Add CHANGELOG for 2.0.2

Rename "IPv6 mapped IPv4 addresses" to their correct name from RFC4191: "IPv4-mapped IPv6 address"
(cherry picked from commit 4d8fec3b67) Conflicts: src/core/ipv6/ip6.c
2017-03-13 10:26:42 +01:00 · 2017-03-13 09:28:46 +01:00 · 2017-03-13 09:14:38 +01:00 · 2017-03-13 09:14:24 +01:00 · 2017-03-13 09:14:23 +01:00 · 2017-03-13 09:14:22 +01:00
299 changed files with 13002 additions and 43159 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -16,4 +16,3 @@
 /test/fuzz/output
 /test/fuzz/lwip_fuzz
 /test/fuzz/.depend
-/build
--- a/256
+++ b/256
@@ -1,262 +1,9 @@
 HISTORY
- * These are only the most important changes. For a full list, use git log:
-   http://git.savannah.nongnu.org/cgit/lwip.git

 (git master)

  * [Enter new changes just after this line - do not remove this line]

-(STABLE-2.1.1):
-
-  ++ Bugfixes:
-
-  2018-11-01: Joan Lledó
-  * sockets.c: fix bad assertion in lwip_poll_dec_sockets_used() (bug #54933)
-
-  2018-11-01: Dirk Ziegelmeier
-  * ip4.c: don't send 127.* to default netif (bug #54670)
-
-  2018-10-23: David Girault
-  * altcp_tls_mbedtls.c: fix use-after free (bug #54774)
-
-  2018-10-23: Ognjen Bjelica, Dirk Ziegelmeier
-  * snmp_scalar.c: Avoid NULL pointer dereference (bug #54886)
-
-  2018-10-23: Simon Goldschmidt
-  * Fix missing standard includes in multiple files
-
-  2018-10-17: Ivan Warren
-  * def.h: fix casting htonX and ntohX to u16_t (bug #54850)
-
-  2018-10-12: Simon Goldschmidt
-  * Revert "tcp_abandon: no need to buffer pcb->local_port" (fix that source port was 0 for RST
-    called when aborting a connection)
-
-  2018-10-11: Jonas Rabenstein
-  * tcp.c: tcp_recved: check for overflow and warn about too big values (patch #9699)              
-
-  2018-10-06: Joan Lledó
-  * sockets.c: alloc_socket(): Check for LWIP_SOCKET_POLL when setting select-
-    related variables (patch #9696)
-
-  2018-10-04: Spencer
-  * tcp.c: Update prev pointer when skipping entries in tcp_slowtmr (patch #9694)
-
-  2018-09-27: Martine Lenders
-  * lowpan6.c: Fix IEEE 802.15.4 address setting (bug #54749)
-
-(STABLE-2.1.0):
-
-  ++ New features:
-
-  2018-06-17: Simon Goldschmidt
-  * lwiperf: implemented iPerf client mode
-
-  2018-04-23: Dirk Ziegelmeier
-  * added cmake build files
-
-  2018-03-04: Ray Abram
-  * netbios responder: respond to '*' queries
-
-  2018-02-23: Benjamin Aigner
-  * 6lowpan: add 6lowpan-over-BLE netif (based on existing 6lowpan netif)
-
-  2018-02-22: Simon Goldschmidt
-  * ipv6: add support for stateless DHCPv6 (to get DNS servers in SLAAC nets)
-
-  2018-02-16: Simon Goldschmidt
-  * add raw API http(s) client (with proxy support)
-
-  2018-02-01: Simon Goldschmidt
-  * tcp: add hooks to implement additional socket options
-
-  2018-02-01: Simon Goldschmidt
-  * tcp: add hooks to implement tcp md5 signatures or similar (see contrib/addons for an example)
-
-  2018-01-05: Simon Goldschmidt
-  * Added sys_mbox_trypost_fromisr() and tcpip_callbackmsg_trycallback_fromisr()
-    These can be used to post preallocated messages from an ISR to the tcpip thread
-    (e.g. when using FreeRTOS)
-
-  2018-01-02: Dirk Ziegelmeier
-  * task #14780: Add debug helper asserts to ensure threading/locking requirements are met
-
-  2017-11-21: Simon Goldschmidt
-  * task #14600: tcp_alloc(): kill TF_CLOSEPEND connections before other ESTABLISHED
-
-  2017-11-21: Simon Goldschmidt
-  * makefsdata: added option "-ssi:<filename>" to control SSI tag checking/insertion
-    through a list of filenames, not by checking the file extension at runtime
-
-  2017-11-20: Joel Cunningham
-  * netconn: add LWIP_HOOK_NETCONN_EXTERNAL_RESOLVE to use external DNS resolver (patch #9427)
-
-  2017-11-14: Joel Cunningham
-  * netifapi: Add thread safe ARP cache APIs (task #14724)
-
-  2017-11-06: Axel Lin
-  * TCP: kill existing connections with a LOWER priority than the one currently being opened.
-    Previous implementations also kill existing connections of the SAME priority.
-
-  2017-09-21: Kalle Olavi Niemitalo
-  * sockets: add poll() implementation (patch #9450)
-
-  2017-09-10: Joel Cunningham
-  * sockets: add readv() implementation (task #14610)
-
-  2017-08-04: Simon Goldschmidt
-  * Clean up DHCP a bit: no need keep msg_out and msg_in as members in struct
-    dhcp - they are used in a call stack only (p_out and options_out_len as well)
-
-  2017-08-04: Simon Goldschmidt
-  * pbuf: split pbuf_header(s16_t) into pbuf_add_header(size_t) and
-    pbuf_remove_header(size_t)
-
-  2017-07-20: Douglas
-  * sys: deprecate sys_arch_sem_wait and sys_arch_mbox_fetch returning the
-    time waited rather they are now defined to return != SYS_ARCH_TIMEOUT
-    on success.
-
-  2017-07-03: Jakub Schmidtke
-  * tcp: added support for sending TCP SACKs
-
-  2017-06-20: Joel Cunningham
-  * netconn/netdb: added core locking support to netconn_gethostbyname (task #14523)
-
-  2017-04-25: Simon Goldschmidt
-  * dhcp: added two hooks for adding and parsing user defined DHCP options
-
-  2017-04-25: Joel Cunningham
-  * sockets: added recvmsg for UDP (together with CMSG and IP_PKTINFO) (task #14247)
-
-  2017-04-20: Joel Cunningham
-  * tcp: added Appropriate Byte Counting support (task #14128)
-
-  2017-04-11: Simon Goldschmidt
-  * netconn/sockets: remove fatal error handling, fix asynchronous error handling,
-    ensure data before RST can be received
-
-  2017-03-30: Simon Goldschmidt
-  * added "application layered TCP" connection API (altcp) for seamless integration
-    of TLS or proxy connections
-
-  2017-03-09: Simon Goldschmidt
-  * sockets: add recvmsg for TCP
-
-  2017-03-02: Joel Cunningham
-  * netconn/sockets: vectorize netconn_write for TCP, treating a vectored I/O write
-    atomically in regards to TCP segmentation (patch #8882)
-
-  2017-03-02: Simon Goldschmidt
-  * netconn: added nonblocking accept/recv to netconn API (task #14396)
-
-  2017-02-28: Simon Goldschmidt
-  * Added LWIP_SINGLE_NETIF for small targets with only one netif
-
-  2017-02-10: David van Moolenbroek
-  * Implement UDP and RAW multicast support for IPv6 (core API, not netconn/sockets)
-
-  2017-02-04: David van Moolenbroek
-  * IPv6 scopes support
-
-  2017-01-20: Joel Cunningham
-  * sockets: add interface name/index APIs (task #14314)
-  
-  2017-01-08: David van Moolenbroek
-  * Extensions to RAW API (patch #9208)
-    - Connected RAW PCBs
-    - Add raw_sendto_if_src()
-    - Support IP_HDRINCL socket option
-
-  ++ Bugfixes:
-
-  2018-06-19: Simon Goldschmidt
-  * tcp: fix RTO timer not working if link is down
-
-  2018-06-15: Sylvain Rochet
-  * ppp: multiple smaller bugfixes
-
-  2018-05-17: Simon Goldschmidt
-  * etharp: arp table can now be bigger than 127 entries
-
-  2018-04-25: Jens Nielsen
-  * tftp server: correctly handle retransmissions
-
-  2018-04-18: Simon Goldschmidt
-  sockets: fix race conditions when closing full-duplex sockets
-
-  2018-03-09: Simon Goldschmidt
-  * 6lowpan: fix to work against contiki; added ZigBee encapsulation netif for tests
-
-  2018-02-04: Simon Goldschmidt
-  * sockets: fix inconsistencies on close (inconsistent error codes, double FIN)
-
-  2018-01-05: Dirk Ziegelmeier
-  * Fix bug #52748: the bug in timeouts.c by reimplementing timer logic to use
-    absolute instead of relative timeout values
-
-  2017-12-31: Dirk Ziegelmeier
-  * Fix bug #52704: DHCP and bad OFFER: Stop timeout only if offer is accepted
-
-  2017-11-08: Joel Cunningham
-  * netif: ensure link and admin states are up in issue reports (bug #52353)
-
-  2017-09-12: David Lockyer
-  * select: allocate select_cb from memp for LWIP_MPU_COMPATIBLE = 1 (bug #51990)
-
-  2017-09-11: Simon Goldschmidt
-  * tcp_in.c: fix bug #51937 (leaking tcp_pcbs on passive close with unacked data)
-
-  2017-08-11: Joel Cunningham
-  * lwip_itoa: fix converting the number 0 (previously converted to '\0') (bug #51729)
-
-  2017-08-08: Dirk Ziegelmeier
-  * ip4_route_src: parameter order is reversed: ip4_route_src(dest, src) -> ip4_route_src(src, dest)
-    to make parameter order consistent with other ip*_route*() functions
-    Same also applies to LWIP_HOOK_IP4_ROUTE_SRC() parameter order.
-
-  2017-08-04: Joel Cunningham
-  * tcp: re-work persist timer to fully close window (details in bug #50837)
-
-  2017-07-26: Simon Goldschmidt
-  * snmp_msg.c: fix bug #51578 (SNMP failed to decode some values on non 32bit platforms)
-
-  2017-07-20: Simon Goldschmidt
-  * compatibility headers: moved from 'src/include/posix' to 'src/include/compat/posix',
-    'src/include/compat/stdc' etc.
-
-  2017-05-09: Joel Cunningham
-  * tcp: add zero-window probe timeout (bug #50837)
-
-  2017-04-11: Simon Goldschmidt
-  * sockets.c: task #14420 (Remove sys_sem_signal from inside SYS_ARCH_PROTECT
-    crit section) done for LWIP_TCPIP_CORE_LOCKING==1
-
-  2017-02-24: Simon Goldschmidt
-  * sockets.c: fixed close race conditions in lwip_select (for LWIP_NETCONN_FULLDUPLEX)
-
-  2017-02-24: Simon Goldschmidt
-  * sockets.c: fixed that select ignored invalid/not open sockets in the fd_sets (bug #50392)
-
-  2017-01-11: David van Moolenbroek
-  * Lots of IPv6 related fixes and improvements
-
-(STABLE-2.0.3)
-
-  ++ Bugfixes:
-
-  2017-09-11: Simon Goldschmidt
-  * tcp_in.c: fix bug #51937 (leaking tcp_pcbs on passive close with unacked data)
-
-  2017-08-02: Abroz Bizjak/Simon Goldschmidt
-  * multiple fixes in IPv4 reassembly (leading to corrupted datagrams received)
-  
-  2017-03-30: Simon Goldschmidt
-  * dhcp.c: return ERR_VAL instead of asserting on offset-out-of-pbuf
-
-  2017-03-23: Dirk Ziegelmeier
-  * dhcp.h: fix bug #50618 (dhcp_remove_struct() macro does not work)
-
 (STABLE-2.0.2)

  ++ New features:
@@ -266,9 +13,6 @@ HISTORY
    We now have a #define for a header file name that is #included in every .c
    file that provides hooks.

-  2017-02-10: Simon Goldschmidt
-  * tcp_close does not fail on memory error (instead, FIN is sent from tcp_tmr)
-
  ++ Bugfixes:

  2017-03-08
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,20 +0,0 @@
-cmake_minimum_required(VERSION 3.7)
-
-project(lwIP)
-
-set(LWIP_DIR ${CMAKE_CURRENT_SOURCE_DIR})
-include(src/Filelists.cmake)
-
-# Package generation
-set(CPACK_SOURCE_GENERATOR "ZIP")
-set(CPACK_SOURCE_PACKAGE_DESCRIPTION_SUMMARY "lwIP lightweight IP stack")
-set(CPACK_PACKAGE_VERSION_MAJOR "${LWIP_VERSION_MAJOR}")
-set(CPACK_PACKAGE_VERSION_MINOR "${LWIP_VERSION_MINOR}")
-set(CPACK_PACKAGE_VERSION_PATCH "${LWIP_VERSION_REVISION}")
-set(CPACK_SOURCE_IGNORE_FILES "/build/;${CPACK_SOURCE_IGNORE_FILES};.git")
-set(CPACK_SOURCE_PACKAGE_FILE_NAME "lwip-${LWIP_VERSION_MAJOR}.${LWIP_VERSION_MINOR}.${LWIP_VERSION_REVISION}")
-include(CPack)
-
-# Target for package generation
-add_custom_target(dist COMMAND ${CMAKE_MAKE_PROGRAM} package_source)
-add_dependencies(dist lwipdocs)
--- a/11
+++ b/11
@@ -1,11 +0,0 @@
-lwIP is a small independent implementation of the TCP/IP protocol suite targeted at embedded systems.
-
-The focus of the lwIP TCP/IP implementation is to reduce resource usage while still having a full scale TCP. This makes lwIP suitable for use in embedded systems with tens of kilobytes of free RAM and room for around 40 kilobytes of code ROM.
-
-Main features include:
- Protocols: IP, IPv6, ICMP, ND, MLD, UDP, TCP, IGMP, ARP, PPPoS, PPPoE, 6LowPAN (via IEEE 802.15.4, BLE or ZEP; since v2.1.0)
- DHCP client, stateless DHCPv6 (since v2.1.0), DNS client (incl. mDNS hostname resolver), AutoIP/APIPA (Zeroconf), SNMP agent (v1, v2c, v3 (since v2.1.0), private MIB support & MIB compiler)
- APIs: specialized APIs for enhanced performance & zero copy, optional Berkeley-alike socket API
- Extended features: IP forwarding over multiple network interfaces
- Extended TCP features: congestion control, RTT estimation and fast recovery/fast retransmit, sending SACKs (since v2.1.0), "altcp": nearly transparent TLS for any tcp pcb (since v2.1.0)
- Addon applications: HTTP server (HTTPS via altcp), HTTP(S) client (since v2.1.0), SNTP client, SMTP client (SMTPS via altcp), ping, NetBIOS nameserver, mDNS responder, MQTT client (TLS support since v2.1.0), TFTP server, iPerf2 counterpart
--- a/22
+++ b/22
@@ -1,15 +1,15 @@
 INTRODUCTION

-lwIP is a small independent implementation of the TCP/IP protocol suite.
+lwIP is a small independent implementation of the TCP/IP protocol
+suite that has been developed by Adam Dunkels at the Computer and
+Networks Architectures (CNA) lab at the Swedish Institute of Computer
+Science (SICS).

 The focus of the lwIP TCP/IP implementation is to reduce the RAM usage
 while still having a full scale TCP. This making lwIP suitable for use
 in embedded systems with tens of kilobytes of free RAM and room for
 around 40 kilobytes of code ROM.

-lwIP was originally developed by Adam Dunkels at the Computer and Networks
-Architectures (CNA) lab at the Swedish Institute of Computer Science (SICS)
-and is now developed and maintained by a worldwide network of developers.

 FEATURES

@@ -22,28 +22,22 @@ FEATURES
  * ND (Neighbor discovery and stateless address autoconfiguration for IPv6).
    Aims to be compliant with RFC 4861 (Neighbor discovery) and RFC 4862
    (Address autoconfiguration)
-  * DHCP, AutoIP/APIPA (Zeroconf) and (stateless) DHCPv6
  * UDP (User Datagram Protocol) including experimental UDP-lite extensions
  * TCP (Transmission Control Protocol) with congestion control, RTT estimation
-    fast recovery/fast retransmit and sending SACKs
+    and fast recovery/fast retransmit
  * raw/native API for enhanced performance
  * Optional Berkeley-like socket API
-  * TLS: optional layered TCP ("altcp") for nearly transparent TLS for any
-    TCP-based protocol (ported to mbedTLS) (see changelog for more info)
-  * PPPoS and PPPoE (Point-to-point protocol over Serial/Ethernet)
-  * DNS (Domain name resolver incl. mDNS)
-  * 6LoWPAN (via IEEE 802.15.4, BLE or ZEP)
+  * DNS (Domain names resolver)


 APPLICATIONS

-  * HTTP server with SSI and CGI (HTTPS via altcp)
-  * SNMPv2c agent with MIB compiler (Simple Network Management Protocol), v3 via altcp
+  * HTTP server with SSI and CGI
+  * SNMPv2c agent with MIB compiler (Simple Network Management Protocol)
  * SNTP (Simple network time protocol)
  * NetBIOS name service responder
  * MDNS (Multicast DNS) responder
  * iPerf server implementation
-  * MQTT client (TLS support via altcp)


 LICENSE
--- a/47
+++ b/47
@@ -8,51 +8,8 @@ with newer versions.

  * [Enter new changes just after this line - do not remove this line]

-(2.1.0)
-
-  ++ Application changes:
-
-  * Use the new altcp API for seamless TLS integration into existing TCP applications (see changelog)
-  * TCP only kills existing connections with a LOWER priority than the one currently being opened.
-    Previous implementations also kill existing connections of the SAME priority.
-  * ip4_route_src: parameter order is reversed: ip4_route_src(dest, src) -> ip4_route_src(src, dest)
-    to make parameter order consistent with other ip*_route*() functions.
-    Same also applies to LWIP_HOOK_IP4_ROUTE_SRC() parameter order.
-  * pbuf API: pbuf->type (an u8_t holding the enum 'pbuf_type') has changed to only hold a
-    description of the pbuf (e.g. data following pbuf struct, data volatile, allocation
-    source heap/pool/etc.). As a consequence, applications can't test pbuf->type any more.
-    Use pbuf_match_type(pbuf, type) instead.
-  * socket API: according to the standard, SO_ERROR now only returns asynchronous errors.
-    All other/normal/synchronous errors are (and always were) available via 'errno'.
-    LWIP_SOCKET_SET_ERRNO has been removed - 'errno' is always set - and required!
-  * httpd LWIP_HTTPD_CGI_SSI: httpd_cgi_handler() has an additional parameter "struct fs_file *"
-
-  ++ Port changes:
-
-  * tcpip_trycallback() was renamed to tcpip_callbackmsg_trycallback() to avoid confusion
-    with tcpip_try_callback()
-  * compatibility headers: moved from 'src/include/posix' to 'src/include/compat/posix',
-    'src/include/compat/stdc' etc.
-  * The IPv6 implementation now supports address scopes. (See LWIP_IPV6_SCOPES documentation
-    and ip6_zone.h for more documentation)
-  * LWIP_HOOK_DHCP_APPEND_OPTIONS() has changed, see description in opt.h (options_out_len is not
-    available in struct dhcp any more)
-  * Added debug helper asserts to ensure threading/locking requirements are met (define
-    LWIP_MARK_TCPIP_THREAD() and LWIP_ASSERT_CORE_LOCKED()).
-  * Added sys_mbox_trypost_fromisr() and tcpip_callbackmsg_trycallback_fromisr()
-    These can be used to post preallocated messages from an ISR to the tcpip thread
-    (e.g. when using FreeRTOS)
-
-(2.0.2)
-
-  ++ Application changes:
-
-  * slipif: The way to pass serial port number has changed. netif->num is not
-    supported any more, netif->state is interpreted as an u8_t port number now
-    (it's not a POINTER to an u8_t any more!)
-
-(2.0.1)
-
+(2.0.1)
+
  ++ Application changes:

  * UDP does NOT receive multicast traffic from ALL netifs on an UDP PCB bound to a specific
--- a/doc/NO_SYS_SampleCode.c
+++ b/doc/NO_SYS_SampleCode.c
@@ -1,5 +1,4 @@
-void
-eth_mac_irq()
+void eth_mac_irq()
 {
  /* Service MAC IRQ here */

@@ -18,8 +17,7 @@ eth_mac_irq()
  }
 }

-static err_t 
-netif_output(struct netif *netif, struct pbuf *p)
+static err_t netif_output(struct netif *netif, struct pbuf *p)
 {
  LINK_STATS_INC(link.xmit);

@@ -40,14 +38,12 @@ netif_output(struct netif *netif, struct pbuf *p)
  return ERR_OK;
 }

-static void 
-netif_status_callback(struct netif *netif)
+static void netif_status_callback(struct netif *netif)
 {
  printf("netif status changed %s\n", ip4addr_ntoa(netif_ip4_addr(netif)));
 }

-static err_t 
-netif_init(struct netif *netif)
+static err_t netif_init(struct netif *netif)
 {
  netif->linkoutput = netif_output;
  netif->output     = etharp_output;
@@ -56,14 +52,13 @@ netif_init(struct netif *netif)
  netif->flags      = NETIF_FLAG_BROADCAST | NETIF_FLAG_ETHARP | NETIF_FLAG_ETHERNET | NETIF_FLAG_IGMP | NETIF_FLAG_MLD6;
  MIB2_INIT_NETIF(netif, snmp_ifType_ethernet_csmacd, 100000000);

-  SMEMCPY(netif->hwaddr, your_mac_address_goes_here, ETH_HWADDR_LEN);
-  netif->hwaddr_len = ETH_HWADDR_LEN;
+  SMEMCPY(netif->hwaddr, your_mac_address_goes_here, sizeof(netif->hwaddr));
+  netif->hwaddr_len = sizeof(netif->hwaddr);

  return ERR_OK;
 }

-void 
-main(void)
+void main(void)
 {
  struct netif netif;

@@ -79,7 +74,7 @@ main(void)
  netif_set_up(&netif);
  
  /* Start DHCP and HTTPD */
-  dhcp_start(&netif );
+  dhcp_init();
  httpd_init();

  while(1) {
--- a/doc/ZeroCopyRx.c
+++ b/doc/ZeroCopyRx.c
@@ -1,45 +0,0 @@
-typedef struct my_custom_pbuf
-{
-   struct pbuf_custom p;
-   void* dma_descriptor;
-} my_custom_pbuf_t;
-
-LWIP_MEMPOOL_DECLARE(RX_POOL, 10, sizeof(my_custom_pbuf_t), "Zero-copy RX PBUF pool");
-
-void my_pbuf_free_custom(void* p)
-{
-  SYS_ARCH_DECL_PROTECT(old_level);
-
-  my_custom_pbuf_t* my_puf = (my_custom_pbuf_t*)p;
-
-  // invalidate data cache here - lwIP and/or application may have written into buffer!
-  // (invalidate is faster than flushing, and noone needs the correct data in the buffer)
-  invalidate_cpu_cache(p->payload, p->tot_len);
-
-  SYS_ARCH_PROTECT(old_level);
-  free_rx_dma_descriptor(my_pbuf->dma_descriptor);
-  LWIP_MEMPOOL_FREE(RX_POOL, my_pbuf);
-  SYS_ARCH_UNPROTECT(old_level);
-}
-
-void eth_rx_irq()
-{
-  dma_descriptor*   dma_desc = get_RX_DMA_descriptor_from_ethernet();
-  my_custom_pbuf_t* my_pbuf  = (my_custom_pbuf_t*)LWIP_MEMPOOL_ALLOC(RX_POOL);
-
-  my_pbuf->p.custom_free_function = my_pbuf_free_custom;
-  my_pbuf->dma_descriptor         = dma_desc;
-
-  invalidate_cpu_cache(dma_desc->rx_data, dma_desc->rx_length);
-  
-  struct pbuf* p = pbuf_alloced_custom(PBUF_RAW,
-     dma_desc->rx_length,
-     PBUF_REF,
-     &my_pbuf->p,
-     dma_desc->rx_data,
-     dma_desc->max_buffer_size);
-
-  if(netif->input(p, netif) != ERR_OK) {
-    pbuf_free(p);
-  }
-}
--- a/doc/doxygen/lwip.Doxyfile
+++ b/doc/doxygen/lwip.Doxyfile
@@ -1,4 +1,4 @@
-# Doxyfile 1.8.13
+# Doxyfile 1.8.11

 # This file describes the settings to be used by the documentation system
 # doxygen (www.doxygen.org) for a project.
@@ -38,7 +38,7 @@ PROJECT_NAME           = "lwIP"
 # could be handy for archiving the generated documentation or if some version
 # control system is used.

-PROJECT_NUMBER         = "2.1.1"
+PROJECT_NUMBER         = "2.0.2"

 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a
@@ -58,7 +58,7 @@ PROJECT_LOGO           =
 # entered, it will be relative to the location where doxygen was started. If
 # left blank the current directory will be used.

-OUTPUT_DIRECTORY       = "output"
+OUTPUT_DIRECTORY       = output

 # If the CREATE_SUBDIRS tag is set to YES then doxygen will create 4096 sub-
 # directories (in 2 levels) under the output directory of each output format and
@@ -303,15 +303,6 @@ EXTENSION_MAPPING      =

 MARKDOWN_SUPPORT       = YES

-# When the TOC_INCLUDE_HEADINGS tag is set to a non-zero value, all headings up
-# to that level are automatically included in the table of contents, even if
-# they do not have an id attribute.
-# Note: This feature currently applies only to Markdown headings.
-# Minimum value: 0, maximum value: 99, default value: 0.
-# This tag requires that the tag MARKDOWN_SUPPORT is set to YES.
-
-TOC_INCLUDE_HEADINGS   = 0
-
 # When enabled doxygen tries to link words that correspond to documented
 # classes, or namespaces to their corresponding documentation. Such a link can
 # be prevented in individual cases by putting a % sign in front of the word or
@@ -790,8 +781,7 @@ WARN_LOGFILE           =
 # spaces. See also FILE_PATTERNS and EXTENSION_MAPPING
 # Note: If this tag is empty the current directory is searched.

-INPUT                  = main_page.h \
-                         ../../src
+INPUT                  = main_page.h ../../src

 # This tag can be used to specify the character encoding of the source files
 # that doxygen parses. Internally doxygen uses the UTF-8 encoding. Doxygen uses
@@ -813,8 +803,8 @@ INPUT_ENCODING         = UTF-8
 # If left blank the following patterns are tested:*.c, *.cc, *.cxx, *.cpp,
 # *.c++, *.java, *.ii, *.ixx, *.ipp, *.i++, *.inl, *.idl, *.ddl, *.odl, *.h,
 # *.hh, *.hxx, *.hpp, *.h++, *.cs, *.d, *.php, *.php4, *.php5, *.phtml, *.inc,
-# *.m, *.markdown, *.md, *.mm, *.dox, *.py, *.pyw, *.f90, *.f95, *.f03, *.f08,
-# *.f, *.for, *.tcl, *.vhd, *.vhdl, *.ucf and *.qsf.
+# *.m, *.markdown, *.md, *.mm, *.dox, *.py, *.pyw, *.f90, *.f, *.for, *.tcl,
+# *.vhd, *.vhdl, *.ucf, *.qsf, *.as and *.js.

 FILE_PATTERNS          = *.c \
                         *.cc \
@@ -885,8 +875,7 @@ EXCLUDE_SYMBOLS        =
 # that contain example code fragments that are included (see the \include
 # command).

-EXAMPLE_PATH           = ../ \
-                         ../../
+EXAMPLE_PATH           = ../ ../../

 # If the value of the EXAMPLE_PATH tag contains directories, you can use the
 # EXAMPLE_PATTERNS tag to specify one or more wildcard pattern (like *.cpp and
@@ -2088,26 +2077,16 @@ PREDEFINED             = __DOXYGEN__=1 \
                         LWIP_ICMP=1 \
                         LWIP_RAW=1 \
                         LWIP_DHCP=1 \
-                         LWIP_IPV6_DHCP6=1 \
                         LWIP_UDPLITE=1 \
                         LWIP_UDP=1 \
                         LWIP_IGMP=1 \
                         LWIP_TCP=1 \
-                         LWIP_ALTCP=1 \
-                         LWIP_ALTCP_TLS=1 \
-                         LWIP_IPV6_SCOPES=1 \
                         TCP_LISTEN_BACKLOG=1 \
                         LWIP_SNMP=1 \
                         SNMP_USE_NETCONN=1 \
                         SNMP_USE_RAW=1 \
                         MIB2_STATS=1 \
                         LWIP_MDNS_RESPONDER=1 \
-                         HTTPD_ENABLE_HTTPS=1 \
-                         LWIP_HTTPD_CGI=1 \
-                         LWIP_HTTPD_SSI=1 \
-                         LWIP_HTTPD_SSI_RAW=1 \
-                         LWIP_HTTPD_SUPPORT_POST=1 \
-                         LWIP_HTTPD_POST_MANUAL_WND=1 \
                         MEMP_OVERFLOW_CHECK=0 \
                         MEMP_SANITY_CHECK=1 \
                         LWIP_ARP=1 \
@@ -2118,7 +2097,6 @@ PREDEFINED             = __DOXYGEN__=1 \
                         LWIP_NETIF_STATUS_CALLBACK=1 \
                         LWIP_NETIF_REMOVE_CALLBACK=1 \
                         LWIP_NETIF_LINK_CALLBACK=1 \
-                         LWIP_NETIF_EXT_STATUS_CALLBACK=1 \
                         LWIP_NUM_NETIF_CLIENT_DATA=1 \
                         ENABLE_LOOPBACK=1 \
                         LWIP_AUTOIP=1 \
@@ -2137,9 +2115,8 @@ PREDEFINED             = __DOXYGEN__=1 \
                         SO_REUSE=1 \
                         SO_REUSE_RXTOALL=1 \
                         LWIP_HAVE_SLIPIF=1 \
-                         SLIP_RX_FROM_ISR=1 \
-                         LWIP_TCP_PCB_NUM_EXT_ARGS=1
-
+                         LWIP_6LOWPAN=1
+ 
 # If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this
 # tag can be used to specify a list of macro names that should be expanded. The
 # macro definition that is found in the sources will be used. Use the PREDEFINED
@@ -2251,7 +2228,7 @@ HIDE_UNDOC_RELATIONS   = YES
 # http://www.graphviz.org/), a graph visualization toolkit from AT&T and Lucent
 # Bell Labs. The other options in this section have no effect if this option is
 # set to NO
-# The default value is: NO.
+# The default value is: YES.

 HAVE_DOT               = NO

@@ -2407,7 +2384,9 @@ DIRECTORY_GRAPH        = YES
 # Note: If you choose svg you need to set HTML_FILE_EXTENSION to xhtml in order
 # to make the SVG files visible in IE 9+ (other browsers do not have this
 # requirement).
-# Possible values are: png, jpg, gif, svg, png:gd, png:gd:gd, png:cairo,
+# Possible values are: png, png:cairo, png:cairo:cairo, png:cairo:gd, png:gd,
+# png:gd:gd, jpg, jpg:cairo, jpg:cairo:gd, jpg:gd, jpg:gd:gd, gif, gif:cairo,
+# gif:cairo:gd, gif:gd, gif:gd:gd, svg, png:gd, png:gd:gd, png:cairo,
 # png:cairo:gd, png:cairo:cairo, png:cairo:gdiplus, png:gdiplus and
 # png:gdiplus:gdiplus.
 # The default value is: png.
@@ -2460,11 +2439,6 @@ DIAFILE_DIRS           =

 PLANTUML_JAR_PATH      =

-# When using plantuml, the PLANTUML_CFG_FILE tag can be used to specify a
-# configuration file for plantuml.
-
-PLANTUML_CFG_FILE      =
-
 # When using plantuml, the specified paths are searched for files specified by
 # the !include statement in a plantuml block.

--- a/doc/doxygen/lwip.Doxyfile.cmake.in
+++ b/doc/doxygen/lwip.Doxyfile.cmake.in
--- a/doc/doxygen/main_page.h
+++ b/doc/doxygen/main_page.h
@@ -1,90 +1,17 @@
-/**
+/**
 * @defgroup lwip lwIP
 *
 * @defgroup infrastructure Infrastructure
- * 
- * @defgroup api APIs
- * lwIP provides three Application Program's Interfaces (APIs) for programs
- * to use for communication with the TCP/IP code:
- * - low-level "core" / "callback" or @ref callbackstyle_api.
- * - higher-level @ref sequential_api.
- * - BSD-style @ref socket.
- * 
- * The raw TCP/IP interface allows the application program to integrate
- * better with the TCP/IP code. Program execution is event based by
- * having callback functions being called from within the TCP/IP
- * code. The TCP/IP code and the application program both run in the same
- * thread. The sequential API has a much higher overhead and is not very
- * well suited for small systems since it forces a multithreaded paradigm
- * on the application.
- * 
- * The raw TCP/IP interface is not only faster in terms of code execution
- * time but is also less memory intensive. The drawback is that program
- * development is somewhat harder and application programs written for
- * the raw TCP/IP interface are more difficult to understand. Still, this
- * is the preferred way of writing applications that should be small in
- * code size and memory usage.
- * 
- * All APIs can be used simultaneously by different application
- * programs. In fact, the sequential API is implemented as an application
- * program using the raw TCP/IP interface.
- * 
- * Do not confuse the lwIP raw API with raw Ethernet or IP sockets.
- * The former is a way of interfacing the lwIP network stack (including
- * TCP and UDP), the latter refers to processing raw Ethernet or IP data
- * instead of TCP connections or UDP packets.
- * 
- * Raw API applications may never block since all packet processing
- * (input and output) as well as timer processing (TCP mainly) is done
- * in a single execution context.
 *
- * @defgroup callbackstyle_api "raw" APIs
- * @ingroup api
+ * @defgroup callbackstyle_api Callback-style APIs
 * Non thread-safe APIs, callback style for maximum performance and minimum
 * memory footprint.
- * Program execution is driven by callbacks functions, which are then
- * invoked by the lwIP core when activity related to that application
- * occurs. A particular application may register to be notified via a
- * callback function for events such as incoming data available, outgoing
- * data sent, error notifications, poll timer expiration, connection
- * closed, etc. An application can provide a callback function to perform
- * processing for any or all of these events. Each callback is an ordinary
- * C function that is called from within the TCP/IP code. Every callback
- * function is passed the current TCP or UDP connection state as an
- * argument. Also, in order to be able to keep program specific state,
- * the callback functions are called with a program specified argument
- * that is independent of the TCP/IP state.
- * The raw API (sometimes called native API) is an event-driven API designed
- * to be used without an operating system that implements zero-copy send and
- * receive. This API is also used by the core stack for interaction between
- * the various protocols. It is the only API available when running lwIP
- * without an operating system.
 * 
 * @defgroup sequential_api Sequential-style APIs
- * @ingroup api
 * Sequential-style APIs, blocking functions. More overhead, but can be called
 * from any thread except TCPIP thread.
- * The sequential API provides a way for ordinary, sequential, programs
- * to use the lwIP stack. It is quite similar to the BSD socket API. The
- * model of execution is based on the blocking open-read-write-close
- * paradigm. Since the TCP/IP stack is event based by nature, the TCP/IP
- * code and the application program must reside in different execution
- * contexts (threads).
 * 
- * @defgroup socket Socket API
- * @ingroup api
- * BSD-style socket API.\n
- * Thread-safe, to be called from non-TCPIP threads only.\n
- * Can be activated by defining @ref LWIP_SOCKET to 1.\n
- * Header is in posix/sys/socket.h\n
- * The socket API is a compatibility API for existing applications,
- * currently it is built on top of the sequential API. It is meant to
- * provide all functions needed to run socket API applications running
- * on other platforms (e.g. unix / windows etc.). However, due to limitations
- * in the specification of this API, there might be incompatibilities
- * that require small modifications of existing programs.
- * 
- * @defgroup netifs NETIFs
+ * @defgroup addons Addons
 * 
 * @defgroup apps Applications
 */
@@ -101,20 +28,6 @@

 /**
 * @page changelog Changelog
- *
- * 2.1.0
- * -----
- * * Support TLS via new @ref altcp_api connection API (https, smtps, mqtt over TLS)
- * * Switch to cmake as the main build system (Makefile file lists are still
- *   maintained for now)
- * * Improve IPv6 support: support address scopes, support stateless DHCPv6, bugfixes
- * * Add debug helper asserts to ensure threading/locking requirements are met
- * * Add sys_mbox_trypost_fromisr() and tcpip_callbackmsg_trycallback_fromisr()
- *   (for FreeRTOS, mainly)
- * * socket API: support poll(), sendmsg() and recvmsg(); fix problems on close
- * 
- * Detailed Changelog
- * ------------------
 * @verbinclude "CHANGELOG"
 */

@@ -135,8 +48,6 @@
 * lwIP can be used in two basic modes: @ref lwip_nosys (no OS/RTOS 
 * running on target system) or @ref lwip_os (there is an OS running
 * on the target system).
- * 
- * See also: @ref multithreading (especially the part about @ref LWIP_ASSERT_CORE_LOCKED()!)
 *
 * Mainloop Mode
 * -------------
@@ -180,28 +91,6 @@
 *    @ref LOCK_TCPIP_CORE() and @ref UNLOCK_TCPIP_CORE().
 *    These macros cannot be used in an interrupt context!
 *    Note the OS must correctly handle priority inversion for this.
- *
- * Cache / DMA issues
- * ==================
- *
- * DMA-capable ethernet hardware and zero-copy RX
- * ----------------------------------------------
- * 
- * lwIP changes the content of RECEIVED pbufs in the TCP code path.
- * This implies one or more cacheline(s) of the RX pbuf become dirty
- * and need to be flushed before the memory is handed over to the
- * DMA ethernet hardware for the next telegram to be received.
- * See http://lists.nongnu.org/archive/html/lwip-devel/2017-12/msg00070.html
- * for a more detailed explanation.
- * Also keep in mind the user application may also write into pbufs,
- * so it is generally a bug not to flush the data cache before handing
- * a buffer to DMA hardware.
- *
- * DMA-capable ethernet hardware and cacheline alignment
- * -----------------------------------------------------
- * Nice description about DMA capable hardware and buffer handling:
- * http://www.pebblebay.com/a-guide-to-using-direct-memory-access-in-embedded-systems-part-two/
- * Read especially sections "Cache coherency" and "Buffer alignment".
 */

 /**
@@ -211,12 +100,6 @@
 * https://savannah.nongnu.org/bugs/?group=lwip
 */

-/**
- * @page zerocopyrx Zero-copy RX
- * The following code is an example for zero-copy RX ethernet driver:
- * @include ZeroCopyRx.c
- */
-
 /**
 * @defgroup lwip_nosys Mainloop mode ("NO_SYS")
 * @ingroup lwip
@@ -244,160 +127,6 @@
 */

 /**
- * @page sys_init System initalization
-A truly complete and generic sequence for initializing the lwIP stack
-cannot be given because it depends on additional initializations for
-your runtime environment (e.g. timers).
-
-We can give you some idea on how to proceed when using the raw API.
-We assume a configuration using a single Ethernet netif and the
-UDP and TCP transport layers, IPv4 and the DHCP client.
-
-Call these functions in the order of appearance:
-
- lwip_init(): Initialize the lwIP stack and all of its subsystems.
-
- netif_add(struct netif *netif, ...):
-  Adds your network interface to the netif_list. Allocate a struct
-  netif and pass a pointer to this structure as the first argument.
-  Give pointers to cleared ip_addr structures when using DHCP,
-  or fill them with sane numbers otherwise. The state pointer may be NULL.
-
-  The init function pointer must point to a initialization function for
-  your Ethernet netif interface. The following code illustrates its use.
-  
-@code{.c}
-  err_t netif_if_init(struct netif *netif)
-  {
-    u8_t i;
-    
-    for (i = 0; i < ETHARP_HWADDR_LEN; i++) {
-      netif->hwaddr[i] = some_eth_addr[i];
-    }
-    init_my_eth_device();
-    return ERR_OK;
-  }
-@endcode
-  
-  For Ethernet drivers, the input function pointer must point to the lwIP
-  function ethernet_input() declared in "netif/etharp.h". Other drivers
-  must use ip_input() declared in "lwip/ip.h".
-  
- netif_set_default(struct netif *netif)
-  Registers the default network interface.
-
- netif_set_link_up(struct netif *netif)
-  This is the hardware link state; e.g. whether cable is plugged for wired
-  Ethernet interface. This function must be called even if you don't know
-  the current state. Having link up and link down events is optional but
-  DHCP and IPv6 discover benefit well from those events.
-
- netif_set_up(struct netif *netif)
-  This is the administrative (= software) state of the netif, when the
-  netif is fully configured this function must be called.
-
- dhcp_start(struct netif *netif)
-  Creates a new DHCP client for this interface on the first call.
-  You can peek in the netif->dhcp struct for the actual DHCP status.
-
- sys_check_timeouts()
-  When the system is running, you have to periodically call
-  sys_check_timeouts() which will handle all timers for all protocols in
-  the stack; add this to your main loop or equivalent.
- */
-
-/**
- * @page multithreading Multithreading
- * lwIP started targeting single-threaded environments. When adding multi-
- * threading support, instead of making the core thread-safe, another
- * approach was chosen: there is one main thread running the lwIP core
- * (also known as the "tcpip_thread"). When running in a multithreaded
- * environment, raw API functions MUST only be called from the core thread
- * since raw API functions are not protected from concurrent access (aside
- * from pbuf- and memory management functions). Application threads using
- * the sequential- or socket API communicate with this main thread through
- * message passing.
- * 
- * As such, the list of functions that may be called from
- * other threads or an ISR is very limited! Only functions
- * from these API header files are thread-safe:
- * - api.h
- * - netbuf.h
- * - netdb.h
- * - netifapi.h
- * - pppapi.h
- * - sockets.h
- * - sys.h
- * 
- * Additionaly, memory (de-)allocation functions may be
- * called from multiple threads (not ISR!) with NO_SYS=0
- * since they are protected by @ref SYS_LIGHTWEIGHT_PROT and/or
- * semaphores.
- * 
- * Netconn or Socket API functions are thread safe against the
- * core thread but they are not reentrant at the control block
- * granularity level. That is, a UDP or TCP control block must
- * not be shared among multiple threads without proper locking.
- * 
- * If @ref SYS_LIGHTWEIGHT_PROT is set to 1 and
- * @ref LWIP_ALLOW_MEM_FREE_FROM_OTHER_CONTEXT is set to 1,
- * pbuf_free() may also be called from another thread or
- * an ISR (since only then, mem_free - for PBUF_RAM - may
- * be called from an ISR: otherwise, the HEAP is only
- * protected by semaphores).
- * 
- * How to get threading done right
- * -------------------------------
- * 
- * It is strongly recommended to implement the LWIP_ASSERT_CORE_LOCKED()
- * macro in an application that uses multithreading. lwIP code has
- * several places where a check for a correct thread context is
- * implemented which greatly helps the user to get threading done right.
- * See the example sys_arch.c files in unix and Win32 port 
- * in the contrib repository.
- * 
- * In short: Copy the functions sys_mark_tcpip_thread() and 
- * sys_check_core_locking() to your port and modify them to work with your OS.
- * Then let @ref LWIP_ASSERT_CORE_LOCKED() and @ref LWIP_MARK_TCPIP_THREAD()
- * point to these functions.
- * 
- * If you use @ref LWIP_TCPIP_CORE_LOCKING, you also need to copy and adapt
- * the functions sys_lock_tcpip_core() and sys_unlock_tcpip_core().
- * Let @ref LOCK_TCPIP_CORE() and @ref UNLOCK_TCPIP_CORE() point 
- * to these functions. 
- */
-
-/**
- * @page optimization Optimization hints
-The first thing you want to optimize is the lwip_standard_checksum()
-routine from src/core/inet.c. You can override this standard
-function with the \#define LWIP_CHKSUM your_checksum_routine().
-
-There are C examples given in inet.c or you might want to
-craft an assembly function for this. RFC1071 is a good
-introduction to this subject.
-
-Other significant improvements can be made by supplying
-assembly or inline replacements for htons() and htonl()
-if you're using a little-endian architecture.
-\#define lwip_htons(x) your_htons()
-\#define lwip_htonl(x) your_htonl()
-If you \#define them to htons() and htonl(), you should
-\#define LWIP_DONT_PROVIDE_BYTEORDER_FUNCTIONS to prevent lwIP from
-defining htonx / ntohx compatibility macros.
-
-Check your network interface driver if it reads at
-a higher speed than the maximum wire-speed. If the
-hardware isn't serviced frequently and fast enough
-buffer overflows are likely to occur.
-
-E.g. when using the cs8900 driver, call cs8900if_service(ethif)
-as frequently as possible. When using an RTOS let the cs8900 interrupt
-wake a high priority task that services your driver using a binary
-semaphore or event flag. Some drivers might allow additional tuning
-to match your application and network.
-
-For a production release it is recommended to set LWIP_STATS to 0.
-Note that speed performance isn't influenced much by simply setting
-high values to the memory options.
+ * @page raw_api lwIP API
+ * @verbinclude "rawapi.txt"
 */
--- a/doc/mdns.txt
+++ b/doc/mdns.txt
@@ -32,8 +32,8 @@ generated.
 The MDNS code puts its structs on the stack where suitable to reduce dynamic
 memory allocation. It may use up to 1kB of stack.

-MDNS (like other apps) needs a strncasecmp() implementation. If you have one, define
-'lwip_strnicmp' to it. Otherwise the code will provide an implementation
+MDNS needs a strncasecmp() implementation. If you have one, define
+LWIP_MDNS_STRNCASECMP to it. Otherwise the code will provide an implementation
 for you.


@@ -57,11 +57,11 @@ Answers will use the supplied TTL (in seconds)
 MDNS allows UTF-8 names, but it is recommended to stay within ASCII,
 since the default case-insensitive comparison assumes this.

-Call mdns_resp_announce() every time the IP address on the netif has changed.
+It is recommended to call this function after an IPv4 address has been set,
+since there is currently no check if the v4 address is valid.

-Call mdns_resp_restart() every time the network interface comes up after being
-down, for example cable connected after being disconnected, administrative 
-interface comes up after being down, or the device wakes up from sleep.
+Call mdns_resp_netif_settings_changed() every time the IP address
+on the netif has changed.

 To stop responding on a netif, run
  mdns_resp_remove_netif(struct netif *netif)
@@ -108,5 +108,6 @@ and point them to <hostname>.local:80
 Relevant information will be sent as additional records to reduce number of
 requests required from a client.

-To remove a service from a netif, run
-  mdns_resp_del_service(struct netif *netif, s8_t slot)
+Removing services is currently not supported. Services are removed when the
+netif is removed.
+
--- a/doc/mqtt_client.txt
+++ b/doc/mqtt_client.txt
@@ -40,7 +40,7 @@ void example_do_connect(mqtt_client_t *client)
  
  err = mqtt_client_connect(client, ip_addr, MQTT_PORT, mqtt_connection_cb, 0, &ci);
  
-  /* For now just print the result code if something goes wrong */
+  /* For now just print the result code if something goes wrong
  if(err != ERR_OK) {
    printf("mqtt_connect return %d\n", err);
  }
--- a/doc/rawapi.txt
+++ b/doc/rawapi.txt
@@ -0,0 +1,499 @@
+Raw TCP/IP interface for lwIP
+
+Authors: Adam Dunkels, Leon Woestenberg, Christiaan Simons
+
+lwIP provides three Application Program's Interfaces (APIs) for programs
+to use for communication with the TCP/IP code:
+* low-level "core" / "callback" or "raw" API.
+* higher-level "sequential" API.
+* BSD-style socket API.
+
+The raw API (sometimes called native API) is an event-driven API designed
+to be used without an operating system that implements zero-copy send and
+receive. This API is also used by the core stack for interaction between
+the various protocols. It is the only API available when running lwIP
+without an operating system.
+
+The sequential API provides a way for ordinary, sequential, programs
+to use the lwIP stack. It is quite similar to the BSD socket API. The
+model of execution is based on the blocking open-read-write-close
+paradigm. Since the TCP/IP stack is event based by nature, the TCP/IP
+code and the application program must reside in different execution
+contexts (threads).
+
+The socket API is a compatibility API for existing applications,
+currently it is built on top of the sequential API. It is meant to
+provide all functions needed to run socket API applications running
+on other platforms (e.g. unix / windows etc.). However, due to limitations
+in the specification of this API, there might be incompatibilities
+that require small modifications of existing programs.
+
+** Multithreading
+
+lwIP started targeting single-threaded environments. When adding multi-
+threading support, instead of making the core thread-safe, another
+approach was chosen: there is one main thread running the lwIP core
+(also known as the "tcpip_thread"). When running in a multithreaded
+environment, raw API functions MUST only be called from the core thread
+since raw API functions are not protected from concurrent access (aside
+from pbuf- and memory management functions). Application threads using
+the sequential- or socket API communicate with this main thread through
+message passing.
+
+      As such, the list of functions that may be called from
+      other threads or an ISR is very limited! Only functions
+      from these API header files are thread-safe:
+      - api.h
+      - netbuf.h
+      - netdb.h
+      - netifapi.h
+      - pppapi.h
+      - sockets.h
+      - sys.h
+
+      Additionaly, memory (de-)allocation functions may be
+      called from multiple threads (not ISR!) with NO_SYS=0
+      since they are protected by SYS_LIGHTWEIGHT_PROT and/or
+      semaphores.
+
+      Netconn or Socket API functions are thread safe against the
+      core thread but they are not reentrant at the control block
+      granularity level. That is, a UDP or TCP control block must
+      not be shared among multiple threads without proper locking.
+
+      If SYS_LIGHTWEIGHT_PROT is set to 1 and
+      LWIP_ALLOW_MEM_FREE_FROM_OTHER_CONTEXT is set to 1,
+      pbuf_free() may also be called from another thread or
+      an ISR (since only then, mem_free - for PBUF_RAM - may
+      be called from an ISR: otherwise, the HEAP is only
+      protected by semaphores).
+
+
+** The remainder of this document discusses the "raw" API. **
+
+The raw TCP/IP interface allows the application program to integrate
+better with the TCP/IP code. Program execution is event based by
+having callback functions being called from within the TCP/IP
+code. The TCP/IP code and the application program both run in the same
+thread. The sequential API has a much higher overhead and is not very
+well suited for small systems since it forces a multithreaded paradigm
+on the application.
+
+The raw TCP/IP interface is not only faster in terms of code execution
+time but is also less memory intensive. The drawback is that program
+development is somewhat harder and application programs written for
+the raw TCP/IP interface are more difficult to understand. Still, this
+is the preferred way of writing applications that should be small in
+code size and memory usage.
+
+All APIs can be used simultaneously by different application
+programs. In fact, the sequential API is implemented as an application
+program using the raw TCP/IP interface.
+
+Do not confuse the lwIP raw API with raw Ethernet or IP sockets.
+The former is a way of interfacing the lwIP network stack (including
+TCP and UDP), the later refers to processing raw Ethernet or IP data
+instead of TCP connections or UDP packets.
+
+Raw API applications may never block since all packet processing
+(input and output) as well as timer processing (TCP mainly) is done
+in a single execution context.
+
+--- Callbacks
+
+Program execution is driven by callbacks functions, which are then
+invoked by the lwIP core when activity related to that application
+occurs. A particular application may register to be notified via a
+callback function for events such as incoming data available, outgoing
+data sent, error notifications, poll timer expiration, connection
+closed, etc. An application can provide a callback function to perform
+processing for any or all of these events. Each callback is an ordinary
+C function that is called from within the TCP/IP code. Every callback
+function is passed the current TCP or UDP connection state as an
+argument. Also, in order to be able to keep program specific state,
+the callback functions are called with a program specified argument
+that is independent of the TCP/IP state.
+
+The function for setting the application connection state is:
+
+- void tcp_arg(struct tcp_pcb *pcb, void *arg)
+
+  Specifies the program specific state that should be passed to all
+  other callback functions. The "pcb" argument is the current TCP
+  connection control block, and the "arg" argument is the argument
+  that will be passed to the callbacks.
+
+  
+--- TCP connection setup
+
+The functions used for setting up connections is similar to that of
+the sequential API and of the BSD socket API. A new TCP connection
+identifier (i.e., a protocol control block - PCB) is created with the
+tcp_new() function. This PCB can then be either set to listen for new
+incoming connections or be explicitly connected to another host.
+
+- struct tcp_pcb *tcp_new(void)
+
+  Creates a new connection identifier (PCB). If memory is not
+  available for creating the new pcb, NULL is returned.
+
+- err_t tcp_bind(struct tcp_pcb *pcb, ip_addr_t *ipaddr,
+                 u16_t port)
+
+  Binds the pcb to a local IP address and port number. The IP address
+  can be specified as IP_ADDR_ANY in order to bind the connection to
+  all local IP addresses.
+
+  If another connection is bound to the same port, the function will
+  return ERR_USE, otherwise ERR_OK is returned.
+
+- struct tcp_pcb *tcp_listen(struct tcp_pcb *pcb)
+
+  Commands a pcb to start listening for incoming connections. When an
+  incoming connection is accepted, the function specified with the
+  tcp_accept() function will be called. The pcb will have to be bound
+  to a local port with the tcp_bind() function.
+
+  The tcp_listen() function returns a new connection identifier, and
+  the one passed as an argument to the function will be
+  deallocated. The reason for this behavior is that less memory is
+  needed for a connection that is listening, so tcp_listen() will
+  reclaim the memory needed for the original connection and allocate a
+  new smaller memory block for the listening connection.
+
+  tcp_listen() may return NULL if no memory was available for the
+  listening connection. If so, the memory associated with the pcb
+  passed as an argument to tcp_listen() will not be deallocated.
+
+- struct tcp_pcb *tcp_listen_with_backlog(struct tcp_pcb *pcb, u8_t backlog)
+
+  Same as tcp_listen, but limits the number of outstanding connections
+  in the listen queue to the value specified by the backlog argument.
+  To use it, your need to set TCP_LISTEN_BACKLOG=1 in your lwipopts.h.
+
+- void tcp_accept(struct tcp_pcb *pcb,
+                  err_t (* accept)(void *arg, struct tcp_pcb *newpcb,
+                                   err_t err))
+
+  Specified the callback function that should be called when a new
+  connection arrives on a listening connection.
+
+- err_t tcp_connect(struct tcp_pcb *pcb, ip_addr_t *ipaddr,
+                    u16_t port, err_t (* connected)(void *arg,
+                                                    struct tcp_pcb *tpcb,
+                                                    err_t err));
+
+  Sets up the pcb to connect to the remote host and sends the
+  initial SYN segment which opens the connection. 
+
+  The tcp_connect() function returns immediately; it does not wait for
+  the connection to be properly setup. Instead, it will call the
+  function specified as the fourth argument (the "connected" argument)
+  when the connection is established. If the connection could not be
+  properly established, either because the other host refused the
+  connection or because the other host didn't answer, the "err"
+  callback function of this pcb (registered with tcp_err, see below)
+  will be called.
+
+  The tcp_connect() function can return ERR_MEM if no memory is
+  available for enqueueing the SYN segment. If the SYN indeed was
+  enqueued successfully, the tcp_connect() function returns ERR_OK.
+
+
+--- Sending TCP data
+
+TCP data is sent by enqueueing the data with a call to
+tcp_write(). When the data is successfully transmitted to the remote
+host, the application will be notified with a call to a specified
+callback function.
+
+- err_t tcp_write(struct tcp_pcb *pcb, const void *dataptr, u16_t len,
+                  u8_t apiflags)
+
+  Enqueues the data pointed to by the argument dataptr. The length of
+  the data is passed as the len parameter. The apiflags can be one or more of:
+  - TCP_WRITE_FLAG_COPY: indicates whether the new memory should be allocated
+    for the data to be copied into. If this flag is not given, no new memory
+    should be allocated and the data should only be referenced by pointer. This
+    also means that the memory behind dataptr must not change until the data is
+    ACKed by the remote host
+  - TCP_WRITE_FLAG_MORE: indicates that more data follows. If this is omitted,
+    the PSH flag is set in the last segment created by this call to tcp_write.
+    If this flag is given, the PSH flag is not set.
+
+  The tcp_write() function will fail and return ERR_MEM if the length
+  of the data exceeds the current send buffer size or if the length of
+  the queue of outgoing segment is larger than the upper limit defined
+  in lwipopts.h. The number of bytes available in the output queue can
+  be retrieved with the tcp_sndbuf() function.
+
+  The proper way to use this function is to call the function with at
+  most tcp_sndbuf() bytes of data. If the function returns ERR_MEM,
+  the application should wait until some of the currently enqueued
+  data has been successfully received by the other host and try again.
+
+- void tcp_sent(struct tcp_pcb *pcb,
+                err_t (* sent)(void *arg, struct tcp_pcb *tpcb,
+                u16_t len))
+
+  Specifies the callback function that should be called when data has
+  successfully been received (i.e., acknowledged) by the remote
+  host. The len argument passed to the callback function gives the
+  amount bytes that was acknowledged by the last acknowledgment.
+
+  
+--- Receiving TCP data
+
+TCP data reception is callback based - an application specified
+callback function is called when new data arrives. When the
+application has taken the data, it has to call the tcp_recved()
+function to indicate that TCP can advertise increase the receive
+window.
+
+- void tcp_recv(struct tcp_pcb *pcb,
+                err_t (* recv)(void *arg, struct tcp_pcb *tpcb,
+                               struct pbuf *p, err_t err))
+
+  Sets the callback function that will be called when new data
+  arrives. The callback function will be passed a NULL pbuf to
+  indicate that the remote host has closed the connection. If
+  there are no errors and the callback function is to return
+  ERR_OK, then it must free the pbuf. Otherwise, it must not
+  free the pbuf so that lwIP core code can store it.
+
+- void tcp_recved(struct tcp_pcb *pcb, u16_t len)
+
+  Must be called when the application has received the data. The len
+  argument indicates the length of the received data.
+
+
+--- Application polling
+
+When a connection is idle (i.e., no data is either transmitted or
+received), lwIP will repeatedly poll the application by calling a
+specified callback function. This can be used either as a watchdog
+timer for killing connections that have stayed idle for too long, or
+as a method of waiting for memory to become available. For instance,
+if a call to tcp_write() has failed because memory wasn't available,
+the application may use the polling functionality to call tcp_write()
+again when the connection has been idle for a while.
+
+- void tcp_poll(struct tcp_pcb *pcb, 
+                err_t (* poll)(void *arg, struct tcp_pcb *tpcb),
+                u8_t interval)
+
+  Specifies the polling interval and the callback function that should
+  be called to poll the application. The interval is specified in
+  number of TCP coarse grained timer shots, which typically occurs
+  twice a second. An interval of 10 means that the application would
+  be polled every 5 seconds.
+
+
+--- Closing and aborting connections
+
+- err_t tcp_close(struct tcp_pcb *pcb)
+
+  Closes the connection. The function may return ERR_MEM if no memory
+  was available for closing the connection. If so, the application
+  should wait and try again either by using the acknowledgment
+  callback or the polling functionality. If the close succeeds, the
+  function returns ERR_OK.
+
+  The pcb is deallocated by the TCP code after a call to tcp_close(). 
+
+- void tcp_abort(struct tcp_pcb *pcb)
+
+  Aborts the connection by sending a RST (reset) segment to the remote
+  host. The pcb is deallocated. This function never fails.
+
+  ATTENTION: When calling this from one of the TCP callbacks, make
+  sure you always return ERR_ABRT (and never return ERR_ABRT otherwise
+  or you will risk accessing deallocated memory or memory leaks!
+
+
+If a connection is aborted because of an error, the application is
+alerted of this event by the err callback. Errors that might abort a
+connection are when there is a shortage of memory. The callback
+function to be called is set using the tcp_err() function.
+
+- void tcp_err(struct tcp_pcb *pcb, void (* err)(void *arg,
+       err_t err))
+
+  The error callback function does not get the pcb passed to it as a
+  parameter since the pcb may already have been deallocated.
+
+
+--- UDP interface
+
+The UDP interface is similar to that of TCP, but due to the lower
+level of complexity of UDP, the interface is significantly simpler.
+
+- struct udp_pcb *udp_new(void)
+
+  Creates a new UDP pcb which can be used for UDP communication. The
+  pcb is not active until it has either been bound to a local address
+  or connected to a remote address.
+
+- void udp_remove(struct udp_pcb *pcb)
+
+  Removes and deallocates the pcb.  
+  
+- err_t udp_bind(struct udp_pcb *pcb, ip_addr_t *ipaddr,
+                 u16_t port)
+
+  Binds the pcb to a local address. The IP-address argument "ipaddr"
+  can be IP_ADDR_ANY to indicate that it should listen to any local IP
+  address. The function currently always return ERR_OK.
+
+- err_t udp_connect(struct udp_pcb *pcb, ip_addr_t *ipaddr,
+                    u16_t port)
+
+  Sets the remote end of the pcb. This function does not generate any
+  network traffic, but only set the remote address of the pcb.
+
+- err_t udp_disconnect(struct udp_pcb *pcb)
+
+  Remove the remote end of the pcb. This function does not generate
+  any network traffic, but only removes the remote address of the pcb.
+
+- err_t udp_send(struct udp_pcb *pcb, struct pbuf *p)
+
+  Sends the pbuf p. The pbuf is not deallocated.
+
+- void udp_recv(struct udp_pcb *pcb,
+                void (* recv)(void *arg, struct udp_pcb *upcb,
+                                         struct pbuf *p,
+                                         ip_addr_t *addr,
+                                         u16_t port),
+                              void *recv_arg)
+
+  Specifies a callback function that should be called when a UDP
+  datagram is received.
+  
+
+--- System initalization
+
+A truly complete and generic sequence for initializing the lwIP stack
+cannot be given because it depends on additional initializations for
+your runtime environment (e.g. timers).
+
+We can give you some idea on how to proceed when using the raw API.
+We assume a configuration using a single Ethernet netif and the
+UDP and TCP transport layers, IPv4 and the DHCP client.
+
+Call these functions in the order of appearance:
+
+- lwip_init()
+
+  Initialize the lwIP stack and all of its subsystems.
+
+- netif_add(struct netif *netif, const ip4_addr_t *ipaddr,
+            const ip4_addr_t *netmask, const ip4_addr_t *gw,
+            void *state, netif_init_fn init, netif_input_fn input)
+
+  Adds your network interface to the netif_list. Allocate a struct
+  netif and pass a pointer to this structure as the first argument.
+  Give pointers to cleared ip_addr structures when using DHCP,
+  or fill them with sane numbers otherwise. The state pointer may be NULL.
+
+  The init function pointer must point to a initialization function for
+  your Ethernet netif interface. The following code illustrates its use.
+  
+  err_t netif_if_init(struct netif *netif)
+  {
+    u8_t i;
+    
+    for (i = 0; i < ETHARP_HWADDR_LEN; i++) {
+      netif->hwaddr[i] = some_eth_addr[i];
+    }
+    init_my_eth_device();
+    return ERR_OK;
+  }
+  
+  For Ethernet drivers, the input function pointer must point to the lwIP
+  function ethernet_input() declared in "netif/etharp.h". Other drivers
+  must use ip_input() declared in "lwip/ip.h".
+  
+- netif_set_default(struct netif *netif)
+
+  Registers the default network interface.
+
+- netif_set_link_up(struct netif *netif)
+
+  This is the hardware link state; e.g. whether cable is plugged for wired
+  Ethernet interface. This function must be called even if you don't know
+  the current state. Having link up and link down events is optional but
+  DHCP and IPv6 discover benefit well from those events.
+
+- netif_set_up(struct netif *netif)
+
+  This is the administrative (= software) state of the netif, when the
+  netif is fully configured this function must be called.
+
+- dhcp_start(struct netif *netif)
+
+  Creates a new DHCP client for this interface on the first call.
+  
+  You can peek in the netif->dhcp struct for the actual DHCP status.
+
+- sys_check_timeouts()
+
+  When the system is running, you have to periodically call
+  sys_check_timeouts() which will handle all timers for all protocols in
+  the stack; add this to your main loop or equivalent.
+
+
+--- Optimalization hints
+
+The first thing you want to optimize is the lwip_standard_checksum()
+routine from src/core/inet.c. You can override this standard
+function with the #define LWIP_CHKSUM <your_checksum_routine>.
+
+There are C examples given in inet.c or you might want to
+craft an assembly function for this. RFC1071 is a good
+introduction to this subject.
+
+Other significant improvements can be made by supplying
+assembly or inline replacements for htons() and htonl()
+if you're using a little-endian architecture.
+#define lwip_htons(x) <your_htons>
+#define lwip_htonl(x) <your_htonl>
+If you #define them to htons() and htonl(), you should
+#define LWIP_DONT_PROVIDE_BYTEORDER_FUNCTIONS to prevent lwIP from
+defining hton*/ntoh* compatibility macros.
+
+Check your network interface driver if it reads at
+a higher speed than the maximum wire-speed. If the
+hardware isn't serviced frequently and fast enough
+buffer overflows are likely to occur.
+
+E.g. when using the cs8900 driver, call cs8900if_service(ethif)
+as frequently as possible. When using an RTOS let the cs8900 interrupt
+wake a high priority task that services your driver using a binary
+semaphore or event flag. Some drivers might allow additional tuning
+to match your application and network.
+
+For a production release it is recommended to set LWIP_STATS to 0.
+Note that speed performance isn't influenced much by simply setting
+high values to the memory options.
+
+For more optimization hints take a look at the lwIP wiki.
+
+--- Zero-copy MACs
+
+To achieve zero-copy on transmit, the data passed to the raw API must
+remain unchanged until sent. Because the send- (or write-)functions return
+when the packets have been enqueued for sending, data must be kept stable
+after that, too.
+
+This implies that PBUF_RAM/PBUF_POOL pbufs passed to raw-API send functions
+must *not* be reused by the application unless their ref-count is 1.
+
+For no-copy pbufs (PBUF_ROM/PBUF_REF), data must be kept unchanged, too,
+but the stack/driver will/must copy PBUF_REF'ed data when enqueueing, while
+PBUF_ROM-pbufs are just enqueued (as ROM-data is expected to never change).
+
+Also, data passed to tcp_write without the copy-flag must not be changed!
+
+Therefore, be careful which type of PBUF you use and if you copy TCP data
+or not!
--- a/doc/savannah.txt
+++ b/doc/savannah.txt
@@ -29,12 +29,12 @@ Or, obtain a specific (fixed) release as follows:
 The Savannah server uses SSH (Secure Shell) protocol 2 authentication and encryption.
 As such, Git commits to the server occur through a SSH tunnel for project members.
 To create a SSH2 key pair in UNIX-like environments, do this:
- ssh-keygen
+ ssh-keygen -t dsa

 Under Windows, a recommended SSH client is "PuTTY", freely available with good
 documentation and a graphic user interface. Use its key generator.

-Now paste the id_rsa.pub contents into your Savannah account public key list. Wait
+Now paste the id_dsa.pub contents into your Savannah account public key list. Wait
 a while so that Savannah can update its configuration (This can take minutes).

 Try to login using SSH:
--- a/doc/sys_arch.txt
+++ b/doc/sys_arch.txt
@@ -0,0 +1,303 @@
+sys_arch interface for lwIP
+
+Author: Adam Dunkels
+        Simon Goldschmidt
+
+The operating system emulation layer provides a common interface
+between the lwIP code and the underlying operating system kernel. The
+general idea is that porting lwIP to new architectures requires only
+small changes to a few header files and a new sys_arch
+implementation. It is also possible to do a sys_arch implementation
+that does not rely on any underlying operating system.
+
+The sys_arch provides semaphores, mailboxes and mutexes to lwIP. For the full
+lwIP functionality, multiple threads support can be implemented in the
+sys_arch, but this is not required for the basic lwIP
+functionality. Timer scheduling is implemented in lwIP, but can be implemented
+by the sys_arch port (LWIP_TIMERS_CUSTOM==1).
+
+In addition to the source file providing the functionality of sys_arch,
+the OS emulation layer must provide several header files defining
+macros used throughout lwip.  The files required and the macros they
+must define are listed below the sys_arch description.
+
+Semaphores can be either counting or binary - lwIP works with both
+kinds. Mailboxes should be implemented as a queue which allows multiple messages
+to be posted (implementing as a rendez-vous point where only one message can be
+posted at a time can have a highly negative impact on performance). A message
+in a mailbox is just a pointer, nothing more. 
+
+Semaphores are represented by the type "sys_sem_t" which is typedef'd
+in the sys_arch.h file. Mailboxes are equivalently represented by the
+type "sys_mbox_t". Mutexes are represented by the type "sys_mutex_t".
+lwIP does not place any restrictions on how these types are represented
+internally.
+
+Since lwIP 1.4.0, semaphore, mutexes and mailbox functions are prototyped in a way that
+allows both using pointers or actual OS structures to be used. This way, memory
+required for such types can be either allocated in place (globally or on the
+stack) or on the heap (allocated internally in the "*_new()" functions).
+
+The following functions must be implemented by the sys_arch:
+
+- void sys_init(void)
+
+  Is called to initialize the sys_arch layer.
+
+- err_t sys_sem_new(sys_sem_t *sem, u8_t count)
+
+  Creates a new semaphore. The semaphore is allocated to the memory that 'sem'
+  points to (which can be both a pointer or the actual OS structure).
+  The "count" argument specifies the initial state of the semaphore (which is
+  either 0 or 1).
+  If the semaphore has been created, ERR_OK should be returned. Returning any
+  other error will provide a hint what went wrong, but except for assertions,
+  no real error handling is implemented.
+
+- void sys_sem_free(sys_sem_t *sem)
+
+  Deallocates a semaphore.
+
+- void sys_sem_signal(sys_sem_t *sem)
+
+  Signals a semaphore.
+
+- u32_t sys_arch_sem_wait(sys_sem_t *sem, u32_t timeout)
+
+  Blocks the thread while waiting for the semaphore to be
+  signaled. If the "timeout" argument is non-zero, the thread should
+  only be blocked for the specified time (measured in
+  milliseconds). If the "timeout" argument is zero, the thread should be
+  blocked until the semaphore is signalled.
+
+  If the timeout argument is non-zero, the return value is the number of
+  milliseconds spent waiting for the semaphore to be signaled. If the
+  semaphore wasn't signaled within the specified time, the return value is
+  SYS_ARCH_TIMEOUT. If the thread didn't have to wait for the semaphore
+  (i.e., it was already signaled), the function may return zero.
+
+  Notice that lwIP implements a function with a similar name,
+  sys_sem_wait(), that uses the sys_arch_sem_wait() function.
+
+- int sys_sem_valid(sys_sem_t *sem)
+
+  Returns 1 if the semaphore is valid, 0 if it is not valid.
+  When using pointers, a simple way is to check the pointer for != NULL.
+  When directly using OS structures, implementing this may be more complex.
+  This may also be a define, in which case the function is not prototyped.
+
+- void sys_sem_set_invalid(sys_sem_t *sem)
+
+  Invalidate a semaphore so that sys_sem_valid() returns 0.
+  ATTENTION: This does NOT mean that the semaphore shall be deallocated:
+  sys_sem_free() is always called before calling this function!
+  This may also be a define, in which case the function is not prototyped.
+
+- void sys_mutex_new(sys_mutex_t *mutex)
+
+  Creates a new mutex. The mutex is allocated to the memory that 'mutex'
+  points to (which can be both a pointer or the actual OS structure).
+  If the mutex has been created, ERR_OK should be returned. Returning any
+  other error will provide a hint what went wrong, but except for assertions,
+  no real error handling is implemented.
+
+- void sys_mutex_free(sys_mutex_t *mutex)
+
+  Deallocates a mutex.
+
+- void sys_mutex_lock(sys_mutex_t *mutex)
+  
+  Blocks the thread until the mutex can be grabbed.
+
+- void sys_mutex_unlock(sys_mutex_t *mutex)
+
+  Releases the mutex previously locked through 'sys_mutex_lock()'.
+
+- void sys_mutex_valid(sys_mutex_t *mutex)
+
+  Returns 1 if the mutes is valid, 0 if it is not valid.
+  When using pointers, a simple way is to check the pointer for != NULL.
+  When directly using OS structures, implementing this may be more complex.
+  This may also be a define, in which case the function is not prototyped.
+
+- void sys_mutex_set_invalid(sys_mutex_t *mutex)
+
+  Invalidate a mutex so that sys_mutex_valid() returns 0.
+  ATTENTION: This does NOT mean that the mutex shall be deallocated:
+  sys_mutex_free() is always called before calling this function!
+  This may also be a define, in which case the function is not prototyped.
+
+- err_t sys_mbox_new(sys_mbox_t *mbox, int size)
+
+  Creates an empty mailbox for maximum "size" elements. Elements stored
+  in mailboxes are pointers. You have to define macros "_MBOX_SIZE"
+  in your lwipopts.h, or ignore this parameter in your implementation
+  and use a default size.
+  If the mailbox has been created, ERR_OK should be returned. Returning any
+  other error will provide a hint what went wrong, but except for assertions,
+  no real error handling is implemented.
+
+- void sys_mbox_free(sys_mbox_t *mbox)
+
+  Deallocates a mailbox. If there are messages still present in the
+  mailbox when the mailbox is deallocated, it is an indication of a
+  programming error in lwIP and the developer should be notified.
+
+- void sys_mbox_post(sys_mbox_t *mbox, void *msg)
+
+  Posts the "msg" to the mailbox. This function have to block until
+  the "msg" is really posted.
+
+- err_t sys_mbox_trypost(sys_mbox_t *mbox, void *msg)
+
+  Try to post the "msg" to the mailbox. Returns ERR_MEM if this one
+  is full, else, ERR_OK if the "msg" is posted.
+
+- u32_t sys_arch_mbox_fetch(sys_mbox_t *mbox, void **msg, u32_t timeout)
+
+  Blocks the thread until a message arrives in the mailbox, but does
+  not block the thread longer than "timeout" milliseconds (similar to
+  the sys_arch_sem_wait() function). If "timeout" is 0, the thread should
+  be blocked until a message arrives. The "msg" argument is a result
+  parameter that is set by the function (i.e., by doing "*msg =
+  ptr"). The "msg" parameter maybe NULL to indicate that the message
+  should be dropped.
+
+  The return values are the same as for the sys_arch_sem_wait() function:
+  Number of milliseconds spent waiting or SYS_ARCH_TIMEOUT if there was a
+  timeout.
+
+  Note that a function with a similar name, sys_mbox_fetch(), is
+  implemented by lwIP. 
+
+- u32_t sys_arch_mbox_tryfetch(sys_mbox_t *mbox, void **msg)
+
+  This is similar to sys_arch_mbox_fetch, however if a message is not
+  present in the mailbox, it immediately returns with the code
+  SYS_MBOX_EMPTY. On success 0 is returned.
+
+  To allow for efficient implementations, this can be defined as a
+  function-like macro in sys_arch.h instead of a normal function. For
+  example, a naive implementation could be:
+    #define sys_arch_mbox_tryfetch(mbox,msg) \
+      sys_arch_mbox_fetch(mbox,msg,1)
+  although this would introduce unnecessary delays.
+
+- int sys_mbox_valid(sys_mbox_t *mbox)
+
+  Returns 1 if the mailbox is valid, 0 if it is not valid.
+  When using pointers, a simple way is to check the pointer for != NULL.
+  When directly using OS structures, implementing this may be more complex.
+  This may also be a define, in which case the function is not prototyped.
+
+- void sys_mbox_set_invalid(sys_mbox_t *mbox)
+
+  Invalidate a mailbox so that sys_mbox_valid() returns 0.
+  ATTENTION: This does NOT mean that the mailbox shall be deallocated:
+  sys_mbox_free() is always called before calling this function!
+  This may also be a define, in which case the function is not prototyped.
+
+If threads are supported by the underlying operating system and if
+such functionality is needed in lwIP, the following function will have
+to be implemented as well:
+
+- sys_thread_t sys_thread_new(char *name, void (* thread)(void *arg), void *arg, int stacksize, int prio)
+
+  Starts a new thread named "name" with priority "prio" that will begin its
+  execution in the function "thread()". The "arg" argument will be passed as an
+  argument to the thread() function. The stack size to used for this thread is
+  the "stacksize" parameter. The id of the new thread is returned. Both the id
+  and the priority are system dependent.
+
+When lwIP is used from more than one context (e.g. from multiple threads OR from
+main-loop and from interrupts), the SYS_LIGHTWEIGHT_PROT protection SHOULD be enabled!
+
+- sys_prot_t sys_arch_protect(void)
+
+  This optional function does a "fast" critical region protection and returns
+  the previous protection level. This function is only called during very short
+  critical regions. An embedded system which supports ISR-based drivers might
+  want to implement this function by disabling interrupts. Task-based systems
+  might want to implement this by using a mutex or disabling tasking. This
+  function should support recursive calls from the same task or interrupt. In
+  other words, sys_arch_protect() could be called while already protected. In
+  that case the return value indicates that it is already protected.
+
+  sys_arch_protect() is only required if your port is supporting an operating
+  system.
+
+- void sys_arch_unprotect(sys_prot_t pval)
+
+  This optional function does a "fast" set of critical region protection to the
+  value specified by pval. See the documentation for sys_arch_protect() for
+  more information. This function is only required if your port is supporting
+  an operating system.
+
+For some configurations, you also need:
+
+- u32_t sys_now(void)
+
+  This optional function returns the current time in milliseconds (don't care
+  for wraparound, this is only used for time diffs).
+  Not implementing this function means you cannot use some modules (e.g. TCP
+  timestamps, internal timeouts for NO_SYS==1).
+
+
+Note:
+
+Be careful with using mem_malloc() in sys_arch. When malloc() refers to
+mem_malloc() you can run into a circular function call problem. In mem.c
+mem_init() tries to allcate a semaphore using mem_malloc, which of course
+can't be performed when sys_arch uses mem_malloc.
+
+-------------------------------------------------------------------------------
+Additional files required for the "OS support" emulation layer:
+-------------------------------------------------------------------------------
+
+cc.h       - Architecture environment, some compiler specific, some
+             environment specific (probably should move env stuff 
+             to sys_arch.h.)
+
+  Typedefs for the types used by lwip -
+    u8_t, s8_t, u16_t, s16_t, u32_t, s32_t, mem_ptr_t
+
+  Compiler hints for packing lwip's structures -
+    PACK_STRUCT_FIELD(x)
+    PACK_STRUCT_STRUCT
+    PACK_STRUCT_BEGIN
+    PACK_STRUCT_END
+
+  Platform specific diagnostic output -
+    LWIP_PLATFORM_DIAG(x)    - non-fatal, print a message.
+    LWIP_PLATFORM_ASSERT(x)  - fatal, print message and abandon execution.
+    Portability defines for printf formatters:
+    U16_F, S16_F, X16_F, U32_F, S32_F, X32_F, SZT_F
+
+  "lightweight" synchronization mechanisms -
+    SYS_ARCH_DECL_PROTECT(x) - declare a protection state variable.
+    SYS_ARCH_PROTECT(x)      - enter protection mode.
+    SYS_ARCH_UNPROTECT(x)    - leave protection mode.
+
+  If the compiler does not provide memset() this file must include a
+  definition of it, or include a file which defines it.
+
+  This file must either include a system-local <errno.h> which defines
+  the standard *nix error codes, or it should #define LWIP_PROVIDE_ERRNO
+  to make lwip/arch.h define the codes which are used throughout.
+
+
+perf.h     - Architecture specific performance measurement.
+  Measurement calls made throughout lwip, these can be defined to nothing.
+    PERF_START               - start measuring something.
+    PERF_STOP(x)             - stop measuring something, and record the result.
+
+sys_arch.h - Tied to sys_arch.c
+
+  Arch dependent types for the following objects:
+    sys_sem_t, sys_mbox_t, sys_thread_t,
+  And, optionally:
+    sys_prot_t
+
+  Defines to set vars of sys_mbox_t and sys_sem_t to NULL.
+    SYS_MBOX_NULL NULL
+    SYS_SEM_NULL NULL
--- a/src/Filelists.cmake
+++ b/src/Filelists.cmake
@@ -1,279 +0,0 @@
-# This file is indended to be included in end-user CMakeLists.txt
-# include(/path/to/Filelists.cmake)
-# It assumes the variable LWIP_DIR is defined pointing to the
-# root path of lwIP sources.
-#
-# This file is NOT designed (on purpose) to be used as cmake
-# subdir via add_subdirectory()
-# The intention is to provide greater flexibility to users to 
-# create their own targets using the *_SRCS variables.
-
-set(LWIP_VERSION_MAJOR    "2")
-set(LWIP_VERSION_MINOR    "1")
-set(LWIP_VERSION_REVISION "1")
-# LWIP_VERSION_RC is set to LWIP_RC_RELEASE for official releases
-# LWIP_VERSION_RC is set to LWIP_RC_DEVELOPMENT for Git versions
-# Numbers 1..31 are reserved for release candidates
-set(LWIP_VERSION_RC       "LWIP_RC_RELEASE")
-
-if ("${LWIP_VERSION_RC}" STREQUAL "LWIP_RC_RELEASE")
-    set(LWIP_VERSION_STRING
-        "${LWIP_VERSION_MAJOR}.${LWIP_VERSION_MINOR}.${LWIP_VERSION_REVISION}"
-    )
-elseif ("${LWIP_VERSION_RC}" STREQUAL "LWIP_RC_DEVELOPMENT")
-    set(LWIP_VERSION_STRING
-        "${LWIP_VERSION_MAJOR}.${LWIP_VERSION_MINOR}.${LWIP_VERSION_REVISION}.dev"
-    )
-else ("${LWIP_VERSION_RC}" STREQUAL "LWIP_RC_RELEASE")
-    set(LWIP_VERSION_STRING
-        "${LWIP_VERSION_MAJOR}.${LWIP_VERSION_MINOR}.${LWIP_VERSION_REVISION}.rc${LWIP_VERSION_RC}"
-    )
-endif ("${LWIP_VERSION_RC}" STREQUAL "LWIP_RC_RELEASE")
-
-# The minimum set of files needed for lwIP.
-set(lwipcore_SRCS
-    ${LWIP_DIR}/src/core/init.c
-    ${LWIP_DIR}/src/core/def.c
-    ${LWIP_DIR}/src/core/dns.c
-    ${LWIP_DIR}/src/core/inet_chksum.c
-    ${LWIP_DIR}/src/core/ip.c
-    ${LWIP_DIR}/src/core/mem.c
-    ${LWIP_DIR}/src/core/memp.c
-    ${LWIP_DIR}/src/core/netif.c
-    ${LWIP_DIR}/src/core/pbuf.c
-    ${LWIP_DIR}/src/core/raw.c
-    ${LWIP_DIR}/src/core/stats.c
-    ${LWIP_DIR}/src/core/sys.c
-    ${LWIP_DIR}/src/core/altcp.c
-    ${LWIP_DIR}/src/core/altcp_alloc.c
-    ${LWIP_DIR}/src/core/altcp_tcp.c
-    ${LWIP_DIR}/src/core/tcp.c
-    ${LWIP_DIR}/src/core/tcp_in.c
-    ${LWIP_DIR}/src/core/tcp_out.c
-    ${LWIP_DIR}/src/core/timeouts.c
-    ${LWIP_DIR}/src/core/udp.c
-)
-set(lwipcore4_SRCS
-    ${LWIP_DIR}/src/core/ipv4/autoip.c
-    ${LWIP_DIR}/src/core/ipv4/dhcp.c
-    ${LWIP_DIR}/src/core/ipv4/etharp.c
-    ${LWIP_DIR}/src/core/ipv4/icmp.c
-    ${LWIP_DIR}/src/core/ipv4/igmp.c
-    ${LWIP_DIR}/src/core/ipv4/ip4_frag.c
-    ${LWIP_DIR}/src/core/ipv4/ip4.c
-    ${LWIP_DIR}/src/core/ipv4/ip4_addr.c
-)
-set(lwipcore6_SRCS
-    ${LWIP_DIR}/src/core/ipv6/dhcp6.c
-    ${LWIP_DIR}/src/core/ipv6/ethip6.c
-    ${LWIP_DIR}/src/core/ipv6/icmp6.c
-    ${LWIP_DIR}/src/core/ipv6/inet6.c
-    ${LWIP_DIR}/src/core/ipv6/ip6.c
-    ${LWIP_DIR}/src/core/ipv6/ip6_addr.c
-    ${LWIP_DIR}/src/core/ipv6/ip6_frag.c
-    ${LWIP_DIR}/src/core/ipv6/mld6.c
-    ${LWIP_DIR}/src/core/ipv6/nd6.c
-)
-
-# APIFILES: The files which implement the sequential and socket APIs.
-set(lwipapi_SRCS
-    ${LWIP_DIR}/src/api/api_lib.c
-    ${LWIP_DIR}/src/api/api_msg.c
-    ${LWIP_DIR}/src/api/err.c
-    ${LWIP_DIR}/src/api/if_api.c
-    ${LWIP_DIR}/src/api/netbuf.c
-    ${LWIP_DIR}/src/api/netdb.c
-    ${LWIP_DIR}/src/api/netifapi.c
-    ${LWIP_DIR}/src/api/sockets.c
-    ${LWIP_DIR}/src/api/tcpip.c
-)
-
-# Files implementing various generic network interface functions
-set(lwipnetif_SRCS
-    ${LWIP_DIR}/src/netif/ethernet.c
-    ${LWIP_DIR}/src/netif/bridgeif.c
-    ${LWIP_DIR}/src/netif/bridgeif_fdb.c
-    ${LWIP_DIR}/src/netif/slipif.c
-)
-
-# 6LoWPAN
-set(lwipsixlowpan_SRCS
-    ${LWIP_DIR}/src/netif/lowpan6_common.c
-    ${LWIP_DIR}/src/netif/lowpan6.c
-    ${LWIP_DIR}/src/netif/lowpan6_ble.c
-    ${LWIP_DIR}/src/netif/zepif.c
-)
-
-# PPP
-set(lwipppp_SRCS
-    ${LWIP_DIR}/src/netif/ppp/auth.c
-    ${LWIP_DIR}/src/netif/ppp/ccp.c
-    ${LWIP_DIR}/src/netif/ppp/chap-md5.c
-    ${LWIP_DIR}/src/netif/ppp/chap_ms.c
-    ${LWIP_DIR}/src/netif/ppp/chap-new.c
-    ${LWIP_DIR}/src/netif/ppp/demand.c
-    ${LWIP_DIR}/src/netif/ppp/eap.c
-    ${LWIP_DIR}/src/netif/ppp/ecp.c
-    ${LWIP_DIR}/src/netif/ppp/eui64.c
-    ${LWIP_DIR}/src/netif/ppp/fsm.c
-    ${LWIP_DIR}/src/netif/ppp/ipcp.c
-    ${LWIP_DIR}/src/netif/ppp/ipv6cp.c
-    ${LWIP_DIR}/src/netif/ppp/lcp.c
-    ${LWIP_DIR}/src/netif/ppp/magic.c
-    ${LWIP_DIR}/src/netif/ppp/mppe.c
-    ${LWIP_DIR}/src/netif/ppp/multilink.c
-    ${LWIP_DIR}/src/netif/ppp/ppp.c
-    ${LWIP_DIR}/src/netif/ppp/pppapi.c
-    ${LWIP_DIR}/src/netif/ppp/pppcrypt.c
-    ${LWIP_DIR}/src/netif/ppp/pppoe.c
-    ${LWIP_DIR}/src/netif/ppp/pppol2tp.c
-    ${LWIP_DIR}/src/netif/ppp/pppos.c
-    ${LWIP_DIR}/src/netif/ppp/upap.c
-    ${LWIP_DIR}/src/netif/ppp/utils.c
-    ${LWIP_DIR}/src/netif/ppp/vj.c
-    ${LWIP_DIR}/src/netif/ppp/polarssl/arc4.c
-    ${LWIP_DIR}/src/netif/ppp/polarssl/des.c
-    ${LWIP_DIR}/src/netif/ppp/polarssl/md4.c
-    ${LWIP_DIR}/src/netif/ppp/polarssl/md5.c
-    ${LWIP_DIR}/src/netif/ppp/polarssl/sha1.c
-)
-
-# SNMPv3 agent
-set(lwipsnmp_SRCS
-    ${LWIP_DIR}/src/apps/snmp/snmp_asn1.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_core.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_icmp.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_interfaces.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_ip.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_snmp.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_system.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_tcp.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_mib2_udp.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_snmpv2_framework.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_snmpv2_usm.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_msg.c
-    ${LWIP_DIR}/src/apps/snmp/snmpv3.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_netconn.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_pbuf_stream.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_raw.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_scalar.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_table.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_threadsync.c
-    ${LWIP_DIR}/src/apps/snmp/snmp_traps.c
-)
-
-# HTTP server + client
-set(lwiphttp_SRCS
-    ${LWIP_DIR}/src/apps/http/altcp_proxyconnect.c
-    ${LWIP_DIR}/src/apps/http/fs.c
-    ${LWIP_DIR}/src/apps/http/http_client.c
-    ${LWIP_DIR}/src/apps/http/httpd.c
-)
-
-# MAKEFSDATA HTTP server host utility
-set(lwipmakefsdata_SRCS
-    ${LWIP_DIR}/src/apps/http/makefsdata/makefsdata.c
-)
-
-# IPERF server
-set(lwipiperf_SRCS
-    ${LWIP_DIR}/src/apps/lwiperf/lwiperf.c
-)
-
-# SMTP client
-set(lwipsmtp_SRCS
-    ${LWIP_DIR}/src/apps/smtp/smtp.c
-)
-
-# SNTP client
-set(lwipsntp_SRCS
-    ${LWIP_DIR}/src/apps/sntp/sntp.c
-)
-
-# MDNS responder
-set(lwipmdns_SRCS
-    ${LWIP_DIR}/src/apps/mdns/mdns.c
-)
-
-# NetBIOS name server
-set(lwipnetbios_SRCS
-    ${LWIP_DIR}/src/apps/netbiosns/netbiosns.c
-)
-
-# TFTP server files
-set(lwiptftp_SRCS
-    ${LWIP_DIR}/src/apps/tftp/tftp_server.c
-)
-
-# MQTT client files
-set(lwipmqtt_SRCS
-    ${LWIP_DIR}/src/apps/mqtt/mqtt.c
-)
-
-# ARM MBEDTLS related files of lwIP rep
-set(lwipmbedtls_SRCS
-    ${LWIP_DIR}/src/apps/altcp_tls/altcp_tls_mbedtls.c
-    ${LWIP_DIR}/src/apps/altcp_tls/altcp_tls_mbedtls_mem.c
-    ${LWIP_DIR}/src/apps/snmp/snmpv3_mbedtls.c
-)
-
-# All LWIP files without apps
-set(lwipnoapps_SRCS
-    ${lwipcore_SRCS}
-    ${lwipcore4_SRCS}
-    ${lwipcore6_SRCS}
-    ${lwipapi_SRCS}
-    ${lwipnetif_SRCS}
-    ${lwipsixlowpan_SRCS}
-    ${lwipppp_SRCS}
-)
-
-# LWIPAPPFILES: All LWIP APPs
-set(lwipallapps_SRCS
-    ${lwipsnmp_SRCS}
-    ${lwiphttp_SRCS}
-    ${lwipiperf_SRCS}
-    ${lwipsmtp_SRCS}
-    ${lwipsntp_SRCS}
-    ${lwipmdns_SRCS}
-    ${lwipnetbios_SRCS}
-    ${lwiptftp_SRCS}
-    ${lwipmqtt_SRCS}
-    ${lwipmbedtls_SRCS}
-)
-
-# Generate lwip/init.h (version info)
-configure_file(${LWIP_DIR}/src/include/lwip/init.h.cmake.in ${LWIP_DIR}/src/include/lwip/init.h)
-
-# Documentation
-set(DOXYGEN_DIR ${LWIP_DIR}/doc/doxygen)
-set(DOXYGEN_OUTPUT_DIR output)
-set(DOXYGEN_IN  ${LWIP_DIR}/doc/doxygen/lwip.Doxyfile.cmake.in)
-set(DOXYGEN_OUT ${LWIP_DIR}/doc/doxygen/lwip.Doxyfile)
-configure_file(${DOXYGEN_IN} ${DOXYGEN_OUT})
-
-find_package(Doxygen)
-if (DOXYGEN_FOUND)
-    message("Doxygen build started")
-
-    add_custom_target(lwipdocs
-        COMMAND ${CMAKE_COMMAND} -E remove_directory ${DOXYGEN_DIR}/${DOXYGEN_OUTPUT_DIR}/html
-        COMMAND ${DOXYGEN_EXECUTABLE} ${DOXYGEN_OUT}
-        WORKING_DIRECTORY ${DOXYGEN_DIR}
-        COMMENT "Generating API documentation with Doxygen"
-        VERBATIM)
-else (DOXYGEN_FOUND)
-    message("Doxygen needs to be installed to generate the doxygen documentation")
-endif (DOXYGEN_FOUND)
-
-# lwIP libraries
-add_library(lwipcore EXCLUDE_FROM_ALL ${lwipnoapps_SRCS})
-target_compile_options(lwipcore PRIVATE ${LWIP_COMPILER_FLAGS})
-target_compile_definitions(lwipcore PRIVATE ${LWIP_DEFINITIONS}  ${LWIP_MBEDTLS_DEFINITIONS})
-target_include_directories(lwipcore PRIVATE ${LWIP_INCLUDE_DIRS} ${LWIP_MBEDTLS_INCLUDE_DIRS})
-
-add_library(lwipallapps EXCLUDE_FROM_ALL ${lwipallapps_SRCS})
-target_compile_options(lwipallapps PRIVATE ${LWIP_COMPILER_FLAGS})
-target_compile_definitions(lwipallapps PRIVATE ${LWIP_DEFINITIONS}  ${LWIP_MBEDTLS_DEFINITIONS})
-target_include_directories(lwipallapps PRIVATE ${LWIP_INCLUDE_DIRS} ${LWIP_MBEDTLS_INCLUDE_DIRS})
--- a/src/Filelists.mk
+++ b/src/Filelists.mk
@@ -42,9 +42,6 @@ COREFILES=$(LWIPDIR)/core/init.c \
 	$(LWIPDIR)/core/raw.c \
 	$(LWIPDIR)/core/stats.c \
 	$(LWIPDIR)/core/sys.c \
-	$(LWIPDIR)/core/altcp.c \
-	$(LWIPDIR)/core/altcp_alloc.c \
-	$(LWIPDIR)/core/altcp_tcp.c \
 	$(LWIPDIR)/core/tcp.c \
 	$(LWIPDIR)/core/tcp_in.c \
 	$(LWIPDIR)/core/tcp_out.c \
@@ -74,7 +71,6 @@ CORE6FILES=$(LWIPDIR)/core/ipv6/dhcp6.c \
 APIFILES=$(LWIPDIR)/api/api_lib.c \
 	$(LWIPDIR)/api/api_msg.c \
 	$(LWIPDIR)/api/err.c \
-	$(LWIPDIR)/api/if_api.c \
 	$(LWIPDIR)/api/netbuf.c \
 	$(LWIPDIR)/api/netdb.c \
 	$(LWIPDIR)/api/netifapi.c \
@@ -83,15 +79,10 @@ APIFILES=$(LWIPDIR)/api/api_lib.c \

 # NETIFFILES: Files implementing various generic network interface functions
 NETIFFILES=$(LWIPDIR)/netif/ethernet.c \
-	$(LWIPDIR)/netif/bridgeif.c \
-	$(LWIPDIR)/netif/bridgeif_fdb.c \
 	$(LWIPDIR)/netif/slipif.c

 # SIXLOWPAN: 6LoWPAN
-SIXLOWPAN=$(LWIPDIR)/netif/lowpan6_common.c \
-        $(LWIPDIR)/netif/lowpan6.c \
-	$(LWIPDIR)/netif/lowpan6_ble.c \
-	$(LWIPDIR)/netif/zepif.c
+SIXLOWPAN=$(LWIPDIR)/netif/lowpan6.c \

 # PPPFILES: PPP
 PPPFILES=$(LWIPDIR)/netif/ppp/auth.c \
@@ -145,8 +136,6 @@ SNMPFILES=$(LWIPDIR)/apps/snmp/snmp_asn1.c \
 	$(LWIPDIR)/apps/snmp/snmp_mib2_system.c \
 	$(LWIPDIR)/apps/snmp/snmp_mib2_tcp.c \
 	$(LWIPDIR)/apps/snmp/snmp_mib2_udp.c \
-	$(LWIPDIR)/apps/snmp/snmp_snmpv2_framework.c \
-	$(LWIPDIR)/apps/snmp/snmp_snmpv2_usm.c \
 	$(LWIPDIR)/apps/snmp/snmp_msg.c \
 	$(LWIPDIR)/apps/snmp/snmpv3.c \
 	$(LWIPDIR)/apps/snmp/snmp_netconn.c \
@@ -155,23 +144,17 @@ SNMPFILES=$(LWIPDIR)/apps/snmp/snmp_asn1.c \
 	$(LWIPDIR)/apps/snmp/snmp_scalar.c \
 	$(LWIPDIR)/apps/snmp/snmp_table.c \
 	$(LWIPDIR)/apps/snmp/snmp_threadsync.c \
-	$(LWIPDIR)/apps/snmp/snmp_traps.c
+	$(LWIPDIR)/apps/snmp/snmp_traps.c \
+	$(LWIPDIR)/apps/snmp/snmpv3_mbedtls.c \
+	$(LWIPDIR)/apps/snmp/snmpv3_dummy.c

-# HTTPFILES: HTTP server + client
-HTTPFILES=$(LWIPDIR)/apps/http/altcp_proxyconnect.c \
-	$(LWIPDIR)/apps/http/fs.c \
-	$(LWIPDIR)/apps/http/http_client.c \
-	$(LWIPDIR)/apps/http/httpd.c
-
-# MAKEFSDATA: MAKEFSDATA HTTP server host utility
-MAKEFSDATAFILES=$(LWIPDIR)/apps/http/makefsdata/makefsdata.c
+# HTTPDFILES: HTTP server
+HTTPDFILES=$(LWIPDIR)/apps/httpd/fs.c \
+	$(LWIPDIR)/apps/httpd/httpd.c

 # LWIPERFFILES: IPERF server
 LWIPERFFILES=$(LWIPDIR)/apps/lwiperf/lwiperf.c

-# SMTPFILES: SMTP client
-SMTPFILES=$(LWIPDIR)/apps/smtp/smtp.c
-
 # SNTPFILES: SNTP client
 SNTPFILES=$(LWIPDIR)/apps/sntp/sntp.c

@@ -187,19 +170,12 @@ TFTPFILES=$(LWIPDIR)/apps/tftp/tftp_server.c
 # MQTTFILES: MQTT client files
 MQTTFILES=$(LWIPDIR)/apps/mqtt/mqtt.c

-# MBEDTLS_FILES: MBEDTLS related files of lwIP rep
-MBEDTLS_FILES=$(LWIPDIR)/apps/altcp_tls/altcp_tls_mbedtls.c \
-	$(LWIPDIR)/apps/altcp_tls/altcp_tls_mbedtls_mem.c \
-	$(LWIPDIR)/apps/snmp/snmpv3_mbedtls.c
-
 # LWIPAPPFILES: All LWIP APPs
 LWIPAPPFILES=$(SNMPFILES) \
-	$(HTTPFILES) \
+	$(HTTPDFILES) \
 	$(LWIPERFFILES) \
-	$(SMTPFILES) \
 	$(SNTPFILES) \
 	$(MDNSFILES) \
 	$(NETBIOSNSFILES) \
 	$(TFTPFILES) \
-	$(MQTTFILES) \
-	$(MBEDTLS_FILES)
+	$(MQTTFILES)
--- a/src/api/api_lib.c
+++ b/src/api/api_lib.c
@@ -1,21 +1,21 @@
 /**
 * @file
 * Sequential API External module
- *
+ * 
 * @defgroup netconn Netconn API
 * @ingroup sequential_api
 * Thread-safe, to be called from non-TCPIP threads only.
 * TX/RX handling based on @ref netbuf (containing @ref pbuf)
 * to avoid copying data around.
- *
+ * 
 * @defgroup netconn_common Common functions
 * @ingroup netconn
 * For use with TCP and UDP
- *
+ * 
 * @defgroup netconn_tcp TCP only
 * @ingroup netconn
 * TCP only functions
- *
+ * 
 * @defgroup netconn_udp UDP only
 * @ingroup netconn
 * UDP only functions
@@ -69,10 +69,6 @@
 #include "lwip/priv/tcp_priv.h"
 #include "lwip/priv/tcpip_priv.h"

-#ifdef LWIP_HOOK_FILENAME
-#include LWIP_HOOK_FILENAME
-#endif
-
 #include <string.h>

 #define API_MSG_VAR_REF(name)               API_VAR_REF(name)
@@ -81,28 +77,6 @@
 #define API_MSG_VAR_ALLOC_RETURN_NULL(name) API_VAR_ALLOC(struct api_msg, MEMP_API_MSG, name, NULL)
 #define API_MSG_VAR_FREE(name)              API_VAR_FREE(MEMP_API_MSG, name)

-#if TCP_LISTEN_BACKLOG
-/* need to allocate API message for accept so empty message pool does not result in event loss
- * see bug #47512: MPU_COMPATIBLE may fail on empty pool */
-#define API_MSG_VAR_ALLOC_ACCEPT(msg) API_MSG_VAR_ALLOC(msg)
-#define API_MSG_VAR_FREE_ACCEPT(msg) API_MSG_VAR_FREE(msg)
-#else /* TCP_LISTEN_BACKLOG */
-#define API_MSG_VAR_ALLOC_ACCEPT(msg)
-#define API_MSG_VAR_FREE_ACCEPT(msg)
-#endif /* TCP_LISTEN_BACKLOG */
-
-#if LWIP_NETCONN_FULLDUPLEX
-#define NETCONN_RECVMBOX_WAITABLE(conn) (sys_mbox_valid(&(conn)->recvmbox) && (((conn)->flags & NETCONN_FLAG_MBOXINVALID) == 0))
-#define NETCONN_ACCEPTMBOX_WAITABLE(conn) (sys_mbox_valid(&(conn)->acceptmbox) && (((conn)->flags & (NETCONN_FLAG_MBOXCLOSED|NETCONN_FLAG_MBOXINVALID)) == 0))
-#define NETCONN_MBOX_WAITING_INC(conn) SYS_ARCH_INC(conn->mbox_threads_waiting, 1)
-#define NETCONN_MBOX_WAITING_DEC(conn) SYS_ARCH_DEC(conn->mbox_threads_waiting, 1)
-#else /* LWIP_NETCONN_FULLDUPLEX */
-#define NETCONN_RECVMBOX_WAITABLE(conn)   sys_mbox_valid(&(conn)->recvmbox)
-#define NETCONN_ACCEPTMBOX_WAITABLE(conn) (sys_mbox_valid(&(conn)->acceptmbox) && (((conn)->flags & NETCONN_FLAG_MBOXCLOSED) == 0))
-#define NETCONN_MBOX_WAITING_INC(conn)
-#define NETCONN_MBOX_WAITING_DEC(conn)
-#endif /* LWIP_NETCONN_FULLDUPLEX */
-
 static err_t netconn_close_shutdown(struct netconn *conn, u8_t how);

 /**
@@ -145,7 +119,7 @@ netconn_apimsg(tcpip_callback_fn fn, struct api_msg *apimsg)
 * @return a newly allocated struct netconn or
 *         NULL on memory error
 */
-struct netconn *
+struct netconn*
 netconn_new_with_proto_and_callback(enum netconn_type t, u8_t proto, netconn_callback callback)
 {
  struct netconn *conn;
@@ -181,7 +155,7 @@ netconn_new_with_proto_and_callback(enum netconn_type t, u8_t proto, netconn_cal

 /**
 * @ingroup netconn_common
- * Close a netconn 'connection' and free all its resources but not the netconn itself.
+ * Close a netconn 'connection' and free its resources.
 * UDP and RAW connection are completely closed, TCP pcbs might still be in a waitstate
 * after this returns.
 *
@@ -189,7 +163,7 @@ netconn_new_with_proto_and_callback(enum netconn_type t, u8_t proto, netconn_cal
 * @return ERR_OK if the connection was deleted
 */
 err_t
-netconn_prepare_delete(struct netconn *conn)
+netconn_delete(struct netconn *conn)
 {
  err_t err;
  API_MSG_VAR_DECLARE(msg);
@@ -217,43 +191,12 @@ netconn_prepare_delete(struct netconn *conn)
  if (err != ERR_OK) {
    return err;
  }
+
+  netconn_free(conn);
+
  return ERR_OK;
 }

-/**
- * @ingroup netconn_common
- * Close a netconn 'connection' and free its resources.
- * UDP and RAW connection are completely closed, TCP pcbs might still be in a waitstate
- * after this returns.
- *
- * @param conn the netconn to delete
- * @return ERR_OK if the connection was deleted
- */
-err_t
-netconn_delete(struct netconn *conn)
-{
-  err_t err;
-
-  /* No ASSERT here because possible to get a (conn == NULL) if we got an accept error */
-  if (conn == NULL) {
-    return ERR_OK;
-  }
-
-#if LWIP_NETCONN_FULLDUPLEX
-  if (conn->flags & NETCONN_FLAG_MBOXINVALID) {
-    /* Already called netconn_prepare_delete() before */
-    err = ERR_OK;
-  } else
-#endif /* LWIP_NETCONN_FULLDUPLEX */
-  {
-    err = netconn_prepare_delete(conn);
-  }
-  if (err == ERR_OK) {
-    netconn_free(conn);
-  }
-  return err;
-}
-
 /**
 * Get the local or remote IP address and port of a netconn.
 * For RAW netconns, this returns the protocol instead of a port!
@@ -298,7 +241,7 @@ netconn_getaddr(struct netconn *conn, ip_addr_t *addr, u16_t *port, u8_t local)
 * Binding one netconn twice might not always be checked correctly!
 *
 * @param conn the netconn to bind
- * @param addr the local IP address to bind the netconn to
+ * @param addr the local IP address to bind the netconn to 
 *             (use IP4_ADDR_ANY/IP6_ADDR_ANY to bind to all addresses)
 * @param port the local port to bind the netconn to (not used for RAW)
 * @return ERR_OK if bound, any other err_t on failure
@@ -308,7 +251,7 @@ netconn_bind(struct netconn *conn, const ip_addr_t *addr, u16_t port)
 {
  API_MSG_VAR_DECLARE(msg);
  err_t err;
-
+  
  LWIP_ERROR("netconn_bind: invalid conn", (conn != NULL), return ERR_ARG;);

 #if LWIP_IPV4
@@ -317,13 +260,13 @@ netconn_bind(struct netconn *conn, const ip_addr_t *addr, u16_t port)
    addr = IP4_ADDR_ANY;
  }
 #endif /* LWIP_IPV4 */
-
+  
 #if LWIP_IPV4 && LWIP_IPV6
  /* "Socket API like" dual-stack support: If IP to bind to is IP6_ADDR_ANY,
   * and NETCONN_FLAG_IPV6_V6ONLY is 0, use IP_ANY_TYPE to bind
   */
  if ((netconn_get_ipv6only(conn) == 0) &&
-      ip_addr_cmp(addr, IP6_ADDR_ANY)) {
+     ip_addr_cmp(addr, IP6_ADDR_ANY)) {
    addr = IP_ANY_TYPE;
  }
 #endif /* LWIP_IPV4 && LWIP_IPV6 */
@@ -338,32 +281,6 @@ netconn_bind(struct netconn *conn, const ip_addr_t *addr, u16_t port)
  return err;
 }

-/**
- * @ingroup netconn_common
- * Bind a netconn to a specific interface and port.
- * Binding one netconn twice might not always be checked correctly!
- *
- * @param conn the netconn to bind
- * @param if_idx the local interface index to bind the netconn to
- * @return ERR_OK if bound, any other err_t on failure
- */
-err_t
-netconn_bind_if(struct netconn *conn, u8_t if_idx)
-{
-  API_MSG_VAR_DECLARE(msg);
-  err_t err;
-
-  LWIP_ERROR("netconn_bind_if: invalid conn", (conn != NULL), return ERR_ARG;);
-
-  API_MSG_VAR_ALLOC(msg);
-  API_MSG_VAR_REF(msg).conn = conn;
-  API_MSG_VAR_REF(msg).msg.bc.if_idx = if_idx;
-  err = netconn_apimsg(lwip_netconn_do_bind_if, &API_MSG_VAR_REF(msg));
-  API_MSG_VAR_FREE(msg);
-
-  return err;
-}
-
 /**
 * @ingroup netconn_common
 * Connect a netconn to a specific remote IP address and port.
@@ -471,7 +388,6 @@ err_t
 netconn_accept(struct netconn *conn, struct netconn **new_conn)
 {
 #if LWIP_TCP
-  err_t err;
  void *accept_ptr;
  struct netconn *newconn;
 #if TCP_LISTEN_BACKLOG
@@ -482,65 +398,52 @@ netconn_accept(struct netconn *conn, struct netconn **new_conn)
  *new_conn = NULL;
  LWIP_ERROR("netconn_accept: invalid conn",       (conn != NULL),                      return ERR_ARG;);

-  /* NOTE: Although the opengroup spec says a pending error shall be returned to
-           send/recv/getsockopt(SO_ERROR) only, we return it for listening
-           connections also, to handle embedded-system errors */
-  err = netconn_err(conn);
-  if (err != ERR_OK) {
-    /* return pending error */
-    return err;
-  }
-  if (!NETCONN_ACCEPTMBOX_WAITABLE(conn)) {
-    /* don't accept if closed: this might block the application task
+  if (ERR_IS_FATAL(conn->last_err)) {
+    /* don't recv on fatal errors: this might block the application task
       waiting on acceptmbox forever! */
+    return conn->last_err;
+  }
+  if (!sys_mbox_valid(&conn->acceptmbox)) {
    return ERR_CLSD;
  }

-  API_MSG_VAR_ALLOC_ACCEPT(msg);
+#if TCP_LISTEN_BACKLOG
+  API_MSG_VAR_ALLOC(msg);
+#endif /* TCP_LISTEN_BACKLOG */

-  NETCONN_MBOX_WAITING_INC(conn);
-  if (netconn_is_nonblocking(conn)) {
-    if (sys_arch_mbox_tryfetch(&conn->acceptmbox, &accept_ptr) == SYS_ARCH_TIMEOUT) {
-      API_MSG_VAR_FREE_ACCEPT(msg);
-      NETCONN_MBOX_WAITING_DEC(conn);
-      return ERR_WOULDBLOCK;
-    }
-  } else {
 #if LWIP_SO_RCVTIMEO
-    if (sys_arch_mbox_fetch(&conn->acceptmbox, &accept_ptr, conn->recv_timeout) == SYS_ARCH_TIMEOUT) {
-      API_MSG_VAR_FREE_ACCEPT(msg);
-      NETCONN_MBOX_WAITING_DEC(conn);
-      return ERR_TIMEOUT;
-    }
+  if (sys_arch_mbox_fetch(&conn->acceptmbox, &accept_ptr, conn->recv_timeout) == SYS_ARCH_TIMEOUT) {
+#if TCP_LISTEN_BACKLOG
+    API_MSG_VAR_FREE(msg);
+#endif /* TCP_LISTEN_BACKLOG */
+    return ERR_TIMEOUT;
+  }
 #else
-    sys_arch_mbox_fetch(&conn->acceptmbox, &accept_ptr, 0);
+  sys_arch_mbox_fetch(&conn->acceptmbox, &accept_ptr, 0);
 #endif /* LWIP_SO_RCVTIMEO*/
-  }
-  NETCONN_MBOX_WAITING_DEC(conn);
-#if LWIP_NETCONN_FULLDUPLEX
-  if (conn->flags & NETCONN_FLAG_MBOXINVALID) {
-    if (lwip_netconn_is_deallocated_msg(accept_ptr)) {
-      /* the netconn has been closed from another thread */
-      API_MSG_VAR_FREE_ACCEPT(msg);
-      return ERR_CONN;
-    }
-  }
-#endif
-
+  newconn = (struct netconn *)accept_ptr;
  /* Register event with callback */
  API_EVENT(conn, NETCONN_EVT_RCVMINUS, 0);

-  if (lwip_netconn_is_err_msg(accept_ptr, &err)) {
-    /* a connection has been aborted: e.g. out of pcbs or out of netconns during accept */
-    API_MSG_VAR_FREE_ACCEPT(msg);
-    return err;
+  if (accept_ptr == &netconn_aborted) {
+    /* a connection has been aborted: out of pcbs or out of netconns during accept */
+    /* @todo: set netconn error, but this would be fatal and thus block further accepts */
+#if TCP_LISTEN_BACKLOG
+    API_MSG_VAR_FREE(msg);
+#endif /* TCP_LISTEN_BACKLOG */
+    return ERR_ABRT;
  }
-  if (accept_ptr == NULL) {
+  if (newconn == NULL) {
    /* connection has been aborted */
-    API_MSG_VAR_FREE_ACCEPT(msg);
+    /* in this special case, we set the netconn error from application thread, as
+       on a ready-to-accept listening netconn, there should not be anything running
+       in tcpip_thread */
+    NETCONN_SET_SAFE_ERR(conn, ERR_CLSD);
+#if TCP_LISTEN_BACKLOG
+    API_MSG_VAR_FREE(msg);
+#endif /* TCP_LISTEN_BACKLOG */
    return ERR_CLSD;
  }
-  newconn = (struct netconn *)accept_ptr;
 #if TCP_LISTEN_BACKLOG
  /* Let the stack know that we have accepted the connection. */
  API_MSG_VAR_REF(msg).conn = newconn;
@@ -562,89 +465,103 @@ netconn_accept(struct netconn *conn, struct netconn **new_conn)
 /**
 * @ingroup netconn_common
 * Receive data: actual implementation that doesn't care whether pbuf or netbuf
- * is received (this is internal, it's just here for describing common errors)
+ * is received
 *
 * @param conn the netconn from which to receive data
 * @param new_buf pointer where a new pbuf/netbuf is stored when received data
- * @param apiflags flags that control function behaviour. For now only:
- * - NETCONN_DONTBLOCK: only read data that is available now, don't wait for more data
 * @return ERR_OK if data has been received, an error code otherwise (timeout,
 *                memory error or another error)
- *         ERR_CONN if not connected
- *         ERR_CLSD if TCP connection has been closed
- *         ERR_WOULDBLOCK if the netconn is nonblocking but would block to wait for data
- *         ERR_TIMEOUT if the netconn has a receive timeout and no data was received
 */
 static err_t
-netconn_recv_data(struct netconn *conn, void **new_buf, u8_t apiflags)
+netconn_recv_data(struct netconn *conn, void **new_buf)
 {
  void *buf = NULL;
  u16_t len;
+#if LWIP_TCP
+  API_MSG_VAR_DECLARE(msg);
+#if LWIP_MPU_COMPATIBLE
+  msg = NULL;
+#endif
+#endif /* LWIP_TCP */

  LWIP_ERROR("netconn_recv: invalid pointer", (new_buf != NULL), return ERR_ARG;);
  *new_buf = NULL;
  LWIP_ERROR("netconn_recv: invalid conn",    (conn != NULL),    return ERR_ARG;);
-
-  if (!NETCONN_RECVMBOX_WAITABLE(conn)) {
-    err_t err = netconn_err(conn);
-    if (err != ERR_OK) {
-      /* return pending error */
-      return err;
+#if LWIP_TCP
+#if (LWIP_UDP || LWIP_RAW)
+  if (NETCONNTYPE_GROUP(conn->type) == NETCONN_TCP)
+#endif /* (LWIP_UDP || LWIP_RAW) */
+  {
+    if (!sys_mbox_valid(&conn->recvmbox)) {
+      /* This happens when calling this function after receiving FIN */
+      return sys_mbox_valid(&conn->acceptmbox) ? ERR_CONN : ERR_CLSD;
    }
-    return ERR_CONN;
  }
+#endif /* LWIP_TCP */
+  LWIP_ERROR("netconn_recv: invalid recvmbox", sys_mbox_valid(&conn->recvmbox), return ERR_CONN;);
+
+  if (ERR_IS_FATAL(conn->last_err)) {
+    /* don't recv on fatal errors: this might block the application task
+       waiting on recvmbox forever! */
+    /* @todo: this does not allow us to fetch data that has been put into recvmbox
+       before the fatal error occurred - is that a problem? */
+    return conn->last_err;
+  }
+#if LWIP_TCP
+#if (LWIP_UDP || LWIP_RAW)
+  if (NETCONNTYPE_GROUP(conn->type) == NETCONN_TCP)
+#endif /* (LWIP_UDP || LWIP_RAW) */
+  {
+    API_MSG_VAR_ALLOC(msg);
+  }
+#endif /* LWIP_TCP */

-  NETCONN_MBOX_WAITING_INC(conn);
-  if (netconn_is_nonblocking(conn) || (apiflags & NETCONN_DONTBLOCK) ||
-      (conn->flags & NETCONN_FLAG_MBOXCLOSED) || (conn->pending_err != ERR_OK)) {
-    if (sys_arch_mbox_tryfetch(&conn->recvmbox, &buf) == SYS_ARCH_TIMEOUT) {
-      err_t err;
-      NETCONN_MBOX_WAITING_DEC(conn);
-      err = netconn_err(conn);
-      if (err != ERR_OK) {
-        /* return pending error */
-        return err;
-      }
-      if (conn->flags & NETCONN_FLAG_MBOXCLOSED) {
-        return ERR_CONN;
-      }
-      return ERR_WOULDBLOCK;
-    }
-  } else {
 #if LWIP_SO_RCVTIMEO
-    if (sys_arch_mbox_fetch(&conn->recvmbox, &buf, conn->recv_timeout) == SYS_ARCH_TIMEOUT) {
-      NETCONN_MBOX_WAITING_DEC(conn);
-      return ERR_TIMEOUT;
+  if (sys_arch_mbox_fetch(&conn->recvmbox, &buf, conn->recv_timeout) == SYS_ARCH_TIMEOUT) {
+#if LWIP_TCP
+#if (LWIP_UDP || LWIP_RAW)
+    if (NETCONNTYPE_GROUP(conn->type) == NETCONN_TCP)
+#endif /* (LWIP_UDP || LWIP_RAW) */
+    {
+      API_MSG_VAR_FREE(msg);
    }
+#endif /* LWIP_TCP */
+    return ERR_TIMEOUT;
+  }
 #else
-    sys_arch_mbox_fetch(&conn->recvmbox, &buf, 0);
+  sys_arch_mbox_fetch(&conn->recvmbox, &buf, 0);
 #endif /* LWIP_SO_RCVTIMEO*/
-  }
-  NETCONN_MBOX_WAITING_DEC(conn);
-#if LWIP_NETCONN_FULLDUPLEX
-  if (conn->flags & NETCONN_FLAG_MBOXINVALID) {
-    if (lwip_netconn_is_deallocated_msg(buf)) {
-      /* the netconn has been closed from another thread */
-      API_MSG_VAR_FREE_ACCEPT(msg);
-      return ERR_CONN;
-    }
-  }
-#endif

 #if LWIP_TCP
 #if (LWIP_UDP || LWIP_RAW)
  if (NETCONNTYPE_GROUP(conn->type) == NETCONN_TCP)
 #endif /* (LWIP_UDP || LWIP_RAW) */
  {
-    err_t err;
-    /* Check if this is an error message or a pbuf */
-    if (lwip_netconn_is_err_msg(buf, &err)) {
-      /* new_buf has been zeroed above already */
-      if (err == ERR_CLSD) {
-        /* connection closed translates to ERR_OK with *new_buf == NULL */
-        return ERR_OK;
+    /* Let the stack know that we have taken the data. */
+    /* @todo: Speedup: Don't block and wait for the answer here
+       (to prevent multiple thread-switches). */
+    API_MSG_VAR_REF(msg).conn = conn;
+    if (buf != NULL) {
+      API_MSG_VAR_REF(msg).msg.r.len = ((struct pbuf *)buf)->tot_len;
+    } else {
+      API_MSG_VAR_REF(msg).msg.r.len = 1;
+    }
+
+    /* don't care for the return value of lwip_netconn_do_recv */
+    netconn_apimsg(lwip_netconn_do_recv, &API_MSG_VAR_REF(msg));
+    API_MSG_VAR_FREE(msg);
+
+    /* If we are closed, we indicate that we no longer wish to use the socket */
+    if (buf == NULL) {
+      API_EVENT(conn, NETCONN_EVT_RCVMINUS, 0);
+      if (conn->pcb.ip == NULL) {
+        /* race condition: RST during recv */
+        return conn->last_err == ERR_OK ? ERR_RST : conn->last_err;
      }
-      return err;
+      /* RX side is closed, so deallocate the recvmbox */
+      netconn_close_shutdown(conn, NETCONN_SHUT_RD);
+      /* Don' store ERR_CLSD as conn->err since we are only half-closed */
+      return ERR_CLSD;
    }
    len = ((struct pbuf *)buf)->tot_len;
  }
@@ -655,7 +572,7 @@ netconn_recv_data(struct netconn *conn, void **new_buf, u8_t apiflags)
 #if (LWIP_UDP || LWIP_RAW)
  {
    LWIP_ASSERT("buf != NULL", buf != NULL);
-    len = netbuf_len((struct netbuf *)buf);
+    len = netbuf_len((struct netbuf*)buf);
  }
 #endif /* (LWIP_UDP || LWIP_RAW) */

@@ -672,102 +589,6 @@ netconn_recv_data(struct netconn *conn, void **new_buf, u8_t apiflags)
  return ERR_OK;
 }

-#if LWIP_TCP
-static err_t
-netconn_tcp_recvd_msg(struct netconn *conn, size_t len, struct api_msg *msg)
-{
-  LWIP_ERROR("netconn_recv_tcp_pbuf: invalid conn", (conn != NULL) &&
-             NETCONNTYPE_GROUP(netconn_type(conn)) == NETCONN_TCP, return ERR_ARG;);
-
-  msg->conn = conn;
-  msg->msg.r.len = len;
-
-  return netconn_apimsg(lwip_netconn_do_recv, msg);
-}
-
-err_t
-netconn_tcp_recvd(struct netconn *conn, size_t len)
-{
-  err_t err;
-  API_MSG_VAR_DECLARE(msg);
-  LWIP_ERROR("netconn_recv_tcp_pbuf: invalid conn", (conn != NULL) &&
-             NETCONNTYPE_GROUP(netconn_type(conn)) == NETCONN_TCP, return ERR_ARG;);
-
-  API_MSG_VAR_ALLOC(msg);
-  err = netconn_tcp_recvd_msg(conn, len, &API_VAR_REF(msg));
-  API_MSG_VAR_FREE(msg);
-  return err;
-}
-
-static err_t
-netconn_recv_data_tcp(struct netconn *conn, struct pbuf **new_buf, u8_t apiflags)
-{
-  err_t err;
-  struct pbuf *buf;
-  API_MSG_VAR_DECLARE(msg);
-#if LWIP_MPU_COMPATIBLE
-  msg = NULL;
-#endif
-
-  if (!NETCONN_RECVMBOX_WAITABLE(conn)) {
-    /* This only happens when calling this function more than once *after* receiving FIN */
-    return ERR_CONN;
-  }
-  if (netconn_is_flag_set(conn, NETCONN_FIN_RX_PENDING)) {
-    netconn_clear_flags(conn, NETCONN_FIN_RX_PENDING);
-    goto handle_fin;
-  }
-
-  if (!(apiflags & NETCONN_NOAUTORCVD)) {
-    /* need to allocate API message here so empty message pool does not result in event loss
-      * see bug #47512: MPU_COMPATIBLE may fail on empty pool */
-    API_MSG_VAR_ALLOC(msg);
-  }
-
-  err = netconn_recv_data(conn, (void **)new_buf, apiflags);
-  if (err != ERR_OK) {
-    if (!(apiflags & NETCONN_NOAUTORCVD)) {
-      API_MSG_VAR_FREE(msg);
-    }
-    return err;
-  }
-  buf = *new_buf;
-  if (!(apiflags & NETCONN_NOAUTORCVD)) {
-    /* Let the stack know that we have taken the data. */
-    u16_t len = buf ? buf->tot_len : 1;
-    /* don't care for the return value of lwip_netconn_do_recv */
-    /* @todo: this should really be fixed, e.g. by retrying in poll on error */
-    netconn_tcp_recvd_msg(conn, len,  &API_VAR_REF(msg));
-    API_MSG_VAR_FREE(msg);
-  }
-
-  /* If we are closed, we indicate that we no longer wish to use the socket */
-  if (buf == NULL) {
-    if (apiflags & NETCONN_NOFIN) {
-      /* received a FIN but the caller cannot handle it right now:
-         re-enqueue it and return "no data" */
-      netconn_set_flags(conn, NETCONN_FIN_RX_PENDING);
-      return ERR_WOULDBLOCK;
-    } else {
-handle_fin:
-      API_EVENT(conn, NETCONN_EVT_RCVMINUS, 0);
-      if (conn->pcb.ip == NULL) {
-        /* race condition: RST during recv */
-        err = netconn_err(conn);
-        if (err != ERR_OK) {
-          return err;
-        }
-        return ERR_RST;
-      }
-      /* RX side is closed, so deallocate the recvmbox */
-      netconn_close_shutdown(conn, NETCONN_SHUT_RD);
-      /* Don' store ERR_CLSD as conn->err since we are only half-closed */
-      return ERR_CLSD;
-    }
-  }
-  return err;
-}
-
 /**
 * @ingroup netconn_tcp
 * Receive data (in form of a pbuf) from a TCP netconn
@@ -775,76 +596,16 @@ handle_fin:
 * @param conn the netconn from which to receive data
 * @param new_buf pointer where a new pbuf is stored when received data
 * @return ERR_OK if data has been received, an error code otherwise (timeout,
- *                memory error or another error, @see netconn_recv_data)
+ *                memory error or another error)
 *         ERR_ARG if conn is not a TCP netconn
 */
 err_t
 netconn_recv_tcp_pbuf(struct netconn *conn, struct pbuf **new_buf)
 {
-  LWIP_ERROR("netconn_recv_tcp_pbuf: invalid conn", (conn != NULL) &&
+  LWIP_ERROR("netconn_recv: invalid conn", (conn != NULL) &&
             NETCONNTYPE_GROUP(netconn_type(conn)) == NETCONN_TCP, return ERR_ARG;);

-  return netconn_recv_data_tcp(conn, new_buf, 0);
-}
-
-/**
- * @ingroup netconn_tcp
- * Receive data (in form of a pbuf) from a TCP netconn
- *
- * @param conn the netconn from which to receive data
- * @param new_buf pointer where a new pbuf is stored when received data
- * @param apiflags flags that control function behaviour. For now only:
- * - NETCONN_DONTBLOCK: only read data that is available now, don't wait for more data
- * @return ERR_OK if data has been received, an error code otherwise (timeout,
- *                memory error or another error, @see netconn_recv_data)
- *         ERR_ARG if conn is not a TCP netconn
- */
-err_t
-netconn_recv_tcp_pbuf_flags(struct netconn *conn, struct pbuf **new_buf, u8_t apiflags)
-{
-  LWIP_ERROR("netconn_recv_tcp_pbuf: invalid conn", (conn != NULL) &&
-             NETCONNTYPE_GROUP(netconn_type(conn)) == NETCONN_TCP, return ERR_ARG;);
-
-  return netconn_recv_data_tcp(conn, new_buf, apiflags);
-}
-#endif /* LWIP_TCP */
-
-/**
- * Receive data (in form of a netbuf) from a UDP or RAW netconn
- *
- * @param conn the netconn from which to receive data
- * @param new_buf pointer where a new netbuf is stored when received data
- * @return ERR_OK if data has been received, an error code otherwise (timeout,
- *                memory error or another error)
- *         ERR_ARG if conn is not a UDP/RAW netconn
- */
-err_t
-netconn_recv_udp_raw_netbuf(struct netconn *conn, struct netbuf **new_buf)
-{
-  LWIP_ERROR("netconn_recv_udp_raw_netbuf: invalid conn", (conn != NULL) &&
-             NETCONNTYPE_GROUP(netconn_type(conn)) != NETCONN_TCP, return ERR_ARG;);
-
-  return netconn_recv_data(conn, (void **)new_buf, 0);
-}
-
-/**
- * Receive data (in form of a netbuf) from a UDP or RAW netconn
- *
- * @param conn the netconn from which to receive data
- * @param new_buf pointer where a new netbuf is stored when received data
- * @param apiflags flags that control function behaviour. For now only:
- * - NETCONN_DONTBLOCK: only read data that is available now, don't wait for more data
- * @return ERR_OK if data has been received, an error code otherwise (timeout,
- *                memory error or another error)
- *         ERR_ARG if conn is not a UDP/RAW netconn
- */
-err_t
-netconn_recv_udp_raw_netbuf_flags(struct netconn *conn, struct netbuf **new_buf, u8_t apiflags)
-{
-  LWIP_ERROR("netconn_recv_udp_raw_netbuf: invalid conn", (conn != NULL) &&
-             NETCONNTYPE_GROUP(netconn_type(conn)) != NETCONN_TCP, return ERR_ARG;);
-
-  return netconn_recv_data(conn, (void **)new_buf, apiflags);
+  return netconn_recv_data(conn, (void **)new_buf);
 }

 /**
@@ -881,7 +642,7 @@ netconn_recv(struct netconn *conn, struct netbuf **new_buf)
      return ERR_MEM;
    }

-    err = netconn_recv_data_tcp(conn, &p, 0);
+    err = netconn_recv_data(conn, (void **)&p);
    if (err != ERR_OK) {
      memp_free(MEMP_NETBUF, buf);
      return err;
@@ -902,7 +663,7 @@ netconn_recv(struct netconn *conn, struct netbuf **new_buf)
 #endif /* LWIP_TCP && (LWIP_UDP || LWIP_RAW) */
  {
 #if (LWIP_UDP || LWIP_RAW)
-    return netconn_recv_data(conn, (void **)new_buf, 0);
+    return netconn_recv_data(conn, (void **)new_buf);
 #endif /* (LWIP_UDP || LWIP_RAW) */
  }
 }
@@ -973,38 +734,16 @@ netconn_send(struct netconn *conn, struct netbuf *buf)
 err_t
 netconn_write_partly(struct netconn *conn, const void *dataptr, size_t size,
                     u8_t apiflags, size_t *bytes_written)
-{
-  struct netvector vector;
-  vector.ptr = dataptr;
-  vector.len = size;
-  return netconn_write_vectors_partly(conn, &vector, 1, apiflags, bytes_written);
-}
-
-/**
- * Send vectorized data atomically over a TCP netconn.
- *
- * @param conn the TCP netconn over which to send data
- * @param vectors array of vectors containing data to send
- * @param vectorcnt number of vectors in the array
- * @param apiflags combination of following flags :
- * - NETCONN_COPY: data will be copied into memory belonging to the stack
- * - NETCONN_MORE: for TCP connection, PSH flag will be set on last segment sent
- * - NETCONN_DONTBLOCK: only write the data if all data can be written at once
- * @param bytes_written pointer to a location that receives the number of written bytes
- * @return ERR_OK if data was sent, any other err_t on error
- */
-err_t
-netconn_write_vectors_partly(struct netconn *conn, struct netvector *vectors, u16_t vectorcnt,
-                             u8_t apiflags, size_t *bytes_written)
 {
  API_MSG_VAR_DECLARE(msg);
  err_t err;
  u8_t dontblock;
-  size_t size;
-  int i;

  LWIP_ERROR("netconn_write: invalid conn",  (conn != NULL), return ERR_ARG;);
-  LWIP_ERROR("netconn_write: invalid conn->type",  (NETCONNTYPE_GROUP(conn->type) == NETCONN_TCP), return ERR_VAL;);
+  LWIP_ERROR("netconn_write: invalid conn->type",  (NETCONNTYPE_GROUP(conn->type)== NETCONN_TCP), return ERR_VAL;);
+  if (size == 0) {
+    return ERR_OK;
+  }
  dontblock = netconn_is_nonblocking(conn) || (apiflags & NETCONN_DONTBLOCK);
 #if LWIP_SO_SNDTIMEO
  if (conn->send_timeout != 0) {
@@ -1017,37 +756,12 @@ netconn_write_vectors_partly(struct netconn *conn, struct netvector *vectors, u1
    return ERR_VAL;
  }

-  /* sum up the total size */
-  size = 0;
-  for (i = 0; i < vectorcnt; i++) {
-    size += vectors[i].len;
-    if (size < vectors[i].len) {
-      /* overflow */
-      return ERR_VAL;
-    }
-  }
-  if (size == 0) {
-    return ERR_OK;
-  } else if (size > SSIZE_MAX) {
-    ssize_t limited;
-    /* this is required by the socket layer (cannot send full size_t range) */
-    if (!bytes_written) {
-      return ERR_VAL;
-    }
-    /* limit the amount of data to send */
-    limited = SSIZE_MAX;
-    size = (size_t)limited;
-  }
-
  API_MSG_VAR_ALLOC(msg);
  /* non-blocking write sends as much  */
  API_MSG_VAR_REF(msg).conn = conn;
-  API_MSG_VAR_REF(msg).msg.w.vector = vectors;
-  API_MSG_VAR_REF(msg).msg.w.vector_cnt = vectorcnt;
-  API_MSG_VAR_REF(msg).msg.w.vector_off = 0;
+  API_MSG_VAR_REF(msg).msg.w.dataptr = dataptr;
  API_MSG_VAR_REF(msg).msg.w.apiflags = apiflags;
  API_MSG_VAR_REF(msg).msg.w.len = size;
-  API_MSG_VAR_REF(msg).msg.w.offset = 0;
 #if LWIP_SO_SNDTIMEO
  if (conn->send_timeout != 0) {
    /* get the time we started, which is later compared to
@@ -1062,14 +776,13 @@ netconn_write_vectors_partly(struct netconn *conn, struct netvector *vectors, u1
     but if it is, this is done inside api_msg.c:do_write(), so we can use the
     non-blocking version here. */
  err = netconn_apimsg(lwip_netconn_do_write, &API_MSG_VAR_REF(msg));
-  if (err == ERR_OK) {
-    if (bytes_written != NULL) {
-      *bytes_written = API_MSG_VAR_REF(msg).msg.w.offset;
-    }
-    /* for blocking, check all requested bytes were written, NOTE: send_timeout is
-       treated as dontblock (see dontblock assignment above) */
-    if (!dontblock) {
-      LWIP_ASSERT("do_write failed to write all bytes", API_MSG_VAR_REF(msg).msg.w.offset == size);
+  if ((err == ERR_OK) && (bytes_written != NULL)) {
+    if (dontblock) {
+      /* nonblocking write: maybe the data has been sent partly */
+      *bytes_written = API_MSG_VAR_REF(msg).msg.w.len;
+    } else {
+      /* blocking call succeeded: all data has been sent if it */
+      *bytes_written = size;
    }
  }
  API_MSG_VAR_FREE(msg);
@@ -1128,28 +841,6 @@ netconn_close(struct netconn *conn)
  return netconn_close_shutdown(conn, NETCONN_SHUT_RDWR);
 }

-/**
- * @ingroup netconn_common
- * Get and reset pending error on a netconn
- *
- * @param conn the netconn to get the error from
- * @return and pending error or ERR_OK if no error was pending
- */
-err_t
-netconn_err(struct netconn *conn)
-{
-  err_t err;
-  SYS_ARCH_DECL_PROTECT(lev);
-  if (conn == NULL) {
-    return ERR_OK;
-  }
-  SYS_ARCH_PROTECT(lev);
-  err = conn->pending_err;
-  conn->pending_err = ERR_OK;
-  SYS_ARCH_UNPROTECT(lev);
-  return err;
-}
-
 /**
 * @ingroup netconn_tcp
 * Shut down one or both sides of a TCP netconn (doesn't delete it).
@@ -1162,7 +853,7 @@ netconn_err(struct netconn *conn)
 err_t
 netconn_shutdown(struct netconn *conn, u8_t shut_rx, u8_t shut_tx)
 {
-  return netconn_close_shutdown(conn, (u8_t)((shut_rx ? NETCONN_SHUT_RD : 0) | (shut_tx ? NETCONN_SHUT_WR : 0)));
+  return netconn_close_shutdown(conn, (shut_rx ? NETCONN_SHUT_RD : 0) | (shut_tx ? NETCONN_SHUT_WR : 0));
 }

 #if LWIP_IGMP || (LWIP_IPV6 && LWIP_IPV6_MLD)
@@ -1209,48 +900,6 @@ netconn_join_leave_group(struct netconn *conn,

  return err;
 }
-/**
- * @ingroup netconn_udp
- * Join multicast groups for UDP netconns.
- *
- * @param conn the UDP netconn for which to change multicast addresses
- * @param multiaddr IP address of the multicast group to join or leave
- * @param if_idx the index of the netif
- * @param join_or_leave flag whether to send a join- or leave-message
- * @return ERR_OK if the action was taken, any err_t on error
- */
-err_t
-netconn_join_leave_group_netif(struct netconn *conn,
-                               const ip_addr_t *multiaddr,
-                               u8_t if_idx,
-                               enum netconn_igmp join_or_leave)
-{
-  API_MSG_VAR_DECLARE(msg);
-  err_t err;
-
-  LWIP_ERROR("netconn_join_leave_group: invalid conn",  (conn != NULL), return ERR_ARG;);
-
-  API_MSG_VAR_ALLOC(msg);
-
-#if LWIP_IPV4
-  /* Don't propagate NULL pointer (IP_ADDR_ANY alias) to subsequent functions */
-  if (multiaddr == NULL) {
-    multiaddr = IP4_ADDR_ANY;
-  }
-  if (if_idx == NETIF_NO_INDEX) {
-    return ERR_IF;
-  }
-#endif /* LWIP_IPV4 */
-
-  API_MSG_VAR_REF(msg).conn = conn;
-  API_MSG_VAR_REF(msg).msg.jl.multiaddr = API_MSG_VAR_REF(multiaddr);
-  API_MSG_VAR_REF(msg).msg.jl.if_idx = if_idx;
-  API_MSG_VAR_REF(msg).msg.jl.join_or_leave = join_or_leave;
-  err = netconn_apimsg(lwip_netconn_do_join_leave_group_netif, &API_MSG_VAR_REF(msg));
-  API_MSG_VAR_FREE(msg);
-
-  return err;
-}
 #endif /* LWIP_IGMP || (LWIP_IPV6 && LWIP_IPV6_MLD) */

 #if LWIP_DNS
@@ -1289,20 +938,10 @@ netconn_gethostbyname(const char *name, ip_addr_t *addr)
  }
 #endif

-#ifdef LWIP_HOOK_NETCONN_EXTERNAL_RESOLVE
-#if LWIP_IPV4 && LWIP_IPV6
-  if (LWIP_HOOK_NETCONN_EXTERNAL_RESOLVE(name, addr, dns_addrtype, &err)) {
-#else
-  if (LWIP_HOOK_NETCONN_EXTERNAL_RESOLVE(name, addr, NETCONN_DNS_DEFAULT, &err)) {
-#endif /* LWIP_IPV4 && LWIP_IPV6 */
-    return err;
-  }
-#endif /* LWIP_HOOK_NETCONN_EXTERNAL_RESOLVE */
-
  API_VAR_ALLOC(struct dns_api_msg, MEMP_DNS_API_MSG, msg, ERR_MEM);
 #if LWIP_MPU_COMPATIBLE
-  strncpy(API_VAR_REF(msg).name, name, DNS_MAX_NAME_LENGTH - 1);
-  API_VAR_REF(msg).name[DNS_MAX_NAME_LENGTH - 1] = 0;
+  strncpy(API_VAR_REF(msg).name, name, DNS_MAX_NAME_LENGTH-1);
+  API_VAR_REF(msg).name[DNS_MAX_NAME_LENGTH-1] = 0;
 #else /* LWIP_MPU_COMPATIBLE */
  msg.err = &err;
  msg.sem = &sem;
@@ -1322,14 +961,18 @@ netconn_gethostbyname(const char *name, ip_addr_t *addr)
  }
 #endif /* LWIP_NETCONN_SEM_PER_THREAD */

-  cberr = tcpip_send_msg_wait_sem(lwip_netconn_do_gethostbyname, &API_VAR_REF(msg), API_EXPR_REF(API_VAR_REF(msg).sem));
-#if !LWIP_NETCONN_SEM_PER_THREAD
-  sys_sem_free(API_EXPR_REF(API_VAR_REF(msg).sem));
-#endif /* !LWIP_NETCONN_SEM_PER_THREAD */
+  cberr = tcpip_callback(lwip_netconn_do_gethostbyname, &API_VAR_REF(msg));
  if (cberr != ERR_OK) {
+#if !LWIP_NETCONN_SEM_PER_THREAD
+    sys_sem_free(API_EXPR_REF(API_VAR_REF(msg).sem));
+#endif /* !LWIP_NETCONN_SEM_PER_THREAD */
    API_VAR_FREE(MEMP_DNS_API_MSG, msg);
    return cberr;
  }
+  sys_sem_wait(API_EXPR_REF_SEM(API_VAR_REF(msg).sem));
+#if !LWIP_NETCONN_SEM_PER_THREAD
+  sys_sem_free(API_EXPR_REF(API_VAR_REF(msg).sem));
+#endif /* !LWIP_NETCONN_SEM_PER_THREAD */

 #if LWIP_MPU_COMPATIBLE
  *addr = msg->addr;
--- a/src/api/api_msg.c
+++ b/src/api/api_msg.c
--- a/src/api/err.c
+++ b/src/api/err.c
@@ -78,23 +78,23 @@ err_to_errno(err_t err)
 #ifdef LWIP_DEBUG

 static const char *err_strerr[] = {
-  "Ok.",                    /* ERR_OK          0  */
-  "Out of memory error.",   /* ERR_MEM        -1  */
-  "Buffer error.",          /* ERR_BUF        -2  */
-  "Timeout.",               /* ERR_TIMEOUT    -3  */
-  "Routing problem.",       /* ERR_RTE        -4  */
-  "Operation in progress.", /* ERR_INPROGRESS -5  */
-  "Illegal value.",         /* ERR_VAL        -6  */
-  "Operation would block.", /* ERR_WOULDBLOCK -7  */
-  "Address in use.",        /* ERR_USE        -8  */
-  "Already connecting.",    /* ERR_ALREADY    -9  */
-  "Already connected.",     /* ERR_ISCONN     -10 */
-  "Not connected.",         /* ERR_CONN       -11 */
-  "Low-level netif error.", /* ERR_IF         -12 */
-  "Connection aborted.",    /* ERR_ABRT       -13 */
-  "Connection reset.",      /* ERR_RST        -14 */
-  "Connection closed.",     /* ERR_CLSD       -15 */
-  "Illegal argument."       /* ERR_ARG        -16 */
+           "Ok.",                    /* ERR_OK          0  */
+           "Out of memory error.",   /* ERR_MEM        -1  */
+           "Buffer error.",          /* ERR_BUF        -2  */
+           "Timeout.",               /* ERR_TIMEOUT    -3  */
+           "Routing problem.",       /* ERR_RTE        -4  */
+           "Operation in progress.", /* ERR_INPROGRESS -5  */
+           "Illegal value.",         /* ERR_VAL        -6  */
+           "Operation would block.", /* ERR_WOULDBLOCK -7  */
+           "Address in use.",        /* ERR_USE        -8  */
+           "Already connecting.",    /* ERR_ALREADY    -9  */
+           "Already connected.",     /* ERR_ISCONN     -10 */
+           "Not connected.",         /* ERR_CONN       -11 */
+           "Low-level netif error.", /* ERR_IF         -12 */
+           "Connection aborted.",    /* ERR_ABRT       -13 */
+           "Connection reset.",      /* ERR_RST        -14 */
+           "Connection closed.",     /* ERR_CLSD       -15 */
+           "Illegal argument."       /* ERR_ARG        -16 */
 };

 /**
--- a/src/api/if_api.c
+++ b/src/api/if_api.c
@@ -1,102 +0,0 @@
-/**
- * @file
- * Interface Identification APIs from:
- *              RFC 3493: Basic Socket Interface Extensions for IPv6
- *                  Section 4: Interface Identification
- *
- * @defgroup if_api Interface Identification API
- * @ingroup socket
- */
-
-/*
- * Copyright (c) 2017 Joel Cunningham, Garmin International, Inc. <joel.cunningham@garmin.com>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Joel Cunningham <joel.cunningham@me.com>
- *
- */
-#include "lwip/opt.h"
-
-#if LWIP_SOCKET
-
-#include "lwip/errno.h"
-#include "lwip/if_api.h"
-#include "lwip/netifapi.h"
-#include "lwip/priv/sockets_priv.h"
-
-/**
- * @ingroup if_api
- * Maps an interface index to its corresponding name.
- * @param ifindex interface index
- * @param ifname shall point to a buffer of at least {IF_NAMESIZE} bytes
- * @return If ifindex is an interface index, then the function shall return the
- * value supplied in ifname, which points to a buffer now containing the interface name.
- * Otherwise, the function shall return a NULL pointer.
- */
-char *
-lwip_if_indextoname(unsigned int ifindex, char *ifname)
-{
-#if LWIP_NETIF_API
-  if (ifindex <= 0xff) {
-    err_t err = netifapi_netif_index_to_name((u8_t)ifindex, ifname);
-    if (!err && ifname[0] != '\0') {
-      return ifname;
-    }
-  }
-#else /* LWIP_NETIF_API */
-  LWIP_UNUSED_ARG(ifindex);
-  LWIP_UNUSED_ARG(ifname);
-#endif /* LWIP_NETIF_API */
-  set_errno(ENXIO);
-  return NULL;
-}
-
-/**
- * @ingroup if_api
- * Returs the interface index corresponding to name ifname.
- * @param ifname Interface name
- * @return The corresponding index if ifname is the name of an interface;
- * otherwise, zero.
- */
-unsigned int
-lwip_if_nametoindex(const char *ifname)
-{
-#if LWIP_NETIF_API
-  err_t err;
-  u8_t idx;
-
-  err = netifapi_netif_name_to_index(ifname, &idx);
-  if (!err) {
-    return idx;
-  }
-#else /* LWIP_NETIF_API */
-  LWIP_UNUSED_ARG(ifname);
-#endif /* LWIP_NETIF_API */
-  return 0; /* invalid index */
-}
-
-#endif /* LWIP_SOCKET */
--- a/src/api/netbuf.c
+++ b/src/api/netbuf.c
@@ -109,10 +109,10 @@ netbuf_alloc(struct netbuf *buf, u16_t size)
  }
  buf->p = pbuf_alloc(PBUF_TRANSPORT, size, PBUF_RAM);
  if (buf->p == NULL) {
-    return NULL;
+     return NULL;
  }
  LWIP_ASSERT("check that first pbuf can hold size",
-              (buf->p->len >= size));
+             (buf->p->len >= size));
  buf->ptr = buf->p;
  return buf->p->payload;
 }
@@ -131,10 +131,6 @@ netbuf_free(struct netbuf *buf)
    pbuf_free(buf->p);
  }
  buf->p = buf->ptr = NULL;
-#if LWIP_CHECKSUM_ON_COPY
-  buf->flags = 0;
-  buf->toport_chksum = 0;
-#endif /* LWIP_CHECKSUM_ON_COPY */
 }

 /**
@@ -159,7 +155,7 @@ netbuf_ref(struct netbuf *buf, const void *dataptr, u16_t size)
    buf->ptr = NULL;
    return ERR_MEM;
  }
-  ((struct pbuf_rom *)buf->p)->payload = dataptr;
+  ((struct pbuf_rom*)buf->p)->payload = dataptr;
  buf->p->len = buf->p->tot_len = size;
  buf->ptr = buf->p;
  return ERR_OK;
--- a/src/api/netdb.c
+++ b/src/api/netdb.c
@@ -83,7 +83,7 @@ int h_errno;
 * @return an entry containing addresses of address family AF_INET
 *         for the host with name name
 */
-struct hostent *
+struct hostent*
 lwip_gethostbyname(const char *name)
 {
  err_t err;
@@ -115,21 +115,21 @@ lwip_gethostbyname(const char *name)
  s_hostent.h_aliases = &s_aliases;
  s_hostent.h_addrtype = AF_INET;
  s_hostent.h_length = sizeof(ip_addr_t);
-  s_hostent.h_addr_list = (char **)&s_phostent_addr;
+  s_hostent.h_addr_list = (char**)&s_phostent_addr;

 #if DNS_DEBUG
  /* dump hostent */
  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_name           == %s\n", s_hostent.h_name));
-  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_aliases        == %p\n", (void *)s_hostent.h_aliases));
+  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_aliases        == %p\n", (void*)s_hostent.h_aliases));
  /* h_aliases are always empty */
  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addrtype       == %d\n", s_hostent.h_addrtype));
  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_length         == %d\n", s_hostent.h_length));
-  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addr_list      == %p\n", (void *)s_hostent.h_addr_list));
+  LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addr_list      == %p\n", (void*)s_hostent.h_addr_list));
  if (s_hostent.h_addr_list != NULL) {
    u8_t idx;
-    for (idx = 0; s_hostent.h_addr_list[idx]; idx++) {
+    for (idx=0; s_hostent.h_addr_list[idx]; idx++) {
      LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addr_list[%i]   == %p\n", idx, s_hostent.h_addr_list[idx]));
-      LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addr_list[%i]-> == %s\n", idx, ipaddr_ntoa((ip_addr_t *)s_hostent.h_addr_list[idx])));
+      LWIP_DEBUGF(DNS_DEBUG, ("hostent.h_addr_list[%i]-> == %s\n", idx, ipaddr_ntoa((ip_addr_t*)s_hostent.h_addr_list[idx])));
    }
  }
 #endif /* DNS_DEBUG */
@@ -160,7 +160,7 @@ lwip_gethostbyname(const char *name)
 */
 int
 lwip_gethostbyname_r(const char *name, struct hostent *ret, char *buf,
-                     size_t buflen, struct hostent **result, int *h_errnop)
+                size_t buflen, struct hostent **result, int *h_errnop)
 {
  err_t err;
  struct gethostbyname_r_helper *h;
@@ -187,14 +187,14 @@ lwip_gethostbyname_r(const char *name, struct hostent *ret, char *buf,
  }

  namelen = strlen(name);
-  if (buflen < (sizeof(struct gethostbyname_r_helper) + LWIP_MEM_ALIGN_BUFFER(namelen + 1))) {
+  if (buflen < (sizeof(struct gethostbyname_r_helper) + namelen + 1 + (MEM_ALIGNMENT - 1))) {
    /* buf can't hold the data needed + a copy of name */
    *h_errnop = ERANGE;
    return -1;
  }

-  h = (struct gethostbyname_r_helper *)LWIP_MEM_ALIGN(buf);
-  hostname = ((char *)h) + sizeof(struct gethostbyname_r_helper);
+  h = (struct gethostbyname_r_helper*)LWIP_MEM_ALIGN(buf);
+  hostname = ((char*)h) + sizeof(struct gethostbyname_r_helper);

  /* query host IP address */
  err = netconn_gethostbyname(name, &h->addr);
@@ -216,7 +216,7 @@ lwip_gethostbyname_r(const char *name, struct hostent *ret, char *buf,
  ret->h_aliases = &h->aliases;
  ret->h_addrtype = AF_INET;
  ret->h_length = sizeof(ip_addr_t);
-  ret->h_addr_list = (char **)&h->addr_list;
+  ret->h_addr_list = (char**)&h->addr_list;

  /* set result != NULL */
  *result = ret;
@@ -267,7 +267,7 @@ lwip_freeaddrinfo(struct addrinfo *ai)
 */
 int
 lwip_getaddrinfo(const char *nodename, const char *servname,
-                 const struct addrinfo *hints, struct addrinfo **res)
+       const struct addrinfo *hints, struct addrinfo **res)
 {
  err_t err;
  ip_addr_t addr;
@@ -290,12 +290,12 @@ lwip_getaddrinfo(const char *nodename, const char *servname,
    ai_family = hints->ai_family;
    if ((ai_family != AF_UNSPEC)
 #if LWIP_IPV4
-        && (ai_family != AF_INET)
+      && (ai_family != AF_INET)
 #endif /* LWIP_IPV4 */
 #if LWIP_IPV6
-        && (ai_family != AF_INET6)
+      && (ai_family != AF_INET6)
 #endif /* LWIP_IPV6 */
-       ) {
+      ) {
      return EAI_FAMILY;
    }
  } else {
@@ -342,9 +342,9 @@ lwip_getaddrinfo(const char *nodename, const char *servname,
  } else {
    /* service location specified, use loopback address */
    if ((hints != NULL) && (hints->ai_flags & AI_PASSIVE)) {
-      ip_addr_set_any_val(ai_family == AF_INET6, addr);
+      ip_addr_set_any(ai_family == AF_INET6, &addr);
    } else {
-      ip_addr_set_loopback_val(ai_family == AF_INET6, addr);
+      ip_addr_set_loopback(ai_family == AF_INET6, &addr);
    }
  }

@@ -360,28 +360,27 @@ lwip_getaddrinfo(const char *nodename, const char *servname,
  }
  /* If this fails, please report to lwip-devel! :-) */
  LWIP_ASSERT("total_size <= NETDB_ELEM_SIZE: please report this!",
-              total_size <= NETDB_ELEM_SIZE);
+    total_size <= NETDB_ELEM_SIZE);
  ai = (struct addrinfo *)memp_malloc(MEMP_NETDB);
  if (ai == NULL) {
    return EAI_MEMORY;
  }
  memset(ai, 0, total_size);
  /* cast through void* to get rid of alignment warnings */
-  sa = (struct sockaddr_storage *)(void *)((u8_t *)ai + sizeof(struct addrinfo));
+  sa = (struct sockaddr_storage *)(void*)((u8_t*)ai + sizeof(struct addrinfo));
  if (IP_IS_V6_VAL(addr)) {
 #if LWIP_IPV6
-    struct sockaddr_in6 *sa6 = (struct sockaddr_in6 *)sa;
+    struct sockaddr_in6 *sa6 = (struct sockaddr_in6*)sa;
    /* set up sockaddr */
    inet6_addr_from_ip6addr(&sa6->sin6_addr, ip_2_ip6(&addr));
    sa6->sin6_family = AF_INET6;
    sa6->sin6_len = sizeof(struct sockaddr_in6);
    sa6->sin6_port = lwip_htons((u16_t)port_nr);
-    sa6->sin6_scope_id = ip6_addr_zone(ip_2_ip6(&addr));
    ai->ai_family = AF_INET6;
 #endif /* LWIP_IPV6 */
  } else {
 #if LWIP_IPV4
-    struct sockaddr_in *sa4 = (struct sockaddr_in *)sa;
+    struct sockaddr_in *sa4 = (struct sockaddr_in*)sa;
    /* set up sockaddr */
    inet_addr_from_ip4addr(&sa4->sin_addr, ip_2_ip4(&addr));
    sa4->sin_family = AF_INET;
@@ -399,12 +398,12 @@ lwip_getaddrinfo(const char *nodename, const char *servname,
  }
  if (nodename != NULL) {
    /* copy nodename to canonname if specified */
-    ai->ai_canonname = ((char *)ai + sizeof(struct addrinfo) + sizeof(struct sockaddr_storage));
+    ai->ai_canonname = ((char*)ai + sizeof(struct addrinfo) + sizeof(struct sockaddr_storage));
    MEMCPY(ai->ai_canonname, nodename, namelen);
    ai->ai_canonname[namelen] = 0;
  }
  ai->ai_addrlen = sizeof(struct sockaddr_storage);
-  ai->ai_addr = (struct sockaddr *)sa;
+  ai->ai_addr = (struct sockaddr*)sa;

  *res = ai;

--- a/src/api/netifapi.c
+++ b/src/api/netifapi.c
@@ -5,10 +5,10 @@
 * @defgroup netifapi NETIF API
 * @ingroup sequential_api
 * Thread-safe functions to be called from non-TCPIP threads
- *
+ * 
 * @defgroup netifapi_netif NETIF related
 * @ingroup netifapi
- * To be called from non-TCPIP threads
+ * To be called from non-TCPIP threads 
 */

 /*
@@ -42,13 +42,10 @@

 #if LWIP_NETIF_API /* don't build if not configured for use in lwipopts.h */

-#include "lwip/etharp.h"
 #include "lwip/netifapi.h"
 #include "lwip/memp.h"
 #include "lwip/priv/tcpip_priv.h"

-#include <string.h> /* strncpy */
-
 #define NETIFAPI_VAR_REF(name)      API_VAR_REF(name)
 #define NETIFAPI_VAR_DECLARE(name)  API_VAR_DECLARE(struct netifapi_msg, name)
 #define NETIFAPI_VAR_ALLOC(name)    API_VAR_ALLOC(struct netifapi_msg, MEMP_NETIFAPI_MSG, name, ERR_MEM)
@@ -60,10 +57,10 @@
 static err_t
 netifapi_do_netif_add(struct tcpip_api_call_data *m)
 {
-  /* cast through void* to silence alignment warnings.
+  /* cast through void* to silence alignment warnings. 
   * We know it works because the structs have been instantiated as struct netifapi_msg */
-  struct netifapi_msg *msg = (struct netifapi_msg *)(void *)m;
-
+  struct netifapi_msg *msg = (struct netifapi_msg*)(void*)m;
+  
  if (!netif_add( msg->netif,
 #if LWIP_IPV4
                  API_EXPR_REF(msg->msg.add.ipaddr),
@@ -86,9 +83,9 @@ netifapi_do_netif_add(struct tcpip_api_call_data *m)
 static err_t
 netifapi_do_netif_set_addr(struct tcpip_api_call_data *m)
 {
-  /* cast through void* to silence alignment warnings.
+  /* cast through void* to silence alignment warnings. 
   * We know it works because the structs have been instantiated as struct netifapi_msg */
-  struct netifapi_msg *msg = (struct netifapi_msg *)(void *)m;
+  struct netifapi_msg *msg = (struct netifapi_msg*)(void*)m;

  netif_set_addr( msg->netif,
                  API_EXPR_REF(msg->msg.add.ipaddr),
@@ -98,37 +95,6 @@ netifapi_do_netif_set_addr(struct tcpip_api_call_data *m)
 }
 #endif /* LWIP_IPV4 */

-/**
-* Call netif_name_to_index() inside the tcpip_thread context.
-*/
-static err_t
-netifapi_do_name_to_index(struct tcpip_api_call_data *m)
-{
-  /* cast through void* to silence alignment warnings.
-   * We know it works because the structs have been instantiated as struct netifapi_msg */
-  struct netifapi_msg *msg = (struct netifapi_msg *)(void *)m;
-
-  msg->msg.ifs.index = netif_name_to_index(msg->msg.ifs.name);
-  return ERR_OK;
-}
-
-/**
-* Call netif_index_to_name() inside the tcpip_thread context.
-*/
-static err_t
-netifapi_do_index_to_name(struct tcpip_api_call_data *m)
-{
-  /* cast through void* to silence alignment warnings.
-   * We know it works because the structs have been instantiated as struct netifapi_msg */
-  struct netifapi_msg *msg = (struct netifapi_msg *)(void *)m;
-
-  if (!netif_index_to_name(msg->msg.ifs.index, msg->msg.ifs.name)) {
-    /* return failure via empty name */
-    msg->msg.ifs.name[0] = '\0';
-  }
-  return ERR_OK;
-}
-
 /**
 * Call the "errtfunc" (or the "voidfunc" if "errtfunc" is NULL) inside the
 * tcpip_thread context.
@@ -136,9 +102,9 @@ netifapi_do_index_to_name(struct tcpip_api_call_data *m)
 static err_t
 netifapi_do_netif_common(struct tcpip_api_call_data *m)
 {
-  /* cast through void* to silence alignment warnings.
+  /* cast through void* to silence alignment warnings. 
   * We know it works because the structs have been instantiated as struct netifapi_msg */
-  struct netifapi_msg *msg = (struct netifapi_msg *)(void *)m;
+  struct netifapi_msg *msg = (struct netifapi_msg*)(void*)m;

  if (msg->msg.common.errtfunc != NULL) {
    return msg->msg.common.errtfunc(msg->netif);
@@ -148,69 +114,6 @@ netifapi_do_netif_common(struct tcpip_api_call_data *m)
  }
 }

-#if LWIP_ARP && LWIP_IPV4
-/**
- * @ingroup netifapi_arp
- * Add or update an entry in the ARP cache.
- * For an update, ipaddr is used to find the cache entry.
- *
- * @param ipaddr IPv4 address of cache entry
- * @param ethaddr hardware address mapped to ipaddr
- * @param type type of ARP cache entry
- * @return ERR_OK: entry added/updated, else error from err_t
- */
-err_t
-netifapi_arp_add(const ip4_addr_t *ipaddr, struct eth_addr *ethaddr, enum netifapi_arp_entry type)
-{
-  err_t err;
-
-  /* We only support permanent entries currently */
-  LWIP_UNUSED_ARG(type);
-
-#if ETHARP_SUPPORT_STATIC_ENTRIES && LWIP_TCPIP_CORE_LOCKING
-  LOCK_TCPIP_CORE();
-  err = etharp_add_static_entry(ipaddr, ethaddr);
-  UNLOCK_TCPIP_CORE();
-#else
-  /* @todo add new vars to struct netifapi_msg and create a 'do' func */
-  LWIP_UNUSED_ARG(ipaddr);
-  LWIP_UNUSED_ARG(ethaddr);
-  err = ERR_VAL;
-#endif /* ETHARP_SUPPORT_STATIC_ENTRIES && LWIP_TCPIP_CORE_LOCKING */
-
-  return err;
-}
-
-/**
- * @ingroup netifapi_arp
- * Remove an entry in the ARP cache identified by ipaddr
- *
- * @param ipaddr IPv4 address of cache entry
- * @param type type of ARP cache entry
- * @return ERR_OK: entry removed, else error from err_t
- */
-err_t
-netifapi_arp_remove(const ip4_addr_t *ipaddr, enum netifapi_arp_entry type)
-{
-  err_t err;
-
-  /* We only support permanent entries currently */
-  LWIP_UNUSED_ARG(type);
-
-#if ETHARP_SUPPORT_STATIC_ENTRIES && LWIP_TCPIP_CORE_LOCKING
-  LOCK_TCPIP_CORE();
-  err = etharp_remove_static_entry(ipaddr);
-  UNLOCK_TCPIP_CORE();
-#else
-  /* @todo add new vars to struct netifapi_msg and create a 'do' func */
-  LWIP_UNUSED_ARG(ipaddr);
-  err = ERR_VAL;
-#endif /* ETHARP_SUPPORT_STATIC_ENTRIES && LWIP_TCPIP_CORE_LOCKING */
-
-  return err;
-}
-#endif /* LWIP_ARP && LWIP_IPV4 */
-
 /**
 * @ingroup netifapi_netif
 * Call netif_add() in a thread-safe way by running that function inside the
@@ -301,7 +204,7 @@ netifapi_netif_set_addr(struct netif *netif,
 */
 err_t
 netifapi_netif_common(struct netif *netif, netifapi_void_fn voidfunc,
-                      netifapi_errt_fn errtfunc)
+                       netifapi_errt_fn errtfunc)
 {
  err_t err;
  NETIFAPI_VAR_DECLARE(msg);
@@ -315,66 +218,4 @@ netifapi_netif_common(struct netif *netif, netifapi_void_fn voidfunc,
  return err;
 }

-/**
-* @ingroup netifapi_netif
-* Call netif_name_to_index() in a thread-safe way by running that function inside the
-* tcpip_thread context.
-*
-* @param name the interface name of the netif
-* @param idx output index of the found netif
-*/
-err_t
-netifapi_netif_name_to_index(const char *name, u8_t *idx)
-{
-  err_t err;
-  NETIFAPI_VAR_DECLARE(msg);
-  NETIFAPI_VAR_ALLOC(msg);
-
-  *idx = 0;
-
-#if LWIP_MPU_COMPATIBLE
-  strncpy(NETIFAPI_VAR_REF(msg).msg.ifs.name, name, NETIF_NAMESIZE - 1);
-  NETIFAPI_VAR_REF(msg).msg.ifs.name[NETIF_NAMESIZE - 1] = '\0';
-#else
-  NETIFAPI_VAR_REF(msg).msg.ifs.name = LWIP_CONST_CAST(char *, name);
-#endif /* LWIP_MPU_COMPATIBLE */
-  err = tcpip_api_call(netifapi_do_name_to_index, &API_VAR_REF(msg).call);
-  if (!err) {
-    *idx = NETIFAPI_VAR_REF(msg).msg.ifs.index;
-  }
-  NETIFAPI_VAR_FREE(msg);
-  return err;
-}
-
-/**
-* @ingroup netifapi_netif
-* Call netif_index_to_name() in a thread-safe way by running that function inside the
-* tcpip_thread context.
-*
-* @param idx the interface index of the netif
-* @param name output name of the found netif, empty '\0' string if netif not found.
-*             name should be of at least NETIF_NAMESIZE bytes
-*/
-err_t
-netifapi_netif_index_to_name(u8_t idx, char *name)
-{
-  err_t err;
-  NETIFAPI_VAR_DECLARE(msg);
-  NETIFAPI_VAR_ALLOC(msg);
-
-  NETIFAPI_VAR_REF(msg).msg.ifs.index = idx;
-#if !LWIP_MPU_COMPATIBLE
-  NETIFAPI_VAR_REF(msg).msg.ifs.name = name;
-#endif /* LWIP_MPU_COMPATIBLE */
-  err = tcpip_api_call(netifapi_do_index_to_name, &API_VAR_REF(msg).call);
-#if LWIP_MPU_COMPATIBLE
-  if (!err) {
-    strncpy(name, NETIFAPI_VAR_REF(msg).msg.ifs.name, NETIF_NAMESIZE - 1);
-    name[NETIF_NAMESIZE - 1] = '\0';
-  }
-#endif /* LWIP_MPU_COMPATIBLE */
-  NETIFAPI_VAR_FREE(msg);
-  return err;
-}
-
 #endif /* LWIP_NETIF_API */
--- a/src/api/sockets.c
+++ b/src/api/sockets.c
--- a/src/api/tcpip.c
+++ b/src/api/tcpip.c
@@ -58,60 +58,20 @@
 /* global variables */
 static tcpip_init_done_fn tcpip_init_done;
 static void *tcpip_init_done_arg;
-static sys_mbox_t tcpip_mbox;
+static sys_mbox_t mbox;

 #if LWIP_TCPIP_CORE_LOCKING
 /** The global semaphore to lock the stack. */
 sys_mutex_t lock_tcpip_core;
 #endif /* LWIP_TCPIP_CORE_LOCKING */

-static void tcpip_thread_handle_msg(struct tcpip_msg *msg);
-
-#if !LWIP_TIMERS
+#if LWIP_TIMERS
+/* wait for a message, timeouts are processed while waiting */
+#define TCPIP_MBOX_FETCH(mbox, msg) sys_timeouts_mbox_fetch(mbox, msg)
+#else /* LWIP_TIMERS */
 /* wait for a message with timers disabled (e.g. pass a timer-check trigger into tcpip_thread) */
 #define TCPIP_MBOX_FETCH(mbox, msg) sys_mbox_fetch(mbox, msg)
-#else /* !LWIP_TIMERS */
-/* wait for a message, timeouts are processed while waiting */
-#define TCPIP_MBOX_FETCH(mbox, msg) tcpip_timeouts_mbox_fetch(mbox, msg)
-/**
- * Wait (forever) for a message to arrive in an mbox.
- * While waiting, timeouts are processed.
- *
- * @param mbox the mbox to fetch the message from
- * @param msg the place to store the message
- */
-static void
-tcpip_timeouts_mbox_fetch(sys_mbox_t *mbox, void **msg)
-{
-  u32_t sleeptime, res;
-
-again:
-  LWIP_ASSERT_CORE_LOCKED();
-
-  sleeptime = sys_timeouts_sleeptime();
-  if (sleeptime == SYS_TIMEOUTS_SLEEPTIME_INFINITE) {
-    UNLOCK_TCPIP_CORE();
-    sys_arch_mbox_fetch(mbox, msg, 0);
-    LOCK_TCPIP_CORE();
-    return;
-  } else if (sleeptime == 0) {
-    sys_check_timeouts();
-    /* We try again to fetch a message from the mbox. */
-    goto again;
-  }
-
-  UNLOCK_TCPIP_CORE();
-  res = sys_arch_mbox_fetch(mbox, msg, sleeptime);
-  LOCK_TCPIP_CORE();
-  if (res == SYS_ARCH_TIMEOUT) {
-    /* If a SYS_ARCH_TIMEOUT value is returned, a timeout occurred
-       before a message could be fetched. */
-    sys_check_timeouts();
-    /* We try again to fetch a message from the mbox. */
-    goto again;
-  }
-}
-#endif /* !LWIP_TIMERS */
+#endif /* LWIP_TIMERS */

 /**
 * The main lwIP thread. This thread has exclusive access to lwIP core functions
@@ -129,33 +89,23 @@ tcpip_thread(void *arg)
  struct tcpip_msg *msg;
  LWIP_UNUSED_ARG(arg);

-  LWIP_MARK_TCPIP_THREAD();
-
-  LOCK_TCPIP_CORE();
  if (tcpip_init_done != NULL) {
    tcpip_init_done(tcpip_init_done_arg);
  }

+  LOCK_TCPIP_CORE();
  while (1) {                          /* MAIN Loop */
+    UNLOCK_TCPIP_CORE();
    LWIP_TCPIP_THREAD_ALIVE();
    /* wait for a message, timeouts are processed while waiting */
-    TCPIP_MBOX_FETCH(&tcpip_mbox, (void **)&msg);
+    TCPIP_MBOX_FETCH(&mbox, (void **)&msg);
+    LOCK_TCPIP_CORE();
    if (msg == NULL) {
      LWIP_DEBUGF(TCPIP_DEBUG, ("tcpip_thread: invalid message: NULL\n"));
      LWIP_ASSERT("tcpip_thread: invalid message", 0);
      continue;
    }
-    tcpip_thread_handle_msg(msg);
-  }
-}
-
-/* Handle a single tcpip_msg
- * This is in its own function for access by tests only.
- */
-static void
-tcpip_thread_handle_msg(struct tcpip_msg *msg)
-{
-  switch (msg->type) {
+    switch (msg->type) {
 #if !LWIP_TCPIP_CORE_LOCKING
    case TCPIP_MSG_API:
      LWIP_DEBUGF(TCPIP_DEBUG, ("tcpip_thread: API message %p\n", (void *)msg));
@@ -171,9 +121,7 @@ tcpip_thread_handle_msg(struct tcpip_msg *msg)
 #if !LWIP_TCPIP_CORE_LOCKING_INPUT
    case TCPIP_MSG_INPKT:
      LWIP_DEBUGF(TCPIP_DEBUG, ("tcpip_thread: PACKET %p\n", (void *)msg));
-      if (msg->msg.inp.input_fn(msg->msg.inp.p, msg->msg.inp.netif) != ERR_OK) {
-        pbuf_free(msg->msg.inp.p);
-      }
+      msg->msg.inp.input_fn(msg->msg.inp.p, msg->msg.inp.netif);
      memp_free(MEMP_TCPIP_MSG_INPKT, msg);
      break;
 #endif /* !LWIP_TCPIP_CORE_LOCKING_INPUT */
@@ -206,28 +154,9 @@ tcpip_thread_handle_msg(struct tcpip_msg *msg)
      LWIP_DEBUGF(TCPIP_DEBUG, ("tcpip_thread: invalid message: %d\n", msg->type));
      LWIP_ASSERT("tcpip_thread: invalid message", 0);
      break;
-  }
-}
-
-#ifdef TCPIP_THREAD_TEST
-/** Work on queued items in single-threaded test mode */
-int
-tcpip_thread_poll_one(void)
-{
-  int ret = 0;
-  struct tcpip_msg *msg;
-
-  if (sys_arch_mbox_tryfetch(&tcpip_mbox, (void **)&msg) != SYS_ARCH_TIMEOUT) {
-    LOCK_TCPIP_CORE();
-    if (msg != NULL) {
-      tcpip_thread_handle_msg(msg);
-      ret = 1;
    }
-    UNLOCK_TCPIP_CORE();
  }
-  return ret;
 }
-#endif

 /**
 * Pass a received packet to tcpip_thread for input processing
@@ -249,7 +178,7 @@ tcpip_inpkt(struct pbuf *p, struct netif *inp, netif_input_fn input_fn)
 #else /* LWIP_TCPIP_CORE_LOCKING_INPUT */
  struct tcpip_msg *msg;

-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_INPKT);
  if (msg == NULL) {
@@ -260,7 +189,7 @@ tcpip_inpkt(struct pbuf *p, struct netif *inp, netif_input_fn input_fn)
  msg->msg.inp.p = p;
  msg->msg.inp.netif = inp;
  msg->msg.inp.input_fn = input_fn;
-  if (sys_mbox_trypost(&tcpip_mbox, msg) != ERR_OK) {
+  if (sys_mbox_trypost(&mbox, msg) != ERR_OK) {
    memp_free(MEMP_TCPIP_MSG_INPKT, msg);
    return ERR_MEM;
  }
@@ -287,30 +216,26 @@ tcpip_input(struct pbuf *p, struct netif *inp)
    return tcpip_inpkt(p, inp, ethernet_input);
  } else
 #endif /* LWIP_ETHERNET */
-    return tcpip_inpkt(p, inp, ip_input);
+  return tcpip_inpkt(p, inp, ip_input);
 }

 /**
- * @ingroup lwip_os
 * Call a specific function in the thread context of
 * tcpip_thread for easy access synchronization.
 * A function called in that way may access lwIP core code
 * without fearing concurrent access.
- * Blocks until the request is posted.
- * Must not be called from interrupt context!
 *
 * @param function the function to call
 * @param ctx parameter passed to f
+ * @param block 1 to block until the request is posted, 0 to non-blocking mode
 * @return ERR_OK if the function was called, another err_t if not
- *
- * @see tcpip_try_callback
 */
 err_t
-tcpip_callback(tcpip_callback_fn function, void *ctx)
+tcpip_callback_with_block(tcpip_callback_fn function, void *ctx, u8_t block)
 {
  struct tcpip_msg *msg;

-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_API);
  if (msg == NULL) {
@@ -320,46 +245,13 @@ tcpip_callback(tcpip_callback_fn function, void *ctx)
  msg->type = TCPIP_MSG_CALLBACK;
  msg->msg.cb.function = function;
  msg->msg.cb.ctx = ctx;
-
-  sys_mbox_post(&tcpip_mbox, msg);
-  return ERR_OK;
-}
-
-/**
- * @ingroup lwip_os
- * Call a specific function in the thread context of
- * tcpip_thread for easy access synchronization.
- * A function called in that way may access lwIP core code
- * without fearing concurrent access.
- * Does NOT block when the request cannot be posted because the
- * tcpip_mbox is full, but returns ERR_MEM instead.
- * Can be called from interrupt context.
- *
- * @param function the function to call
- * @param ctx parameter passed to f
- * @return ERR_OK if the function was called, another err_t if not
- *
- * @see tcpip_callback
- */
-err_t
-tcpip_try_callback(tcpip_callback_fn function, void *ctx)
-{
-  struct tcpip_msg *msg;
-
-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
-
-  msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_API);
-  if (msg == NULL) {
-    return ERR_MEM;
-  }
-
-  msg->type = TCPIP_MSG_CALLBACK;
-  msg->msg.cb.function = function;
-  msg->msg.cb.ctx = ctx;
-
-  if (sys_mbox_trypost(&tcpip_mbox, msg) != ERR_OK) {
-    memp_free(MEMP_TCPIP_MSG_API, msg);
-    return ERR_MEM;
+  if (block) {
+    sys_mbox_post(&mbox, msg);
+  } else {
+    if (sys_mbox_trypost(&mbox, msg) != ERR_OK) {
+      memp_free(MEMP_TCPIP_MSG_API, msg);
+      return ERR_MEM;
+    }
  }
  return ERR_OK;
 }
@@ -378,7 +270,7 @@ tcpip_timeout(u32_t msecs, sys_timeout_handler h, void *arg)
 {
  struct tcpip_msg *msg;

-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_API);
  if (msg == NULL) {
@@ -389,7 +281,7 @@ tcpip_timeout(u32_t msecs, sys_timeout_handler h, void *arg)
  msg->msg.tmo.msecs = msecs;
  msg->msg.tmo.h = h;
  msg->msg.tmo.arg = arg;
-  sys_mbox_post(&tcpip_mbox, msg);
+  sys_mbox_post(&mbox, msg);
  return ERR_OK;
 }

@@ -405,7 +297,7 @@ tcpip_untimeout(sys_timeout_handler h, void *arg)
 {
  struct tcpip_msg *msg;

-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_API);
  if (msg == NULL) {
@@ -415,7 +307,7 @@ tcpip_untimeout(sys_timeout_handler h, void *arg)
  msg->type = TCPIP_MSG_UNTIMEOUT;
  msg->msg.tmo.h = h;
  msg->msg.tmo.arg = arg;
-  sys_mbox_post(&tcpip_mbox, msg);
+  sys_mbox_post(&mbox, msg);
  return ERR_OK;
 }
 #endif /* LWIP_TCPIP_TIMEOUT && LWIP_TIMERS */
@@ -434,7 +326,7 @@ tcpip_untimeout(sys_timeout_handler h, void *arg)
 * @return ERR_OK if the function was called, another err_t if not
 */
 err_t
-tcpip_send_msg_wait_sem(tcpip_callback_fn fn, void *apimsg, sys_sem_t *sem)
+tcpip_send_msg_wait_sem(tcpip_callback_fn fn, void *apimsg, sys_sem_t* sem)
 {
 #if LWIP_TCPIP_CORE_LOCKING
  LWIP_UNUSED_ARG(sem);
@@ -446,13 +338,13 @@ tcpip_send_msg_wait_sem(tcpip_callback_fn fn, void *apimsg, sys_sem_t *sem)
  TCPIP_MSG_VAR_DECLARE(msg);

  LWIP_ASSERT("semaphore not initialized", sys_sem_valid(sem));
-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  TCPIP_MSG_VAR_ALLOC(msg);
  TCPIP_MSG_VAR_REF(msg).type = TCPIP_MSG_API;
  TCPIP_MSG_VAR_REF(msg).msg.api_msg.function = fn;
  TCPIP_MSG_VAR_REF(msg).msg.api_msg.msg = apimsg;
-  sys_mbox_post(&tcpip_mbox, &TCPIP_MSG_VAR_REF(msg));
+  sys_mbox_post(&mbox, &TCPIP_MSG_VAR_REF(msg));
  sys_arch_sem_wait(sem, 0);
  TCPIP_MSG_VAR_FREE(msg);
  return ERR_OK;
@@ -462,7 +354,7 @@ tcpip_send_msg_wait_sem(tcpip_callback_fn fn, void *apimsg, sys_sem_t *sem)
 /**
 * Synchronously calls function in TCPIP thread and waits for its completion.
 * It is recommended to use LWIP_TCPIP_CORE_LOCKING (preferred) or
- * LWIP_NETCONN_SEM_PER_THREAD.
+ * LWIP_NETCONN_SEM_PER_THREAD. 
 * If not, a semaphore is created and destroyed on every call which is usually
 * an expensive/slow operation.
 * @param fn Function to call
@@ -488,7 +380,7 @@ tcpip_api_call(tcpip_api_call_fn fn, struct tcpip_api_call_data *call)
  }
 #endif /* LWIP_NETCONN_SEM_PER_THREAD */

-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));

  TCPIP_MSG_VAR_ALLOC(msg);
  TCPIP_MSG_VAR_REF(msg).type = TCPIP_MSG_API_CALL;
@@ -499,7 +391,7 @@ tcpip_api_call(tcpip_api_call_fn fn, struct tcpip_api_call_data *call)
 #else /* LWIP_NETCONN_SEM_PER_THREAD */
  TCPIP_MSG_VAR_REF(msg).msg.api_call.sem = &call->sem;
 #endif /* LWIP_NETCONN_SEM_PER_THREAD */
-  sys_mbox_post(&tcpip_mbox, &TCPIP_MSG_VAR_REF(msg));
+  sys_mbox_post(&mbox, &TCPIP_MSG_VAR_REF(msg));
  sys_arch_sem_wait(TCPIP_MSG_VAR_REF(msg).msg.api_call.sem, 0);
  TCPIP_MSG_VAR_FREE(msg);

@@ -512,22 +404,14 @@ tcpip_api_call(tcpip_api_call_fn fn, struct tcpip_api_call_data *call)
 }

 /**
- * @ingroup lwip_os
 * Allocate a structure for a static callback message and initialize it.
- * The message has a special type such that lwIP never frees it.
- * This is intended to be used to send "static" messages from interrupt context,
- * e.g. the message is allocated once and posted several times from an IRQ
- * using tcpip_callbackmsg_trycallback().
- * Example usage: Trigger execution of an ethernet IRQ DPC routine in lwIP thread context.
- * 
+ * This is intended to be used to send "static" messages from interrupt context.
+ *
 * @param function the function to call
 * @param ctx parameter passed to function
- * @return a struct pointer to pass to tcpip_callbackmsg_trycallback().
- *
- * @see tcpip_callbackmsg_trycallback()
- * @see tcpip_callbackmsg_delete()
+ * @return a struct pointer to pass to tcpip_trycallback().
 */
-struct tcpip_callback_msg *
+struct tcpip_callback_msg*
 tcpip_callbackmsg_new(tcpip_callback_fn function, void *ctx)
 {
  struct tcpip_msg *msg = (struct tcpip_msg *)memp_malloc(MEMP_TCPIP_MSG_API);
@@ -537,56 +421,32 @@ tcpip_callbackmsg_new(tcpip_callback_fn function, void *ctx)
  msg->type = TCPIP_MSG_CALLBACK_STATIC;
  msg->msg.cb.function = function;
  msg->msg.cb.ctx = ctx;
-  return (struct tcpip_callback_msg *)msg;
+  return (struct tcpip_callback_msg*)msg;
 }

 /**
- * @ingroup lwip_os
 * Free a callback message allocated by tcpip_callbackmsg_new().
 *
 * @param msg the message to free
- *
- * @see tcpip_callbackmsg_new()
 */
 void
-tcpip_callbackmsg_delete(struct tcpip_callback_msg *msg)
+tcpip_callbackmsg_delete(struct tcpip_callback_msg* msg)
 {
  memp_free(MEMP_TCPIP_MSG_API, msg);
 }

 /**
- * @ingroup lwip_os
- * Try to post a callback-message to the tcpip_thread tcpip_mbox.
+ * Try to post a callback-message to the tcpip_thread mbox
+ * This is intended to be used to send "static" messages from interrupt context.
 *
 * @param msg pointer to the message to post
 * @return sys_mbox_trypost() return code
- *
- * @see tcpip_callbackmsg_new()
 */
 err_t
-tcpip_callbackmsg_trycallback(struct tcpip_callback_msg *msg)
+tcpip_trycallback(struct tcpip_callback_msg* msg)
 {
-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
-  return sys_mbox_trypost(&tcpip_mbox, msg);
-}
-
-/**
- * @ingroup lwip_os
- * Try to post a callback-message to the tcpip_thread mbox.
- * Same as @ref tcpip_callbackmsg_trycallback but calls sys_mbox_trypost_fromisr(),
- * mainly to help FreeRTOS, where calls differ between task level and ISR level.
- *
- * @param msg pointer to the message to post
- * @return sys_mbox_trypost_fromisr() return code (without change, so this
- *         knowledge can be used to e.g. propagate "bool needs_scheduling")
- *
- * @see tcpip_callbackmsg_new()
- */
-err_t
-tcpip_callbackmsg_trycallback_fromisr(struct tcpip_callback_msg *msg)
-{
-  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(tcpip_mbox));
-  return sys_mbox_trypost_fromisr(&tcpip_mbox, msg);
+  LWIP_ASSERT("Invalid mbox", sys_mbox_valid_val(mbox));
+  return sys_mbox_trypost(&mbox, msg);
 }

 /**
@@ -605,7 +465,7 @@ tcpip_init(tcpip_init_done_fn initfunc, void *arg)

  tcpip_init_done = initfunc;
  tcpip_init_done_arg = arg;
-  if (sys_mbox_new(&tcpip_mbox, TCPIP_MBOX_SIZE) != ERR_OK) {
+  if (sys_mbox_new(&mbox, TCPIP_MBOX_SIZE) != ERR_OK) {
    LWIP_ASSERT("failed to create tcpip_thread mbox", 0);
  }
 #if LWIP_TCPIP_CORE_LOCKING
@@ -639,7 +499,7 @@ pbuf_free_int(void *p)
 err_t
 pbuf_free_callback(struct pbuf *p)
 {
-  return tcpip_try_callback(pbuf_free_int, p);
+  return tcpip_callback_with_block(pbuf_free_int, p, 0);
 }

 /**
@@ -652,7 +512,7 @@ pbuf_free_callback(struct pbuf *p)
 err_t
 mem_free_callback(void *m)
 {
-  return tcpip_try_callback(mem_free, m);
+  return tcpip_callback_with_block(mem_free, m, 0);
 }

 #endif /* !NO_SYS */
--- a/src/apps/altcp_tls/altcp_tls_mbedtls.c
+++ b/src/apps/altcp_tls/altcp_tls_mbedtls.c
--- a/src/apps/altcp_tls/altcp_tls_mbedtls_mem.c
+++ b/src/apps/altcp_tls/altcp_tls_mbedtls_mem.c
@@ -1,210 +0,0 @@
-/**
- * @file
- * Application layered TCP connection API (to be used from TCPIP thread)
- *
- * This file contains memory management functions for a TLS layer using mbedTLS.
- *
- * ATTENTION: For production usage, you might want to override this file with
- *            your own implementation since this implementation simply uses the
- *            lwIP heap without caring for fragmentation or leaving heap for
- *            other parts of lwIP!
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- * Missing things / @todo:
- * - RX data is acknowledged after receiving (tcp_recved is called when enqueueing
- *   the pbuf for mbedTLS receive, not when processed by mbedTLS or the inner
- *   connection; altcp_recved() from inner connection does nothing)
- * - TX data is marked as 'sent' (i.e. acknowledged; sent callback is called) right
- *   after enqueueing for transmission, not when actually ACKed be the remote host.
- */
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/apps/altcp_tls_mbedtls_opts.h"
-
-#if LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS
-
-#include "altcp_tls_mbedtls_mem.h"
-#include "altcp_tls_mbedtls_structs.h"
-#include "lwip/mem.h"
-
-#include "mbedtls/platform.h"
-
-#include <string.h>
-
-#ifndef ALTCP_MBEDTLS_MEM_DEBUG
-#define ALTCP_MBEDTLS_MEM_DEBUG   LWIP_DBG_OFF
-#endif
-
-#if defined(MBEDTLS_PLATFORM_MEMORY) && \
-   (!defined(MBEDTLS_PLATFORM_FREE_MACRO) || \
-    defined(MBEDTLS_PLATFORM_CALLOC_MACRO))
-#define ALTCP_MBEDTLS_PLATFORM_ALLOC 1
-#else
-#define ALTCP_MBEDTLS_PLATFORM_ALLOC 0
-#endif
-
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC
-
-#ifndef ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS
-#define ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS 0
-#endif
-
-/* This is an example/debug implementation of alloc/free functions only */
-typedef struct altcp_mbedtls_malloc_helper_s {
-  size_t c;
-  size_t len;
-} altcp_mbedtls_malloc_helper_t;
-
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS
-typedef struct altcp_mbedtls_malloc_stats_s {
-  size_t allocedBytes;
-  size_t allocCnt;
-  size_t maxBytes;
-  size_t totalBytes;
-} altcp_mbedtls_malloc_stats_t;
-altcp_mbedtls_malloc_stats_t altcp_mbedtls_malloc_stats;
-volatile int altcp_mbedtls_malloc_clear_stats;
-#endif
-
-static void *
-tls_malloc(size_t c, size_t len)
-{
-  altcp_mbedtls_malloc_helper_t *hlpr;
-  void *ret;
-  size_t alloc_size;
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS
-  if (altcp_mbedtls_malloc_clear_stats) {
-    altcp_mbedtls_malloc_clear_stats = 0;
-    memset(&altcp_mbedtls_malloc_stats, 0, sizeof(altcp_mbedtls_malloc_stats));
-  }
-#endif
-  alloc_size = sizeof(altcp_mbedtls_malloc_helper_t) + (c * len);
-  /* check for maximum allocation size, mainly to prevent mem_size_t overflow */
-  if (alloc_size > MEM_SIZE) {
-    LWIP_DEBUGF(ALTCP_MBEDTLS_MEM_DEBUG, ("mbedtls allocation too big: %c * %d bytes vs MEM_SIZE=%d",
-                                          (int)c, (int)len, (int)MEM_SIZE));
-    return NULL;
-  }
-  hlpr = (altcp_mbedtls_malloc_helper_t *)mem_malloc((mem_size_t)alloc_size);
-  if (hlpr == NULL) {
-    LWIP_DEBUGF(ALTCP_MBEDTLS_MEM_DEBUG, ("mbedtls alloc callback failed for %c * %d bytes", (int)c, (int)len));
-    return NULL;
-  }
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS
-  altcp_mbedtls_malloc_stats.allocCnt++;
-  altcp_mbedtls_malloc_stats.allocedBytes += c * len;
-  if (altcp_mbedtls_malloc_stats.allocedBytes > altcp_mbedtls_malloc_stats.maxBytes) {
-    altcp_mbedtls_malloc_stats.maxBytes = altcp_mbedtls_malloc_stats.allocedBytes;
-  }
-  altcp_mbedtls_malloc_stats.totalBytes += c * len;
-#endif
-  hlpr->c = c;
-  hlpr->len = len;
-  ret = hlpr + 1;
-  /* zeroing the allocated chunk is required by mbedTLS! */
-  memset(ret, 0, c * len);
-  return ret;
-}
-
-static void
-tls_free(void *ptr)
-{
-  altcp_mbedtls_malloc_helper_t *hlpr;
-  if (ptr == NULL) {
-    /* this obviously happened in mbedtls... */
-    return;
-  }
-  hlpr = ((altcp_mbedtls_malloc_helper_t *)ptr) - 1;
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC_STATS
-  if (!altcp_mbedtls_malloc_clear_stats) {
-    altcp_mbedtls_malloc_stats.allocedBytes -= hlpr->c * hlpr->len;
-  }
-#endif
-  mem_free(hlpr);
-}
-#endif /* ALTCP_MBEDTLS_PLATFORM_ALLOC*/
-
-void
-altcp_mbedtls_mem_init(void)
-{
-  /* not much to do here when using the heap */
-
-#if ALTCP_MBEDTLS_PLATFORM_ALLOC
-  /* set mbedtls allocation methods */
-  mbedtls_platform_set_calloc_free(&tls_malloc, &tls_free);
-#endif
-}
-
-altcp_mbedtls_state_t *
-altcp_mbedtls_alloc(void *conf)
-{
-  altcp_mbedtls_state_t *ret = (altcp_mbedtls_state_t *)mem_calloc(1, sizeof(altcp_mbedtls_state_t));
-  if (ret != NULL) {
-    ret->conf = conf;
-  }
-  return ret;
-}
-
-void
-altcp_mbedtls_free(void *conf, altcp_mbedtls_state_t *state)
-{
-  LWIP_UNUSED_ARG(conf);
-  LWIP_ASSERT("state != NULL", state != NULL);
-  mem_free(state);
-}
-
-void *
-altcp_mbedtls_alloc_config(size_t size)
-{
-  void *ret;
-  size_t checked_size = (mem_size_t)size;
-  if (size != checked_size) {
-    /* allocation too big (mem_size_t overflow) */
-    return NULL;
-  }
-  ret = (altcp_mbedtls_state_t *)mem_calloc(1, (mem_size_t)size);
-  return ret;
-}
-
-void
-altcp_mbedtls_free_config(void *item)
-{
-  LWIP_ASSERT("item != NULL", item != NULL);
-  mem_free(item);
-}
-
-#endif /* LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS */
-#endif /* LWIP_ALTCP */
--- a/src/apps/altcp_tls/altcp_tls_mbedtls_mem.h
+++ b/src/apps/altcp_tls/altcp_tls_mbedtls_mem.h
@@ -1,72 +0,0 @@
-/**
- * @file
- * Application layered TCP/TLS connection API (to be used from TCPIP thread)
- *
- * This file contains memory management function prototypes for a TLS layer using mbedTLS.
- *
- * Memory management contains:
- * - allocating/freeing altcp_mbedtls_state_t
- * - allocating/freeing memory used in the mbedTLS library
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-#ifndef LWIP_HDR_ALTCP_MBEDTLS_MEM_H
-#define LWIP_HDR_ALTCP_MBEDTLS_MEM_H
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/apps/altcp_tls_mbedtls_opts.h"
-
-#if LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS
-
-#include "altcp_tls_mbedtls_structs.h"
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-void altcp_mbedtls_mem_init(void);
-altcp_mbedtls_state_t *altcp_mbedtls_alloc(void *conf);
-void altcp_mbedtls_free(void *conf, altcp_mbedtls_state_t *state);
-void *altcp_mbedtls_alloc_config(size_t size);
-void altcp_mbedtls_free_config(void *item);
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS */
-#endif /* LWIP_ALTCP */
-#endif /* LWIP_HDR_ALTCP_MBEDTLS_MEM_H */
--- a/src/apps/altcp_tls/altcp_tls_mbedtls_structs.h
+++ b/src/apps/altcp_tls/altcp_tls_mbedtls_structs.h
@@ -1,83 +0,0 @@
-/**
- * @file
- * Application layered TCP/TLS connection API (to be used from TCPIP thread)
- *
- * This file contains structure definitions for a TLS layer using mbedTLS.
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-#ifndef LWIP_HDR_ALTCP_MBEDTLS_STRUCTS_H
-#define LWIP_HDR_ALTCP_MBEDTLS_STRUCTS_H
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/apps/altcp_tls_mbedtls_opts.h"
-
-#if LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS
-
-#include "lwip/altcp.h"
-#include "lwip/pbuf.h"
-
-#include "mbedtls/ssl.h"
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-#define ALTCP_MBEDTLS_FLAGS_HANDSHAKE_DONE    0x01
-#define ALTCP_MBEDTLS_FLAGS_UPPER_CALLED      0x02
-#define ALTCP_MBEDTLS_FLAGS_RX_CLOSE_QUEUED   0x04
-#define ALTCP_MBEDTLS_FLAGS_RX_CLOSED         0x08
-#define ALTCP_MBEDTLS_FLAGS_APPLDATA_SENT     0x10
-
-typedef struct altcp_mbedtls_state_s {
-  void *conf;
-  mbedtls_ssl_context ssl_context;
-  /* chain of rx pbufs (before decryption) */
-  struct pbuf *rx;
-  struct pbuf *rx_app;
-  u8_t flags;
-  int rx_passed_unrecved;
-  int bio_bytes_read;
-  int bio_bytes_appl;
-} altcp_mbedtls_state_t;
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* LWIP_ALTCP_TLS && LWIP_ALTCP_TLS_MBEDTLS */
-#endif /* LWIP_ALTCP */
-#endif /* LWIP_HDR_ALTCP_MBEDTLS_STRUCTS_H */
--- a/src/apps/http/altcp_proxyconnect.c
+++ b/src/apps/http/altcp_proxyconnect.c
@@ -1,584 +0,0 @@
-/**
- * @file
- * Application layered TCP connection API that executes a proxy-connect.
- *
- * This file provides a starting layer that executes a proxy-connect e.g. to
- * set up TLS connections through a http proxy.
- */
-
-/*
- * Copyright (c) 2018 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-
-#include "lwip/apps/altcp_proxyconnect.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/altcp.h"
-#include "lwip/priv/altcp_priv.h"
-
-#include "lwip/altcp_tcp.h"
-#include "lwip/altcp_tls.h"
-
-#include "lwip/mem.h"
-#include "lwip/init.h"
-
-#include <stdio.h>
-
-/** This string is passed in the HTTP header as "User-Agent: " */
-#ifndef ALTCP_PROXYCONNECT_CLIENT_AGENT
-#define ALTCP_PROXYCONNECT_CLIENT_AGENT "lwIP/" LWIP_VERSION_STRING " (http://savannah.nongnu.org/projects/lwip)"
-#endif
-
-#define ALTCP_PROXYCONNECT_FLAGS_CONNECT_STARTED  0x01
-#define ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE   0x02
-
-typedef struct altcp_proxyconnect_state_s
-{
-  ip_addr_t outer_addr;
-  u16_t outer_port;
-  struct altcp_proxyconnect_config *conf;
-  u8_t flags;
-} altcp_proxyconnect_state_t;
-
-/* Variable prototype, the actual declaration is at the end of this file
-   since it contains pointers to static functions declared here */
-extern const struct altcp_functions altcp_proxyconnect_functions;
-
-/* memory management functions: */
-
-static altcp_proxyconnect_state_t *
-altcp_proxyconnect_state_alloc(void)
-{
-  altcp_proxyconnect_state_t *ret = (altcp_proxyconnect_state_t *)mem_calloc(1, sizeof(altcp_proxyconnect_state_t));
-  return ret;
-}
-
-static void
-altcp_proxyconnect_state_free(altcp_proxyconnect_state_t *state)
-{
-  LWIP_ASSERT("state != NULL", state != NULL);
-  mem_free(state);
-}
-
-/* helper functions */
-
-#define PROXY_CONNECT "CONNECT %s:%d HTTP/1.1\r\n" /* HOST, PORT */ \
-  "User-Agent: %s\r\n" /* User-Agent */\
-  "Proxy-Connection: keep-alive\r\n" \
-  "Connection: keep-alive\r\n" \
-  "\r\n"
-#define PROXY_CONNECT_FORMAT(host, port) PROXY_CONNECT, host, port, ALTCP_PROXYCONNECT_CLIENT_AGENT
-
-/* Format the http proxy connect request via snprintf */
-static int
-altcp_proxyconnect_format_request(char *buffer, size_t bufsize, const char *host, int port)
-{
-  return snprintf(buffer, bufsize, PROXY_CONNECT_FORMAT(host, port));
-}
-
-/* Create and send the http proxy connect request */
-static err_t
-altcp_proxyconnect_send_request(struct altcp_pcb *conn)
-{
-  int len, len2;
-  mem_size_t alloc_len;
-  char *buffer, *host;
-  altcp_proxyconnect_state_t *state = (altcp_proxyconnect_state_t *)conn->state;
-
-  if (!state) {
-    return ERR_VAL;
-  }
-  /* Use printf with zero length to get the required allocation size */
-  len = altcp_proxyconnect_format_request(NULL, 0, "", state->outer_port);
-  if (len < 0) {
-    return ERR_VAL;
-  }
-  /* add allocation size for IP address strings */
-#if LWIP_IPV6
-  len += 40; /* worst-case IPv6 address length */
-#else
-  len += 16; /* worst-case IPv4 address length */
-#endif
-  alloc_len = (mem_size_t)len;
-  if ((len < 0) || (int)alloc_len != len) {
-    /* overflow */
-    return ERR_MEM;
-  }
-  /* Allocate a bufer for the request string */
-  buffer = (char *)mem_malloc(alloc_len);
-  if (buffer == NULL) {
-    return ERR_MEM;
-  }
-  host = ipaddr_ntoa(&state->outer_addr);
-  len2 = altcp_proxyconnect_format_request(buffer, alloc_len, host, state->outer_port);
-  if ((len2 > 0) && (len2 <= len) && (len2 <= 0xFFFF)) {
-    err_t err = altcp_write(conn->inner_conn, buffer, (u16_t)len2, TCP_WRITE_FLAG_COPY);
-    if (err != ERR_OK) {
-      /* @todo: abort? */
-      mem_free(buffer);
-      return err;
-    }
-  }
-  mem_free(buffer);
-  return ERR_OK;
-}
-
-/* callback functions from inner/lower connection: */
-
-/** Connected callback from lower connection (i.e. TCP).
- * Not really implemented/tested yet...
- */
-static err_t
-altcp_proxyconnect_lower_connected(void *arg, struct altcp_pcb *inner_conn, err_t err)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn && conn->state) {
-    LWIP_ASSERT("pcb mismatch", conn->inner_conn == inner_conn);
-    LWIP_UNUSED_ARG(inner_conn); /* for LWIP_NOASSERT */
-    /* upper connected is called when handshake is done */
-    if (err != ERR_OK) {
-      if (conn->connected) {
-        if (conn->connected(conn->arg, conn, err) == ERR_ABRT) {
-          return ERR_ABRT;
-        }
-        return ERR_OK;
-      }
-    }
-    /* send proxy connect request here */
-    return altcp_proxyconnect_send_request(conn);
-  }
-  return ERR_VAL;
-}
-
-/** Recv callback from lower connection (i.e. TCP)
- * This one mainly differs between connection setup (wait for proxy OK string)
- * and application phase (data is passed on to the application).
- */
-static err_t
-altcp_proxyconnect_lower_recv(void *arg, struct altcp_pcb *inner_conn, struct pbuf *p, err_t err)
-{
-  altcp_proxyconnect_state_t *state;
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-
-  LWIP_ASSERT("no err expected", err == ERR_OK);
-  LWIP_UNUSED_ARG(err);
-
-  if (!conn) {
-    /* no connection given as arg? should not happen, but prevent pbuf/conn leaks */
-    if (p != NULL) {
-      pbuf_free(p);
-    }
-    altcp_close(inner_conn);
-    return ERR_CLSD;
-  }
-  state = (altcp_proxyconnect_state_t *)conn->state;
-  LWIP_ASSERT("pcb mismatch", conn->inner_conn == inner_conn);
-  if (!state) {
-    /* already closed */
-    if (p != NULL) {
-      pbuf_free(p);
-    }
-    altcp_close(inner_conn);
-    return ERR_CLSD;
-  }
-  if (state->flags & ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE) {
-    /* application phase, just pass this through */
-    if (conn->recv) {
-      return conn->recv(conn->arg, conn, p, err);
-    }
-    pbuf_free(p);
-    return ERR_OK;
-  } else {
-    /* setup phase */
-    /* handle NULL pbuf (inner connection closed) */
-    if (p == NULL) {
-      if (altcp_close(conn) != ERR_OK) {
-        altcp_abort(conn);
-        return ERR_ABRT;
-      }
-      return ERR_OK;
-    } else {
-      /* @todo: parse setup phase rx data
-         for now, we just wait for the end of the header... */
-      u16_t idx = pbuf_memfind(p, "\r\n\r\n", 4, 0);
-      altcp_recved(inner_conn, p->tot_len);
-      pbuf_free(p);
-      if (idx != 0xFFFF) {
-        state->flags |= ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE;
-        if (conn->connected) {
-          return conn->connected(conn->arg, conn, ERR_OK);
-        }
-      }
-      return ERR_OK;
-    }
-  }
-}
-
-/** Sent callback from lower connection (i.e. TCP)
- * This only informs the upper layer to try to send more, not about
- * the number of ACKed bytes.
- */
-static err_t
-altcp_proxyconnect_lower_sent(void *arg, struct altcp_pcb *inner_conn, u16_t len)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  LWIP_UNUSED_ARG(len);
-  if (conn) {
-    altcp_proxyconnect_state_t *state = (altcp_proxyconnect_state_t *)conn->state;
-    LWIP_ASSERT("pcb mismatch", conn->inner_conn == inner_conn);
-    LWIP_UNUSED_ARG(inner_conn); /* for LWIP_NOASSERT */
-    if (!state || !(state->flags & ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE)) {
-      /* @todo: do something here? */
-      return ERR_OK;
-    }
-    /* pass this on to upper sent */
-    if (conn->sent) {
-      return conn->sent(conn->arg, conn, len);
-    }
-  }
-  return ERR_OK;
-}
-
-/** Poll callback from lower connection (i.e. TCP)
- * Just pass this on to the application.
- * @todo: retry sending?
- */
-static err_t
-altcp_proxyconnect_lower_poll(void *arg, struct altcp_pcb *inner_conn)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    LWIP_ASSERT("pcb mismatch", conn->inner_conn == inner_conn);
-    LWIP_UNUSED_ARG(inner_conn); /* for LWIP_NOASSERT */
-    if (conn->poll) {
-      return conn->poll(conn->arg, conn);
-    }
-  }
-  return ERR_OK;
-}
-
-static void
-altcp_proxyconnect_lower_err(void *arg, err_t err)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    conn->inner_conn = NULL; /* already freed */
-    if (conn->err) {
-      conn->err(conn->arg, err);
-    }
-    altcp_free(conn);
-  }
-}
-
-
-/* setup functions */
-
-static void
-altcp_proxyconnect_setup_callbacks(struct altcp_pcb *conn, struct altcp_pcb *inner_conn)
-{
-  altcp_arg(inner_conn, conn);
-  altcp_recv(inner_conn, altcp_proxyconnect_lower_recv);
-  altcp_sent(inner_conn, altcp_proxyconnect_lower_sent);
-  altcp_err(inner_conn, altcp_proxyconnect_lower_err);
-  /* tcp_poll is set when interval is set by application */
-  /* listen is set totally different :-) */
-}
-
-static err_t
-altcp_proxyconnect_setup(struct altcp_proxyconnect_config *config, struct altcp_pcb *conn, struct altcp_pcb *inner_conn)
-{
-  altcp_proxyconnect_state_t *state;
-  if (!config) {
-    return ERR_ARG;
-  }
-  LWIP_ASSERT("invalid inner_conn", conn != inner_conn);
-
-  /* allocate proxyconnect context */
-  state = altcp_proxyconnect_state_alloc();
-  if (state == NULL) {
-    return ERR_MEM;
-  }
-  state->flags = 0;
-  state->conf = config;
-  altcp_proxyconnect_setup_callbacks(conn, inner_conn);
-  conn->inner_conn = inner_conn;
-  conn->fns = &altcp_proxyconnect_functions;
-  conn->state = state;
-  return ERR_OK;
-}
-
-/** Allocate a new altcp layer connecting through a proxy.
- * This function gets the inner pcb passed.
- *
- * @param config struct altcp_proxyconnect_config that contains the proxy settings
- * @param inner_pcb pcb that makes the connection to the proxy (i.e. tcp pcb)
- */
-struct altcp_pcb *
-altcp_proxyconnect_new(struct altcp_proxyconnect_config *config, struct altcp_pcb *inner_pcb)
-{
-  struct altcp_pcb *ret;
-  if (inner_pcb == NULL) {
-    return NULL;
-  }
-  ret = altcp_alloc();
-  if (ret != NULL) {
-    if (altcp_proxyconnect_setup(config, ret, inner_pcb) != ERR_OK) {
-      altcp_free(ret);
-      return NULL;
-    }
-  }
-  return ret;
-}
-
-/** Allocate a new altcp layer connecting through a proxy.
- * This function allocates the inner pcb as tcp pcb, resulting in a direct tcp
- * connection to the proxy.
- *
- * @param config struct altcp_proxyconnect_config that contains the proxy settings
- * @param ip_type IP type of the connection (@ref lwip_ip_addr_type)
- */
-struct altcp_pcb *
-altcp_proxyconnect_new_tcp(struct altcp_proxyconnect_config *config, u8_t ip_type)
-{
-  struct altcp_pcb *inner_pcb, *ret;
-
-  /* inner pcb is tcp */
-  inner_pcb = altcp_tcp_new_ip_type(ip_type);
-  if (inner_pcb == NULL) {
-    return NULL;
-  }
-  ret = altcp_proxyconnect_new(config, inner_pcb);
-  if (ret == NULL) {
-    altcp_close(inner_pcb);
-  }
-  return ret;
-}
-
-/** Allocator function to allocate a proxy connect altcp pcb connecting directly
- * via tcp to the proxy.
- *
- * The returned pcb is a chain: altcp_proxyconnect - altcp_tcp - tcp pcb
- *
- * This function is meant for use with @ref altcp_new.
- *
- * @param arg struct altcp_proxyconnect_config that contains the proxy settings
- * @param ip_type IP type of the connection (@ref lwip_ip_addr_type)
- */
-struct altcp_pcb *
-altcp_proxyconnect_alloc(void *arg, u8_t ip_type)
-{
-  return altcp_proxyconnect_new_tcp((struct altcp_proxyconnect_config *)arg, ip_type);
-}
-
-
-#if LWIP_ALTCP_TLS
-
-/** Allocator function to allocate a TLS connection through a proxy.
- *
- * The returned pcb is a chain: altcp_tls - altcp_proxyconnect - altcp_tcp - tcp pcb
- *
- * This function is meant for use with @ref altcp_new.
- *
- * @param arg struct altcp_proxyconnect_tls_config that contains the proxy settings
- *        and tls settings
- * @param ip_type IP type of the connection (@ref lwip_ip_addr_type)
- */
-struct altcp_pcb *
-altcp_proxyconnect_tls_alloc(void *arg, u8_t ip_type)
-{
-  struct altcp_proxyconnect_tls_config *cfg = (struct altcp_proxyconnect_tls_config *)arg;
-  struct altcp_pcb *proxy_pcb;
-  struct altcp_pcb *tls_pcb;
-
-  proxy_pcb = altcp_proxyconnect_new_tcp(&cfg->proxy, ip_type);
-  tls_pcb = altcp_tls_wrap(cfg->tls_config, proxy_pcb);
-
-  if (tls_pcb == NULL) {
-    altcp_close(proxy_pcb);
-  }
-  return tls_pcb;
-}
-#endif /* LWIP_ALTCP_TLS */
-
-/* "virtual" functions */
-static void
-altcp_proxyconnect_set_poll(struct altcp_pcb *conn, u8_t interval)
-{
-  if (conn != NULL) {
-    altcp_poll(conn->inner_conn, altcp_proxyconnect_lower_poll, interval);
-  }
-}
-
-static void
-altcp_proxyconnect_recved(struct altcp_pcb *conn, u16_t len)
-{
-  altcp_proxyconnect_state_t *state;
-  if (conn == NULL) {
-    return;
-  }
-  state = (altcp_proxyconnect_state_t *)conn->state;
-  if (state == NULL) {
-    return;
-  }
-  if (!(state->flags & ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE)) {
-    return;
-  }
-  altcp_recved(conn->inner_conn, len);
-}
-
-static err_t
-altcp_proxyconnect_connect(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port, altcp_connected_fn connected)
-{
-  altcp_proxyconnect_state_t *state;
-
-  if ((conn == NULL) || (ipaddr == NULL)) {
-    return ERR_VAL;
-  }
-  state = (altcp_proxyconnect_state_t *)conn->state;
-  if (state == NULL) {
-    return ERR_VAL;
-  }
-  if (state->flags & ALTCP_PROXYCONNECT_FLAGS_CONNECT_STARTED) {
-    return ERR_VAL;
-  }
-  state->flags |= ALTCP_PROXYCONNECT_FLAGS_CONNECT_STARTED;
-
-  conn->connected = connected;
-  /* connect to our proxy instead, but store the requested address and port */
-  ip_addr_copy(state->outer_addr, *ipaddr);
-  state->outer_port = port;
-
-  return altcp_connect(conn->inner_conn, &state->conf->proxy_addr, state->conf->proxy_port, altcp_proxyconnect_lower_connected);
-}
-
-static struct altcp_pcb *
-altcp_proxyconnect_listen(struct altcp_pcb *conn, u8_t backlog, err_t *err)
-{
-  LWIP_UNUSED_ARG(conn);
-  LWIP_UNUSED_ARG(backlog);
-  LWIP_UNUSED_ARG(err);
-  /* listen not supported! */
-  return NULL;
-}
-
-static void
-altcp_proxyconnect_abort(struct altcp_pcb *conn)
-{
-  if (conn != NULL) {
-    if (conn->inner_conn != NULL) {
-      altcp_abort(conn->inner_conn);
-    }
-    altcp_free(conn);
-  }
-}
-
-static err_t
-altcp_proxyconnect_close(struct altcp_pcb *conn)
-{
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  if (conn->inner_conn != NULL) {
-    err_t err = altcp_close(conn->inner_conn);
-    if (err != ERR_OK) {
-      /* closing inner conn failed, return the error */
-      return err;
-    }
-  }
-  /* no inner conn or closing it succeeded, deallocate myself */
-  altcp_free(conn);
-  return ERR_OK;
-}
-
-static err_t
-altcp_proxyconnect_write(struct altcp_pcb *conn, const void *dataptr, u16_t len, u8_t apiflags)
-{
-  altcp_proxyconnect_state_t *state;
-
-  LWIP_UNUSED_ARG(apiflags);
-
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-
-  state = (altcp_proxyconnect_state_t *)conn->state;
-  if (state == NULL) {
-    /* @todo: which error? */
-    return ERR_CLSD;
-  }
-  if (!(state->flags & ALTCP_PROXYCONNECT_FLAGS_HANDSHAKE_DONE)) {
-    /* @todo: which error? */
-    return ERR_VAL;
-  }
-  return altcp_write(conn->inner_conn, dataptr, len, apiflags);
-}
-
-static void
-altcp_proxyconnect_dealloc(struct altcp_pcb *conn)
-{
-  /* clean up and free tls state */
-  if (conn) {
-    altcp_proxyconnect_state_t *state = (altcp_proxyconnect_state_t *)conn->state;
-    if (state) {
-      altcp_proxyconnect_state_free(state);
-      conn->state = NULL;
-    }
-  }
-}
-const struct altcp_functions altcp_proxyconnect_functions = {
-  altcp_proxyconnect_set_poll,
-  altcp_proxyconnect_recved,
-  altcp_default_bind,
-  altcp_proxyconnect_connect,
-  altcp_proxyconnect_listen,
-  altcp_proxyconnect_abort,
-  altcp_proxyconnect_close,
-  altcp_default_shutdown,
-  altcp_proxyconnect_write,
-  altcp_default_output,
-  altcp_default_mss,
-  altcp_default_sndbuf,
-  altcp_default_sndqueuelen,
-  altcp_default_nagle_disable,
-  altcp_default_nagle_enable,
-  altcp_default_nagle_disabled,
-  altcp_default_setprio,
-  altcp_proxyconnect_dealloc,
-  altcp_default_get_tcp_addrinfo,
-  altcp_default_get_ip,
-  altcp_default_get_port
-#ifdef LWIP_DEBUG
-  , altcp_default_dbg_get_tcp_state
-#endif
-};
-
-#endif /* LWIP_ALTCP */
--- a/src/apps/http/http_client.c
+++ b/src/apps/http/http_client.c
@@ -1,909 +0,0 @@
-/**
- * @file
- * HTTP client
- */
-
-/*
- * Copyright (c) 2018 Simon Goldschmidt <goldsimon@gmx.de>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- */
-
-/**
- * @defgroup httpc HTTP client
- * @ingroup apps
- * @todo:
- * - persistent connections
- * - select outgoing http version
- * - optionally follow redirect
- * - check request uri for invalid characters? (e.g. encode spaces)
- * - IPv6 support
- */
-
-#include "lwip/apps/http_client.h"
-
-#include "lwip/altcp_tcp.h"
-#include "lwip/dns.h"
-#include "lwip/debug.h"
-#include "lwip/mem.h"
-#include "lwip/altcp_tls.h"
-#include "lwip/init.h"
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
-#if LWIP_TCP && LWIP_CALLBACK_API
-
-/**
- * HTTPC_DEBUG: Enable debugging for HTTP client.
- */
-#ifndef HTTPC_DEBUG
-#define HTTPC_DEBUG                 LWIP_DBG_OFF
-#endif
-
-/** Set this to 1 to keep server name and uri in request state */
-#ifndef HTTPC_DEBUG_REQUEST
-#define HTTPC_DEBUG_REQUEST         0
-#endif
-
-/** This string is passed in the HTTP header as "User-Agent: " */
-#ifndef HTTPC_CLIENT_AGENT
-#define HTTPC_CLIENT_AGENT "lwIP/" LWIP_VERSION_STRING " (http://savannah.nongnu.org/projects/lwip)"
-#endif
-
-/* the various debug levels for this file */
-#define HTTPC_DEBUG_TRACE        (HTTPC_DEBUG | LWIP_DBG_TRACE)
-#define HTTPC_DEBUG_STATE        (HTTPC_DEBUG | LWIP_DBG_STATE)
-#define HTTPC_DEBUG_WARN         (HTTPC_DEBUG | LWIP_DBG_LEVEL_WARNING)
-#define HTTPC_DEBUG_WARN_STATE   (HTTPC_DEBUG | LWIP_DBG_LEVEL_WARNING | LWIP_DBG_STATE)
-#define HTTPC_DEBUG_SERIOUS      (HTTPC_DEBUG | LWIP_DBG_LEVEL_SERIOUS)
-
-#define HTTPC_POLL_INTERVAL     1
-#define HTTPC_POLL_TIMEOUT      30 /* 15 seconds */
-
-#define HTTPC_CONTENT_LEN_INVALID 0xFFFFFFFF
-
-/* GET request basic */
-#define HTTPC_REQ_11 "GET %s HTTP/1.1\r\n" /* URI */\
-    "User-Agent: %s\r\n" /* User-Agent */ \
-    "Accept: */*\r\n" \
-    "Connection: Close\r\n" /* we don't support persistent connections, yet */ \
-    "\r\n"
-#define HTTPC_REQ_11_FORMAT(uri) HTTPC_REQ_11, uri, HTTPC_CLIENT_AGENT
-
-/* GET request with host */
-#define HTTPC_REQ_11_HOST "GET %s HTTP/1.1\r\n" /* URI */\
-    "User-Agent: %s\r\n" /* User-Agent */ \
-    "Accept: */*\r\n" \
-    "Host: %s\r\n" /* server name */ \
-    "Connection: Close\r\n" /* we don't support persistent connections, yet */ \
-    "\r\n"
-#define HTTPC_REQ_11_HOST_FORMAT(uri, srv_name) HTTPC_REQ_11_HOST, uri, HTTPC_CLIENT_AGENT, srv_name
-
-/* GET request with proxy */
-#define HTTPC_REQ_11_PROXY "GET http://%s%s HTTP/1.1\r\n" /* HOST, URI */\
-    "User-Agent: %s\r\n" /* User-Agent */ \
-    "Accept: */*\r\n" \
-    "Host: %s\r\n" /* server name */ \
-    "Connection: Close\r\n" /* we don't support persistent connections, yet */ \
-    "\r\n"
-#define HTTPC_REQ_11_PROXY_FORMAT(host, uri, srv_name) HTTPC_REQ_11_PROXY, host, uri, HTTPC_CLIENT_AGENT, srv_name
-
-/* GET request with proxy (non-default server port) */
-#define HTTPC_REQ_11_PROXY_PORT "GET http://%s:%d%s HTTP/1.1\r\n" /* HOST, host-port, URI */\
-    "User-Agent: %s\r\n" /* User-Agent */ \
-    "Accept: */*\r\n" \
-    "Host: %s\r\n" /* server name */ \
-    "Connection: Close\r\n" /* we don't support persistent connections, yet */ \
-    "\r\n"
-#define HTTPC_REQ_11_PROXY_PORT_FORMAT(host, host_port, uri, srv_name) HTTPC_REQ_11_PROXY_PORT, host, host_port, uri, HTTPC_CLIENT_AGENT, srv_name
-
-typedef enum ehttpc_parse_state {
-  HTTPC_PARSE_WAIT_FIRST_LINE = 0,
-  HTTPC_PARSE_WAIT_HEADERS,
-  HTTPC_PARSE_RX_DATA
-} httpc_parse_state_t;
-
-typedef struct _httpc_state
-{
-  struct altcp_pcb* pcb;
-  ip_addr_t remote_addr;
-  u16_t remote_port;
-  int timeout_ticks;
-  struct pbuf *request;
-  struct pbuf *rx_hdrs;
-  u16_t rx_http_version;
-  u16_t rx_status;
-  altcp_recv_fn recv_fn;
-  const httpc_connection_t *conn_settings;
-  void* callback_arg;
-  u32_t rx_content_len;
-  u32_t hdr_content_len;
-  httpc_parse_state_t parse_state;
-#if HTTPC_DEBUG_REQUEST
-  char* server_name;
-  char* uri;
-#endif
-} httpc_state_t;
-
-/** Free http client state and deallocate all resources within */
-static err_t
-httpc_free_state(httpc_state_t* req)
-{
-  struct altcp_pcb* tpcb;
-
-  if (req->request != NULL) {
-    pbuf_free(req->request);
-    req->request = NULL;
-  }
-  if (req->rx_hdrs != NULL) {
-    pbuf_free(req->rx_hdrs);
-    req->rx_hdrs = NULL;
-  }
-
-  tpcb = req->pcb;
-  mem_free(req);
-  req = NULL;
-
-  if (tpcb != NULL) {
-    err_t r;
-    altcp_arg(tpcb, NULL);
-    altcp_recv(tpcb, NULL);
-    altcp_err(tpcb, NULL);
-    altcp_poll(tpcb, NULL, 0);
-    altcp_sent(tpcb, NULL);
-    r = altcp_close(tpcb);
-    if (r != ERR_OK) {
-      altcp_abort(tpcb);
-      return ERR_ABRT;
-    }
-  }
-  return ERR_OK;
-}
-
-/** Close the connection: call finished callback and free the state */
-static err_t
-httpc_close(httpc_state_t* req, httpc_result_t result, u32_t server_response, err_t err)
-{
-  if (req != NULL) {
-    if (req->conn_settings != NULL) {
-      if (req->conn_settings->result_fn != NULL) {
-        req->conn_settings->result_fn(req->callback_arg, result, req->rx_content_len, server_response, err);
-      }
-    }
-    return httpc_free_state(req);
-  }
-  return ERR_OK;
-}
-
-/** Parse http header response line 1 */
-static err_t
-http_parse_response_status(struct pbuf *p, u16_t *http_version, u16_t *http_status, u16_t *http_status_str_offset)
-{
-  u16_t end1 = pbuf_memfind(p, "\r\n", 2, 0);
-  if (end1 != 0xFFFF) {
-    /* get parts of first line */
-    u16_t space1, space2;
-    space1 = pbuf_memfind(p, " ", 1, 0);
-    if (space1 != 0xFFFF) {
-      if ((pbuf_memcmp(p, 0, "HTTP/", 5) == 0)  && (pbuf_get_at(p, 6) == '.')) {
-        char status_num[10];
-        size_t status_num_len;
-        /* parse http version */
-        u16_t version = pbuf_get_at(p, 5) - '0';
-        version <<= 8;
-        version |= pbuf_get_at(p, 7) - '0';
-        *http_version = version;
-
-        /* parse http status number */
-        space2 = pbuf_memfind(p, " ", 1, space1 + 1);
-        if (space2 != 0xFFFF) {
-          *http_status_str_offset = space2 + 1;
-          status_num_len = space2 - space1 - 1;
-        } else {
-          status_num_len = end1 - space1 - 1;
-        }
-        memset(status_num, 0, sizeof(status_num));
-        if (pbuf_copy_partial(p, status_num, (u16_t)status_num_len, space1 + 1) == status_num_len) {
-          int status = atoi(status_num);
-          if ((status > 0) && (status <= 0xFFFF)) {
-            *http_status = (u16_t)status;
-            return ERR_OK;
-          }
-        }
-      }
-    }
-  }
-  return ERR_VAL;
-}
-
-/** Wait for all headers to be received, return its length and content-length (if available) */
-static err_t
-http_wait_headers(struct pbuf *p, u32_t *content_length, u16_t *total_header_len)
-{
-  u16_t end1 = pbuf_memfind(p, "\r\n\r\n", 4, 0);
-  if (end1 < (0xFFFF - 2)) {
-    /* all headers received */
-    /* check if we have a content length (@todo: case insensitive?) */
-    u16_t content_len_hdr;
-    *content_length = HTTPC_CONTENT_LEN_INVALID;
-    *total_header_len = end1 + 4;
-
-    content_len_hdr = pbuf_memfind(p, "Content-Length: ", 16, 0);
-    if (content_len_hdr != 0xFFFF) {
-      u16_t content_len_line_end = pbuf_memfind(p, "\r\n", 2, content_len_hdr);
-      if (content_len_line_end != 0xFFFF) {
-        char content_len_num[16];
-        u16_t content_len_num_len = (u16_t)(content_len_line_end - content_len_hdr - 16);
-        memset(content_len_num, 0, sizeof(content_len_num));
-        if (pbuf_copy_partial(p, content_len_num, content_len_num_len, content_len_hdr + 16) == content_len_num_len) {
-          int len = atoi(content_len_num);
-          if ((len >= 0) && ((u32_t)len < HTTPC_CONTENT_LEN_INVALID)) {
-            *content_length = (u32_t)len;
-          }
-        }
-      }
-    }
-    return ERR_OK;
-  }
-  return ERR_VAL;
-}
-
-/** http client tcp recv callback */
-static err_t
-httpc_tcp_recv(void *arg, struct altcp_pcb *pcb, struct pbuf *p, err_t r)
-{
-  httpc_state_t* req = (httpc_state_t*)arg;
-  LWIP_UNUSED_ARG(r);
-
-  if (p == NULL) {
-    httpc_result_t result;
-    if (req->parse_state != HTTPC_PARSE_RX_DATA) {
-      /* did not get RX data yet */
-      result = HTTPC_RESULT_ERR_CLOSED;
-    } else if ((req->hdr_content_len != HTTPC_CONTENT_LEN_INVALID) &&
-      (req->hdr_content_len != req->rx_content_len)) {
-      /* header has been received with content length but not all data received */
-      result = HTTPC_RESULT_ERR_CONTENT_LEN;
-    } else {
-      /* receiving data and either all data received or no content length header */
-      result = HTTPC_RESULT_OK;
-    }
-    return httpc_close(req, result, req->rx_status, ERR_OK);
-  }
-  if (req->parse_state != HTTPC_PARSE_RX_DATA) {
-    if (req->rx_hdrs == NULL) {
-      req->rx_hdrs = p;
-    } else {
-      pbuf_cat(req->rx_hdrs, p);
-    }
-    if (req->parse_state == HTTPC_PARSE_WAIT_FIRST_LINE) {
-      u16_t status_str_off;
-      err_t err = http_parse_response_status(req->rx_hdrs, &req->rx_http_version, &req->rx_status, &status_str_off);
-      if (err == ERR_OK) {
-        /* don't care status string */
-        req->parse_state = HTTPC_PARSE_WAIT_HEADERS;
-      }
-    }
-    if (req->parse_state == HTTPC_PARSE_WAIT_HEADERS) {
-      u16_t total_header_len;
-      err_t err = http_wait_headers(req->rx_hdrs, &req->hdr_content_len, &total_header_len);
-      if (err == ERR_OK) {
-        struct pbuf *q;
-        /* full header received, send window update for header bytes and call into client callback */
-        altcp_recved(pcb, total_header_len);
-        if (req->conn_settings) {
-          if (req->conn_settings->headers_done_fn) {
-            err = req->conn_settings->headers_done_fn(req, req->callback_arg, req->rx_hdrs, total_header_len, req->hdr_content_len);
-            if (err != ERR_OK) {
-              return httpc_close(req, HTTPC_RESULT_LOCAL_ABORT, req->rx_status, err);
-            }
-          }
-        }
-        /* hide header bytes in pbuf */
-        q = pbuf_free_header(req->rx_hdrs, total_header_len);
-        p = q;
-        req->rx_hdrs = NULL;
-        /* go on with data */
-        req->parse_state = HTTPC_PARSE_RX_DATA;
-      }
-    }
-  }
-  if ((p != NULL) && (req->parse_state == HTTPC_PARSE_RX_DATA)) {
-    req->rx_content_len += p->tot_len;
-    if (req->recv_fn != NULL) {
-      /* directly return here: the connection migth already be aborted from the callback! */
-      return req->recv_fn(req->callback_arg, pcb, p, r);
-    } else {
-      altcp_recved(pcb, p->tot_len);
-      pbuf_free(p);
-    }
-  }
-  return ERR_OK;
-}
-
-/** http client tcp err callback */
-static void
-httpc_tcp_err(void *arg, err_t err)
-{
-  httpc_state_t* req = (httpc_state_t*)arg;
-  if (req != NULL) {
-    /* pcb has already been deallocated */
-    req->pcb = NULL;
-    httpc_close(req, HTTPC_RESULT_ERR_CLOSED, 0, err);
-  }
-}
-
-/** http client tcp poll callback */
-static err_t
-httpc_tcp_poll(void *arg, struct altcp_pcb *pcb)
-{
-  /* implement timeout */
-  httpc_state_t* req = (httpc_state_t*)arg;
-  LWIP_UNUSED_ARG(pcb);
-  if (req != NULL) {
-    if (req->timeout_ticks) {
-      req->timeout_ticks--;
-    }
-    if (!req->timeout_ticks) {
-      return httpc_close(req, HTTPC_RESULT_ERR_TIMEOUT, 0, ERR_OK);
-    }
-  }
-  return ERR_OK;
-}
-
-/** http client tcp sent callback */
-static err_t
-httpc_tcp_sent(void *arg, struct altcp_pcb *pcb, u16_t len)
-{
-  /* nothing to do here for now */
-  LWIP_UNUSED_ARG(arg);
-  LWIP_UNUSED_ARG(pcb);
-  LWIP_UNUSED_ARG(len);
-  return ERR_OK;
-}
-
-/** http client tcp connected callback */
-static err_t
-httpc_tcp_connected(void *arg, struct altcp_pcb *pcb, err_t err)
-{
-  err_t r;
-  httpc_state_t* req = (httpc_state_t*)arg;
-  LWIP_UNUSED_ARG(pcb);
-  LWIP_UNUSED_ARG(err);
-
-  /* send request; last char is zero termination */
-  r = altcp_write(req->pcb, req->request->payload, req->request->len - 1, TCP_WRITE_FLAG_COPY);
-  if (r != ERR_OK) {
-     /* could not write the single small request -> fail, don't retry */
-     return httpc_close(req, HTTPC_RESULT_ERR_MEM, 0, r);
-  }
-  /* everything written, we can free the request */
-  pbuf_free(req->request);
-  req->request = NULL;
-
-  altcp_output(req->pcb);
-  return ERR_OK;
-}
-
-/** Start the http request when the server IP addr is known */
-static err_t
-httpc_get_internal_addr(httpc_state_t* req, const ip_addr_t *ipaddr)
-{
-  err_t err;
-  LWIP_ASSERT("req != NULL", req != NULL);
-
-  if (&req->remote_addr != ipaddr) {
-    /* fill in remote addr if called externally */
-    req->remote_addr = *ipaddr;
-  }
-
-  err = altcp_connect(req->pcb, &req->remote_addr, req->remote_port, httpc_tcp_connected);
-  if (err == ERR_OK) {
-    return ERR_OK;
-  }
-  LWIP_DEBUGF(HTTPC_DEBUG_WARN_STATE, ("tcp_connect failed: %d\n", (int)err));
-  return err;
-}
-
-#if LWIP_DNS
-/** DNS callback
- * If ipaddr is non-NULL, resolving succeeded and the request can be sent, otherwise it failed.
- */
-static void
-httpc_dns_found(const char* hostname, const ip_addr_t *ipaddr, void *arg)
-{
-  httpc_state_t* req = (httpc_state_t*)arg;
-  err_t err;
-  httpc_result_t result;
-
-  LWIP_UNUSED_ARG(hostname);
-
-  if (ipaddr != NULL) {
-    err = httpc_get_internal_addr(req, ipaddr);
-    if (err == ERR_OK) {
-      return;
-    }
-    result = HTTPC_RESULT_ERR_CONNECT;
-  } else {
-    LWIP_DEBUGF(HTTPC_DEBUG_WARN_STATE, ("httpc_dns_found: failed to resolve hostname: %s\n",
-      hostname));
-    result = HTTPC_RESULT_ERR_HOSTNAME;
-    err = ERR_ARG;
-  }
-  httpc_close(req, result, 0, err);
-}
-#endif /* LWIP_DNS */
-
-/** Start the http request after converting 'server_name' to ip address (DNS or address string) */
-static err_t
-httpc_get_internal_dns(httpc_state_t* req, const char* server_name)
-{
-  err_t err;
-  LWIP_ASSERT("req != NULL", req != NULL);
-
-#if LWIP_DNS
-  err = dns_gethostbyname(server_name, &req->remote_addr, httpc_dns_found, req);
-#else
-  err = ipaddr_aton(server_name, &req->remote_addr) ? ERR_OK : ERR_ARG;
-#endif
-
-  if (err == ERR_OK) {
-    /* cached or IP-string */
-    err = httpc_get_internal_addr(req, &req->remote_addr);
-  } else if (err == ERR_INPROGRESS) {
-    return ERR_OK;
-  }
-  return err;
-}
-
-static int
-httpc_create_request_string(const httpc_connection_t *settings, const char* server_name, int server_port, const char* uri,
-                            int use_host, char *buffer, size_t buffer_size)
-{
-  if (settings->use_proxy) {
-    LWIP_ASSERT("server_name != NULL", server_name != NULL);
-    if (server_port != HTTP_DEFAULT_PORT) {
-      return snprintf(buffer, buffer_size, HTTPC_REQ_11_PROXY_PORT_FORMAT(server_name, server_port, uri, server_name));
-    } else {
-      return snprintf(buffer, buffer_size, HTTPC_REQ_11_PROXY_FORMAT(server_name, uri, server_name));
-    }
-  } else if (use_host) {
-    LWIP_ASSERT("server_name != NULL", server_name != NULL);
-    return snprintf(buffer, buffer_size, HTTPC_REQ_11_HOST_FORMAT(uri, server_name));
-  } else {
-    return snprintf(buffer, buffer_size, HTTPC_REQ_11_FORMAT(uri));
-  }
-}
-
-/** Initialize the connection struct */
-static err_t
-httpc_init_connection_common(httpc_state_t **connection, const httpc_connection_t *settings, const char* server_name,
-                      u16_t server_port, const char* uri, altcp_recv_fn recv_fn, void* callback_arg, int use_host)
-{
-  size_t alloc_len;
-  mem_size_t mem_alloc_len;
-  int req_len, req_len2;
-  httpc_state_t *req;
-#if HTTPC_DEBUG_REQUEST
-  size_t server_name_len, uri_len;
-#endif
-
-  LWIP_ASSERT("uri != NULL", uri != NULL);
-
-  /* get request len */
-  req_len = httpc_create_request_string(settings, server_name, server_port, uri, use_host, NULL, 0);
-  if ((req_len < 0) || (req_len > 0xFFFF)) {
-    return ERR_VAL;
-  }
-  /* alloc state and request in one block */
-  alloc_len = sizeof(httpc_state_t);
-#if HTTPC_DEBUG_REQUEST
-  server_name_len = server_name ? strlen(server_name) : 0;
-  uri_len = strlen(uri);
-  alloc_len += server_name_len + 1 + uri_len + 1;
-#endif
-  mem_alloc_len = (mem_size_t)alloc_len;
-  if ((mem_alloc_len < alloc_len) || (req_len + 1 > 0xFFFF)) {
-    return ERR_VAL;
-  }
-
-  req = (httpc_state_t*)mem_malloc((mem_size_t)alloc_len);
-  if(req == NULL) {
-    return ERR_MEM;
-  }
-  memset(req, 0, sizeof(httpc_state_t));
-  req->timeout_ticks = HTTPC_POLL_TIMEOUT;
-  req->request = pbuf_alloc(PBUF_RAW, (u16_t)(req_len + 1), PBUF_RAM);
-  if (req->request == NULL) {
-    httpc_free_state(req);
-    return ERR_MEM;
-  }
-  if (req->request->next != NULL) {
-    /* need a pbuf in one piece */
-    httpc_free_state(req);
-    return ERR_MEM;
-  }
-  req->hdr_content_len = HTTPC_CONTENT_LEN_INVALID;
-#if HTTPC_DEBUG_REQUEST
-  req->server_name = (char*)(req + 1);
-  if (server_name) {
-    memcpy(req->server_name, server_name, server_name_len + 1);
-  }
-  req->uri = req->server_name + server_name_len + 1;
-  memcpy(req->uri, uri, uri_len + 1);
-#endif
-  req->pcb = altcp_new(settings->altcp_allocator);
-  if(req->pcb == NULL) {
-    httpc_free_state(req);
-    return ERR_MEM;
-  }
-  req->remote_port = settings->use_proxy ? settings->proxy_port : server_port;
-  altcp_arg(req->pcb, req);
-  altcp_recv(req->pcb, httpc_tcp_recv);
-  altcp_err(req->pcb, httpc_tcp_err);
-  altcp_poll(req->pcb, httpc_tcp_poll, HTTPC_POLL_INTERVAL);
-  altcp_sent(req->pcb, httpc_tcp_sent);
-
-  /* set up request buffer */
-  req_len2 = httpc_create_request_string(settings, server_name, server_port, uri, use_host,
-    (char *)req->request->payload, req_len + 1);
-  if (req_len2 != req_len) {
-    httpc_free_state(req);
-    return ERR_VAL;
-  }
-
-  req->recv_fn = recv_fn;
-  req->conn_settings = settings;
-  req->callback_arg = callback_arg;
-
-  *connection = req;
-  return ERR_OK;
-}
-
-/**
- * Initialize the connection struct
- */
-static err_t
-httpc_init_connection(httpc_state_t **connection, const httpc_connection_t *settings, const char* server_name,
-                      u16_t server_port, const char* uri, altcp_recv_fn recv_fn, void* callback_arg)
-{
-  return httpc_init_connection_common(connection, settings, server_name, server_port, uri, recv_fn, callback_arg, 1);
-}
-
-
-/**
- * Initialize the connection struct (from IP address)
- */
-static err_t
-httpc_init_connection_addr(httpc_state_t **connection, const httpc_connection_t *settings,
-                           const ip_addr_t* server_addr, u16_t server_port, const char* uri,
-                           altcp_recv_fn recv_fn, void* callback_arg)
-{
-  char *server_addr_str = ipaddr_ntoa(server_addr);
-  if (server_addr_str == NULL) {
-    return ERR_VAL;
-  }
-  return httpc_init_connection_common(connection, settings, server_addr_str, server_port, uri,
-    recv_fn, callback_arg, 1);
-}
-
-/**
- * @ingroup httpc 
- * HTTP client API: get a file by passing server IP address
- *
- * @param server_addr IP address of the server to connect
- * @param port tcp port of the server
- * @param uri uri to get from the server, remember leading "/"!
- * @param settings connection settings (callbacks, proxy, etc.)
- * @param recv_fn the http body (not the headers) are passed to this callback
- * @param callback_arg argument passed to all the callbacks
- * @param connection retreives the connection handle (to match in callbacks)
- * @return ERR_OK if starting the request succeeds (callback_fn will be called later)
- *         or an error code
- */
-err_t
-httpc_get_file(const ip_addr_t* server_addr, u16_t port, const char* uri, const httpc_connection_t *settings,
-               altcp_recv_fn recv_fn, void* callback_arg, httpc_state_t **connection)
-{
-  err_t err;
-  httpc_state_t* req;
-
-  LWIP_ERROR("invalid parameters", (server_addr != NULL) && (uri != NULL) && (recv_fn != NULL), return ERR_ARG;);
-
-  err = httpc_init_connection_addr(&req, settings, server_addr, port,
-    uri, recv_fn, callback_arg);
-  if (err != ERR_OK) {
-    return err;
-  }
-
-  if (settings->use_proxy) {
-    err = httpc_get_internal_addr(req, &settings->proxy_addr);
-  } else {
-    err = httpc_get_internal_addr(req, server_addr);
-  }
-  if(err != ERR_OK) {
-    httpc_free_state(req);
-    return err;
-  }
-
-  if (connection != NULL) {
-    *connection = req;
-  }
-  return ERR_OK;
-}
-
-/**
- * @ingroup httpc 
- * HTTP client API: get a file by passing server name as string (DNS name or IP address string)
- *
- * @param server_name server name as string (DNS name or IP address string)
- * @param port tcp port of the server
- * @param uri uri to get from the server, remember leading "/"!
- * @param settings connection settings (callbacks, proxy, etc.)
- * @param recv_fn the http body (not the headers) are passed to this callback
- * @param callback_arg argument passed to all the callbacks
- * @param connection retreives the connection handle (to match in callbacks)
- * @return ERR_OK if starting the request succeeds (callback_fn will be called later)
- *         or an error code
- */
-err_t
-httpc_get_file_dns(const char* server_name, u16_t port, const char* uri, const httpc_connection_t *settings,
-                   altcp_recv_fn recv_fn, void* callback_arg, httpc_state_t **connection)
-{
-  err_t err;
-  httpc_state_t* req;
-
-  LWIP_ERROR("invalid parameters", (server_name != NULL) && (uri != NULL) && (recv_fn != NULL), return ERR_ARG;);
-
-  err = httpc_init_connection(&req, settings, server_name, port, uri, recv_fn, callback_arg);
-  if (err != ERR_OK) {
-    return err;
-  }
-
-  if (settings->use_proxy) {
-    err = httpc_get_internal_addr(req, &settings->proxy_addr);
-  } else {
-    err = httpc_get_internal_dns(req, server_name);
-  }
-  if(err != ERR_OK) {
-    httpc_free_state(req);
-    return err;
-  }
-
-  if (connection != NULL) {
-    *connection = req;
-  }
-  return ERR_OK;
-}
-
-#if LWIP_HTTPC_HAVE_FILE_IO
-/* Implementation to disk via fopen/fwrite/fclose follows */
-
-typedef struct _httpc_filestate
-{
-  const char* local_file_name;
-  FILE *file;
-  httpc_connection_t settings;
-  const httpc_connection_t *client_settings;
-  void *callback_arg;
-} httpc_filestate_t;
-
-static void httpc_fs_result(void *arg, httpc_result_t httpc_result, u32_t rx_content_len,
-  u32_t srv_res, err_t err);
-
-/** Initalize http client state for download to file system */
-static err_t
-httpc_fs_init(httpc_filestate_t **filestate_out, const char* local_file_name,
-              const httpc_connection_t *settings, void* callback_arg)
-{
-  httpc_filestate_t *filestate;
-  size_t file_len, alloc_len;
-  FILE *f;
-
-  file_len = strlen(local_file_name);
-  alloc_len = sizeof(httpc_filestate_t) + file_len + 1;
-
-  filestate = (httpc_filestate_t *)mem_malloc((mem_size_t)alloc_len);
-  if (filestate == NULL) {
-    return ERR_MEM;
-  }
-  memset(filestate, 0, sizeof(httpc_filestate_t));
-  filestate->local_file_name = (const char *)(filestate + 1);
-  memcpy((char *)(filestate + 1), local_file_name, file_len + 1);
-  filestate->file = NULL;
-  filestate->client_settings = settings;
-  filestate->callback_arg = callback_arg;
-  /* copy client settings but override result callback */
-  memcpy(&filestate->settings, settings, sizeof(httpc_connection_t));
-  filestate->settings.result_fn = httpc_fs_result;
-
-  f = fopen(local_file_name, "wb");
-  if(f == NULL) {
-    /* could not open file */
-    mem_free(filestate);
-    return ERR_VAL;
-  }
-  filestate->file = f;
-  *filestate_out = filestate;
-  return ERR_OK;
-}
-
-/** Free http client state for download to file system */
-static void
-httpc_fs_free(httpc_filestate_t *filestate)
-{
-  if (filestate != NULL) {
-    if (filestate->file != NULL) {
-      fclose(filestate->file);
-      filestate->file = NULL;
-    }
-    mem_free(filestate);
-  }
-}
-
-/** Connection closed (success or error) */
-static void
-httpc_fs_result(void *arg, httpc_result_t httpc_result, u32_t rx_content_len,
-                u32_t srv_res, err_t err)
-{
-  httpc_filestate_t *filestate = (httpc_filestate_t *)arg;
-  if (filestate != NULL) {
-    if (filestate->client_settings->result_fn != NULL) {
-      filestate->client_settings->result_fn(filestate->callback_arg, httpc_result, rx_content_len,
-        srv_res, err);
-    }
-    httpc_fs_free(filestate);
-  }
-}
-
-/** tcp recv callback */
-static err_t
-httpc_fs_tcp_recv(void *arg, struct altcp_pcb *pcb, struct pbuf *p, err_t err)
-{
-  httpc_filestate_t *filestate = (httpc_filestate_t*)arg;
-  struct pbuf* q;
-  LWIP_UNUSED_ARG(err);
-
-  LWIP_ASSERT("p != NULL", p != NULL);
-
-  for (q = p; q != NULL; q = q->next) {
-    fwrite(q->payload, 1, q->len, filestate->file);
-  }
-  altcp_recved(pcb, p->tot_len);
-  pbuf_free(p);
-  return ERR_OK;
-}
-
-/**
- * @ingroup httpc 
- * HTTP client API: get a file to disk by passing server IP address
- *
- * @param server_addr IP address of the server to connect
- * @param port tcp port of the server
- * @param uri uri to get from the server, remember leading "/"!
- * @param settings connection settings (callbacks, proxy, etc.)
- * @param callback_arg argument passed to all the callbacks
- * @param connection retreives the connection handle (to match in callbacks)
- * @return ERR_OK if starting the request succeeds (callback_fn will be called later)
- *         or an error code
- */
-err_t
-httpc_get_file_to_disk(const ip_addr_t* server_addr, u16_t port, const char* uri, const httpc_connection_t *settings,
-                       void* callback_arg, const char* local_file_name, httpc_state_t **connection)
-{
-  err_t err;
-  httpc_state_t* req;
-  httpc_filestate_t *filestate;
-
-  LWIP_ERROR("invalid parameters", (server_addr != NULL) && (uri != NULL) && (local_file_name != NULL), return ERR_ARG;);
-
-  err = httpc_fs_init(&filestate, local_file_name, settings, callback_arg);
-  if (err != ERR_OK) {
-    return err;
-  }
-
-  err = httpc_init_connection_addr(&req, &filestate->settings, server_addr, port,
-    uri, httpc_fs_tcp_recv, filestate);
-  if (err != ERR_OK) {
-    httpc_fs_free(filestate);
-    return err;
-  }
-
-  if (settings->use_proxy) {
-    err = httpc_get_internal_addr(req, &settings->proxy_addr);
-  } else {
-    err = httpc_get_internal_addr(req, server_addr);
-  }
-  if(err != ERR_OK) {
-    httpc_fs_free(filestate);
-    httpc_free_state(req);
-    return err;
-  }
-
-  if (connection != NULL) {
-    *connection = req;
-  }
-  return ERR_OK;
-}
-
-/**
- * @ingroup httpc 
- * HTTP client API: get a file to disk by passing server name as string (DNS name or IP address string)
- *
- * @param server_name server name as string (DNS name or IP address string)
- * @param port tcp port of the server
- * @param uri uri to get from the server, remember leading "/"!
- * @param settings connection settings (callbacks, proxy, etc.)
- * @param callback_arg argument passed to all the callbacks
- * @param connection retreives the connection handle (to match in callbacks)
- * @return ERR_OK if starting the request succeeds (callback_fn will be called later)
- *         or an error code
- */
-err_t
-httpc_get_file_dns_to_disk(const char* server_name, u16_t port, const char* uri, const httpc_connection_t *settings,
-                           void* callback_arg, const char* local_file_name, httpc_state_t **connection)
-{
-  err_t err;
-  httpc_state_t* req;
-  httpc_filestate_t *filestate;
-
-  LWIP_ERROR("invalid parameters", (server_name != NULL) && (uri != NULL) && (local_file_name != NULL), return ERR_ARG;);
-
-  err = httpc_fs_init(&filestate, local_file_name, settings, callback_arg);
-  if (err != ERR_OK) {
-    return err;
-  }
-
-  err = httpc_init_connection(&req, &filestate->settings, server_name, port,
-    uri, httpc_fs_tcp_recv, filestate);
-  if (err != ERR_OK) {
-    httpc_fs_free(filestate);
-    return err;
-  }
-
-  if (settings->use_proxy) {
-    err = httpc_get_internal_addr(req, &settings->proxy_addr);
-  } else {
-    err = httpc_get_internal_dns(req, server_name);
-  }
-  if(err != ERR_OK) {
-    httpc_fs_free(filestate);
-    httpc_free_state(req);
-    return err;
-  }
-
-  if (connection != NULL) {
-    *connection = req;
-  }
-  return ERR_OK;
-}
-#endif /* LWIP_HTTPC_HAVE_FILE_IO */
-
-#endif /* LWIP_TCP && LWIP_CALLBACK_API */
--- a/src/apps/http/httpd_structs.h
+++ b/src/apps/http/httpd_structs.h
@@ -1,123 +0,0 @@
-#ifndef LWIP_HTTPD_STRUCTS_H
-#define LWIP_HTTPD_STRUCTS_H
-
-#include "lwip/apps/httpd.h"
-
-#if LWIP_HTTPD_DYNAMIC_HEADERS
-/** This struct is used for a list of HTTP header strings for various
- * filename extensions. */
-typedef struct {
-  const char *extension;
-  const char *content_type;
-} tHTTPHeader;
-
-/** A list of strings used in HTTP headers (see RFC 1945 HTTP/1.0 and
- * RFC 2616 HTTP/1.1 for header field definitions) */
-static const char *const g_psHTTPHeaderStrings[] = {
-  "HTTP/1.0 200 OK\r\n",
-  "HTTP/1.0 404 File not found\r\n",
-  "HTTP/1.0 400 Bad Request\r\n",
-  "HTTP/1.0 501 Not Implemented\r\n",
-  "HTTP/1.1 200 OK\r\n",
-  "HTTP/1.1 404 File not found\r\n",
-  "HTTP/1.1 400 Bad Request\r\n",
-  "HTTP/1.1 501 Not Implemented\r\n",
-  "Content-Length: ",
-  "Connection: Close\r\n",
-  "Connection: keep-alive\r\n",
-  "Connection: keep-alive\r\nContent-Length: ",
-  "Server: "HTTPD_SERVER_AGENT"\r\n",
-  "\r\n<html><body><h2>404: The requested file cannot be found.</h2></body></html>\r\n"
-#if LWIP_HTTPD_SUPPORT_11_KEEPALIVE
-  , "Connection: keep-alive\r\nContent-Length: 77\r\n\r\n<html><body><h2>404: The requested file cannot be found.</h2></body></html>\r\n"
-#endif
-};
-
-/* Indexes into the g_psHTTPHeaderStrings array */
-#define HTTP_HDR_OK             0 /* 200 OK */
-#define HTTP_HDR_NOT_FOUND      1 /* 404 File not found */
-#define HTTP_HDR_BAD_REQUEST    2 /* 400 Bad request */
-#define HTTP_HDR_NOT_IMPL       3 /* 501 Not Implemented */
-#define HTTP_HDR_OK_11          4 /* 200 OK */
-#define HTTP_HDR_NOT_FOUND_11   5 /* 404 File not found */
-#define HTTP_HDR_BAD_REQUEST_11 6 /* 400 Bad request */
-#define HTTP_HDR_NOT_IMPL_11    7 /* 501 Not Implemented */
-#define HTTP_HDR_CONTENT_LENGTH 8 /* Content-Length: (HTTP 1.0)*/
-#define HTTP_HDR_CONN_CLOSE     9 /* Connection: Close (HTTP 1.1) */
-#define HTTP_HDR_CONN_KEEPALIVE 10 /* Connection: keep-alive (HTTP 1.1) */
-#define HTTP_HDR_KEEPALIVE_LEN  11 /* Connection: keep-alive + Content-Length: (HTTP 1.1)*/
-#define HTTP_HDR_SERVER         12 /* Server: HTTPD_SERVER_AGENT */
-#define DEFAULT_404_HTML        13 /* default 404 body */
-#if LWIP_HTTPD_SUPPORT_11_KEEPALIVE
-#define DEFAULT_404_HTML_PERSISTENT 14 /* default 404 body, but including Connection: keep-alive */
-#endif
-
-#define HTTP_CONTENT_TYPE(contenttype) "Content-Type: "contenttype"\r\n\r\n"
-#define HTTP_CONTENT_TYPE_ENCODING(contenttype, encoding) "Content-Type: "contenttype"\r\nContent-Encoding: "encoding"\r\n\r\n"
-
-#define HTTP_HDR_HTML           HTTP_CONTENT_TYPE("text/html")
-#define HTTP_HDR_SSI            HTTP_CONTENT_TYPE("text/html\r\nExpires: Fri, 10 Apr 2008 14:00:00 GMT\r\nPragma: no-cache")
-#define HTTP_HDR_GIF            HTTP_CONTENT_TYPE("image/gif")
-#define HTTP_HDR_PNG            HTTP_CONTENT_TYPE("image/png")
-#define HTTP_HDR_JPG            HTTP_CONTENT_TYPE("image/jpeg")
-#define HTTP_HDR_BMP            HTTP_CONTENT_TYPE("image/bmp")
-#define HTTP_HDR_ICO            HTTP_CONTENT_TYPE("image/x-icon")
-#define HTTP_HDR_APP            HTTP_CONTENT_TYPE("application/octet-stream")
-#define HTTP_HDR_JS             HTTP_CONTENT_TYPE("application/javascript")
-#define HTTP_HDR_RA             HTTP_CONTENT_TYPE("application/javascript")
-#define HTTP_HDR_CSS            HTTP_CONTENT_TYPE("text/css")
-#define HTTP_HDR_SWF            HTTP_CONTENT_TYPE("application/x-shockwave-flash")
-#define HTTP_HDR_XML            HTTP_CONTENT_TYPE("text/xml")
-#define HTTP_HDR_PDF            HTTP_CONTENT_TYPE("application/pdf")
-#define HTTP_HDR_JSON           HTTP_CONTENT_TYPE("application/json")
-#define HTTP_HDR_CSV            HTTP_CONTENT_TYPE("text/csv")
-#define HTTP_HDR_TSV            HTTP_CONTENT_TYPE("text/tsv")
-#define HTTP_HDR_SVG            HTTP_CONTENT_TYPE("image/svg+xml")
-#define HTTP_HDR_SVGZ           HTTP_CONTENT_TYPE_ENCODING("image/svg+xml", "gzip")
-
-#define HTTP_HDR_DEFAULT_TYPE   HTTP_CONTENT_TYPE("text/plain")
-
-/** A list of extension-to-HTTP header strings (see outdated RFC 1700 MEDIA TYPES
- * and http://www.iana.org/assignments/media-types for registered content types
- * and subtypes) */
-static const tHTTPHeader g_psHTTPHeaders[] = {
-  { "html", HTTP_HDR_HTML},
-  { "htm",  HTTP_HDR_HTML},
-  { "shtml", HTTP_HDR_SSI},
-  { "shtm", HTTP_HDR_SSI},
-  { "ssi",  HTTP_HDR_SSI},
-  { "gif",  HTTP_HDR_GIF},
-  { "png",  HTTP_HDR_PNG},
-  { "jpg",  HTTP_HDR_JPG},
-  { "bmp",  HTTP_HDR_BMP},
-  { "ico",  HTTP_HDR_ICO},
-  { "class", HTTP_HDR_APP},
-  { "cls",  HTTP_HDR_APP},
-  { "js",   HTTP_HDR_JS},
-  { "ram",  HTTP_HDR_RA},
-  { "css",  HTTP_HDR_CSS},
-  { "swf",  HTTP_HDR_SWF},
-  { "xml",  HTTP_HDR_XML},
-  { "xsl",  HTTP_HDR_XML},
-  { "pdf",  HTTP_HDR_PDF},
-  { "json", HTTP_HDR_JSON}
-#ifdef HTTPD_ADDITIONAL_CONTENT_TYPES
-  /* If you need to add content types not listed here:
-   * #define HTTPD_ADDITIONAL_CONTENT_TYPES {"ct1", HTTP_CONTENT_TYPE("text/ct1")}, {"exe", HTTP_CONTENT_TYPE("application/exe")}
-   */
-  , HTTPD_ADDITIONAL_CONTENT_TYPES
-#endif
-};
-
-#define NUM_HTTP_HEADERS LWIP_ARRAYSIZE(g_psHTTPHeaders)
-
-#endif /* LWIP_HTTPD_DYNAMIC_HEADERS */
-
-#if LWIP_HTTPD_SSI
-static const char *const g_pcSSIExtensions[] = {
-  ".shtml", ".shtm", ".ssi", ".xml", ".json"
-};
-#define NUM_SHTML_EXTENSIONS LWIP_ARRAYSIZE(g_pcSSIExtensions)
-#endif /* LWIP_HTTPD_SSI */
-
-#endif /* LWIP_HTTPD_STRUCTS_H */
--- a/src/apps/http/makefsdata/tinydir.h
+++ b/src/apps/http/makefsdata/tinydir.h
@@ -1,808 +0,0 @@
-/*
-Copyright (c) 2013-2017, tinydir authors:
- Cong Xu
- Lautis Sun
- Baudouin Feildel
- Andargor <andargor@yahoo.com>
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this
-   list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright notice,
-   this list of conditions and the following disclaimer in the documentation
-   and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
-ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-*/
-#ifndef TINYDIR_H
-#define TINYDIR_H
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-#if ((defined _UNICODE) && !(defined UNICODE))
-#define UNICODE
-#endif
-
-#if ((defined UNICODE) && !(defined _UNICODE))
-#define _UNICODE
-#endif
-
-#include <errno.h>
-#include <stdlib.h>
-#include <string.h>
-#ifdef _MSC_VER
-# define WIN32_LEAN_AND_MEAN
-# include <windows.h>
-# include <tchar.h>
-# pragma warning(push)
-# pragma warning (disable : 4996)
-#else
-# include <dirent.h>
-# include <libgen.h>
-# include <sys/stat.h>
-# include <stddef.h>
-#endif
-#ifdef __MINGW32__
-# include <tchar.h>
-#endif
-
-
-/* types */
-
-/* Windows UNICODE wide character support */
-#if defined _MSC_VER || defined __MINGW32__
-#define _tinydir_char_t TCHAR
-#define TINYDIR_STRING(s) _TEXT(s)
-#define _tinydir_strlen _tcslen
-#define _tinydir_strcpy _tcscpy
-#define _tinydir_strcat _tcscat
-#define _tinydir_strcmp _tcscmp
-#define _tinydir_strrchr _tcsrchr
-#define _tinydir_strncmp _tcsncmp
-#else
-#define _tinydir_char_t char
-#define TINYDIR_STRING(s) s
-#define _tinydir_strlen strlen
-#define _tinydir_strcpy strcpy
-#define _tinydir_strcat strcat
-#define _tinydir_strcmp strcmp
-#define _tinydir_strrchr strrchr
-#define _tinydir_strncmp strncmp
-#endif
-
-#if (defined _MSC_VER || defined __MINGW32__)
-#include <windows.h>
-#define _TINYDIR_PATH_MAX MAX_PATH
-#elif defined  __linux__
-#include <linux/limits.h>
-#define _TINYDIR_PATH_MAX PATH_MAX
-#else
-#define _TINYDIR_PATH_MAX 4096
-#endif
-
-#ifdef _MSC_VER
-/* extra chars for the "\\*" mask */
-# define _TINYDIR_PATH_EXTRA 2
-#else
-# define _TINYDIR_PATH_EXTRA 0
-#endif
-
-#define _TINYDIR_FILENAME_MAX 256
-
-#if (defined _MSC_VER || defined __MINGW32__)
-#define _TINYDIR_DRIVE_MAX 3
-#endif
-
-#ifdef _MSC_VER
-# define _TINYDIR_FUNC static __inline
-#elif !defined __STDC_VERSION__ || __STDC_VERSION__ < 199901L
-# define _TINYDIR_FUNC static __inline__
-#else
-# define _TINYDIR_FUNC static inline
-#endif
-
-/* readdir_r usage; define TINYDIR_USE_READDIR_R to use it (if supported) */
-#ifdef TINYDIR_USE_READDIR_R
-
-/* readdir_r is a POSIX-only function, and may not be available under various
- * environments/settings, e.g. MinGW. Use readdir fallback */
-#if _POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _BSD_SOURCE || _SVID_SOURCE ||\
-	_POSIX_SOURCE
-# define _TINYDIR_HAS_READDIR_R
-#endif
-#if _POSIX_C_SOURCE >= 200112L
-# define _TINYDIR_HAS_FPATHCONF
-# include <unistd.h>
-#endif
-#if _BSD_SOURCE || _SVID_SOURCE || \
-	(_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700)
-# define _TINYDIR_HAS_DIRFD
-# include <sys/types.h>
-#endif
-#if defined _TINYDIR_HAS_FPATHCONF && defined _TINYDIR_HAS_DIRFD &&\
-	defined _PC_NAME_MAX
-# define _TINYDIR_USE_FPATHCONF
-#endif
-#if defined __MINGW32__ || !defined _TINYDIR_HAS_READDIR_R ||\
-	!(defined _TINYDIR_USE_FPATHCONF || defined NAME_MAX)
-# define _TINYDIR_USE_READDIR
-#endif
-
-/* Use readdir by default */
-#else
-# define _TINYDIR_USE_READDIR
-#endif
-
-/* MINGW32 has two versions of dirent, ASCII and UNICODE*/
-#ifndef _MSC_VER
-#if (defined __MINGW32__) && (defined _UNICODE)
-#define _TINYDIR_DIR _WDIR
-#define _tinydir_dirent _wdirent
-#define _tinydir_opendir _wopendir
-#define _tinydir_readdir _wreaddir
-#define _tinydir_closedir _wclosedir
-#else
-#define _TINYDIR_DIR DIR
-#define _tinydir_dirent dirent
-#define _tinydir_opendir opendir
-#define _tinydir_readdir readdir
-#define _tinydir_closedir closedir
-#endif
-#endif
-
-/* Allow user to use a custom allocator by defining _TINYDIR_MALLOC and _TINYDIR_FREE. */
-#if    defined(_TINYDIR_MALLOC) &&  defined(_TINYDIR_FREE)
-#elif !defined(_TINYDIR_MALLOC) && !defined(_TINYDIR_FREE)
-#else
-#error "Either define both alloc and free or none of them!"
-#endif
-
-#if !defined(_TINYDIR_MALLOC)
-	#define _TINYDIR_MALLOC(_size) malloc(_size)
-	#define _TINYDIR_FREE(_ptr)    free(_ptr)
-#endif /* !defined(_TINYDIR_MALLOC) */
-
-typedef struct tinydir_file
-{
-	_tinydir_char_t path[_TINYDIR_PATH_MAX];
-	_tinydir_char_t name[_TINYDIR_FILENAME_MAX];
-	_tinydir_char_t *extension;
-	int is_dir;
-	int is_reg;
-
-#ifndef _MSC_VER
-#ifdef __MINGW32__
-	struct _stat _s;
-#else
-	struct stat _s;
-#endif
-#endif
-} tinydir_file;
-
-typedef struct tinydir_dir
-{
-	_tinydir_char_t path[_TINYDIR_PATH_MAX];
-	int has_next;
-	size_t n_files;
-
-	tinydir_file *_files;
-#ifdef _MSC_VER
-	HANDLE _h;
-	WIN32_FIND_DATA _f;
-#else
-	_TINYDIR_DIR *_d;
-	struct _tinydir_dirent *_e;
-#ifndef _TINYDIR_USE_READDIR
-	struct _tinydir_dirent *_ep;
-#endif
-#endif
-} tinydir_dir;
-
-
-/* declarations */
-
-_TINYDIR_FUNC
-int tinydir_open(tinydir_dir *dir, const _tinydir_char_t *path);
-_TINYDIR_FUNC
-int tinydir_open_sorted(tinydir_dir *dir, const _tinydir_char_t *path);
-_TINYDIR_FUNC
-void tinydir_close(tinydir_dir *dir);
-
-_TINYDIR_FUNC
-int tinydir_next(tinydir_dir *dir);
-_TINYDIR_FUNC
-int tinydir_readfile(const tinydir_dir *dir, tinydir_file *file);
-_TINYDIR_FUNC
-int tinydir_readfile_n(const tinydir_dir *dir, tinydir_file *file, size_t i);
-_TINYDIR_FUNC
-int tinydir_open_subdir_n(tinydir_dir *dir, size_t i);
-
-_TINYDIR_FUNC
-int tinydir_file_open(tinydir_file *file, const _tinydir_char_t *path);
-_TINYDIR_FUNC
-void _tinydir_get_ext(tinydir_file *file);
-_TINYDIR_FUNC
-int _tinydir_file_cmp(const void *a, const void *b);
-#ifndef _MSC_VER
-#ifndef _TINYDIR_USE_READDIR
-_TINYDIR_FUNC
-size_t _tinydir_dirent_buf_size(_TINYDIR_DIR *dirp);
-#endif
-#endif
-
-
-/* definitions*/
-
-_TINYDIR_FUNC
-int tinydir_open(tinydir_dir *dir, const _tinydir_char_t *path)
-{
-#ifndef _MSC_VER
-#ifndef _TINYDIR_USE_READDIR
-	int error;
-	int size;	/* using int size */
-#endif
-#else
-	_tinydir_char_t path_buf[_TINYDIR_PATH_MAX];
-#endif
-	_tinydir_char_t *pathp;
-
-	if (dir == NULL || path == NULL || _tinydir_strlen(path) == 0)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	if (_tinydir_strlen(path) + _TINYDIR_PATH_EXTRA >= _TINYDIR_PATH_MAX)
-	{
-		errno = ENAMETOOLONG;
-		return -1;
-	}
-
-	/* initialise dir */
-	dir->_files = NULL;
-#ifdef _MSC_VER
-	dir->_h = INVALID_HANDLE_VALUE;
-#else
-	dir->_d = NULL;
-#ifndef _TINYDIR_USE_READDIR
-	dir->_ep = NULL;
-#endif
-#endif
-	tinydir_close(dir);
-
-	_tinydir_strcpy(dir->path, path);
-	/* Remove trailing slashes */
-	pathp = &dir->path[_tinydir_strlen(dir->path) - 1];
-	while (pathp != dir->path && (*pathp == TINYDIR_STRING('\\') || *pathp == TINYDIR_STRING('/')))
-	{
-		*pathp = TINYDIR_STRING('\0');
-		pathp++;
-	}
-#ifdef _MSC_VER
-	_tinydir_strcpy(path_buf, dir->path);
-	_tinydir_strcat(path_buf, TINYDIR_STRING("\\*"));
-#if (defined WINAPI_FAMILY) && (WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP)
-	dir->_h = FindFirstFileEx(path_buf, FindExInfoStandard, &dir->_f, FindExSearchNameMatch, NULL, 0);
-#else
-	dir->_h = FindFirstFile(path_buf, &dir->_f);
-#endif
-	if (dir->_h == INVALID_HANDLE_VALUE)
-	{
-		errno = ENOENT;
-#else
-	dir->_d = _tinydir_opendir(path);
-	if (dir->_d == NULL)
-	{
-#endif
-		goto bail;
-	}
-
-	/* read first file */
-	dir->has_next = 1;
-#ifndef _MSC_VER
-#ifdef _TINYDIR_USE_READDIR
-	dir->_e = _tinydir_readdir(dir->_d);
-#else
-	/* allocate dirent buffer for readdir_r */
-	size = _tinydir_dirent_buf_size(dir->_d); /* conversion to int */
-	if (size == -1) return -1;
-	dir->_ep = (struct _tinydir_dirent*)_TINYDIR_MALLOC(size);
-	if (dir->_ep == NULL) return -1;
-
-	error = readdir_r(dir->_d, dir->_ep, &dir->_e);
-	if (error != 0) return -1;
-#endif
-	if (dir->_e == NULL)
-	{
-		dir->has_next = 0;
-	}
-#endif
-
-	return 0;
-
-bail:
-	tinydir_close(dir);
-	return -1;
-}
-
-_TINYDIR_FUNC
-int tinydir_open_sorted(tinydir_dir *dir, const _tinydir_char_t *path)
-{
-	/* Count the number of files first, to pre-allocate the files array */
-	size_t n_files = 0;
-	if (tinydir_open(dir, path) == -1)
-	{
-		return -1;
-	}
-	while (dir->has_next)
-	{
-		n_files++;
-		if (tinydir_next(dir) == -1)
-		{
-			goto bail;
-		}
-	}
-	tinydir_close(dir);
-
-	if (tinydir_open(dir, path) == -1)
-	{
-		return -1;
-	}
-
-	dir->n_files = 0;
-	dir->_files = (tinydir_file *)_TINYDIR_MALLOC(sizeof *dir->_files * n_files);
-	if (dir->_files == NULL)
-	{
-		goto bail;
-	}
-	while (dir->has_next)
-	{
-		tinydir_file *p_file;
-		dir->n_files++;
-
-		p_file = &dir->_files[dir->n_files - 1];
-		if (tinydir_readfile(dir, p_file) == -1)
-		{
-			goto bail;
-		}
-
-		if (tinydir_next(dir) == -1)
-		{
-			goto bail;
-		}
-
-		/* Just in case the number of files has changed between the first and
-		second reads, terminate without writing into unallocated memory */
-		if (dir->n_files == n_files)
-		{
-			break;
-		}
-	}
-
-	qsort(dir->_files, dir->n_files, sizeof(tinydir_file), _tinydir_file_cmp);
-
-	return 0;
-
-bail:
-	tinydir_close(dir);
-	return -1;
-}
-
-_TINYDIR_FUNC
-void tinydir_close(tinydir_dir *dir)
-{
-	if (dir == NULL)
-	{
-		return;
-	}
-
-	memset(dir->path, 0, sizeof(dir->path));
-	dir->has_next = 0;
-	dir->n_files = 0;
-	_TINYDIR_FREE(dir->_files);
-	dir->_files = NULL;
-#ifdef _MSC_VER
-	if (dir->_h != INVALID_HANDLE_VALUE)
-	{
-		FindClose(dir->_h);
-	}
-	dir->_h = INVALID_HANDLE_VALUE;
-#else
-	if (dir->_d)
-	{
-		_tinydir_closedir(dir->_d);
-	}
-	dir->_d = NULL;
-	dir->_e = NULL;
-#ifndef _TINYDIR_USE_READDIR
-	_TINYDIR_FREE(dir->_ep);
-	dir->_ep = NULL;
-#endif
-#endif
-}
-
-_TINYDIR_FUNC
-int tinydir_next(tinydir_dir *dir)
-{
-	if (dir == NULL)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	if (!dir->has_next)
-	{
-		errno = ENOENT;
-		return -1;
-	}
-
-#ifdef _MSC_VER
-	if (FindNextFile(dir->_h, &dir->_f) == 0)
-#else
-#ifdef _TINYDIR_USE_READDIR
-	dir->_e = _tinydir_readdir(dir->_d);
-#else
-	if (dir->_ep == NULL)
-	{
-		return -1;
-	}
-	if (readdir_r(dir->_d, dir->_ep, &dir->_e) != 0)
-	{
-		return -1;
-	}
-#endif
-	if (dir->_e == NULL)
-#endif
-	{
-		dir->has_next = 0;
-#ifdef _MSC_VER
-		if (GetLastError() != ERROR_SUCCESS &&
-			GetLastError() != ERROR_NO_MORE_FILES)
-		{
-			tinydir_close(dir);
-			errno = EIO;
-			return -1;
-		}
-#endif
-	}
-
-	return 0;
-}
-
-_TINYDIR_FUNC
-int tinydir_readfile(const tinydir_dir *dir, tinydir_file *file)
-{
-	if (dir == NULL || file == NULL)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-#ifdef _MSC_VER
-	if (dir->_h == INVALID_HANDLE_VALUE)
-#else
-	if (dir->_e == NULL)
-#endif
-	{
-		errno = ENOENT;
-		return -1;
-	}
-	if (_tinydir_strlen(dir->path) +
-		_tinydir_strlen(
-#ifdef _MSC_VER
-			dir->_f.cFileName
-#else
-			dir->_e->d_name
-#endif
-		) + 1 + _TINYDIR_PATH_EXTRA >=
-		_TINYDIR_PATH_MAX)
-	{
-		/* the path for the file will be too long */
-		errno = ENAMETOOLONG;
-		return -1;
-	}
-	if (_tinydir_strlen(
-#ifdef _MSC_VER
-			dir->_f.cFileName
-#else
-			dir->_e->d_name
-#endif
-		) >= _TINYDIR_FILENAME_MAX)
-	{
-		errno = ENAMETOOLONG;
-		return -1;
-	}
-
-	_tinydir_strcpy(file->path, dir->path);
-	_tinydir_strcat(file->path, TINYDIR_STRING("/"));
-	_tinydir_strcpy(file->name,
-#ifdef _MSC_VER
-		dir->_f.cFileName
-#else
-		dir->_e->d_name
-#endif
-	);
-	_tinydir_strcat(file->path, file->name);
-#ifndef _MSC_VER
-#ifdef __MINGW32__
-	if (_tstat(
-#else
-	if (stat(
-#endif
-		file->path, &file->_s) == -1)
-	{
-		return -1;
-	}
-#endif
-	_tinydir_get_ext(file);
-
-	file->is_dir =
-#ifdef _MSC_VER
-		!!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY);
-#else
-		S_ISDIR(file->_s.st_mode);
-#endif
-	file->is_reg =
-#ifdef _MSC_VER
-		!!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_NORMAL) ||
-		(
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_DEVICE) &&
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) &&
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_ENCRYPTED) &&
-#ifdef FILE_ATTRIBUTE_INTEGRITY_STREAM
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_INTEGRITY_STREAM) &&
-#endif
-#ifdef FILE_ATTRIBUTE_NO_SCRUB_DATA
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_NO_SCRUB_DATA) &&
-#endif
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_OFFLINE) &&
-			!(dir->_f.dwFileAttributes & FILE_ATTRIBUTE_TEMPORARY));
-#else
-		S_ISREG(file->_s.st_mode);
-#endif
-
-	return 0;
-}
-
-_TINYDIR_FUNC
-int tinydir_readfile_n(const tinydir_dir *dir, tinydir_file *file, size_t i)
-{
-	if (dir == NULL || file == NULL)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	if (i >= dir->n_files)
-	{
-		errno = ENOENT;
-		return -1;
-	}
-
-	memcpy(file, &dir->_files[i], sizeof(tinydir_file));
-	_tinydir_get_ext(file);
-
-	return 0;
-}
-
-_TINYDIR_FUNC
-int tinydir_open_subdir_n(tinydir_dir *dir, size_t i)
-{
-	_tinydir_char_t path[_TINYDIR_PATH_MAX];
-	if (dir == NULL)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	if (i >= dir->n_files || !dir->_files[i].is_dir)
-	{
-		errno = ENOENT;
-		return -1;
-	}
-
-	_tinydir_strcpy(path, dir->_files[i].path);
-	tinydir_close(dir);
-	if (tinydir_open_sorted(dir, path) == -1)
-	{
-		return -1;
-	}
-
-	return 0;
-}
-
-/* Open a single file given its path */
-_TINYDIR_FUNC
-int tinydir_file_open(tinydir_file *file, const _tinydir_char_t *path)
-{
-	tinydir_dir dir;
-	int result = 0;
-	int found = 0;
-	_tinydir_char_t dir_name_buf[_TINYDIR_PATH_MAX];
-	_tinydir_char_t file_name_buf[_TINYDIR_FILENAME_MAX];
-	_tinydir_char_t *dir_name;
-	_tinydir_char_t *base_name;
-#if (defined _MSC_VER || defined __MINGW32__)
-	_tinydir_char_t drive_buf[_TINYDIR_PATH_MAX];
-	_tinydir_char_t ext_buf[_TINYDIR_FILENAME_MAX];
-#endif
-
-	if (file == NULL || path == NULL || _tinydir_strlen(path) == 0)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	if (_tinydir_strlen(path) + _TINYDIR_PATH_EXTRA >= _TINYDIR_PATH_MAX)
-	{
-		errno = ENAMETOOLONG;
-		return -1;
-	}
-
-	/* Get the parent path */
-#if (defined _MSC_VER || defined __MINGW32__)
-#if ((defined _MSC_VER) && (_MSC_VER >= 1400))
-		_tsplitpath_s(
-			path,
-			drive_buf, _TINYDIR_DRIVE_MAX,
-			dir_name_buf, _TINYDIR_FILENAME_MAX,
-			file_name_buf, _TINYDIR_FILENAME_MAX,
-			ext_buf, _TINYDIR_FILENAME_MAX);
-#else
-		_tsplitpath(
-			path,
-			drive_buf,
-			dir_name_buf,
-			file_name_buf,
-			ext_buf);
-#endif
-
-/* _splitpath_s not work fine with only filename and widechar support */
-#ifdef _UNICODE
-		if (drive_buf[0] == L'\xFEFE')
-			drive_buf[0] = '\0';
-		if (dir_name_buf[0] == L'\xFEFE')
-			dir_name_buf[0] = '\0';
-#endif
-
-	if (errno)
-	{
-		errno = EINVAL;
-		return -1;
-	}
-	/* Emulate the behavior of dirname by returning "." for dir name if it's
-	empty */
-	if (drive_buf[0] == '\0' && dir_name_buf[0] == '\0')
-	{
-		_tinydir_strcpy(dir_name_buf, TINYDIR_STRING("."));
-	}
-	/* Concatenate the drive letter and dir name to form full dir name */
-	_tinydir_strcat(drive_buf, dir_name_buf);
-	dir_name = drive_buf;
-	/* Concatenate the file name and extension to form base name */
-	_tinydir_strcat(file_name_buf, ext_buf);
-	base_name = file_name_buf;
-#else
-	_tinydir_strcpy(dir_name_buf, path);
-	dir_name = dirname(dir_name_buf);
-	_tinydir_strcpy(file_name_buf, path);
-	base_name =basename(file_name_buf);
-#endif
-
-	/* Open the parent directory */
-	if (tinydir_open(&dir, dir_name) == -1)
-	{
-		return -1;
-	}
-
-	/* Read through the parent directory and look for the file */
-	while (dir.has_next)
-	{
-		if (tinydir_readfile(&dir, file) == -1)
-		{
-			result = -1;
-			goto bail;
-		}
-		if (_tinydir_strcmp(file->name, base_name) == 0)
-		{
-			/* File found */
-			found = 1;
-			break;
-		}
-		tinydir_next(&dir);
-	}
-	if (!found)
-	{
-		result = -1;
-		errno = ENOENT;
-	}
-
-bail:
-	tinydir_close(&dir);
-	return result;
-}
-
-_TINYDIR_FUNC
-void _tinydir_get_ext(tinydir_file *file)
-{
-	_tinydir_char_t *period = _tinydir_strrchr(file->name, TINYDIR_STRING('.'));
-	if (period == NULL)
-	{
-		file->extension = &(file->name[_tinydir_strlen(file->name)]);
-	}
-	else
-	{
-		file->extension = period + 1;
-	}
-}
-
-_TINYDIR_FUNC
-int _tinydir_file_cmp(const void *a, const void *b)
-{
-	const tinydir_file *fa = (const tinydir_file *)a;
-	const tinydir_file *fb = (const tinydir_file *)b;
-	if (fa->is_dir != fb->is_dir)
-	{
-		return -(fa->is_dir - fb->is_dir);
-	}
-	return _tinydir_strncmp(fa->name, fb->name, _TINYDIR_FILENAME_MAX);
-}
-
-#ifndef _MSC_VER
-#ifndef _TINYDIR_USE_READDIR
-/*
-The following authored by Ben Hutchings <ben@decadent.org.uk>
-from https://womble.decadent.org.uk/readdir_r-advisory.html
-*/
-/* Calculate the required buffer size (in bytes) for directory      *
-* entries read from the given directory handle.  Return -1 if this  *
-* this cannot be done.                                              *
-*                                                                   *
-* This code does not trust values of NAME_MAX that are less than    *
-* 255, since some systems (including at least HP-UX) incorrectly    *
-* define it to be a smaller value.                                  */
-_TINYDIR_FUNC
-size_t _tinydir_dirent_buf_size(_TINYDIR_DIR *dirp)
-{
-	long name_max;
-	size_t name_end;
-	/* parameter may be unused */
-	(void)dirp;
-
-#if defined _TINYDIR_USE_FPATHCONF
-	name_max = fpathconf(dirfd(dirp), _PC_NAME_MAX);
-	if (name_max == -1)
-#if defined(NAME_MAX)
-		name_max = (NAME_MAX > 255) ? NAME_MAX : 255;
-#else
-		return (size_t)(-1);
-#endif
-#elif defined(NAME_MAX)
- 	name_max = (NAME_MAX > 255) ? NAME_MAX : 255;
-#else
-#error "buffer size for readdir_r cannot be determined"
-#endif
-	name_end = (size_t)offsetof(struct _tinydir_dirent, d_name) + name_max + 1;
-	return (name_end > sizeof(struct _tinydir_dirent) ?
-		name_end : sizeof(struct _tinydir_dirent));
-}
-#endif
-#endif
-
-#ifdef __cplusplus
-}
-#endif
-
-# if defined (_MSC_VER)
-# pragma warning(pop)
-# endif
-
-#endif
--- a/src/apps/httpd/fs.c
+++ b/src/apps/httpd/fs.c
@@ -1,8 +1,8 @@
 /*
 * Copyright (c) 2001-2003 Swedish Institute of Computer Science.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
+ * All rights reserved. 
+ * 
+ * Redistribution and use in source and binary forms, with or without modification, 
 * are permitted provided that the following conditions are met:
 *
 * 1. Redistributions of source code must retain the above copyright notice,
@@ -11,21 +11,21 @@
 *    this list of conditions and the following disclaimer in the documentation
 *    and/or other materials provided with the distribution.
 * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
+ *    derived from this software without specific prior written permission. 
 *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT 
+ * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT 
+ * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING 
+ * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY 
 * OF SUCH DAMAGE.
 *
 * This file is part of the lwIP TCP/IP stack.
- *
+ * 
 * Author: Adam Dunkels <adam@sics.se>
 *
 */
@@ -33,10 +33,15 @@
 #include "lwip/apps/httpd_opts.h"
 #include "lwip/def.h"
 #include "lwip/apps/fs.h"
+#include "fsdata.h"
 #include <string.h>


-#include HTTPD_FSDATA_FILE
+#if HTTPD_USE_CUSTOM_FSDATA
+#include "fsdata_custom.c"
+#else /* HTTPD_USE_CUSTOM_FSDATA */
+#include "fsdata.c"
+#endif /* HTTPD_USE_CUSTOM_FSDATA */

 /*-----------------------------------------------------------------------------------*/

@@ -59,7 +64,7 @@ fs_open(struct fs_file *file, const char *name)
  const struct fsdata_file *f;

  if ((file == NULL) || (name == NULL)) {
-    return ERR_ARG;
+     return ERR_ARG;
  }

 #if LWIP_HTTPD_CUSTOM_FILES
@@ -116,7 +121,7 @@ fs_read(struct fs_file *file, char *buffer, int count)
 #endif /* LWIP_HTTPD_FS_ASYNC_READ */
 {
  int read;
-  if (file->index == file->len) {
+  if(file->index == file->len) {
    return FS_READ_EOF;
  }
 #if LWIP_HTTPD_FS_ASYNC_READ
@@ -134,14 +139,14 @@ fs_read(struct fs_file *file, char *buffer, int count)
 #endif /* LWIP_HTTPD_CUSTOM_FILES */

  read = file->len - file->index;
-  if (read > count) {
+  if(read > count) {
    read = count;
  }

  MEMCPY(buffer, (file->data + file->index), read);
  file->index += read;

-  return (read);
+  return(read);
 }
 #endif /* LWIP_HTTPD_DYNAMIC_FILE_READ */
 /*-----------------------------------------------------------------------------------*/
--- a/src/apps/httpd/fs/404.html
+++ b/src/apps/httpd/fs/404.html
--- a/src/apps/httpd/fs/img/sics.gif
+++ b/src/apps/httpd/fs/img/sics.gif
--- a/src/apps/httpd/fs/index.html
+++ b/src/apps/httpd/fs/index.html
--- a/src/apps/httpd/fsdata.c
+++ b/src/apps/httpd/fsdata.c
@@ -1,33 +1,13 @@
 #include "lwip/apps/fs.h"
 #include "lwip/def.h"
+#include "fsdata.h"


 #define file_NULL (struct fsdata_file *) NULL


-#ifndef FS_FILE_FLAGS_HEADER_INCLUDED
-#define FS_FILE_FLAGS_HEADER_INCLUDED 1
-#endif
-#ifndef FS_FILE_FLAGS_HEADER_PERSISTENT
-#define FS_FILE_FLAGS_HEADER_PERSISTENT 0
-#endif
-/* FSDATA_FILE_ALIGNMENT: 0=off, 1=by variable, 2=by include */
-#ifndef FSDATA_FILE_ALIGNMENT
-#define FSDATA_FILE_ALIGNMENT 0
-#endif
-#ifndef FSDATA_ALIGN_PRE
-#define FSDATA_ALIGN_PRE
-#endif
-#ifndef FSDATA_ALIGN_POST
-#define FSDATA_ALIGN_POST
-#endif
-#if FSDATA_FILE_ALIGNMENT==2
-#include "fsdata_alignment.h"
-#endif
-#if FSDATA_FILE_ALIGNMENT==1
 static const unsigned int dummy_align__img_sics_gif = 0;
-#endif
-static const unsigned char FSDATA_ALIGN_PRE data__img_sics_gif[] FSDATA_ALIGN_POST = {
+static const unsigned char data__img_sics_gif[] = {
 /* /img/sics.gif (14 chars) */
 0x2f,0x69,0x6d,0x67,0x2f,0x73,0x69,0x63,0x73,0x2e,0x67,0x69,0x66,0x00,0x00,0x00,

@@ -36,21 +16,16 @@ static const unsigned char FSDATA_ALIGN_PRE data__img_sics_gif[] FSDATA_ALIGN_PO
 " (17 bytes) */
 0x48,0x54,0x54,0x50,0x2f,0x31,0x2e,0x30,0x20,0x32,0x30,0x30,0x20,0x4f,0x4b,0x0d,
 0x0a,
-/* "Server: lwIP/2.0.3d (http://savannah.nongnu.org/projects/lwip)
-" (64 bytes) */
-0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x32,0x2e,0x30,
-0x2e,0x33,0x64,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,
-0x6e,0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,
-0x70,0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
-
-/* "Content-Length: 724
-" (18+ bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x4c,0x65,0x6e,0x67,0x74,0x68,0x3a,0x20,
-0x37,0x32,0x34,0x0d,0x0a,
-/* "Content-Type: image/gif
+/* "Server: lwIP/1.3.1 (http://savannah.nongnu.org/projects/lwip)
+" (63 bytes) */
+0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x31,0x2e,0x33,
+0x2e,0x31,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,0x6e,
+0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,0x70,
+0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
+/* "Content-type: image/gif

 " (27 bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x54,0x79,0x70,0x65,0x3a,0x20,0x69,0x6d,
+0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x74,0x79,0x70,0x65,0x3a,0x20,0x69,0x6d,
 0x61,0x67,0x65,0x2f,0x67,0x69,0x66,0x0d,0x0a,0x0d,0x0a,
 /* raw file data (724 bytes) */
 0x47,0x49,0x46,0x38,0x39,0x61,0x46,0x00,0x22,0x00,0xa5,0x00,0x00,0xd9,0x2b,0x39,
@@ -100,10 +75,8 @@ static const unsigned char FSDATA_ALIGN_PRE data__img_sics_gif[] FSDATA_ALIGN_PO
 0x82,0x0c,0x36,0xe8,0xe0,0x83,0x10,0x46,0x28,0xe1,0x84,0x14,0x56,0x68,0xa1,0x10,
 0x41,0x00,0x00,0x3b,};

-#if FSDATA_FILE_ALIGNMENT==1
 static const unsigned int dummy_align__404_html = 1;
-#endif
-static const unsigned char FSDATA_ALIGN_PRE data__404_html[] FSDATA_ALIGN_POST = {
+static const unsigned char data__404_html[] = {
 /* /404.html (10 chars) */
 0x2f,0x34,0x30,0x34,0x2e,0x68,0x74,0x6d,0x6c,0x00,0x00,0x00,

@@ -112,21 +85,16 @@ static const unsigned char FSDATA_ALIGN_PRE data__404_html[] FSDATA_ALIGN_POST =
 " (29 bytes) */
 0x48,0x54,0x54,0x50,0x2f,0x31,0x2e,0x30,0x20,0x34,0x30,0x34,0x20,0x46,0x69,0x6c,
 0x65,0x20,0x6e,0x6f,0x74,0x20,0x66,0x6f,0x75,0x6e,0x64,0x0d,0x0a,
-/* "Server: lwIP/2.0.3d (http://savannah.nongnu.org/projects/lwip)
-" (64 bytes) */
-0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x32,0x2e,0x30,
-0x2e,0x33,0x64,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,
-0x6e,0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,
-0x70,0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
-
-/* "Content-Length: 565
-" (18+ bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x4c,0x65,0x6e,0x67,0x74,0x68,0x3a,0x20,
-0x35,0x36,0x35,0x0d,0x0a,
-/* "Content-Type: text/html
+/* "Server: lwIP/1.3.1 (http://savannah.nongnu.org/projects/lwip)
+" (63 bytes) */
+0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x31,0x2e,0x33,
+0x2e,0x31,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,0x6e,
+0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,0x70,
+0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
+/* "Content-type: text/html

 " (27 bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x54,0x79,0x70,0x65,0x3a,0x20,0x74,0x65,
+0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x74,0x79,0x70,0x65,0x3a,0x20,0x74,0x65,
 0x78,0x74,0x2f,0x68,0x74,0x6d,0x6c,0x0d,0x0a,0x0d,0x0a,
 /* raw file data (565 bytes) */
 0x3c,0x68,0x74,0x6d,0x6c,0x3e,0x0d,0x0a,0x3c,0x68,0x65,0x61,0x64,0x3e,0x3c,0x74,
@@ -166,10 +134,8 @@ static const unsigned char FSDATA_ALIGN_PRE data__404_html[] FSDATA_ALIGN_POST =
 0x3e,0x0d,0x0a,0x3c,0x2f,0x62,0x6f,0x64,0x79,0x3e,0x0d,0x0a,0x3c,0x2f,0x68,0x74,
 0x6d,0x6c,0x3e,0x0d,0x0a,};

-#if FSDATA_FILE_ALIGNMENT==1
 static const unsigned int dummy_align__index_html = 2;
-#endif
-static const unsigned char FSDATA_ALIGN_PRE data__index_html[] FSDATA_ALIGN_POST = {
+static const unsigned char data__index_html[] = {
 /* /index.html (12 chars) */
 0x2f,0x69,0x6e,0x64,0x65,0x78,0x2e,0x68,0x74,0x6d,0x6c,0x00,

@@ -178,21 +144,16 @@ static const unsigned char FSDATA_ALIGN_PRE data__index_html[] FSDATA_ALIGN_POST
 " (17 bytes) */
 0x48,0x54,0x54,0x50,0x2f,0x31,0x2e,0x30,0x20,0x32,0x30,0x30,0x20,0x4f,0x4b,0x0d,
 0x0a,
-/* "Server: lwIP/2.0.3d (http://savannah.nongnu.org/projects/lwip)
-" (64 bytes) */
-0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x32,0x2e,0x30,
-0x2e,0x33,0x64,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,
-0x6e,0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,
-0x70,0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
-
-/* "Content-Length: 1751
-" (18+ bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x4c,0x65,0x6e,0x67,0x74,0x68,0x3a,0x20,
-0x31,0x37,0x35,0x31,0x0d,0x0a,
-/* "Content-Type: text/html
+/* "Server: lwIP/1.3.1 (http://savannah.nongnu.org/projects/lwip)
+" (63 bytes) */
+0x53,0x65,0x72,0x76,0x65,0x72,0x3a,0x20,0x6c,0x77,0x49,0x50,0x2f,0x31,0x2e,0x33,
+0x2e,0x31,0x20,0x28,0x68,0x74,0x74,0x70,0x3a,0x2f,0x2f,0x73,0x61,0x76,0x61,0x6e,
+0x6e,0x61,0x68,0x2e,0x6e,0x6f,0x6e,0x67,0x6e,0x75,0x2e,0x6f,0x72,0x67,0x2f,0x70,
+0x72,0x6f,0x6a,0x65,0x63,0x74,0x73,0x2f,0x6c,0x77,0x69,0x70,0x29,0x0d,0x0a,
+/* "Content-type: text/html

 " (27 bytes) */
-0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x54,0x79,0x70,0x65,0x3a,0x20,0x74,0x65,
+0x43,0x6f,0x6e,0x74,0x65,0x6e,0x74,0x2d,0x74,0x79,0x70,0x65,0x3a,0x20,0x74,0x65,
 0x78,0x74,0x2f,0x68,0x74,0x6d,0x6c,0x0d,0x0a,0x0d,0x0a,
 /* raw file data (1751 bytes) */
 0x3c,0x68,0x74,0x6d,0x6c,0x3e,0x0d,0x0a,0x3c,0x68,0x65,0x61,0x64,0x3e,0x3c,0x74,
@@ -313,7 +274,7 @@ file_NULL,
 data__img_sics_gif,
 data__img_sics_gif + 16,
 sizeof(data__img_sics_gif) - 16,
-FS_FILE_FLAGS_HEADER_INCLUDED | FS_FILE_FLAGS_HEADER_PERSISTENT,
+1,
 }};

 const struct fsdata_file file__404_html[] = { {
@@ -321,7 +282,7 @@ file__img_sics_gif,
 data__404_html,
 data__404_html + 12,
 sizeof(data__404_html) - 12,
-FS_FILE_FLAGS_HEADER_INCLUDED | FS_FILE_FLAGS_HEADER_PERSISTENT,
+1,
 }};

 const struct fsdata_file file__index_html[] = { {
@@ -329,7 +290,7 @@ file__404_html,
 data__index_html,
 data__index_html + 12,
 sizeof(data__index_html) - 12,
-FS_FILE_FLAGS_HEADER_INCLUDED | FS_FILE_FLAGS_HEADER_PERSISTENT,
+1,
 }};

 #define FS_ROOT file__index_html
--- a/src/apps/httpd/fsdata.h
+++ b/src/apps/httpd/fsdata.h
@@ -1,8 +1,8 @@
 /*
 * Copyright (c) 2001-2003 Swedish Institute of Computer Science.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
+ * All rights reserved. 
+ * 
+ * Redistribution and use in source and binary forms, with or without modification, 
 * are permitted provided that the following conditions are met:
 *
 * 1. Redistributions of source code must retain the above copyright notice,
@@ -11,21 +11,21 @@
 *    this list of conditions and the following disclaimer in the documentation
 *    and/or other materials provided with the distribution.
 * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
+ *    derived from this software without specific prior written permission. 
 *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT 
+ * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT 
+ * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING 
+ * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY 
 * OF SUCH DAMAGE.
 *
 * This file is part of the lwIP TCP/IP stack.
- *
+ * 
 * Author: Adam Dunkels <adam@sics.se>
 *
 */
@@ -35,7 +35,16 @@
 #include "lwip/apps/httpd_opts.h"
 #include "lwip/apps/fs.h"

-/* THIS FILE IS DEPRECATED AND WILL BE REMOVED IN THE FUTURE */
-/* content was moved to fs.h to simplify #include structure */
+struct fsdata_file {
+  const struct fsdata_file *next;
+  const unsigned char *name;
+  const unsigned char *data;
+  int len;
+  u8_t flags;
+#if HTTPD_PRECALCULATED_CHECKSUM
+  u16_t chksum_count;
+  const struct fsdata_chksum *chksum;
+#endif /* HTTPD_PRECALCULATED_CHECKSUM */
+};

 #endif /* LWIP_FSDATA_H */
--- a/src/apps/httpd/httpd.c
+++ b/src/apps/httpd/httpd.c
--- a/src/apps/httpd/httpd_structs.h
+++ b/src/apps/httpd/httpd_structs.h
@@ -0,0 +1,114 @@
+#ifndef LWIP_HTTPD_STRUCTS_H
+#define LWIP_HTTPD_STRUCTS_H
+
+#include "lwip/apps/httpd.h"
+
+#if LWIP_HTTPD_DYNAMIC_HEADERS
+/** This struct is used for a list of HTTP header strings for various
+ * filename extensions. */
+typedef struct
+{
+  const char *extension;
+  const char *content_type;
+} tHTTPHeader;
+
+/** A list of strings used in HTTP headers (see RFC 1945 HTTP/1.0 and
+ * RFC 2616 HTTP/1.1 for header field definitions) */
+static const char * const g_psHTTPHeaderStrings[] =
+{
+ "HTTP/1.0 200 OK\r\n",
+ "HTTP/1.0 404 File not found\r\n",
+ "HTTP/1.0 400 Bad Request\r\n",
+ "HTTP/1.0 501 Not Implemented\r\n",
+ "HTTP/1.1 200 OK\r\n",
+ "HTTP/1.1 404 File not found\r\n",
+ "HTTP/1.1 400 Bad Request\r\n",
+ "HTTP/1.1 501 Not Implemented\r\n",
+ "Content-Length: ",
+ "Connection: Close\r\n",
+ "Connection: keep-alive\r\n",
+ "Connection: keep-alive\r\nContent-Length: ",
+ "Server: "HTTPD_SERVER_AGENT"\r\n",
+ "\r\n<html><body><h2>404: The requested file cannot be found.</h2></body></html>\r\n"
+#if LWIP_HTTPD_SUPPORT_11_KEEPALIVE
+ ,"Connection: keep-alive\r\nContent-Length: 77\r\n\r\n<html><body><h2>404: The requested file cannot be found.</h2></body></html>\r\n"
+#endif
+};
+
+/* Indexes into the g_psHTTPHeaderStrings array */
+#define HTTP_HDR_OK             0 /* 200 OK */
+#define HTTP_HDR_NOT_FOUND      1 /* 404 File not found */
+#define HTTP_HDR_BAD_REQUEST    2 /* 400 Bad request */
+#define HTTP_HDR_NOT_IMPL       3 /* 501 Not Implemented */
+#define HTTP_HDR_OK_11          4 /* 200 OK */
+#define HTTP_HDR_NOT_FOUND_11   5 /* 404 File not found */
+#define HTTP_HDR_BAD_REQUEST_11 6 /* 400 Bad request */
+#define HTTP_HDR_NOT_IMPL_11    7 /* 501 Not Implemented */
+#define HTTP_HDR_CONTENT_LENGTH 8 /* Content-Length: (HTTP 1.0)*/
+#define HTTP_HDR_CONN_CLOSE     9 /* Connection: Close (HTTP 1.1) */
+#define HTTP_HDR_CONN_KEEPALIVE 10 /* Connection: keep-alive (HTTP 1.1) */
+#define HTTP_HDR_KEEPALIVE_LEN  11 /* Connection: keep-alive + Content-Length: (HTTP 1.1)*/
+#define HTTP_HDR_SERVER         12 /* Server: HTTPD_SERVER_AGENT */
+#define DEFAULT_404_HTML        13 /* default 404 body */
+#if LWIP_HTTPD_SUPPORT_11_KEEPALIVE
+#define DEFAULT_404_HTML_PERSISTENT 14 /* default 404 body, but including Connection: keep-alive */
+#endif
+
+
+#define HTTP_HDR_HTML           "Content-type: text/html\r\n\r\n"
+#define HTTP_HDR_SSI            "Content-type: text/html\r\nExpires: Fri, 10 Apr 2008 14:00:00 GMT\r\nPragma: no-cache\r\n\r\n"
+#define HTTP_HDR_GIF            "Content-type: image/gif\r\n\r\n"
+#define HTTP_HDR_PNG            "Content-type: image/png\r\n\r\n"
+#define HTTP_HDR_JPG            "Content-type: image/jpeg\r\n\r\n"
+#define HTTP_HDR_BMP            "Content-type: image/bmp\r\n\r\n"
+#define HTTP_HDR_ICO            "Content-type: image/x-icon\r\n\r\n"
+#define HTTP_HDR_APP            "Content-type: application/octet-stream\r\n\r\n"
+#define HTTP_HDR_JS             "Content-type: application/javascript\r\n\r\n"
+#define HTTP_HDR_RA             "Content-type: application/javascript\r\n\r\n"
+#define HTTP_HDR_CSS            "Content-type: text/css\r\n\r\n"
+#define HTTP_HDR_SWF            "Content-type: application/x-shockwave-flash\r\n\r\n"
+#define HTTP_HDR_XML            "Content-type: text/xml\r\n\r\n"
+#define HTTP_HDR_PDF            "Content-type: application/pdf\r\n\r\n"
+#define HTTP_HDR_JSON           "Content-type: application/json\r\n\r\n"
+
+#define HTTP_HDR_DEFAULT_TYPE   "Content-type: text/plain\r\n\r\n"
+
+/** A list of extension-to-HTTP header strings (see outdated RFC 1700 MEDIA TYPES
+ * and http://www.iana.org/assignments/media-types for registered content types
+ * and subtypes) */
+static const tHTTPHeader g_psHTTPHeaders[] =
+{
+ { "html", HTTP_HDR_HTML},
+ { "htm",  HTTP_HDR_HTML},
+ { "shtml",HTTP_HDR_SSI},
+ { "shtm", HTTP_HDR_SSI},
+ { "ssi",  HTTP_HDR_SSI},
+ { "gif",  HTTP_HDR_GIF},
+ { "png",  HTTP_HDR_PNG},
+ { "jpg",  HTTP_HDR_JPG},
+ { "bmp",  HTTP_HDR_BMP},
+ { "ico",  HTTP_HDR_ICO},
+ { "class",HTTP_HDR_APP},
+ { "cls",  HTTP_HDR_APP},
+ { "js",   HTTP_HDR_JS},
+ { "ram",  HTTP_HDR_RA},
+ { "css",  HTTP_HDR_CSS},
+ { "swf",  HTTP_HDR_SWF},
+ { "xml",  HTTP_HDR_XML},
+ { "xsl",  HTTP_HDR_XML},
+ { "pdf",  HTTP_HDR_PDF},
+ { "json", HTTP_HDR_JSON}
+};
+
+#define NUM_HTTP_HEADERS (sizeof(g_psHTTPHeaders) / sizeof(tHTTPHeader))
+
+#endif /* LWIP_HTTPD_DYNAMIC_HEADERS */
+
+#if LWIP_HTTPD_SSI
+static const char * const g_pcSSIExtensions[] = {
+  ".shtml", ".shtm", ".ssi", ".xml"
+};
+#define NUM_SHTML_EXTENSIONS (sizeof(g_pcSSIExtensions) / sizeof(const char *))
+#endif /* LWIP_HTTPD_SSI */
+
+#endif /* LWIP_HTTPD_STRUCTS_H */
--- a/src/apps/httpd/makefsdata/makefsdata
+++ b/src/apps/httpd/makefsdata/makefsdata
--- a/src/apps/httpd/makefsdata/makefsdata.c
+++ b/src/apps/httpd/makefsdata/makefsdata.c
--- a/src/apps/httpd/makefsdata/readme.txt
+++ b/src/apps/httpd/makefsdata/readme.txt
--- a/src/apps/lwiperf/lwiperf.c
+++ b/src/apps/lwiperf/lwiperf.c
@@ -7,15 +7,11 @@
 * @defgroup iperf Iperf server
 * @ingroup apps
 *
- * This is a simple performance measuring client/server to check your bandwith using
- * iPerf2 on a PC as server/client.
- * It is currently a minimal implementation providing a TCP client/server only.
+ * This is a simple performance measuring server to check your bandwith using
+ * iPerf2 on a PC as client.
+ * It is currently a minimal implementation providing an IPv4 TCP server only.
 *
- * @todo:
- * - implement UDP mode
- * - protect combined sessions handling (via 'related_master_state') against reallocation
- *   (this is a pointer address, currently, so if the same memory is allocated again,
- *    session pairs (tx/rx) can be confused on reallocation)
+ * @todo: implement UDP mode and IPv6
 */

 /*
@@ -56,8 +52,8 @@

 #include <string.h>

-/* Currently, only TCP is implemented */
-#if LWIP_TCP && LWIP_CALLBACK_API
+/* Currently, only TCP-over-IPv4 is implemented (does iperf support IPv6 anyway?) */
+#if LWIP_IPV4 && LWIP_TCP && LWIP_CALLBACK_API

 /** Specify the idle timeout (in seconds) after that the test fails */
 #ifndef LWIPERF_TCP_MAX_IDLE_SEC
@@ -67,11 +63,6 @@
 #error LWIPERF_TCP_MAX_IDLE_SEC must fit into an u8_t
 #endif

-/** Change this if you don't want to lwiperf to listen to any IP version */
-#ifndef LWIPERF_SERVER_IP_TYPE
-#define LWIPERF_SERVER_IP_TYPE      IPADDR_TYPE_ANY
-#endif
-
 /* File internal memory allocation (struct lwiperf_*): this defaults to
   the heap */
 #ifndef LWIPERF_ALLOC
@@ -100,108 +91,101 @@ typedef struct _lwiperf_settings {
 struct _lwiperf_state_base;
 typedef struct _lwiperf_state_base lwiperf_state_base_t;
 struct _lwiperf_state_base {
-  /* linked list */
-  lwiperf_state_base_t *next;
  /* 1=tcp, 0=udp */
  u8_t tcp;
  /* 1=server, 0=client */
  u8_t server;
-  /* master state used to abort sessions (e.g. listener, main client) */
-  lwiperf_state_base_t *related_master_state;
+  lwiperf_state_base_t* next;
+  lwiperf_state_base_t* related_server_state;
 };

 /** Connection handle for a TCP iperf session */
 typedef struct _lwiperf_state_tcp {
  lwiperf_state_base_t base;
-  struct tcp_pcb *server_pcb;
-  struct tcp_pcb *conn_pcb;
+  struct tcp_pcb* server_pcb;
+  struct tcp_pcb* conn_pcb;
  u32_t time_started;
  lwiperf_report_fn report_fn;
-  void *report_arg;
+  void* report_arg;
  u8_t poll_count;
  u8_t next_num;
-  /* 1=start server when client is closed */
-  u8_t client_tradeoff_mode;
  u32_t bytes_transferred;
  lwiperf_settings_t settings;
  u8_t have_settings_buf;
-  u8_t specific_remote;
-  ip_addr_t remote_addr;
 } lwiperf_state_tcp_t;

 /** List of active iperf sessions */
-static lwiperf_state_base_t *lwiperf_all_connections;
+static lwiperf_state_base_t* lwiperf_all_connections;
 /** A const buffer to send from: we want to measure sending, not copying! */
 static const u8_t lwiperf_txbuf_const[1600] = {
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-  '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
+  '0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9','0','1','2','3','4','5','6','7','8','9',
 };

 static err_t lwiperf_tcp_poll(void *arg, struct tcp_pcb *tpcb);
 static void lwiperf_tcp_err(void *arg, err_t err);
-static err_t lwiperf_start_tcp_server_impl(const ip_addr_t *local_addr, u16_t local_port,
-                                           lwiperf_report_fn report_fn, void *report_arg,
-                                           lwiperf_state_base_t *related_master_state, lwiperf_state_tcp_t **state);
-

 /** Add an iperf session to the 'active' list */
 static void
-lwiperf_list_add(lwiperf_state_base_t *item)
+lwiperf_list_add(lwiperf_state_base_t* item)
 {
-  item->next = lwiperf_all_connections;
-  lwiperf_all_connections = item;
+  if (lwiperf_all_connections == NULL) {
+    lwiperf_all_connections = item;
+  } else {
+    item = lwiperf_all_connections;
+  }
 }

 /** Remove an iperf session from the 'active' list */
 static void
-lwiperf_list_remove(lwiperf_state_base_t *item)
+lwiperf_list_remove(lwiperf_state_base_t* item)
 {
-  lwiperf_state_base_t *prev = NULL;
-  lwiperf_state_base_t *iter;
+  lwiperf_state_base_t* prev = NULL;
+  lwiperf_state_base_t* iter;
  for (iter = lwiperf_all_connections; iter != NULL; prev = iter, iter = iter->next) {
    if (iter == item) {
      if (prev == NULL) {
        lwiperf_all_connections = iter->next;
      } else {
-        prev->next = iter->next;
+        prev->next = item;
      }
      /* @debug: ensure this item is listed only once */
      for (iter = iter->next; iter != NULL; iter = iter->next) {
@@ -212,21 +196,9 @@ lwiperf_list_remove(lwiperf_state_base_t *item)
  }
 }

-static lwiperf_state_base_t *
-lwiperf_list_find(lwiperf_state_base_t *item)
-{
-  lwiperf_state_base_t *iter;
-  for (iter = lwiperf_all_connections; iter != NULL; iter = iter->next) {
-    if (iter == item) {
-      return item;
-    }
-  }
-  return NULL;
-}
-
 /** Call the report function of an iperf tcp session */
 static void
-lwip_tcp_conn_report(lwiperf_state_tcp_t *conn, enum lwiperf_report_type report_type)
+lwip_tcp_conn_report(lwiperf_state_tcp_t* conn, enum lwiperf_report_type report_type)
 {
  if ((conn != NULL) && (conn->report_fn != NULL)) {
    u32_t now, duration_ms, bandwidth_kbitpsec;
@@ -238,20 +210,20 @@ lwip_tcp_conn_report(lwiperf_state_tcp_t *conn, enum lwiperf_report_type report_
      bandwidth_kbitpsec = (conn->bytes_transferred / duration_ms) * 8U;
    }
    conn->report_fn(conn->report_arg, report_type,
-                    &conn->conn_pcb->local_ip, conn->conn_pcb->local_port,
-                    &conn->conn_pcb->remote_ip, conn->conn_pcb->remote_port,
-                    conn->bytes_transferred, duration_ms, bandwidth_kbitpsec);
+      &conn->conn_pcb->local_ip, conn->conn_pcb->local_port,
+      &conn->conn_pcb->remote_ip, conn->conn_pcb->remote_port,
+      conn->bytes_transferred, duration_ms, bandwidth_kbitpsec);
  }
 }

 /** Close an iperf tcp session */
 static void
-lwiperf_tcp_close(lwiperf_state_tcp_t *conn, enum lwiperf_report_type report_type)
+lwiperf_tcp_close(lwiperf_state_tcp_t* conn, enum lwiperf_report_type report_type)
 {
  err_t err;

-  lwiperf_list_remove(&conn->base);
  lwip_tcp_conn_report(conn, report_type);
+  lwiperf_list_remove(&conn->base);
  if (conn->conn_pcb != NULL) {
    tcp_arg(conn->conn_pcb, NULL);
    tcp_poll(conn->conn_pcb, NULL, 0);
@@ -264,22 +236,22 @@ lwiperf_tcp_close(lwiperf_state_tcp_t *conn, enum lwiperf_report_type report_typ
      tcp_abort(conn->conn_pcb);
    }
  } else {
-    /* no conn pcb, this is the listener pcb */
+    /* no conn pcb, this is the server pcb */
    err = tcp_close(conn->server_pcb);
-    LWIP_ASSERT("error", err == ERR_OK);
+    LWIP_ASSERT("error", err != ERR_OK);
  }
  LWIPERF_FREE(lwiperf_state_tcp_t, conn);
 }

 /** Try to send more data on an iperf tcp session */
 static err_t
-lwiperf_tcp_client_send_more(lwiperf_state_tcp_t *conn)
+lwiperf_tcp_client_send_more(lwiperf_state_tcp_t* conn)
 {
  int send_more;
  err_t err;
  u16_t txlen;
  u16_t txlen_max;
-  void *txptr;
+  void* txptr;
  u8_t apiflags;

  LWIP_ASSERT("conn invalid", (conn != NULL) && conn->base.tcp && (conn->base.server == 0));
@@ -290,7 +262,7 @@ lwiperf_tcp_client_send_more(lwiperf_state_tcp_t *conn)
      /* this session is time-limited */
      u32_t now = sys_now();
      u32_t diff_ms = now - conn->time_started;
-      u32_t time = (u32_t) - (s32_t)lwip_htonl(conn->settings.amount);
+      u32_t time = (u32_t)-(s32_t)lwip_htonl(conn->settings.amount);
      u32_t time_ms = time * 10;
      if (diff_ms >= time_ms) {
        /* time specified by the client is over -> close the connection */
@@ -310,19 +282,19 @@ lwiperf_tcp_client_send_more(lwiperf_state_tcp_t *conn)

    if (conn->bytes_transferred < 24) {
      /* transmit the settings a first time */
-      txptr = &((u8_t *)&conn->settings)[conn->bytes_transferred];
+      txptr = &((u8_t*)&conn->settings)[conn->bytes_transferred];
      txlen_max = (u16_t)(24 - conn->bytes_transferred);
      apiflags = TCP_WRITE_FLAG_COPY;
    } else if (conn->bytes_transferred < 48) {
      /* transmit the settings a second time */
-      txptr = &((u8_t *)&conn->settings)[conn->bytes_transferred - 24];
+      txptr = &((u8_t*)&conn->settings)[conn->bytes_transferred - 24];
      txlen_max = (u16_t)(48 - conn->bytes_transferred);
      apiflags = TCP_WRITE_FLAG_COPY | TCP_WRITE_FLAG_MORE;
      send_more = 1;
    } else {
      /* transmit data */
      /* @todo: every x bytes, transmit the settings again */
-      txptr = LWIP_CONST_CAST(void *, &lwiperf_txbuf_const[conn->bytes_transferred % 10]);
+      txptr = LWIP_CONST_CAST(void*, &lwiperf_txbuf_const[conn->bytes_transferred % 10]);
      txlen_max = TCP_MSS;
      if (conn->bytes_transferred == 48) { /* @todo: fix this for intermediate settings, too */
        txlen_max = TCP_MSS - 24;
@@ -336,14 +308,14 @@ lwiperf_tcp_client_send_more(lwiperf_state_tcp_t *conn)
      if (err ==  ERR_MEM) {
        txlen /= 2;
      }
-    } while ((err == ERR_MEM) && (txlen >= (TCP_MSS / 2)));
+    } while ((err == ERR_MEM) && (txlen >= (TCP_MSS/2)));

    if (err == ERR_OK) {
      conn->bytes_transferred += txlen;
    } else {
      send_more = 0;
    }
-  } while (send_more);
+  } while(send_more);

  tcp_output(conn->conn_pcb);
  return ERR_OK;
@@ -353,7 +325,7 @@ lwiperf_tcp_client_send_more(lwiperf_state_tcp_t *conn)
 static err_t
 lwiperf_tcp_client_sent(void *arg, struct tcp_pcb *tpcb, u16_t len)
 {
-  lwiperf_state_tcp_t *conn = (lwiperf_state_tcp_t *)arg;
+  lwiperf_state_tcp_t* conn = (lwiperf_state_tcp_t*)arg;
  /* @todo: check 'len' (e.g. to time ACK of all data)? for now, we just send more... */
  LWIP_ASSERT("invalid conn", conn->conn_pcb == tpcb);
  LWIP_UNUSED_ARG(tpcb);
@@ -368,7 +340,7 @@ lwiperf_tcp_client_sent(void *arg, struct tcp_pcb *tpcb, u16_t len)
 static err_t
 lwiperf_tcp_client_connected(void *arg, struct tcp_pcb *tpcb, err_t err)
 {
-  lwiperf_state_tcp_t *conn = (lwiperf_state_tcp_t *)arg;
+  lwiperf_state_tcp_t* conn = (lwiperf_state_tcp_t*)arg;
  LWIP_ASSERT("invalid conn", conn->conn_pcb == tpcb);
  LWIP_UNUSED_ARG(tpcb);
  if (err != ERR_OK) {
@@ -384,46 +356,41 @@ lwiperf_tcp_client_connected(void *arg, struct tcp_pcb *tpcb, err_t err)
 * receive test has finished.
 */
 static err_t
-lwiperf_tx_start_impl(const ip_addr_t *remote_ip, u16_t remote_port, lwiperf_settings_t *settings, lwiperf_report_fn report_fn,
-                      void *report_arg, lwiperf_state_base_t *related_master_state, lwiperf_state_tcp_t **new_conn)
+lwiperf_tx_start(lwiperf_state_tcp_t* conn)
 {
  err_t err;
-  lwiperf_state_tcp_t *client_conn;
-  struct tcp_pcb *newpcb;
+  lwiperf_state_tcp_t* client_conn;
+  struct tcp_pcb* newpcb;
  ip_addr_t remote_addr;
+  u16_t remote_port;

-  LWIP_ASSERT("remote_ip != NULL", remote_ip != NULL);
-  LWIP_ASSERT("remote_ip != NULL", settings != NULL);
-  LWIP_ASSERT("new_conn != NULL", new_conn != NULL);
-  *new_conn = NULL;
-
-  client_conn = (lwiperf_state_tcp_t *)LWIPERF_ALLOC(lwiperf_state_tcp_t);
+  client_conn = (lwiperf_state_tcp_t*)LWIPERF_ALLOC(lwiperf_state_tcp_t);
  if (client_conn == NULL) {
    return ERR_MEM;
  }
-  newpcb = tcp_new_ip_type(IP_GET_TYPE(remote_ip));
+  newpcb = tcp_new();
  if (newpcb == NULL) {
    LWIPERF_FREE(lwiperf_state_tcp_t, client_conn);
    return ERR_MEM;
  }
-  memset(client_conn, 0, sizeof(lwiperf_state_tcp_t));
-  client_conn->base.tcp = 1;
-  client_conn->base.related_master_state = related_master_state;
+
+  MEMCPY(client_conn, conn, sizeof(lwiperf_state_tcp_t));
+  client_conn->base.server = 0;
+  client_conn->server_pcb = NULL;
  client_conn->conn_pcb = newpcb;
  client_conn->time_started = sys_now(); /* @todo: set this again on 'connected' */
-  client_conn->report_fn = report_fn;
-  client_conn->report_arg = report_arg;
+  client_conn->poll_count = 0;
  client_conn->next_num = 4; /* initial nr is '4' since the header has 24 byte */
  client_conn->bytes_transferred = 0;
-  memcpy(&client_conn->settings, settings, sizeof(*settings));
-  client_conn->have_settings_buf = 1;
+  client_conn->settings.flags = 0; /* prevent the remote side starting back as client again */

  tcp_arg(newpcb, client_conn);
  tcp_sent(newpcb, lwiperf_tcp_client_sent);
  tcp_poll(newpcb, lwiperf_tcp_poll, 2U);
  tcp_err(newpcb, lwiperf_tcp_err);

-  ip_addr_copy(remote_addr, *remote_ip);
+  ip_addr_copy(remote_addr, conn->conn_pcb->remote_ip);
+  remote_port = (u16_t)lwip_htonl(client_conn->settings.remote_port);

  err = tcp_connect(newpcb, &remote_addr, remote_port, lwiperf_tcp_client_connected);
  if (err != ERR_OK) {
@@ -431,26 +398,9 @@ lwiperf_tx_start_impl(const ip_addr_t *remote_ip, u16_t remote_port, lwiperf_set
    return err;
  }
  lwiperf_list_add(&client_conn->base);
-  *new_conn = client_conn;
  return ERR_OK;
 }

-static err_t
-lwiperf_tx_start_passive(lwiperf_state_tcp_t *conn)
-{
-  err_t ret;
-  lwiperf_state_tcp_t *new_conn = NULL;
-  u16_t remote_port = (u16_t)lwip_htonl(conn->settings.remote_port);
-
-  ret = lwiperf_tx_start_impl(&conn->conn_pcb->remote_ip, remote_port, &conn->settings, conn->report_fn, conn->report_arg,
-    conn->base.related_master_state, &new_conn);
-  if (ret == ERR_OK) {
-    LWIP_ASSERT("new_conn != NULL", new_conn != NULL);
-    new_conn->settings.flags = 0; /* prevent the remote side starting back as client again */
-  }
-  return ret;
-}
-
 /** Receive data on an iperf tcp session */
 static err_t
 lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
@@ -458,8 +408,8 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
  u8_t tmp;
  u16_t tot_len;
  u32_t packet_idx;
-  struct pbuf *q;
-  lwiperf_state_tcp_t *conn = (lwiperf_state_tcp_t *)arg;
+  struct pbuf* q;
+  lwiperf_state_tcp_t* conn = (lwiperf_state_tcp_t*)arg;

  LWIP_ASSERT("pcb mismatch", conn->conn_pcb == tpcb);
  LWIP_UNUSED_ARG(tpcb);
@@ -470,11 +420,10 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
  }
  if (p == NULL) {
    /* connection closed -> test done */
-    if (conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST)) {
-      if ((conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_NOW)) == 0) {
-        /* client requested transmission after end of test */
-        lwiperf_tx_start_passive(conn);
-      }
+    if ((conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST|LWIPERF_FLAGS_ANSWER_NOW)) ==
+        PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST)) {
+      /* client requested transmission after end of test */
+      lwiperf_tx_start(conn);
    }
    lwiperf_tcp_close(conn, LWIPERF_TCP_DONE_SERVER);
    return ERR_OK;
@@ -483,38 +432,35 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)

  conn->poll_count = 0;

-  if ((!conn->have_settings_buf) || ((conn->bytes_transferred - 24) % (1024 * 128) == 0)) {
+  if ((!conn->have_settings_buf) || ((conn->bytes_transferred -24) % (1024*128) == 0)) {
    /* wait for 24-byte header */
    if (p->tot_len < sizeof(lwiperf_settings_t)) {
      lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL_DATAERROR);
      pbuf_free(p);
-      return ERR_OK;
+      return ERR_VAL;
    }
    if (!conn->have_settings_buf) {
      if (pbuf_copy_partial(p, &conn->settings, sizeof(lwiperf_settings_t), 0) != sizeof(lwiperf_settings_t)) {
        lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL);
        pbuf_free(p);
-        return ERR_OK;
+        return ERR_VAL;
      }
      conn->have_settings_buf = 1;
-      if (conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST)) {
-        if (conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_NOW)) {
+      if ((conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST|LWIPERF_FLAGS_ANSWER_NOW)) ==
+        PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST|LWIPERF_FLAGS_ANSWER_NOW)) {
          /* client requested parallel transmission test */
-          err_t err2 = lwiperf_tx_start_passive(conn);
+          err_t err2 = lwiperf_tx_start(conn);
          if (err2 != ERR_OK) {
            lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL_TXERROR);
            pbuf_free(p);
-            return ERR_OK;
+            return err2;
          }
-        }
      }
    } else {
-      if (conn->settings.flags & PP_HTONL(LWIPERF_FLAGS_ANSWER_TEST)) {
-        if (pbuf_memcmp(p, 0, &conn->settings, sizeof(lwiperf_settings_t)) != 0) {
-          lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL_DATAERROR);
-          pbuf_free(p);
-          return ERR_OK;
-        }
+      if (pbuf_memcmp(p, 0, &conn->settings, sizeof(lwiperf_settings_t)) != 0) {
+        lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL_DATAERROR);
+        pbuf_free(p);
+        return ERR_VAL;
      }
    }
    conn->bytes_transferred += sizeof(lwiperf_settings_t);
@@ -525,15 +471,14 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
      return ERR_OK;
    }
    conn->next_num = 4; /* 24 bytes received... */
-    tmp = pbuf_remove_header(p, 24);
-    LWIP_ASSERT("pbuf_remove_header failed", tmp == 0);
-    LWIP_UNUSED_ARG(tmp); /* for LWIP_NOASSERT */
+    tmp = pbuf_header(p, -24);
+    LWIP_ASSERT("pbuf_header failed", tmp == 0);
  }

  packet_idx = 0;
  for (q = p; q != NULL; q = q->next) {
 #if LWIPERF_CHECK_RX_DATA
-    const u8_t *payload = (const u8_t *)q->payload;
+    const u8_t* payload = (const u8_t*)q->payload;
    u16_t i;
    for (i = 0; i < q->len; i++) {
      u8_t val = payload[i];
@@ -546,7 +491,7 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
      } else {
        lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_LOCAL_DATAERROR);
        pbuf_free(p);
-        return ERR_OK;
+        return ERR_VAL;
      }
    }
 #endif
@@ -563,7 +508,7 @@ lwiperf_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
 static void
 lwiperf_tcp_err(void *arg, err_t err)
 {
-  lwiperf_state_tcp_t *conn = (lwiperf_state_tcp_t *)arg;
+  lwiperf_state_tcp_t* conn = (lwiperf_state_tcp_t*)arg;
  LWIP_UNUSED_ARG(err);
  lwiperf_tcp_close(conn, LWIPERF_TCP_ABORTED_REMOTE);
 }
@@ -572,7 +517,7 @@ lwiperf_tcp_err(void *arg, err_t err)
 static err_t
 lwiperf_tcp_poll(void *arg, struct tcp_pcb *tpcb)
 {
-  lwiperf_state_tcp_t *conn = (lwiperf_state_tcp_t *)arg;
+  lwiperf_state_tcp_t* conn = (lwiperf_state_tcp_t*)arg;
  LWIP_ASSERT("pcb mismatch", conn->conn_pcb == tpcb);
  LWIP_UNUSED_ARG(tpcb);
  if (++conn->poll_count >= LWIPERF_TCP_MAX_IDLE_SEC) {
@@ -596,28 +541,16 @@ lwiperf_tcp_accept(void *arg, struct tcp_pcb *newpcb, err_t err)
    return ERR_VAL;
  }

-  s = (lwiperf_state_tcp_t *)arg;
-  LWIP_ASSERT("invalid session", s->base.server);
-  LWIP_ASSERT("invalid listen pcb", s->server_pcb != NULL);
-  LWIP_ASSERT("invalid conn pcb", s->conn_pcb == NULL);
-  if (s->specific_remote) {
-    LWIP_ASSERT("s->base.related_master_state != NULL", s->base.related_master_state != NULL);
-    if (!ip_addr_cmp(&newpcb->remote_ip, &s->remote_addr)) {
-      /* this listener belongs to a client session, and this is not the correct remote */
-      return ERR_VAL;
-    }
-  } else {
-    LWIP_ASSERT("s->base.related_master_state == NULL", s->base.related_master_state == NULL);
-  }
-
-  conn = (lwiperf_state_tcp_t *)LWIPERF_ALLOC(lwiperf_state_tcp_t);
+  s = (lwiperf_state_tcp_t*)arg;
+  conn = (lwiperf_state_tcp_t*)LWIPERF_ALLOC(lwiperf_state_tcp_t);
  if (conn == NULL) {
    return ERR_MEM;
  }
  memset(conn, 0, sizeof(lwiperf_state_tcp_t));
  conn->base.tcp = 1;
  conn->base.server = 1;
-  conn->base.related_master_state = &s->base;
+  conn->base.related_server_state = &s->base;
+  conn->server_pcb = s->server_pcb;
  conn->conn_pcb = newpcb;
  conn->time_started = sys_now();
  conn->report_fn = s->report_fn;
@@ -629,21 +562,11 @@ lwiperf_tcp_accept(void *arg, struct tcp_pcb *newpcb, err_t err)
  tcp_poll(newpcb, lwiperf_tcp_poll, 2U);
  tcp_err(conn->conn_pcb, lwiperf_tcp_err);

-  if (s->specific_remote) {
-    /* this listener belongs to a client, so make the client the master of the newly created connection */
-    conn->base.related_master_state = s->base.related_master_state;
-    /* if dual mode or (tradeoff mode AND client is done): close the listener */
-    if (!s->client_tradeoff_mode || !lwiperf_list_find(s->base.related_master_state)) {
-      /* prevent report when closing: this is expected */
-      s->report_fn = NULL;
-      lwiperf_tcp_close(s, LWIPERF_TCP_ABORTED_LOCAL);
-    }
-  }
  lwiperf_list_add(&conn->base);
  return ERR_OK;
 }

-/**
+/** 
 * @ingroup iperf
 * Start a TCP iperf server on the default TCP port (5001) and listen for
 * incoming connections from iperf clients.
@@ -651,11 +574,11 @@ lwiperf_tcp_accept(void *arg, struct tcp_pcb *newpcb, err_t err)
 * @returns a connection handle that can be used to abort the server
 *          by calling @ref lwiperf_abort()
 */
-void *
-lwiperf_start_tcp_server_default(lwiperf_report_fn report_fn, void *report_arg)
+void*
+lwiperf_start_tcp_server_default(lwiperf_report_fn report_fn, void* report_arg)
 {
  return lwiperf_start_tcp_server(IP_ADDR_ANY, LWIPERF_TCP_PORT_DEFAULT,
-                                  report_fn, report_arg);
+    report_fn, report_arg);
 }

 /**
@@ -666,63 +589,41 @@ lwiperf_start_tcp_server_default(lwiperf_report_fn report_fn, void *report_arg)
 * @returns a connection handle that can be used to abort the server
 *          by calling @ref lwiperf_abort()
 */
-void *
-lwiperf_start_tcp_server(const ip_addr_t *local_addr, u16_t local_port,
-                         lwiperf_report_fn report_fn, void *report_arg)
+void*
+lwiperf_start_tcp_server(const ip_addr_t* local_addr, u16_t local_port,
+  lwiperf_report_fn report_fn, void* report_arg)
 {
  err_t err;
-  lwiperf_state_tcp_t *state = NULL;
-
-  err = lwiperf_start_tcp_server_impl(local_addr, local_port, report_fn, report_arg,
-    NULL, &state);
-  if (err == ERR_OK) {
-    return state;
-  }
-  return NULL;
-}
-
-static err_t lwiperf_start_tcp_server_impl(const ip_addr_t *local_addr, u16_t local_port,
-                                           lwiperf_report_fn report_fn, void *report_arg,
-                                           lwiperf_state_base_t *related_master_state, lwiperf_state_tcp_t **state)
-{
-  err_t err;
-  struct tcp_pcb *pcb;
-  lwiperf_state_tcp_t *s;
-
-  LWIP_ASSERT_CORE_LOCKED();
-
-  LWIP_ASSERT("state != NULL", state != NULL);
+  struct tcp_pcb* pcb;
+  lwiperf_state_tcp_t* s;

  if (local_addr == NULL) {
-    return ERR_ARG;
+    return NULL;
  }

-  s = (lwiperf_state_tcp_t *)LWIPERF_ALLOC(lwiperf_state_tcp_t);
+  s = (lwiperf_state_tcp_t*)LWIPERF_ALLOC(lwiperf_state_tcp_t);
  if (s == NULL) {
-    return ERR_MEM;
+    return NULL;
  }
  memset(s, 0, sizeof(lwiperf_state_tcp_t));
  s->base.tcp = 1;
  s->base.server = 1;
-  s->base.related_master_state = related_master_state;
  s->report_fn = report_fn;
  s->report_arg = report_arg;

-  pcb = tcp_new_ip_type(LWIPERF_SERVER_IP_TYPE);
-  if (pcb == NULL) {
-    return ERR_MEM;
+  pcb = tcp_new();
+  if (pcb != NULL) {
+    err = tcp_bind(pcb, local_addr, local_port);
+    if (err == ERR_OK) {
+      s->server_pcb = tcp_listen_with_backlog(pcb, 1);
+    }
  }
-  err = tcp_bind(pcb, local_addr, local_port);
-  if (err != ERR_OK) {
-    return err;
-  }
-  s->server_pcb = tcp_listen_with_backlog(pcb, 1);
  if (s->server_pcb == NULL) {
    if (pcb != NULL) {
      tcp_close(pcb);
    }
    LWIPERF_FREE(lwiperf_state_tcp_t, s);
-    return ERR_MEM;
+    return NULL;
  }
  pcb = NULL;

@@ -730,86 +631,7 @@ static err_t lwiperf_start_tcp_server_impl(const ip_addr_t *local_addr, u16_t lo
  tcp_accept(s->server_pcb, lwiperf_tcp_accept);

  lwiperf_list_add(&s->base);
-  *state = s;
-  return ERR_OK;
-}
-
-/**
- * @ingroup iperf
- * Start a TCP iperf client to the default TCP port (5001).
- *
- * @returns a connection handle that can be used to abort the client
- *          by calling @ref lwiperf_abort()
- */
-void* lwiperf_start_tcp_client_default(const ip_addr_t* remote_addr,
-                               lwiperf_report_fn report_fn, void* report_arg)
-{
-  return lwiperf_start_tcp_client(remote_addr, LWIPERF_TCP_PORT_DEFAULT, LWIPERF_CLIENT,
-                                  report_fn, report_arg);
-}
-
-/**
- * @ingroup iperf
- * Start a TCP iperf client to a specific IP address and port.
- *
- * @returns a connection handle that can be used to abort the client
- *          by calling @ref lwiperf_abort()
- */
-void* lwiperf_start_tcp_client(const ip_addr_t* remote_addr, u16_t remote_port,
-  enum lwiperf_client_type type, lwiperf_report_fn report_fn, void* report_arg)
-{
-  err_t ret;
-  lwiperf_settings_t settings;
-  lwiperf_state_tcp_t *state = NULL;
-
-  memset(&settings, 0, sizeof(settings));
-  switch (type) {
-  case LWIPERF_CLIENT:
-    /* Unidirectional tx only test */
-    settings.flags = 0;
-    break;
-  case LWIPERF_DUAL:
-    /* Do a bidirectional test simultaneously */
-    settings.flags = htonl(LWIPERF_FLAGS_ANSWER_TEST | LWIPERF_FLAGS_ANSWER_NOW);
-    break;
-  case LWIPERF_TRADEOFF:
-    /* Do a bidirectional test individually */
-    settings.flags = htonl(LWIPERF_FLAGS_ANSWER_TEST);
-    break;
-  default:
-    /* invalid argument */
-    return NULL;
-  }
-  settings.num_threads = htonl(1);
-  settings.remote_port = htonl(LWIPERF_TCP_PORT_DEFAULT);
-  /* TODO: implement passing duration/amount of bytes to transfer */
-  settings.amount = htonl((u32_t)-1000);
-
-  ret = lwiperf_tx_start_impl(remote_addr, remote_port, &settings, report_fn, report_arg, NULL, &state);
-  if (ret == ERR_OK) {
-    LWIP_ASSERT("state != NULL", state != NULL);
-    if (type != LWIPERF_CLIENT) {
-      /* start corresponding server now */
-      lwiperf_state_tcp_t *server = NULL;
-      ret = lwiperf_start_tcp_server_impl(&state->conn_pcb->local_ip, LWIPERF_TCP_PORT_DEFAULT,
-        report_fn, report_arg, (lwiperf_state_base_t *)state, &server);
-      if (ret != ERR_OK) {
-        /* starting server failed, abort client */
-        lwiperf_abort(state);
-        return NULL;
-      }
-      /* make this server accept one connection only */
-      server->specific_remote = 1;
-      server->remote_addr = state->conn_pcb->remote_ip;
-      if (type == LWIPERF_TRADEOFF) {
-        /* tradeoff means that the remote host connects only after the client is done,
-           so keep the listen pcb open until the client is done */
-        server->client_tradeoff_mode = 1;
-      }
-    }
-    return state;
-  }
-  return NULL;
+  return s;
 }

 /**
@@ -817,14 +639,12 @@ void* lwiperf_start_tcp_client(const ip_addr_t* remote_addr, u16_t remote_port,
 * Abort an iperf session (handle returned by lwiperf_start_tcp_server*())
 */
 void
-lwiperf_abort(void *lwiperf_session)
+lwiperf_abort(void* lwiperf_session)
 {
-  lwiperf_state_base_t *i, *dealloc, *last = NULL;
-
-  LWIP_ASSERT_CORE_LOCKED();
+  lwiperf_state_base_t* i, *dealloc, *last = NULL;

  for (i = lwiperf_all_connections; i != NULL; ) {
-    if ((i == lwiperf_session) || (i->related_master_state == lwiperf_session)) {
+    if ((i == lwiperf_session) || (i->related_server_state == lwiperf_session)) {
      dealloc = i;
      i = i->next;
      if (last != NULL) {
@@ -838,4 +658,4 @@ lwiperf_abort(void *lwiperf_session)
  }
 }

-#endif /* LWIP_TCP && LWIP_CALLBACK_API */
+#endif /* LWIP_IPV4 && LWIP_TCP && LWIP_CALLBACK_API */
--- a/src/apps/mdns/mdns.c
+++ b/src/apps/mdns/mdns.c
--- a/src/apps/mqtt/mqtt.c
+++ b/src/apps/mqtt/mqtt.c
@@ -48,15 +48,12 @@
 *
 */
 #include "lwip/apps/mqtt.h"
-#include "lwip/apps/mqtt_priv.h"
 #include "lwip/timeouts.h"
 #include "lwip/ip_addr.h"
 #include "lwip/mem.h"
 #include "lwip/err.h"
 #include "lwip/pbuf.h"
-#include "lwip/altcp.h"
-#include "lwip/altcp_tcp.h"
-#include "lwip/altcp_tls.h"
+#include "lwip/tcp.h"
 #include <string.h>

 #if LWIP_TCP && LWIP_CALLBACK_API
@@ -74,7 +71,7 @@
 #define MQTT_DEBUG_WARN_STATE   (MQTT_DEBUG | LWIP_DBG_LEVEL_WARNING | LWIP_DBG_STATE)
 #define MQTT_DEBUG_SERIOUS      (MQTT_DEBUG | LWIP_DBG_LEVEL_SERIOUS)

-
+static void mqtt_cyclic_timer(void *arg);

 /**
 * MQTT client connection states
@@ -122,10 +119,9 @@ enum mqtt_connect_flag {
 };


-static void mqtt_cyclic_timer(void *arg);
-
 #if defined(LWIP_DEBUG)
-static const char *const mqtt_message_type_str[15] = {
+static const char * const mqtt_message_type_str[15] =
+{
  "UNDEFINED",
  "CONNECT",
  "CONNACK",
@@ -146,7 +142,7 @@ static const char *const mqtt_message_type_str[15] = {
 /**
 * Message type value to string
 * @param msg_type see enum mqtt_message_type
- *
+ * 
 * @return Control message type text string
 */
 static const char *
@@ -179,51 +175,26 @@ msg_generate_packet_id(mqtt_client_t *client)
 /*--------------------------------------------------------------------------------------------------------------------- */
 /* Output ring buffer */

+
+#define MQTT_RINGBUF_IDX_MASK ((MQTT_OUTPUT_RINGBUF_SIZE) - 1)
+
 /** Add single item to ring buffer */
-static void
-mqtt_ringbuf_put(struct mqtt_ringbuf_t *rb, u8_t item)
-{
-  rb->buf[rb->put] = item;
-  rb->put++;
-  if (rb->put >= MQTT_OUTPUT_RINGBUF_SIZE) {
-    rb->put = 0;
-  }
-}
-
-/** Return pointer to ring buffer get position */
-static u8_t *
-mqtt_ringbuf_get_ptr(struct mqtt_ringbuf_t *rb)
-{
-  return &rb->buf[rb->get];
-}
-
-static void
-mqtt_ringbuf_advance_get_idx(struct mqtt_ringbuf_t *rb, u16_t len)
-{
-  LWIP_ASSERT("mqtt_ringbuf_advance_get_idx: len < MQTT_OUTPUT_RINGBUF_SIZE", len < MQTT_OUTPUT_RINGBUF_SIZE);
-
-  rb->get += len;
-  if (rb->get >= MQTT_OUTPUT_RINGBUF_SIZE) {
-    rb->get = rb->get - MQTT_OUTPUT_RINGBUF_SIZE;
-  }
-}
+#define mqtt_ringbuf_put(rb, item) ((rb)->buf)[(rb)->put++ & MQTT_RINGBUF_IDX_MASK] = (item)

 /** Return number of bytes in ring buffer */
-static u16_t
-mqtt_ringbuf_len(struct mqtt_ringbuf_t *rb)
-{
-  u32_t len = rb->put - rb->get;
-  if (len > 0xFFFF) {
-    len += MQTT_OUTPUT_RINGBUF_SIZE;
-  }
-  return (u16_t)len;
-}
+#define mqtt_ringbuf_len(rb) ((u16_t)((rb)->put - (rb)->get))

 /** Return number of bytes free in ring buffer */
 #define mqtt_ringbuf_free(rb) (MQTT_OUTPUT_RINGBUF_SIZE - mqtt_ringbuf_len(rb))

 /** Return number of bytes possible to read without wrapping around */
-#define mqtt_ringbuf_linear_read_length(rb) LWIP_MIN(mqtt_ringbuf_len(rb), (MQTT_OUTPUT_RINGBUF_SIZE - (rb)->get))
+#define mqtt_ringbuf_linear_read_length(rb) LWIP_MIN(mqtt_ringbuf_len(rb), (MQTT_OUTPUT_RINGBUF_SIZE - ((rb)->get & MQTT_RINGBUF_IDX_MASK)))
+
+/** Return pointer to ring buffer get position */
+#define mqtt_ringbuf_get_ptr(rb) (&(rb)->buf[(rb)->get & MQTT_RINGBUF_IDX_MASK])
+
+#define mqtt_ringbuf_advance_get_idx(rb, len) ((rb)->get += (len))
+

 /**
 * Try send as many bytes as possible from output ring buffer
@@ -231,20 +202,20 @@ mqtt_ringbuf_len(struct mqtt_ringbuf_t *rb)
 * @param tpcb TCP connection handle
 */
 static void
-mqtt_output_send(struct mqtt_ringbuf_t *rb, struct altcp_pcb *tpcb)
+mqtt_output_send(struct mqtt_ringbuf_t *rb, struct tcp_pcb *tpcb)
 {
  err_t err;
  u8_t wrap = 0;
  u16_t ringbuf_lin_len = mqtt_ringbuf_linear_read_length(rb);
-  u16_t send_len = altcp_sndbuf(tpcb);
+  u16_t send_len = tcp_sndbuf(tpcb);
  LWIP_ASSERT("mqtt_output_send: tpcb != NULL", tpcb != NULL);

  if (send_len == 0 || ringbuf_lin_len == 0) {
    return;
  }

-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_output_send: tcp_sndbuf: %d bytes, ringbuf_linear_available: %d, get %d, put %d\n",
-                                 send_len, ringbuf_lin_len, rb->get, rb->put));
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_output_send: tcp_sndbuf: %d bytes, ringbuf_linear_available: %d, get %d, put %d\n",
+                                send_len, ringbuf_lin_len, ((rb)->get & MQTT_RINGBUF_IDX_MASK), ((rb)->put & MQTT_RINGBUF_IDX_MASK)));

  if (send_len > ringbuf_lin_len) {
    /* Space in TCP output buffer is larger than available in ring buffer linear portion */
@@ -252,18 +223,18 @@ mqtt_output_send(struct mqtt_ringbuf_t *rb, struct altcp_pcb *tpcb)
    /* Wrap around if more data in ring buffer after linear portion */
    wrap = (mqtt_ringbuf_len(rb) > ringbuf_lin_len);
  }
-  err = altcp_write(tpcb, mqtt_ringbuf_get_ptr(rb), send_len, TCP_WRITE_FLAG_COPY | (wrap ? TCP_WRITE_FLAG_MORE : 0));
+  err = tcp_write(tpcb, mqtt_ringbuf_get_ptr(rb), send_len, TCP_WRITE_FLAG_COPY | (wrap ? TCP_WRITE_FLAG_MORE : 0));
  if ((err == ERR_OK) && wrap) {
    mqtt_ringbuf_advance_get_idx(rb, send_len);
    /* Use the lesser one of ring buffer linear length and TCP send buffer size */
-    send_len = LWIP_MIN(altcp_sndbuf(tpcb), mqtt_ringbuf_linear_read_length(rb));
-    err = altcp_write(tpcb, mqtt_ringbuf_get_ptr(rb), send_len, TCP_WRITE_FLAG_COPY);
+    send_len = LWIP_MIN(tcp_sndbuf(tpcb), mqtt_ringbuf_linear_read_length(rb));
+    err = tcp_write(tpcb, mqtt_ringbuf_get_ptr(rb), send_len, TCP_WRITE_FLAG_COPY);
  }

  if (err == ERR_OK) {
    mqtt_ringbuf_advance_get_idx(rb, send_len);
    /* Flush */
-    altcp_output(tpcb);
+    tcp_output(tpcb);
  } else {
    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_output_send: Send failed with err %d (\"%s\")\n", err, lwip_strerr(err)));
  }
@@ -277,19 +248,18 @@ mqtt_output_send(struct mqtt_ringbuf_t *rb, struct altcp_pcb *tpcb)
 /**
 * Create request item
 * @param r_objs Pointer to request objects
- * @param r_objs_len Number of array entries
 * @param pkt_id Packet identifier of request
 * @param cb Packet callback to call when requests lifetime ends
 * @param arg Parameter following callback
 * @return Request or NULL if failed to create
 */
 static struct mqtt_request_t *
-mqtt_create_request(struct mqtt_request_t *r_objs, size_t r_objs_len, u16_t pkt_id, mqtt_request_cb_t cb, void *arg)
+mqtt_create_request(struct mqtt_request_t *r_objs, u16_t pkt_id, mqtt_request_cb_t cb, void *arg)
 {
  struct mqtt_request_t *r = NULL;
  u8_t n;
  LWIP_ASSERT("mqtt_create_request: r_objs != NULL", r_objs != NULL);
-  for (n = 0; n < r_objs_len; n++) {
+  for (n = 0; n < MQTT_REQ_MAX_IN_FLIGHT; n++) {
    /* Item point to itself if not in use */
    if (r_objs[n].next == &r_objs[n]) {
      r = &r_objs[n];
@@ -369,7 +339,7 @@ mqtt_take_request(struct mqtt_request_t **tail, u16_t pkt_id)
  if (iter != NULL) {
    /* unchain */
    if (prev == NULL) {
-      *tail = iter->next;
+      *tail= iter->next;
    } else {
      prev->next = iter->next;
    }
@@ -390,9 +360,8 @@ mqtt_take_request(struct mqtt_request_t **tail, u16_t pkt_id)
 static void
 mqtt_request_time_elapsed(struct mqtt_request_t **tail, u8_t t)
 {
-  struct mqtt_request_t *r;
+  struct mqtt_request_t *r = *tail;
  LWIP_ASSERT("mqtt_request_time_elapsed: tail != NULL", tail != NULL);
-  r = *tail;
  while (t > 0 && r != NULL) {
    if (t >= r->timeout_diff) {
      t -= (u8_t)r->timeout_diff;
@@ -404,7 +373,7 @@ mqtt_request_time_elapsed(struct mqtt_request_t **tail, u8_t t)
      }
      mqtt_delete_request(r);
      /* Tail might be be modified in callback, so re-read it in every iteration */
-      r = *(struct mqtt_request_t *const volatile *)tail;
+      r = *(struct mqtt_request_t * const volatile *)tail;
    } else {
      r->timeout_diff -= t;
      t = 0;
@@ -430,14 +399,13 @@ mqtt_clear_requests(struct mqtt_request_t **tail)
 /**
 * Initialize all request items
 * @param r_objs Pointer to request objects
- * @param r_objs_len Number of array entries
 */
 static void
-mqtt_init_requests(struct mqtt_request_t *r_objs, size_t r_objs_len)
+mqtt_init_requests(struct mqtt_request_t *r_objs)
 {
  u8_t n;
  LWIP_ASSERT("mqtt_init_requests: r_objs != NULL", r_objs != NULL);
-  for (n = 0; n < r_objs_len; n++) {
+  for (n = 0; n < MQTT_REQ_MAX_IN_FLIGHT; n++) {
    /* Item pointing to itself indicates unused */
    r_objs[n].next = &r_objs[n];
  }
@@ -484,18 +452,18 @@ mqtt_output_append_string(struct mqtt_ringbuf_t *rb, const char *str, u16_t leng
 * Append fixed header
 * @param rb Output ring buffer
 * @param msg_type see enum mqtt_message_type
- * @param fdup MQTT DUP flag
- * @param fqos MQTT QoS field
- * @param fretain MQTT retain flag
+ * @param dup MQTT DUP flag
+ * @param qos MQTT QoS field
+ * @param retain MQTT retain flag
 * @param r_length Remaining length after fixed header
 */

 static void
-mqtt_output_append_fixed_header(struct mqtt_ringbuf_t *rb, u8_t msg_type, u8_t fdup,
-                                u8_t fqos, u8_t fretain, u16_t r_length)
+mqtt_output_append_fixed_header(struct mqtt_ringbuf_t *rb, u8_t msg_type, u8_t dup,
+                 u8_t qos, u8_t retain, u16_t r_length)
 {
  /* Start with control byte */
-  mqtt_output_append_u8(rb, (((msg_type & 0x0f) << 4) | ((fdup & 1) << 3) | ((fqos & 3) << 1) | (fretain & 1)));
+  mqtt_output_append_u8(rb, (((msg_type & 0x0f) << 4) | ((dup & 1) << 3) | ((qos & 3) << 1) | (retain & 1)));
  /* Encode remaining length field */
  do {
    mqtt_output_append_u8(rb, (r_length & 0x7f) | (r_length >= 128 ? 0x80 : 0));
@@ -518,7 +486,7 @@ mqtt_output_check_space(struct mqtt_ringbuf_t *rb, u16_t r_length)

  LWIP_ASSERT("mqtt_output_check_space: rb != NULL", rb != NULL);

-  /* Calculate number of required bytes to contain the remaining bytes field and add to total*/
+ /* Calculate number of required bytes to contain the remaining bytes field and add to total*/
  do {
    total_len++;
    r_length >>= 7;
@@ -541,13 +509,13 @@ mqtt_close(mqtt_client_t *client, mqtt_connection_status_t reason)
  /* Bring down TCP connection if not already done */
  if (client->conn != NULL) {
    err_t res;
-    altcp_recv(client->conn, NULL);
-    altcp_err(client->conn,  NULL);
-    altcp_sent(client->conn, NULL);
-    res = altcp_close(client->conn);
+    tcp_recv(client->conn, NULL);
+    tcp_err(client->conn,  NULL);
+    tcp_sent(client->conn, NULL);
+    res = tcp_close(client->conn);
    if (res != ERR_OK) {
-      altcp_abort(client->conn);
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_close: Close err=%s\n", lwip_strerr(res)));
+      tcp_abort(client->conn);
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_close: Close err=%s\n", lwip_strerr(res)));
    }
    client->conn = NULL;
  }
@@ -582,7 +550,7 @@ mqtt_cyclic_timer(void *arg)
  if (client->conn_state == MQTT_CONNECTING) {
    client->cyclic_tick++;
    if ((client->cyclic_tick * MQTT_CYCLIC_TIMER_INTERVAL) >= MQTT_CONNECT_TIMOUT) {
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_cyclic_timer: CONNECT attempt to server timed out\n"));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_cyclic_timer: CONNECT attempt to server timed out\n"));
      /* Disconnect TCP */
      mqtt_close(client, MQTT_CONNECT_TIMEOUT);
      restart_timer = 0;
@@ -596,15 +564,15 @@ mqtt_cyclic_timer(void *arg)

      client->server_watchdog++;
      /* If reception from server has been idle for 1.5*keep_alive time, server is considered unresponsive */
-      if ((client->server_watchdog * MQTT_CYCLIC_TIMER_INTERVAL) > (client->keep_alive + client->keep_alive / 2)) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_cyclic_timer: Server incoming keep-alive timeout\n"));
+      if ((client->server_watchdog * MQTT_CYCLIC_TIMER_INTERVAL) > (client->keep_alive + client->keep_alive/2)) {
+        LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_cyclic_timer: Server incoming keep-alive timeout\n"));
        mqtt_close(client, MQTT_CONNECT_TIMEOUT);
        restart_timer = 0;
      }

      /* If time for a keep alive message to be sent, transmission has been idle for keep_alive time */
      if ((client->cyclic_tick * MQTT_CYCLIC_TIMER_INTERVAL) >= client->keep_alive) {
-        LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_cyclic_timer: Sending keep-alive message to server\n"));
+        LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_cyclic_timer: Sending keep-alive message to server\n"));
        if (mqtt_output_check_space(&client->output, 0) != 0) {
          mqtt_output_append_fixed_header(&client->output, MQTT_MSG_TYPE_PINGREQ, 0, 0, 0, 0);
          client->cyclic_tick = 0;
@@ -614,11 +582,11 @@ mqtt_cyclic_timer(void *arg)
      }
    }
  } else {
-    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_cyclic_timer: Timer should not be running in state %d\n", client->conn_state));
+    LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_cyclic_timer: Timer should not be running in state %d\n", client->conn_state));
    restart_timer = 0;
  }
  if (restart_timer) {
-    sys_timeout(MQTT_CYCLIC_TIMER_INTERVAL * 1000, mqtt_cyclic_timer, arg);
+    sys_timeout(MQTT_CYCLIC_TIMER_INTERVAL*1000, mqtt_cyclic_timer, arg);
  }
 }

@@ -640,8 +608,8 @@ pub_ack_rec_rel_response(mqtt_client_t *client, u8_t msg, u16_t pkt_id, u8_t qos
    mqtt_output_append_u16(&client->output, pkt_id);
    mqtt_output_send(&client->output, client->conn);
  } else {
-    LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("pub_ack_rec_rel_response: OOM creating response: %s with pkt_id: %d\n",
-                                   mqtt_msg_type_to_str(msg), pkt_id));
+    LWIP_DEBUGF(MQTT_DEBUG_TRACE,("pub_ack_rec_rel_response: OOM creating response: %s with pkt_id: %d\n",
+                                  mqtt_msg_type_to_str(msg), pkt_id));
    err = ERR_MEM;
  }
  return err;
@@ -669,31 +637,21 @@ mqtt_incomming_suback(struct mqtt_request_t *r, u8_t result)
 * @param remaining_length Remaining length of complete message
 */
 static mqtt_connection_status_t
-mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u32_t remaining_length)
+  mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u32_t remaining_length)
 {
  mqtt_connection_status_t res = MQTT_CONNECT_ACCEPTED;

  u8_t *var_hdr_payload = client->rx_buffer + fixed_hdr_idx;
-  size_t var_hdr_payload_bufsize = sizeof(client->rx_buffer) - fixed_hdr_idx;

  /* Control packet type */
  u8_t pkt_type = MQTT_CTL_PACKET_TYPE(client->rx_buffer[0]);
  u16_t pkt_id = 0;

-  LWIP_ASSERT("client->msg_idx < MQTT_VAR_HEADER_BUFFER_LEN", client->msg_idx < MQTT_VAR_HEADER_BUFFER_LEN);
-  LWIP_ASSERT("fixed_hdr_idx <= client->msg_idx", fixed_hdr_idx <= client->msg_idx);
-  LWIP_ERROR("buffer length mismatch", fixed_hdr_idx + length <= MQTT_VAR_HEADER_BUFFER_LEN,
-             return MQTT_CONNECT_DISCONNECTED);
-
  if (pkt_type == MQTT_MSG_TYPE_CONNACK) {
    if (client->conn_state == MQTT_CONNECTING) {
-      if (length < 2) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received short CONNACK message\n"));
-        goto out_disconnect;
-      }
      /* Get result code from CONNACK */
      res = (mqtt_connection_status_t)var_hdr_payload[1];
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_message_received: Connect response code %d\n", res));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_message_received: Connect response code %d\n", res));
      if (res == MQTT_CONNECT_ACCEPTED) {
        /* Reset cyclic_tick when changing to connected state */
        client->cyclic_tick = 0;
@@ -704,10 +662,10 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u
        }
      }
    } else {
-      LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_message_received: Received CONNACK in connected state\n"));
+      LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_message_received: Received CONNACK in connected state\n"));
    }
  } else if (pkt_type == MQTT_MSG_TYPE_PINGRESP) {
-    LWIP_DEBUGF(MQTT_DEBUG_TRACE, ( "mqtt_message_received: Received PINGRESP from server\n"));
+    LWIP_DEBUGF(MQTT_DEBUG_TRACE,( "mqtt_message_received: Received PINGRESP from server\n"));

  } else if (pkt_type == MQTT_MSG_TYPE_PUBLISH) {
    u16_t payload_offset = 0;
@@ -716,37 +674,22 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u

    if (client->msg_idx <= MQTT_VAR_HEADER_BUFFER_LEN) {
      /* Should have topic and pkt id*/
-      u8_t *topic;
-      u16_t after_topic;
+      uint8_t *topic;
+      uint16_t after_topic;
      u8_t bkp;
-      u16_t topic_len;
-      u16_t qos_len = (qos ? 2U : 0U);
-      if (length < 2 + qos_len) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received short PUBLISH packet\n"));
-        goto out_disconnect;
-      }
-      topic_len = var_hdr_payload[0];
+      u16_t topic_len = var_hdr_payload[0];
      topic_len = (topic_len << 8) + (u16_t)(var_hdr_payload[1]);
-      if ((topic_len > length - (2 + qos_len)) ||
-          (topic_len > var_hdr_payload_bufsize - (2 + qos_len))) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received short PUBLISH packet (topic)\n"));
-        goto out_disconnect;
-      }

      topic = var_hdr_payload + 2;
      after_topic = 2 + topic_len;
-      /* Check buffer length, add one byte even for QoS 0 so that zero termination will fit */
-      if ((after_topic + (qos ? 2U : 1U)) > var_hdr_payload_bufsize) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_message_received: Receive buffer can not fit topic + pkt_id\n"));
+      /* Check length, add one byte even for QoS 0 so that zero termination will fit */
+      if ((after_topic + (qos? 2 : 1)) > length) {
+        LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_message_received: Receive buffer can not fit topic + pkt_id\n"));
        goto out_disconnect;
      }

      /* id for QoS 1 and 2 */
      if (qos > 0) {
-        if (length < after_topic + 2U) {
-          LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received short PUBLISH packet (after_topic)\n"));
-          goto out_disconnect;
-        }
        client->inpub_pkt_id = ((u16_t)var_hdr_payload[after_topic] << 8) + (u16_t)var_hdr_payload[after_topic + 1];
        after_topic += 2;
      } else {
@@ -760,8 +703,8 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u
      payload_length = length - after_topic;
      payload_offset = after_topic;

-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_incomming_publish: Received message with QoS %d at topic: %s, payload length %"U32_F"\n",
-                                     qos, topic, remaining_length + payload_length));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_incomming_publish: Received message with QoS %d at topic: %s, payload length %d\n",
+                                    qos, topic, remaining_length + payload_length));
      if (client->pub_cb != NULL) {
        client->pub_cb(client->inpub_arg, (const char *)topic, remaining_length + payload_length);
      }
@@ -769,17 +712,13 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u
      topic[topic_len] = bkp;
    }
    if (payload_length > 0 || remaining_length == 0) {
-      if (length < (size_t)(payload_offset + payload_length)) {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received short packet (payload)\n"));
-        goto out_disconnect;
-      }
      client->data_cb(client->inpub_arg, var_hdr_payload + payload_offset, payload_length, remaining_length == 0 ? MQTT_DATA_FLAG_LAST : 0);
      /* Reply if QoS > 0 */
      if (remaining_length == 0 && qos > 0) {
        /* Send PUBACK for QoS 1 or PUBREC for QoS 2 */
        u8_t resp_msg = (qos == 1) ? MQTT_MSG_TYPE_PUBACK : MQTT_MSG_TYPE_PUBREC;
-        LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_incomming_publish: Sending publish response: %s with pkt_id: %d\n",
-                                       mqtt_msg_type_to_str(resp_msg), client->inpub_pkt_id));
+        LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_incomming_publish: Sending publish response: %s with pkt_id: %d\n",
+                                      mqtt_msg_type_to_str(resp_msg), client->inpub_pkt_id));
        pub_ack_rec_rel_response(client, resp_msg, client->inpub_pkt_id, 0);
      }
    }
@@ -788,25 +727,25 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u
    pkt_id = (u16_t)var_hdr_payload[0] << 8;
    pkt_id |= (u16_t)var_hdr_payload[1];
    if (pkt_id == 0) {
-      LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_message_received: Got message with illegal packet identifier: 0\n"));
+      LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_message_received: Got message with illegal packet identifier: 0\n"));
      goto out_disconnect;
    }
    if (pkt_type == MQTT_MSG_TYPE_PUBREC) {
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_message_received: PUBREC, sending PUBREL with pkt_id: %d\n", pkt_id));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_message_received: PUBREC, sending PUBREL with pkt_id: %d\n",pkt_id));
      pub_ack_rec_rel_response(client, MQTT_MSG_TYPE_PUBREL, pkt_id, 1);

    } else if (pkt_type == MQTT_MSG_TYPE_PUBREL) {
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_message_received: PUBREL, sending PUBCOMP response with pkt_id: %d\n", pkt_id));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_message_received: PUBREL, sending PUBCOMP response with pkt_id: %d\n",pkt_id));
      pub_ack_rec_rel_response(client, MQTT_MSG_TYPE_PUBCOMP, pkt_id, 0);

    } else if (pkt_type == MQTT_MSG_TYPE_SUBACK || pkt_type == MQTT_MSG_TYPE_UNSUBACK ||
-               pkt_type == MQTT_MSG_TYPE_PUBCOMP || pkt_type == MQTT_MSG_TYPE_PUBACK) {
+              pkt_type == MQTT_MSG_TYPE_PUBCOMP || pkt_type == MQTT_MSG_TYPE_PUBACK) {
      struct mqtt_request_t *r = mqtt_take_request(&client->pend_req_queue, pkt_id);
      if (r != NULL) {
-        LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_message_received: %s response with id %d\n", mqtt_msg_type_to_str(pkt_type), pkt_id));
+        LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_message_received: %s response with id %d\n", mqtt_msg_type_to_str(pkt_type), pkt_id));
        if (pkt_type == MQTT_MSG_TYPE_SUBACK) {
          if (length < 3) {
-            LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_message_received: To small SUBACK packet\n"));
+            LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_message_received: To small SUBACK packet\n"));
            goto out_disconnect;
          } else {
            mqtt_incomming_suback(r, var_hdr_payload[2]);
@@ -816,10 +755,10 @@ mqtt_message_received(mqtt_client_t *client, u8_t fixed_hdr_idx, u16_t length, u
        }
        mqtt_delete_request(r);
      } else {
-        LWIP_DEBUGF(MQTT_DEBUG_WARN, ( "mqtt_message_received: Received %s reply, with wrong pkt_id: %d\n", mqtt_msg_type_to_str(pkt_type), pkt_id));
+        LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received %s reply, with wrong pkt_id: %d\n", mqtt_msg_type_to_str(pkt_type), pkt_id));
      }
    } else {
-      LWIP_DEBUGF(MQTT_DEBUG_WARN, ( "mqtt_message_received: Received unknown message type: %d\n", pkt_type));
+      LWIP_DEBUGF(MQTT_DEBUG_WARN,( "mqtt_message_received: Received unknown message type: %d\n", pkt_type));
      goto out_disconnect;
    }
  }
@@ -844,44 +783,32 @@ mqtt_parse_incoming(mqtt_client_t *client, struct pbuf *p)
  u8_t b = 0;

  while (p->tot_len > in_offset) {
-    /* We ALWAYS parse the header here first. Even if the header was not
-       included in this segment, we re-parse it here by buffering it in
-       client->rx_buffer. client->msg_idx keeps track of this. */
    if ((fixed_hdr_idx < 2) || ((b & 0x80) != 0)) {

      if (fixed_hdr_idx < client->msg_idx) {
-        /* parse header from old pbuf (buffered in client->rx_buffer) */
        b = client->rx_buffer[fixed_hdr_idx];
      } else {
-        /* parse header from this pbuf and save it in client->rx_buffer in case
-           it comes in segmented */
        b = pbuf_get_at(p, in_offset++);
        client->rx_buffer[client->msg_idx++] = b;
      }
      fixed_hdr_idx++;

      if (fixed_hdr_idx >= 2) {
-        /* fixed header contains at least 2 bytes but can contain more, depending on
-           'remaining length'. All bytes but the last of this have 0x80 set to
-           indicate more bytes are coming. */
        msg_rem_len |= (u32_t)(b & 0x7f) << ((fixed_hdr_idx - 2) * 7);
        if ((b & 0x80) == 0) {
-          /* fixed header is done */
-          LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_parse_incoming: Remaining length after fixed header: %"U32_F"\n", msg_rem_len));
+          LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_parse_incoming: Remaining length after fixed header: %d\n", msg_rem_len));
          if (msg_rem_len == 0) {
            /* Complete message with no extra headers of payload received */
            mqtt_message_received(client, fixed_hdr_idx, 0, 0);
            client->msg_idx = 0;
            fixed_hdr_idx = 0;
          } else {
-            /* Bytes remaining in message (changes remaining length if this is
-               not the first segment of this message) */
+            /* Bytes remaining in message */
            msg_rem_len = (msg_rem_len + fixed_hdr_idx) - client->msg_idx;
          }
        }
      }
    } else {
-      /* Fixed header has been parsed, parse variable header */
      u16_t cpy_len, cpy_start, buffer_space;

      cpy_start = (client->msg_idx - fixed_hdr_idx) % (MQTT_VAR_HEADER_BUFFER_LEN - fixed_hdr_idx) + fixed_hdr_idx;
@@ -894,15 +821,15 @@ mqtt_parse_incoming(mqtt_client_t *client, struct pbuf *p)
      if (cpy_len > buffer_space) {
        cpy_len = buffer_space;
      }
-      pbuf_copy_partial(p, client->rx_buffer + cpy_start, cpy_len, in_offset);
+      pbuf_copy_partial(p, client->rx_buffer+cpy_start, cpy_len, in_offset);

      /* Advance get and put indexes  */
      client->msg_idx += cpy_len;
      in_offset += cpy_len;
      msg_rem_len -= cpy_len;

-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_parse_incoming: msg_idx: %"U32_F", cpy_len: %"U16_F", remaining %"U32_F"\n", client->msg_idx, cpy_len, msg_rem_len));
-      if ((msg_rem_len == 0) || (cpy_len == buffer_space)) {
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_parse_incoming: msg_idx: %d, cpy_len: %d, remaining %d\n", client->msg_idx, cpy_len, msg_rem_len));
+      if (msg_rem_len == 0 || cpy_len == buffer_space) {
        /* Whole message received or buffer is full */
        mqtt_connection_status_t res = mqtt_message_received(client, fixed_hdr_idx, (cpy_start + cpy_len) - fixed_hdr_idx, msg_rem_len);
        if (res != MQTT_CONNECT_ACCEPTED) {
@@ -929,25 +856,25 @@ mqtt_parse_incoming(mqtt_client_t *client, struct pbuf *p)
 * @return ERR_OK or err passed into callback
 */
 static err_t
-mqtt_tcp_recv_cb(void *arg, struct altcp_pcb *pcb, struct pbuf *p, err_t err)
+mqtt_tcp_recv_cb(void *arg, struct tcp_pcb *pcb, struct pbuf *p, err_t err)
 {
  mqtt_client_t *client = (mqtt_client_t *)arg;
  LWIP_ASSERT("mqtt_tcp_recv_cb: client != NULL", client != NULL);
  LWIP_ASSERT("mqtt_tcp_recv_cb: client->conn == pcb", client->conn == pcb);

  if (p == NULL) {
-    LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_tcp_recv_cb: Recv pbuf=NULL, remote has closed connection\n"));
+    LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_tcp_recv_cb: Recv pbuf=NULL, remote has closed connection\n"));
    mqtt_close(client, MQTT_CONNECT_DISCONNECTED);
  } else {
    mqtt_connection_status_t res;
    if (err != ERR_OK) {
-      LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_tcp_recv_cb: Recv err=%d\n", err));
+      LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_tcp_recv_cb: Recv err=%d\n", err));
      pbuf_free(p);
      return err;
    }

    /* Tell remote that data has been received */
-    altcp_recved(pcb, p->tot_len);
+    tcp_recved(pcb, p->tot_len);
    res = mqtt_parse_incoming(client, p);
    pbuf_free(p);

@@ -973,7 +900,7 @@ mqtt_tcp_recv_cb(void *arg, struct altcp_pcb *pcb, struct pbuf *p, err_t err)
 * @return ERR_OK
 */
 static err_t
-mqtt_tcp_sent_cb(void *arg, struct altcp_pcb *tpcb, u16_t len)
+mqtt_tcp_sent_cb(void *arg, struct tcp_pcb *tpcb, u16_t len)
 {
  mqtt_client_t *client = (mqtt_client_t *)arg;

@@ -988,7 +915,7 @@ mqtt_tcp_sent_cb(void *arg, struct altcp_pcb *tpcb, u16_t len)
    client->server_watchdog = 0;
    /* QoS 0 publish has no response from server, so call its callbacks here */
    while ((r = mqtt_take_request(&client->pend_req_queue, 0)) != NULL) {
-      LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_tcp_sent_cb: Calling QoS 0 publish complete callback\n"));
+      LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_tcp_sent_cb: Calling QoS 0 publish complete callback\n"));
      if (r->cb != NULL) {
        r->cb(r->arg, ERR_OK);
      }
@@ -1010,7 +937,7 @@ mqtt_tcp_err_cb(void *arg, err_t err)
 {
  mqtt_client_t *client = (mqtt_client_t *)arg;
  LWIP_UNUSED_ARG(err); /* only used for debug output */
-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_tcp_err_cb: TCP error callback: error %d, arg: %p\n", err, arg));
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_tcp_err_cb: TCP error callback: error %d, arg: %p\n", err, arg));
  LWIP_ASSERT("mqtt_tcp_err_cb: client != NULL", client != NULL);
  /* Set conn to null before calling close as pcb is already deallocated*/
  client->conn = 0;
@@ -1024,7 +951,7 @@ mqtt_tcp_err_cb(void *arg, err_t err)
 * @return err ERR_OK
 */
 static err_t
-mqtt_tcp_poll_cb(void *arg, struct altcp_pcb *tpcb)
+mqtt_tcp_poll_cb(void *arg, struct tcp_pcb *tpcb)
 {
  mqtt_client_t *client = (mqtt_client_t *)arg;
  if (client->conn_state == MQTT_CONNECTED) {
@@ -1041,12 +968,12 @@ mqtt_tcp_poll_cb(void *arg, struct altcp_pcb *tpcb)
 * @return ERR_OK
 */
 static err_t
-mqtt_tcp_connect_cb(void *arg, struct altcp_pcb *tpcb, err_t err)
+mqtt_tcp_connect_cb(void *arg, struct tcp_pcb *tpcb, err_t err)
 {
-  mqtt_client_t *client = (mqtt_client_t *)arg;
+  mqtt_client_t* client = (mqtt_client_t *)arg;

  if (err != ERR_OK) {
-    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_tcp_connect_cb: TCP connect error %d\n", err));
+    LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_tcp_connect_cb: TCP connect error %d\n", err));
    return err;
  }

@@ -1054,16 +981,16 @@ mqtt_tcp_connect_cb(void *arg, struct altcp_pcb *tpcb, err_t err)
  client->msg_idx = 0;

  /* Setup TCP callbacks */
-  altcp_recv(tpcb, mqtt_tcp_recv_cb);
-  altcp_sent(tpcb, mqtt_tcp_sent_cb);
-  altcp_poll(tpcb, mqtt_tcp_poll_cb, 2);
+  tcp_recv(tpcb, mqtt_tcp_recv_cb);
+  tcp_sent(tpcb, mqtt_tcp_sent_cb);
+  tcp_poll(tpcb, mqtt_tcp_poll_cb, 2);

-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_tcp_connect_cb: TCP connection established to server\n"));
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_tcp_connect_cb: TCP connection established to server\n"));
  /* Enter MQTT connect state */
  client->conn_state = MQTT_CONNECTING;

  /* Start cyclic timer */
-  sys_timeout(MQTT_CYCLIC_TIMER_INTERVAL * 1000, mqtt_cyclic_timer, client);
+  sys_timeout(MQTT_CYCLIC_TIMER_INTERVAL*1000, mqtt_cyclic_timer, client);
  client->cyclic_tick = 0;

  /* Start transmission from output queue, connect message is the first one out*/
@@ -1084,7 +1011,7 @@ mqtt_tcp_connect_cb(void *arg, struct altcp_pcb *tpcb, err_t err)
 * @param client MQTT client
 * @param topic Publish topic string
 * @param payload Data to publish (NULL is allowed)
- * @param payload_length Length of payload (0 is allowed)
+ * @param payload_length: Length of payload (0 is allowed)
 * @param qos Quality of service, 0 1 or 2
 * @param retain MQTT retain flag
 * @param cb Callback to call when publish is complete or has timed out
@@ -1104,7 +1031,6 @@ mqtt_publish(mqtt_client_t *client, const char *topic, const void *payload, u16_
  u16_t topic_len;
  u16_t remaining_length;

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_publish: client != NULL", client);
  LWIP_ASSERT("mqtt_publish: topic != NULL", topic);
  LWIP_ERROR("mqtt_publish: TCP disconnected", (client->conn_state != TCP_DISCONNECTED), return ERR_CONN);
@@ -1113,21 +1039,21 @@ mqtt_publish(mqtt_client_t *client, const char *topic, const void *payload, u16_
  LWIP_ERROR("mqtt_publish: topic length overflow", (topic_strlen <= (0xFFFF - 2)), return ERR_ARG);
  topic_len = (u16_t)topic_strlen;
  total_len = 2 + topic_len + payload_length;
+  LWIP_ERROR("mqtt_publish: total length overflow", (total_len <= 0xFFFF), return ERR_ARG);
+  remaining_length = (u16_t)total_len;
+
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_publish: Publish with payload length %d to topic \"%s\"\n", payload_length, topic));

  if (qos > 0) {
-    total_len += 2;
+    remaining_length += 2;
    /* Generate pkt_id id for QoS1 and 2 */
    pkt_id = msg_generate_packet_id(client);
  } else {
    /* Use reserved value pkt_id 0 for QoS 0 in request handle */
    pkt_id = 0;
  }
-  LWIP_ERROR("mqtt_publish: total length overflow", (total_len <= 0xFFFF), return ERR_ARG);
-  remaining_length = (u16_t)total_len;

-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_publish: Publish with payload length %d to topic \"%s\"\n", payload_length, topic));
-
-  r = mqtt_create_request(client->req_list, LWIP_ARRAYSIZE(client->req_list), pkt_id, cb, arg);
+  r = mqtt_create_request(client->req_list, pkt_id, cb, arg);
  if (r == NULL) {
    return ERR_MEM;
  }
@@ -1179,7 +1105,6 @@ mqtt_sub_unsub(mqtt_client_t *client, const char *topic, u8_t qos, mqtt_request_
  u16_t pkt_id;
  struct mqtt_request_t *r;

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_sub_unsub: client != NULL", client);
  LWIP_ASSERT("mqtt_sub_unsub: topic != NULL", topic);

@@ -1193,12 +1118,12 @@ mqtt_sub_unsub(mqtt_client_t *client, const char *topic, u8_t qos, mqtt_request_

  LWIP_ASSERT("mqtt_sub_unsub: qos < 3", qos < 3);
  if (client->conn_state == TCP_DISCONNECTED) {
-    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_sub_unsub: Can not (un)subscribe in disconnected state\n"));
+    LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_sub_unsub: Can not (un)subscribe in disconnected state\n"));
    return ERR_CONN;
  }

  pkt_id = msg_generate_packet_id(client);
-  r = mqtt_create_request(client->req_list, LWIP_ARRAYSIZE(client->req_list), pkt_id, cb, arg);
+  r = mqtt_create_request(client->req_list, pkt_id, cb, arg);
  if (r == NULL) {
    return ERR_MEM;
  }
@@ -1208,7 +1133,7 @@ mqtt_sub_unsub(mqtt_client_t *client, const char *topic, u8_t qos, mqtt_request_
    return ERR_MEM;
  }

-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_sub_unsub: Client (un)subscribe to topic \"%s\", id: %d\n", topic, pkt_id));
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_sub_unsub: Client (un)subscribe to topic \"%s\", id: %d\n", topic, pkt_id));

  mqtt_output_append_fixed_header(&client->output, sub ? MQTT_MSG_TYPE_SUBSCRIBE : MQTT_MSG_TYPE_UNSUBSCRIBE, 0, 1, 0, remaining_length);
  /* Packet id */
@@ -1236,9 +1161,8 @@ mqtt_sub_unsub(mqtt_client_t *client, const char *topic, u8_t qos, mqtt_request_
 */
 void
 mqtt_set_inpub_callback(mqtt_client_t *client, mqtt_incoming_publish_cb_t pub_cb,
-                        mqtt_incoming_data_cb_t data_cb, void *arg)
+                             mqtt_incoming_data_cb_t data_cb, void *arg)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_set_inpub_callback: client != NULL", client != NULL);
  client->data_cb = data_cb;
  client->pub_cb = pub_cb;
@@ -1253,20 +1177,13 @@ mqtt_set_inpub_callback(mqtt_client_t *client, mqtt_incoming_publish_cb_t pub_cb
 mqtt_client_t *
 mqtt_client_new(void)
 {
-  LWIP_ASSERT_CORE_LOCKED();
-  return (mqtt_client_t *)mem_calloc(1, sizeof(mqtt_client_t));
+  mqtt_client_t *client = (mqtt_client_t *)mem_malloc(sizeof(mqtt_client_t));
+  if (client != NULL) {
+    memset(client, 0, sizeof(mqtt_client_t));
+  }
+  return client;
 }

-/**
- * @ingroup mqtt
- * Free MQTT client instance
- * @param client Pointer to instance to be freed
- */
-void
-mqtt_client_free(mqtt_client_t *client)
-{
-  mem_free(client);
-}

 /**
 * @ingroup mqtt
@@ -1289,16 +1206,14 @@ mqtt_client_connect(mqtt_client_t *client, const ip_addr_t *ip_addr, u16_t port,
  /* Length is the sum of 2+"MQTT", protocol level, flags and keep alive */
  u16_t remaining_length = 2 + 4 + 1 + 1 + 2;
  u8_t flags = 0, will_topic_len = 0, will_msg_len = 0;
-  u16_t client_user_len = 0, client_pass_len = 0;

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_client_connect: client != NULL", client != NULL);
  LWIP_ASSERT("mqtt_client_connect: ip_addr != NULL", ip_addr != NULL);
  LWIP_ASSERT("mqtt_client_connect: client_info != NULL", client_info != NULL);
  LWIP_ASSERT("mqtt_client_connect: client_info->client_id != NULL", client_info->client_id != NULL);

  if (client->conn_state != TCP_DISCONNECTED) {
-    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_client_connect: Already connected\n"));
+    LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_client_connect: Already connected\n"));
    return ERR_ISCONN;
  }

@@ -1307,7 +1222,7 @@ mqtt_client_connect(mqtt_client_t *client, const ip_addr_t *ip_addr, u16_t port,
  client->connect_arg = arg;
  client->connect_cb = cb;
  client->keep_alive = client_info->keep_alive;
-  mqtt_init_requests(client->req_list, LWIP_ARRAYSIZE(client->req_list));
+  mqtt_init_requests(client->req_list);

  /* Build connect message */
  if (client_info->will_topic != NULL && client_info->will_msg != NULL) {
@@ -1327,26 +1242,6 @@ mqtt_client_connect(mqtt_client_t *client, const ip_addr_t *ip_addr, u16_t port,
    LWIP_ERROR("mqtt_client_connect: remaining_length overflow", len <= 0xFFFF, return ERR_VAL);
    remaining_length = (u16_t)len;
  }
-  if (client_info->client_user != NULL) {
-    flags |= MQTT_CONNECT_FLAG_USERNAME;
-    len = strlen(client_info->client_user);
-    LWIP_ERROR("mqtt_client_connect: client_info->client_user length overflow", len <= 0xFFFF, return ERR_VAL);
-    LWIP_ERROR("mqtt_client_connect: client_info->client_user length must be > 0", len > 0, return ERR_VAL);
-    client_user_len = (u16_t)len;
-    len = remaining_length + 2 + client_user_len;
-    LWIP_ERROR("mqtt_client_connect: remaining_length overflow", len <= 0xFFFF, return ERR_VAL);
-    remaining_length = (u16_t)len;
-  }
-  if (client_info->client_pass != NULL) {
-    flags |= MQTT_CONNECT_FLAG_PASSWORD;
-    len = strlen(client_info->client_pass);
-    LWIP_ERROR("mqtt_client_connect: client_info->client_pass length overflow", len <= 0xFFFF, return ERR_VAL);
-    LWIP_ERROR("mqtt_client_connect: client_info->client_pass length must be > 0", len > 0, return ERR_VAL);
-    client_pass_len = (u16_t)len;
-    len = remaining_length + 2 + client_pass_len;
-    LWIP_ERROR("mqtt_client_connect: remaining_length overflow", len <= 0xFFFF, return ERR_VAL);
-    remaining_length = (u16_t)len;
-  }

  /* Don't complicate things, always connect using clean session */
  flags |= MQTT_CONNECT_FLAG_CLEAN_SESSION;
@@ -1362,36 +1257,29 @@ mqtt_client_connect(mqtt_client_t *client, const ip_addr_t *ip_addr, u16_t port,
    return ERR_MEM;
  }

-#if LWIP_ALTCP && LWIP_ALTCP_TLS
-  if (client_info->tls_config) {
-    client->conn = altcp_tls_new(client_info->tls_config, IP_GET_TYPE(ip_addr));
-  } else
-#endif
-  {
-    client->conn = altcp_tcp_new_ip_type(IP_GET_TYPE(ip_addr));
-  }
+  client->conn = tcp_new();
  if (client->conn == NULL) {
    return ERR_MEM;
  }

  /* Set arg pointer for callbacks */
-  altcp_arg(client->conn, client);
+  tcp_arg(client->conn, client);
  /* Any local address, pick random local port number */
-  err = altcp_bind(client->conn, IP_ADDR_ANY, 0);
+  err = tcp_bind(client->conn, IP_ADDR_ANY, 0);
  if (err != ERR_OK) {
-    LWIP_DEBUGF(MQTT_DEBUG_WARN, ("mqtt_client_connect: Error binding to local ip/port, %d\n", err));
+    LWIP_DEBUGF(MQTT_DEBUG_WARN,("mqtt_client_connect: Error binding to local ip/port, %d\n", err));
    goto tcp_fail;
  }
-  LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_client_connect: Connecting to host: %s at port:%"U16_F"\n", ipaddr_ntoa(ip_addr), port));
+  LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_client_connect: Connecting to host: %s at port:%"U16_F"\n", ipaddr_ntoa(ip_addr), port));

  /* Connect to server */
-  err = altcp_connect(client->conn, ip_addr, port, mqtt_tcp_connect_cb);
+  err = tcp_connect(client->conn, ip_addr, port, mqtt_tcp_connect_cb);
  if (err != ERR_OK) {
-    LWIP_DEBUGF(MQTT_DEBUG_TRACE, ("mqtt_client_connect: Error connecting to remote ip/port, %d\n", err));
+    LWIP_DEBUGF(MQTT_DEBUG_TRACE,("mqtt_client_connect: Error connecting to remote ip/port, %d\n", err));
    goto tcp_fail;
  }
  /* Set error callback */
-  altcp_err(client->conn, mqtt_tcp_err_cb);
+  tcp_err(client->conn, mqtt_tcp_err_cb);
  client->conn_state = TCP_CONNECTING;

  /* Append fixed header */
@@ -1411,18 +1299,10 @@ mqtt_client_connect(mqtt_client_t *client, const ip_addr_t *ip_addr, u16_t port,
    mqtt_output_append_string(&client->output, client_info->will_topic, will_topic_len);
    mqtt_output_append_string(&client->output, client_info->will_msg, will_msg_len);
  }
-  /* Append user name if given */
-  if ((flags & MQTT_CONNECT_FLAG_USERNAME) != 0) {
-    mqtt_output_append_string(&client->output, client_info->client_user, client_user_len);
-  }
-  /* Append password if given */
-  if ((flags & MQTT_CONNECT_FLAG_PASSWORD) != 0) {
-    mqtt_output_append_string(&client->output, client_info->client_pass, client_pass_len);
-  }
  return ERR_OK;

 tcp_fail:
-  altcp_abort(client->conn);
+  tcp_abort(client->conn);
  client->conn = NULL;
  return err;
 }
@@ -1436,7 +1316,6 @@ tcp_fail:
 void
 mqtt_disconnect(mqtt_client_t *client)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_disconnect: client != NULL", client);
  /* If connection in not already closed */
  if (client->conn_state != TCP_DISCONNECTED) {
@@ -1455,7 +1334,6 @@ mqtt_disconnect(mqtt_client_t *client)
 u8_t
 mqtt_client_is_connected(mqtt_client_t *client)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mqtt_client_is_connected: client != NULL", client);
  return client->conn_state == MQTT_CONNECTED;
 }
--- a/src/apps/netbiosns/netbiosns.c
+++ b/src/apps/netbiosns/netbiosns.c
@@ -1,4 +1,4 @@
-  /**
+/**
 * @file
 * NetBIOS name service responder
 */
@@ -40,10 +40,6 @@
 *
 * This file is part of the lwIP TCP/IP stack.
 *
- * Modifications by Ray Abram to respond to NetBIOS name requests when Incoming name = *
- * - based on code from "https://github.com/esp8266/Arduino/commit/1f7989b31d26d7df9776a08f36d685eae7ac8f99"
- * - with permission to relicense to BSD from original author:
- *   http://www.xpablo.cz/?p=751#more-751
 */

 #include "lwip/apps/netbiosns.h"
@@ -52,12 +48,13 @@

 #include "lwip/def.h"
 #include "lwip/udp.h"
-#include "lwip/ip.h"
 #include "lwip/netif.h"
-#include "lwip/prot/iana.h"

 #include <string.h>

+/** default port number for "NetBIOS Name service */
+#define NETBIOS_PORT     137
+
 /** size of a NetBIOS name */
 #define NETBIOS_NAME_LEN 16

@@ -77,10 +74,6 @@
 #define NETB_HFLAG_REPLYCODE          0x0008U
 #define NETB_HFLAG_REPLYCODE_NOERROR  0x0000U

-/* NetBIOS question types */
-#define NETB_QTYPE_NB                 0x0020U
-#define NETB_QTYPE_NBSTAT             0x0021U
-
 /** NetBIOS name flags */
 #define NETB_NFLAG_UNIQUE             0x8000U
 #define NETB_NFLAG_NODETYPE           0x6000U
@@ -89,10 +82,6 @@
 #define NETB_NFLAG_NODETYPE_PNODE     0x2000U
 #define NETB_NFLAG_NODETYPE_BNODE     0x0000U

-#define NETB_NFLAG_NAME_IN_CONFLICT   0x0800U /* 1=Yes, 0=No */
-#define NETB_NFLAG_NAME_IS_ACTIVE     0x0400U /* 1=Yes, 0=No */
-#define NETB_NFLAG_NAME_IS_PERMANENT  0x0200U /* 1=Yes (Name is Permanent Node Name), 0=No */
-
 /** NetBIOS message header */
 #ifdef PACK_STRUCT_USE_INCLUDES
 #  include "arch/bpstruct.h"
@@ -118,7 +107,7 @@ PACK_STRUCT_END
 PACK_STRUCT_BEGIN
 struct netbios_name_hdr {
  PACK_STRUCT_FLD_8(u8_t  nametype);
-  PACK_STRUCT_FLD_8(u8_t  encname[(NETBIOS_NAME_LEN * 2) + 1]);
+  PACK_STRUCT_FLD_8(u8_t  encname[(NETBIOS_NAME_LEN*2)+1]);
  PACK_STRUCT_FIELD(u16_t type);
  PACK_STRUCT_FIELD(u16_t cls);
  PACK_STRUCT_FIELD(u32_t ttl);
@@ -136,7 +125,8 @@ PACK_STRUCT_END
 #  include "arch/bpstruct.h"
 #endif
 PACK_STRUCT_BEGIN
-struct netbios_resp {
+struct netbios_resp
+{
  struct netbios_hdr      resp_hdr;
  struct netbios_name_hdr resp_name;
 } PACK_STRUCT_STRUCT;
@@ -145,74 +135,6 @@ PACK_STRUCT_END
 #  include "arch/epstruct.h"
 #endif

-/** The NBNS Structure Responds to a Name Query */
-#ifdef PACK_STRUCT_USE_INCLUDES
-#  include "arch/bpstruct.h"
-#endif
-PACK_STRUCT_BEGIN
-struct netbios_answer {
-  struct netbios_hdr      answer_hdr;
-  /** the length of the next string */
-  PACK_STRUCT_FIELD(u8_t  name_size);
-  /** WARNING!!! this item may be of a different length (we use this struct for transmission) */
-  PACK_STRUCT_FLD_8(u8_t  query_name[(NETBIOS_NAME_LEN * 2) + 1]);
-  PACK_STRUCT_FIELD(u16_t packet_type);
-  PACK_STRUCT_FIELD(u16_t cls);
-  PACK_STRUCT_FIELD(u32_t ttl);
-  PACK_STRUCT_FIELD(u16_t data_length);
-#define OFFSETOF_STRUCT_NETBIOS_ANSWER_NUMBER_OF_NAMES 56
-  /** number of names */
-  PACK_STRUCT_FLD_8(u8_t  number_of_names);
-  /** node name */
-  PACK_STRUCT_FLD_8(u8_t  answer_name[NETBIOS_NAME_LEN]);
-  /** node flags */
-  PACK_STRUCT_FIELD(u16_t answer_name_flags);
-  /** Unit ID */
-  PACK_STRUCT_FLD_8(u8_t  unit_id[6]);
-  /** Jumpers */
-  PACK_STRUCT_FLD_8(u8_t  jumpers);
-  /** Test result */
-  PACK_STRUCT_FLD_8(u8_t  test_result);
-  /** Version number */
-  PACK_STRUCT_FIELD(u16_t version_number);
-  /** Period of statistics */
-  PACK_STRUCT_FIELD(u16_t period_of_statistics);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_crcs);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_alignment_errors);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_collisions);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_send_aborts);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u32_t number_of_good_sends);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u32_t number_of_good_receives);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_retransmits);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_no_resource_condition);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_free_command_blocks);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t total_number_of_command_blocks);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t max_total_number_of_command_blocks);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t number_of_pending_sessions);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t max_number_of_pending_sessions);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t max_total_sessions_possible);
-  /** Statistics */
-  PACK_STRUCT_FIELD(u16_t session_data_packet_size);
-} PACK_STRUCT_STRUCT;
-PACK_STRUCT_END
-#ifdef PACK_STRUCT_USE_INCLUDES
-#  include "arch/epstruct.h"
-#endif
-
 #ifdef NETBIOS_LWIP_NAME
 #define NETBIOS_LOCAL_NAME NETBIOS_LWIP_NAME
 #else
@@ -220,7 +142,7 @@ static char netbiosns_local_name[NETBIOS_NAME_LEN];
 #define NETBIOS_LOCAL_NAME netbiosns_local_name
 #endif

-static struct udp_pcb *netbiosns_pcb;
+struct udp_pcb *netbiosns_pcb;

 /** Decode a NetBIOS name (from packet to string) */
 static int
@@ -239,13 +161,11 @@ netbiosns_name_decode(char *name_enc, char *name_dec, int name_dec_len)
    /* Every two characters of the first level-encoded name
     * turn into one character in the decoded name. */
    cname = *pname;
-    if (cname == '\0') {
-      break;  /* no more characters */
-    }
-    if (cname == '.') {
-      break;  /* scope ID follows */
-    }
-    if (!lwip_isupper(cname)) {
+    if (cname == '\0')
+      break;    /* no more characters */
+    if (cname == '.')
+      break;    /* scope ID follows */
+    if (cname < 'A' || cname > 'Z') {
      /* Not legal. */
      return -1;
    }
@@ -254,7 +174,12 @@ netbiosns_name_decode(char *name_enc, char *name_dec, int name_dec_len)
    pname++;

    cname = *pname;
-    if (!lwip_isupper(cname)) {
+    if (cname == '\0' || cname == '.') {
+      /* No more characters in the name - but we're in
+       * the middle of a pair.  Not legal. */
+      return -1;
+    }
+    if (cname < 'A' || cname > 'Z') {
      /* Not legal. */
      return -1;
    }
@@ -265,7 +190,7 @@ netbiosns_name_decode(char *name_enc, char *name_dec, int name_dec_len)
    /* Do we have room to store the character? */
    if (idx < NETBIOS_NAME_LEN) {
      /* Yes - store the character. */
-      name_dec[idx++] = (cnbname != ' ' ? cnbname : '\0');
+      name_dec[idx++] = (cnbname!=' '?cnbname:'\0');
    }
  }

@@ -290,12 +215,10 @@ netbiosns_name_encode(char *name_enc, char *name_dec, int name_dec_len)
    /* Every two characters of the first level-encoded name
     * turn into one character in the decoded name. */
    cname = *pname;
-    if (cname == '\0') {
-      break;  /* no more characters */
-    }
-    if (cname == '.') {
-      break;  /* scope ID follows */
-    }
+    if (cname == '\0')
+      break;    /* no more characters */
+    if (cname == '.')
+      break;    /* scope ID follows */
    if ((cname < 'A' || cname > 'Z') && (cname < '0' || cname > '9')) {
      /* Not legal. */
      return -1;
@@ -308,13 +231,13 @@ netbiosns_name_encode(char *name_enc, char *name_dec, int name_dec_len)

    /* Yes - store the character. */
    ucname = cname;
-    name_dec[idx++] = ('A' + ((ucname >> 4) & 0x0F));
-    name_dec[idx++] = ('A' + ( ucname     & 0x0F));
+    name_dec[idx++] = ('A'+((ucname>>4) & 0x0F));
+    name_dec[idx++] = ('A'+( ucname     & 0x0F));
    pname++;
  }

  /* Fill with "space" coding */
-  for (; idx < name_dec_len - 1;) {
+  for (;idx < name_dec_len - 1;) {
    name_dec[idx++] = 'C';
    name_dec[idx++] = 'A';
  }
@@ -334,118 +257,55 @@ netbiosns_recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t

  /* if packet is valid */
  if (p != NULL) {
-    char   netbios_name[NETBIOS_NAME_LEN + 1];
-    struct netbios_hdr      *netbios_hdr      = (struct netbios_hdr *)p->payload;
-    struct netbios_name_hdr *netbios_name_hdr = (struct netbios_name_hdr *)(netbios_hdr + 1);
+    char   netbios_name[NETBIOS_NAME_LEN+1];
+    struct netbios_hdr*      netbios_hdr      = (struct netbios_hdr*)p->payload;
+    struct netbios_name_hdr* netbios_name_hdr = (struct netbios_name_hdr*)(netbios_hdr+1);

-    /* is the packet long enough (we need the header in one piece) */
-    if (p->len < (sizeof(struct netbios_hdr) + sizeof(struct netbios_name_hdr))) {
-      /* packet too short */
-      pbuf_free(p);
-      return;
-    }
    /* we only answer if we got a default interface */
    if (netif_default != NULL) {
      /* @todo: do we need to check answerRRs/authorityRRs/additionalRRs? */
      /* if the packet is a NetBIOS name query question */
      if (((netbios_hdr->flags & PP_NTOHS(NETB_HFLAG_OPCODE)) == PP_NTOHS(NETB_HFLAG_OPCODE_NAME_QUERY)) &&
          ((netbios_hdr->flags & PP_NTOHS(NETB_HFLAG_RESPONSE)) == 0) &&
-          (netbios_hdr->questions == PP_NTOHS(1))) {
+           (netbios_hdr->questions == PP_NTOHS(1))) {
        /* decode the NetBIOS name */
-        netbiosns_name_decode((char *)(netbios_name_hdr->encname), netbios_name, sizeof(netbios_name));
-        /* check the request type */
-        if (netbios_name_hdr->type == PP_HTONS(NETB_QTYPE_NB)) {
-          /* if the packet is for us */
-          if (lwip_strnicmp(netbios_name, NETBIOS_LOCAL_NAME, sizeof(NETBIOS_LOCAL_NAME)) == 0) {
-            struct pbuf *q;
-            struct netbios_resp *resp;
+        netbiosns_name_decode((char*)(netbios_name_hdr->encname), netbios_name, sizeof(netbios_name));
+        /* if the packet is for us */
+        if (lwip_strnicmp(netbios_name, NETBIOS_LOCAL_NAME, sizeof(NETBIOS_LOCAL_NAME)) == 0) {
+          struct pbuf *q;
+          struct netbios_resp *resp;

-            q = pbuf_alloc(PBUF_TRANSPORT, sizeof(struct netbios_resp), PBUF_RAM);
-            if (q != NULL) {
-              resp = (struct netbios_resp *)q->payload;
+          q = pbuf_alloc(PBUF_TRANSPORT, sizeof(struct netbios_resp), PBUF_RAM);
+          if (q != NULL) {
+            resp = (struct netbios_resp*)q->payload;

-              /* prepare NetBIOS header response */
-              resp->resp_hdr.trans_id      = netbios_hdr->trans_id;
-              resp->resp_hdr.flags         = PP_HTONS(NETB_HFLAG_RESPONSE |
-                                                      NETB_HFLAG_OPCODE_NAME_QUERY |
-                                                      NETB_HFLAG_AUTHORATIVE |
-                                                      NETB_HFLAG_RECURS_DESIRED);
-              resp->resp_hdr.questions     = 0;
-              resp->resp_hdr.answerRRs     = PP_HTONS(1);
-              resp->resp_hdr.authorityRRs  = 0;
-              resp->resp_hdr.additionalRRs = 0;
+            /* prepare NetBIOS header response */
+            resp->resp_hdr.trans_id      = netbios_hdr->trans_id;
+            resp->resp_hdr.flags         = PP_HTONS(NETB_HFLAG_RESPONSE |
+                                                 NETB_HFLAG_OPCODE_NAME_QUERY |
+                                                 NETB_HFLAG_AUTHORATIVE |
+                                                 NETB_HFLAG_RECURS_DESIRED);
+            resp->resp_hdr.questions     = 0;
+            resp->resp_hdr.answerRRs     = PP_HTONS(1);
+            resp->resp_hdr.authorityRRs  = 0;
+            resp->resp_hdr.additionalRRs = 0;

-              /* prepare NetBIOS header datas */
-              MEMCPY( resp->resp_name.encname, netbios_name_hdr->encname, sizeof(netbios_name_hdr->encname));
-              resp->resp_name.nametype     = netbios_name_hdr->nametype;
-              resp->resp_name.type         = netbios_name_hdr->type;
-              resp->resp_name.cls          = netbios_name_hdr->cls;
-              resp->resp_name.ttl          = PP_HTONL(NETBIOS_NAME_TTL);
-              resp->resp_name.datalen      = PP_HTONS(sizeof(resp->resp_name.flags) + sizeof(resp->resp_name.addr));
-              resp->resp_name.flags        = PP_HTONS(NETB_NFLAG_NODETYPE_BNODE);
-              ip4_addr_copy(resp->resp_name.addr, *netif_ip4_addr(netif_default));
+            /* prepare NetBIOS header datas */
+            MEMCPY( resp->resp_name.encname, netbios_name_hdr->encname, sizeof(netbios_name_hdr->encname));
+            resp->resp_name.nametype     = netbios_name_hdr->nametype;
+            resp->resp_name.type         = netbios_name_hdr->type;
+            resp->resp_name.cls          = netbios_name_hdr->cls;
+            resp->resp_name.ttl          = PP_HTONL(NETBIOS_NAME_TTL);
+            resp->resp_name.datalen      = PP_HTONS(sizeof(resp->resp_name.flags)+sizeof(resp->resp_name.addr));
+            resp->resp_name.flags        = PP_HTONS(NETB_NFLAG_NODETYPE_BNODE);
+            ip4_addr_copy(resp->resp_name.addr, *netif_ip4_addr(netif_default));

-              /* send the NetBIOS response */
-              udp_sendto(upcb, q, addr, port);
+            /* send the NetBIOS response */
+            udp_sendto(upcb, q, addr, port);

-              /* free the "reference" pbuf */
-              pbuf_free(q);
-            }
+            /* free the "reference" pbuf */
+            pbuf_free(q);
          }
-#if LWIP_NETBIOS_RESPOND_NAME_QUERY
-        } else if (netbios_name_hdr->type == PP_HTONS(NETB_QTYPE_NBSTAT)) {
-          /* if the packet is for us or general query */
-          if (!lwip_strnicmp(netbios_name, NETBIOS_LOCAL_NAME, sizeof(NETBIOS_LOCAL_NAME)) ||
-              !lwip_strnicmp(netbios_name, "*", sizeof(NETBIOS_LOCAL_NAME))) {
-            /* general query - ask for our IP address */
-            struct pbuf *q;
-            struct netbios_answer *resp;
-
-            q = pbuf_alloc(PBUF_TRANSPORT, sizeof(struct netbios_answer), PBUF_RAM);
-            if (q != NULL) {
-              /* buffer to which a response is compiled */
-              resp = (struct netbios_answer *) q->payload;
-
-              /* Init response to zero, especially the statistics fields */
-              memset(resp, 0, sizeof(*resp));
-
-              /* copy the query to the response ID */
-              resp->answer_hdr.trans_id        = netbios_hdr->trans_id;
-              /* acknowledgment of termination */
-              resp->answer_hdr.flags           = PP_HTONS(NETB_HFLAG_RESPONSE | NETB_HFLAG_OPCODE_NAME_QUERY | NETB_HFLAG_AUTHORATIVE);
-              /* resp->answer_hdr.questions       = PP_HTONS(0); done by memset() */
-              /* serial number of the answer */
-              resp->answer_hdr.answerRRs       = PP_HTONS(1);
-              /* resp->answer_hdr.authorityRRs    = PP_HTONS(0); done by memset() */
-              /* resp->answer_hdr.additionalRRs   = PP_HTONS(0); done by memset() */
-              /* we will copy the length of the station name */
-              resp->name_size                  = netbios_name_hdr->nametype;
-              /* we will copy the queried name */
-              MEMCPY(resp->query_name, netbios_name_hdr->encname, (NETBIOS_NAME_LEN * 2) + 1);
-              /* NBSTAT */
-              resp->packet_type                = PP_HTONS(0x21);
-              /* Internet name */
-              resp->cls                        = PP_HTONS(1);
-              /* resp->ttl                        = PP_HTONL(0); done by memset() */
-              resp->data_length                = PP_HTONS(sizeof(struct netbios_answer) - offsetof(struct netbios_answer, number_of_names));
-              resp->number_of_names            = 1;
-
-              /* make windows see us as workstation, not as a server */
-              memset(resp->answer_name, 0x20, NETBIOS_NAME_LEN - 1);
-              /* strlen is checked to be < NETBIOS_NAME_LEN during initialization */
-              MEMCPY(resp->answer_name, NETBIOS_LOCAL_NAME, strlen(NETBIOS_LOCAL_NAME));
-
-              /* b-node, unique, active */
-              resp->answer_name_flags          = PP_HTONS(NETB_NFLAG_NAME_IS_ACTIVE);
-
-              /* Set responder netif MAC address */
-              SMEMCPY(resp->unit_id, ip_current_input_netif()->hwaddr, sizeof(resp->unit_id));
-
-              udp_sendto(upcb, q, addr, port);
-              pbuf_free(q);
-            }
-          }
-#endif /* LWIP_NETBIOS_RESPOND_NAME_QUERY */
        }
      }
    }
@@ -455,13 +315,12 @@ netbiosns_recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t
 }

 /**
- * @ingroup netbiosns
+ * @ingroup netbiosns 
 * Init netbios responder
 */
 void
 netbiosns_init(void)
 {
-  /* LWIP_ASSERT_CORE_LOCKED(); is checked by udp_new() */
 #ifdef NETBIOS_LWIP_NAME
  LWIP_ASSERT("NetBIOS name is too long!", strlen(NETBIOS_LWIP_NAME) < NETBIOS_NAME_LEN);
 #endif
@@ -470,44 +329,35 @@ netbiosns_init(void)
  if (netbiosns_pcb != NULL) {
    /* we have to be allowed to send broadcast packets! */
    ip_set_option(netbiosns_pcb, SOF_BROADCAST);
-    udp_bind(netbiosns_pcb, IP_ANY_TYPE, LWIP_IANA_PORT_NETBIOS);
+    udp_bind(netbiosns_pcb, IP_ANY_TYPE, NETBIOS_PORT);
    udp_recv(netbiosns_pcb, netbiosns_recv, netbiosns_pcb);
  }
 }

 #ifndef NETBIOS_LWIP_NAME
 /**
- * @ingroup netbiosns
+ * @ingroup netbiosns 
 * Set netbios name. ATTENTION: the hostname must be less than 15 characters!
- *                              the NetBIOS name spec says the name MUST be upper case, so incoming name is forced into uppercase :-)
 */
 void
-netbiosns_set_name(const char *hostname)
+netbiosns_set_name(const char* hostname)
 {
-  size_t i;
  size_t copy_len = strlen(hostname);
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("NetBIOS name is too long!", copy_len < NETBIOS_NAME_LEN);
  if (copy_len >= NETBIOS_NAME_LEN) {
    copy_len = NETBIOS_NAME_LEN - 1;
  }
-
-  /* make name into upper case */
-  for (i = 0; i < copy_len; i++ ) {
-    netbiosns_local_name[i] = (char)lwip_toupper(hostname[i]);
-  }
-  netbiosns_local_name[copy_len] = '\0';
+  MEMCPY(netbiosns_local_name, hostname, copy_len + 1);
 }
-#endif /* NETBIOS_LWIP_NAME */
+#endif

 /**
- * @ingroup netbiosns
+ * @ingroup netbiosns 
 * Stop netbios responder
 */
 void
 netbiosns_stop(void)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (netbiosns_pcb != NULL) {
    udp_remove(netbiosns_pcb);
    netbiosns_pcb = NULL;
--- a/src/apps/smtp/smtp.c
+++ b/src/apps/smtp/smtp.c
--- a/src/apps/snmp/snmp_asn1.c
+++ b/src/apps/snmp/snmp_asn1.c
@@ -54,7 +54,7 @@
 * @return ERR_OK if successful, ERR_ARG if we can't (or won't) encode
 */
 err_t
-snmp_ans1_enc_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tlv)
+snmp_ans1_enc_tlv(struct snmp_pbuf_stream* pbuf_stream, struct snmp_asn1_tlv* tlv)
 {
  u8_t data;
  u8_t length_bytes_required;
@@ -130,7 +130,7 @@ snmp_ans1_enc_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tl
 * @return ERR_OK if successful, ERR_ARG if we can't (or won't) encode
 */
 err_t
-snmp_asn1_enc_raw(struct snmp_pbuf_stream *pbuf_stream, const u8_t *raw, u16_t raw_len)
+snmp_asn1_enc_raw(struct snmp_pbuf_stream* pbuf_stream, const u8_t *raw, u16_t raw_len)
 {
  PBUF_OP_EXEC(snmp_pbuf_stream_writebuf(pbuf_stream, raw, raw_len));

@@ -148,7 +148,7 @@ snmp_asn1_enc_raw(struct snmp_pbuf_stream *pbuf_stream, const u8_t *raw, u16_t r
 * @see snmp_asn1_enc_u32t_cnt()
 */
 err_t
-snmp_asn1_enc_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u32_t value)
+snmp_asn1_enc_u32t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, u32_t value)
 {
  if (octets_needed > 5) {
    return ERR_ARG;
@@ -169,6 +169,48 @@ snmp_asn1_enc_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u3

  return ERR_OK;
 }
+
+/**
+ * Encodes u64_t (counter64) into a pbuf chained ASN1 msg.
+ *
+ * @param pbuf_stream points to a pbuf stream
+ * @param octets_needed encoding length (from snmp_asn1_enc_u32t_cnt())
+ * @param value is the host order u32_t value to be encoded
+ * @return ERR_OK if successful, ERR_ARG if we can't (or won't) encode
+ *
+ * @see snmp_asn1_enc_u64t_cnt()
+ */
+err_t
+snmp_asn1_enc_u64t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, const u32_t* value)
+{
+  if (octets_needed > 9) {
+    return ERR_ARG;
+  }
+  if (octets_needed == 9) {
+    /* not enough bits in 'value' add leading 0x00 */
+    PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, 0x00));
+    octets_needed--;
+  }
+
+  while (octets_needed > 4) {
+    octets_needed--;
+    PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, (u8_t)(*value >> ((octets_needed-4) << 3))));
+  }
+
+  /* skip to low u32 */
+  value++;
+
+  while (octets_needed > 1) {
+    octets_needed--;
+    PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, (u8_t)(*value >> (octets_needed << 3))));
+  }
+
+  /* always write at least one octet (also in case of value == 0) */
+  PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, (u8_t)(*value)));
+
+  return ERR_OK;
+}
+
 /**
 * Encodes s32_t integer into a pbuf chained ASN1 msg.
 *
@@ -180,7 +222,7 @@ snmp_asn1_enc_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u3
 * @see snmp_asn1_enc_s32t_cnt()
 */
 err_t
-snmp_asn1_enc_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, s32_t value)
+snmp_asn1_enc_s32t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, s32_t value)
 {
  while (octets_needed > 1) {
    octets_needed--;
@@ -203,7 +245,7 @@ snmp_asn1_enc_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, s3
 * @return ERR_OK if successful, ERR_ARG if we can't (or won't) encode
 */
 err_t
-snmp_asn1_enc_oid(struct snmp_pbuf_stream *pbuf_stream, const u32_t *oid, u16_t oid_len)
+snmp_asn1_enc_oid(struct snmp_pbuf_stream* pbuf_stream, const u32_t *oid, u16_t oid_len)
 {
  if (oid_len > 1) {
    /* write compressed first two sub id's */
@@ -287,6 +329,31 @@ snmp_asn1_enc_u32t_cnt(u32_t value, u16_t *octets_needed)
  }
 }

+/**
+ * Returns octet count for an u64_t.
+ *
+ * @param value value to be encoded
+ * @param octets_needed points to the return value
+ *
+ * @note ASN coded integers are _always_ signed. E.g. +0xFFFF is coded
+ * as 0x00,0xFF,0xFF. Note the leading sign octet. A positive value
+ * of 0xFFFFFFFF is preceded with 0x00 and the length is 5 octets!!
+ */
+void
+snmp_asn1_enc_u64t_cnt(const u32_t *value, u16_t *octets_needed)
+{
+  /* check if high u32 is 0 */
+  if (*value == 0x00) {
+    /* only low u32 is important */
+    value++;
+    snmp_asn1_enc_u32t_cnt(*value, octets_needed);
+  } else {
+    /* low u32 does not matter for length determination */
+    snmp_asn1_enc_u32t_cnt(*value, octets_needed);
+    *octets_needed = *octets_needed + 4; /* add the 4 bytes of low u32 */
+  }
+}
+
 /**
 * Returns octet count for an s32_t.
 *
@@ -353,7 +420,7 @@ snmp_asn1_enc_oid_cnt(const u32_t *oid, u16_t oid_len, u16_t *octets_needed)
 * @return ERR_OK if successful, ERR_VAL if we can't decode
 */
 err_t
-snmp_asn1_dec_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tlv)
+snmp_asn1_dec_tlv(struct snmp_pbuf_stream* pbuf_stream, struct snmp_asn1_tlv* tlv)
 {
  u8_t data;

@@ -375,9 +442,6 @@ snmp_asn1_dec_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tl
    tlv->value_len  = data;
  } else if (data > 0x80) { /* long form */
    u8_t length_bytes = data - 0x80;
-    if (length_bytes > pbuf_stream->length) {
-      return ERR_VAL;
-    }
    tlv->length_len = length_bytes + 1; /* this byte + defined number of length bytes following */
    tlv->value_len = 0;

@@ -445,6 +509,60 @@ snmp_asn1_dec_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *value
  return ERR_VAL;
 }

+/**
+ * Decodes large positive integer (counter64) into 2x u32_t.
+ *
+ * @param pbuf_stream points to a pbuf stream
+ * @param len length of the coded integer field
+ * @param value return host order integer
+ * @return ERR_OK if successful, ERR_ARG if we can't (or won't) decode
+ *
+ * @note ASN coded integers are _always_ signed. E.g. +0xFFFF is coded
+ * as 0x00,0xFF,0xFF. Note the leading sign octet. A positive value
+ * of 0xFFFFFFFF is preceded with 0x00 and the length is 5 octets!!
+ */
+err_t
+snmp_asn1_dec_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *value)
+{
+  u8_t data;
+
+  if (len <= 4) {
+    /* high u32 is 0 */
+    *value = 0;
+    /* directly skip to low u32 */
+    value++;
+  }
+
+  if ((len > 0) && (len <= 9)) {
+    PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
+
+    /* expecting sign bit to be zero, only unsigned please! */
+    if (((len == 9) && (data == 0x00)) || ((len < 9) && ((data & 0x80) == 0))) {
+      *value = data;
+      len--;
+
+      while (len > 0) {
+        PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
+
+        if (len == 4) {
+          /* skip to low u32 */
+          value++;
+          *value = 0;
+        } else {
+          *value <<= 8;
+        }
+
+        *value |= data;
+        len--;
+      }
+
+      return ERR_OK;
+    }
+  }
+
+  return ERR_VAL;
+}
+
 /**
 * Decodes integer into s32_t.
 *
@@ -458,26 +576,51 @@ snmp_asn1_dec_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *value
 err_t
 snmp_asn1_dec_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, s32_t *value)
 {
+#if BYTE_ORDER == LITTLE_ENDIAN
+  u8_t *lsb_ptr = (u8_t*)value;
+#endif
+#if BYTE_ORDER == BIG_ENDIAN
+  u8_t *lsb_ptr = (u8_t*)value + sizeof(s32_t) - 1;
+#endif
+  u8_t sign;
  u8_t data;

  if ((len > 0) && (len < 5)) {
    PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
+    len--;

    if (data & 0x80) {
      /* negative, start from -1 */
      *value = -1;
-      *value = (*value << 8) | data;
+      sign = 1;
+      *lsb_ptr &= data;
    } else {
      /* positive, start from 0 */
-      *value = data;
+      *value = 0;
+      sign = 0;
+      *lsb_ptr |= data;
    }
-    len--;
-    /* shift in the remaining value */
+
+    /* OR/AND octets with value */
    while (len > 0) {
      PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
-      *value = (*value << 8) | data;
      len--;
+
+#if BYTE_ORDER == LITTLE_ENDIAN
+      *value <<= 8;
+#endif
+#if BYTE_ORDER == BIG_ENDIAN
+      *value >>= 8;
+#endif
+
+      if (sign) {
+        *lsb_ptr |= 255;
+        *lsb_ptr &= data;
+      } else {
+        *lsb_ptr |= data;
+      }
    }
+
    return ERR_OK;
  }

@@ -495,7 +638,7 @@ snmp_asn1_dec_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, s32_t *value
 * @return ERR_OK if successful, ERR_ARG if we can't (or won't) decode
 */
 err_t
-snmp_asn1_dec_oid(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *oid, u8_t *oid_len, u8_t oid_max_len)
+snmp_asn1_dec_oid(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t* oid, u8_t* oid_len, u8_t oid_max_len)
 {
  u32_t *oid_ptr;
  u8_t data;
@@ -586,7 +729,7 @@ snmp_asn1_dec_oid(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *oid, u
 * @return ERR_OK if successful, ERR_ARG if we can't (or won't) decode
 */
 err_t
-snmp_asn1_dec_raw(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u8_t *buf, u16_t *buf_len, u16_t buf_max_len)
+snmp_asn1_dec_raw(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u8_t *buf, u16_t* buf_len, u16_t buf_max_len)
 {
  if (len > buf_max_len) {
    /* not enough dst space */
@@ -603,102 +746,4 @@ snmp_asn1_dec_raw(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u8_t *buf, u1
  return ERR_OK;
 }

-#if LWIP_HAVE_INT64
-/**
- * Returns octet count for an u64_t.
- *
- * @param value value to be encoded
- * @param octets_needed points to the return value
- *
- * @note ASN coded integers are _always_ signed. E.g. +0xFFFF is coded
- * as 0x00,0xFF,0xFF. Note the leading sign octet. A positive value
- * of 0xFFFFFFFFFFFFFFFF is preceded with 0x00 and the length is 9 octets!!
- */
-void
-snmp_asn1_enc_u64t_cnt(u64_t value, u16_t *octets_needed)
-{
-  /* check if high u32 is 0 */
-  if ((value >> 32) == 0) {
-    /* only low u32 is important */
-    snmp_asn1_enc_u32t_cnt((u32_t)value, octets_needed);
-  } else {
-    /* low u32 does not matter for length determination */
-    snmp_asn1_enc_u32t_cnt((u32_t)(value >> 32), octets_needed);
-    *octets_needed = *octets_needed + 4; /* add the 4 bytes of low u32 */
-  }
-}
-
-/**
- * Decodes large positive integer (counter64) into 2x u32_t.
- *
- * @param pbuf_stream points to a pbuf stream
- * @param len length of the coded integer field
- * @param value return 64 bit integer
- * @return ERR_OK if successful, ERR_ARG if we can't (or won't) decode
- *
- * @note ASN coded integers are _always_ signed. E.g. +0xFFFF is coded
- * as 0x00,0xFF,0xFF. Note the leading sign octet. A positive value
- * of 0xFFFFFFFFFFFFFFFF is preceded with 0x00 and the length is 9 octets!!
- */
-err_t
-snmp_asn1_dec_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u64_t *value)
-{
-  u8_t data;
-
-  if ((len > 0) && (len <= 9)) {
-    PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
-
-    /* expecting sign bit to be zero, only unsigned please! */
-    if (((len == 9) && (data == 0x00)) || ((len < 9) && ((data & 0x80) == 0))) {
-      *value = data;
-      len--;
-
-      while (len > 0) {
-        PBUF_OP_EXEC(snmp_pbuf_stream_read(pbuf_stream, &data));
-        *value <<= 8;
-        *value |= data;
-        len--;
-      }
-
-      return ERR_OK;
-    }
-  }
-
-  return ERR_VAL;
-}
-
-/**
- * Encodes u64_t (counter64) into a pbuf chained ASN1 msg.
- *
- * @param pbuf_stream points to a pbuf stream
- * @param octets_needed encoding length (from snmp_asn1_enc_u32t_cnt())
- * @param value is the value to be encoded
- * @return ERR_OK if successful, ERR_ARG if we can't (or won't) encode
- *
- * @see snmp_asn1_enc_u64t_cnt()
- */
-err_t
-snmp_asn1_enc_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u64_t value)
-{
-  if (octets_needed > 9) {
-    return ERR_ARG;
-  }
-  if (octets_needed == 9) {
-    /* not enough bits in 'value' add leading 0x00 */
-    PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, 0x00));
-    octets_needed--;
-  }
-
-  while (octets_needed > 1) {
-    octets_needed--;
-    PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, (u8_t)(value >> (octets_needed << 3))));
-  }
-
-  /* always write at least one octet (also in case of value == 0) */
-  PBUF_OP_EXEC(snmp_pbuf_stream_write(pbuf_stream, (u8_t)(value)));
-
-  return ERR_OK;
-}
-#endif
-
 #endif /* LWIP_SNMP */
--- a/src/apps/snmp/snmp_asn1.h
+++ b/src/apps/snmp/snmp_asn1.h
@@ -57,21 +57,19 @@ extern "C" {
 #define SNMP_ASN1_DATATYPE_MASK     0x1F
 #define SNMP_ASN1_DATATYPE_EXTENDED 0x1F /* DataType indicating that datatype is encoded in following bytes */

-/* context specific (SNMP) tags (from SNMP spec. RFC1157 and RFC1905) */
+/* context specific (SNMP) tags (from SNMP spec. RFC1157) */
 #define SNMP_ASN1_CONTEXT_PDU_GET_REQ      0
 #define SNMP_ASN1_CONTEXT_PDU_GET_NEXT_REQ 1
 #define SNMP_ASN1_CONTEXT_PDU_GET_RESP     2
 #define SNMP_ASN1_CONTEXT_PDU_SET_REQ      3
 #define SNMP_ASN1_CONTEXT_PDU_TRAP         4
 #define SNMP_ASN1_CONTEXT_PDU_GET_BULK_REQ 5
-#define SNMP_ASN1_CONTEXT_PDU_INFORM_REQ   6
-#define SNMP_ASN1_CONTEXT_PDU_V2_TRAP      7
-#define SNMP_ASN1_CONTEXT_PDU_REPORT       8

 #define SNMP_ASN1_CONTEXT_VARBIND_NO_SUCH_OBJECT      0
 #define SNMP_ASN1_CONTEXT_VARBIND_END_OF_MIB_VIEW     2

-struct snmp_asn1_tlv {
+struct snmp_asn1_tlv
+{
  u8_t  type;       /* only U8 because extended types are not specified by SNMP */
  u8_t  type_len;   /* encoded length of 'type' field (normally 1) */
  u8_t  length_len; /* indicates how many bytes are required to encode the 'value_len' field */
@@ -81,28 +79,25 @@ struct snmp_asn1_tlv {
 #define SNMP_ASN1_TLV_LENGTH(tlv) ((tlv).type_len + (tlv).length_len + (tlv).value_len)
 #define SNMP_ASN1_SET_TLV_PARAMS(tlv, type_, length_len_, value_len_) do { (tlv).type = (type_); (tlv).type_len = 0; (tlv).length_len = (length_len_); (tlv).value_len = (value_len_); } while (0);

-err_t snmp_asn1_dec_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tlv);
+err_t snmp_asn1_dec_tlv(struct snmp_pbuf_stream* pbuf_stream, struct snmp_asn1_tlv* tlv);
 err_t snmp_asn1_dec_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *value);
+err_t snmp_asn1_dec_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *value);
 err_t snmp_asn1_dec_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, s32_t *value);
-err_t snmp_asn1_dec_oid(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t *oid, u8_t *oid_len, u8_t oid_max_len);
-err_t snmp_asn1_dec_raw(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u8_t *buf, u16_t *buf_len, u16_t buf_max_len);
+err_t snmp_asn1_dec_oid(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u32_t* oid, u8_t* oid_len, u8_t oid_max_len);
+err_t snmp_asn1_dec_raw(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u8_t *buf, u16_t* buf_len, u16_t buf_max_len);

-err_t snmp_ans1_enc_tlv(struct snmp_pbuf_stream *pbuf_stream, struct snmp_asn1_tlv *tlv);
+err_t snmp_ans1_enc_tlv(struct snmp_pbuf_stream* pbuf_stream, struct snmp_asn1_tlv* tlv);

 void snmp_asn1_enc_length_cnt(u16_t length, u8_t *octets_needed);
 void snmp_asn1_enc_u32t_cnt(u32_t value, u16_t *octets_needed);
+void snmp_asn1_enc_u64t_cnt(const u32_t *value, u16_t *octets_needed);
 void snmp_asn1_enc_s32t_cnt(s32_t value, u16_t *octets_needed);
 void snmp_asn1_enc_oid_cnt(const u32_t *oid, u16_t oid_len, u16_t *octets_needed);
-err_t snmp_asn1_enc_oid(struct snmp_pbuf_stream *pbuf_stream, const u32_t *oid, u16_t oid_len);
-err_t snmp_asn1_enc_s32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, s32_t value);
-err_t snmp_asn1_enc_u32t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u32_t value);
-err_t snmp_asn1_enc_raw(struct snmp_pbuf_stream *pbuf_stream, const u8_t *raw, u16_t raw_len);
-
-#if LWIP_HAVE_INT64
-err_t snmp_asn1_dec_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t len, u64_t *value);
-void snmp_asn1_enc_u64t_cnt(u64_t value, u16_t *octets_needed);
-err_t snmp_asn1_enc_u64t(struct snmp_pbuf_stream *pbuf_stream, u16_t octets_needed, u64_t value);
-#endif
+err_t snmp_asn1_enc_oid(struct snmp_pbuf_stream* pbuf_stream, const u32_t *oid, u16_t oid_len);
+err_t snmp_asn1_enc_s32t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, s32_t value);
+err_t snmp_asn1_enc_u32t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, u32_t value);
+err_t snmp_asn1_enc_u64t(struct snmp_pbuf_stream* pbuf_stream, u16_t octets_needed, const u32_t* value);
+err_t snmp_asn1_enc_raw(struct snmp_pbuf_stream* pbuf_stream, const u8_t *raw, u16_t raw_len);

 #ifdef __cplusplus
 }
--- a/src/apps/snmp/snmp_core.c
+++ b/src/apps/snmp/snmp_core.c
@@ -34,24 +34,24 @@
 */

 /**
- * @defgroup snmp SNMPv2c/v3 agent
+ * @defgroup snmp SNMPv2c agent
 * @ingroup apps
- * SNMPv2c and SNMPv3 compatible agent\n
+ * SNMPv2c compatible agent\n
 * There is also a MIB compiler and a MIB viewer in lwIP contrib repository
 * (lwip-contrib/apps/LwipMibCompiler).\n
 * The agent implements the most important MIB2 MIBs including IPv6 support
 * (interfaces, UDP, TCP, SNMP, ICMP, SYSTEM). IP MIB is an older version
- * without IPv6 statistics (TODO).\n
+ * whithout IPv6 statistics (TODO).\n
 * Rewritten by Martin Hentschel <info@cl-soft.de> and
 * Dirk Ziegelmeier <dziegel@gmx.de>\n
+ * Work on SNMPv3 has started, but is not finished.\n
 *
 * 0 Agent Capabilities
 * ====================
- *
+ * 
 * Features:
 * ---------
 * - SNMPv2c support.
- * - SNMPv3 support (a port to ARM mbedtls is provided, LWIP_SNMP_V3_MBEDTLS option).
 * - Low RAM usage - no memory pools, stack only.
 * - MIB2 implementation is separated from SNMP stack.
 * - Support for multiple MIBs (snmp_set_mibs() call) - e.g. for private MIB.
@@ -66,7 +66,7 @@
 * - Simplified thread sync support for MIBs - useful when MIBs
 *   need to access variables shared with other threads where no locking is
 *   possible. Used in MIB2 to access lwIP stats from lwIP thread.
- *
+ * 
 * MIB compiler (code generator):
 * ------------------------------
 * - Provided in lwIP contrib repository.
@@ -78,100 +78,92 @@
 * - MIB parser, C file generation framework and LWIP code generation are cleanly
 *   separated, which means the code may be useful as a base for code generation
 *   of other SNMP agents.
- *
+ * 
 * Notes:
 * ------
 * - Stack and MIB compiler were used to implement a Profinet device.
 *   Compiled/implemented MIBs: LLDP-MIB, LLDP-EXT-DOT3-MIB, LLDP-EXT-PNO-MIB.
- *
+ * 
 * SNMPv1 per RFC1157 and SNMPv2c per RFC 3416
 * -------------------------------------------
 *   Note the S in SNMP stands for "Simple". Note that "Simple" is
 *   relative. SNMP is simple compared to the complex ISO network
 *   management protocols CMIP (Common Management Information Protocol)
 *   and CMOT (CMip Over Tcp).
- *
- * SNMPv3
- * ------
- * When SNMPv3 is used, several functions from snmpv3.h must be implemented
- * by the user. This is mainly user management and persistence handling.
- * The sample provided in lwip-contrib is insecure, don't use it in production
- * systems, especially the missing persistence for engine boots variable
- * simplifies replay attacks.
- *
+ * 
 * MIB II
 * ------
 *   The standard lwIP stack management information base.
 *   This is a required MIB, so this is always enabled.
 *   The groups EGP, CMOT and transmission are disabled by default.
- *
+ * 
 *   Most mib-2 objects are not writable except:
 *   sysName, sysLocation, sysContact, snmpEnableAuthenTraps.
 *   Writing to or changing the ARP and IP address and route
 *   tables is not possible.
- *
+ * 
 *   Note lwIP has a very limited notion of IP routing. It currently
 *   doen't have a route table and doesn't have a notion of the U,G,H flags.
 *   Instead lwIP uses the interface list with only one default interface
 *   acting as a single gateway interface (G) for the default route.
- *
+ * 
 *   The agent returns a "virtual table" with the default route 0.0.0.0
 *   for the default interface and network routes (no H) for each
 *   network interface in the netif_list.
 *   All routes are considered to be up (U).
- *
+ * 
 * Loading additional MIBs
 * -----------------------
 *   MIBs can only be added in compile-time, not in run-time.
- *
- *
+ *  
+ * 
 * 1 Building the Agent
 * ====================
 * First of all you'll need to add the following define
 * to your local lwipopts.h:
 * \#define LWIP_SNMP               1
- *
+ * 
 * and add the source files your makefile.
- *
+ * 
 * Note you'll might need to adapt you network driver to update
 * the mib2 variables for your interface.
- *
+ * 
 * 2 Running the Agent
 * ===================
 * The following function calls must be made in your program to
 * actually get the SNMP agent running.
- *
+ * 
 * Before starting the agent you should supply pointers
 * for sysContact, sysLocation, and snmpEnableAuthenTraps.
 * You can do this by calling
- *
+ * 
 * - snmp_mib2_set_syscontact()
 * - snmp_mib2_set_syslocation()
 * - snmp_set_auth_traps_enabled()
- *
- * You can register a callback which is called on successful write access:
+ * 
+ * You can register a callback which is called on successful write access: 
 * snmp_set_write_callback().
- *
+ * 
 * Additionally you may want to set
- *
+ * 
 * - snmp_mib2_set_sysdescr()
 * - snmp_set_device_enterprise_oid()
 * - snmp_mib2_set_sysname()
- *
+ * 
 * Also before starting the agent you need to setup
 * one or more trap destinations using these calls:
- *
+ * 
 * - snmp_trap_dst_enable()
 * - snmp_trap_dst_ip_set()
- *
+ * 
 * If you need more than MIB2, set the MIBs you want to use
 * by snmp_set_mibs().
- *
+ * 
 * Finally, enable the agent by calling snmp_init()
 *
 * @defgroup snmp_core Core
 * @ingroup snmp
- *
+ * 
 * @defgroup snmp_traps Traps
 * @ingroup snmp
 */
@@ -188,39 +180,31 @@


 #if (LWIP_SNMP && (SNMP_TRAP_DESTINATIONS<=0))
-#error "If you want to use SNMP, you have to define SNMP_TRAP_DESTINATIONS>=1 in your lwipopts.h"
+  #error "If you want to use SNMP, you have to define SNMP_TRAP_DESTINATIONS>=1 in your lwipopts.h"
 #endif
 #if (!LWIP_UDP && LWIP_SNMP)
-#error "If you want to use SNMP, you have to define LWIP_UDP=1 in your lwipopts.h"
-#endif
-#if SNMP_MAX_OBJ_ID_LEN > 255
-#error "SNMP_MAX_OBJ_ID_LEN must fit into an u8_t"
+  #error "If you want to use SNMP, you have to define LWIP_UDP=1 in your lwipopts.h"
 #endif

 struct snmp_statistics snmp_stats;
 static const struct snmp_obj_id  snmp_device_enterprise_oid_default = {SNMP_DEVICE_ENTERPRISE_OID_LEN, SNMP_DEVICE_ENTERPRISE_OID};
-static const struct snmp_obj_id *snmp_device_enterprise_oid         = &snmp_device_enterprise_oid_default;
+static const struct snmp_obj_id* snmp_device_enterprise_oid         = &snmp_device_enterprise_oid_default;

 const u32_t snmp_zero_dot_zero_values[] = { 0, 0 };
 const struct snmp_obj_id_const_ref snmp_zero_dot_zero = { LWIP_ARRAYSIZE(snmp_zero_dot_zero_values), snmp_zero_dot_zero_values };

-#if SNMP_LWIP_MIB2 && LWIP_SNMP_V3
+
+#if SNMP_LWIP_MIB2
 #include "lwip/apps/snmp_mib2.h"
-#include "lwip/apps/snmp_snmpv2_framework.h"
-#include "lwip/apps/snmp_snmpv2_usm.h"
-static const struct snmp_mib *const default_mibs[] = { &mib2, &snmpframeworkmib, &snmpusmmib };
-static u8_t snmp_num_mibs                          = LWIP_ARRAYSIZE(default_mibs);
-#elif SNMP_LWIP_MIB2
-#include "lwip/apps/snmp_mib2.h"
-static const struct snmp_mib *const default_mibs[] = { &mib2 };
-static u8_t snmp_num_mibs                          = LWIP_ARRAYSIZE(default_mibs);
+static const struct snmp_mib* const default_mibs[] = { &mib2 };
+static u8_t snmp_num_mibs                          = 1;
 #else
-static const struct snmp_mib *const default_mibs[] = { NULL };
+static const struct snmp_mib* const default_mibs[] = { NULL };
 static u8_t snmp_num_mibs                          = 0;
 #endif

 /* List of known mibs */
-static struct snmp_mib const *const *snmp_mibs = default_mibs;
+static struct snmp_mib const * const *snmp_mibs = default_mibs;

 /**
 * @ingroup snmp_core
@@ -235,7 +219,6 @@ static struct snmp_mib const *const *snmp_mibs = default_mibs;
 void
 snmp_set_mibs(const struct snmp_mib **mibs, u8_t num_mibs)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("mibs pointer must be != NULL", (mibs != NULL));
  LWIP_ASSERT("num_mibs pointer must be != 0", (num_mibs != 0));
  snmp_mibs     = mibs;
@@ -249,16 +232,15 @@ snmp_set_mibs(const struct snmp_mib **mibs, u8_t num_mibs)
 * The 'device enterprise oid' shall point to an OID located under 'private-enterprises' branch (1.3.6.1.4.1.XXX). If a vendor
 * wants to provide a custom object there, he has to get its own enterprise oid from IANA (http://www.iana.org). It
 * is not allowed to use LWIP enterprise ID!
- * In order to identify a specific device it is recommended to create a dedicated OID for each device type under its own
+ * In order to identify a specific device it is recommended to create a dedicated OID for each device type under its own 
 * enterprise oid.
 * e.g.
 * device a > 1.3.6.1.4.1.XXX(ent-oid).1(devices).1(device a)
 * device b > 1.3.6.1.4.1.XXX(ent-oid).1(devices).2(device b)
 * for more details see description of 'sysObjectID' field in RFC1213-MIB
 */
-void snmp_set_device_enterprise_oid(const struct snmp_obj_id *device_enterprise_oid)
+void snmp_set_device_enterprise_oid(const struct snmp_obj_id* device_enterprise_oid)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (device_enterprise_oid == NULL) {
    snmp_device_enterprise_oid = &snmp_device_enterprise_oid_default;
  } else {
@@ -268,11 +250,10 @@ void snmp_set_device_enterprise_oid(const struct snmp_obj_id *device_enterprise_

 /**
 * @ingroup snmp_core
- * Get 'device enterprise oid'
+ * Get 'device enterprise oid' 
 */
-const struct snmp_obj_id *snmp_get_device_enterprise_oid(void)
+const struct snmp_obj_id* snmp_get_device_enterprise_oid(void)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  return snmp_device_enterprise_oid;
 }

@@ -515,16 +496,16 @@ snmp_oid_to_ip(const u32_t *oid, u8_t oid_len, ip_addr_t *ip)
 u8_t
 snmp_oid_to_ip_port(const u32_t *oid, u8_t oid_len, ip_addr_t *ip, u16_t *port)
 {
-  u8_t idx;
+  u8_t idx = 0;

  /* InetAddressType + InetAddress */
-  idx = snmp_oid_to_ip(&oid[0], oid_len, ip);
+  idx += snmp_oid_to_ip(&oid[idx], oid_len-idx, ip);
  if (idx == 0) {
    return 0;
  }

  /* InetPortNumber */
-  if (oid_len < (idx + 1)) {
+  if (oid_len < (idx+1)) {
    return 0;
  }
  if (oid[idx] > 0xffff) {
@@ -540,14 +521,14 @@ snmp_oid_to_ip_port(const u32_t *oid, u8_t oid_len, ip_addr_t *ip, u16_t *port)

 /**
 * Assign an OID to struct snmp_obj_id
- * @param target Assignment target
+ * @param target Assignment target 
 * @param oid OID
 * @param oid_len OID length
 */
 void
-snmp_oid_assign(struct snmp_obj_id *target, const u32_t *oid, u8_t oid_len)
+snmp_oid_assign(struct snmp_obj_id* target, const u32_t *oid, u8_t oid_len)
 {
-  LWIP_ASSERT("oid_len <= SNMP_MAX_OBJ_ID_LEN", oid_len <= SNMP_MAX_OBJ_ID_LEN);
+  LWIP_ASSERT("oid_len <= LWIP_SNMP_OBJ_ID_LEN", oid_len <= SNMP_MAX_OBJ_ID_LEN);

  target->len = oid_len;

@@ -563,14 +544,14 @@ snmp_oid_assign(struct snmp_obj_id *target, const u32_t *oid, u8_t oid_len)
 * @param oid_len OID length
 */
 void
-snmp_oid_prefix(struct snmp_obj_id *target, const u32_t *oid, u8_t oid_len)
+snmp_oid_prefix(struct snmp_obj_id* target, const u32_t *oid, u8_t oid_len)
 {
-  LWIP_ASSERT("target->len + oid_len <= SNMP_MAX_OBJ_ID_LEN", (target->len + oid_len) <= SNMP_MAX_OBJ_ID_LEN);
+  LWIP_ASSERT("target->len + oid_len <= LWIP_SNMP_OBJ_ID_LEN", (target->len + oid_len) <= SNMP_MAX_OBJ_ID_LEN);

  if (oid_len > 0) {
    /* move existing OID to make room at the beginning for OID to insert */
    int i;
-    for (i = target->len - 1; i >= 0; i--) {
+    for (i = target->len-1; i>=0; i--) {
      target->id[i + oid_len] = target->id[i];
    }

@@ -588,7 +569,7 @@ snmp_oid_prefix(struct snmp_obj_id *target, const u32_t *oid, u8_t oid_len)
 * @param oid2_len OID 2 length
 */
 void
-snmp_oid_combine(struct snmp_obj_id *target, const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_len)
+snmp_oid_combine(struct snmp_obj_id* target, const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_len)
 {
  snmp_oid_assign(target, oid1, oid1_len);
  snmp_oid_append(target, oid2, oid2_len);
@@ -601,13 +582,13 @@ snmp_oid_combine(struct snmp_obj_id *target, const u32_t *oid1, u8_t oid1_len, c
 * @param oid_len OID length
 */
 void
-snmp_oid_append(struct snmp_obj_id *target, const u32_t *oid, u8_t oid_len)
+snmp_oid_append(struct snmp_obj_id* target, const u32_t *oid, u8_t oid_len)
 {
-  LWIP_ASSERT("offset + oid_len <= SNMP_MAX_OBJ_ID_LEN", (target->len + oid_len) <= SNMP_MAX_OBJ_ID_LEN);
+  LWIP_ASSERT("offset + oid_len <= LWIP_SNMP_OBJ_ID_LEN", (target->len + oid_len) <= SNMP_MAX_OBJ_ID_LEN);

  if (oid_len > 0) {
    MEMCPY(&target->id[target->len], oid, oid_len * sizeof(u32_t));
-    target->len = (u8_t)(target->len + oid_len);
+    target->len += oid_len;
  }
 }

@@ -663,7 +644,7 @@ snmp_oid_compare(const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_
 u8_t
 snmp_oid_equal(const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_len)
 {
-  return (snmp_oid_compare(oid1, oid1_len, oid2, oid2_len) == 0) ? 1 : 0;
+  return (snmp_oid_compare(oid1, oid1_len, oid2, oid2_len) == 0)? 1 : 0;
 }

 /**
@@ -674,18 +655,32 @@ snmp_oid_equal(const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_le
 u8_t
 netif_to_num(const struct netif *netif)
 {
-  return netif_get_index(netif);
+  u8_t result = 0;
+  struct netif *netif_iterator = netif_list;
+
+  while (netif_iterator != NULL) {
+    result++;
+
+    if (netif_iterator == netif) {
+      return result;
+    }
+
+    netif_iterator = netif_iterator->next;
+  }
+
+  LWIP_ASSERT("netif not found in netif_list", 0);
+  return 0;
 }

-static const struct snmp_mib *
+static const struct snmp_mib*
 snmp_get_mib_from_oid(const u32_t *oid, u8_t oid_len)
 {
-  const u32_t *list_oid;
-  const u32_t *searched_oid;
+  const u32_t* list_oid;
+  const u32_t* searched_oid;
  u8_t i, l;

  u8_t max_match_len = 0;
-  const struct snmp_mib *matched_mib = NULL;
+  const struct snmp_mib* matched_mib = NULL;

  LWIP_ASSERT("'oid' param must not be NULL!", (oid != NULL));

@@ -722,11 +717,11 @@ snmp_get_mib_from_oid(const u32_t *oid, u8_t oid_len)
  return matched_mib;
 }

-static const struct snmp_mib *
+static const struct snmp_mib*
 snmp_get_next_mib(const u32_t *oid, u8_t oid_len)
 {
  u8_t i;
-  const struct snmp_mib *next_mib = NULL;
+  const struct snmp_mib* next_mib = NULL;

  LWIP_ASSERT("'oid' param must not be NULL!", (oid != NULL));

@@ -750,10 +745,10 @@ snmp_get_next_mib(const u32_t *oid, u8_t oid_len)
  return next_mib;
 }

-static const struct snmp_mib *
+static const struct snmp_mib*
 snmp_get_mib_between(const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t oid2_len)
 {
-  const struct snmp_mib *next_mib = snmp_get_next_mib(oid1, oid1_len);
+  const struct snmp_mib* next_mib = snmp_get_next_mib(oid1, oid1_len);

  LWIP_ASSERT("'oid2' param must not be NULL!", (oid2 != NULL));
  LWIP_ASSERT("'oid2_len' param must be greater than 0!", (oid2_len > 0));
@@ -768,7 +763,7 @@ snmp_get_mib_between(const u32_t *oid1, u8_t oid1_len, const u32_t *oid2, u8_t o
 }

 u8_t
-snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node_instance *node_instance)
+snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node_instance* node_instance)
 {
  u8_t result = SNMP_ERR_NOSUCHOBJECT;
  const struct snmp_mib *mib;
@@ -781,15 +776,15 @@ snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node
    mn = snmp_mib_tree_resolve_exact(mib, oid, oid_len, &oid_instance_len);
    if ((mn != NULL) && (mn->node_type != SNMP_NODE_TREE)) {
      /* get instance */
-      const struct snmp_leaf_node *leaf_node = (const struct snmp_leaf_node *)(const void *)mn;
+      const struct snmp_leaf_node* leaf_node = (const struct snmp_leaf_node*)(const void*)mn;

      node_instance->node = mn;
      snmp_oid_assign(&node_instance->instance_oid, oid + (oid_len - oid_instance_len), oid_instance_len);

      result = leaf_node->get_instance(
-                 oid,
-                 oid_len - oid_instance_len,
-                 node_instance);
+        oid,
+        oid_len - oid_instance_len,
+        node_instance);

 #ifdef LWIP_DEBUG
      if (result == SNMP_ERR_NOERROR) {
@@ -808,11 +803,11 @@ snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node
 }

 u8_t
-snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_validate_node_instance_method validate_node_instance_method, void *validate_node_instance_arg, struct snmp_obj_id *node_oid, struct snmp_node_instance *node_instance)
+snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_validate_node_instance_method validate_node_instance_method, void* validate_node_instance_arg, struct snmp_obj_id* node_oid, struct snmp_node_instance* node_instance)
 {
  const struct snmp_mib      *mib;
  const struct snmp_node *mn = NULL;
-  const u32_t *start_oid     = NULL;
+  const u32_t* start_oid     = NULL;
  u8_t         start_oid_len = 0;

  /* resolve target MIB from passed OID */
@@ -848,7 +843,7 @@ snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_valida
    /* validate the node; if the node has no further instance or the returned instance is invalid, search for the next in MIB and validate again */
    node_instance->node = mn;
    while (mn != NULL) {
-      u8_t result;
+       u8_t result;

      /* clear fields which may have values from previous loops */
      node_instance->asn1_type        = 0;
@@ -860,10 +855,10 @@ snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_valida
      node_instance->reference.ptr    = NULL;
      node_instance->reference_len    = 0;

-      result = ((const struct snmp_leaf_node *)(const void *)mn)->get_next_instance(
-                 node_oid->id,
-                 node_oid->len,
-                 node_instance);
+      result = ((const struct snmp_leaf_node*)(const void*)mn)->get_next_instance(
+        node_oid->id,
+        node_oid->len,
+        node_instance);

      if (result == SNMP_ERR_NOERROR) {
 #ifdef LWIP_DEBUG
@@ -911,7 +906,7 @@ snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_valida
      /*
      we found a suitable next node,
      now we have to check if a inner MIB is located between the searched OID and the resulting OID.
-      this is possible because MIB's may be located anywhere in the global tree, that means also in
+      this is possible because MIB's may be located anywhere in the global tree, that means also in 
      the subtree of another MIB (e.g. if searched OID is .2 and resulting OID is .4, then another
      MIB having .3 as root node may exist)
      */
@@ -980,17 +975,17 @@ snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_valida
 *
 */
 const struct snmp_node *
-snmp_mib_tree_resolve_exact(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, u8_t *oid_instance_len)
+snmp_mib_tree_resolve_exact(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, u8_t* oid_instance_len)
 {
-  const struct snmp_node *const *node = &mib->root_node;
+  const struct snmp_node* const* node = &mib->root_node;
  u8_t oid_offset = mib->base_oid_len;

  while ((oid_offset < oid_len) && ((*node)->node_type == SNMP_NODE_TREE)) {
    /* search for matching sub node */
    u32_t subnode_oid = *(oid + oid_offset);

-    u32_t i = (*(const struct snmp_tree_node * const *)node)->subnode_count;
-    node    = (*(const struct snmp_tree_node * const *)node)->subnodes;
+    u32_t i = (*(const struct snmp_tree_node* const*)node)->subnode_count;
+    node    = (*(const struct snmp_tree_node* const*)node)->subnodes;
    while ((i > 0) && ((*node)->oid != subnode_oid)) {
      node++;
      i--;
@@ -1013,12 +1008,12 @@ snmp_mib_tree_resolve_exact(const struct snmp_mib *mib, const u32_t *oid, u8_t o
  return NULL;
 }

-const struct snmp_node *
-snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, struct snmp_obj_id *oidret)
+const struct snmp_node*
+snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, struct snmp_obj_id* oidret)
 {
  u8_t  oid_offset = mib->base_oid_len;
-  const struct snmp_node *const *node;
-  const struct snmp_tree_node *node_stack[SNMP_MAX_OBJ_ID_LEN];
+  const struct snmp_node* const* node;
+  const struct snmp_tree_node* node_stack[SNMP_MAX_OBJ_ID_LEN];
  s32_t nsi = 0; /* NodeStackIndex */
  u32_t subnode_oid;

@@ -1028,7 +1023,7 @@ snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oi
  }

  /* first build node stack related to passed oid (as far as possible), then go backwards to determine the next node */
-  node_stack[nsi] = (const struct snmp_tree_node *)(const void *)mib->root_node;
+  node_stack[nsi] = (const struct snmp_tree_node*)(const void*)mib->root_node;
  while (oid_offset < oid_len) {
    /* search for matching sub node */
    u32_t i = node_stack[nsi]->subnode_count;
@@ -1046,7 +1041,7 @@ snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oi
      break;
    }
    nsi++;
-    node_stack[nsi] = (const struct snmp_tree_node *)(const void *)(*node);
+    node_stack[nsi] = (const struct snmp_tree_node*)(const void*)(*node);

    oid_offset++;
  }
@@ -1060,7 +1055,7 @@ snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oi
  }

  while (nsi >= 0) {
-    const struct snmp_node *subnode = NULL;
+    const struct snmp_node* subnode = NULL;

    /* find next node on current level */
    s32_t i        = node_stack[nsi]->subnode_count;
@@ -1085,7 +1080,7 @@ snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oi
      if (subnode->node_type == SNMP_NODE_TREE) {
        /* next is a tree node, go into it and start searching */
        nsi++;
-        node_stack[nsi] = (const struct snmp_tree_node *)(const void *)subnode;
+        node_stack[nsi] = (const struct snmp_tree_node*)(const void*)subnode;
        subnode_oid = 0;
      } else {
        /* we found a leaf node -> fill oidret and return it */
@@ -1111,8 +1106,8 @@ snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oi
 /** initialize struct next_oid_state using this function before passing it to next_oid_check */
 void
 snmp_next_oid_init(struct snmp_next_oid_state *state,
-                   const u32_t *start_oid, u8_t start_oid_len,
-                   u32_t *next_oid_buf, u8_t next_oid_max_len)
+  const u32_t *start_oid, u8_t start_oid_len,
+  u32_t *next_oid_buf, u8_t next_oid_max_len)
 {
  state->start_oid        = start_oid;
  state->start_oid_len    = start_oid_len;
@@ -1126,7 +1121,7 @@ snmp_next_oid_init(struct snmp_next_oid_state *state,
 this methid is intended if the complete OID is not yet known but it is very expensive to build it up,
 so it is possible to test the starting part before building up the complete oid and pass it to snmp_next_oid_check()*/
 u8_t
-snmp_next_oid_precheck(struct snmp_next_oid_state *state, const u32_t *oid, u8_t oid_len)
+snmp_next_oid_precheck(struct snmp_next_oid_state *state, const u32_t *oid, const u8_t oid_len)
 {
  if (state->status != SNMP_NEXT_OID_STATUS_BUF_TO_SMALL) {
    u8_t start_oid_len = (oid_len < state->start_oid_len) ? oid_len : state->start_oid_len;
@@ -1135,7 +1130,7 @@ snmp_next_oid_precheck(struct snmp_next_oid_state *state, const u32_t *oid, u8_t
    if (snmp_oid_compare(oid, oid_len, state->start_oid, start_oid_len) >= 0) {
      /* check if new oid is located closer to start oid than current closest oid */
      if ((state->status == SNMP_NEXT_OID_STATUS_NO_MATCH) ||
-          (snmp_oid_compare(oid, oid_len, state->next_oid, state->next_oid_len) < 0)) {
+        (snmp_oid_compare(oid, oid_len, state->next_oid, state->next_oid_len) < 0)) {
        return 1;
      }
    }
@@ -1146,7 +1141,7 @@ snmp_next_oid_precheck(struct snmp_next_oid_state *state, const u32_t *oid, u8_t

 /** checks the passed OID if it is a candidate to be the next one (get_next); returns !=0 if passed oid is currently closest, otherwise 0 */
 u8_t
-snmp_next_oid_check(struct snmp_next_oid_state *state, const u32_t *oid, u8_t oid_len, void *reference)
+snmp_next_oid_check(struct snmp_next_oid_state *state, const u32_t *oid, const u8_t oid_len, void* reference)
 {
  /* do not overwrite a fail result */
  if (state->status != SNMP_NEXT_OID_STATUS_BUF_TO_SMALL) {
@@ -1154,7 +1149,7 @@ snmp_next_oid_check(struct snmp_next_oid_state *state, const u32_t *oid, u8_t oi
    if (snmp_oid_compare(oid, oid_len, state->start_oid, state->start_oid_len) > 0) {
      /* check if new oid is located closer to start oid than current closest oid */
      if ((state->status == SNMP_NEXT_OID_STATUS_NO_MATCH) ||
-          (snmp_oid_compare(oid, oid_len, state->next_oid, state->next_oid_len) < 0)) {
+        (snmp_oid_compare(oid, oid_len, state->next_oid, state->next_oid_len) < 0)) {
        if (oid_len <= state->next_oid_max_len) {
          MEMCPY(state->next_oid, oid, oid_len * sizeof(u32_t));
          state->next_oid_len = oid_len;
@@ -1190,7 +1185,7 @@ snmp_oid_in_range(const u32_t *oid_in, u8_t oid_len, const struct snmp_oid_range
 }

 snmp_err_t
-snmp_set_test_ok(struct snmp_node_instance *instance, u16_t value_len, void *value)
+snmp_set_test_ok(struct snmp_node_instance* instance, u16_t value_len, void* value)
 {
  LWIP_UNUSED_ARG(instance);
  LWIP_UNUSED_ARG(value_len);
@@ -1233,7 +1228,8 @@ snmp_decode_bits(const u8_t *buf, u32_t buf_len, u32_t *bit_value)
        }
        bits_processed++;
        b <<= 1;
-      } while ((bits_processed & 0x07) != 0); /* &0x07 -> % 8 */
+      }
+      while ((bits_processed & 0x07) != 0); /* &0x07 -> % 8 */
    } else {
      bits_processed += 8;
    }
--- a/src/apps/snmp/snmp_core_priv.h
+++ b/src/apps/snmp/snmp_core_priv.h
@@ -55,24 +55,17 @@ extern "C" {
 */
 #define SNMP_ERR_TOOBIG               1
 #define SNMP_ERR_AUTHORIZATIONERROR   16
-
-#define SNMP_ERR_UNKNOWN_ENGINEID     30
-#define SNMP_ERR_UNKNOWN_SECURITYNAME 31
-#define SNMP_ERR_UNSUPPORTED_SECLEVEL 32
-#define SNMP_ERR_NOTINTIMEWINDOW      33
-#define SNMP_ERR_DECRYIPTION_ERROR    34
-
 #define SNMP_ERR_NOSUCHOBJECT         SNMP_VARBIND_EXCEPTION_OFFSET + SNMP_ASN1_CONTEXT_VARBIND_NO_SUCH_OBJECT
 #define SNMP_ERR_ENDOFMIBVIEW         SNMP_VARBIND_EXCEPTION_OFFSET + SNMP_ASN1_CONTEXT_VARBIND_END_OF_MIB_VIEW


-const struct snmp_node *snmp_mib_tree_resolve_exact(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, u8_t *oid_instance_len);
-const struct snmp_node *snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, struct snmp_obj_id *oidret);
+const struct snmp_node* snmp_mib_tree_resolve_exact(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, u8_t* oid_instance_len);
+const struct snmp_node* snmp_mib_tree_resolve_next(const struct snmp_mib *mib, const u32_t *oid, u8_t oid_len, struct snmp_obj_id* oidret);

-typedef u8_t (*snmp_validate_node_instance_method)(struct snmp_node_instance *, void *);
+typedef u8_t (*snmp_validate_node_instance_method)(struct snmp_node_instance*, void*);

-u8_t snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node_instance *node_instance);
-u8_t snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_validate_node_instance_method validate_node_instance_method, void *validate_node_instance_arg, struct snmp_obj_id *node_oid, struct snmp_node_instance *node_instance);
+u8_t snmp_get_node_instance_from_oid(const u32_t *oid, u8_t oid_len, struct snmp_node_instance* node_instance);
+u8_t snmp_get_next_node_instance_from_oid(const u32_t *oid, u8_t oid_len, snmp_validate_node_instance_method validate_node_instance_method, void* validate_node_instance_arg, struct snmp_obj_id* node_oid, struct snmp_node_instance* node_instance);

 #ifdef __cplusplus
 }
--- a/src/apps/snmp/snmp_mib2.c
+++ b/src/apps/snmp/snmp_mib2.c
@@ -59,7 +59,7 @@
 #include "lwip/tcpip.h"
 #include "lwip/priv/tcpip_priv.h"
 void
-snmp_mib2_lwip_synchronizer(snmp_threadsync_called_fn fn, void *arg)
+snmp_mib2_lwip_synchronizer(snmp_threadsync_called_fn fn, void* arg)
 {
 #if LWIP_TCPIP_CORE_LOCKING
  LOCK_TCPIP_CORE();
@@ -87,7 +87,7 @@ extern const struct snmp_scalar_array_node snmp_mib2_system_node;
 extern const struct snmp_tree_node snmp_mib2_at_root;
 extern const struct snmp_tree_node snmp_mib2_ip_root;

-static const struct snmp_node *const mib2_nodes[] = {
+static const struct snmp_node* const mib2_nodes[] = {
  &snmp_mib2_system_node.node.node,
  &snmp_mib2_interface_root.node,
 #if LWIP_ARP && LWIP_IPV4
@@ -110,7 +110,7 @@ static const struct snmp_node *const mib2_nodes[] = {

 static const struct snmp_tree_node mib2_root = SNMP_CREATE_TREE_NODE(1, mib2_nodes);

-static const u32_t  mib2_base_oid_arr[] = { 1, 3, 6, 1, 2, 1 };
+static const u32_t  mib2_base_oid_arr[] = { 1,3,6,1,2,1 };
 const struct snmp_mib mib2 = SNMP_MIB_CREATE(mib2_base_oid_arr, &mib2_root.node);

 #endif /* LWIP_SNMP && SNMP_LWIP_MIB2 */
--- a/src/apps/snmp/snmp_mib2_icmp.c
+++ b/src/apps/snmp/snmp_mib2_icmp.c
@@ -58,90 +58,90 @@
 static s16_t
 icmp_get_value(const struct snmp_scalar_array_node_def *node, void *value)
 {
-  u32_t *uint_ptr = (u32_t *)value;
+  u32_t *uint_ptr = (u32_t*)value;

  switch (node->oid) {
-    case 1: /* icmpInMsgs */
-      *uint_ptr = STATS_GET(mib2.icmpinmsgs);
-      return sizeof(*uint_ptr);
-    case 2: /* icmpInErrors */
-      *uint_ptr = STATS_GET(mib2.icmpinerrors);
-      return sizeof(*uint_ptr);
-    case 3: /* icmpInDestUnreachs */
-      *uint_ptr = STATS_GET(mib2.icmpindestunreachs);
-      return sizeof(*uint_ptr);
-    case 4: /* icmpInTimeExcds */
-      *uint_ptr = STATS_GET(mib2.icmpintimeexcds);
-      return sizeof(*uint_ptr);
-    case 5: /* icmpInParmProbs */
-      *uint_ptr = STATS_GET(mib2.icmpinparmprobs);
-      return sizeof(*uint_ptr);
-    case 6: /* icmpInSrcQuenchs */
-      *uint_ptr = STATS_GET(mib2.icmpinsrcquenchs);
-      return sizeof(*uint_ptr);
-    case 7: /* icmpInRedirects */
-      *uint_ptr = STATS_GET(mib2.icmpinredirects);
-      return sizeof(*uint_ptr);
-    case 8: /* icmpInEchos */
-      *uint_ptr = STATS_GET(mib2.icmpinechos);
-      return sizeof(*uint_ptr);
-    case 9: /* icmpInEchoReps */
-      *uint_ptr = STATS_GET(mib2.icmpinechoreps);
-      return sizeof(*uint_ptr);
-    case 10: /* icmpInTimestamps */
-      *uint_ptr = STATS_GET(mib2.icmpintimestamps);
-      return sizeof(*uint_ptr);
-    case 11: /* icmpInTimestampReps */
-      *uint_ptr = STATS_GET(mib2.icmpintimestampreps);
-      return sizeof(*uint_ptr);
-    case 12: /* icmpInAddrMasks */
-      *uint_ptr = STATS_GET(mib2.icmpinaddrmasks);
-      return sizeof(*uint_ptr);
-    case 13: /* icmpInAddrMaskReps */
-      *uint_ptr = STATS_GET(mib2.icmpinaddrmaskreps);
-      return sizeof(*uint_ptr);
-    case 14: /* icmpOutMsgs */
-      *uint_ptr = STATS_GET(mib2.icmpoutmsgs);
-      return sizeof(*uint_ptr);
-    case 15: /* icmpOutErrors */
-      *uint_ptr = STATS_GET(mib2.icmpouterrors);
-      return sizeof(*uint_ptr);
-    case 16: /* icmpOutDestUnreachs */
-      *uint_ptr = STATS_GET(mib2.icmpoutdestunreachs);
-      return sizeof(*uint_ptr);
-    case 17: /* icmpOutTimeExcds */
-      *uint_ptr = STATS_GET(mib2.icmpouttimeexcds);
-      return sizeof(*uint_ptr);
-    case 18: /* icmpOutParmProbs: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 19: /* icmpOutSrcQuenchs: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 20: /* icmpOutRedirects: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 21: /* icmpOutEchos */
-      *uint_ptr = STATS_GET(mib2.icmpoutechos);
-      return sizeof(*uint_ptr);
-    case 22: /* icmpOutEchoReps */
-      *uint_ptr = STATS_GET(mib2.icmpoutechoreps);
-      return sizeof(*uint_ptr);
-    case 23: /* icmpOutTimestamps: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 24: /* icmpOutTimestampReps: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 25: /* icmpOutAddrMasks: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    case 26: /* icmpOutAddrMaskReps: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("icmp_get_value(): unknown id: %"S32_F"\n", node->oid));
-      break;
+  case 1: /* icmpInMsgs */
+    *uint_ptr = STATS_GET(mib2.icmpinmsgs);
+    return sizeof(*uint_ptr);
+  case 2: /* icmpInErrors */
+    *uint_ptr = STATS_GET(mib2.icmpinerrors);
+    return sizeof(*uint_ptr);
+  case 3: /* icmpInDestUnreachs */
+    *uint_ptr = STATS_GET(mib2.icmpindestunreachs);
+    return sizeof(*uint_ptr);
+  case 4: /* icmpInTimeExcds */
+    *uint_ptr = STATS_GET(mib2.icmpintimeexcds);
+    return sizeof(*uint_ptr);
+  case 5: /* icmpInParmProbs */
+    *uint_ptr = STATS_GET(mib2.icmpinparmprobs);
+    return sizeof(*uint_ptr);
+  case 6: /* icmpInSrcQuenchs */
+    *uint_ptr = STATS_GET(mib2.icmpinsrcquenchs);
+    return sizeof(*uint_ptr);
+  case 7: /* icmpInRedirects */
+    *uint_ptr = STATS_GET(mib2.icmpinredirects);
+    return sizeof(*uint_ptr);
+  case 8: /* icmpInEchos */
+    *uint_ptr = STATS_GET(mib2.icmpinechos);
+    return sizeof(*uint_ptr);
+  case 9: /* icmpInEchoReps */
+    *uint_ptr = STATS_GET(mib2.icmpinechoreps);
+    return sizeof(*uint_ptr);
+  case 10: /* icmpInTimestamps */
+    *uint_ptr = STATS_GET(mib2.icmpintimestamps);
+    return sizeof(*uint_ptr);
+  case 11: /* icmpInTimestampReps */
+    *uint_ptr = STATS_GET(mib2.icmpintimestampreps);
+    return sizeof(*uint_ptr);
+  case 12: /* icmpInAddrMasks */
+    *uint_ptr = STATS_GET(mib2.icmpinaddrmasks);
+    return sizeof(*uint_ptr);
+  case 13: /* icmpInAddrMaskReps */
+    *uint_ptr = STATS_GET(mib2.icmpinaddrmaskreps);
+    return sizeof(*uint_ptr);
+  case 14: /* icmpOutMsgs */
+    *uint_ptr = STATS_GET(mib2.icmpoutmsgs);
+    return sizeof(*uint_ptr);
+  case 15: /* icmpOutErrors */
+    *uint_ptr = STATS_GET(mib2.icmpouterrors);
+    return sizeof(*uint_ptr);
+  case 16: /* icmpOutDestUnreachs */
+    *uint_ptr = STATS_GET(mib2.icmpoutdestunreachs);
+    return sizeof(*uint_ptr);
+  case 17: /* icmpOutTimeExcds */
+    *uint_ptr = STATS_GET(mib2.icmpouttimeexcds);
+    return sizeof(*uint_ptr);
+  case 18: /* icmpOutParmProbs: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 19: /* icmpOutSrcQuenchs: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 20: /* icmpOutRedirects: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 21: /* icmpOutEchos */
+    *uint_ptr = STATS_GET(mib2.icmpoutechos);
+    return sizeof(*uint_ptr);
+  case 22: /* icmpOutEchoReps */
+    *uint_ptr = STATS_GET(mib2.icmpoutechoreps);
+    return sizeof(*uint_ptr);
+  case 23: /* icmpOutTimestamps: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 24: /* icmpOutTimestampReps: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 25: /* icmpOutAddrMasks: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  case 26: /* icmpOutAddrMaskReps: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("icmp_get_value(): unknown id: %"S32_F"\n", node->oid));
+    break;
  }

  return 0;
--- a/src/apps/snmp/snmp_mib2_interfaces.c
+++ b/src/apps/snmp/snmp_mib2_interfaces.c
@@ -59,15 +59,16 @@
 /* --- interfaces .1.3.6.1.2.1.2 ----------------------------------------------------- */

 static s16_t
-interfaces_get_value(struct snmp_node_instance *instance, void *value)
+interfaces_get_value(struct snmp_node_instance* instance, void* value)
 {
  if (instance->node->oid == 1) {
-    s32_t *sint_ptr = (s32_t *)value;
+    s32_t *sint_ptr = (s32_t*)value;
    s32_t num_netifs = 0;

-    struct netif *netif;
-    NETIF_FOREACH(netif) {
+    struct netif *netif = netif_list;
+    while (netif != NULL) {
      num_netifs++;
+      netif = netif->next;
    }

    *sint_ptr = num_netifs;
@@ -92,7 +93,7 @@ static const u8_t iftable_ifAdminStatus_lowerLayerDown = 7;
 static const u8_t iftable_ifAdminStatus_down           = 2;

 static snmp_err_t
-interfaces_Table_get_cell_instance(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, struct snmp_node_instance *cell_instance)
+interfaces_Table_get_cell_instance(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, struct snmp_node_instance* cell_instance)
 {
  u32_t ifIndex;
  struct netif *netif;
@@ -108,12 +109,14 @@ interfaces_Table_get_cell_instance(const u32_t *column, const u32_t *row_oid, u8
  ifIndex = row_oid[0];

  /* find netif with index */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    if (netif_to_num(netif) == ifIndex) {
      /* store netif pointer for subsequent operations (get/test/set) */
      cell_instance->reference.ptr = netif;
      return SNMP_ERR_NOERROR;
    }
+    netif = netif->next;
  }

  /* not found */
@@ -121,7 +124,7 @@ interfaces_Table_get_cell_instance(const u32_t *column, const u32_t *row_oid, u8
 }

 static snmp_err_t
-interfaces_Table_get_next_cell_instance(const u32_t *column, struct snmp_obj_id *row_oid, struct snmp_node_instance *cell_instance)
+interfaces_Table_get_next_cell_instance(const u32_t* column, struct snmp_obj_id* row_oid, struct snmp_node_instance* cell_instance)
 {
  struct netif *netif;
  struct snmp_next_oid_state state;
@@ -133,12 +136,15 @@ interfaces_Table_get_next_cell_instance(const u32_t *column, struct snmp_obj_id
  snmp_next_oid_init(&state, row_oid->id, row_oid->len, result_temp, LWIP_ARRAYSIZE(interfaces_Table_oid_ranges));

  /* iterate over all possible OIDs to find the next one */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    u32_t test_oid[LWIP_ARRAYSIZE(interfaces_Table_oid_ranges)];
    test_oid[0] = netif_to_num(netif);

    /* check generated OID: is it a candidate for the next one? */
    snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(interfaces_Table_oid_ranges), netif);
+
+    netif = netif->next;
  }

  /* did we find a next one? */
@@ -154,117 +160,118 @@ interfaces_Table_get_next_cell_instance(const u32_t *column, struct snmp_obj_id
 }

 static s16_t
-interfaces_Table_get_value(struct snmp_node_instance *instance, void *value)
+interfaces_Table_get_value(struct snmp_node_instance* instance, void* value)
 {
-  struct netif *netif = (struct netif *)instance->reference.ptr;
-  u32_t *value_u32 = (u32_t *)value;
-  s32_t *value_s32 = (s32_t *)value;
+  struct netif *netif = (struct netif*)instance->reference.ptr;
+  u32_t* value_u32 = (u32_t*)value;
+  s32_t* value_s32 = (s32_t*)value;
  u16_t value_len;

-  switch (SNMP_TABLE_GET_COLUMN_FROM_OID(instance->instance_oid.id)) {
-    case 1: /* ifIndex */
-      *value_s32 = netif_to_num(netif);
-      value_len = sizeof(*value_s32);
-      break;
-    case 2: /* ifDescr */
-      value_len = sizeof(netif->name);
-      MEMCPY(value, netif->name, value_len);
-      break;
-    case 3: /* ifType */
-      *value_s32 = netif->link_type;
-      value_len = sizeof(*value_s32);
-      break;
-    case 4: /* ifMtu */
-      *value_s32 = netif->mtu;
-      value_len = sizeof(*value_s32);
-      break;
-    case 5: /* ifSpeed */
-      *value_u32 = netif->link_speed;
-      value_len = sizeof(*value_u32);
-      break;
-    case 6: /* ifPhysAddress */
-      value_len = sizeof(netif->hwaddr);
-      MEMCPY(value, &netif->hwaddr, value_len);
-      break;
-    case 7: /* ifAdminStatus */
-      if (netif_is_up(netif)) {
-        *value_s32 = iftable_ifOperStatus_up;
+  switch (SNMP_TABLE_GET_COLUMN_FROM_OID(instance->instance_oid.id))
+  {
+  case 1: /* ifIndex */
+    *value_s32 = netif_to_num(netif);
+    value_len = sizeof(*value_s32);
+    break;
+  case 2: /* ifDescr */
+    value_len = sizeof(netif->name);
+    MEMCPY(value, netif->name, value_len);
+    break;
+  case 3: /* ifType */
+    *value_s32 = netif->link_type;
+    value_len = sizeof(*value_s32);
+    break;
+  case 4: /* ifMtu */
+    *value_s32 = netif->mtu;
+    value_len = sizeof(*value_s32);
+    break;
+  case 5: /* ifSpeed */
+    *value_u32 = netif->link_speed;
+    value_len = sizeof(*value_u32);
+    break;
+  case 6: /* ifPhysAddress */
+    value_len = sizeof(netif->hwaddr);
+    MEMCPY(value, &netif->hwaddr, value_len);
+    break;
+  case 7: /* ifAdminStatus */
+    if (netif_is_up(netif)) {
+      *value_s32 = iftable_ifOperStatus_up;
+    } else {
+      *value_s32 = iftable_ifOperStatus_down;
+    }
+    value_len = sizeof(*value_s32);
+    break;
+  case 8: /* ifOperStatus */
+    if (netif_is_up(netif)) {
+      if (netif_is_link_up(netif)) {
+        *value_s32 = iftable_ifAdminStatus_up;
      } else {
-        *value_s32 = iftable_ifOperStatus_down;
+        *value_s32 = iftable_ifAdminStatus_lowerLayerDown;
      }
-      value_len = sizeof(*value_s32);
-      break;
-    case 8: /* ifOperStatus */
-      if (netif_is_up(netif)) {
-        if (netif_is_link_up(netif)) {
-          *value_s32 = iftable_ifAdminStatus_up;
-        } else {
-          *value_s32 = iftable_ifAdminStatus_lowerLayerDown;
-        }
-      } else {
-        *value_s32 = iftable_ifAdminStatus_down;
-      }
-      value_len = sizeof(*value_s32);
-      break;
-    case 9: /* ifLastChange */
-      *value_u32 = netif->ts;
-      value_len = sizeof(*value_u32);
-      break;
-    case 10: /* ifInOctets */
-      *value_u32 = netif->mib2_counters.ifinoctets;
-      value_len = sizeof(*value_u32);
-      break;
-    case 11: /* ifInUcastPkts */
-      *value_u32 = netif->mib2_counters.ifinucastpkts;
-      value_len = sizeof(*value_u32);
-      break;
-    case 12: /* ifInNUcastPkts */
-      *value_u32 = netif->mib2_counters.ifinnucastpkts;
-      value_len = sizeof(*value_u32);
-      break;
-    case 13: /* ifInDiscards */
-      *value_u32 = netif->mib2_counters.ifindiscards;
-      value_len = sizeof(*value_u32);
-      break;
-    case 14: /* ifInErrors */
-      *value_u32 = netif->mib2_counters.ifinerrors;
-      value_len = sizeof(*value_u32);
-      break;
-    case 15: /* ifInUnkownProtos */
-      *value_u32 = netif->mib2_counters.ifinunknownprotos;
-      value_len = sizeof(*value_u32);
-      break;
-    case 16: /* ifOutOctets */
-      *value_u32 = netif->mib2_counters.ifoutoctets;
-      value_len = sizeof(*value_u32);
-      break;
-    case 17: /* ifOutUcastPkts */
-      *value_u32 = netif->mib2_counters.ifoutucastpkts;
-      value_len = sizeof(*value_u32);
-      break;
-    case 18: /* ifOutNUcastPkts */
-      *value_u32 = netif->mib2_counters.ifoutnucastpkts;
-      value_len = sizeof(*value_u32);
-      break;
-    case 19: /* ifOutDiscarts */
-      *value_u32 = netif->mib2_counters.ifoutdiscards;
-      value_len = sizeof(*value_u32);
-      break;
-    case 20: /* ifOutErrors */
-      *value_u32 = netif->mib2_counters.ifouterrors;
-      value_len = sizeof(*value_u32);
-      break;
-    case 21: /* ifOutQLen */
-      *value_u32 = iftable_ifOutQLen;
-      value_len = sizeof(*value_u32);
-      break;
-    /** @note returning zeroDotZero (0.0) no media specific MIB support */
-    case 22: /* ifSpecific */
-      value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
-      MEMCPY(value, snmp_zero_dot_zero.id, value_len);
-      break;
-    default:
-      return 0;
+    } else {
+      *value_s32 = iftable_ifAdminStatus_down;
+    }
+    value_len = sizeof(*value_s32);
+    break;
+  case 9: /* ifLastChange */
+    *value_u32 = netif->ts;
+    value_len = sizeof(*value_u32);
+    break;
+  case 10: /* ifInOctets */
+    *value_u32 = netif->mib2_counters.ifinoctets;
+    value_len = sizeof(*value_u32);
+    break;
+  case 11: /* ifInUcastPkts */
+    *value_u32 = netif->mib2_counters.ifinucastpkts;
+    value_len = sizeof(*value_u32);
+    break;
+  case 12: /* ifInNUcastPkts */
+    *value_u32 = netif->mib2_counters.ifinnucastpkts;
+    value_len = sizeof(*value_u32);
+    break;
+  case 13: /* ifInDiscards */
+    *value_u32 = netif->mib2_counters.ifindiscards;
+    value_len = sizeof(*value_u32);
+    break;
+  case 14: /* ifInErrors */
+    *value_u32 = netif->mib2_counters.ifinerrors;
+    value_len = sizeof(*value_u32);
+    break;
+  case 15: /* ifInUnkownProtos */
+    *value_u32 = netif->mib2_counters.ifinunknownprotos;
+    value_len = sizeof(*value_u32);
+    break;
+  case 16: /* ifOutOctets */
+    *value_u32 = netif->mib2_counters.ifoutoctets;
+    value_len = sizeof(*value_u32);
+    break;
+  case 17: /* ifOutUcastPkts */
+    *value_u32 = netif->mib2_counters.ifoutucastpkts;
+    value_len = sizeof(*value_u32);
+    break;
+  case 18: /* ifOutNUcastPkts */
+    *value_u32 = netif->mib2_counters.ifoutnucastpkts;
+    value_len = sizeof(*value_u32);
+    break;
+  case 19: /* ifOutDiscarts */
+    *value_u32 = netif->mib2_counters.ifoutdiscards;
+    value_len = sizeof(*value_u32);
+    break;
+  case 20: /* ifOutErrors */
+    *value_u32 = netif->mib2_counters.ifouterrors;
+    value_len = sizeof(*value_u32);
+    break;
+  case 21: /* ifOutQLen */
+    *value_u32 = iftable_ifOutQLen;
+    value_len = sizeof(*value_u32);
+    break;
+  /** @note returning zeroDotZero (0.0) no media specific MIB support */
+  case 22: /* ifSpecific */
+    value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
+    MEMCPY(value, snmp_zero_dot_zero.id, value_len);
+    break;
+  default:
+    return 0;
  }

  return value_len;
@@ -273,9 +280,9 @@ interfaces_Table_get_value(struct snmp_node_instance *instance, void *value)
 #if !SNMP_SAFE_REQUESTS

 static snmp_err_t
-interfaces_Table_set_test(struct snmp_node_instance *instance, u16_t len, void *value)
+interfaces_Table_set_test(struct snmp_node_instance* instance, u16_t len, void *value)
 {
-  s32_t *sint_ptr = (s32_t *)value;
+  s32_t *sint_ptr = (s32_t*)value;

  /* stack should never call this method for another column,
  because all other columns are set to readonly */
@@ -290,10 +297,10 @@ interfaces_Table_set_test(struct snmp_node_instance *instance, u16_t len, void *
 }

 static snmp_err_t
-interfaces_Table_set_value(struct snmp_node_instance *instance, u16_t len, void *value)
+interfaces_Table_set_value(struct snmp_node_instance* instance, u16_t len, void *value)
 {
-  struct netif *netif = (struct netif *)instance->reference.ptr;
-  s32_t *sint_ptr = (s32_t *)value;
+  struct netif *netif = (struct netif*)instance->reference.ptr;
+  s32_t *sint_ptr = (s32_t*)value;

  /* stack should never call this method for another column,
  because all other columns are set to readonly */
@@ -344,21 +351,21 @@ static const struct snmp_table_col_def interfaces_Table_columns[] = {

 #if !SNMP_SAFE_REQUESTS
 static const struct snmp_table_node interfaces_Table = SNMP_TABLE_CREATE(
-      2, interfaces_Table_columns,
-      interfaces_Table_get_cell_instance, interfaces_Table_get_next_cell_instance,
-      interfaces_Table_get_value, interfaces_Table_set_test, interfaces_Table_set_value);
+  2, interfaces_Table_columns,
+  interfaces_Table_get_cell_instance, interfaces_Table_get_next_cell_instance,
+  interfaces_Table_get_value, interfaces_Table_set_test, interfaces_Table_set_value);
 #else
 static const struct snmp_table_node interfaces_Table = SNMP_TABLE_CREATE(
-      2, interfaces_Table_columns,
-      interfaces_Table_get_cell_instance, interfaces_Table_get_next_cell_instance,
-      interfaces_Table_get_value, NULL, NULL);
+  2, interfaces_Table_columns,
+  interfaces_Table_get_cell_instance, interfaces_Table_get_next_cell_instance,
+  interfaces_Table_get_value, NULL, NULL);
 #endif

 /* the following nodes access variables in LWIP stack from SNMP worker thread and must therefore be synced to LWIP (TCPIP) thread */
 CREATE_LWIP_SYNC_NODE(1, interfaces_Number)
 CREATE_LWIP_SYNC_NODE(2, interfaces_Table)

-static const struct snmp_node *const interface_nodes[] = {
+static const struct snmp_node* const interface_nodes[] = {
  &SYNC_NODE_NAME(interfaces_Number).node.node,
  &SYNC_NODE_NAME(interfaces_Table).node.node
 };
--- a/src/apps/snmp/snmp_mib2_ip.c
+++ b/src/apps/snmp/snmp_mib2_ip.c
@@ -59,85 +59,85 @@
 /* --- ip .1.3.6.1.2.1.4 ----------------------------------------------------- */

 static s16_t
-ip_get_value(struct snmp_node_instance *instance, void *value)
+ip_get_value(struct snmp_node_instance* instance, void* value)
 {
-  s32_t *sint_ptr = (s32_t *)value;
-  u32_t *uint_ptr = (u32_t *)value;
+  s32_t* sint_ptr = (s32_t*)value;
+  u32_t* uint_ptr = (u32_t*)value;

  switch (instance->node->oid) {
-    case 1: /* ipForwarding */
+  case 1: /* ipForwarding */
 #if IP_FORWARD
-      /* forwarding */
-      *sint_ptr = 1;
+    /* forwarding */
+    *sint_ptr = 1;
 #else
-      /* not-forwarding */
-      *sint_ptr = 2;
+    /* not-forwarding */
+    *sint_ptr = 2;
 #endif
-      return sizeof(*sint_ptr);
-    case 2: /* ipDefaultTTL */
-      *sint_ptr = IP_DEFAULT_TTL;
-      return sizeof(*sint_ptr);
-    case 3: /* ipInReceives */
-      *uint_ptr = STATS_GET(mib2.ipinreceives);
-      return sizeof(*uint_ptr);
-    case 4: /* ipInHdrErrors */
-      *uint_ptr = STATS_GET(mib2.ipinhdrerrors);
-      return sizeof(*uint_ptr);
-    case 5: /* ipInAddrErrors */
-      *uint_ptr = STATS_GET(mib2.ipinaddrerrors);
-      return sizeof(*uint_ptr);
-    case 6: /* ipForwDatagrams */
-      *uint_ptr = STATS_GET(mib2.ipforwdatagrams);
-      return sizeof(*uint_ptr);
-    case 7: /* ipInUnknownProtos */
-      *uint_ptr = STATS_GET(mib2.ipinunknownprotos);
-      return sizeof(*uint_ptr);
-    case 8: /* ipInDiscards */
-      *uint_ptr = STATS_GET(mib2.ipindiscards);
-      return sizeof(*uint_ptr);
-    case 9: /* ipInDelivers */
-      *uint_ptr = STATS_GET(mib2.ipindelivers);
-      return sizeof(*uint_ptr);
-    case 10: /* ipOutRequests */
-      *uint_ptr = STATS_GET(mib2.ipoutrequests);
-      return sizeof(*uint_ptr);
-    case 11: /* ipOutDiscards */
-      *uint_ptr = STATS_GET(mib2.ipoutdiscards);
-      return sizeof(*uint_ptr);
-    case 12: /* ipOutNoRoutes */
-      *uint_ptr = STATS_GET(mib2.ipoutnoroutes);
-      return sizeof(*uint_ptr);
-    case 13: /* ipReasmTimeout */
+    return sizeof(*sint_ptr);
+  case 2: /* ipDefaultTTL */
+    *sint_ptr = IP_DEFAULT_TTL;
+    return sizeof(*sint_ptr);
+  case 3: /* ipInReceives */
+    *uint_ptr = STATS_GET(mib2.ipinreceives);
+    return sizeof(*uint_ptr);
+  case 4: /* ipInHdrErrors */
+    *uint_ptr = STATS_GET(mib2.ipinhdrerrors);
+    return sizeof(*uint_ptr);
+  case 5: /* ipInAddrErrors */
+    *uint_ptr = STATS_GET(mib2.ipinaddrerrors);
+    return sizeof(*uint_ptr);
+  case 6: /* ipForwDatagrams */
+    *uint_ptr = STATS_GET(mib2.ipforwdatagrams);
+    return sizeof(*uint_ptr);
+  case 7: /* ipInUnknownProtos */
+    *uint_ptr = STATS_GET(mib2.ipinunknownprotos);
+    return sizeof(*uint_ptr);
+  case 8: /* ipInDiscards */
+    *uint_ptr = STATS_GET(mib2.ipindiscards);
+    return sizeof(*uint_ptr);
+  case 9: /* ipInDelivers */
+    *uint_ptr = STATS_GET(mib2.ipindelivers);
+    return sizeof(*uint_ptr);
+  case 10: /* ipOutRequests */
+    *uint_ptr = STATS_GET(mib2.ipoutrequests);
+    return sizeof(*uint_ptr);
+  case 11: /* ipOutDiscards */
+    *uint_ptr = STATS_GET(mib2.ipoutdiscards);
+    return sizeof(*uint_ptr);
+  case 12: /* ipOutNoRoutes */
+    *uint_ptr = STATS_GET(mib2.ipoutnoroutes);
+    return sizeof(*uint_ptr);
+  case 13: /* ipReasmTimeout */
 #if IP_REASSEMBLY
-      *sint_ptr = IP_REASS_MAXAGE;
+    *sint_ptr = IP_REASS_MAXAGE;
 #else
-      *sint_ptr = 0;
+    *sint_ptr = 0;
 #endif
-      return sizeof(*sint_ptr);
-    case 14: /* ipReasmReqds */
-      *uint_ptr = STATS_GET(mib2.ipreasmreqds);
-      return sizeof(*uint_ptr);
-    case 15: /* ipReasmOKs */
-      *uint_ptr = STATS_GET(mib2.ipreasmoks);
-      return sizeof(*uint_ptr);
-    case 16: /* ipReasmFails */
-      *uint_ptr = STATS_GET(mib2.ipreasmfails);
-      return sizeof(*uint_ptr);
-    case 17: /* ipFragOKs */
-      *uint_ptr = STATS_GET(mib2.ipfragoks);
-      return sizeof(*uint_ptr);
-    case 18: /* ipFragFails */
-      *uint_ptr = STATS_GET(mib2.ipfragfails);
-      return sizeof(*uint_ptr);
-    case 19: /* ipFragCreates */
-      *uint_ptr = STATS_GET(mib2.ipfragcreates);
-      return sizeof(*uint_ptr);
-    case 23: /* ipRoutingDiscards: not supported -> always 0 */
-      *uint_ptr = 0;
-      return sizeof(*uint_ptr);
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("ip_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
-      break;
+    return sizeof(*sint_ptr);
+  case 14: /* ipReasmReqds */
+    *uint_ptr = STATS_GET(mib2.ipreasmreqds);
+    return sizeof(*uint_ptr);
+  case 15: /* ipReasmOKs */
+    *uint_ptr = STATS_GET(mib2.ipreasmoks);
+    return sizeof(*uint_ptr);
+  case 16: /* ipReasmFails */
+    *uint_ptr = STATS_GET(mib2.ipreasmfails);
+    return sizeof(*uint_ptr);
+  case 17: /* ipFragOKs */
+    *uint_ptr = STATS_GET(mib2.ipfragoks);
+    return sizeof(*uint_ptr);
+  case 18: /* ipFragFails */
+    *uint_ptr = STATS_GET(mib2.ipfragfails);
+    return sizeof(*uint_ptr);
+  case 19: /* ipFragCreates */
+    *uint_ptr = STATS_GET(mib2.ipfragcreates);
+    return sizeof(*uint_ptr);
+  case 23: /* ipRoutingDiscards: not supported -> always 0 */
+    *uint_ptr = 0;
+    return sizeof(*uint_ptr);
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
+    break;
  }

  return 0;
@@ -154,40 +154,40 @@ ip_get_value(struct snmp_node_instance *instance, void *value)
 *   otherwise return badvalue.
 */
 static snmp_err_t
-ip_set_test(struct snmp_node_instance *instance, u16_t len, void *value)
+ip_set_test(struct snmp_node_instance* instance, u16_t len, void *value)
 {
  snmp_err_t ret = SNMP_ERR_WRONGVALUE;
-  s32_t *sint_ptr = (s32_t *)value;
+  s32_t *sint_ptr = (s32_t*)value;

  LWIP_UNUSED_ARG(len);
  switch (instance->node->oid) {
-    case 1: /* ipForwarding */
+  case 1: /* ipForwarding */
 #if IP_FORWARD
-      /* forwarding */
-      if (*sint_ptr == 1)
+    /* forwarding */
+    if (*sint_ptr == 1)
 #else
-      /* not-forwarding */
-      if (*sint_ptr == 2)
+    /* not-forwarding */
+    if (*sint_ptr == 2)
 #endif
-      {
-        ret = SNMP_ERR_NOERROR;
-      }
-      break;
-    case 2: /* ipDefaultTTL */
-      if (*sint_ptr == IP_DEFAULT_TTL) {
-        ret = SNMP_ERR_NOERROR;
-      }
-      break;
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("ip_set_test(): unknown id: %"S32_F"\n", instance->node->oid));
-      break;
+    {
+      ret = SNMP_ERR_NOERROR;
+    }
+    break;
+  case 2: /* ipDefaultTTL */
+    if (*sint_ptr == IP_DEFAULT_TTL) {
+      ret = SNMP_ERR_NOERROR;
+    }
+    break;
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_set_test(): unknown id: %"S32_F"\n", instance->node->oid));
+    break;
  }

  return ret;
 }

 static snmp_err_t
-ip_set_value(struct snmp_node_instance *instance, u16_t len, void *value)
+ip_set_value(struct snmp_node_instance* instance, u16_t len, void *value)
 {
  LWIP_UNUSED_ARG(instance);
  LWIP_UNUSED_ARG(len);
@@ -207,48 +207,48 @@ static const struct snmp_oid_range ip_AddrTable_oid_ranges[] = {
 };

 static snmp_err_t
-ip_AddrTable_get_cell_value_core(struct netif *netif, const u32_t *column, union snmp_variant_value *value, u32_t *value_len)
+ip_AddrTable_get_cell_value_core(struct netif *netif, const u32_t* column, union snmp_variant_value* value, u32_t* value_len)
 {
  LWIP_UNUSED_ARG(value_len);

  switch (*column) {
-    case 1: /* ipAdEntAddr */
-      value->u32 = netif_ip4_addr(netif)->addr;
-      break;
-    case 2: /* ipAdEntIfIndex */
-      value->u32 = netif_to_num(netif);
-      break;
-    case 3: /* ipAdEntNetMask */
-      value->u32 = netif_ip4_netmask(netif)->addr;
-      break;
-    case 4: /* ipAdEntBcastAddr */
-      /* lwIP oddity, there's no broadcast
-         address in the netif we can rely on */
-      value->u32 = IPADDR_BROADCAST & 1;
-      break;
-    case 5: /* ipAdEntReasmMaxSize */
+  case 1: /* ipAdEntAddr */
+    value->u32 = netif_ip4_addr(netif)->addr;
+    break;
+  case 2: /* ipAdEntIfIndex */
+    value->u32 = netif_to_num(netif);
+    break;
+  case 3: /* ipAdEntNetMask */
+    value->u32 = netif_ip4_netmask(netif)->addr;
+    break;
+  case 4: /* ipAdEntBcastAddr */
+    /* lwIP oddity, there's no broadcast
+       address in the netif we can rely on */
+    value->u32 = IPADDR_BROADCAST & 1;
+    break;
+  case 5: /* ipAdEntReasmMaxSize */
 #if IP_REASSEMBLY
-      /* @todo The theoretical maximum is IP_REASS_MAX_PBUFS * size of the pbufs,
-       * but only if receiving one fragmented packet at a time.
-       * The current solution is to calculate for 2 simultaneous packets...
-       */
-      value->u32 = (IP_HLEN + ((IP_REASS_MAX_PBUFS / 2) *
-                               (PBUF_POOL_BUFSIZE - PBUF_LINK_ENCAPSULATION_HLEN - PBUF_LINK_HLEN - IP_HLEN)));
+    /* @todo The theoretical maximum is IP_REASS_MAX_PBUFS * size of the pbufs,
+     * but only if receiving one fragmented packet at a time.
+     * The current solution is to calculate for 2 simultaneous packets...
+     */
+    value->u32 = (IP_HLEN + ((IP_REASS_MAX_PBUFS/2) *
+        (PBUF_POOL_BUFSIZE - PBUF_LINK_ENCAPSULATION_HLEN - PBUF_LINK_HLEN - IP_HLEN)));
 #else
-      /** @todo returning MTU would be a bad thing and
-          returning a wild guess like '576' isn't good either */
-      value->u32 = 0;
+    /** @todo returning MTU would be a bad thing and
+        returning a wild guess like '576' isn't good either */
+    value->u32 = 0;
 #endif
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-ip_AddrTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+ip_AddrTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip4_addr_t ip;
  struct netif *netif;
@@ -262,11 +262,14 @@ ip_AddrTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_
  snmp_oid_to_ip4(&row_oid[0], &ip); /* we know it succeeds because of oid_in_range check above */

  /* find netif with requested ip */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    if (ip4_addr_cmp(&ip, netif_ip4_addr(netif))) {
      /* fill in object properties */
      return ip_AddrTable_get_cell_value_core(netif, column, value, value_len);
    }
+
+    netif = netif->next;
  }

  /* not found */
@@ -274,7 +277,7 @@ ip_AddrTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_
 }

 static snmp_err_t
-ip_AddrTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+ip_AddrTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct netif *netif;
  struct snmp_next_oid_state state;
@@ -284,19 +287,22 @@ ip_AddrTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_o
  snmp_next_oid_init(&state, row_oid->id, row_oid->len, result_temp, LWIP_ARRAYSIZE(ip_AddrTable_oid_ranges));

  /* iterate over all possible OIDs to find the next one */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    u32_t test_oid[LWIP_ARRAYSIZE(ip_AddrTable_oid_ranges)];
    snmp_ip4_to_oid(netif_ip4_addr(netif), &test_oid[0]);

    /* check generated OID: is it a candidate for the next one? */
    snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(ip_AddrTable_oid_ranges), netif);
+
+    netif = netif->next;
  }

  /* did we find a next one? */
  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return ip_AddrTable_get_cell_value_core((struct netif *)state.reference, column, value, value_len);
+    return ip_AddrTable_get_cell_value_core((struct netif*)state.reference, column, value, value_len);
  }

  /* not found */
@@ -314,86 +320,86 @@ static const struct snmp_oid_range ip_RouteTable_oid_ranges[] = {
 };

 static snmp_err_t
-ip_RouteTable_get_cell_value_core(struct netif *netif, u8_t default_route, const u32_t *column, union snmp_variant_value *value, u32_t *value_len)
+ip_RouteTable_get_cell_value_core(struct netif *netif, u8_t default_route, const u32_t* column, union snmp_variant_value* value, u32_t* value_len)
 {
  switch (*column) {
-    case 1: /* ipRouteDest */
-      if (default_route) {
-        /* default rte has 0.0.0.0 dest */
-        value->u32 = IP4_ADDR_ANY4->addr;
-      } else {
-        /* netifs have netaddress dest */
-        ip4_addr_t tmp;
-        ip4_addr_get_network(&tmp, netif_ip4_addr(netif), netif_ip4_netmask(netif));
-        value->u32 = tmp.addr;
-      }
-      break;
-    case 2: /* ipRouteIfIndex */
-      value->u32 = netif_to_num(netif);
-      break;
-    case 3: /* ipRouteMetric1 */
-      if (default_route) {
-        value->s32 = 1; /* default */
-      } else {
-        value->s32 = 0; /* normal */
-      }
-      break;
-    case 4: /* ipRouteMetric2 */
-    case 5: /* ipRouteMetric3 */
-    case 6: /* ipRouteMetric4 */
-      value->s32 = -1; /* none */
-      break;
-    case 7: /* ipRouteNextHop */
-      if (default_route) {
-        /* default rte: gateway */
-        value->u32 = netif_ip4_gw(netif)->addr;
-      } else {
-        /* other rtes: netif ip_addr  */
-        value->u32 = netif_ip4_addr(netif)->addr;
-      }
-      break;
-    case 8: /* ipRouteType */
-      if (default_route) {
-        /* default rte is indirect */
-        value->u32 = 4; /* indirect */
-      } else {
-        /* other rtes are direct */
-        value->u32 = 3; /* direct */
-      }
-      break;
-    case 9: /* ipRouteProto */
-      /* locally defined routes */
-      value->u32 = 2; /* local */
-      break;
-    case 10: /* ipRouteAge */
-      /* @todo (sysuptime - timestamp last change) / 100 */
-      value->u32 = 0;
-      break;
-    case 11: /* ipRouteMask */
-      if (default_route) {
-        /* default rte use 0.0.0.0 mask */
-        value->u32 = IP4_ADDR_ANY4->addr;
-      } else {
-        /* other rtes use netmask */
-        value->u32 = netif_ip4_netmask(netif)->addr;
-      }
-      break;
-    case 12: /* ipRouteMetric5 */
-      value->s32 = -1; /* none */
-      break;
-    case 13: /* ipRouteInfo */
-      value->const_ptr = snmp_zero_dot_zero.id;
-      *value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 1: /* ipRouteDest */
+    if (default_route) {
+       /* default rte has 0.0.0.0 dest */
+      value->u32 = IP4_ADDR_ANY4->addr;
+    } else {
+      /* netifs have netaddress dest */
+      ip4_addr_t tmp;
+      ip4_addr_get_network(&tmp, netif_ip4_addr(netif), netif_ip4_netmask(netif));
+      value->u32 = tmp.addr;
+    }
+    break;
+  case 2: /* ipRouteIfIndex */
+    value->u32 = netif_to_num(netif);
+    break;
+  case 3: /* ipRouteMetric1 */
+    if (default_route) {
+      value->s32 = 1; /* default */
+    } else {
+      value->s32 = 0; /* normal */
+    }
+    break;
+  case 4: /* ipRouteMetric2 */
+  case 5: /* ipRouteMetric3 */
+  case 6: /* ipRouteMetric4 */
+    value->s32 = -1; /* none */
+    break;
+  case 7: /* ipRouteNextHop */
+    if (default_route) {
+      /* default rte: gateway */
+      value->u32 = netif_ip4_gw(netif)->addr;
+    } else {
+      /* other rtes: netif ip_addr  */
+      value->u32 = netif_ip4_addr(netif)->addr;
+    }
+    break;
+  case 8: /* ipRouteType */
+    if (default_route) {
+      /* default rte is indirect */
+      value->u32 = 4; /* indirect */
+    } else {
+      /* other rtes are direct */
+      value->u32 = 3; /* direct */
+    }
+    break;
+  case 9: /* ipRouteProto */
+    /* locally defined routes */
+    value->u32 = 2; /* local */
+    break;
+  case 10: /* ipRouteAge */
+    /* @todo (sysuptime - timestamp last change) / 100 */
+    value->u32 = 0;
+    break;
+  case 11: /* ipRouteMask */
+    if (default_route) {
+      /* default rte use 0.0.0.0 mask */
+      value->u32 = IP4_ADDR_ANY4->addr;
+    } else {
+      /* other rtes use netmask */
+      value->u32 = netif_ip4_netmask(netif)->addr;
+    }
+    break;
+  case 12: /* ipRouteMetric5 */
+    value->s32 = -1; /* none */
+    break;
+  case 13: /* ipRouteInfo */
+    value->const_ptr = snmp_zero_dot_zero.id;
+    *value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-ip_RouteTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+ip_RouteTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip4_addr_t test_ip;
  struct netif *netif;
@@ -413,7 +419,8 @@ ip_RouteTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
  }

  /* find netif with requested route */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    ip4_addr_t dst;
    ip4_addr_get_network(&dst, netif_ip4_addr(netif), netif_ip4_netmask(netif));

@@ -421,6 +428,8 @@ ip_RouteTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
      /* fill in object properties */
      return ip_RouteTable_get_cell_value_core(netif, 0, column, value, value_len);
    }
+
+    netif = netif->next;
  }

  /* not found */
@@ -428,7 +437,7 @@ ip_RouteTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
 }

 static snmp_err_t
-ip_RouteTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+ip_RouteTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct netif *netif;
  struct snmp_next_oid_state state;
@@ -445,7 +454,8 @@ ip_RouteTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_
  }

  /* iterate over all possible OIDs to find the next one */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    ip4_addr_t dst;
    ip4_addr_get_network(&dst, netif_ip4_addr(netif), netif_ip4_netmask(netif));

@@ -454,6 +464,8 @@ ip_RouteTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_
      snmp_ip4_to_oid(&dst, &test_oid[0]);
      snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(ip_RouteTable_oid_ranges), netif);
    }
+
+    netif = netif->next;
  }

  /* did we find a next one? */
@@ -462,7 +474,7 @@ ip_RouteTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_
    snmp_oid_to_ip4(&result_temp[0], &dst);
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return ip_RouteTable_get_cell_value_core((struct netif *)state.reference, ip4_addr_isany_val(dst), column, value, value_len);
+    return ip_RouteTable_get_cell_value_core((struct netif*)state.reference, ip4_addr_isany_val(dst), column, value, value_len);
  } else {
    /* not found */
    return SNMP_ERR_NOSUCHINSTANCE;
@@ -482,7 +494,7 @@ static const struct snmp_oid_range ip_NetToMediaTable_oid_ranges[] = {
 };

 static snmp_err_t
-ip_NetToMediaTable_get_cell_value_core(size_t arp_table_index, const u32_t *column, union snmp_variant_value *value, u32_t *value_len)
+ip_NetToMediaTable_get_cell_value_core(u8_t arp_table_index, const u32_t* column, union snmp_variant_value* value, u32_t* value_len)
 {
  ip4_addr_t *ip;
  struct netif *netif;
@@ -492,32 +504,32 @@ ip_NetToMediaTable_get_cell_value_core(size_t arp_table_index, const u32_t *colu

  /* value */
  switch (*column) {
-    case 1: /* atIfIndex / ipNetToMediaIfIndex */
-      value->u32 = netif_to_num(netif);
-      break;
-    case 2: /* atPhysAddress / ipNetToMediaPhysAddress */
-      value->ptr = ethaddr;
-      *value_len = sizeof(*ethaddr);
-      break;
-    case 3: /* atNetAddress / ipNetToMediaNetAddress */
-      value->u32 = ip->addr;
-      break;
-    case 4: /* ipNetToMediaType */
-      value->u32 = 3; /* dynamic*/
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 1: /* atIfIndex / ipNetToMediaIfIndex */
+    value->u32 = netif_to_num(netif);
+    break;
+  case 2: /* atPhysAddress / ipNetToMediaPhysAddress */
+    value->ptr = ethaddr;
+    *value_len = sizeof(*ethaddr);
+    break;
+  case 3: /* atNetAddress / ipNetToMediaNetAddress */
+    value->u32 = ip->addr;
+    break;
+  case 4: /* ipNetToMediaType */
+    value->u32 = 3; /* dynamic*/
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-ip_NetToMediaTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+ip_NetToMediaTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip4_addr_t ip_in;
  u8_t netif_index;
-  size_t i;
+  u8_t i;

  /* check if incoming OID length and if values are in plausible range */
  if (!snmp_oid_in_range(row_oid, row_oid_len, ip_NetToMediaTable_oid_ranges, LWIP_ARRAYSIZE(ip_NetToMediaTable_oid_ranges))) {
@@ -529,7 +541,7 @@ ip_NetToMediaTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_
  snmp_oid_to_ip4(&row_oid[1], &ip_in); /* we know it succeeds because of oid_in_range check above */

  /* find requested entry */
-  for (i = 0; i < ARP_TABLE_SIZE; i++) {
+  for (i=0; i<ARP_TABLE_SIZE; i++) {
    ip4_addr_t *ip;
    struct netif *netif;
    struct eth_addr *ethaddr;
@@ -547,9 +559,9 @@ ip_NetToMediaTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_
 }

 static snmp_err_t
-ip_NetToMediaTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+ip_NetToMediaTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
-  size_t i;
+  u8_t i;
  struct snmp_next_oid_state state;
  u32_t result_temp[LWIP_ARRAYSIZE(ip_NetToMediaTable_oid_ranges)];

@@ -557,7 +569,7 @@ ip_NetToMediaTable_get_next_cell_instance_and_value(const u32_t *column, struct
  snmp_next_oid_init(&state, row_oid->id, row_oid->len, result_temp, LWIP_ARRAYSIZE(ip_NetToMediaTable_oid_ranges));

  /* iterate over all possible OIDs to find the next one */
-  for (i = 0; i < ARP_TABLE_SIZE; i++) {
+  for (i=0; i<ARP_TABLE_SIZE; i++) {
    ip4_addr_t *ip;
    struct netif *netif;
    struct eth_addr *ethaddr;
@@ -569,7 +581,7 @@ ip_NetToMediaTable_get_next_cell_instance_and_value(const u32_t *column, struct
      snmp_ip4_to_oid(ip, &test_oid[1]);

      /* check generated OID: is it a candidate for the next one? */
-      snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(ip_NetToMediaTable_oid_ranges), LWIP_PTR_NUMERIC_CAST(void *, i));
+      snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(ip_NetToMediaTable_oid_ranges), LWIP_PTR_NUMERIC_CAST(void*, i));
    }
  }

@@ -577,7 +589,7 @@ ip_NetToMediaTable_get_next_cell_instance_and_value(const u32_t *column, struct
  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return ip_NetToMediaTable_get_cell_value_core(LWIP_PTR_NUMERIC_CAST(size_t, state.reference), column, value, value_len);
+    return ip_NetToMediaTable_get_cell_value_core(LWIP_PTR_NUMERIC_CAST(u8_t, state.reference), column, value, value_len);
  }

  /* not found */
@@ -675,7 +687,7 @@ CREATE_LWIP_SYNC_NODE(22, ip_NetToMediaTable)
 #endif /* LWIP_ARP */
 CREATE_LWIP_SYNC_NODE(23, ip_RoutingDiscards)

-static const struct snmp_node *const ip_nodes[] = {
+static const struct snmp_node* const ip_nodes[] = {
  &SYNC_NODE_NAME(ip_Forwarding).node.node,
  &SYNC_NODE_NAME(ip_DefaultTTL).node.node,
  &SYNC_NODE_NAME(ip_InReceives).node.node,
@@ -721,7 +733,7 @@ static const struct snmp_table_simple_node at_Table = SNMP_TABLE_CREATE_SIMPLE(1
 /* the following nodes access variables in LWIP stack from SNMP worker thread and must therefore be synced to LWIP (TCPIP) thread */
 CREATE_LWIP_SYNC_NODE(1, at_Table)

-static const struct snmp_node *const at_nodes[] = {
+static const struct snmp_node* const at_nodes[] = {
  &SYNC_NODE_NAME(at_Table).node.node
 };

--- a/src/apps/snmp/snmp_mib2_snmp.c
+++ b/src/apps/snmp/snmp_mib2_snmp.c
@@ -48,105 +48,105 @@
 static s16_t
 snmp_get_value(const struct snmp_scalar_array_node_def *node, void *value)
 {
-  u32_t *uint_ptr = (u32_t *)value;
+  u32_t *uint_ptr = (u32_t*)value;
  switch (node->oid) {
-    case 1: /* snmpInPkts */
-      *uint_ptr = snmp_stats.inpkts;
-      break;
-    case 2: /* snmpOutPkts */
-      *uint_ptr = snmp_stats.outpkts;
-      break;
-    case 3: /* snmpInBadVersions */
-      *uint_ptr = snmp_stats.inbadversions;
-      break;
-    case 4: /* snmpInBadCommunityNames */
-      *uint_ptr = snmp_stats.inbadcommunitynames;
-      break;
-    case 5: /* snmpInBadCommunityUses */
-      *uint_ptr = snmp_stats.inbadcommunityuses;
-      break;
-    case 6: /* snmpInASNParseErrs */
-      *uint_ptr = snmp_stats.inasnparseerrs;
-      break;
-    case 8: /* snmpInTooBigs */
-      *uint_ptr = snmp_stats.intoobigs;
-      break;
-    case 9: /* snmpInNoSuchNames */
-      *uint_ptr = snmp_stats.innosuchnames;
-      break;
-    case 10: /* snmpInBadValues */
-      *uint_ptr = snmp_stats.inbadvalues;
-      break;
-    case 11: /* snmpInReadOnlys */
-      *uint_ptr = snmp_stats.inreadonlys;
-      break;
-    case 12: /* snmpInGenErrs */
-      *uint_ptr = snmp_stats.ingenerrs;
-      break;
-    case 13: /* snmpInTotalReqVars */
-      *uint_ptr = snmp_stats.intotalreqvars;
-      break;
-    case 14: /* snmpInTotalSetVars */
-      *uint_ptr = snmp_stats.intotalsetvars;
-      break;
-    case 15: /* snmpInGetRequests */
-      *uint_ptr = snmp_stats.ingetrequests;
-      break;
-    case 16: /* snmpInGetNexts */
-      *uint_ptr = snmp_stats.ingetnexts;
-      break;
-    case 17: /* snmpInSetRequests */
-      *uint_ptr = snmp_stats.insetrequests;
-      break;
-    case 18: /* snmpInGetResponses */
-      *uint_ptr = snmp_stats.ingetresponses;
-      break;
-    case 19: /* snmpInTraps */
-      *uint_ptr = snmp_stats.intraps;
-      break;
-    case 20: /* snmpOutTooBigs */
-      *uint_ptr = snmp_stats.outtoobigs;
-      break;
-    case 21: /* snmpOutNoSuchNames */
-      *uint_ptr = snmp_stats.outnosuchnames;
-      break;
-    case 22: /* snmpOutBadValues */
-      *uint_ptr = snmp_stats.outbadvalues;
-      break;
-    case 24: /* snmpOutGenErrs */
-      *uint_ptr = snmp_stats.outgenerrs;
-      break;
-    case 25: /* snmpOutGetRequests */
-      *uint_ptr = snmp_stats.outgetrequests;
-      break;
-    case 26: /* snmpOutGetNexts */
-      *uint_ptr = snmp_stats.outgetnexts;
-      break;
-    case 27: /* snmpOutSetRequests */
-      *uint_ptr = snmp_stats.outsetrequests;
-      break;
-    case 28: /* snmpOutGetResponses */
-      *uint_ptr = snmp_stats.outgetresponses;
-      break;
-    case 29: /* snmpOutTraps */
-      *uint_ptr = snmp_stats.outtraps;
-      break;
-    case 30: /* snmpEnableAuthenTraps */
-      if (snmp_get_auth_traps_enabled() == SNMP_AUTH_TRAPS_DISABLED) {
-        *uint_ptr = MIB2_AUTH_TRAPS_DISABLED;
-      } else {
-        *uint_ptr = MIB2_AUTH_TRAPS_ENABLED;
-      }
-      break;
-    case 31: /* snmpSilentDrops */
-      *uint_ptr = 0; /* not supported */
-      break;
-    case 32: /* snmpProxyDrops */
-      *uint_ptr = 0; /* not supported */
-      break;
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("snmp_get_value(): unknown id: %"S32_F"\n", node->oid));
-      return 0;
+  case 1: /* snmpInPkts */
+    *uint_ptr = snmp_stats.inpkts;
+    break;
+  case 2: /* snmpOutPkts */
+    *uint_ptr = snmp_stats.outpkts;
+    break;
+  case 3: /* snmpInBadVersions */
+    *uint_ptr = snmp_stats.inbadversions;
+    break;
+  case 4: /* snmpInBadCommunityNames */
+    *uint_ptr = snmp_stats.inbadcommunitynames;
+    break;
+  case 5: /* snmpInBadCommunityUses */
+    *uint_ptr = snmp_stats.inbadcommunityuses;
+    break;
+  case 6: /* snmpInASNParseErrs */
+    *uint_ptr = snmp_stats.inasnparseerrs;
+    break;
+  case 8: /* snmpInTooBigs */
+    *uint_ptr = snmp_stats.intoobigs;
+    break;
+  case 9: /* snmpInNoSuchNames */
+    *uint_ptr = snmp_stats.innosuchnames;
+    break;
+  case 10: /* snmpInBadValues */
+    *uint_ptr = snmp_stats.inbadvalues;
+    break;
+  case 11: /* snmpInReadOnlys */
+    *uint_ptr = snmp_stats.inreadonlys;
+    break;
+  case 12: /* snmpInGenErrs */
+    *uint_ptr = snmp_stats.ingenerrs;
+    break;
+  case 13: /* snmpInTotalReqVars */
+    *uint_ptr = snmp_stats.intotalreqvars;
+    break;
+  case 14: /* snmpInTotalSetVars */
+    *uint_ptr = snmp_stats.intotalsetvars;
+    break;
+  case 15: /* snmpInGetRequests */
+    *uint_ptr = snmp_stats.ingetrequests;
+    break;
+  case 16: /* snmpInGetNexts */
+    *uint_ptr = snmp_stats.ingetnexts;
+    break;
+  case 17: /* snmpInSetRequests */
+    *uint_ptr = snmp_stats.insetrequests;
+    break;
+  case 18: /* snmpInGetResponses */
+    *uint_ptr = snmp_stats.ingetresponses;
+    break;
+  case 19: /* snmpInTraps */
+    *uint_ptr = snmp_stats.intraps;
+    break;
+  case 20: /* snmpOutTooBigs */
+    *uint_ptr = snmp_stats.outtoobigs;
+    break;
+  case 21: /* snmpOutNoSuchNames */
+    *uint_ptr = snmp_stats.outnosuchnames;
+    break;
+  case 22: /* snmpOutBadValues */
+    *uint_ptr = snmp_stats.outbadvalues;
+    break;
+  case 24: /* snmpOutGenErrs */
+    *uint_ptr = snmp_stats.outgenerrs;
+    break;
+  case 25: /* snmpOutGetRequests */
+    *uint_ptr = snmp_stats.outgetrequests;
+    break;
+  case 26: /* snmpOutGetNexts */
+    *uint_ptr = snmp_stats.outgetnexts;
+    break;
+  case 27: /* snmpOutSetRequests */
+    *uint_ptr = snmp_stats.outsetrequests;
+    break;
+  case 28: /* snmpOutGetResponses */
+    *uint_ptr = snmp_stats.outgetresponses;
+    break;
+  case 29: /* snmpOutTraps */
+    *uint_ptr = snmp_stats.outtraps;
+    break;
+  case 30: /* snmpEnableAuthenTraps */
+    if (snmp_get_auth_traps_enabled() == SNMP_AUTH_TRAPS_DISABLED) {
+      *uint_ptr = MIB2_AUTH_TRAPS_DISABLED;
+    } else {
+      *uint_ptr = MIB2_AUTH_TRAPS_ENABLED;
+    }
+    break;
+  case 31: /* snmpSilentDrops */
+    *uint_ptr = 0; /* not supported */
+    break;
+  case 32: /* snmpProxyDrops */
+    *uint_ptr = 0; /* not supported */
+    break;
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("snmp_get_value(): unknown id: %"S32_F"\n", node->oid));
+    return 0;
  }

  return sizeof(*uint_ptr);
@@ -160,7 +160,7 @@ snmp_set_test(const struct snmp_scalar_array_node_def *node, u16_t len, void *va

  if (node->oid == 30) {
    /* snmpEnableAuthenTraps */
-    s32_t *sint_ptr = (s32_t *)value;
+    s32_t *sint_ptr = (s32_t*)value;

    /* we should have writable non-volatile mem here */
    if ((*sint_ptr == MIB2_AUTH_TRAPS_DISABLED) || (*sint_ptr == MIB2_AUTH_TRAPS_ENABLED)) {
@@ -177,7 +177,7 @@ snmp_set_value(const struct snmp_scalar_array_node_def *node, u16_t len, void *v

  if (node->oid == 30) {
    /* snmpEnableAuthenTraps */
-    s32_t *sint_ptr = (s32_t *)value;
+    s32_t *sint_ptr = (s32_t*)value;
    if (*sint_ptr == MIB2_AUTH_TRAPS_DISABLED) {
      snmp_set_auth_traps_enabled(SNMP_AUTH_TRAPS_DISABLED);
    } else {
--- a/src/apps/snmp/snmp_mib2_system.c
+++ b/src/apps/snmp/snmp_mib2_system.c
@@ -58,31 +58,31 @@

 /** mib-2.system.sysDescr */
 static const u8_t   sysdescr_default[] = SNMP_LWIP_MIB2_SYSDESC;
-static const u8_t  *sysdescr           = sysdescr_default;
-static const u16_t *sysdescr_len       = NULL; /* use strlen for determining len */
+static const u8_t*  sysdescr           = sysdescr_default;
+static const u16_t* sysdescr_len       = NULL; /* use strlen for determining len */

 /** mib-2.system.sysContact */
 static const u8_t   syscontact_default[]     = SNMP_LWIP_MIB2_SYSCONTACT;
-static const u8_t  *syscontact               = syscontact_default;
-static const u16_t *syscontact_len           = NULL; /* use strlen for determining len */
-static u8_t        *syscontact_wr            = NULL; /* if writable, points to the same buffer as syscontact (required for correct constness) */
-static u16_t       *syscontact_wr_len        = NULL; /* if writable, points to the same buffer as syscontact_len (required for correct constness) */
+static const u8_t*  syscontact               = syscontact_default;
+static const u16_t* syscontact_len           = NULL; /* use strlen for determining len */
+static u8_t*        syscontact_wr            = NULL; /* if writable, points to the same buffer as syscontact (required for correct constness) */
+static u16_t*       syscontact_wr_len        = NULL; /* if writable, points to the same buffer as syscontact_len (required for correct constness) */
 static u16_t        syscontact_bufsize       = 0;    /* 0=not writable */

 /** mib-2.system.sysName */
 static const u8_t   sysname_default[]        = SNMP_LWIP_MIB2_SYSNAME;
-static const u8_t  *sysname                  = sysname_default;
-static const u16_t *sysname_len              = NULL; /* use strlen for determining len */
-static u8_t        *sysname_wr               = NULL; /* if writable, points to the same buffer as sysname (required for correct constness) */
-static u16_t       *sysname_wr_len           = NULL; /* if writable, points to the same buffer as sysname_len (required for correct constness) */
+static const u8_t*  sysname                  = sysname_default;
+static const u16_t* sysname_len              = NULL; /* use strlen for determining len */
+static u8_t*        sysname_wr               = NULL; /* if writable, points to the same buffer as sysname (required for correct constness) */
+static u16_t*       sysname_wr_len           = NULL; /* if writable, points to the same buffer as sysname_len (required for correct constness) */
 static u16_t        sysname_bufsize          = 0;    /* 0=not writable */

 /** mib-2.system.sysLocation */
 static const u8_t   syslocation_default[]    = SNMP_LWIP_MIB2_SYSLOCATION;
-static const u8_t  *syslocation              = syslocation_default;
-static const u16_t *syslocation_len           = NULL; /* use strlen for determining len */
-static u8_t        *syslocation_wr            = NULL; /* if writable, points to the same buffer as syslocation (required for correct constness) */
-static u16_t       *syslocation_wr_len        = NULL; /* if writable, points to the same buffer as syslocation_len (required for correct constness) */
+static const u8_t*  syslocation              = syslocation_default;
+static const u16_t* syslocation_len           = NULL; /* use strlen for determining len */
+static u8_t*        syslocation_wr            = NULL; /* if writable, points to the same buffer as syslocation (required for correct constness) */
+static u16_t*       syslocation_wr_len        = NULL; /* if writable, points to the same buffer as syslocation_len (required for correct constness) */
 static u16_t        syslocation_bufsize       = 0;    /* 0=not writable */

 /**
@@ -229,47 +229,48 @@ snmp_mib2_set_syslocation_readonly(const u8_t *ocstr, const u16_t *ocstrlen)
 static s16_t
 system_get_value(const struct snmp_scalar_array_node_def *node, void *value)
 {
-  const u8_t  *var = NULL;
-  const s16_t *var_len;
+  const u8_t*  var = NULL;
+  const s16_t* var_len;
  u16_t result;

  switch (node->oid) {
-    case 1: /* sysDescr */
-      var     = sysdescr;
-      var_len = (const s16_t *)sysdescr_len;
-      break;
-    case 2: { /* sysObjectID */
-      const struct snmp_obj_id *dev_enterprise_oid = snmp_get_device_enterprise_oid();
+  case 1: /* sysDescr */
+    var     = sysdescr;
+    var_len = (const s16_t*)sysdescr_len;
+    break;
+  case 2: /* sysObjectID */
+    {
+      const struct snmp_obj_id* dev_enterprise_oid = snmp_get_device_enterprise_oid();
      MEMCPY(value, dev_enterprise_oid->id, dev_enterprise_oid->len * sizeof(u32_t));
      return dev_enterprise_oid->len * sizeof(u32_t);
    }
-    case 3: /* sysUpTime */
-      MIB2_COPY_SYSUPTIME_TO((u32_t *)value);
-      return sizeof(u32_t);
-    case 4: /* sysContact */
-      var     = syscontact;
-      var_len = (const s16_t *)syscontact_len;
-      break;
-    case 5: /* sysName */
-      var     = sysname;
-      var_len = (const s16_t *)sysname_len;
-      break;
-    case 6: /* sysLocation */
-      var     = syslocation;
-      var_len = (const s16_t *)syslocation_len;
-      break;
-    case 7: /* sysServices */
-      *(s32_t *)value = SNMP_SYSSERVICES;
-      return sizeof(s32_t);
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("system_get_value(): unknown id: %"S32_F"\n", node->oid));
-      return 0;
+  case 3: /* sysUpTime */
+    MIB2_COPY_SYSUPTIME_TO((u32_t*)value);
+    return sizeof(u32_t);
+  case 4: /* sysContact */
+    var     = syscontact;
+    var_len = (const s16_t*)syscontact_len;
+    break;
+  case 5: /* sysName */
+    var     = sysname;
+    var_len = (const s16_t*)sysname_len;
+    break;
+  case 6: /* sysLocation */
+    var     = syslocation;
+    var_len = (const s16_t*)syslocation_len;
+    break;
+  case 7: /* sysServices */
+    *(s32_t*)value = SNMP_SYSSERVICES;
+    return sizeof(s32_t);
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_get_value(): unknown id: %"S32_F"\n", node->oid));
+    return 0;
  }

  /* handle string values (OID 1,4,5 and 6) */
  LWIP_ASSERT("", (value != NULL));
  if (var_len == NULL) {
-    result = (s16_t)strlen((const char *)var);
+    result = (s16_t)strlen((const char*)var);
  } else {
    result = *var_len;
  }
@@ -281,27 +282,27 @@ static snmp_err_t
 system_set_test(const struct snmp_scalar_array_node_def *node, u16_t len, void *value)
 {
  snmp_err_t ret = SNMP_ERR_WRONGVALUE;
-  const u16_t *var_bufsize  = NULL;
-  const u16_t *var_wr_len;
+  const u16_t* var_bufsize  = NULL;
+  const u16_t* var_wr_len;

  LWIP_UNUSED_ARG(value);

  switch (node->oid) {
-    case 4: /* sysContact */
-      var_bufsize  = &syscontact_bufsize;
-      var_wr_len   = syscontact_wr_len;
-      break;
-    case 5: /* sysName */
-      var_bufsize  = &sysname_bufsize;
-      var_wr_len   = sysname_wr_len;
-      break;
-    case 6: /* sysLocation */
-      var_bufsize  = &syslocation_bufsize;
-      var_wr_len   = syslocation_wr_len;
-      break;
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("system_set_test(): unknown id: %"S32_F"\n", node->oid));
-      return ret;
+  case 4: /* sysContact */
+    var_bufsize  = &syscontact_bufsize;
+    var_wr_len   = syscontact_wr_len;
+    break;
+  case 5: /* sysName */
+    var_bufsize  = &sysname_bufsize;
+    var_wr_len   = sysname_wr_len;
+    break;
+  case 6: /* sysLocation */
+    var_bufsize  = &syslocation_bufsize;
+    var_wr_len   = syslocation_wr_len;
+    break;
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_set_test(): unknown id: %"S32_F"\n", node->oid));
+    return ret;
  }

  /* check if value is writable at all */
@@ -326,31 +327,31 @@ system_set_test(const struct snmp_scalar_array_node_def *node, u16_t len, void *
 static snmp_err_t
 system_set_value(const struct snmp_scalar_array_node_def *node, u16_t len, void *value)
 {
-  u8_t  *var_wr = NULL;
-  u16_t *var_wr_len;
+  u8_t*  var_wr = NULL;
+  u16_t* var_wr_len;

  switch (node->oid) {
-    case 4: /* sysContact */
-      var_wr     = syscontact_wr;
-      var_wr_len = syscontact_wr_len;
-      break;
-    case 5: /* sysName */
-      var_wr     = sysname_wr;
-      var_wr_len = sysname_wr_len;
-      break;
-    case 6: /* sysLocation */
-      var_wr     = syslocation_wr;
-      var_wr_len = syslocation_wr_len;
-      break;
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("system_set_value(): unknown id: %"S32_F"\n", node->oid));
-      return SNMP_ERR_GENERROR;
+  case 4: /* sysContact */
+    var_wr     = syscontact_wr;
+    var_wr_len = syscontact_wr_len;
+    break;
+  case 5: /* sysName */
+    var_wr     = sysname_wr;
+    var_wr_len = sysname_wr_len;
+    break;
+  case 6: /* sysLocation */
+    var_wr     = syslocation_wr;
+    var_wr_len = syslocation_wr_len;
+    break;
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_set_value(): unknown id: %"S32_F"\n", node->oid));
+    return SNMP_ERR_GENERROR;
  }

  /* no need to check size of target buffer, this was already done in set_test method */
  LWIP_ASSERT("", var_wr != NULL);
  MEMCPY(var_wr, value, len);
-
+  
  if (var_wr_len == NULL) {
    /* add terminating 0 */
    var_wr[len] = 0;
--- a/src/apps/snmp/snmp_mib2_tcp.c
+++ b/src/apps/snmp/snmp_mib2_tcp.c
@@ -59,41 +59,42 @@
 /* --- tcp .1.3.6.1.2.1.6 ----------------------------------------------------- */

 static s16_t
-tcp_get_value(struct snmp_node_instance *instance, void *value)
+tcp_get_value(struct snmp_node_instance* instance, void* value)
 {
-  u32_t *uint_ptr = (u32_t *)value;
-  s32_t *sint_ptr = (s32_t *)value;
+  u32_t *uint_ptr = (u32_t*)value;
+  s32_t *sint_ptr = (s32_t*)value;

  switch (instance->node->oid) {
-    case 1: /* tcpRtoAlgorithm, vanj(4) */
-      *sint_ptr = 4;
-      return sizeof(*sint_ptr);
-    case 2: /* tcpRtoMin */
-      /* @todo not the actual value, a guess,
-          needs to be calculated */
-      *sint_ptr = 1000;
-      return sizeof(*sint_ptr);
-    case 3: /* tcpRtoMax */
-      /* @todo not the actual value, a guess,
-          needs to be calculated */
-      *sint_ptr = 60000;
-      return sizeof(*sint_ptr);
-    case 4: /* tcpMaxConn */
-      *sint_ptr = MEMP_NUM_TCP_PCB;
-      return sizeof(*sint_ptr);
-    case 5: /* tcpActiveOpens */
-      *uint_ptr = STATS_GET(mib2.tcpactiveopens);
-      return sizeof(*uint_ptr);
-    case 6: /* tcpPassiveOpens */
-      *uint_ptr = STATS_GET(mib2.tcppassiveopens);
-      return sizeof(*uint_ptr);
-    case 7: /* tcpAttemptFails */
-      *uint_ptr = STATS_GET(mib2.tcpattemptfails);
-      return sizeof(*uint_ptr);
-    case 8: /* tcpEstabResets */
-      *uint_ptr = STATS_GET(mib2.tcpestabresets);
-      return sizeof(*uint_ptr);
-    case 9: { /* tcpCurrEstab */
+  case 1: /* tcpRtoAlgorithm, vanj(4) */
+    *sint_ptr = 4;
+    return sizeof(*sint_ptr);
+  case 2: /* tcpRtoMin */
+    /* @todo not the actual value, a guess,
+        needs to be calculated */
+    *sint_ptr = 1000;
+    return sizeof(*sint_ptr);
+  case 3: /* tcpRtoMax */
+    /* @todo not the actual value, a guess,
+        needs to be calculated */
+    *sint_ptr = 60000;
+    return sizeof(*sint_ptr);
+  case 4: /* tcpMaxConn */
+    *sint_ptr = MEMP_NUM_TCP_PCB;
+    return sizeof(*sint_ptr);
+  case 5: /* tcpActiveOpens */
+    *uint_ptr = STATS_GET(mib2.tcpactiveopens);
+    return sizeof(*uint_ptr);
+  case 6: /* tcpPassiveOpens */
+    *uint_ptr = STATS_GET(mib2.tcppassiveopens);
+    return sizeof(*uint_ptr);
+  case 7: /* tcpAttemptFails */
+    *uint_ptr = STATS_GET(mib2.tcpattemptfails);
+    return sizeof(*uint_ptr);
+  case 8: /* tcpEstabResets */
+    *uint_ptr = STATS_GET(mib2.tcpestabresets);
+    return sizeof(*uint_ptr);
+  case 9: /* tcpCurrEstab */
+    {
      u16_t tcpcurrestab = 0;
      struct tcp_pcb *pcb = tcp_active_pcbs;
      while (pcb != NULL) {
@@ -106,38 +107,30 @@ tcp_get_value(struct snmp_node_instance *instance, void *value)
      *uint_ptr = tcpcurrestab;
    }
    return sizeof(*uint_ptr);
-    case 10: /* tcpInSegs */
-      *uint_ptr = STATS_GET(mib2.tcpinsegs);
-      return sizeof(*uint_ptr);
-    case 11: /* tcpOutSegs */
-      *uint_ptr = STATS_GET(mib2.tcpoutsegs);
-      return sizeof(*uint_ptr);
-    case 12: /* tcpRetransSegs */
-      *uint_ptr = STATS_GET(mib2.tcpretranssegs);
-      return sizeof(*uint_ptr);
-    case 14: /* tcpInErrs */
-      *uint_ptr = STATS_GET(mib2.tcpinerrs);
-      return sizeof(*uint_ptr);
-    case 15: /* tcpOutRsts */
-      *uint_ptr = STATS_GET(mib2.tcpoutrsts);
-      return sizeof(*uint_ptr);
-#if LWIP_HAVE_INT64
-    case 17: { /* tcpHCInSegs */
-      /* use the 32 bit counter for now... */
-      u64_t val64 = STATS_GET(mib2.tcpinsegs);
-      *((u64_t *)value) = val64;
-    }
-    return sizeof(u64_t);
-    case 18: { /* tcpHCOutSegs */
-      /* use the 32 bit counter for now... */
-      u64_t val64 = STATS_GET(mib2.tcpoutsegs);
-      *((u64_t *)value) = val64;
-    }
-    return sizeof(u64_t);
-#endif
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("tcp_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
-      break;
+  case 10: /* tcpInSegs */
+    *uint_ptr = STATS_GET(mib2.tcpinsegs);
+    return sizeof(*uint_ptr);
+  case 11: /* tcpOutSegs */
+    *uint_ptr = STATS_GET(mib2.tcpoutsegs);
+    return sizeof(*uint_ptr);
+  case 12: /* tcpRetransSegs */
+    *uint_ptr = STATS_GET(mib2.tcpretranssegs);
+    return sizeof(*uint_ptr);
+  case 14: /* tcpInErrs */
+    *uint_ptr = STATS_GET(mib2.tcpinerrs);
+    return sizeof(*uint_ptr);
+  case 15: /* tcpOutRsts */
+    *uint_ptr = STATS_GET(mib2.tcpoutrsts);
+    return sizeof(*uint_ptr);
+  case 17: /* tcpHCInSegs */
+    memset(value, 0, 2*sizeof(u32_t)); /* not supported */
+    return 2*sizeof(u32_t);
+  case 18: /* tcpHCOutSegs */
+    memset(value, 0, 2*sizeof(u32_t)); /* not supported */
+    return 2*sizeof(u32_t);
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("tcp_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
+    break;
  }

  return 0;
@@ -162,45 +155,45 @@ static const struct snmp_oid_range tcp_ConnTable_oid_ranges[] = {
 };

 static snmp_err_t
-tcp_ConnTable_get_cell_value_core(struct tcp_pcb *pcb, const u32_t *column, union snmp_variant_value *value, u32_t *value_len)
+tcp_ConnTable_get_cell_value_core(struct tcp_pcb *pcb, const u32_t* column, union snmp_variant_value* value, u32_t* value_len)
 {
  LWIP_UNUSED_ARG(value_len);

  /* value */
  switch (*column) {
-    case 1: /* tcpConnState */
-      value->u32 = pcb->state + 1;
-      break;
-    case 2: /* tcpConnLocalAddress */
-      value->u32 = ip_2_ip4(&pcb->local_ip)->addr;
-      break;
-    case 3: /* tcpConnLocalPort */
-      value->u32 = pcb->local_port;
-      break;
-    case 4: /* tcpConnRemAddress */
-      if (pcb->state == LISTEN) {
-        value->u32 = IP4_ADDR_ANY4->addr;
-      } else {
-        value->u32 = ip_2_ip4(&pcb->remote_ip)->addr;
-      }
-      break;
-    case 5: /* tcpConnRemPort */
-      if (pcb->state == LISTEN) {
-        value->u32 = 0;
-      } else {
-        value->u32 = pcb->remote_port;
-      }
-      break;
-    default:
-      LWIP_ASSERT("invalid id", 0);
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 1: /* tcpConnState */
+    value->u32 = pcb->state + 1;
+    break;
+  case 2: /* tcpConnLocalAddress */
+    value->u32 = ip_2_ip4(&pcb->local_ip)->addr;
+    break;
+  case 3: /* tcpConnLocalPort */
+    value->u32 = pcb->local_port;
+    break;
+  case 4: /* tcpConnRemAddress */
+    if (pcb->state == LISTEN) {
+      value->u32 = IP4_ADDR_ANY4->addr;
+    } else {
+      value->u32 = ip_2_ip4(&pcb->remote_ip)->addr;
+    }
+    break;
+  case 5: /* tcpConnRemPort */
+    if (pcb->state == LISTEN) {
+      value->u32 = 0;
+    } else {
+      value->u32 = pcb->remote_port;
+    }
+    break;
+  default:
+    LWIP_ASSERT("invalid id", 0);
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-tcp_ConnTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+tcp_ConnTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  u8_t i;
  ip4_addr_t local_ip;
@@ -227,7 +220,7 @@ tcp_ConnTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
    while (pcb != NULL) {
      /* do local IP and local port match? */
      if (IP_IS_V4_VAL(pcb->local_ip) &&
-          ip4_addr_cmp(&local_ip, ip_2_ip4(&pcb->local_ip)) && (local_port == pcb->local_port)) {
+         ip4_addr_cmp(&local_ip, ip_2_ip4(&pcb->local_ip)) && (local_port == pcb->local_port)) {

        /* PCBs in state LISTEN are not connected and have no remote_ip or remote_port */
        if (pcb->state == LISTEN) {
@@ -237,7 +230,7 @@ tcp_ConnTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
          }
        } else {
          if (IP_IS_V4_VAL(pcb->remote_ip) &&
-              ip4_addr_cmp(&remote_ip, ip_2_ip4(&pcb->remote_ip)) && (remote_port == pcb->remote_port)) {
+             ip4_addr_cmp(&remote_ip, ip_2_ip4(&pcb->remote_ip)) && (remote_port == pcb->remote_port)) {
            /* fill in object properties */
            return tcp_ConnTable_get_cell_value_core(pcb, column, value, value_len);
          }
@@ -253,7 +246,7 @@ tcp_ConnTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row
 }

 static snmp_err_t
-tcp_ConnTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+tcp_ConnTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  u8_t i;
  struct tcp_pcb *pcb;
@@ -297,7 +290,7 @@ tcp_ConnTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_
  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return tcp_ConnTable_get_cell_value_core((struct tcp_pcb *)state.reference, column, value, value_len);
+    return tcp_ConnTable_get_cell_value_core((struct tcp_pcb*)state.reference, column, value, value_len);
  }

  /* not found */
@@ -309,43 +302,43 @@ tcp_ConnTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_
 /* --- tcpConnectionTable --- */

 static snmp_err_t
-tcp_ConnectionTable_get_cell_value_core(const u32_t *column, struct tcp_pcb *pcb, union snmp_variant_value *value)
+tcp_ConnectionTable_get_cell_value_core(const u32_t* column, struct tcp_pcb *pcb, union snmp_variant_value* value)
 {
  /* all items except tcpConnectionState and tcpConnectionProcess are declared as not-accessible */
  switch (*column) {
-    case 7: /* tcpConnectionState */
-      value->u32 = pcb->state + 1;
-      break;
-    case 8: /* tcpConnectionProcess */
-      value->u32 = 0; /* not supported */
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 7: /* tcpConnectionState */
+    value->u32 = pcb->state + 1;
+    break;
+  case 8: /* tcpConnectionProcess */
+    value->u32 = 0; /* not supported */
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-tcp_ConnectionTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+tcp_ConnectionTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip_addr_t local_ip, remote_ip;
  u16_t local_port, remote_port;
  struct tcp_pcb *pcb;
  u8_t idx = 0;
  u8_t i;
-  struct tcp_pcb **const tcp_pcb_nonlisten_lists[] = {&tcp_bound_pcbs, &tcp_active_pcbs, &tcp_tw_pcbs};
+  struct tcp_pcb ** const tcp_pcb_nonlisten_lists[] = {&tcp_bound_pcbs, &tcp_active_pcbs, &tcp_tw_pcbs};

  LWIP_UNUSED_ARG(value_len);

  /* tcpConnectionLocalAddressType + tcpConnectionLocalAddress + tcpConnectionLocalPort */
-  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len - idx, &local_ip, &local_port);
+  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len-idx, &local_ip, &local_port);
  if (idx == 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }

  /* tcpConnectionRemAddressType + tcpConnectionRemAddress + tcpConnectionRemPort */
-  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len - idx, &remote_ip, &remote_port);
+  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len-idx, &remote_ip, &remote_port);
  if (idx == 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }
@@ -356,9 +349,9 @@ tcp_ConnectionTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8

    while (pcb != NULL) {
      if (ip_addr_cmp(&local_ip, &pcb->local_ip) &&
-          (local_port == pcb->local_port) &&
-          ip_addr_cmp(&remote_ip, &pcb->remote_ip) &&
-          (remote_port == pcb->remote_port)) {
+         (local_port == pcb->local_port) &&
+         ip_addr_cmp(&remote_ip, &pcb->remote_ip) &&
+         (remote_port == pcb->remote_port)) {
        /* fill in object properties */
        return tcp_ConnectionTable_get_cell_value_core(column, pcb, value);
      }
@@ -371,7 +364,7 @@ tcp_ConnectionTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8
 }

 static snmp_err_t
-tcp_ConnectionTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+tcp_ConnectionTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct tcp_pcb *pcb;
  struct snmp_next_oid_state state;
@@ -379,7 +372,7 @@ tcp_ConnectionTable_get_next_cell_instance_and_value(const u32_t *column, struct
   * 1x tcpConnectionRemAddressType   + 1x OID len + 16x tcpConnectionRemAddress    + 1x tcpConnectionRemPort */
  u32_t  result_temp[38];
  u8_t i;
-  struct tcp_pcb **const tcp_pcb_nonlisten_lists[] = {&tcp_bound_pcbs, &tcp_active_pcbs, &tcp_tw_pcbs};
+  struct tcp_pcb ** const tcp_pcb_nonlisten_lists[] = {&tcp_bound_pcbs, &tcp_active_pcbs, &tcp_tw_pcbs};

  LWIP_UNUSED_ARG(value_len);

@@ -411,7 +404,7 @@ tcp_ConnectionTable_get_next_cell_instance_and_value(const u32_t *column, struct
  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return tcp_ConnectionTable_get_cell_value_core(column, (struct tcp_pcb *)state.reference, value);
+    return tcp_ConnectionTable_get_cell_value_core(column, (struct tcp_pcb*)state.reference, value);
  } else {
    /* not found */
    return SNMP_ERR_NOSUCHINSTANCE;
@@ -421,22 +414,22 @@ tcp_ConnectionTable_get_next_cell_instance_and_value(const u32_t *column, struct
 /* --- tcpListenerTable --- */

 static snmp_err_t
-tcp_ListenerTable_get_cell_value_core(const u32_t *column, union snmp_variant_value *value)
+tcp_ListenerTable_get_cell_value_core(const u32_t* column, union snmp_variant_value* value)
 {
  /* all items except tcpListenerProcess are declared as not-accessible */
  switch (*column) {
-    case 4: /* tcpListenerProcess */
-      value->u32 = 0; /* not supported */
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 4: /* tcpListenerProcess */
+    value->u32 = 0; /* not supported */
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-tcp_ListenerTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+tcp_ListenerTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip_addr_t local_ip;
  u16_t local_port;
@@ -446,7 +439,7 @@ tcp_ListenerTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t
  LWIP_UNUSED_ARG(value_len);

  /* tcpListenerLocalAddressType + tcpListenerLocalAddress + tcpListenerLocalPort */
-  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len - idx, &local_ip, &local_port);
+  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len-idx, &local_ip, &local_port);
  if (idx == 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }
@@ -455,7 +448,7 @@ tcp_ListenerTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t
  pcb = tcp_listen_pcbs.listen_pcbs;
  while (pcb != NULL) {
    if (ip_addr_cmp(&local_ip, &pcb->local_ip) &&
-        (local_port == pcb->local_port)) {
+       (local_port == pcb->local_port)) {
      /* fill in object properties */
      return tcp_ListenerTable_get_cell_value_core(column, value);
    }
@@ -467,7 +460,7 @@ tcp_ListenerTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t
 }

 static snmp_err_t
-tcp_ListenerTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+tcp_ListenerTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct tcp_pcb_listen *pcb;
  struct snmp_next_oid_state state;
@@ -519,10 +512,8 @@ static const struct snmp_scalar_node tcp_OutSegs       = SNMP_SCALAR_CREATE_NODE
 static const struct snmp_scalar_node tcp_RetransSegs   = SNMP_SCALAR_CREATE_NODE_READONLY(12, SNMP_ASN1_TYPE_COUNTER, tcp_get_value);
 static const struct snmp_scalar_node tcp_InErrs        = SNMP_SCALAR_CREATE_NODE_READONLY(14, SNMP_ASN1_TYPE_COUNTER, tcp_get_value);
 static const struct snmp_scalar_node tcp_OutRsts       = SNMP_SCALAR_CREATE_NODE_READONLY(15, SNMP_ASN1_TYPE_COUNTER, tcp_get_value);
-#if LWIP_HAVE_INT64
 static const struct snmp_scalar_node tcp_HCInSegs      = SNMP_SCALAR_CREATE_NODE_READONLY(17, SNMP_ASN1_TYPE_COUNTER64, tcp_get_value);
 static const struct snmp_scalar_node tcp_HCOutSegs     = SNMP_SCALAR_CREATE_NODE_READONLY(18, SNMP_ASN1_TYPE_COUNTER64, tcp_get_value);
-#endif

 #if LWIP_IPV4
 static const struct snmp_table_simple_col_def tcp_ConnTable_columns[] = {
@@ -570,14 +561,12 @@ CREATE_LWIP_SYNC_NODE(13, tcp_ConnTable)
 #endif /* LWIP_IPV4 */
 CREATE_LWIP_SYNC_NODE(14, tcp_InErrs)
 CREATE_LWIP_SYNC_NODE(15, tcp_OutRsts)
-#if LWIP_HAVE_INT64
 CREATE_LWIP_SYNC_NODE(17, tcp_HCInSegs)
 CREATE_LWIP_SYNC_NODE(18, tcp_HCOutSegs)
-#endif
 CREATE_LWIP_SYNC_NODE(19, tcp_ConnectionTable)
 CREATE_LWIP_SYNC_NODE(20, tcp_ListenerTable)

-static const struct snmp_node *const tcp_nodes[] = {
+static const struct snmp_node* const tcp_nodes[] = {
  &SYNC_NODE_NAME(tcp_RtoAlgorithm).node.node,
  &SYNC_NODE_NAME(tcp_RtoMin).node.node,
  &SYNC_NODE_NAME(tcp_RtoMax).node.node,
@@ -596,10 +585,8 @@ static const struct snmp_node *const tcp_nodes[] = {
  &SYNC_NODE_NAME(tcp_InErrs).node.node,
  &SYNC_NODE_NAME(tcp_OutRsts).node.node,
  &SYNC_NODE_NAME(tcp_HCInSegs).node.node,
-#if LWIP_HAVE_INT64
  &SYNC_NODE_NAME(tcp_HCOutSegs).node.node,
  &SYNC_NODE_NAME(tcp_ConnectionTable).node.node,
-#endif
  &SYNC_NODE_NAME(tcp_ListenerTable).node.node
 };

--- a/src/apps/snmp/snmp_mib2_udp.c
+++ b/src/apps/snmp/snmp_mib2_udp.c
@@ -58,40 +58,32 @@
 /* --- udp .1.3.6.1.2.1.7 ----------------------------------------------------- */

 static s16_t
-udp_get_value(struct snmp_node_instance *instance, void *value)
+udp_get_value(struct snmp_node_instance* instance, void* value)
 {
-  u32_t *uint_ptr = (u32_t *)value;
+  u32_t *uint_ptr = (u32_t*)value;

  switch (instance->node->oid) {
-    case 1: /* udpInDatagrams */
-      *uint_ptr = STATS_GET(mib2.udpindatagrams);
-      return sizeof(*uint_ptr);
-    case 2: /* udpNoPorts */
-      *uint_ptr = STATS_GET(mib2.udpnoports);
-      return sizeof(*uint_ptr);
-    case 3: /* udpInErrors */
-      *uint_ptr = STATS_GET(mib2.udpinerrors);
-      return sizeof(*uint_ptr);
-    case 4: /* udpOutDatagrams */
-      *uint_ptr = STATS_GET(mib2.udpoutdatagrams);
-      return sizeof(*uint_ptr);
-#if LWIP_HAVE_INT64
-    case 8: { /* udpHCInDatagrams */
-      /* use the 32 bit counter for now... */
-      u64_t val64 = STATS_GET(mib2.udpindatagrams);
-      *((u64_t *)value) = val64;
-    }
-    return sizeof(u64_t);
-    case 9: { /* udpHCOutDatagrams */
-      /* use the 32 bit counter for now... */
-      u64_t val64 = STATS_GET(mib2.udpoutdatagrams);
-      *((u64_t *)value) = val64;
-    }
-    return sizeof(u64_t);
-#endif
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("udp_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
-      break;
+  case 1: /* udpInDatagrams */
+    *uint_ptr = STATS_GET(mib2.udpindatagrams);
+    return sizeof(*uint_ptr);
+  case 2: /* udpNoPorts */
+    *uint_ptr = STATS_GET(mib2.udpnoports);
+    return sizeof(*uint_ptr);
+  case 3: /* udpInErrors */
+    *uint_ptr = STATS_GET(mib2.udpinerrors);
+    return sizeof(*uint_ptr);
+  case 4: /* udpOutDatagrams */
+    *uint_ptr = STATS_GET(mib2.udpoutdatagrams);
+    return sizeof(*uint_ptr);
+  case 8: /* udpHCInDatagrams */
+    memset(value, 0, 2*sizeof(u32_t)); /* not supported */
+    return 2*sizeof(u32_t);
+  case 9: /* udpHCOutDatagrams */
+    memset(value, 0, 2*sizeof(u32_t)); /* not supported */
+    return 2*sizeof(u32_t);
+  default:
+    LWIP_DEBUGF(SNMP_MIB_DEBUG,("udp_get_value(): unknown id: %"S32_F"\n", instance->node->oid));
+    break;
  }

  return 0;
@@ -100,22 +92,22 @@ udp_get_value(struct snmp_node_instance *instance, void *value)
 /* --- udpEndpointTable --- */

 static snmp_err_t
-udp_endpointTable_get_cell_value_core(const u32_t *column, union snmp_variant_value *value)
+udp_endpointTable_get_cell_value_core(const u32_t* column, union snmp_variant_value* value)
 {
  /* all items except udpEndpointProcess are declared as not-accessible */
  switch (*column) {
-    case 8: /* udpEndpointProcess */
-      value->u32 = 0; /* not supported */
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 8: /* udpEndpointProcess */
+    value->u32 = 0; /* not supported */
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

 static snmp_err_t
-udp_endpointTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+udp_endpointTable_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip_addr_t local_ip, remote_ip;
  u16_t local_port, remote_port;
@@ -125,32 +117,32 @@ udp_endpointTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t
  LWIP_UNUSED_ARG(value_len);

  /* udpEndpointLocalAddressType + udpEndpointLocalAddress + udpEndpointLocalPort */
-  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len - idx, &local_ip, &local_port);
+  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len-idx, &local_ip, &local_port);
  if (idx == 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }

  /* udpEndpointRemoteAddressType + udpEndpointRemoteAddress + udpEndpointRemotePort */
-  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len - idx, &remote_ip, &remote_port);
+  idx += snmp_oid_to_ip_port(&row_oid[idx], row_oid_len-idx, &remote_ip, &remote_port);
  if (idx == 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }

  /* udpEndpointInstance */
-  if (row_oid_len < (idx + 1)) {
+  if (row_oid_len < (idx+1)) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }
  if (row_oid[idx] != 0) {
    return SNMP_ERR_NOSUCHINSTANCE;
  }
-
+  
  /* find udp_pcb with requested ip and port*/
  pcb = udp_pcbs;
  while (pcb != NULL) {
    if (ip_addr_cmp(&local_ip, &pcb->local_ip) &&
-        (local_port == pcb->local_port) &&
-        ip_addr_cmp(&remote_ip, &pcb->remote_ip) &&
-        (remote_port == pcb->remote_port)) {
+       (local_port == pcb->local_port) &&
+       ip_addr_cmp(&remote_ip, &pcb->remote_ip) &&
+       (remote_port == pcb->remote_port)) {
      /* fill in object properties */
      return udp_endpointTable_get_cell_value_core(column, value);
    }
@@ -161,8 +153,8 @@ udp_endpointTable_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t
  return SNMP_ERR_NOSUCHINSTANCE;
 }

-static snmp_err_t
-udp_endpointTable_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+static snmp_err_t 
+udp_endpointTable_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct udp_pcb *pcb;
  struct snmp_next_oid_state state;
@@ -189,12 +181,12 @@ udp_endpointTable_get_next_cell_instance_and_value(const u32_t *column, struct s
    /* udpEndpointRemoteAddressType + udpEndpointRemoteAddress + udpEndpointRemotePort */
    idx += snmp_ip_port_to_oid(&pcb->remote_ip, pcb->remote_port, &test_oid[idx]);

-    test_oid[idx] = 0; /* udpEndpointInstance */
+    test_oid[idx] = 0; /* udpEndpointInstance */    
    idx++;
-
+    
    /* check generated OID: is it a candidate for the next one? */
    snmp_next_oid_check(&state, test_oid, idx, NULL);
-
+    
    pcb = pcb->next;
  }

@@ -222,29 +214,29 @@ static const struct snmp_oid_range udp_Table_oid_ranges[] = {
  { 1, 0xffff }  /* Port        */
 };

-static snmp_err_t
-udp_Table_get_cell_value_core(struct udp_pcb *pcb, const u32_t *column, union snmp_variant_value *value, u32_t *value_len)
+static snmp_err_t 
+udp_Table_get_cell_value_core(struct udp_pcb *pcb, const u32_t* column, union snmp_variant_value* value, u32_t* value_len)
 {
  LWIP_UNUSED_ARG(value_len);

  switch (*column) {
-    case 1: /* udpLocalAddress */
-      /* set reference to PCB local IP and return a generic node that copies IP4 addresses */
-      value->u32 = ip_2_ip4(&pcb->local_ip)->addr;
-      break;
-    case 2: /* udpLocalPort */
-      /* set reference to PCB local port and return a generic node that copies u16_t values */
-      value->u32 = pcb->local_port;
-      break;
-    default:
-      return SNMP_ERR_NOSUCHINSTANCE;
+  case 1: /* udpLocalAddress */
+    /* set reference to PCB local IP and return a generic node that copies IP4 addresses */
+    value->u32 = ip_2_ip4(&pcb->local_ip)->addr;
+    break;
+  case 2: /* udpLocalPort */
+    /* set reference to PCB local port and return a generic node that copies u16_t values */
+    value->u32 = pcb->local_port;
+    break;
+  default:
+    return SNMP_ERR_NOSUCHINSTANCE;
  }

  return SNMP_ERR_NOERROR;
 }

-static snmp_err_t
-udp_Table_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, union snmp_variant_value *value, u32_t *value_len)
+static snmp_err_t 
+udp_Table_get_cell_value(const u32_t* column, const u32_t* row_oid, u8_t row_oid_len, union snmp_variant_value* value, u32_t* value_len)
 {
  ip4_addr_t ip;
  u16_t port;
@@ -275,8 +267,8 @@ udp_Table_get_cell_value(const u32_t *column, const u32_t *row_oid, u8_t row_oid
  return SNMP_ERR_NOSUCHINSTANCE;
 }

-static snmp_err_t
-udp_Table_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_id *row_oid, union snmp_variant_value *value, u32_t *value_len)
+static snmp_err_t 
+udp_Table_get_next_cell_instance_and_value(const u32_t* column, struct snmp_obj_id* row_oid, union snmp_variant_value* value, u32_t* value_len)
 {
  struct udp_pcb *pcb;
  struct snmp_next_oid_state state;
@@ -297,7 +289,7 @@ udp_Table_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_
      /* check generated OID: is it a candidate for the next one? */
      snmp_next_oid_check(&state, test_oid, LWIP_ARRAYSIZE(udp_Table_oid_ranges), pcb);
    }
-
+    
    pcb = pcb->next;
  }

@@ -305,7 +297,7 @@ udp_Table_get_next_cell_instance_and_value(const u32_t *column, struct snmp_obj_
  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
    /* fill in object properties */
-    return udp_Table_get_cell_value_core((struct udp_pcb *)state.reference, column, value, value_len);
+    return udp_Table_get_cell_value_core((struct udp_pcb*)state.reference, column, value, value_len);
  } else {
    /* not found */
    return SNMP_ERR_NOSUCHINSTANCE;
@@ -318,10 +310,8 @@ static const struct snmp_scalar_node udp_inDatagrams    = SNMP_SCALAR_CREATE_NOD
 static const struct snmp_scalar_node udp_noPorts        = SNMP_SCALAR_CREATE_NODE_READONLY(2, SNMP_ASN1_TYPE_COUNTER,   udp_get_value);
 static const struct snmp_scalar_node udp_inErrors       = SNMP_SCALAR_CREATE_NODE_READONLY(3, SNMP_ASN1_TYPE_COUNTER,   udp_get_value);
 static const struct snmp_scalar_node udp_outDatagrams   = SNMP_SCALAR_CREATE_NODE_READONLY(4, SNMP_ASN1_TYPE_COUNTER,   udp_get_value);
-#if LWIP_HAVE_INT64
 static const struct snmp_scalar_node udp_HCInDatagrams  = SNMP_SCALAR_CREATE_NODE_READONLY(8, SNMP_ASN1_TYPE_COUNTER64, udp_get_value);
 static const struct snmp_scalar_node udp_HCOutDatagrams = SNMP_SCALAR_CREATE_NODE_READONLY(9, SNMP_ASN1_TYPE_COUNTER64, udp_get_value);
-#endif

 #if LWIP_IPV4
 static const struct snmp_table_simple_col_def udp_Table_columns[] = {
@@ -332,13 +322,13 @@ static const struct snmp_table_simple_node udp_Table = SNMP_TABLE_CREATE_SIMPLE(
 #endif /* LWIP_IPV4 */

 static const struct snmp_table_simple_col_def udp_endpointTable_columns[] = {
-  /* all items except udpEndpointProcess are declared as not-accessible */
+  /* all items except udpEndpointProcess are declared as not-accessible */   
  { 8, SNMP_ASN1_TYPE_UNSIGNED32, SNMP_VARIANT_VALUE_TYPE_U32 }  /* udpEndpointProcess */
 };

 static const struct snmp_table_simple_node udp_endpointTable = SNMP_TABLE_CREATE_SIMPLE(7, udp_endpointTable_columns, udp_endpointTable_get_cell_value, udp_endpointTable_get_next_cell_instance_and_value);

-/* the following nodes access variables in LWIP stack from SNMP worker thread and must therefore be synced to LWIP (TCPIP) thread */
+/* the following nodes access variables in LWIP stack from SNMP worker thread and must therefore be synced to LWIP (TCPIP) thread */ 
 CREATE_LWIP_SYNC_NODE(1, udp_inDatagrams)
 CREATE_LWIP_SYNC_NODE(2, udp_noPorts)
 CREATE_LWIP_SYNC_NODE(3, udp_inErrors)
@@ -347,12 +337,10 @@ CREATE_LWIP_SYNC_NODE(4, udp_outDatagrams)
 CREATE_LWIP_SYNC_NODE(5, udp_Table)
 #endif /* LWIP_IPV4 */
 CREATE_LWIP_SYNC_NODE(7, udp_endpointTable)
-#if LWIP_HAVE_INT64
 CREATE_LWIP_SYNC_NODE(8, udp_HCInDatagrams)
 CREATE_LWIP_SYNC_NODE(9, udp_HCOutDatagrams)
-#endif

-static const struct snmp_node *const udp_nodes[] = {
+static const struct snmp_node* const udp_nodes[] = {
  &SYNC_NODE_NAME(udp_inDatagrams).node.node,
  &SYNC_NODE_NAME(udp_noPorts).node.node,
  &SYNC_NODE_NAME(udp_inErrors).node.node,
@@ -360,12 +348,9 @@ static const struct snmp_node *const udp_nodes[] = {
 #if LWIP_IPV4
  &SYNC_NODE_NAME(udp_Table).node.node,
 #endif /* LWIP_IPV4 */
-  &SYNC_NODE_NAME(udp_endpointTable).node.node
-#if LWIP_HAVE_INT64
-  ,
+  &SYNC_NODE_NAME(udp_endpointTable).node.node,
  &SYNC_NODE_NAME(udp_HCInDatagrams).node.node,
  &SYNC_NODE_NAME(udp_HCOutDatagrams).node.node
-#endif
 };

 const struct snmp_tree_node snmp_mib2_udp_root = SNMP_CREATE_TREE_NODE(7, udp_nodes);
--- a/src/apps/snmp/snmp_msg.c
+++ b/src/apps/snmp/snmp_msg.c
--- a/src/apps/snmp/snmp_msg.h
+++ b/src/apps/snmp/snmp_msg.h
@@ -57,12 +57,24 @@
 extern "C" {
 #endif

+/* The listen port of the SNMP agent. Clients have to make their requests to
+   this port. Most standard clients won't work if you change this! */
+#ifndef SNMP_IN_PORT
+#define SNMP_IN_PORT 161
+#endif
+/* The remote port the SNMP agent sends traps to. Most standard trap sinks won't
+   work if you change this! */
+#ifndef SNMP_TRAP_PORT
+#define SNMP_TRAP_PORT 162
+#endif
+
 /* version defines used in PDU */
 #define SNMP_VERSION_1  0
 #define SNMP_VERSION_2c 1
 #define SNMP_VERSION_3  3

-struct snmp_varbind_enumerator {
+struct snmp_varbind_enumerator
+{
  struct snmp_pbuf_stream pbuf_stream;
  u16_t varbind_count;
 };
@@ -74,10 +86,11 @@ typedef enum {
  SNMP_VB_ENUMERATOR_ERR_INVALIDLENGTH = 3
 } snmp_vb_enumerator_err_t;

-void snmp_vb_enumerator_init(struct snmp_varbind_enumerator *enumerator, struct pbuf *p, u16_t offset, u16_t length);
-snmp_vb_enumerator_err_t snmp_vb_enumerator_get_next(struct snmp_varbind_enumerator *enumerator, struct snmp_varbind *varbind);
+void snmp_vb_enumerator_init(struct snmp_varbind_enumerator* enumerator, struct pbuf* p, u16_t offset, u16_t length);
+snmp_vb_enumerator_err_t snmp_vb_enumerator_get_next(struct snmp_varbind_enumerator* enumerator, struct snmp_varbind* varbind);

-struct snmp_request {
+struct snmp_request
+{
  /* Communication handle */
  void *handle;
  /* source IP address */
@@ -102,10 +115,7 @@ struct snmp_request {
  s32_t non_repeaters;
  /* max-repetitions (getBulkRequest (SNMPv2c)) */
  s32_t max_repetitions;
-
-  /* Usually response-pdu (2). When snmpv3 errors are detected report-pdu(8) */
-  u8_t request_out_type;
-
+  
 #if LWIP_SNMP_V3
  s32_t msg_id;
  s32_t msg_max_size;
@@ -118,9 +128,7 @@ struct snmp_request {
  u8_t  msg_user_name[SNMP_V3_MAX_USER_LENGTH];
  u8_t  msg_user_name_len;
  u8_t  msg_authentication_parameters[SNMP_V3_MAX_AUTH_PARAM_LENGTH];
-  u8_t  msg_authentication_parameters_len;
  u8_t  msg_privacy_parameters[SNMP_V3_MAX_PRIV_PARAM_LENGTH];
-  u8_t  msg_privacy_parameters_len;
  u8_t  context_engine_id[SNMP_V3_MAX_ENGINE_ID_LENGTH];
  u8_t  context_engine_id_len;
  u8_t  context_name[SNMP_V3_MAX_ENGINE_ID_LENGTH];
@@ -154,7 +162,8 @@ struct snmp_request {
 };

 /** A helper struct keeping length information about varbinds */
-struct snmp_varbind_len {
+struct snmp_varbind_len
+{
  u8_t  vb_len_len;
  u16_t vb_value_len;
  u8_t  oid_len_len;
@@ -168,13 +177,13 @@ extern const char *snmp_community;
 /** Agent community string for write access */
 extern const char *snmp_community_write;
 /** handle for sending traps */
-extern void *snmp_traps_handle;
+extern void* snmp_traps_handle;

 void snmp_receive(void *handle, struct pbuf *p, const ip_addr_t *source_ip, u16_t port);
 err_t snmp_sendto(void *handle, struct pbuf *p, const ip_addr_t *dst, u16_t port);
-u8_t snmp_get_local_ip_for_dst(void *handle, const ip_addr_t *dst, ip_addr_t *result);
+u8_t snmp_get_local_ip_for_dst(void* handle, const ip_addr_t *dst, ip_addr_t *result);
 err_t snmp_varbind_length(struct snmp_varbind *varbind, struct snmp_varbind_len *len);
-err_t snmp_append_outbound_varbind(struct snmp_pbuf_stream *pbuf_stream, struct snmp_varbind *varbind);
+err_t snmp_append_outbound_varbind(struct snmp_pbuf_stream *pbuf_stream, struct snmp_varbind* varbind);

 #ifdef __cplusplus
 }
--- a/src/apps/snmp/snmp_netconn.c
+++ b/src/apps/snmp/snmp_netconn.c
@@ -42,7 +42,6 @@
 #include "lwip/udp.h"
 #include "snmp_msg.h"
 #include "lwip/sys.h"
-#include "lwip/prot/iana.h"

 /** SNMP netconn API worker thread */
 static void
@@ -52,17 +51,17 @@ snmp_netconn_thread(void *arg)
  struct netbuf *buf;
  err_t err;
  LWIP_UNUSED_ARG(arg);
-
+  
  /* Bind to SNMP port with default IP address */
 #if LWIP_IPV6
  conn = netconn_new(NETCONN_UDP_IPV6);
-  netconn_bind(conn, IP6_ADDR_ANY, LWIP_IANA_PORT_SNMP);
+  netconn_bind(conn, IP6_ADDR_ANY, SNMP_IN_PORT);
 #else /* LWIP_IPV6 */
  conn = netconn_new(NETCONN_UDP);
-  netconn_bind(conn, IP4_ADDR_ANY, LWIP_IANA_PORT_SNMP);
+  netconn_bind(conn, IP4_ADDR_ANY, SNMP_IN_PORT);
 #endif /* LWIP_IPV6 */
  LWIP_ERROR("snmp_netconn: invalid conn", (conn != NULL), return;);
-
+  
  snmp_traps_handle = conn;

  do {
@@ -75,28 +74,28 @@ snmp_netconn_thread(void *arg)
    if (buf != NULL) {
      netbuf_delete(buf);
    }
-  } while (1);
+  } while(1);
 }

-err_t
+err_t 
 snmp_sendto(void *handle, struct pbuf *p, const ip_addr_t *dst, u16_t port)
 {
  err_t result;
  struct netbuf buf;
-
+  
  memset(&buf, 0, sizeof(buf));
  buf.p = p;
-  result = netconn_sendto((struct netconn *)handle, &buf, dst, port);
-
+  result = netconn_sendto((struct netconn*)handle, &buf, dst, port);
+  
  return result;
 }

 u8_t
-snmp_get_local_ip_for_dst(void *handle, const ip_addr_t *dst, ip_addr_t *result)
+snmp_get_local_ip_for_dst(void* handle, const ip_addr_t *dst, ip_addr_t *result)
 {
-  struct netconn *conn = (struct netconn *)handle;
+  struct netconn* conn = (struct netconn*)handle;
  struct netif *dst_if;
-  const ip_addr_t *dst_ip;
+  const ip_addr_t* dst_ip;

  LWIP_UNUSED_ARG(conn); /* unused in case of IPV4 only configuration */

@@ -116,7 +115,6 @@ snmp_get_local_ip_for_dst(void *handle, const ip_addr_t *dst, ip_addr_t *result)
 void
 snmp_init(void)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  sys_thread_new("snmp_netconn", snmp_netconn_thread, NULL, SNMP_STACK_SIZE, SNMP_THREAD_PRIO);
 }

--- a/src/apps/snmp/snmp_pbuf_stream.c
+++ b/src/apps/snmp/snmp_pbuf_stream.c
@@ -44,7 +44,7 @@
 #include <string.h>

 err_t
-snmp_pbuf_stream_init(struct snmp_pbuf_stream *pbuf_stream, struct pbuf *p, u16_t offset, u16_t length)
+snmp_pbuf_stream_init(struct snmp_pbuf_stream* pbuf_stream, struct pbuf* p, u16_t offset, u16_t length)
 {
  pbuf_stream->offset = offset;
  pbuf_stream->length = length;
@@ -54,7 +54,7 @@ snmp_pbuf_stream_init(struct snmp_pbuf_stream *pbuf_stream, struct pbuf *p, u16_
 }

 err_t
-snmp_pbuf_stream_read(struct snmp_pbuf_stream *pbuf_stream, u8_t *data)
+snmp_pbuf_stream_read(struct snmp_pbuf_stream* pbuf_stream, u8_t* data)
 {
  if (pbuf_stream->length == 0) {
    return ERR_BUF;
@@ -71,13 +71,13 @@ snmp_pbuf_stream_read(struct snmp_pbuf_stream *pbuf_stream, u8_t *data)
 }

 err_t
-snmp_pbuf_stream_write(struct snmp_pbuf_stream *pbuf_stream, u8_t data)
+snmp_pbuf_stream_write(struct snmp_pbuf_stream* pbuf_stream, u8_t data)
 {
  return snmp_pbuf_stream_writebuf(pbuf_stream, &data, 1);
 }

 err_t
-snmp_pbuf_stream_writebuf(struct snmp_pbuf_stream *pbuf_stream, const void *buf, u16_t buf_len)
+snmp_pbuf_stream_writebuf(struct snmp_pbuf_stream* pbuf_stream, const void* buf, u16_t buf_len)
 {
  if (pbuf_stream->length < buf_len) {
    return ERR_BUF;
@@ -94,7 +94,7 @@ snmp_pbuf_stream_writebuf(struct snmp_pbuf_stream *pbuf_stream, const void *buf,
 }

 err_t
-snmp_pbuf_stream_writeto(struct snmp_pbuf_stream *pbuf_stream, struct snmp_pbuf_stream *target_pbuf_stream, u16_t len)
+snmp_pbuf_stream_writeto(struct snmp_pbuf_stream* pbuf_stream, struct snmp_pbuf_stream* target_pbuf_stream, u16_t len)
 {

  if ((pbuf_stream == NULL) || (target_pbuf_stream == NULL)) {
@@ -112,14 +112,14 @@ snmp_pbuf_stream_writeto(struct snmp_pbuf_stream *pbuf_stream, struct snmp_pbuf_
    u16_t chunk_len;
    err_t err;
    u16_t target_offset;
-    struct pbuf *pbuf = pbuf_skip(pbuf_stream->pbuf, pbuf_stream->offset, &target_offset);
+    struct pbuf* pbuf = pbuf_skip(pbuf_stream->pbuf, pbuf_stream->offset, &target_offset);

    if ((pbuf == NULL) || (pbuf->len == 0)) {
      return ERR_BUF;
    }

    chunk_len = LWIP_MIN(len, pbuf->len);
-    err = snmp_pbuf_stream_writebuf(target_pbuf_stream, &((u8_t *)pbuf->payload)[target_offset], chunk_len);
+    err = snmp_pbuf_stream_writebuf(target_pbuf_stream, &((u8_t*)pbuf->payload)[target_offset], chunk_len);
    if (err != ERR_OK) {
      return err;
    }
@@ -133,7 +133,7 @@ snmp_pbuf_stream_writeto(struct snmp_pbuf_stream *pbuf_stream, struct snmp_pbuf_
 }

 err_t
-snmp_pbuf_stream_seek(struct snmp_pbuf_stream *pbuf_stream, s32_t offset)
+snmp_pbuf_stream_seek(struct snmp_pbuf_stream* pbuf_stream, s32_t offset)
 {
  if ((offset < 0) || (offset > pbuf_stream->length)) {
    /* we cannot seek backwards or forward behind stream end */
@@ -147,7 +147,7 @@ snmp_pbuf_stream_seek(struct snmp_pbuf_stream *pbuf_stream, s32_t offset)
 }

 err_t
-snmp_pbuf_stream_seek_abs(struct snmp_pbuf_stream *pbuf_stream, u32_t offset)
+snmp_pbuf_stream_seek_abs(struct snmp_pbuf_stream* pbuf_stream, u32_t offset)
 {
  s32_t rel_offset = offset - pbuf_stream->offset;
  return snmp_pbuf_stream_seek(pbuf_stream, rel_offset);
--- a/src/apps/snmp/snmp_pbuf_stream.h
+++ b/src/apps/snmp/snmp_pbuf_stream.h
@@ -49,19 +49,20 @@
 extern "C" {
 #endif

-struct snmp_pbuf_stream {
-  struct pbuf *pbuf;
+struct snmp_pbuf_stream
+{
+  struct pbuf* pbuf;
  u16_t offset;
  u16_t length;
 };

-err_t snmp_pbuf_stream_init(struct snmp_pbuf_stream *pbuf_stream, struct pbuf *p, u16_t offset, u16_t length);
-err_t snmp_pbuf_stream_read(struct snmp_pbuf_stream *pbuf_stream, u8_t *data);
-err_t snmp_pbuf_stream_write(struct snmp_pbuf_stream *pbuf_stream, u8_t data);
-err_t snmp_pbuf_stream_writebuf(struct snmp_pbuf_stream *pbuf_stream, const void *buf, u16_t buf_len);
-err_t snmp_pbuf_stream_writeto(struct snmp_pbuf_stream *pbuf_stream, struct snmp_pbuf_stream *target_pbuf_stream, u16_t len);
-err_t snmp_pbuf_stream_seek(struct snmp_pbuf_stream *pbuf_stream, s32_t offset);
-err_t snmp_pbuf_stream_seek_abs(struct snmp_pbuf_stream *pbuf_stream, u32_t offset);
+err_t snmp_pbuf_stream_init(struct snmp_pbuf_stream* pbuf_stream, struct pbuf* p, u16_t offset, u16_t length);
+err_t snmp_pbuf_stream_read(struct snmp_pbuf_stream* pbuf_stream, u8_t* data);
+err_t snmp_pbuf_stream_write(struct snmp_pbuf_stream* pbuf_stream, u8_t data);
+err_t snmp_pbuf_stream_writebuf(struct snmp_pbuf_stream* pbuf_stream, const void* buf, u16_t buf_len);
+err_t snmp_pbuf_stream_writeto(struct snmp_pbuf_stream* pbuf_stream, struct snmp_pbuf_stream* target_pbuf_stream, u16_t len);
+err_t snmp_pbuf_stream_seek(struct snmp_pbuf_stream* pbuf_stream, s32_t offset);
+err_t snmp_pbuf_stream_seek_abs(struct snmp_pbuf_stream* pbuf_stream, u32_t offset);

 #ifdef __cplusplus
 }
--- a/src/apps/snmp/snmp_raw.c
+++ b/src/apps/snmp/snmp_raw.c
@@ -39,7 +39,6 @@

 #include "lwip/udp.h"
 #include "lwip/ip.h"
-#include "lwip/prot/iana.h"
 #include "snmp_msg.h"

 /* lwIP UDP receive callback function */
@@ -53,18 +52,18 @@ snmp_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
  pbuf_free(p);
 }

-err_t
+err_t 
 snmp_sendto(void *handle, struct pbuf *p, const ip_addr_t *dst, u16_t port)
 {
-  return udp_sendto((struct udp_pcb *)handle, p, dst, port);
+  return udp_sendto((struct udp_pcb*)handle, p, dst, port);
 }

 u8_t
-snmp_get_local_ip_for_dst(void *handle, const ip_addr_t *dst, ip_addr_t *result)
+snmp_get_local_ip_for_dst(void* handle, const ip_addr_t *dst, ip_addr_t *result)
 {
-  struct udp_pcb *udp_pcb = (struct udp_pcb *)handle;
+  struct udp_pcb* udp_pcb = (struct udp_pcb*)handle;
  struct netif *dst_if;
-  const ip_addr_t *dst_ip;
+  const ip_addr_t* dst_ip;

  LWIP_UNUSED_ARG(udp_pcb); /* unused in case of IPV4 only configuration */

@@ -87,16 +86,14 @@ void
 snmp_init(void)
 {
  err_t err;
-
+  
  struct udp_pcb *snmp_pcb = udp_new_ip_type(IPADDR_TYPE_ANY);
  LWIP_ERROR("snmp_raw: no PCB", (snmp_pcb != NULL), return;);

-  LWIP_ASSERT_CORE_LOCKED();
-
  snmp_traps_handle = snmp_pcb;

-  udp_recv(snmp_pcb, snmp_recv, NULL);
-  err = udp_bind(snmp_pcb, IP_ANY_TYPE, LWIP_IANA_PORT_SNMP);
+  udp_recv(snmp_pcb, snmp_recv, (void *)SNMP_IN_PORT);
+  err = udp_bind(snmp_pcb, IP_ANY_TYPE, SNMP_IN_PORT);
  LWIP_ERROR("snmp_raw: Unable to bind PCB", (err == ERR_OK), return;);
 }

--- a/src/apps/snmp/snmp_scalar.c
+++ b/src/apps/snmp/snmp_scalar.c
@@ -42,14 +42,14 @@
 #include "lwip/apps/snmp_scalar.h"
 #include "lwip/apps/snmp_core.h"

-static s16_t snmp_scalar_array_get_value(struct snmp_node_instance *instance, void *value);
-static snmp_err_t  snmp_scalar_array_set_test(struct snmp_node_instance *instance, u16_t value_len, void *value);
-static snmp_err_t  snmp_scalar_array_set_value(struct snmp_node_instance *instance, u16_t value_len, void *value);
+static s16_t snmp_scalar_array_get_value(struct snmp_node_instance* instance, void* value);
+static snmp_err_t  snmp_scalar_array_set_test(struct snmp_node_instance* instance, u16_t value_len, void* value);
+static snmp_err_t  snmp_scalar_array_set_value(struct snmp_node_instance* instance, u16_t value_len, void* value);

-snmp_err_t
-snmp_scalar_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t 
+snmp_scalar_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
-  const struct snmp_scalar_node *scalar_node = (const struct snmp_scalar_node *)(const void *)instance->node;
+  const struct snmp_scalar_node* scalar_node = (const struct snmp_scalar_node*)(const void*)instance->node;

  LWIP_UNUSED_ARG(root_oid);
  LWIP_UNUSED_ARG(root_oid_len);
@@ -67,8 +67,8 @@ snmp_scalar_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_n
  return SNMP_ERR_NOERROR;
 }

-snmp_err_t
-snmp_scalar_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t 
+snmp_scalar_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  /* because our only instance is .0 we can only return a next instance if no instance oid is passed */
  if (instance->instance_oid.len == 0) {
@@ -83,14 +83,14 @@ snmp_scalar_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct s


 snmp_err_t
-snmp_scalar_array_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_scalar_array_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  LWIP_UNUSED_ARG(root_oid);
  LWIP_UNUSED_ARG(root_oid_len);

  if ((instance->instance_oid.len == 2) && (instance->instance_oid.id[1] == 0)) {
-    const struct snmp_scalar_array_node *array_node = (const struct snmp_scalar_array_node *)(const void *)instance->node;
-    const struct snmp_scalar_array_node_def *array_node_def = array_node->array_nodes;
+    const struct snmp_scalar_array_node* array_node = (const struct snmp_scalar_array_node*)(const void*)instance->node;
+    const struct snmp_scalar_array_node_def* array_node_def = array_node->array_nodes;
    u32_t i = 0;

    while (i < array_node->array_node_count) {
@@ -118,11 +118,11 @@ snmp_scalar_array_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct
 }

 snmp_err_t
-snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
-  const struct snmp_scalar_array_node *array_node = (const struct snmp_scalar_array_node *)(const void *)instance->node;
-  const struct snmp_scalar_array_node_def *array_node_def = array_node->array_nodes;
-  const struct snmp_scalar_array_node_def *result = NULL;
+  const struct snmp_scalar_array_node* array_node = (const struct snmp_scalar_array_node*)(const void*)instance->node;
+  const struct snmp_scalar_array_node_def* array_node_def = array_node->array_nodes;
+  const struct snmp_scalar_array_node_def* result = NULL;

  LWIP_UNUSED_ARG(root_oid);
  LWIP_UNUSED_ARG(root_oid_len);
@@ -130,7 +130,7 @@ snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, st
  if ((instance->instance_oid.len == 0) && (array_node->array_node_count > 0)) {
    /* return node with lowest OID */
    u16_t i = 0;
-
+    
    result = array_node_def;
    array_node_def++;

@@ -142,7 +142,7 @@ snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, st
    }
  } else if (instance->instance_oid.len >= 1) {
    if (instance->instance_oid.len == 1) {
-      /* if we have the requested OID we return its instance, otherwise we search for the next available */
+      /* if we have the requested OID we return its instance, otherwise we search for the next available */    
      u16_t i = 0;
      while (i < array_node->array_node_count) {
        if (array_node_def->oid == instance->instance_oid.id[0]) {
@@ -179,7 +179,7 @@ snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, st
  instance->instance_oid.len   = 2;
  instance->instance_oid.id[0] = result->oid;
  instance->instance_oid.id[1] = 0;
-
+  
  instance->access              = result->access;
  instance->asn1_type           = result->asn1_type;
  instance->get_value           = snmp_scalar_array_get_value;
@@ -191,42 +191,30 @@ snmp_scalar_array_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, st
 }

 static s16_t
-snmp_scalar_array_get_value(struct snmp_node_instance *instance, void *value)
+snmp_scalar_array_get_value(struct snmp_node_instance* instance, void* value)
 {
-  s16_t result = -1;
-  const struct snmp_scalar_array_node *array_node = (const struct snmp_scalar_array_node *)(const void *)instance->node;
-  const struct snmp_scalar_array_node_def *array_node_def = (const struct snmp_scalar_array_node_def *)instance->reference.const_ptr;
+  const struct snmp_scalar_array_node* array_node = (const struct snmp_scalar_array_node*)(const void*)instance->node;
+  const struct snmp_scalar_array_node_def* array_node_def = (const struct snmp_scalar_array_node_def*)instance->reference.const_ptr;

-  if (array_node->get_value != NULL) {
-    result = array_node->get_value(array_node_def, value);
-  }
-  return result;
+  return array_node->get_value(array_node_def, value);
 }

 static snmp_err_t
-snmp_scalar_array_set_test(struct snmp_node_instance *instance, u16_t value_len, void *value)
+snmp_scalar_array_set_test(struct snmp_node_instance* instance, u16_t value_len, void* value)
 {
-  snmp_err_t result = SNMP_ERR_NOTWRITABLE;
-  const struct snmp_scalar_array_node *array_node = (const struct snmp_scalar_array_node *)(const void *)instance->node;
-  const struct snmp_scalar_array_node_def *array_node_def = (const struct snmp_scalar_array_node_def *)instance->reference.const_ptr;
+  const struct snmp_scalar_array_node* array_node = (const struct snmp_scalar_array_node*)(const void*)instance->node;
+  const struct snmp_scalar_array_node_def* array_node_def = (const struct snmp_scalar_array_node_def*)instance->reference.const_ptr;

-  if (array_node->set_test != NULL) {
-    result = array_node->set_test(array_node_def, value_len, value);
-  }
-  return result;
+  return array_node->set_test(array_node_def, value_len, value);
 }

 static snmp_err_t
-snmp_scalar_array_set_value(struct snmp_node_instance *instance, u16_t value_len, void *value)
+snmp_scalar_array_set_value(struct snmp_node_instance* instance, u16_t value_len, void* value)
 {
-  snmp_err_t result = SNMP_ERR_NOTWRITABLE;
-  const struct snmp_scalar_array_node *array_node = (const struct snmp_scalar_array_node *)(const void *)instance->node;
-  const struct snmp_scalar_array_node_def *array_node_def = (const struct snmp_scalar_array_node_def *)instance->reference.const_ptr;
+  const struct snmp_scalar_array_node* array_node = (const struct snmp_scalar_array_node*)(const void*)instance->node;
+  const struct snmp_scalar_array_node_def* array_node_def = (const struct snmp_scalar_array_node_def*)instance->reference.const_ptr;

-  if (array_node->set_value != NULL) {
-    result = array_node->set_value(array_node_def, value_len, value);
-  }
-  return result;
+  return array_node->set_value(array_node_def, value_len, value);
 }

 #endif /* LWIP_SNMP */
--- a/src/apps/snmp/snmp_snmpv2_framework.c
+++ b/src/apps/snmp/snmp_snmpv2_framework.c
@@ -1,90 +0,0 @@
-/*
-Generated by LwipMibCompiler
-*/
-
-#include "lwip/apps/snmp_opts.h"
-
-#if LWIP_SNMP && LWIP_SNMP_V3 /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/apps/snmp_snmpv2_framework.h"
-#include "lwip/apps/snmp.h"
-#include "lwip/apps/snmp_core.h"
-#include "lwip/apps/snmp_scalar.h"
-#include "lwip/apps/snmp_table.h"
-#include "lwip/apps/snmpv3.h"
-#include "snmpv3_priv.h"
-
-#include "lwip/sys.h"
-
-#include <string.h>
-
-const struct snmp_obj_id usmNoAuthProtocol      = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 1, 1 } };
-const struct snmp_obj_id usmHMACMD5AuthProtocol = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 1, 2 } };
-const struct snmp_obj_id usmHMACSHAAuthProtocol = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 1, 3 } };
-/* .4 sha-224
- * .5 sha-256
- * .6 sha-384
- * .7 sha-512
- */
-
-const struct snmp_obj_id usmNoPrivProtocol  = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 2, 1 } };
-const struct snmp_obj_id usmDESPrivProtocol = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 2, 2 } };
-/* .3 3des-ede */
-const struct snmp_obj_id usmAESPrivProtocol = { 10, { 1, 3, 6, 1, 6, 3, 10, 1, 2, 4 } };
-/* .5 unknown
- * .6 unknown
- * .7 unknown
- */
-
-/* TODO: where should this value come from? */
-#define SNMP_FRAMEWORKMIB_SNMPENGINEMAXMESSAGESIZE 1500
-
-/* --- snmpFrameworkMIBObjects 1.3.6.1.6.3.10.2 ----------------------------------------------------- */
-static s16_t snmpengine_scalars_get_value(const struct snmp_scalar_array_node_def *node, void *value)
-{
-  const char *engineid;
-  u8_t engineid_len;
-
-  switch (node->oid) {
-    case 1: /* snmpEngineID */
-      snmpv3_get_engine_id(&engineid, &engineid_len);
-      MEMCPY(value, engineid, engineid_len);
-      return engineid_len;
-    case 2: /* snmpEngineBoots */
-      *(s32_t *)value = snmpv3_get_engine_boots_internal();
-      return sizeof(s32_t);
-    case 3: /* snmpEngineTime */
-      *(s32_t *)value = snmpv3_get_engine_time_internal();
-      return sizeof(s32_t);
-    case 4: /* snmpEngineMaxMessageSize */
-      *(s32_t *)value = SNMP_FRAMEWORKMIB_SNMPENGINEMAXMESSAGESIZE;
-      return sizeof(s32_t);
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("snmpengine_scalars_get_value(): unknown id: %"S32_F"\n", node->oid));
-      return 0;
-  }
-}
-
-static const struct snmp_scalar_array_node_def snmpengine_scalars_nodes[] = {
-  {1, SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* snmpEngineID */
-  {2, SNMP_ASN1_TYPE_INTEGER,      SNMP_NODE_INSTANCE_READ_ONLY}, /* snmpEngineBoots */
-  {3, SNMP_ASN1_TYPE_INTEGER,      SNMP_NODE_INSTANCE_READ_ONLY}, /* snmpEngineTime */
-  {4, SNMP_ASN1_TYPE_INTEGER,      SNMP_NODE_INSTANCE_READ_ONLY}, /* snmpEngineMaxMessageSize */
-};
-static const struct snmp_scalar_array_node snmpengine_scalars = SNMP_SCALAR_CREATE_ARRAY_NODE(1, snmpengine_scalars_nodes, snmpengine_scalars_get_value, NULL, NULL);
-
-static const struct snmp_node *const snmpframeworkmibobjects_subnodes[] = {
-  &snmpengine_scalars.node.node
-};
-static const struct snmp_tree_node snmpframeworkmibobjects_treenode = SNMP_CREATE_TREE_NODE(2, snmpframeworkmibobjects_subnodes);
-
-/* --- snmpFrameworkMIB  ----------------------------------------------------- */
-static const struct snmp_node *const snmpframeworkmib_subnodes[] = {
-  &snmpframeworkmibobjects_treenode.node
-};
-static const struct snmp_tree_node snmpframeworkmib_root = SNMP_CREATE_TREE_NODE(10, snmpframeworkmib_subnodes);
-static const u32_t snmpframeworkmib_base_oid[] = {1, 3, 6, 1, 6, 3, 10};
-const struct snmp_mib snmpframeworkmib = {snmpframeworkmib_base_oid, LWIP_ARRAYSIZE(snmpframeworkmib_base_oid), &snmpframeworkmib_root.node};
-
-/* --- snmpFrameworkMIB  ----------------------------------------------------- */
-#endif /* LWIP_SNMP */
--- a/src/apps/snmp/snmp_snmpv2_usm.c
+++ b/src/apps/snmp/snmp_snmpv2_usm.c
@@ -1,410 +0,0 @@
-/*
-Generated by LwipMibCompiler
-*/
-
-#include "lwip/apps/snmp_opts.h"
-#if LWIP_SNMP && LWIP_SNMP_V3
-
-#include "lwip/apps/snmp_snmpv2_usm.h"
-#include "lwip/apps/snmp.h"
-#include "lwip/apps/snmp_core.h"
-#include "lwip/apps/snmp_scalar.h"
-#include "lwip/apps/snmp_table.h"
-#include "lwip/apps/snmpv3.h"
-#include "snmpv3_priv.h"
-
-#include "lwip/apps/snmp_snmpv2_framework.h"
-
-#include <string.h>
-
-/* --- usmUser 1.3.6.1.6.3.15.1.2 ----------------------------------------------------- */
-
-static const struct snmp_oid_range usmUserTable_oid_ranges[] = {
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff },
-  { 0, 0xff }, { 0, 0xff }, { 0, 0xff }, { 0, 0xff }
-};
-
-static void snmp_engineid_to_oid(const char *engineid, u32_t *oid, u32_t len)
-{
-  u8_t i;
-
-  for (i = 0; i < len; i++) {
-    oid[i] = engineid[i];
-  }
-}
-
-static void snmp_oid_to_name(char *name, const u32_t *oid, size_t len)
-{
-  u8_t i;
-
-  for (i = 0; i < len; i++) {
-    name[i] = (char)oid[i];
-  }
-}
-
-static void snmp_name_to_oid(const char *name, u32_t *oid, size_t len)
-{
-  u8_t i;
-
-  for (i = 0; i < len; i++) {
-    oid[i] = name[i];
-  }
-}
-
-static const struct snmp_obj_id *snmp_auth_algo_to_oid(snmpv3_auth_algo_t algo)
-{
-  if (algo == SNMP_V3_AUTH_ALGO_MD5) {
-    return &usmHMACMD5AuthProtocol;
-  } else if (algo ==  SNMP_V3_AUTH_ALGO_SHA) {
-    return &usmHMACMD5AuthProtocol;
-  }
-
-  return &usmNoAuthProtocol;
-}
-
-static const struct snmp_obj_id *snmp_priv_algo_to_oid(snmpv3_priv_algo_t algo)
-{
-  if (algo == SNMP_V3_PRIV_ALGO_DES) {
-    return &usmDESPrivProtocol;
-  } else if (algo == SNMP_V3_PRIV_ALGO_AES) {
-    return &usmAESPrivProtocol;
-  }
-
-  return &usmNoPrivProtocol;
-}
-
-char username[32];
-
-static snmp_err_t usmusertable_get_instance(const u32_t *column, const u32_t *row_oid, u8_t row_oid_len, struct snmp_node_instance *cell_instance)
-{
-  const char *engineid;
-  u8_t eid_len;
-
-  u32_t engineid_oid[SNMP_V3_MAX_ENGINE_ID_LENGTH];
-
-  u8_t name_len;
-  u8_t engineid_len;
-
-  u8_t name_start;
-  u8_t engineid_start;
-
-  LWIP_UNUSED_ARG(column);
-
-  snmpv3_get_engine_id(&engineid, &eid_len);
-
-  engineid_len = (u8_t)row_oid[0];
-  engineid_start = 1;
-
-  if (engineid_len != eid_len) {
-    /* EngineID length does not match! */
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  if (engineid_len > row_oid_len) {
-    /* row OID doesn't contain enough data according to engineid_len.*/
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  /* check if incoming OID length and if values are in plausible range */
-  if (!snmp_oid_in_range(&row_oid[engineid_start], engineid_len, usmUserTable_oid_ranges, engineid_len)) {
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  snmp_engineid_to_oid(engineid, engineid_oid, engineid_len);
-
-  /* Verify EngineID */
-  if (snmp_oid_equal(&row_oid[engineid_start], engineid_len, engineid_oid, engineid_len)) {
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  name_len = (u8_t)row_oid[engineid_start + engineid_len];
-  name_start = engineid_start + engineid_len + 1;
-
-  if (name_len > SNMP_V3_MAX_USER_LENGTH) {
-    /* specified name is too long */
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  if (1 + engineid_len + 1 + name_len != row_oid_len) {
-    /* Length of EngineID and name does not match row oid length. (+2 for length fields)*/
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  /* check if incoming OID length and if values are in plausible range */
-  if (!snmp_oid_in_range(&row_oid[name_start], name_len, usmUserTable_oid_ranges, name_len)) {
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  /* Verify if user exists */
-  memset(username, 0, sizeof(username));
-  snmp_oid_to_name(username, &row_oid[name_start], name_len);
-  if (snmpv3_get_user(username, NULL, NULL, NULL, NULL) != ERR_OK) {
-    return SNMP_ERR_NOSUCHINSTANCE;
-  }
-
-  /* Save name in reference pointer to make it easier to handle later on */
-  cell_instance->reference.ptr = username;
-  cell_instance->reference_len = name_len;
-
-  /* user was found */
-  return SNMP_ERR_NOERROR;
-}
-
-/*
- * valid oid options
- * <oid>
- * <oid>.<EngineID length>
- * <oid>.<EngineID length>.<partial EngineID>
- * <oid>.<EngineID length>.<EngineID>
- * <oid>.<EngineID length>.<EngineID>.<UserName length>
- * <oid>.<EngineID length>.<EngineID>.<UserName length>.<partial UserName>
- * <oid>.<EngineID length>.<EngineID>.<UserName length>.<UserName>
- *
- */
-static snmp_err_t usmusertable_get_next_instance(const u32_t *column, struct snmp_obj_id *row_oid, struct snmp_node_instance *cell_instance)
-{
-  const char *engineid;
-  u8_t eid_len;
-
-  u32_t engineid_oid[SNMP_V3_MAX_ENGINE_ID_LENGTH];
-
-  u8_t name_len;
-  u8_t engineid_len;
-
-  u8_t name_start;
-  u8_t engineid_start = 1;
-  u8_t i;
-
-  struct snmp_next_oid_state state;
-
-  u32_t result_temp[LWIP_ARRAYSIZE(usmUserTable_oid_ranges)];
-
-  LWIP_UNUSED_ARG(column);
-
-  snmpv3_get_engine_id(&engineid, &eid_len);
-
-  /* If EngineID might be given */
-  if (row_oid->len > 0) {
-    engineid_len = (u8_t)row_oid->id[0];
-    engineid_start = 1;
-
-    if (engineid_len != eid_len) {
-      /* EngineID length does not match! */
-      return SNMP_ERR_NOSUCHINSTANCE;
-    }
-
-    if (engineid_len > row_oid->len) {
-      /* Verify partial EngineID */
-      snmp_engineid_to_oid(engineid, engineid_oid, row_oid->len - 1);
-      if (!snmp_oid_equal(&row_oid->id[engineid_start], row_oid->len - 1, engineid_oid, row_oid->len - 1)) {
-        return SNMP_ERR_NOSUCHINSTANCE;
-      }
-    } else {
-      /* Verify complete EngineID */
-      snmp_engineid_to_oid(engineid, engineid_oid, engineid_len);
-      if (!snmp_oid_equal(&row_oid->id[engineid_start], engineid_len, engineid_oid, engineid_len)) {
-        return SNMP_ERR_NOSUCHINSTANCE;
-      }
-    }
-
-    /* At this point, the given EngineID (partially) matches the local EngineID.*/
-
-    /* If name might also be given */
-    if (row_oid->len > engineid_start + engineid_len) {
-      name_len = (u8_t)row_oid->id[engineid_start + engineid_len];
-      name_start = engineid_start + engineid_len + 1;
-
-      if (name_len > SNMP_V3_MAX_USER_LENGTH) {
-        /* specified name is too long, max length is 32 according to mib file.*/
-        return SNMP_ERR_NOSUCHINSTANCE;
-      }
-
-      if (row_oid->len < engineid_len + name_len + 2) {
-        /* Partial name given according to oid.*/
-        u8_t tmplen = row_oid->len - engineid_len - 2;
-        if (!snmp_oid_in_range(&row_oid->id[name_start], tmplen, usmUserTable_oid_ranges, tmplen)) {
-          return SNMP_ERR_NOSUCHINSTANCE;
-        }
-      } else {
-        /* Full name given according to oid. Also test for too much data.*/
-        u8_t tmplen = row_oid->len - engineid_len - 2;
-        if (!snmp_oid_in_range(&row_oid->id[name_start], name_len, usmUserTable_oid_ranges, tmplen)) {
-          return SNMP_ERR_NOSUCHINSTANCE;
-        }
-      }
-
-      /* At this point the EngineID and (partial) UserName match the local EngineID and UserName.*/
-    }
-  }
-
-  /* init struct to search next oid */
-  snmp_next_oid_init(&state, row_oid->id, row_oid->len, result_temp, LWIP_ARRAYSIZE(usmUserTable_oid_ranges));
-
-  for (i = 0; i < snmpv3_get_amount_of_users(); i++) {
-    u32_t test_oid[LWIP_ARRAYSIZE(usmUserTable_oid_ranges)];
-
-    test_oid[0] = eid_len;
-    snmp_engineid_to_oid(engineid, &test_oid[1], eid_len);
-
-    snmpv3_get_username(username, i);
-
-    test_oid[1 + eid_len] = strlen(username);
-    snmp_name_to_oid(username, &test_oid[2 + eid_len], strlen(username));
-
-    /* check generated OID: is it a candidate for the next one? */
-    snmp_next_oid_check(&state, test_oid, (u8_t)(1 + eid_len + 1 + strlen(username)), LWIP_PTR_NUMERIC_CAST(void *, i));
-  }
-
-  /* did we find a next one? */
-  if (state.status == SNMP_NEXT_OID_STATUS_SUCCESS) {
-    snmp_oid_assign(row_oid, state.next_oid, state.next_oid_len);
-    /* store username for subsequent operations (get/test/set) */
-    memset(username, 0, sizeof(username));
-    snmpv3_get_username(username, LWIP_PTR_NUMERIC_CAST(u8_t, state.reference));
-    cell_instance->reference.ptr = username;
-    cell_instance->reference_len = strlen(username);
-    return SNMP_ERR_NOERROR;
-  }
-
-  /* not found */
-  return SNMP_ERR_NOSUCHINSTANCE;
-}
-
-static s16_t usmusertable_get_value(struct snmp_node_instance *cell_instance, void *value)
-{
-  snmpv3_user_storagetype_t storage_type;
-
-  switch (SNMP_TABLE_GET_COLUMN_FROM_OID(cell_instance->instance_oid.id)) {
-    case 3: /* usmUserSecurityName */
-      MEMCPY(value, cell_instance->reference.ptr, cell_instance->reference_len);
-      return (s16_t)cell_instance->reference_len;
-    case 4: /* usmUserCloneFrom */
-      MEMCPY(value, snmp_zero_dot_zero.id, snmp_zero_dot_zero.len * sizeof(u32_t));
-      return snmp_zero_dot_zero.len * sizeof(u32_t);
-    case 5: { /* usmUserAuthProtocol */
-      const struct snmp_obj_id *auth_algo;
-      snmpv3_auth_algo_t auth_algo_val;
-      snmpv3_get_user((const char *)cell_instance->reference.ptr, &auth_algo_val, NULL, NULL, NULL);
-      auth_algo = snmp_auth_algo_to_oid(auth_algo_val);
-      MEMCPY(value, auth_algo->id, auth_algo->len * sizeof(u32_t));
-      return auth_algo->len * sizeof(u32_t);
-    }
-    case 6: /* usmUserAuthKeyChange */
-      return 0;
-    case 7: /* usmUserOwnAuthKeyChange */
-      return 0;
-    case 8: { /* usmUserPrivProtocol */
-      const struct snmp_obj_id *priv_algo;
-      snmpv3_priv_algo_t priv_algo_val;
-      snmpv3_get_user((const char *)cell_instance->reference.ptr, NULL, NULL, &priv_algo_val, NULL);
-      priv_algo = snmp_priv_algo_to_oid(priv_algo_val);
-      MEMCPY(value, priv_algo->id, priv_algo->len * sizeof(u32_t));
-      return priv_algo->len * sizeof(u32_t);
-    }
-    case 9: /* usmUserPrivKeyChange */
-      return 0;
-    case 10: /* usmUserOwnPrivKeyChange */
-      return 0;
-    case 11: /* usmUserPublic */
-      /* TODO: Implement usmUserPublic */
-      return 0;
-    case 12: /* usmUserStorageType */
-      snmpv3_get_user_storagetype((const char *)cell_instance->reference.ptr, &storage_type);
-      *(s32_t *)value = storage_type;
-      return sizeof(s32_t);
-    case 13: /* usmUserStatus */
-      *(s32_t *)value = 1; /* active */
-      return sizeof(s32_t);
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("usmusertable_get_value(): unknown id: %"S32_F"\n", SNMP_TABLE_GET_COLUMN_FROM_OID(cell_instance->instance_oid.id)));
-      return 0;
-  }
-}
-
-/* --- usmMIBObjects 1.3.6.1.6.3.15.1 ----------------------------------------------------- */
-static s16_t usmstats_scalars_get_value(const struct snmp_scalar_array_node_def *node, void *value)
-{
-  u32_t *uint_ptr = (u32_t *)value;
-  switch (node->oid) {
-    case 1: /* usmStatsUnsupportedSecLevels */
-      *uint_ptr = snmp_stats.unsupportedseclevels;
-      break;
-    case 2: /* usmStatsNotInTimeWindows */
-      *uint_ptr = snmp_stats.notintimewindows;
-      break;
-    case 3: /* usmStatsUnknownUserNames */
-      *uint_ptr = snmp_stats.unknownusernames;
-      break;
-    case 4: /* usmStatsUnknownEngineIDs */
-      *uint_ptr = snmp_stats.unknownengineids;
-      break;
-    case 5: /* usmStatsWrongDigests */
-      *uint_ptr = snmp_stats.wrongdigests;
-      break;
-    case 6: /* usmStatsDecryptionErrors */
-      *uint_ptr = snmp_stats.decryptionerrors;
-      break;
-    default:
-      LWIP_DEBUGF(SNMP_MIB_DEBUG, ("usmstats_scalars_get_value(): unknown id: %"S32_F"\n", node->oid));
-      return 0;
-  }
-
-  return sizeof(*uint_ptr);
-}
-
-/* --- snmpUsmMIB  ----------------------------------------------------- */
-
-/* --- usmUser 1.3.6.1.6.3.15.1.2 ----------------------------------------------------- */
-
-static const struct snmp_table_col_def usmusertable_columns[] = {
-  {3,  SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserSecurityName */
-  {4,  SNMP_ASN1_TYPE_OBJECT_ID,    SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserCloneFrom */
-  {5,  SNMP_ASN1_TYPE_OBJECT_ID,    SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserAuthProtocol */
-  {6,  SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserAuthKeyChange */
-  {7,  SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserOwnAuthKeyChange */
-  {8,  SNMP_ASN1_TYPE_OBJECT_ID,    SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserPrivProtocol */
-  {9,  SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserPrivKeyChange */
-  {10, SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserOwnPrivKeyChange */
-  {11, SNMP_ASN1_TYPE_OCTET_STRING, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserPublic */
-  {12, SNMP_ASN1_TYPE_INTEGER,      SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserStorageType */
-  {13, SNMP_ASN1_TYPE_INTEGER,      SNMP_NODE_INSTANCE_READ_ONLY}, /* usmUserStatus */
-};
-static const struct snmp_table_node usmusertable = SNMP_TABLE_CREATE(2, usmusertable_columns, usmusertable_get_instance, usmusertable_get_next_instance, usmusertable_get_value, NULL, NULL);
-
-static const struct snmp_node *const usmuser_subnodes[] = {
-  &usmusertable.node.node
-};
-static const struct snmp_tree_node usmuser_treenode = SNMP_CREATE_TREE_NODE(2, usmuser_subnodes);
-
-/* --- usmMIBObjects 1.3.6.1.6.3.15.1 ----------------------------------------------------- */
-static const struct snmp_scalar_array_node_def usmstats_scalars_nodes[] = {
-  {1, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsUnsupportedSecLevels */
-  {2, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsNotInTimeWindows */
-  {3, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsUnknownUserNames */
-  {4, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsUnknownEngineIDs */
-  {5, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsWrongDigests */
-  {6, SNMP_ASN1_TYPE_COUNTER, SNMP_NODE_INSTANCE_READ_ONLY}, /* usmStatsDecryptionErrors */
-};
-static const struct snmp_scalar_array_node usmstats_scalars = SNMP_SCALAR_CREATE_ARRAY_NODE(1, usmstats_scalars_nodes, usmstats_scalars_get_value, NULL, NULL);
-
-static const struct snmp_node *const usmmibobjects_subnodes[] = {
-  &usmstats_scalars.node.node,
-  &usmuser_treenode.node
-};
-static const struct snmp_tree_node usmmibobjects_treenode = SNMP_CREATE_TREE_NODE(1, usmmibobjects_subnodes);
-
-/* --- snmpUsmMIB  ----------------------------------------------------- */
-static const struct snmp_node *const snmpusmmib_subnodes[] = {
-  &usmmibobjects_treenode.node
-};
-static const struct snmp_tree_node snmpusmmib_root = SNMP_CREATE_TREE_NODE(15, snmpusmmib_subnodes);
-static const u32_t snmpusmmib_base_oid[] = {1, 3, 6, 1, 6, 3, 15};
-const struct snmp_mib snmpusmmib = {snmpusmmib_base_oid, LWIP_ARRAYSIZE(snmpusmmib_base_oid), &snmpusmmib_root.node};
-
-#endif /* LWIP_SNMP */
--- a/src/apps/snmp/snmp_table.c
+++ b/src/apps/snmp/snmp_table.c
@@ -43,10 +43,10 @@
 #include "lwip/apps/snmp_table.h"
 #include <string.h>

-snmp_err_t snmp_table_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t snmp_table_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  snmp_err_t ret = SNMP_ERR_NOSUCHINSTANCE;
-  const struct snmp_table_node *table_node = (const struct snmp_table_node *)(const void *)instance->node;
+  const struct snmp_table_node* table_node = (const struct snmp_table_node*)(const void*)instance->node;

  LWIP_UNUSED_ARG(root_oid);
  LWIP_UNUSED_ARG(root_oid_len);
@@ -55,13 +55,13 @@ snmp_err_t snmp_table_get_instance(const u32_t *root_oid, u8_t root_oid_len, str
  /* fixed row entry always has oid 1 */
  if ((instance->instance_oid.len >= 3) && (instance->instance_oid.id[0] == 1)) {
    /* search column */
-    const struct snmp_table_col_def *col_def = table_node->columns;
+    const struct snmp_table_col_def* col_def = table_node->columns;
    u16_t i = table_node->column_count;
    while (i > 0) {
      if (col_def->index == instance->instance_oid.id[1]) {
        break;
      }
-
+      
      col_def++;
      i--;
    }
@@ -75,20 +75,20 @@ snmp_err_t snmp_table_get_instance(const u32_t *root_oid, u8_t root_oid_len, str
      instance->set_value = table_node->set_value;

      ret = table_node->get_cell_instance(
-              &(instance->instance_oid.id[1]),
-              &(instance->instance_oid.id[2]),
-              instance->instance_oid.len - 2,
-              instance);
+        &(instance->instance_oid.id[1]),
+        &(instance->instance_oid.id[2]),
+        instance->instance_oid.len-2,
+        instance);
    }
  }

  return ret;
 }

-snmp_err_t snmp_table_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t snmp_table_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
-  const struct snmp_table_node *table_node = (const struct snmp_table_node *)(const void *)instance->node;
-  const struct snmp_table_col_def *col_def;
+  const struct snmp_table_node* table_node = (const struct snmp_table_node*)(const void*)instance->node;
+  const struct snmp_table_col_def* col_def;
  struct snmp_obj_id row_oid;
  u32_t column = 0;
  snmp_err_t result;
@@ -116,7 +116,7 @@ snmp_err_t snmp_table_get_next_instance(const u32_t *root_oid, u8_t root_oid_len
  /* resolve column and value */
  do {
    u16_t i;
-    const struct snmp_table_col_def *next_col_def = NULL;
+    const struct snmp_table_col_def* next_col_def = NULL;
    col_def = table_node->columns;

    for (i = 0; i < table_node->column_count; i++) {
@@ -138,9 +138,9 @@ snmp_err_t snmp_table_get_next_instance(const u32_t *root_oid, u8_t root_oid_len
    instance->access             = next_col_def->access;

    result = table_node->get_next_cell_instance(
-               &next_col_def->index,
-               &row_oid,
-               instance);
+      &next_col_def->index,
+      &row_oid,
+      instance);

    if (result == SNMP_ERR_NOERROR) {
      col_def = next_col_def;
@@ -161,10 +161,10 @@ snmp_err_t snmp_table_get_next_instance(const u32_t *root_oid, u8_t root_oid_len
 }


-snmp_err_t snmp_table_simple_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t snmp_table_simple_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  snmp_err_t ret = SNMP_ERR_NOSUCHINSTANCE;
-  const struct snmp_table_simple_node *table_node = (const struct snmp_table_simple_node *)(const void *)instance->node;
+  const struct snmp_table_simple_node* table_node = (const struct snmp_table_simple_node*)(const void*)instance->node;

  LWIP_UNUSED_ARG(root_oid);
  LWIP_UNUSED_ARG(root_oid_len);
@@ -173,15 +173,15 @@ snmp_err_t snmp_table_simple_get_instance(const u32_t *root_oid, u8_t root_oid_l
  /* fixed row entry always has oid 1 */
  if ((instance->instance_oid.len >= 3) && (instance->instance_oid.id[0] == 1)) {
    ret = table_node->get_cell_value(
-            &(instance->instance_oid.id[1]),
-            &(instance->instance_oid.id[2]),
-            instance->instance_oid.len - 2,
-            &instance->reference,
-            &instance->reference_len);
+      &(instance->instance_oid.id[1]),
+      &(instance->instance_oid.id[2]),
+      instance->instance_oid.len-2,
+      &instance->reference,
+      &instance->reference_len);

    if (ret == SNMP_ERR_NOERROR) {
      /* search column */
-      const struct snmp_table_simple_col_def *col_def = table_node->columns;
+      const struct snmp_table_simple_col_def* col_def = table_node->columns;
      u32_t i = table_node->column_count;
      while (i > 0) {
        if (col_def->index == instance->instance_oid.id[1]) {
@@ -212,22 +212,22 @@ snmp_err_t snmp_table_simple_get_instance(const u32_t *root_oid, u8_t root_oid_l
          default:
            LWIP_DEBUGF(SNMP_DEBUG, ("snmp_table_simple_get_instance(): unknown column data_type: %d\n", col_def->data_type));
            return SNMP_ERR_GENERROR;
-        }
+        }        

        ret = SNMP_ERR_NOERROR;
      } else {
        ret = SNMP_ERR_NOSUCHINSTANCE;
      }
-    }
+    } 
  }

  return ret;
 }

-snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
-  const struct snmp_table_simple_node *table_node = (const struct snmp_table_simple_node *)(const void *)instance->node;
-  const struct snmp_table_simple_col_def *col_def;
+  const struct snmp_table_simple_node* table_node = (const struct snmp_table_simple_node*)(const void*)instance->node;
+  const struct snmp_table_simple_col_def* col_def;
  struct snmp_obj_id row_oid;
  u32_t column = 0;
  snmp_err_t result;
@@ -251,7 +251,7 @@ snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_
  /* resolve column and value */
  do {
    u32_t i;
-    const struct snmp_table_simple_col_def *next_col_def = NULL;
+    const struct snmp_table_simple_col_def* next_col_def = NULL;
    col_def = table_node->columns;

    for (i = 0; i < table_node->column_count; i++) {
@@ -271,10 +271,10 @@ snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_
    }

    result = table_node->get_next_cell_instance_and_value(
-               &next_col_def->index,
-               &row_oid,
-               &instance->reference,
-               &instance->reference_len);
+      &next_col_def->index,
+      &row_oid,
+      &instance->reference,
+      &instance->reference_len);

    if (result == SNMP_ERR_NOERROR) {
      col_def = next_col_def;
@@ -283,7 +283,8 @@ snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_

    row_oid.len = 0; /* reset row_oid because we switch to next column and start with the first entry there */
    column = next_col_def->index + 1;
-  } while (1);
+  }
+  while (1);

  instance->asn1_type = col_def->asn1_type;
  instance->access    = SNMP_NODE_INSTANCE_READ_ONLY;
@@ -317,23 +318,23 @@ snmp_err_t snmp_table_simple_get_next_instance(const u32_t *root_oid, u8_t root_


 s16_t
-snmp_table_extract_value_from_s32ref(struct snmp_node_instance *instance, void *value)
+snmp_table_extract_value_from_s32ref(struct snmp_node_instance* instance, void* value)
 {
-  s32_t *dst = (s32_t *)value;
+  s32_t *dst = (s32_t*)value;
  *dst = instance->reference.s32;
  return sizeof(*dst);
 }

 s16_t
-snmp_table_extract_value_from_u32ref(struct snmp_node_instance *instance, void *value)
+snmp_table_extract_value_from_u32ref(struct snmp_node_instance* instance, void* value)
 {
-  u32_t *dst = (u32_t *)value;
+  u32_t *dst = (u32_t*)value;
  *dst = instance->reference.u32;
  return sizeof(*dst);
 }

 s16_t
-snmp_table_extract_value_from_refconstptr(struct snmp_node_instance *instance, void *value)
+snmp_table_extract_value_from_refconstptr(struct snmp_node_instance* instance, void* value)
 {
  MEMCPY(value, instance->reference.const_ptr, instance->reference_len);
  return (u16_t)instance->reference_len;
--- a/src/apps/snmp/snmp_threadsync.c
+++ b/src/apps/snmp/snmp_threadsync.c
@@ -40,7 +40,7 @@
 #include "lwip/apps/snmp_core.h"
 #include "lwip/sys.h"
 #include <string.h>
-
+        
 static void
 call_synced_function(struct threadsync_data *call_data, snmp_threadsync_called_fn fn)
 {
@@ -53,21 +53,17 @@ call_synced_function(struct threadsync_data *call_data, snmp_threadsync_called_f
 static void
 threadsync_get_value_synced(void *ctx)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)ctx;
+  struct threadsync_data *call_data = (struct threadsync_data*)ctx;

-  if (call_data->proxy_instance.get_value != NULL) {
-    call_data->retval.s16 = call_data->proxy_instance.get_value(&call_data->proxy_instance, call_data->arg1.value);
-  } else {
-    call_data->retval.s16 = -1;
-  }
+  call_data->retval.s16 = call_data->proxy_instance.get_value(&call_data->proxy_instance, call_data->arg1.value);

  sys_sem_signal(&call_data->threadsync_node->instance->sem);
 }

 static s16_t
-threadsync_get_value(struct snmp_node_instance *instance, void *value)
+threadsync_get_value(struct snmp_node_instance* instance, void* value)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)instance->reference.ptr;
+  struct threadsync_data *call_data = (struct threadsync_data*)instance->reference.ptr;

  call_data->arg1.value = value;
  call_synced_function(call_data, threadsync_get_value_synced);
@@ -78,21 +74,17 @@ threadsync_get_value(struct snmp_node_instance *instance, void *value)
 static void
 threadsync_set_test_synced(void *ctx)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)ctx;
+  struct threadsync_data *call_data = (struct threadsync_data*)ctx;

-  if (call_data->proxy_instance.set_test != NULL) {
-    call_data->retval.err = call_data->proxy_instance.set_test(&call_data->proxy_instance, call_data->arg2.len, call_data->arg1.value);
-  } else {
-    call_data->retval.err = SNMP_ERR_NOTWRITABLE;
-  }
+  call_data->retval.err = call_data->proxy_instance.set_test(&call_data->proxy_instance, call_data->arg2.len, call_data->arg1.value);

  sys_sem_signal(&call_data->threadsync_node->instance->sem);
 }

 static snmp_err_t
-threadsync_set_test(struct snmp_node_instance *instance, u16_t len, void *value)
+threadsync_set_test(struct snmp_node_instance* instance, u16_t len, void *value)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)instance->reference.ptr;
+  struct threadsync_data *call_data = (struct threadsync_data*)instance->reference.ptr;

  call_data->arg1.value = value;
  call_data->arg2.len = len;
@@ -104,34 +96,30 @@ threadsync_set_test(struct snmp_node_instance *instance, u16_t len, void *value)
 static void
 threadsync_set_value_synced(void *ctx)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)ctx;
+  struct threadsync_data *call_data = (struct threadsync_data*)ctx;

-  if (call_data->proxy_instance.set_value != NULL) {
-    call_data->retval.err = call_data->proxy_instance.set_value(&call_data->proxy_instance, call_data->arg2.len, call_data->arg1.value);
-  } else {
-    call_data->retval.err = SNMP_ERR_NOTWRITABLE;
-  }
+  call_data->retval.err = call_data->proxy_instance.set_value(&call_data->proxy_instance, call_data->arg2.len, call_data->arg1.value);

  sys_sem_signal(&call_data->threadsync_node->instance->sem);
 }

 static snmp_err_t
-threadsync_set_value(struct snmp_node_instance *instance, u16_t len, void *value)
+threadsync_set_value(struct snmp_node_instance* instance, u16_t len, void *value)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)instance->reference.ptr;
+  struct threadsync_data *call_data = (struct threadsync_data*)instance->reference.ptr;

  call_data->arg1.value = value;
  call_data->arg2.len = len;
  call_synced_function(call_data, threadsync_set_value_synced);
-
+  
  return call_data->retval.err;
 }

 static void
-threadsync_release_instance_synced(void *ctx)
+threadsync_release_instance_synced(void* ctx)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)ctx;
-
+  struct threadsync_data *call_data = (struct threadsync_data*)ctx;
+  
  call_data->proxy_instance.release_instance(&call_data->proxy_instance);

  sys_sem_signal(&call_data->threadsync_node->instance->sem);
@@ -140,18 +128,18 @@ threadsync_release_instance_synced(void *ctx)
 static void
 threadsync_release_instance(struct snmp_node_instance *instance)
 {
-  struct threadsync_data *call_data = (struct threadsync_data *)instance->reference.ptr;
-
+  struct threadsync_data *call_data = (struct threadsync_data*)instance->reference.ptr;
+  
  if (call_data->proxy_instance.release_instance != NULL) {
    call_synced_function(call_data, threadsync_release_instance_synced);
  }
 }

 static void
-get_instance_synced(void *ctx)
+get_instance_synced(void* ctx)
 {
-  struct threadsync_data *call_data   = (struct threadsync_data *)ctx;
-  const struct snmp_leaf_node *leaf   = (const struct snmp_leaf_node *)(const void *)call_data->proxy_instance.node;
+  struct threadsync_data *call_data   = (struct threadsync_data*)ctx;
+  const struct snmp_leaf_node *leaf   = (const struct snmp_leaf_node*)(const void*)call_data->proxy_instance.node;

  call_data->retval.err = leaf->get_instance(call_data->arg1.root_oid, call_data->arg2.root_oid_len, &call_data->proxy_instance);

@@ -159,10 +147,10 @@ get_instance_synced(void *ctx)
 }

 static void
-get_next_instance_synced(void *ctx)
+get_next_instance_synced(void* ctx)
 {
-  struct threadsync_data *call_data   = (struct threadsync_data *)ctx;
-  const struct snmp_leaf_node *leaf   = (const struct snmp_leaf_node *)(const void *)call_data->proxy_instance.node;
+  struct threadsync_data *call_data   = (struct threadsync_data*)ctx;
+  const struct snmp_leaf_node *leaf   = (const struct snmp_leaf_node*)(const void*)call_data->proxy_instance.node;

  call_data->retval.err = leaf->get_next_instance(call_data->arg1.root_oid, call_data->arg2.root_oid_len, &call_data->proxy_instance);

@@ -170,9 +158,9 @@ get_next_instance_synced(void *ctx)
 }

 static snmp_err_t
-do_sync(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance, snmp_threadsync_called_fn fn)
+do_sync(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance, snmp_threadsync_called_fn fn)
 {
-  const struct snmp_threadsync_node *threadsync_node = (const struct snmp_threadsync_node *)(const void *)instance->node;
+  const struct snmp_threadsync_node *threadsync_node = (const struct snmp_threadsync_node*)(const void*)instance->node;
  struct threadsync_data *call_data = &threadsync_node->instance->data;

  if (threadsync_node->node.node.oid != threadsync_node->target->node.oid) {
@@ -196,9 +184,9 @@ do_sync(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *ins
    instance->access           = call_data->proxy_instance.access;
    instance->asn1_type        = call_data->proxy_instance.asn1_type;
    instance->release_instance = threadsync_release_instance;
-    instance->get_value        = (call_data->proxy_instance.get_value != NULL) ? threadsync_get_value : NULL;
-    instance->set_value        = (call_data->proxy_instance.set_value != NULL) ? threadsync_set_value : NULL;
-    instance->set_test         = (call_data->proxy_instance.set_test != NULL) ?  threadsync_set_test  : NULL;
+    instance->get_value        = (call_data->proxy_instance.get_value != NULL)? threadsync_get_value : NULL;
+    instance->set_value        = (call_data->proxy_instance.set_value != NULL)? threadsync_set_value : NULL;
+    instance->set_test         = (call_data->proxy_instance.set_test != NULL)?  threadsync_set_test  : NULL;
    snmp_oid_assign(&instance->instance_oid, call_data->proxy_instance.instance_oid.id, call_data->proxy_instance.instance_oid.len);
  }

@@ -206,13 +194,13 @@ do_sync(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *ins
 }

 snmp_err_t
-snmp_threadsync_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_threadsync_get_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  return do_sync(root_oid, root_oid_len, instance, get_instance_synced);
 }

 snmp_err_t
-snmp_threadsync_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance *instance)
+snmp_threadsync_get_next_instance(const u32_t *root_oid, u8_t root_oid_len, struct snmp_node_instance* instance)
 {
  return do_sync(root_oid, root_oid_len, instance, get_next_instance_synced);
 }
--- a/src/apps/snmp/snmp_traps.c
+++ b/src/apps/snmp/snmp_traps.c
@@ -46,12 +46,12 @@
 #include "lwip/sys.h"
 #include "lwip/apps/snmp.h"
 #include "lwip/apps/snmp_core.h"
-#include "lwip/prot/iana.h"
 #include "snmp_msg.h"
 #include "snmp_asn1.h"
 #include "snmp_core_priv.h"

-struct snmp_msg_trap {
+struct snmp_msg_trap
+{
  /* source enterprise ID (sysObjectID) */
  const struct snmp_obj_id *enterprise;
  /* source IP address, raw network order format */
@@ -78,21 +78,16 @@ struct snmp_msg_trap {

 static u16_t snmp_trap_varbind_sum(struct snmp_msg_trap *trap, struct snmp_varbind *varbinds);
 static u16_t snmp_trap_header_sum(struct snmp_msg_trap *trap, u16_t vb_len);
-static err_t snmp_trap_header_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream);
-static err_t snmp_trap_varbind_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream, struct snmp_varbind *varbinds);
-
-#define BUILD_EXEC(code) \
-  if ((code) != ERR_OK) { \
-    LWIP_DEBUGF(SNMP_DEBUG, ("SNMP error during creation of outbound trap frame!")); \
-    return ERR_ARG; \
-  }
+static void snmp_trap_header_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream);
+static void snmp_trap_varbind_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream, struct snmp_varbind *varbinds);

 /** Agent community string for sending traps */
 extern const char *snmp_community_trap;

-void *snmp_traps_handle;
+void* snmp_traps_handle;

-struct snmp_trap_dst {
+struct snmp_trap_dst
+{
  /* destination IP address in network order */
  ip_addr_t dip;
  /* set to 0 when disabled, >0 when enabled */
@@ -111,7 +106,6 @@ static u8_t snmp_auth_traps_enabled = 0;
 void
 snmp_trap_dst_enable(u8_t dst_idx, u8_t enable)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (dst_idx < SNMP_TRAP_DESTINATIONS) {
    trap_dst[dst_idx].enable = enable;
  }
@@ -126,7 +120,6 @@ snmp_trap_dst_enable(u8_t dst_idx, u8_t enable)
 void
 snmp_trap_dst_ip_set(u8_t dst_idx, const ip_addr_t *dst)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (dst_idx < SNMP_TRAP_DESTINATIONS) {
    ip_addr_set(&trap_dst[dst_idx].dip, dst);
  }
@@ -170,7 +163,7 @@ snmp_get_auth_traps_enabled(void)
 * (sysObjectID) for specific traps.
 */
 err_t
-snmp_send_trap(const struct snmp_obj_id *eoid, s32_t generic_trap, s32_t specific_trap, struct snmp_varbind *varbinds)
+snmp_send_trap(const struct snmp_obj_id* eoid, s32_t generic_trap, s32_t specific_trap, struct snmp_varbind *varbinds)
 {
  struct snmp_msg_trap trap_msg;
  struct snmp_trap_dst *td;
@@ -178,8 +171,6 @@ snmp_send_trap(const struct snmp_obj_id *eoid, s32_t generic_trap, s32_t specifi
  u16_t i, tot_len;
  err_t err = ERR_OK;

-  LWIP_ASSERT_CORE_LOCKED();
-
  trap_msg.snmp_version = 0;

  for (i = 0, td = &trap_dst[0]; i < SNMP_TRAP_DESTINATIONS; i++, td++) {
@@ -211,7 +202,7 @@ snmp_send_trap(const struct snmp_obj_id *eoid, s32_t generic_trap, s32_t specifi
          struct snmp_pbuf_stream pbuf_stream;
          snmp_pbuf_stream_init(&pbuf_stream, p, 0, tot_len);

-          /* pass 1, encode packet into the pbuf(s) */
+          /* pass 1, encode packet ino the pbuf(s) */
          snmp_trap_header_enc(&trap_msg, &pbuf_stream);
          snmp_trap_varbind_enc(&trap_msg, &pbuf_stream, varbinds);

@@ -219,7 +210,7 @@ snmp_send_trap(const struct snmp_obj_id *eoid, s32_t generic_trap, s32_t specifi
          snmp_stats.outpkts++;

          /** send to the TRAP destination */
-          snmp_sendto(snmp_traps_handle, p, &td->dip, LWIP_IANA_PORT_SNMP_TRAP);
+          snmp_sendto(snmp_traps_handle, p, &td->dip, SNMP_TRAP_PORT);
          pbuf_free(p);
        } else {
          err = ERR_MEM;
@@ -237,7 +228,7 @@ snmp_send_trap(const struct snmp_obj_id *eoid, s32_t generic_trap, s32_t specifi
 * @ingroup snmp_traps
 * Send generic SNMP trap
 */
-err_t
+err_t 
 snmp_send_trap_generic(s32_t generic_trap)
 {
  static const struct snmp_obj_id oid = { 7, { 1, 3, 6, 1, 2, 1, 11 } };
@@ -266,7 +257,7 @@ snmp_coldstart_trap(void)

 /**
 * @ingroup snmp_traps
- * Send authentication failure trap (used internally by agent)
+ * Send authentication failure trap (used internally by agent) 
 */
 void
 snmp_authfail_trap(void)
@@ -366,7 +357,7 @@ snmp_trap_header_sum(struct snmp_msg_trap *trap, u16_t vb_len)
  return tot_len;
 }

-static err_t
+static void
 snmp_trap_varbind_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream, struct snmp_varbind *varbinds)
 {
  struct snmp_asn1_tlv tlv;
@@ -375,84 +366,80 @@ snmp_trap_varbind_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_
  varbind = varbinds;

  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_SEQUENCE, 0, trap->vbseqlen);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);

  while (varbind != NULL) {
-    BUILD_EXEC( snmp_append_outbound_varbind(pbuf_stream, varbind) );
+    snmp_append_outbound_varbind(pbuf_stream, varbind);

    varbind = varbind->next;
  }
-
-  return ERR_OK;
 }

 /**
 * Encodes trap header from head to tail.
 */
-static err_t
+static void
 snmp_trap_header_enc(struct snmp_msg_trap *trap, struct snmp_pbuf_stream *pbuf_stream)
 {
  struct snmp_asn1_tlv tlv;

  /* 'Message' sequence */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_SEQUENCE, 0, trap->seqlen);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);

  /* version */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_INTEGER, 0, 0);
  snmp_asn1_enc_s32t_cnt(trap->snmp_version, &tlv.value_len);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->snmp_version) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->snmp_version);

  /* community */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_OCTET_STRING, 0, trap->comlen);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_raw(pbuf_stream,  (const u8_t *)snmp_community_trap, trap->comlen) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_raw(pbuf_stream,  (const u8_t *)snmp_community_trap, trap->comlen);

  /* 'PDU' sequence */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, (SNMP_ASN1_CLASS_CONTEXT | SNMP_ASN1_CONTENTTYPE_CONSTRUCTED | SNMP_ASN1_CONTEXT_PDU_TRAP), 0, trap->pdulen);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);

  /* object ID */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_OBJECT_ID, 0, 0);
  snmp_asn1_enc_oid_cnt(trap->enterprise->id, trap->enterprise->len, &tlv.value_len);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_oid(pbuf_stream, trap->enterprise->id, trap->enterprise->len) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_oid(pbuf_stream, trap->enterprise->id, trap->enterprise->len);

  /* IP addr */
  if (IP_IS_V6_VAL(trap->sip)) {
 #if LWIP_IPV6
    SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_IPADDR, 0, sizeof(ip_2_ip6(&trap->sip)->addr));
-    BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-    BUILD_EXEC( snmp_asn1_enc_raw(pbuf_stream, (const u8_t *)&ip_2_ip6(&trap->sip)->addr, sizeof(ip_2_ip6(&trap->sip)->addr)) );
+    snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+    snmp_asn1_enc_raw(pbuf_stream, (const u8_t *)&ip_2_ip6(&trap->sip)->addr, sizeof(ip_2_ip6(&trap->sip)->addr));
 #endif
  } else {
 #if LWIP_IPV4
    SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_IPADDR, 0, sizeof(ip_2_ip4(&trap->sip)->addr));
-    BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-    BUILD_EXEC( snmp_asn1_enc_raw(pbuf_stream, (const u8_t *)&ip_2_ip4(&trap->sip)->addr, sizeof(ip_2_ip4(&trap->sip)->addr)) );
+    snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+    snmp_asn1_enc_raw(pbuf_stream, (const u8_t *)&ip_2_ip4(&trap->sip)->addr, sizeof(ip_2_ip4(&trap->sip)->addr));
 #endif
  }

  /* trap length */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_INTEGER, 0, 0);
  snmp_asn1_enc_s32t_cnt(trap->gen_trap, &tlv.value_len);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->gen_trap) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->gen_trap);

  /* specific trap */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_INTEGER, 0, 0);
  snmp_asn1_enc_s32t_cnt(trap->spc_trap, &tlv.value_len);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->spc_trap) );
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->spc_trap);

  /* timestamp */
  SNMP_ASN1_SET_TLV_PARAMS(tlv, SNMP_ASN1_TYPE_TIMETICKS, 0, 0);
  snmp_asn1_enc_s32t_cnt(trap->ts, &tlv.value_len);
-  BUILD_EXEC( snmp_ans1_enc_tlv(pbuf_stream, &tlv) );
-  BUILD_EXEC( snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->ts) );
-
-  return ERR_OK;
+  snmp_ans1_enc_tlv(pbuf_stream, &tlv);
+  snmp_asn1_enc_s32t(pbuf_stream, tlv.value_len, trap->ts);
 }

 #endif /* LWIP_SNMP */
--- a/src/apps/snmp/snmpv3.c
+++ b/src/apps/snmp/snmpv3.c
@@ -58,7 +58,7 @@ snmpv3_engine_id_changed(void)
 * (re-)initialized itself since snmpEngineID
 * was last configured.
 */
-s32_t
+u32_t
 snmpv3_get_engine_boots_internal(void)
 {
  if (snmpv3_get_engine_boots() == 0 ||
@@ -75,7 +75,7 @@ snmpv3_get_engine_boots_internal(void)
 * Once the timer reaches 2147483647 it gets reset to zero and the
 * engine boot ups get incremented.
 */
-s32_t
+u32_t
 snmpv3_get_engine_time_internal(void)
 {
  if (snmpv3_get_engine_time() >= SNMP_MAX_TIME_BOOT) {
@@ -101,7 +101,7 @@ snmpv3_get_engine_time_internal(void)
 * @todo: This is a potential thread safety issue.
 */
 err_t
-snmpv3_build_priv_param(u8_t *priv_param)
+snmpv3_build_priv_param(u8_t* priv_param)
 {
 #ifdef LWIP_RAND /* Based on RFC3826 */
  static u8_t init;
@@ -124,7 +124,7 @@ snmpv3_build_priv_param(u8_t *priv_param)
  }
 #else /* Based on RFC3414 */
  static u32_t ctr;
-  u32_t boots = snmpv3_get_engine_boots_internal();
+  u32_t boots = LWIP_SNMPV3_GET_ENGINE_BOOTS();
  SMEMCPY(&priv_param[0], &boots, 4);
  SMEMCPY(&priv_param[4], &ctr, 4);
  ctr++;
--- a/src/apps/snmp/snmpv3_dummy.c
+++ b/src/apps/snmp/snmpv3_dummy.c
@@ -0,0 +1,145 @@
+/**
+ * @file
+ * Dummy SNMPv3 functions.
+ */
+
+/*
+ * Copyright (c) 2016 Elias Oenal.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification,
+ * are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote products
+ *    derived from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
+ * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+ * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
+ * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
+ * OF SUCH DAMAGE.
+ *
+ * Author: Elias Oenal <lwip@eliasoenal.com>
+ *         Dirk Ziegelmeier <dirk@ziegelmeier.net>
+ */
+
+#include "lwip/apps/snmpv3.h"
+#include "snmpv3_priv.h"
+#include <string.h>
+#include "lwip/err.h"
+
+#if LWIP_SNMP && LWIP_SNMP_V3
+
+/**
+ *  @param username is a pointer to a string.
+ * @param auth_algo is a pointer to u8_t. The implementation has to set this if user was found.
+ * @param auth_key is a pointer to a pointer to a string. Implementation has to set this if user was found.
+ * @param priv_algo is a pointer to u8_t. The implementation has to set this if user was found.
+ * @param priv_key is a pointer to a pointer to a string. Implementation has to set this if user was found.
+ */
+err_t
+snmpv3_get_user(const char* username, u8_t *auth_algo, u8_t *auth_key, u8_t *priv_algo, u8_t *priv_key)
+{
+  const char* engine_id;
+  u8_t engine_id_len;
+  
+  if(strlen(username) == 0) {
+    return ERR_OK;
+  }
+  
+  if(memcmp(username, "lwip", 4) != 0) {
+    return ERR_VAL;
+  }
+  
+  snmpv3_get_engine_id(&engine_id, &engine_id_len);
+  
+  if(auth_key != NULL) {
+    snmpv3_password_to_key_sha((const u8_t*)"maplesyrup", 10,
+      (const u8_t*)engine_id, engine_id_len,
+      auth_key);
+    *auth_algo = SNMP_V3_AUTH_ALGO_SHA;
+  }
+  if(priv_key != NULL) {
+    snmpv3_password_to_key_sha((const u8_t*)"maplesyrup", 10,
+      (const u8_t*)engine_id, engine_id_len,
+      priv_key);
+    *priv_algo = SNMP_V3_PRIV_ALGO_DES;
+  }
+  return ERR_OK;
+}
+
+/**
+ * Get engine ID from persistence
+ * @param id
+ * @param len
+ */
+void
+snmpv3_get_engine_id(const char **id, u8_t *len)
+{
+  *id = "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02";
+  *len = 12;
+}
+
+/**
+ * Store engine ID in persistence
+ * @param id
+ * @param len
+ */
+err_t
+snmpv3_set_engine_id(const char *id, u8_t len)
+{
+  LWIP_UNUSED_ARG(id);
+  LWIP_UNUSED_ARG(len);
+  return ERR_OK;
+}
+
+/**
+ * Get engine boots from persistence. Must be increased on each boot.
+ * @return 
+ */
+u32_t
+snmpv3_get_engine_boots(void)
+{
+  return 0;
+}
+
+/**
+ * Store engine boots in persistence
+ * @param boots
+ */
+void 
+snmpv3_set_engine_boots(u32_t boots)
+{
+  LWIP_UNUSED_ARG(boots);
+}
+
+/**
+ * RFC3414 2.2.2.
+ * Once the timer reaches 2147483647 it gets reset to zero and the
+ * engine boot ups get incremented.
+ */
+u32_t
+snmpv3_get_engine_time(void)
+{
+  return 0;
+}
+
+/**
+ * Reset current engine time to 0
+ */
+void
+snmpv3_reset_engine_time(void)
+{
+}
+
+#endif /* LWIP_SNMP && LWIP_SNMP_V3 */
--- a/src/apps/snmp/snmpv3_mbedtls.c
+++ b/src/apps/snmp/snmpv3_mbedtls.c
@@ -49,8 +49,8 @@
 #include "mbedtls/sha1.h"

 err_t
-snmpv3_auth(struct snmp_pbuf_stream *stream, u16_t length,
-            const u8_t *key, snmpv3_auth_algo_t algo, u8_t *hmac_out)
+snmpv3_auth(struct snmp_pbuf_stream* stream, u16_t length,
+    const u8_t* key, u8_t algo, u8_t* hmac_out)
 {
  u32_t i;
  u8_t key_len;
@@ -70,10 +70,10 @@ snmpv3_auth(struct snmp_pbuf_stream *stream, u16_t length,
  }

  mbedtls_md_init(&ctx);
-  if (mbedtls_md_setup(&ctx, md_info, 1) != 0) {
+  if(mbedtls_md_setup(&ctx, md_info, 1) != 0) {
    return ERR_ARG;
  }
-
+          
  if (mbedtls_md_hmac_starts(&ctx, key, key_len) != 0) {
    goto free_md;
  }
@@ -96,7 +96,7 @@ snmpv3_auth(struct snmp_pbuf_stream *stream, u16_t length,

  mbedtls_md_free(&ctx);
  return ERR_OK;
-
+  
 free_md:
  mbedtls_md_free(&ctx);
  return ERR_ARG;
@@ -105,9 +105,9 @@ free_md:
 #if LWIP_SNMP_V3_CRYPTO

 err_t
-snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length,
-             const u8_t *key, const u8_t *priv_param, const u32_t engine_boots,
-             const u32_t engine_time, snmpv3_priv_algo_t algo, snmpv3_priv_mode_t mode)
+snmpv3_crypt(struct snmp_pbuf_stream* stream, u16_t length,
+    const u8_t* key, const u8_t* priv_param, const u32_t engine_boots,
+    const u32_t engine_time, u8_t algo, u8_t mode)
 {
  size_t i;
  mbedtls_cipher_context_t ctx;
@@ -130,21 +130,21 @@ snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length,
    }

    cipher_info = mbedtls_cipher_info_from_type(MBEDTLS_CIPHER_DES_CBC);
-    if (mbedtls_cipher_setup(&ctx, cipher_info) != 0) {
+    if(mbedtls_cipher_setup(&ctx, cipher_info) != 0) {
      return ERR_ARG;
    }
-    if (mbedtls_cipher_set_padding_mode(&ctx, MBEDTLS_PADDING_NONE) != 0) {
+    if(mbedtls_cipher_set_padding_mode(&ctx, MBEDTLS_PADDING_NONE) != 0) {
      return ERR_ARG;
    }
-    if (mbedtls_cipher_setkey(&ctx, key, 8 * 8, (mode == SNMP_V3_PRIV_MODE_ENCRYPT) ? MBEDTLS_ENCRYPT : MBEDTLS_DECRYPT) != 0) {
+    if(mbedtls_cipher_setkey(&ctx, key, 8*8, (mode == SNMP_V3_PRIV_MODE_ENCRYPT)? MBEDTLS_ENCRYPT : MBEDTLS_DECRYPT) != 0) {
      goto error;
    }

-    /* Prepare IV */
+    /* Prepare IV */    
    for (i = 0; i < LWIP_ARRAYSIZE(iv_local); i++) {
      iv_local[i] = priv_param[i] ^ key[i + 8];
    }
-    if (mbedtls_cipher_set_iv(&ctx, iv_local, LWIP_ARRAYSIZE(iv_local)) != 0) {
+    if(mbedtls_cipher_set_iv(&ctx, iv_local, LWIP_ARRAYSIZE(iv_local)) != 0) {
      goto error;
    }

@@ -152,38 +152,31 @@ snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length,
      size_t j;
      u8_t in_bytes[8];
      out_len = LWIP_ARRAYSIZE(out_bytes) ;
-
+      
      for (j = 0; j < LWIP_ARRAYSIZE(in_bytes); j++) {
-        if (snmp_pbuf_stream_read(&read_stream, &in_bytes[j]) != ERR_OK) {
-          goto error;
-        }
+        snmp_pbuf_stream_read(&read_stream, &in_bytes[j]);
      }

-      if (mbedtls_cipher_update(&ctx, in_bytes, LWIP_ARRAYSIZE(in_bytes), out_bytes, &out_len) != 0) {
+      if(mbedtls_cipher_update(&ctx, in_bytes, LWIP_ARRAYSIZE(in_bytes), out_bytes, &out_len) != 0) {
        goto error;
      }

-      if (snmp_pbuf_stream_writebuf(&write_stream, out_bytes, (u16_t)out_len) != ERR_OK) {
-        goto error;
-      }
+      snmp_pbuf_stream_writebuf(&write_stream, out_bytes, out_len);
    }
-
+    
    out_len = LWIP_ARRAYSIZE(out_bytes);
-    if (mbedtls_cipher_finish(&ctx, out_bytes, &out_len) != 0) {
-      goto error;
-    }
-
-    if (snmp_pbuf_stream_writebuf(&write_stream, out_bytes, (u16_t)out_len) != ERR_OK) {
+    if(mbedtls_cipher_finish(&ctx, out_bytes, &out_len) != 0) {
      goto error;
    }
+    snmp_pbuf_stream_writebuf(&write_stream, out_bytes, out_len);
  } else if (algo == SNMP_V3_PRIV_ALGO_AES) {
    u8_t iv_local[16];

    cipher_info = mbedtls_cipher_info_from_type(MBEDTLS_CIPHER_AES_128_CFB128);
-    if (mbedtls_cipher_setup(&ctx, cipher_info) != 0) {
+    if(mbedtls_cipher_setup(&ctx, cipher_info) != 0) {
      return ERR_ARG;
    }
-    if (mbedtls_cipher_setkey(&ctx, key, 16 * 8, (mode == SNMP_V3_PRIV_MODE_ENCRYPT) ? MBEDTLS_ENCRYPT : MBEDTLS_DECRYPT) != 0) {
+    if(mbedtls_cipher_setkey(&ctx, key, 16*8, (mode == SNMP_V3_PRIV_MODE_ENCRYPT)? MBEDTLS_ENCRYPT : MBEDTLS_DECRYPT) != 0) {
      goto error;
    }

@@ -200,7 +193,7 @@ snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length,
    iv_local[4 + 2] = (engine_time  >>  8) & 0xFF;
    iv_local[4 + 3] = (engine_time  >>  0) & 0xFF;
    SMEMCPY(iv_local + 8, priv_param, 8);
-    if (mbedtls_cipher_set_iv(&ctx, iv_local, LWIP_ARRAYSIZE(iv_local)) != 0) {
+    if(mbedtls_cipher_set_iv(&ctx, iv_local, LWIP_ARRAYSIZE(iv_local)) != 0) {
      goto error;
    }

@@ -208,16 +201,12 @@ snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length,
      u8_t in_byte;
      u8_t out_byte;
      size_t out_len = sizeof(out_byte);
-
-      if (snmp_pbuf_stream_read(&read_stream, &in_byte) != ERR_OK) {
-        goto error;
-      }
-      if (mbedtls_cipher_update(&ctx, &in_byte, sizeof(in_byte), &out_byte, &out_len) != 0) {
-        goto error;
-      }
-      if (snmp_pbuf_stream_write(&write_stream, out_byte) != ERR_OK) {
+      
+      snmp_pbuf_stream_read(&read_stream, &in_byte);
+      if(mbedtls_cipher_update(&ctx, &in_byte, sizeof(in_byte), &out_byte, &out_len) != 0) {
        goto error;
      }
+      snmp_pbuf_stream_write(&write_stream, out_byte);
    }
  } else {
    return ERR_ARG;
@@ -234,13 +223,13 @@ error:
 #endif /* LWIP_SNMP_V3_CRYPTO */

 /* A.2.1. Password to Key Sample Code for MD5 */
-void
+void 
 snmpv3_password_to_key_md5(
-  const u8_t *password,    /* IN */
-  size_t      passwordlen, /* IN */
-  const u8_t *engineID,    /* IN  - pointer to snmpEngineID  */
-  u8_t        engineLength,/* IN  - length of snmpEngineID */
-  u8_t       *key)         /* OUT - pointer to caller 16-octet buffer */
+    const u8_t *password,    /* IN */
+    u8_t        passwordlen, /* IN */
+    const u8_t *engineID,    /* IN  - pointer to snmpEngineID  */
+    u8_t        engineLength,/* IN  - length of snmpEngineID */
+    u8_t       *key)         /* OUT - pointer to caller 16-octet buffer */
 {
  mbedtls_md5_context MD;
  u8_t *cp, password_buf[64];
@@ -287,13 +276,13 @@ snmpv3_password_to_key_md5(
 }

 /* A.2.2. Password to Key Sample Code for SHA */
-void
+void 
 snmpv3_password_to_key_sha(
-  const u8_t *password,    /* IN */
-  size_t      passwordlen, /* IN */
-  const u8_t *engineID,    /* IN  - pointer to snmpEngineID  */
-  u8_t        engineLength,/* IN  - length of snmpEngineID */
-  u8_t       *key)         /* OUT - pointer to caller 20-octet buffer */
+    const u8_t *password,    /* IN */
+    u8_t        passwordlen, /* IN */
+    const u8_t *engineID,    /* IN  - pointer to snmpEngineID  */
+    u8_t        engineLength,/* IN  - length of snmpEngineID */
+    u8_t       *key)         /* OUT - pointer to caller 20-octet buffer */
 {
  mbedtls_sha1_context SH;
  u8_t *cp, password_buf[72];
@@ -334,7 +323,7 @@ snmpv3_password_to_key_sha(
  mbedtls_sha1_starts(&SH);
  mbedtls_sha1_update(&SH, password_buf, 40 + engineLength);
  mbedtls_sha1_finish(&SH, key);
-
+  
  mbedtls_sha1_free(&SH);
  return;
 }
--- a/src/apps/snmp/snmpv3_priv.h
+++ b/src/apps/snmp/snmpv3_priv.h
@@ -39,7 +39,6 @@

 #if LWIP_SNMP && LWIP_SNMP_V3

-#include "lwip/apps/snmpv3.h"
 #include "snmp_pbuf_stream.h"

 /* According to RFC 3411 */
@@ -49,20 +48,18 @@
 #define SNMP_V3_MAX_AUTH_PARAM_LENGTH  12
 #define SNMP_V3_MAX_PRIV_PARAM_LENGTH  8

+#define SNMP_V3_AUTH_FLAG      0x01
+#define SNMP_V3_PRIV_FLAG      0x02
+
 #define SNMP_V3_MD5_LEN        16
 #define SNMP_V3_SHA_LEN        20

-typedef enum {
-  SNMP_V3_PRIV_MODE_DECRYPT = 0,
-  SNMP_V3_PRIV_MODE_ENCRYPT = 1
-} snmpv3_priv_mode_t;
-
-s32_t snmpv3_get_engine_boots_internal(void);
-err_t snmpv3_auth(struct snmp_pbuf_stream *stream, u16_t length, const u8_t *key, snmpv3_auth_algo_t algo, u8_t *hmac_out);
-err_t snmpv3_crypt(struct snmp_pbuf_stream *stream, u16_t length, const u8_t *key,
-                   const u8_t *priv_param, const u32_t engine_boots, const u32_t engine_time, snmpv3_priv_algo_t algo, snmpv3_priv_mode_t mode);
-err_t snmpv3_build_priv_param(u8_t *priv_param);
-void snmpv3_enginetime_timer(void *arg);
+u32_t snmpv3_get_engine_boots_internal(void);
+u32_t snmpv3_get_engine_time_internal(void);
+err_t snmpv3_auth(struct snmp_pbuf_stream* stream, u16_t length, const u8_t* key, u8_t algo, u8_t* hmac_out);
+err_t snmpv3_crypt(struct snmp_pbuf_stream* stream, u16_t length, const u8_t* key,
+    const u8_t* priv_param, const u32_t engine_boots, const u32_t engine_time, u8_t algo, u8_t mode);
+err_t snmpv3_build_priv_param(u8_t* priv_param);

 #endif

--- a/src/apps/sntp/sntp.c
+++ b/src/apps/sntp/sntp.c
@@ -42,10 +42,11 @@
 * This is simple "SNTP" client for the lwIP raw API.
 * It is a minimal implementation of SNTPv4 as specified in RFC 4330.
 *
- * For a list of some public NTP servers, see this link:
+ * For a list of some public NTP servers, see this link :
 * http://support.ntp.org/bin/view/Servers/NTPPoolServers
 *
 * @todo:
+ * - set/change servers at runtime
 * - complete SNTP_CHECK_RESPONSE checks 3 and 4
 */

@@ -71,12 +72,21 @@
 #define SNTP_SUPPORT_MULTIPLE_SERVERS 0
 #endif /* NTP_MAX_SERVERS > 1 */

-#ifndef SNTP_SUPPRESS_DELAY_CHECK
-#if SNTP_UPDATE_DELAY < 15000
+#if (SNTP_UPDATE_DELAY < 15000) && !defined(SNTP_SUPPRESS_DELAY_CHECK)
 #error "SNTPv4 RFC 4330 enforces a minimum update time of 15 seconds (define SNTP_SUPPRESS_DELAY_CHECK to disable this error)!"
 #endif
+
+/* Configure behaviour depending on microsecond or second precision */
+#ifdef SNTP_SET_SYSTEM_TIME_US
+#define SNTP_CALC_TIME_US           1
+#define SNTP_RECEIVE_TIME_SIZE      2
+#else
+#define SNTP_SET_SYSTEM_TIME_US(sec, us)
+#define SNTP_CALC_TIME_US           0
+#define SNTP_RECEIVE_TIME_SIZE      1
 #endif

+
 /* the various debug levels for this file */
 #define SNTP_DEBUG_TRACE        (SNTP_DEBUG | LWIP_DBG_TRACE)
 #define SNTP_DEBUG_STATE        (SNTP_DEBUG | LWIP_DBG_STATE)
@@ -91,10 +101,10 @@

 #define SNTP_OFFSET_LI_VN_MODE      0
 #define SNTP_LI_MASK                0xC0
-#define SNTP_LI_NO_WARNING          (0x00 << 6)
-#define SNTP_LI_LAST_MINUTE_61_SEC  (0x01 << 6)
-#define SNTP_LI_LAST_MINUTE_59_SEC  (0x02 << 6)
-#define SNTP_LI_ALARM_CONDITION     (0x03 << 6) /* (clock not synchronized) */
+#define SNTP_LI_NO_WARNING          0x00
+#define SNTP_LI_LAST_MINUTE_61_SEC  0x01
+#define SNTP_LI_LAST_MINUTE_59_SEC  0x02
+#define SNTP_LI_ALARM_CONDITION     0x03 /* (clock not synchronized) */

 #define SNTP_VERSION_MASK           0x38
 #define SNTP_VERSION                (4/* NTP Version 4*/<<3)
@@ -111,89 +121,18 @@
 #define SNTP_OFFSET_RECEIVE_TIME    32
 #define SNTP_OFFSET_TRANSMIT_TIME   40

-/* Number of seconds between 1970 and Feb 7, 2036 06:28:16 UTC (epoch 1) */
-#define DIFF_SEC_1970_2036          ((u32_t)2085978496L)
-
-/** Convert NTP timestamp fraction to microseconds.
- */
-#ifndef SNTP_FRAC_TO_US
-# if LWIP_HAVE_INT64
-#  define SNTP_FRAC_TO_US(f)        ((u32_t)(((u64_t)(f) * 1000000UL) >> 32))
-# else
-#  define SNTP_FRAC_TO_US(f)        ((u32_t)(f) / 4295)
-# endif
-#endif /* !SNTP_FRAC_TO_US */
-
-/* Configure behaviour depending on native, microsecond or second precision.
- * Treat NTP timestamps as signed two's-complement integers. This way,
- * timestamps that have the MSB set simply become negative offsets from
- * the epoch (Feb 7, 2036 06:28:16 UTC). Representable dates range from
- * 1968 to 2104.
- */
-#ifndef SNTP_SET_SYSTEM_TIME_NTP
-# ifdef SNTP_SET_SYSTEM_TIME_US
-#  define SNTP_SET_SYSTEM_TIME_NTP(s, f) \
-    SNTP_SET_SYSTEM_TIME_US((u32_t)((s) + DIFF_SEC_1970_2036), SNTP_FRAC_TO_US(f))
-# else
-#  define SNTP_SET_SYSTEM_TIME_NTP(s, f) \
-    SNTP_SET_SYSTEM_TIME((u32_t)((s) + DIFF_SEC_1970_2036))
-# endif
-#endif /* !SNTP_SET_SYSTEM_TIME_NTP */
-
-/* Get the system time either natively as NTP timestamp or convert from
- * Unix time in seconds and microseconds. Take care to avoid overflow if the
- * microsecond value is at the maximum of 999999. Also add 0.5 us fudge to
- * avoid special values like 0, and to mask round-off errors that would
- * otherwise break round-trip conversion identity.
- */
-#ifndef SNTP_GET_SYSTEM_TIME_NTP
-# define SNTP_GET_SYSTEM_TIME_NTP(s, f) do { \
-    u32_t sec_, usec_; \
-    SNTP_GET_SYSTEM_TIME(sec_, usec_); \
-    (s) = (s32_t)(sec_ - DIFF_SEC_1970_2036); \
-    (f) = usec_ * 4295 - ((usec_ * 2143) >> 16) + 2147; \
-  } while (0)
-#endif /* !SNTP_GET_SYSTEM_TIME_NTP */
-
-/* Start offset of the timestamps to extract from the SNTP packet */
-#define SNTP_OFFSET_TIMESTAMPS \
-    (SNTP_OFFSET_TRANSMIT_TIME + 8 - sizeof(struct sntp_timestamps))
-
-/* Round-trip delay arithmetic helpers */
-#if SNTP_COMP_ROUNDTRIP
-# if !LWIP_HAVE_INT64
-#  error "SNTP round-trip delay compensation requires 64-bit arithmetic"
-# endif
-# define SNTP_SEC_FRAC_TO_S64(s, f) \
-    ((s64_t)(((u64_t)(s) << 32) | (u32_t)(f)))
-# define SNTP_TIMESTAMP_TO_S64(t) \
-    SNTP_SEC_FRAC_TO_S64(lwip_ntohl((t).sec), lwip_ntohl((t).frac))
-#endif /* SNTP_COMP_ROUNDTRIP */
-
-/**
- * 64-bit NTP timestamp, in network byte order.
- */
-struct sntp_time {
-  u32_t sec;
-  u32_t frac;
-};
-
-/**
- * Timestamps to be extracted from the NTP header.
- */
-struct sntp_timestamps {
-#if SNTP_COMP_ROUNDTRIP || SNTP_CHECK_RESPONSE >= 2
-  struct sntp_time orig;
-  struct sntp_time recv;
-#endif
-  struct sntp_time xmit;
-};
+/* number of seconds between 1900 and 1970 (MSB=1)*/
+#define DIFF_SEC_1900_1970         (2208988800UL)
+/* number of seconds between 1970 and Feb 7, 2036 (6:28:16 UTC) (MSB=0) */
+#define DIFF_SEC_1970_2036         (2085978496UL)

 /**
 * SNTP packet format (without optional fields)
 * Timestamps are coded as 64 bits:
- * - signed 32 bits seconds since Feb 07, 2036, 06:28:16 UTC (epoch 1)
- * - unsigned 32 bits seconds fraction (2^32 = 1 second)
+ * - 32 bits seconds since Jan 01, 1970, 00:00
+ * - 32 bits seconds fraction (0-padded)
+ * For future use, if the MSB in the seconds part is set, seconds are based
+ * on Feb 07, 2036, 06:28:16.
 */
 #ifdef PACK_STRUCT_USE_INCLUDES
 #  include "arch/bpstruct.h"
@@ -224,17 +163,13 @@ static void sntp_request(void *arg);
 static u8_t sntp_opmode;

 /** The UDP pcb used by the SNTP client */
-static struct udp_pcb *sntp_pcb;
+static struct udp_pcb* sntp_pcb;
 /** Names/Addresses of servers */
 struct sntp_server {
 #if SNTP_SERVER_DNS
-  const char *name;
+  char* name;
 #endif /* SNTP_SERVER_DNS */
  ip_addr_t addr;
-#if SNTP_MONITOR_SERVER_REACHABILITY
-  /** Reachability shift register as described in RFC 5905 */
-  u8_t reachability;
-#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
 };
 static struct sntp_server sntp_servers[SNTP_MAX_SERVERS];

@@ -264,69 +199,38 @@ static ip_addr_t sntp_last_server_address;

 #if SNTP_CHECK_RESPONSE >= 2
 /** Saves the last timestamp sent (which is sent back by the server)
- * to compare against in response. Stored in network byte order. */
-static struct sntp_time sntp_last_timestamp_sent;
+ * to compare against in response */
+static u32_t sntp_last_timestamp_sent[2];
 #endif /* SNTP_CHECK_RESPONSE >= 2 */

-#if defined(LWIP_DEBUG) && !defined(sntp_format_time)
-/* Debug print helper. */
-static const char *
-sntp_format_time(s32_t sec)
-{
-  time_t ut;
-  ut = (u32_t)((u32_t)sec + DIFF_SEC_1970_2036);
-  return ctime(&ut);
-}
-#endif /* LWIP_DEBUG && !sntp_format_time */
-
 /**
 * SNTP processing of received timestamp
 */
 static void
-sntp_process(const struct sntp_timestamps *timestamps)
+sntp_process(u32_t *receive_timestamp)
 {
-  s32_t sec;
-  u32_t frac;
+  /* convert SNTP time (1900-based) to unix GMT time (1970-based)
+   * if MSB is 0, SNTP time is 2036-based!
+   */
+  u32_t rx_secs = lwip_ntohl(receive_timestamp[0]);
+  int is_1900_based = ((rx_secs & 0x80000000) != 0);
+  u32_t t = is_1900_based ? (rx_secs - DIFF_SEC_1900_1970) : (rx_secs + DIFF_SEC_1970_2036);
+  time_t tim = t;

-  sec  = (s32_t)lwip_ntohl(timestamps->xmit.sec);
-  frac = lwip_ntohl(timestamps->xmit.frac);
+#if SNTP_CALC_TIME_US
+  u32_t us = lwip_ntohl(receive_timestamp[1]) / 4295;
+  SNTP_SET_SYSTEM_TIME_US(t, us);
+  /* display local time from GMT time */
+  LWIP_DEBUGF(SNTP_DEBUG_TRACE, ("sntp_process: %s, %"U32_F" us", ctime(&tim), us));

-#if SNTP_COMP_ROUNDTRIP
-# if SNTP_CHECK_RESPONSE >= 2
-  if (timestamps->recv.sec != 0 || timestamps->recv.frac != 0)
-# endif
-  {
-    s32_t dest_sec;
-    u32_t dest_frac;
-    u32_t step_sec;
+#else /* SNTP_CALC_TIME_US */

-    /* Get the destination time stamp, i.e. the current system time */
-    SNTP_GET_SYSTEM_TIME_NTP(dest_sec, dest_frac);
-
-    step_sec = (dest_sec < sec) ? ((u32_t)sec - (u32_t)dest_sec)
-               : ((u32_t)dest_sec - (u32_t)sec);
-    /* In order to avoid overflows, skip the compensation if the clock step
-     * is larger than about 34 years. */
-    if ((step_sec >> 30) == 0) {
-      s64_t t1, t2, t3, t4;
-
-      t4 = SNTP_SEC_FRAC_TO_S64(dest_sec, dest_frac);
-      t3 = SNTP_SEC_FRAC_TO_S64(sec, frac);
-      t1 = SNTP_TIMESTAMP_TO_S64(timestamps->orig);
-      t2 = SNTP_TIMESTAMP_TO_S64(timestamps->recv);
-      /* Clock offset calculation according to RFC 4330 */
-      t4 += ((t2 - t1) + (t3 - t4)) / 2;
-
-      sec  = (s32_t)((u64_t)t4 >> 32);
-      frac = (u32_t)((u64_t)t4);
-    }
-  }
-#endif /* SNTP_COMP_ROUNDTRIP */
-
-  SNTP_SET_SYSTEM_TIME_NTP(sec, frac);
-  LWIP_UNUSED_ARG(frac); /* might be unused if only seconds are set */
-  LWIP_DEBUGF(SNTP_DEBUG_TRACE, ("sntp_process: %s, %" U32_F " us\n",
-                                 sntp_format_time(sec), SNTP_FRAC_TO_US(frac)));
+  /* change system time and/or the update the RTC clock */
+  SNTP_SET_SYSTEM_TIME(t);
+  /* display local time from GMT time */
+  LWIP_DEBUGF(SNTP_DEBUG_TRACE, ("sntp_process: %s", ctime(&tim)));
+#endif /* SNTP_CALC_TIME_US */
+  LWIP_UNUSED_ARG(tim);
 }

 /**
@@ -338,23 +242,18 @@ sntp_initialize_request(struct sntp_msg *req)
  memset(req, 0, SNTP_MSG_LEN);
  req->li_vn_mode = SNTP_LI_NO_WARNING | SNTP_VERSION | SNTP_MODE_CLIENT;

-#if SNTP_CHECK_RESPONSE >= 2 || SNTP_COMP_ROUNDTRIP
+#if SNTP_CHECK_RESPONSE >= 2
  {
-    s32_t secs;
-    u32_t sec, frac;
-    /* Get the transmit timestamp */
-    SNTP_GET_SYSTEM_TIME_NTP(secs, frac);
-    sec  = lwip_htonl((u32_t)secs);
-    frac = lwip_htonl(frac);
-
-# if SNTP_CHECK_RESPONSE >= 2
-    sntp_last_timestamp_sent.sec  = sec;
-    sntp_last_timestamp_sent.frac = frac;
-# endif
-    req->transmit_timestamp[0] = sec;
-    req->transmit_timestamp[1] = frac;
+    u32_t sntp_time_sec, sntp_time_us;
+    /* fill in transmit timestamp and save it in 'sntp_last_timestamp_sent' */
+    SNTP_GET_SYSTEM_TIME(sntp_time_sec, sntp_time_us);
+    sntp_last_timestamp_sent[0] = lwip_htonl(sntp_time_sec + DIFF_SEC_1900_1970);
+    req->transmit_timestamp[0] = sntp_last_timestamp_sent[0];
+    /* we send/save us instead of fraction to be faster... */
+    sntp_last_timestamp_sent[1] = lwip_htonl(sntp_time_us);
+    req->transmit_timestamp[1] = sntp_last_timestamp_sent[1];
  }
-#endif /* SNTP_CHECK_RESPONSE >= 2 || SNTP_COMP_ROUNDTRIP */
+#endif /* SNTP_CHECK_RESPONSE >= 2 */
 }

 /**
@@ -363,12 +262,12 @@ sntp_initialize_request(struct sntp_msg *req)
 * @param arg is unused (only necessary to conform to sys_timeout)
 */
 static void
-sntp_retry(void *arg)
+sntp_retry(void* arg)
 {
  LWIP_UNUSED_ARG(arg);

  LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_retry: Next request will be sent in %"U32_F" ms\n",
-                                 sntp_retry_timeout));
+    sntp_retry_timeout));

  /* set up a timer to send a retry and increase the retry delay */
  sys_timeout(sntp_retry_timeout, sntp_request, NULL);
@@ -397,7 +296,7 @@ sntp_retry(void *arg)
 * @param arg is unused (only necessary to conform to sys_timeout)
 */
 static void
-sntp_try_next_server(void *arg)
+sntp_try_next_server(void* arg)
 {
  u8_t old_server, i;
  LWIP_UNUSED_ARG(arg);
@@ -412,9 +311,9 @@ sntp_try_next_server(void *arg)
 #if SNTP_SERVER_DNS
        || (sntp_servers[sntp_current_server].name != NULL)
 #endif
-       ) {
+        ) {
      LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_try_next_server: Sending request to server %"U16_F"\n",
-                                     (u16_t)sntp_current_server));
+        (u16_t)sntp_current_server));
      /* new server: reset retry timeout */
      SNTP_RESET_RETRY_TIMEOUT();
      /* instantly send a request to the next server */
@@ -433,21 +332,25 @@ sntp_try_next_server(void *arg)

 /** UDP recv callback for the sntp pcb */
 static void
-sntp_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr, u16_t port)
+sntp_recv(void *arg, struct udp_pcb* pcb, struct pbuf *p, const ip_addr_t *addr, u16_t port)
 {
-  struct sntp_timestamps timestamps;
  u8_t mode;
  u8_t stratum;
+  u32_t receive_timestamp[SNTP_RECEIVE_TIME_SIZE];
  err_t err;

  LWIP_UNUSED_ARG(arg);
  LWIP_UNUSED_ARG(pcb);

+  /* packet received: stop retry timeout  */
+  sys_untimeout(sntp_try_next_server, NULL);
+  sys_untimeout(sntp_request, NULL);
+
  err = ERR_ARG;
 #if SNTP_CHECK_RESPONSE >= 1
  /* check server address and port */
  if (((sntp_opmode != SNTP_OPMODE_POLL) || ip_addr_cmp(addr, &sntp_last_server_address)) &&
-      (port == SNTP_PORT))
+    (port == SNTP_PORT))
 #else /* SNTP_CHECK_RESPONSE >= 1 */
  LWIP_UNUSED_ARG(addr);
  LWIP_UNUSED_ARG(port);
@@ -455,30 +358,32 @@ sntp_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
  {
    /* process the response */
    if (p->tot_len == SNTP_MSG_LEN) {
-      mode = pbuf_get_at(p, SNTP_OFFSET_LI_VN_MODE) & SNTP_MODE_MASK;
+      pbuf_copy_partial(p, &mode, 1, SNTP_OFFSET_LI_VN_MODE);
+      mode &= SNTP_MODE_MASK;
      /* if this is a SNTP response... */
-      if (((sntp_opmode == SNTP_OPMODE_POLL)       && (mode == SNTP_MODE_SERVER)) ||
+      if (((sntp_opmode == SNTP_OPMODE_POLL) && (mode == SNTP_MODE_SERVER)) ||
          ((sntp_opmode == SNTP_OPMODE_LISTENONLY) && (mode == SNTP_MODE_BROADCAST))) {
-        stratum = pbuf_get_at(p, SNTP_OFFSET_STRATUM);
-
+        pbuf_copy_partial(p, &stratum, 1, SNTP_OFFSET_STRATUM);
        if (stratum == SNTP_STRATUM_KOD) {
          /* Kiss-of-death packet. Use another server or increase UPDATE_DELAY. */
          err = SNTP_ERR_KOD;
          LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_recv: Received Kiss-of-Death\n"));
        } else {
-          pbuf_copy_partial(p, &timestamps, sizeof(timestamps), SNTP_OFFSET_TIMESTAMPS);
 #if SNTP_CHECK_RESPONSE >= 2
          /* check originate_timetamp against sntp_last_timestamp_sent */
-          if (timestamps.orig.sec != sntp_last_timestamp_sent.sec ||
-              timestamps.orig.frac != sntp_last_timestamp_sent.frac) {
-            LWIP_DEBUGF(SNTP_DEBUG_WARN,
-                        ("sntp_recv: Invalid originate timestamp in response\n"));
+          u32_t originate_timestamp[2];
+          pbuf_copy_partial(p, &originate_timestamp, 8, SNTP_OFFSET_ORIGINATE_TIME);
+          if ((originate_timestamp[0] != sntp_last_timestamp_sent[0]) ||
+              (originate_timestamp[1] != sntp_last_timestamp_sent[1]))
+          {
+            LWIP_DEBUGF(SNTP_DEBUG_WARN, ("sntp_recv: Invalid originate timestamp in response\n"));
          } else
 #endif /* SNTP_CHECK_RESPONSE >= 2 */
-            /* @todo: add code for SNTP_CHECK_RESPONSE >= 3 and >= 4 here */
+          /* @todo: add code for SNTP_CHECK_RESPONSE >= 3 and >= 4 here */
          {
            /* correct answer */
            err = ERR_OK;
+            pbuf_copy_partial(p, &receive_timestamp, SNTP_RECEIVE_TIME_SIZE * 4, SNTP_OFFSET_TRANSMIT_TIME);
          }
        }
      } else {
@@ -496,39 +401,30 @@ sntp_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
    err = ERR_TIMEOUT;
  }
 #endif /* SNTP_CHECK_RESPONSE >= 1 */
-
  pbuf_free(p);
-
  if (err == ERR_OK) {
-    /* correct packet received: process it it */
-    sntp_process(&timestamps);
+    sntp_process(receive_timestamp);

-#if SNTP_MONITOR_SERVER_REACHABILITY
-    /* indicate that server responded */
-    sntp_servers[sntp_current_server].reachability |= 1;
-#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
    /* Set up timeout for next request (only if poll response was received)*/
    if (sntp_opmode == SNTP_OPMODE_POLL) {
-      u32_t sntp_update_delay;
-      sys_untimeout(sntp_try_next_server, NULL);
-      sys_untimeout(sntp_request, NULL);
-
      /* Correct response, reset retry timeout */
      SNTP_RESET_RETRY_TIMEOUT();

-      sntp_update_delay = (u32_t)SNTP_UPDATE_DELAY;
-      sys_timeout(sntp_update_delay, sntp_request, NULL);
+      sys_timeout((u32_t)SNTP_UPDATE_DELAY, sntp_request, NULL);
      LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_recv: Scheduled next time request: %"U32_F" ms\n",
-                                     sntp_update_delay));
+        (u32_t)SNTP_UPDATE_DELAY));
    }
-  } else if (err == SNTP_ERR_KOD) {
-    /* KOD errors are only processed in case of an explicit poll response */
+  } else if (err != ERR_TIMEOUT) {
+    /* Errors are only processed in case of an explicit poll response */
    if (sntp_opmode == SNTP_OPMODE_POLL) {
-      /* Kiss-of-death packet. Use another server or increase UPDATE_DELAY. */
-      sntp_try_next_server(NULL);
+      if (err == SNTP_ERR_KOD) {
+        /* Kiss-of-death packet. Use another server or increase UPDATE_DELAY. */
+        sntp_try_next_server(NULL);
+      } else {
+        /* another error, try the same server again */
+        sntp_retry(NULL);
+      }
    }
-  } else {
-    /* ignore any broken packet, poll mode: retry after timeout to avoid flooding */
  }
 }

@@ -539,10 +435,7 @@ sntp_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
 static void
 sntp_send_request(const ip_addr_t *server_addr)
 {
-  struct pbuf *p;
-
-  LWIP_ASSERT("server_addr != NULL", server_addr != NULL);
-
+  struct pbuf* p;
  p = pbuf_alloc(PBUF_TRANSPORT, SNTP_MSG_LEN, PBUF_RAM);
  if (p != NULL) {
    struct sntp_msg *sntpmsg = (struct sntp_msg *)p->payload;
@@ -553,19 +446,15 @@ sntp_send_request(const ip_addr_t *server_addr)
    udp_sendto(sntp_pcb, p, server_addr, SNTP_PORT);
    /* free the pbuf after sending it */
    pbuf_free(p);
-#if SNTP_MONITOR_SERVER_REACHABILITY
-    /* indicate new packet has been sent */
-    sntp_servers[sntp_current_server].reachability <<= 1;
-#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
    /* set up receive timeout: try next server or retry on timeout */
    sys_timeout((u32_t)SNTP_RECV_TIMEOUT, sntp_try_next_server, NULL);
 #if SNTP_CHECK_RESPONSE >= 1
    /* save server address to verify it in sntp_recv */
-    ip_addr_copy(sntp_last_server_address, *server_addr);
+    ip_addr_set(&sntp_last_server_address, server_addr);
 #endif /* SNTP_CHECK_RESPONSE >= 1 */
  } else {
    LWIP_DEBUGF(SNTP_DEBUG_SERIOUS, ("sntp_send_request: Out of memory, trying again in %"U32_F" ms\n",
-                                     (u32_t)SNTP_RETRY_TIMEOUT));
+      (u32_t)SNTP_RETRY_TIMEOUT));
    /* out of memory: set up a timer to send a retry */
    sys_timeout((u32_t)SNTP_RETRY_TIMEOUT, sntp_request, NULL);
  }
@@ -576,7 +465,7 @@ sntp_send_request(const ip_addr_t *server_addr)
 * DNS found callback when using DNS names as server address.
 */
 static void
-sntp_dns_found(const char *hostname, const ip_addr_t *ipaddr, void *arg)
+sntp_dns_found(const char* hostname, const ip_addr_t *ipaddr, void *arg)
 {
  LWIP_UNUSED_ARG(hostname);
  LWIP_UNUSED_ARG(arg);
@@ -584,7 +473,6 @@ sntp_dns_found(const char *hostname, const ip_addr_t *ipaddr, void *arg)
  if (ipaddr != NULL) {
    /* Address resolved, send request */
    LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_dns_found: Server address resolved, sending request\n"));
-    sntp_servers[sntp_current_server].addr = *ipaddr;
    sntp_send_request(ipaddr);
  } else {
    /* DNS resolving failed -> try another server */
@@ -613,7 +501,7 @@ sntp_request(void *arg)
    /* always resolve the name and rely on dns-internal caching & timeout */
    ip_addr_set_zero(&sntp_servers[sntp_current_server].addr);
    err = dns_gethostbyname(sntp_servers[sntp_current_server].name, &sntp_server_address,
-                            sntp_dns_found, NULL);
+      sntp_dns_found, NULL);
    if (err == ERR_INPROGRESS) {
      /* DNS request sent, wait for sntp_dns_found being called */
      LWIP_DEBUGF(SNTP_DEBUG_STATE, ("sntp_request: Waiting for server address to be resolved.\n"));
@@ -630,7 +518,7 @@ sntp_request(void *arg)

  if (err == ERR_OK) {
    LWIP_DEBUGF(SNTP_DEBUG_TRACE, ("sntp_request: current server address is %s\n",
-                                   ipaddr_ntoa(&sntp_server_address)));
+      ipaddr_ntoa(&sntp_server_address)));
    sntp_send_request(&sntp_server_address);
  } else {
    /* address conversion failed, try another server */
@@ -647,8 +535,6 @@ sntp_request(void *arg)
 void
 sntp_init(void)
 {
-  /* LWIP_ASSERT_CORE_LOCKED(); is checked by udp_new() */
-
 #ifdef SNTP_SERVER_ADDRESS
 #if SNTP_SERVER_DNS
  sntp_setservername(0, SNTP_SERVER_ADDRESS);
@@ -685,14 +571,7 @@ sntp_init(void)
 void
 sntp_stop(void)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (sntp_pcb != NULL) {
-#if SNTP_MONITOR_SERVER_REACHABILITY
-    u8_t i;
-    for (i = 0; i < SNTP_MAX_SERVERS; i++) {
-      sntp_servers[i].reachability = 0;
-    }
-#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
    sys_untimeout(sntp_request, NULL);
    sys_untimeout(sntp_try_next_server, NULL);
    udp_remove(sntp_pcb);
@@ -706,7 +585,7 @@ sntp_stop(void)
 */
 u8_t sntp_enabled(void)
 {
-  return (sntp_pcb != NULL) ? 1 : 0;
+  return (sntp_pcb != NULL)? 1 : 0;
 }

 /**
@@ -717,7 +596,6 @@ u8_t sntp_enabled(void)
 void
 sntp_setoperatingmode(u8_t operating_mode)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("Invalid operating mode", operating_mode <= SNTP_OPMODE_LISTENONLY);
  LWIP_ASSERT("Operating mode must not be set while SNTP client is running", sntp_pcb == NULL);
  sntp_opmode = operating_mode;
@@ -733,23 +611,6 @@ sntp_getoperatingmode(void)
  return sntp_opmode;
 }

-#if SNTP_MONITOR_SERVER_REACHABILITY
-/**
- * @ingroup sntp
- * Gets the server reachability shift register as described in RFC 5905.
- *
- * @param idx the index of the NTP server
- */
-u8_t
-sntp_getreachability(u8_t idx)
-{
-  if (idx < SNTP_MAX_SERVERS) {
-    return sntp_servers[idx].reachability;
-  }
-  return 0;
-}
-#endif /* SNTP_MONITOR_SERVER_REACHABILITY */
-
 #if SNTP_GET_SERVERS_FROM_DHCP
 /**
 * Config SNTP server handling by IP address, name, or DHCP; clear table
@@ -759,7 +620,6 @@ void
 sntp_servermode_dhcp(int set_servers_from_dhcp)
 {
  u8_t new_mode = set_servers_from_dhcp ? 1 : 0;
-  LWIP_ASSERT_CORE_LOCKED();
  if (sntp_set_servers_from_dhcp != new_mode) {
    sntp_set_servers_from_dhcp = new_mode;
  }
@@ -776,7 +636,6 @@ sntp_servermode_dhcp(int set_servers_from_dhcp)
 void
 sntp_setserver(u8_t idx, const ip_addr_t *server)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (idx < SNTP_MAX_SERVERS) {
    if (server != NULL) {
      sntp_servers[idx].addr = (*server);
@@ -793,15 +652,15 @@ sntp_setserver(u8_t idx, const ip_addr_t *server)
 /**
 * Initialize one of the NTP servers by IP address, required by DHCP
 *
- * @param num the index of the NTP server to set must be < SNTP_MAX_SERVERS
- * @param server IP address of the NTP server to set
+ * @param numdns the index of the NTP server to set must be < SNTP_MAX_SERVERS
+ * @param dnsserver IP address of the NTP server to set
 */
 void
 dhcp_set_ntp_servers(u8_t num, const ip4_addr_t *server)
 {
  LWIP_DEBUGF(SNTP_DEBUG_TRACE, ("sntp: %s %u.%u.%u.%u as NTP server #%u via DHCP\n",
-                                 (sntp_set_servers_from_dhcp ? "Got" : "Rejected"),
-                                 ip4_addr1(server), ip4_addr2(server), ip4_addr3(server), ip4_addr4(server), num));
+    (sntp_set_servers_from_dhcp ? "Got" : "Rejected"),
+    ip4_addr1(server), ip4_addr2(server), ip4_addr3(server), ip4_addr4(server), num));
  if (sntp_set_servers_from_dhcp && num) {
    u8_t i;
    for (i = 0; (i < num) && (i < SNTP_MAX_SERVERS); i++) {
@@ -824,7 +683,7 @@ dhcp_set_ntp_servers(u8_t num, const ip4_addr_t *server)
 * @return IP address of the indexed NTP server or "ip_addr_any" if the NTP
 *         server has not been configured by address (or at all).
 */
-const ip_addr_t *
+const ip_addr_t*
 sntp_getserver(u8_t idx)
 {
  if (idx < SNTP_MAX_SERVERS) {
@@ -837,13 +696,12 @@ sntp_getserver(u8_t idx)
 /**
 * Initialize one of the NTP servers by name
 *
- * @param idx the index of the NTP server to set must be < SNTP_MAX_SERVERS
- * @param server DNS name of the NTP server to set, to be resolved at contact time
+ * @param numdns the index of the NTP server to set must be < SNTP_MAX_SERVERS
+ * @param dnsserver DNS name of the NTP server to set, to be resolved at contact time
 */
 void
-sntp_setservername(u8_t idx, const char *server)
+sntp_setservername(u8_t idx, char *server)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  if (idx < SNTP_MAX_SERVERS) {
    sntp_servers[idx].name = server;
  }
@@ -852,11 +710,11 @@ sntp_setservername(u8_t idx, const char *server)
 /**
 * Obtain one of the currently configured by name NTP servers.
 *
- * @param idx the index of the NTP server
+ * @param numdns the index of the NTP server
 * @return IP address of the indexed NTP server or NULL if the NTP
 *         server has not been configured by name (or at all)
 */
-const char *
+char *
 sntp_getservername(u8_t idx)
 {
  if (idx < SNTP_MAX_SERVERS) {
--- a/src/apps/tftp/tftp_server.c
+++ b/src/apps/tftp/tftp_server.c
@@ -1,4 +1,4 @@
-/**
+/****************************************************************//**
 *
 * @file tftp_server.c
 *
@@ -10,9 +10,9 @@
 * Copyright (c) Deltatee Enterprises Ltd. 2013
 * All rights reserved.
 *
- */
+ ********************************************************************/

-/*
+/* 
 * Redistribution and use in source and binary forms, with or without
 * modification,are permitted provided that the following conditions are met:
 *
@@ -92,7 +92,7 @@ struct tftp_state {

 static struct tftp_state tftp_state;

-static void tftp_tmr(void *arg);
+static void tftp_tmr(void* arg);

 static void
 close_handle(void)
@@ -100,13 +100,13 @@ close_handle(void)
  tftp_state.port = 0;
  ip_addr_set_any(0, &tftp_state.addr);

-  if (tftp_state.last_data != NULL) {
+  if(tftp_state.last_data != NULL) {
    pbuf_free(tftp_state.last_data);
    tftp_state.last_data = NULL;
  }

  sys_untimeout(tftp_tmr, NULL);
-
+  
  if (tftp_state.handle) {
    tftp_state.ctx->close(tftp_state.handle);
    tftp_state.handle = NULL;
@@ -118,15 +118,15 @@ static void
 send_error(const ip_addr_t *addr, u16_t port, enum tftp_error code, const char *str)
 {
  int str_length = strlen(str);
-  struct pbuf *p;
-  u16_t *payload;
-
+  struct pbuf* p;
+  u16_t* payload;
+  
  p = pbuf_alloc(PBUF_TRANSPORT, (u16_t)(TFTP_HEADER_LENGTH + str_length + 1), PBUF_RAM);
-  if (p == NULL) {
+  if(p == NULL) {
    return;
  }

-  payload = (u16_t *) p->payload;
+  payload = (u16_t*) p->payload;
  payload[0] = PP_HTONS(TFTP_ERROR);
  payload[1] = lwip_htons(code);
  MEMCPY(&payload[2], str, str_length + 1);
@@ -138,15 +138,15 @@ send_error(const ip_addr_t *addr, u16_t port, enum tftp_error code, const char *
 static void
 send_ack(u16_t blknum)
 {
-  struct pbuf *p;
-  u16_t *payload;
-
+  struct pbuf* p;
+  u16_t* payload;
+  
  p = pbuf_alloc(PBUF_TRANSPORT, TFTP_HEADER_LENGTH, PBUF_RAM);
-  if (p == NULL) {
+  if(p == NULL) {
    return;
  }
-  payload = (u16_t *) p->payload;
-
+  payload = (u16_t*) p->payload;
+  
  payload[0] = PP_HTONS(TFTP_ACK);
  payload[1] = lwip_htons(blknum);
  udp_sendto(tftp_state.upcb, p, &tftp_state.addr, tftp_state.port);
@@ -157,15 +157,15 @@ static void
 resend_data(void)
 {
  struct pbuf *p = pbuf_alloc(PBUF_TRANSPORT, tftp_state.last_data->len, PBUF_RAM);
-  if (p == NULL) {
+  if(p == NULL) {
    return;
  }

-  if (pbuf_copy(p, tftp_state.last_data) != ERR_OK) {
+  if(pbuf_copy(p, tftp_state.last_data) != ERR_OK) {
    pbuf_free(p);
    return;
  }
-
+    
  udp_sendto(tftp_state.upcb, p, &tftp_state.addr, tftp_state.port);
  pbuf_free(p);
 }
@@ -176,12 +176,12 @@ send_data(void)
  u16_t *payload;
  int ret;

-  if (tftp_state.last_data != NULL) {
+  if(tftp_state.last_data != NULL) {
    pbuf_free(tftp_state.last_data);
  }
-
+  
  tftp_state.last_data = pbuf_alloc(PBUF_TRANSPORT, TFTP_HEADER_LENGTH + TFTP_MAX_PAYLOAD_SIZE, PBUF_RAM);
-  if (tftp_state.last_data == NULL) {
+  if(tftp_state.last_data == NULL) {
    return;
  }

@@ -208,7 +208,7 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16

  LWIP_UNUSED_ARG(arg);
  LWIP_UNUSED_ARG(upcb);
-
+  
  if (((tftp_state.port != 0) && (port != tftp_state.port)) ||
      (!ip_addr_isany_val(tftp_state.addr) && !ip_addr_cmp(&tftp_state.addr, addr))) {
    send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "Only one connection at a time is supported");
@@ -223,36 +223,37 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16

  switch (opcode) {
    case PP_HTONS(TFTP_RRQ): /* fall through */
-    case PP_HTONS(TFTP_WRQ): {
+    case PP_HTONS(TFTP_WRQ):
+    {
      const char tftp_null = 0;
-      char filename[TFTP_MAX_FILENAME_LEN + 1];
-      char mode[TFTP_MAX_MODE_LEN + 1];
+      char filename[TFTP_MAX_FILENAME_LEN];
+      char mode[TFTP_MAX_MODE_LEN];
      u16_t filename_end_offset;
      u16_t mode_end_offset;

-      if (tftp_state.handle != NULL) {
+      if(tftp_state.handle != NULL) {
        send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "Only one connection at a time is supported");
        break;
      }
-
+      
      sys_timeout(TFTP_TIMER_MSECS, tftp_tmr, NULL);

      /* find \0 in pbuf -> end of filename string */
      filename_end_offset = pbuf_memfind(p, &tftp_null, sizeof(tftp_null), 2);
-      if ((u16_t)(filename_end_offset - 1) > sizeof(filename)) {
+      if((u16_t)(filename_end_offset-2) > sizeof(filename)) {
        send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "Filename too long/not NULL terminated");
        break;
      }
-      pbuf_copy_partial(p, filename, filename_end_offset - 1, 2);
+      pbuf_copy_partial(p, filename, filename_end_offset-2, 2);

      /* find \0 in pbuf -> end of mode string */
-      mode_end_offset = pbuf_memfind(p, &tftp_null, sizeof(tftp_null), filename_end_offset + 1);
-      if ((u16_t)(mode_end_offset - filename_end_offset) > sizeof(mode)) {
+      mode_end_offset = pbuf_memfind(p, &tftp_null, sizeof(tftp_null), filename_end_offset+1);
+      if((u16_t)(mode_end_offset-filename_end_offset) > sizeof(mode)) {
        send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "Mode too long/not NULL terminated");
        break;
      }
-      pbuf_copy_partial(p, mode, mode_end_offset - filename_end_offset, filename_end_offset + 1);
-
+      pbuf_copy_partial(p, mode, mode_end_offset-filename_end_offset, filename_end_offset+1);
+ 
      tftp_state.handle = tftp_state.ctx->open(filename, mode, opcode == PP_HTONS(TFTP_WRQ));
      tftp_state.blknum = 1;

@@ -278,11 +279,12 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16

      break;
    }
-
-    case PP_HTONS(TFTP_DATA): {
+    
+    case PP_HTONS(TFTP_DATA):
+    {
      int ret;
      u16_t blknum;
-
+      
      if (tftp_state.handle == NULL) {
        send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "No connection");
        break;
@@ -294,32 +296,24 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16
      }

      blknum = lwip_ntohs(sbuf[1]);
-      if (blknum == tftp_state.blknum) {
-        pbuf_remove_header(p, TFTP_HEADER_LENGTH);
+      pbuf_header(p, -TFTP_HEADER_LENGTH);

-        ret = tftp_state.ctx->write(tftp_state.handle, p);
-        if (ret < 0) {
-          send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "error writing file");
-          close_handle();
-        } else {
-          send_ack(blknum);
-        }
-
-        if (p->tot_len < TFTP_MAX_PAYLOAD_SIZE) {
-          close_handle();
-        } else {
-          tftp_state.blknum++;
-        }
-      } else if ((u16_t)(blknum + 1) == tftp_state.blknum) {
-        /* retransmit of previous block, ack again (casting to u16_t to care for overflow) */
-        send_ack(blknum);
+      ret = tftp_state.ctx->write(tftp_state.handle, p);
+      if (ret < 0) {
+        send_error(addr, port, TFTP_ERROR_ACCESS_VIOLATION, "error writing file");
+        close_handle();
      } else {
-        send_error(addr, port, TFTP_ERROR_UNKNOWN_TRFR_ID, "Wrong block number");
+        send_ack(blknum);
+      }
+
+      if (p->tot_len < TFTP_MAX_PAYLOAD_SIZE) {
+        close_handle();
      }
      break;
    }

-    case PP_HTONS(TFTP_ACK): {
+    case PP_HTONS(TFTP_ACK):
+    {
      u16_t blknum;
      int lastpkt;

@@ -354,7 +348,7 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16

      break;
    }
-
+    
    default:
      send_error(addr, port, TFTP_ERROR_ILLEGAL_OPERATION, "Unknown operation");
      break;
@@ -364,10 +358,10 @@ recv(void *arg, struct udp_pcb *upcb, struct pbuf *p, const ip_addr_t *addr, u16
 }

 static void
-tftp_tmr(void *arg)
+tftp_tmr(void* arg)
 {
  LWIP_UNUSED_ARG(arg);
-
+  
  tftp_state.timer++;

  if (tftp_state.handle == NULL) {
@@ -392,12 +386,11 @@ tftp_tmr(void *arg)
 * Initialize TFTP server.
 * @param ctx TFTP callback struct
 */
-err_t
+err_t 
 tftp_init(const struct tftp_context *ctx)
 {
  err_t ret;

-  /* LWIP_ASSERT_CORE_LOCKED(); is checked by udp_new() */
  struct udp_pcb *pcb = udp_new_ip_type(IPADDR_TYPE_ANY);
  if (pcb == NULL) {
    return ERR_MEM;
@@ -421,15 +414,4 @@ tftp_init(const struct tftp_context *ctx)
  return ERR_OK;
 }

-/** @ingroup tftp
- * Deinitialize ("turn off") TFTP server.
- */
-void tftp_cleanup(void)
-{
-  LWIP_ASSERT("Cleanup called on non-initialized TFTP", tftp_state.upcb != NULL);
-  udp_remove(tftp_state.upcb);
-  close_handle();
-  memset(&tftp_state, 0, sizeof(tftp_state));
-}
-
 #endif /* LWIP_UDP */
--- a/src/core/altcp.c
+++ b/src/core/altcp.c
@@ -1,681 +0,0 @@
-/**
- * @file
- * @defgroup altcp Application layered TCP Functions
- * @ingroup altcp_api
- *
- * This file contains the common functions for altcp to work.
- * For more details see @ref altcp_api.
- */
-
-/**
- * @defgroup altcp_api Application layered TCP Introduction
- * @ingroup callbackstyle_api
- *
- * Overview
- * --------
- * altcp (application layered TCP connection API; to be used from TCPIP thread)
- * is an abstraction layer that prevents applications linking hard against the
- * @ref tcp.h functions while providing the same functionality. It is used to
- * e.g. add SSL/TLS (see LWIP_ALTCP_TLS) or proxy-connect support to an application
- * written for the tcp callback API without that application knowing the
- * protocol details.
- *
- * * This interface mimics the tcp callback API to the application while preventing
- *   direct linking (much like virtual functions).
- * * This way, an application can make use of other application layer protocols
- *   on top of TCP without knowing the details (e.g. TLS, proxy connection).
- * * This is achieved by simply including "lwip/altcp.h" instead of "lwip/tcp.h",
- *   replacing "struct tcp_pcb" with "struct altcp_pcb" and prefixing all functions
- *   with "altcp_" instead of "tcp_".
- *
- * With altcp support disabled (LWIP_ALTCP==0), applications written against the
- * altcp API can still be compiled but are directly linked against the tcp.h
- * callback API and then cannot use layered protocols. To minimize code changes
- * in this case, the use of altcp_allocators is strongly suggested.
- *
- * Usage
- * -----
- * To make use of this API from an existing tcp raw API application:
- * * Include "lwip/altcp.h" instead of "lwip/tcp.h"
- * * Replace "struct tcp_pcb" with "struct altcp_pcb"
- * * Prefix all called tcp API functions with "altcp_" instead of "tcp_" to link
- *   against the altcp functions
- * * @ref altcp_new (and @ref altcp_new_ip_type/@ref altcp_new_ip6) take
- *   an @ref altcp_allocator_t as an argument, whereas the original tcp API
- *   functions take no arguments.
- * * An @ref altcp_allocator_t allocator is an object that holds a pointer to an
- *   allocator object and a corresponding state (e.g. for TLS, the corresponding
- *   state may hold certificates or keys). This way, the application does not
- *   even need to know if it uses TLS or pure TCP, this is handled at runtime
- *   by passing a specific allocator.
- * * An application can alternatively bind hard to the altcp_tls API by calling
- *   @ref altcp_tls_new or @ref altcp_tls_wrap.
- * * The TLS layer is not directly implemented by lwIP, but a port to mbedTLS is
- *   provided.
- * * Another altcp layer is proxy-connect to use TLS behind a HTTP proxy (see
- *   @ref altcp_proxyconnect.h)
- *
- * altcp_allocator_t
- * -----------------
- * An altcp allocator is created by the application by combining an allocator
- * callback function and a corresponding state, e.g.:\code{.c}
- * static const unsigned char cert[] = {0x2D, ... (see mbedTLS doc for how to create this)};
- * struct altcp_tls_config * conf = altcp_tls_create_config_client(cert, sizeof(cert));
- * altcp_allocator_t tls_allocator = {
- *   altcp_tls_alloc, conf
- * };
- * \endcode
- *
- *
- * struct altcp_tls_config
- * -----------------------
- * The struct altcp_tls_config holds state that is needed to create new TLS client
- * or server connections (e.g. certificates and private keys).
- *
- * It is not defined by lwIP itself but by the TLS port (e.g. altcp_tls to mbedTLS
- * adaption). However, the parameters used to create it are defined in @ref
- * altcp_tls.h (see @ref altcp_tls_create_config_server_privkey_cert for servers
- * and @ref altcp_tls_create_config_client/@ref altcp_tls_create_config_client_2wayauth
- * for clients).
- *
- * For mbedTLS, ensure that certificates can be parsed by 'mbedtls_x509_crt_parse()' and
- * private keys can be parsed by 'mbedtls_pk_parse_key()'.
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/altcp.h"
-#include "lwip/priv/altcp_priv.h"
-#include "lwip/altcp_tcp.h"
-#include "lwip/tcp.h"
-#include "lwip/mem.h"
-
-#include <string.h>
-
-extern const struct altcp_functions altcp_tcp_functions;
-
-/**
- * For altcp layer implementations only: allocate a new struct altcp_pcb from the pool
- * and zero the memory
- */
-struct altcp_pcb *
-altcp_alloc(void)
-{
-  struct altcp_pcb *ret = (struct altcp_pcb *)memp_malloc(MEMP_ALTCP_PCB);
-  if (ret != NULL) {
-    memset(ret, 0, sizeof(struct altcp_pcb));
-  }
-  return ret;
-}
-
-/**
- * For altcp layer implementations only: return a struct altcp_pcb to the pool
- */
-void
-altcp_free(struct altcp_pcb *conn)
-{
-  if (conn) {
-    if (conn->fns && conn->fns->dealloc) {
-      conn->fns->dealloc(conn);
-    }
-    memp_free(MEMP_ALTCP_PCB, conn);
-  }
-}
-
-/**
- * @ingroup altcp
- * altcp_new_ip6: @ref altcp_new for IPv6 
- */
-struct altcp_pcb *
-altcp_new_ip6(altcp_allocator_t *allocator)
-{
-  return altcp_new_ip_type(allocator, IPADDR_TYPE_V6);
-}
-
-/** 
- * @ingroup altcp
- * altcp_new: @ref altcp_new for IPv4 
- */
-struct altcp_pcb *
-altcp_new(altcp_allocator_t *allocator)
-{
-  return altcp_new_ip_type(allocator, IPADDR_TYPE_V4);
-}
-
-/**
- * @ingroup altcp
- * altcp_new_ip_type: called by applications to allocate a new pcb with the help of an
- * allocator function.
- *
- * @param allocator allocator function and argument
- * @param ip_type IP version of the pcb (@ref lwip_ip_addr_type)
- * @return a new altcp_pcb or NULL on error
- */
-struct altcp_pcb *
-altcp_new_ip_type(altcp_allocator_t *allocator, u8_t ip_type)
-{
-  struct altcp_pcb *conn;
-  if (allocator == NULL) {
-    /* no allocator given, create a simple TCP connection */
-    return altcp_tcp_new_ip_type(ip_type);
-  }
-  if (allocator->alloc == NULL) {
-    /* illegal allocator */
-    return NULL;
-  }
-  conn = allocator->alloc(allocator->arg, ip_type);
-  if (conn == NULL) {
-    /* allocation failed */
-    return NULL;
-  }
-  return conn;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_arg()
- */
-void
-altcp_arg(struct altcp_pcb *conn, void *arg)
-{
-  if (conn) {
-    conn->arg = arg;
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_accept()
- */
-void
-altcp_accept(struct altcp_pcb *conn, altcp_accept_fn accept)
-{
-  if (conn != NULL) {
-    conn->accept = accept;
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_recv()
- */
-void
-altcp_recv(struct altcp_pcb *conn, altcp_recv_fn recv)
-{
-  if (conn) {
-    conn->recv = recv;
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_sent()
- */
-void
-altcp_sent(struct altcp_pcb *conn, altcp_sent_fn sent)
-{
-  if (conn) {
-    conn->sent = sent;
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_poll()
- */
-void
-altcp_poll(struct altcp_pcb *conn, altcp_poll_fn poll, u8_t interval)
-{
-  if (conn) {
-    conn->poll = poll;
-    conn->pollinterval = interval;
-    if (conn->fns && conn->fns->set_poll) {
-      conn->fns->set_poll(conn, interval);
-    }
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_err()
- */
-void
-altcp_err(struct altcp_pcb *conn, altcp_err_fn err)
-{
-  if (conn) {
-    conn->err = err;
-  }
-}
-
-/* Generic functions calling the "virtual" ones */
-
-/**
- * @ingroup altcp
- * @see tcp_recved()
- */
-void
-altcp_recved(struct altcp_pcb *conn, u16_t len)
-{
-  if (conn && conn->fns && conn->fns->recved) {
-    conn->fns->recved(conn, len);
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_bind()
- */
-err_t
-altcp_bind(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port)
-{
-  if (conn && conn->fns && conn->fns->bind) {
-    return conn->fns->bind(conn, ipaddr, port);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_connect()
- */
-err_t
-altcp_connect(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port, altcp_connected_fn connected)
-{
-  if (conn && conn->fns && conn->fns->connect) {
-    return conn->fns->connect(conn, ipaddr, port, connected);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_listen_with_backlog_and_err()
- */
-struct altcp_pcb *
-altcp_listen_with_backlog_and_err(struct altcp_pcb *conn, u8_t backlog, err_t *err)
-{
-  if (conn && conn->fns && conn->fns->listen) {
-    return conn->fns->listen(conn, backlog, err);
-  }
-  return NULL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_abort()
- */
-void
-altcp_abort(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->abort) {
-    conn->fns->abort(conn);
-  }
-}
-
-/**
- * @ingroup altcp
- * @see tcp_close()
- */
-err_t
-altcp_close(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->close) {
-    return conn->fns->close(conn);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_shutdown()
- */
-err_t
-altcp_shutdown(struct altcp_pcb *conn, int shut_rx, int shut_tx)
-{
-  if (conn && conn->fns && conn->fns->shutdown) {
-    return conn->fns->shutdown(conn, shut_rx, shut_tx);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_write()
- */
-err_t
-altcp_write(struct altcp_pcb *conn, const void *dataptr, u16_t len, u8_t apiflags)
-{
-  if (conn && conn->fns && conn->fns->write) {
-    return conn->fns->write(conn, dataptr, len, apiflags);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_output()
- */
-err_t
-altcp_output(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->output) {
-    return conn->fns->output(conn);
-  }
-  return ERR_VAL;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_mss()
- */
-u16_t
-altcp_mss(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->mss) {
-    return conn->fns->mss(conn);
-  }
-  return 0;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_sndbuf()
- */
-u16_t
-altcp_sndbuf(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->sndbuf) {
-    return conn->fns->sndbuf(conn);
-  }
-  return 0;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_sndqueuelen()
- */
-u16_t
-altcp_sndqueuelen(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->sndqueuelen) {
-    return conn->fns->sndqueuelen(conn);
-  }
-  return 0;
-}
-
-void
-altcp_nagle_disable(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->nagle_disable) {
-    conn->fns->nagle_disable(conn);
-  }
-}
-
-void
-altcp_nagle_enable(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->nagle_enable) {
-    conn->fns->nagle_enable(conn);
-  }
-}
-
-int
-altcp_nagle_disabled(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->nagle_disabled) {
-    return conn->fns->nagle_disabled(conn);
-  }
-  return 0;
-}
-
-/**
- * @ingroup altcp
- * @see tcp_setprio()
- */
-void
-altcp_setprio(struct altcp_pcb *conn, u8_t prio)
-{
-  if (conn && conn->fns && conn->fns->setprio) {
-    conn->fns->setprio(conn, prio);
-  }
-}
-
-err_t
-altcp_get_tcp_addrinfo(struct altcp_pcb *conn, int local, ip_addr_t *addr, u16_t *port)
-{
-  if (conn && conn->fns && conn->fns->addrinfo) {
-    return conn->fns->addrinfo(conn, local, addr, port);
-  }
-  return ERR_VAL;
-}
-
-ip_addr_t *
-altcp_get_ip(struct altcp_pcb *conn, int local)
-{
-  if (conn && conn->fns && conn->fns->getip) {
-    return conn->fns->getip(conn, local);
-  }
-  return NULL;
-}
-
-u16_t
-altcp_get_port(struct altcp_pcb *conn, int local)
-{
-  if (conn && conn->fns && conn->fns->getport) {
-    return conn->fns->getport(conn, local);
-  }
-  return 0;
-}
-
-#ifdef LWIP_DEBUG
-enum tcp_state
-altcp_dbg_get_tcp_state(struct altcp_pcb *conn)
-{
-  if (conn && conn->fns && conn->fns->dbg_get_tcp_state) {
-    return conn->fns->dbg_get_tcp_state(conn);
-  }
-  return CLOSED;
-}
-#endif
-
-/* Default implementations for the "virtual" functions */
-
-void
-altcp_default_set_poll(struct altcp_pcb *conn, u8_t interval)
-{
-  if (conn && conn->inner_conn) {
-    altcp_poll(conn->inner_conn, conn->poll, interval);
-  }
-}
-
-void
-altcp_default_recved(struct altcp_pcb *conn, u16_t len)
-{
-  if (conn && conn->inner_conn) {
-    altcp_recved(conn->inner_conn, len);
-  }
-}
-
-err_t
-altcp_default_bind(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_bind(conn->inner_conn, ipaddr, port);
-  }
-  return ERR_VAL;
-}
-
-err_t
-altcp_default_shutdown(struct altcp_pcb *conn, int shut_rx, int shut_tx)
-{
-  if (conn) {
-    if (shut_rx && shut_tx && conn->fns && conn->fns->close) {
-      /* default shutdown for both sides is close */
-      return conn->fns->close(conn);
-    }
-    if (conn->inner_conn) {
-      return altcp_shutdown(conn->inner_conn, shut_rx, shut_tx);
-    }
-  }
-  return ERR_VAL;
-}
-
-err_t
-altcp_default_write(struct altcp_pcb *conn, const void *dataptr, u16_t len, u8_t apiflags)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_write(conn->inner_conn, dataptr, len, apiflags);
-  }
-  return ERR_VAL;
-}
-
-err_t
-altcp_default_output(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_output(conn->inner_conn);
-  }
-  return ERR_VAL;
-}
-
-u16_t
-altcp_default_mss(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_mss(conn->inner_conn);
-  }
-  return 0;
-}
-
-u16_t
-altcp_default_sndbuf(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_sndbuf(conn->inner_conn);
-  }
-  return 0;
-}
-
-u16_t
-altcp_default_sndqueuelen(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_sndqueuelen(conn->inner_conn);
-  }
-  return 0;
-}
-
-void
-altcp_default_nagle_disable(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    altcp_nagle_disable(conn->inner_conn);
-  }
-}
-
-void
-altcp_default_nagle_enable(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    altcp_nagle_enable(conn->inner_conn);
-  }
-}
-
-int
-altcp_default_nagle_disabled(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_nagle_disabled(conn->inner_conn);
-  }
-  return 0;
-}
-
-void
-altcp_default_setprio(struct altcp_pcb *conn, u8_t prio)
-{
-  if (conn && conn->inner_conn) {
-    altcp_setprio(conn->inner_conn, prio);
-  }
-}
-
-void
-altcp_default_dealloc(struct altcp_pcb *conn)
-{
-  LWIP_UNUSED_ARG(conn);
-  /* nothing to do */
-}
-
-err_t
-altcp_default_get_tcp_addrinfo(struct altcp_pcb *conn, int local, ip_addr_t *addr, u16_t *port)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_get_tcp_addrinfo(conn->inner_conn, local, addr, port);
-  }
-  return ERR_VAL;
-}
-
-ip_addr_t *
-altcp_default_get_ip(struct altcp_pcb *conn, int local)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_get_ip(conn->inner_conn, local);
-  }
-  return NULL;
-}
-
-u16_t
-altcp_default_get_port(struct altcp_pcb *conn, int local)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_get_port(conn->inner_conn, local);
-  }
-  return 0;
-}
-
-#ifdef LWIP_DEBUG
-enum tcp_state
-altcp_default_dbg_get_tcp_state(struct altcp_pcb *conn)
-{
-  if (conn && conn->inner_conn) {
-    return altcp_dbg_get_tcp_state(conn->inner_conn);
-  }
-  return CLOSED;
-}
-#endif
-
-
-#endif /* LWIP_ALTCP */
--- a/src/core/altcp_alloc.c
+++ b/src/core/altcp_alloc.c
@@ -1,87 +0,0 @@
-/**
- * @file
- * Application layered TCP connection API (to be used from TCPIP thread)\n
- * This interface mimics the tcp callback API to the application while preventing
- * direct linking (much like virtual functions).
- * This way, an application can make use of other application layer protocols
- * on top of TCP without knowing the details (e.g. TLS, proxy connection).
- *
- * This file contains allocation implementation that combine several layers.
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/altcp.h"
-#include "lwip/altcp_tcp.h"
-#include "lwip/altcp_tls.h"
-#include "lwip/priv/altcp_priv.h"
-#include "lwip/mem.h"
-
-#include <string.h>
-
-#if LWIP_ALTCP_TLS
-
-/** This standard allocator function creates an altcp pcb for
- * TLS over TCP */
-struct altcp_pcb *
-altcp_tls_new(struct altcp_tls_config *config, u8_t ip_type)
-{
-  struct altcp_pcb *inner_conn, *ret;
-  LWIP_UNUSED_ARG(ip_type);
-
-  inner_conn = altcp_tcp_new_ip_type(ip_type);
-  if (inner_conn == NULL) {
-    return NULL;
-  }
-  ret = altcp_tls_wrap(config, inner_conn);
-  if (ret == NULL) {
-    altcp_close(inner_conn);
-  }
-  return ret;
-}
-
-/** This standard allocator function creates an altcp pcb for
- * TLS over TCP */
-struct altcp_pcb *
-altcp_tls_alloc(void *arg, u8_t ip_type)
-{
-  return altcp_tls_new((struct altcp_tls_config *)arg, ip_type);
-}
-
-#endif /* LWIP_ALTCP_TLS */
-
-#endif /* LWIP_ALTCP */
--- a/src/core/altcp_tcp.c
+++ b/src/core/altcp_tcp.c
@@ -1,543 +0,0 @@
-/**
- * @file
- * Application layered TCP connection API (to be used from TCPIP thread)\n
- * This interface mimics the tcp callback API to the application while preventing
- * direct linking (much like virtual functions).
- * This way, an application can make use of other application layer protocols
- * on top of TCP without knowing the details (e.g. TLS, proxy connection).
- *
- * This file contains the base implementation calling into tcp.
- */
-
-/*
- * Copyright (c) 2017 Simon Goldschmidt
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- *    this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- *    this list of conditions and the following disclaimer in the documentation
- *    and/or other materials provided with the distribution.
- * 3. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
- * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
- * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
- * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
- * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
- * OF SUCH DAMAGE.
- *
- * This file is part of the lwIP TCP/IP stack.
- *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
- *
- */
-
-#include "lwip/opt.h"
-
-#if LWIP_ALTCP /* don't build if not configured for use in lwipopts.h */
-
-#include "lwip/altcp.h"
-#include "lwip/altcp_tcp.h"
-#include "lwip/priv/altcp_priv.h"
-#include "lwip/tcp.h"
-#include "lwip/mem.h"
-
-#include <string.h>
-
-#define ALTCP_TCP_ASSERT_CONN(conn) do { \
-  LWIP_ASSERT("conn->inner_conn == NULL", (conn)->inner_conn == NULL); \
-  LWIP_UNUSED_ARG(conn); /* for LWIP_NOASSERT */ } while(0)
-#define ALTCP_TCP_ASSERT_CONN_PCB(conn, tpcb) do { \
-  LWIP_ASSERT("pcb mismatch", (conn)->state == tpcb); \
-  LWIP_UNUSED_ARG(tpcb); /* for LWIP_NOASSERT */ \
-  ALTCP_TCP_ASSERT_CONN(conn); } while(0)
-
-
-/* Variable prototype, the actual declaration is at the end of this file
-   since it contains pointers to static functions declared here */
-extern const struct altcp_functions altcp_tcp_functions;
-
-static void altcp_tcp_setup(struct altcp_pcb *conn, struct tcp_pcb *tpcb);
-
-/* callback functions for TCP */
-static err_t
-altcp_tcp_accept(void *arg, struct tcp_pcb *new_tpcb, err_t err)
-{
-  struct altcp_pcb *listen_conn = (struct altcp_pcb *)arg;
-  if (listen_conn && listen_conn->accept) {
-    /* create a new altcp_conn to pass to the next 'accept' callback */
-    struct altcp_pcb *new_conn = altcp_alloc();
-    if (new_conn == NULL) {
-      return ERR_MEM;
-    }
-    altcp_tcp_setup(new_conn, new_tpcb);
-    return listen_conn->accept(listen_conn->arg, new_conn, err);
-  }
-  return ERR_ARG;
-}
-
-static err_t
-altcp_tcp_connected(void *arg, struct tcp_pcb *tpcb, err_t err)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    ALTCP_TCP_ASSERT_CONN_PCB(conn, tpcb);
-    if (conn->connected) {
-      return conn->connected(conn->arg, conn, err);
-    }
-  }
-  return ERR_OK;
-}
-
-static err_t
-altcp_tcp_recv(void *arg, struct tcp_pcb *tpcb, struct pbuf *p, err_t err)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    ALTCP_TCP_ASSERT_CONN_PCB(conn, tpcb);
-    if (conn->recv) {
-      return conn->recv(conn->arg, conn, p, err);
-    }
-  }
-  if (p != NULL) {
-    /* prevent memory leaks */
-    pbuf_free(p);
-  }
-  return ERR_OK;
-}
-
-static err_t
-altcp_tcp_sent(void *arg, struct tcp_pcb *tpcb, u16_t len)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    ALTCP_TCP_ASSERT_CONN_PCB(conn, tpcb);
-    if (conn->sent) {
-      return conn->sent(conn->arg, conn, len);
-    }
-  }
-  return ERR_OK;
-}
-
-static err_t
-altcp_tcp_poll(void *arg, struct tcp_pcb *tpcb)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    ALTCP_TCP_ASSERT_CONN_PCB(conn, tpcb);
-    if (conn->poll) {
-      return conn->poll(conn->arg, conn);
-    }
-  }
-  return ERR_OK;
-}
-
-static void
-altcp_tcp_err(void *arg, err_t err)
-{
-  struct altcp_pcb *conn = (struct altcp_pcb *)arg;
-  if (conn) {
-    conn->state = NULL; /* already freed */
-    if (conn->err) {
-      conn->err(conn->arg, err);
-    }
-    altcp_free(conn);
-  }
-}
-
-/* setup functions */
-
-static void
-altcp_tcp_remove_callbacks(struct tcp_pcb *tpcb)
-{
-  tcp_arg(tpcb, NULL);
-  tcp_recv(tpcb, NULL);
-  tcp_sent(tpcb, NULL);
-  tcp_err(tpcb, NULL);
-  tcp_poll(tpcb, NULL, tpcb->pollinterval);
-}
-
-static void
-altcp_tcp_setup_callbacks(struct altcp_pcb *conn, struct tcp_pcb *tpcb)
-{
-  tcp_arg(tpcb, conn);
-  tcp_recv(tpcb, altcp_tcp_recv);
-  tcp_sent(tpcb, altcp_tcp_sent);
-  tcp_err(tpcb, altcp_tcp_err);
-  /* tcp_poll is set when interval is set by application */
-  /* listen is set totally different :-) */
-}
-
-static void
-altcp_tcp_setup(struct altcp_pcb *conn, struct tcp_pcb *tpcb)
-{
-  altcp_tcp_setup_callbacks(conn, tpcb);
-  conn->state = tpcb;
-  conn->fns = &altcp_tcp_functions;
-}
-
-struct altcp_pcb *
-altcp_tcp_new_ip_type(u8_t ip_type)
-{
-  /* Allocate the tcp pcb first to invoke the priority handling code
-     if we're out of pcbs */
-  struct tcp_pcb *tpcb = tcp_new_ip_type(ip_type);
-  if (tpcb != NULL) {
-    struct altcp_pcb *ret = altcp_alloc();
-    if (ret != NULL) {
-      altcp_tcp_setup(ret, tpcb);
-      return ret;
-    } else {
-      /* altcp_pcb allocation failed -> free the tcp_pcb too */
-      tcp_close(tpcb);
-    }
-  }
-  return NULL;
-}
-
-/** altcp_tcp allocator function fitting to @ref altcp_allocator_t / @ref altcp_new.
-*
-* arg pointer is not used for TCP.
-*/
-struct altcp_pcb *
-altcp_tcp_alloc(void *arg, u8_t ip_type)
-{
-  LWIP_UNUSED_ARG(arg);
-  return altcp_tcp_new_ip_type(ip_type);
-}
-
-struct altcp_pcb *
-altcp_tcp_wrap(struct tcp_pcb *tpcb)
-{
-  if (tpcb != NULL) {
-    struct altcp_pcb *ret = altcp_alloc();
-    if (ret != NULL) {
-      altcp_tcp_setup(ret, tpcb);
-      return ret;
-    }
-  }
-  return NULL;
-}
-
-
-/* "virtual" functions calling into tcp */
-static void
-altcp_tcp_set_poll(struct altcp_pcb *conn, u8_t interval)
-{
-  if (conn != NULL) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    tcp_poll(pcb, altcp_tcp_poll, interval);
-  }
-}
-
-static void
-altcp_tcp_recved(struct altcp_pcb *conn, u16_t len)
-{
-  if (conn != NULL) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    tcp_recved(pcb, len);
-  }
-}
-
-static err_t
-altcp_tcp_bind(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_bind(pcb, ipaddr, port);
-}
-
-static err_t
-altcp_tcp_connect(struct altcp_pcb *conn, const ip_addr_t *ipaddr, u16_t port, altcp_connected_fn connected)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  conn->connected = connected;
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_connect(pcb, ipaddr, port, altcp_tcp_connected);
-}
-
-static struct altcp_pcb *
-altcp_tcp_listen(struct altcp_pcb *conn, u8_t backlog, err_t *err)
-{
-  struct tcp_pcb *pcb;
-  struct tcp_pcb *lpcb;
-  if (conn == NULL) {
-    return NULL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  lpcb = tcp_listen_with_backlog_and_err(pcb, backlog, err);
-  if (lpcb != NULL) {
-    conn->state = lpcb;
-    tcp_accept(lpcb, altcp_tcp_accept);
-    return conn;
-  }
-  return NULL;
-}
-
-static void
-altcp_tcp_abort(struct altcp_pcb *conn)
-{
-  if (conn != NULL) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    if (pcb) {
-      tcp_abort(pcb);
-    }
-  }
-}
-
-static err_t
-altcp_tcp_close(struct altcp_pcb *conn)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  if (pcb) {
-    err_t err;
-    tcp_poll_fn oldpoll = pcb->poll;
-    altcp_tcp_remove_callbacks(pcb);
-    err = tcp_close(pcb);
-    if (err != ERR_OK) {
-      /* not closed, set up all callbacks again */
-      altcp_tcp_setup_callbacks(conn, pcb);
-      /* poll callback is not included in the above */
-      tcp_poll(pcb, oldpoll, pcb->pollinterval);
-      return err;
-    }
-    conn->state = NULL; /* unsafe to reference pcb after tcp_close(). */
-  }
-  altcp_free(conn);
-  return ERR_OK;
-}
-
-static err_t
-altcp_tcp_shutdown(struct altcp_pcb *conn, int shut_rx, int shut_tx)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_shutdown(pcb, shut_rx, shut_tx);
-}
-
-static err_t
-altcp_tcp_write(struct altcp_pcb *conn, const void *dataptr, u16_t len, u8_t apiflags)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_write(pcb, dataptr, len, apiflags);
-}
-
-static err_t
-altcp_tcp_output(struct altcp_pcb *conn)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return ERR_VAL;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_output(pcb);
-}
-
-static u16_t
-altcp_tcp_mss(struct altcp_pcb *conn)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return 0;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_mss(pcb);
-}
-
-static u16_t
-altcp_tcp_sndbuf(struct altcp_pcb *conn)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return 0;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_sndbuf(pcb);
-}
-
-static u16_t
-altcp_tcp_sndqueuelen(struct altcp_pcb *conn)
-{
-  struct tcp_pcb *pcb;
-  if (conn == NULL) {
-    return 0;
-  }
-  ALTCP_TCP_ASSERT_CONN(conn);
-  pcb = (struct tcp_pcb *)conn->state;
-  return tcp_sndqueuelen(pcb);
-}
-
-static void
-altcp_tcp_nagle_disable(struct altcp_pcb *conn)
-{
-  if (conn && conn->state) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    tcp_nagle_disable(pcb);
-  }
-}
-
-static void
-altcp_tcp_nagle_enable(struct altcp_pcb *conn)
-{
-  if (conn && conn->state) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    tcp_nagle_enable(pcb);
-  }
-}
-
-static int
-altcp_tcp_nagle_disabled(struct altcp_pcb *conn)
-{
-  if (conn && conn->state) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    return tcp_nagle_disabled(pcb);
-  }
-  return 0;
-}
-
-static void
-altcp_tcp_setprio(struct altcp_pcb *conn, u8_t prio)
-{
-  if (conn != NULL) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    tcp_setprio(pcb, prio);
-  }
-}
-
-static void
-altcp_tcp_dealloc(struct altcp_pcb *conn)
-{
-  LWIP_UNUSED_ARG(conn);
-  ALTCP_TCP_ASSERT_CONN(conn);
-  /* no private state to clean up */
-}
-
-static err_t
-altcp_tcp_get_tcp_addrinfo(struct altcp_pcb *conn, int local, ip_addr_t *addr, u16_t *port)
-{
-  if (conn) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    return tcp_tcp_get_tcp_addrinfo(pcb, local, addr, port);
-  }
-  return ERR_VAL;
-}
-
-static ip_addr_t *
-altcp_tcp_get_ip(struct altcp_pcb *conn, int local)
-{
-  if (conn) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    if (pcb) {
-      if (local) {
-        return &pcb->local_ip;
-      } else {
-        return &pcb->remote_ip;
-      }
-    }
-  }
-  return NULL;
-}
-
-static u16_t
-altcp_tcp_get_port(struct altcp_pcb *conn, int local)
-{
-  if (conn) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    if (pcb) {
-      if (local) {
-        return pcb->local_port;
-      } else {
-        return pcb->remote_port;
-      }
-    }
-  }
-  return 0;
-}
-
-#ifdef LWIP_DEBUG
-static enum tcp_state
-altcp_tcp_dbg_get_tcp_state(struct altcp_pcb *conn)
-{
-  if (conn) {
-    struct tcp_pcb *pcb = (struct tcp_pcb *)conn->state;
-    ALTCP_TCP_ASSERT_CONN(conn);
-    if (pcb) {
-      return pcb->state;
-    }
-  }
-  return CLOSED;
-}
-#endif
-const struct altcp_functions altcp_tcp_functions = {
-  altcp_tcp_set_poll,
-  altcp_tcp_recved,
-  altcp_tcp_bind,
-  altcp_tcp_connect,
-  altcp_tcp_listen,
-  altcp_tcp_abort,
-  altcp_tcp_close,
-  altcp_tcp_shutdown,
-  altcp_tcp_write,
-  altcp_tcp_output,
-  altcp_tcp_mss,
-  altcp_tcp_sndbuf,
-  altcp_tcp_sndqueuelen,
-  altcp_tcp_nagle_disable,
-  altcp_tcp_nagle_enable,
-  altcp_tcp_nagle_disabled,
-  altcp_tcp_setprio,
-  altcp_tcp_dealloc,
-  altcp_tcp_get_tcp_addrinfo,
-  altcp_tcp_get_ip,
-  altcp_tcp_get_port
-#ifdef LWIP_DEBUG
-  , altcp_tcp_dbg_get_tcp_state
-#endif
-};
-
-#endif /* LWIP_ALTCP */
--- a/src/core/def.c
+++ b/src/core/def.c
@@ -11,7 +11,7 @@
 * \#define lwip_htonl(x) your_htonl
 *
 * Note lwip_ntohs() and lwip_ntohl() are merely references to the htonx counterparts.
- *
+ * 
 * If you \#define them to htons() and htonl(), you should
 * \#define LWIP_DONT_PROVIDE_BYTEORDER_FUNCTIONS to prevent lwIP from
 * defining htonx/ntohx compatibility macros.
@@ -75,7 +75,7 @@
 u16_t
 lwip_htons(u16_t n)
 {
-  return PP_HTONS(n);
+  return (u16_t)PP_HTONS(n);
 }
 #endif /* lwip_htons */

@@ -89,7 +89,7 @@ lwip_htons(u16_t n)
 u32_t
 lwip_htonl(u32_t n)
 {
-  return PP_HTONL(n);
+  return (u32_t)PP_HTONL(n);
 }
 #endif /* lwip_htonl */

@@ -101,10 +101,10 @@ lwip_htonl(u32_t n)
 * lwIP default implementation for strnstr() non-standard function.
 * This can be \#defined to strnstr() depending on your platform port.
 */
-char *
-lwip_strnstr(const char *buffer, const char *token, size_t n)
+char*
+lwip_strnstr(const char* buffer, const char* token, size_t n)
 {
-  const char *p;
+  const char* p;
  size_t tokenlen = strlen(token);
  if (tokenlen == 0) {
    return LWIP_CONST_CAST(char *, buffer);
@@ -125,7 +125,7 @@ lwip_strnstr(const char *buffer, const char *token, size_t n)
 * This can be \#defined to stricmp() depending on your platform port.
 */
 int
-lwip_stricmp(const char *str1, const char *str2)
+lwip_stricmp(const char* str1, const char* str2)
 {
  char c1, c2;

@@ -160,7 +160,7 @@ lwip_stricmp(const char *str1, const char *str2)
 * This can be \#defined to strnicmp() depending on your platform port.
 */
 int
-lwip_strnicmp(const char *str1, const char *str2, size_t len)
+lwip_strnicmp(const char* str1, const char* str2, size_t len)
 {
  char c1, c2;

@@ -183,8 +183,7 @@ lwip_strnicmp(const char *str1, const char *str2, size_t len)
        return 1;
      }
    }
-    len--;
-  } while ((len != 0) && (c1 != 0));
+  } while (len-- && c1 != 0);
  return 0;
 }
 #endif
@@ -196,45 +195,28 @@ lwip_strnicmp(const char *str1, const char *str2, size_t len)
 * This can be \#defined to itoa() or snprintf(result, bufsize, "%d", number) depending on your platform port.
 */
 void
-lwip_itoa(char *result, size_t bufsize, int number)
+lwip_itoa(char* result, size_t bufsize, int number)
 {
-  char *res = result;
-  char *tmp = result + bufsize - 1;
-  int n = (number >= 0) ? number : -number;
+  const int base = 10;
+  char* ptr = result, *ptr1 = result, tmp_char;
+  int tmp_value;
+  LWIP_UNUSED_ARG(bufsize);

-  /* handle invalid bufsize */
-  if (bufsize < 2) {
-    if (bufsize == 1) {
-      *result = 0;
-    }
-    return;
-  }
+  do {
+    tmp_value = number;
+    number /= base;
+    *ptr++ = "zyxwvutsrqponmlkjihgfedcba9876543210123456789abcdefghijklmnopqrstuvwxyz"[35 + (tmp_value - number * base)];
+  } while(number);

-  /* First, add sign */
-  if (number < 0) {
-    *res++ = '-';
+   /* Apply negative sign */
+  if (tmp_value < 0) {
+     *ptr++ = '-';
  }
-  /* Then create the string from the end and stop if buffer full,
-     and ensure output string is zero terminated */
-  *tmp = 0;
-  while ((n != 0) && (tmp > res)) {
-    char val = (char)('0' + (n % 10));
-    tmp--;
-    *tmp = val;
-    n = n / 10;
+  *ptr-- = '\0';
+  while(ptr1 < ptr) {
+    tmp_char = *ptr;
+    *ptr--= *ptr1;
+    *ptr1++ = tmp_char;
  }
-  if (n) {
-    /* buffer is too small */
-    *result = 0;
-    return;
-  }
-  if (*tmp == 0) {
-    /* Nothing added? */
-    *res++ = '0';
-    *res++ = 0;
-    return;
-  }
-  /* move from temporary buffer to output buffer (sign is not moved) */
-  memmove(res, tmp, (size_t)((result + bufsize) - tmp));
 }
 #endif
--- a/src/core/dns.c
+++ b/src/core/dns.c
@@ -23,16 +23,14 @@
 * Once a hostname has been resolved (or found to be non-existent),
 * the resolver code calls a specified callback function (which
 * must be implemented by the module that uses the resolver).
- *
+ * 
 * Multicast DNS queries are supported for names ending on ".local".
 * However, only "One-Shot Multicast DNS Queries" are supported (RFC 6762
 * chapter 5.1), this is not a fully compliant implementation of continuous
 * mDNS querying!
 *
 * All functions must be called from TCPIP thread.
- *
- * @see DNS_MAX_SERVERS
- * @see LWIP_DHCP_MAX_DNS_SERVERS
+ * 
 * @see @ref netconn_common for thread-safe access.
 */

@@ -112,6 +110,11 @@ static u16_t dns_txid;
 #define DNS_PORT_ALLOWED(port) ((port) >= 1024)
 #endif

+/** DNS maximum number of retries when asking for a name, before "timeout". */
+#ifndef DNS_MAX_RETRIES
+#define DNS_MAX_RETRIES           4
+#endif
+
 /** DNS resource record max. TTL (one week as default) */
 #ifndef DNS_MAX_TTL
 #define DNS_MAX_TTL               604800
@@ -284,7 +287,7 @@ static err_t dns_lookup_local(const char *hostname, ip_addr_t *addr LWIP_DNS_ADD
 /* forward declarations */
 static void dns_recv(void *s, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr, u16_t port);
 static void dns_check_entries(void);
-static void dns_call_found(u8_t idx, ip_addr_t *addr);
+static void dns_call_found(u8_t idx, ip_addr_t* addr);

 /*-----------------------------------------------------------------------------
 * Globals
@@ -322,9 +325,9 @@ dns_init(void)
 #endif /* DNS_SERVER_ADDRESS */

  LWIP_ASSERT("sanity check SIZEOF_DNS_QUERY",
-              sizeof(struct dns_query) == SIZEOF_DNS_QUERY);
+    sizeof(struct dns_query) == SIZEOF_DNS_QUERY);
  LWIP_ASSERT("sanity check SIZEOF_DNS_ANSWER",
-              sizeof(struct dns_answer) <= SIZEOF_DNS_ANSWER_ASSERT);
+    sizeof(struct dns_answer) <= SIZEOF_DNS_ANSWER_ASSERT);

  LWIP_DEBUGF(DNS_DEBUG, ("dns_init: initializing\n"));

@@ -337,7 +340,7 @@ dns_init(void)
    /* initialize DNS table not needed (initialized to zero since it is a
     * global variable) */
    LWIP_ASSERT("For implicit initialization to work, DNS_STATE_UNUSED needs to be 0",
-                DNS_STATE_UNUSED == 0);
+      DNS_STATE_UNUSED == 0);

    /* initialize DNS client */
    udp_bind(dns_pcbs[0], IP_ANY_TYPE, 0);
@@ -377,7 +380,7 @@ dns_setserver(u8_t numdns, const ip_addr_t *dnsserver)
 * @return IP address of the indexed DNS server or "ip_addr_any" if the DNS
 *         server has not been configured.
 */
-const ip_addr_t *
+const ip_addr_t*
 dns_getserver(u8_t numdns)
 {
  if (numdns < DNS_MAX_SERVERS) {
@@ -416,7 +419,7 @@ dns_init_local(void)
    entry = (struct local_hostlist_entry *)memp_malloc(MEMP_LOCALHOSTLIST);
    LWIP_ASSERT("mem-error in dns_init_local", entry != NULL);
    if (entry != NULL) {
-      char *entry_name = (char *)entry + sizeof(struct local_hostlist_entry);
+      char* entry_name = (char*)entry + sizeof(struct local_hostlist_entry);
      MEMCPY(entry_name, init_entry->name, namelen);
      entry_name[namelen] = 0;
      entry->name = entry_name;
@@ -563,7 +566,7 @@ dns_local_addhost(const char *hostname, const ip_addr_t *addr)
 {
  struct local_hostlist_entry *entry;
  size_t namelen;
-  char *entry_name;
+  char* entry_name;
  LWIP_ASSERT("invalid host name (NULL)", hostname != NULL);
  namelen = strlen(hostname);
  LWIP_ASSERT("namelen <= DNS_LOCAL_HOSTLIST_MAX_NAMELEN", namelen <= DNS_LOCAL_HOSTLIST_MAX_NAMELEN);
@@ -571,7 +574,7 @@ dns_local_addhost(const char *hostname, const ip_addr_t *addr)
  if (entry == NULL) {
    return ERR_MEM;
  }
-  entry_name = (char *)entry + sizeof(struct local_hostlist_entry);
+  entry_name = (char*)entry + sizeof(struct local_hostlist_entry);
  MEMCPY(entry_name, hostname, namelen);
  entry_name[namelen] = 0;
  entry->name = entry_name;
@@ -602,6 +605,8 @@ static err_t
 dns_lookup(const char *name, ip_addr_t *addr LWIP_DNS_ADDRTYPE_ARG(u8_t dns_addrtype))
 {
  u8_t i;
+#if DNS_LOCAL_HOSTLIST || defined(DNS_LOOKUP_LOCAL_EXTERN)
+#endif /* DNS_LOCAL_HOSTLIST || defined(DNS_LOOKUP_LOCAL_EXTERN) */
 #if DNS_LOCAL_HOSTLIST
  if (dns_lookup_local(name, addr LWIP_DNS_ADDRTYPE_ARG(dns_addrtype)) == ERR_OK) {
    return ERR_OK;
@@ -619,7 +624,7 @@ dns_lookup(const char *name, ip_addr_t *addr LWIP_DNS_ADDRTYPE_ARG(u8_t dns_addr
        (lwip_strnicmp(name, dns_table[i].name, sizeof(dns_table[i].name)) == 0) &&
        LWIP_DNS_ADDRTYPE_MATCH_IP(dns_addrtype, dns_table[i].ipaddr)) {
      LWIP_DEBUGF(DNS_DEBUG, ("dns_lookup: \"%s\": found = ", name));
-      ip_addr_debug_print_val(DNS_DEBUG, dns_table[i].ipaddr);
+      ip_addr_debug_print(DNS_DEBUG, &(dns_table[i].ipaddr));
      LWIP_DEBUGF(DNS_DEBUG, ("\n"));
      if (addr) {
        ip_addr_copy(*addr, dns_table[i].ipaddr);
@@ -637,29 +642,22 @@ dns_lookup(const char *name, ip_addr_t *addr LWIP_DNS_ADDRTYPE_ARG(u8_t dns_addr
 * entry (otherwise, answers might arrive late for hostname not on the list
 * any more).
 *
- * For now, this function compares case-insensitive to cope with all kinds of
- * servers. This also means that "dns 0x20 bit encoding" must be checked
- * externally, if we want to implement it.
- * Currently, the request is sent exactly as passed in by he user request.
- *
 * @param query hostname (not encoded) from the dns_table
 * @param p pbuf containing the encoded hostname in the DNS response
 * @param start_offset offset into p where the name starts
 * @return 0xFFFF: names differ, other: names equal -> offset behind name
 */
 static u16_t
-dns_compare_name(const char *query, struct pbuf *p, u16_t start_offset)
+dns_compare_name(const char *query, struct pbuf* p, u16_t start_offset)
 {
  int n;
  u16_t response_offset = start_offset;

  do {
-    n = pbuf_try_get_at(p, response_offset);
-    if ((n < 0) || (response_offset == 0xFFFF)) {
-      /* error or overflow */
+    n = pbuf_try_get_at(p, response_offset++);
+    if (n < 0) {
      return 0xFFFF;
    }
-    response_offset++;
    /** @see RFC 1035 - 4.1.4. Message compression */
    if ((n & 0xc0) == 0xc0) {
      /* Compressed name: cannot be equal since we don't send them */
@@ -671,14 +669,10 @@ dns_compare_name(const char *query, struct pbuf *p, u16_t start_offset)
        if (c < 0) {
          return 0xFFFF;
        }
-        if (lwip_tolower((*query)) != lwip_tolower((u8_t)c)) {
+        if ((*query) != (u8_t)c) {
          return 0xFFFF;
        }
-        if (response_offset == 0xFFFF) {
-          /* would overflow */
-          return 0xFFFF;
-        }
-        response_offset++;
+        ++response_offset;
        ++query;
        --n;
      }
@@ -690,11 +684,7 @@ dns_compare_name(const char *query, struct pbuf *p, u16_t start_offset)
    }
  } while (n != 0);

-  if (response_offset == 0xFFFF) {
-    /* would overflow */
-    return 0xFFFF;
-  }
-  return (u16_t)(response_offset + 1);
+  return response_offset + 1;
 }

 /**
@@ -705,14 +695,14 @@ dns_compare_name(const char *query, struct pbuf *p, u16_t start_offset)
 * @return index to end of the name
 */
 static u16_t
-dns_skip_name(struct pbuf *p, u16_t query_idx)
+dns_skip_name(struct pbuf* p, u16_t query_idx)
 {
  int n;
  u16_t offset = query_idx;

  do {
    n = pbuf_try_get_at(p, offset++);
-    if ((n < 0) || (offset == 0)) {
+    if (n < 0) {
      return 0xFFFF;
    }
    /** @see RFC 1035 - 4.1.4. Message compression */
@@ -732,10 +722,7 @@ dns_skip_name(struct pbuf *p, u16_t query_idx)
    }
  } while (n != 0);

-  if (offset == 0xFFFF) {
-    return 0xFFFF;
-  }
-  return (u16_t)(offset + 1);
+  return offset + 1;
 }

 /**
@@ -755,16 +742,16 @@ dns_send(u8_t idx)
  const char *hostname, *hostname_part;
  u8_t n;
  u8_t pcb_idx;
-  struct dns_table_entry *entry = &dns_table[idx];
+  struct dns_table_entry* entry = &dns_table[idx];

  LWIP_DEBUGF(DNS_DEBUG, ("dns_send: dns_servers[%"U16_F"] \"%s\": request\n",
-                          (u16_t)(entry->server_idx), entry->name));
+              (u16_t)(entry->server_idx), entry->name));
  LWIP_ASSERT("dns server out of array", entry->server_idx < DNS_MAX_SERVERS);
  if (ip_addr_isany_val(dns_servers[entry->server_idx])
 #if LWIP_DNS_SUPPORT_MDNS_QUERIES
      && !entry->is_mdns
 #endif
-     ) {
+    ) {
    /* DNS server not valid anymore, e.g. PPP netif has been shut down */
    /* call specified callback function if provided */
    dns_call_found(idx, NULL);
@@ -775,9 +762,9 @@ dns_send(u8_t idx)

  /* if here, we have either a new query or a retry on a previous query to process */
  p = pbuf_alloc(PBUF_TRANSPORT, (u16_t)(SIZEOF_DNS_HDR + strlen(entry->name) + 2 +
-                                         SIZEOF_DNS_QUERY), PBUF_RAM);
+                 SIZEOF_DNS_QUERY), PBUF_RAM);
  if (p != NULL) {
-    const ip_addr_t *dst;
+    const ip_addr_t* dst;
    u16_t dst_port;
    /* fill dns header */
    memset(&hdr, 0, SIZEOF_DNS_HDR);
@@ -797,13 +784,9 @@ dns_send(u8_t idx)
        ++n;
      }
      copy_len = (u16_t)(hostname - hostname_part);
-      if (query_idx + n + 1 > 0xFFFF) {
-        /* u16_t overflow */
-        goto overflow_return;
-      }
      pbuf_put_at(p, query_idx, n);
-      pbuf_take_at(p, hostname_part, copy_len, (u16_t)(query_idx + 1));
-      query_idx = (u16_t)(query_idx + n + 1);
+      pbuf_take_at(p, hostname_part, copy_len, query_idx + 1);
+      query_idx += n + 1;
    } while (*hostname != 0);
    pbuf_put_at(p, query_idx, 0);
    query_idx++;
@@ -824,12 +807,13 @@ dns_send(u8_t idx)
 #endif
    /* send dns packet */
    LWIP_DEBUGF(DNS_DEBUG, ("sending DNS request ID %d for name \"%s\" to server %d\r\n",
-                            entry->txid, entry->name, entry->server_idx));
+      entry->txid, entry->name, entry->server_idx));
 #if LWIP_DNS_SUPPORT_MDNS_QUERIES
    if (entry->is_mdns) {
      dst_port = DNS_MQUERY_PORT;
 #if LWIP_IPV6
-      if (LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype)) {
+      if (LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype))
+      {
        dst = &dns_mquery_v6group;
      }
 #endif
@@ -856,38 +840,35 @@ dns_send(u8_t idx)
  }

  return err;
-overflow_return:
-  pbuf_free(p);
-  return ERR_VAL;
 }

 #if ((LWIP_DNS_SECURE & LWIP_DNS_SECURE_RAND_SRC_PORT) != 0)
-static struct udp_pcb *
+static struct udp_pcb*
 dns_alloc_random_port(void)
 {
  err_t err;
-  struct udp_pcb *pcb;
+  struct udp_pcb* ret;

-  pcb = udp_new_ip_type(IPADDR_TYPE_ANY);
-  if (pcb == NULL) {
+  ret = udp_new_ip_type(IPADDR_TYPE_ANY);
+  if (ret == NULL) {
    /* out of memory, have to reuse an existing pcb */
    return NULL;
  }
  do {
    u16_t port = (u16_t)DNS_RAND_TXID();
-    if (DNS_PORT_ALLOWED(port)) {
-      err = udp_bind(pcb, IP_ANY_TYPE, port);
-    } else {
+    if (!DNS_PORT_ALLOWED(port)) {
      /* this port is not allowed, try again */
      err = ERR_USE;
+      continue;
    }
+    err = udp_bind(ret, IP_ANY_TYPE, port);
  } while (err == ERR_USE);
  if (err != ERR_OK) {
-    udp_remove(pcb);
+    udp_remove(ret);
    return NULL;
  }
-  udp_recv(pcb, dns_recv, NULL);
-  return pcb;
+  udp_recv(ret, dns_recv, NULL);
+  return ret;
 }

 /**
@@ -916,8 +897,8 @@ dns_alloc_pcb(void)
    }
  }
  /* if we come here, creating a new UDP pcb failed, so we have to use
-     an already existing one (so overflow is no issue) */
-  for (i = 0, idx = (u8_t)(dns_last_pcb_idx + 1); i < DNS_MAX_SOURCE_PORTS; i++, idx++) {
+     an already existing one */
+  for (i = 0, idx = dns_last_pcb_idx + 1; i < DNS_MAX_SOURCE_PORTS; i++, idx++) {
    if (idx >= DNS_MAX_SOURCE_PORTS) {
      idx = 0;
    }
@@ -939,7 +920,7 @@ dns_alloc_pcb(void)
 * @param addr IP address for the hostname (or NULL on error or memory shortage)
 */
 static void
-dns_call_found(u8_t idx, ip_addr_t *addr)
+dns_call_found(u8_t idx, ip_addr_t* addr)
 {
 #if ((LWIP_DNS_SECURE & (LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING | LWIP_DNS_SECURE_RAND_SRC_PORT)) != 0)
  u8_t i;
@@ -1017,23 +998,6 @@ again:
  return txid;
 }

-/**
- * Check whether there are other backup DNS servers available to try
- */
-static u8_t
-dns_backupserver_available(struct dns_table_entry *pentry)
-{
-  u8_t ret = 0;
-
-  if (pentry) {
-    if ((pentry->server_idx + 1 < DNS_MAX_SERVERS) && !ip_addr_isany_val(dns_servers[pentry->server_idx + 1])) {
-      ret = 1;
-    }
-  }
-
-  return ret;
-}
-
 /**
 * dns_check_entry() - see if entry has not yet been queried and, if so, sends out a query.
 * Check an entry in the dns_table:
@@ -1070,11 +1034,11 @@ dns_check_entry(u8_t i)
    case DNS_STATE_ASKING:
      if (--entry->tmr == 0) {
        if (++entry->retries == DNS_MAX_RETRIES) {
-          if (dns_backupserver_available(entry)
+          if ((entry->server_idx + 1 < DNS_MAX_SERVERS) && !ip_addr_isany_val(dns_servers[entry->server_idx + 1])
 #if LWIP_DNS_SUPPORT_MDNS_QUERIES
-              && !entry->is_mdns
+            && !entry->is_mdns
 #endif /* LWIP_DNS_SUPPORT_MDNS_QUERIES */
-             ) {
+            ) {
            /* change of server */
            entry->server_idx++;
            entry->tmr = 1;
@@ -1141,7 +1105,7 @@ dns_correct_response(u8_t idx, u32_t ttl)
  entry->state = DNS_STATE_DONE;

  LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": response = ", entry->name));
-  ip_addr_debug_print_val(DNS_DEBUG, entry->ipaddr);
+  ip_addr_debug_print(DNS_DEBUG, (&(entry->ipaddr)));
  LWIP_DEBUGF(DNS_DEBUG, ("\n"));

  /* read the answer resource record's TTL, and maximize it if needed */
@@ -1162,7 +1126,6 @@ dns_correct_response(u8_t idx, u32_t ttl)
    }
  }
 }
-
 /**
 * Receive input function for DNS response packets arriving for the dns UDP pcb.
 */
@@ -1185,7 +1148,7 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
  if (p->tot_len < (SIZEOF_DNS_HDR + SIZEOF_DNS_QUERY)) {
    LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: pbuf too small\n"));
    /* free pbuf and return */
-    goto ignore_packet;
+    goto memerr;
  }

  /* copy dns payload inside static buffer for processing */
@@ -1193,7 +1156,7 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
    /* Match the ID in the DNS header with the name table. */
    txid = lwip_htons(hdr.id);
    for (i = 0; i < DNS_TABLE_SIZE; i++) {
-      struct dns_table_entry *entry = &dns_table[i];
+      const struct dns_table_entry *entry = &dns_table[i];
      if ((entry->state == DNS_STATE_ASKING) &&
          (entry->txid == txid)) {

@@ -1205,11 +1168,11 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
        /* Check for correct response. */
        if ((hdr.flags1 & DNS_FLAG1_RESPONSE) == 0) {
          LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": not a response\n", entry->name));
-          goto ignore_packet; /* ignore this packet */
+          goto memerr; /* ignore this packet */
        }
        if (nquestions != 1) {
          LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": response not match to query\n", entry->name));
-          goto ignore_packet; /* ignore this packet */
+          goto memerr; /* ignore this packet */
        }

 #if LWIP_DNS_SUPPORT_MDNS_QUERIES
@@ -1219,7 +1182,7 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
          /* Check whether response comes from the same network address to which the
             question was sent. (RFC 5452) */
          if (!ip_addr_cmp(addr, &dns_servers[entry->server_idx])) {
-            goto ignore_packet; /* ignore this packet */
+            goto memerr; /* ignore this packet */
          }
        }

@@ -1228,58 +1191,38 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
        res_idx = dns_compare_name(entry->name, p, SIZEOF_DNS_HDR);
        if (res_idx == 0xFFFF) {
          LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": response not match to query\n", entry->name));
-          goto ignore_packet; /* ignore this packet */
+          goto memerr; /* ignore this packet */
        }

        /* check if "question" part matches the request */
        if (pbuf_copy_partial(p, &qry, SIZEOF_DNS_QUERY, res_idx) != SIZEOF_DNS_QUERY) {
-          goto ignore_packet; /* ignore this packet */
+          goto memerr; /* ignore this packet */
        }
        if ((qry.cls != PP_HTONS(DNS_RRCLASS_IN)) ||
-            (LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype) && (qry.type != PP_HTONS(DNS_RRTYPE_AAAA))) ||
-            (!LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype) && (qry.type != PP_HTONS(DNS_RRTYPE_A)))) {
+          (LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype) && (qry.type != PP_HTONS(DNS_RRTYPE_AAAA))) ||
+          (!LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype) && (qry.type != PP_HTONS(DNS_RRTYPE_A)))) {
          LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": response not match to query\n", entry->name));
-          goto ignore_packet; /* ignore this packet */
+          goto memerr; /* ignore this packet */
        }
        /* skip the rest of the "question" part */
-        if (res_idx + SIZEOF_DNS_QUERY > 0xFFFF) {
-          goto ignore_packet;
-        }
-        res_idx = (u16_t)(res_idx + SIZEOF_DNS_QUERY);
+        res_idx += SIZEOF_DNS_QUERY;

        /* Check for error. If so, call callback to inform. */
        if (hdr.flags2 & DNS_FLAG2_ERR_MASK) {
          LWIP_DEBUGF(DNS_DEBUG, ("dns_recv: \"%s\": error in flags\n", entry->name));
-
-          /* if there is another backup DNS server to try
-           * then don't stop the DNS request
-           */
-          if (dns_backupserver_available(entry)) {
-            /* avoid retrying the same server */
-            entry->retries = DNS_MAX_RETRIES-1;
-            entry->tmr     = 1;
-
-            /* contact next available server for this entry */
-            dns_check_entry(i);
-
-            goto ignore_packet;
-          }
        } else {
          while ((nanswers > 0) && (res_idx < p->tot_len)) {
            /* skip answer resource record's host name */
            res_idx = dns_skip_name(p, res_idx);
            if (res_idx == 0xFFFF) {
-              goto ignore_packet; /* ignore this packet */
+              goto memerr; /* ignore this packet */
            }

            /* Check for IP address type and Internet class. Others are discarded. */
            if (pbuf_copy_partial(p, &ans, SIZEOF_DNS_ANSWER, res_idx) != SIZEOF_DNS_ANSWER) {
-              goto ignore_packet; /* ignore this packet */
+              goto memerr; /* ignore this packet */
            }
-            if (res_idx + SIZEOF_DNS_ANSWER > 0xFFFF) {
-              goto ignore_packet;
-            }
-            res_idx = (u16_t)(res_idx + SIZEOF_DNS_ANSWER);
+            res_idx += SIZEOF_DNS_ANSWER;

            if (ans.cls == PP_HTONS(DNS_RRCLASS_IN)) {
 #if LWIP_IPV4
@@ -1291,7 +1234,7 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
                  ip4_addr_t ip4addr;
                  /* read the IP address after answer resource record's header */
                  if (pbuf_copy_partial(p, &ip4addr, sizeof(ip4_addr_t), res_idx) != sizeof(ip4_addr_t)) {
-                    goto ignore_packet; /* ignore this packet */
+                    goto memerr; /* ignore this packet */
                  }
                  ip_addr_copy_from_ip4(dns_table[i].ipaddr, ip4addr);
                  pbuf_free(p);
@@ -1302,18 +1245,17 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
              }
 #endif /* LWIP_IPV4 */
 #if LWIP_IPV6
-              if ((ans.type == PP_HTONS(DNS_RRTYPE_AAAA)) && (ans.len == PP_HTONS(sizeof(ip6_addr_p_t)))) {
+              if ((ans.type == PP_HTONS(DNS_RRTYPE_AAAA)) && (ans.len == PP_HTONS(sizeof(ip6_addr_t)))) {
 #if LWIP_IPV4 && LWIP_IPV6
                if (LWIP_DNS_ADDRTYPE_IS_IPV6(entry->reqaddrtype))
 #endif /* LWIP_IPV4 && LWIP_IPV6 */
                {
-                  ip6_addr_p_t ip6addr;
+                  ip6_addr_t ip6addr;
                  /* read the IP address after answer resource record's header */
-                  if (pbuf_copy_partial(p, &ip6addr, sizeof(ip6_addr_p_t), res_idx) != sizeof(ip6_addr_p_t)) {
-                    goto ignore_packet; /* ignore this packet */
+                  if (pbuf_copy_partial(p, &ip6addr, sizeof(ip6_addr_t), res_idx) != sizeof(ip6_addr_t)) {
+                    goto memerr; /* ignore this packet */
                  }
-                  /* @todo: scope ip6addr? Might be required for link-local addresses at least? */
-                  ip_addr_copy_from_ip6_packed(dns_table[i].ipaddr, ip6addr);
+                  ip_addr_copy_from_ip6(dns_table[i].ipaddr, ip6addr);
                  pbuf_free(p);
                  /* handle correct response */
                  dns_correct_response(i, lwip_ntohl(ans.ttl));
@@ -1324,9 +1266,9 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
            }
            /* skip this answer */
            if ((int)(res_idx + lwip_htons(ans.len)) > 0xFFFF) {
-              goto ignore_packet; /* ignore this packet */
+              goto memerr; /* ignore this packet */
            }
-            res_idx = (u16_t)(res_idx + lwip_htons(ans.len));
+            res_idx += lwip_htons(ans.len);
            --nanswers;
          }
 #if LWIP_IPV4 && LWIP_IPV6
@@ -1356,7 +1298,7 @@ dns_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr,
    }
  }

-ignore_packet:
+memerr:
  /* deallocate memory and return */
  pbuf_free(p);
  return;
@@ -1379,7 +1321,7 @@ dns_enqueue(const char *name, size_t hostnamelen, dns_found_callback found,
  u8_t lseq, lseqi;
  struct dns_table_entry *entry = NULL;
  size_t namelen;
-  struct dns_req_entry *req;
+  struct dns_req_entry* req;

 #if ((LWIP_DNS_SECURE & LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING) != 0)
  u8_t r;
@@ -1422,7 +1364,7 @@ dns_enqueue(const char *name, size_t hostnamelen, dns_found_callback found,
    }
    /* check if this is the oldest completed entry */
    if (entry->state == DNS_STATE_DONE) {
-      u8_t age = (u8_t)(dns_seqno - entry->seqno);
+      u8_t age = dns_seqno - entry->seqno;
      if (age > lseq) {
        lseq = age;
        lseqi = i;
@@ -1473,7 +1415,7 @@ dns_enqueue(const char *name, size_t hostnamelen, dns_found_callback found,
  LWIP_DNS_SET_ADDRTYPE(req->reqaddrtype, dns_addrtype);
  req->found = found;
  req->arg   = callback_arg;
-  namelen = LWIP_MIN(hostnamelen, DNS_MAX_NAME_LENGTH - 1);
+  namelen = LWIP_MIN(hostnamelen, DNS_MAX_NAME_LENGTH-1);
  MEMCPY(entry->name, name, namelen);
  entry->name[namelen] = 0;

@@ -1625,7 +1567,7 @@ dns_gethostbyname_addrtype(const char *hostname, ip_addr_t *addr, dns_found_call

  /* queue query with specified callback */
  return dns_enqueue(hostname, hostnamelen, found, callback_arg LWIP_DNS_ADDRTYPE_ARG(dns_addrtype)
-                     LWIP_DNS_ISMDNS_ARG(is_mdns));
+     LWIP_DNS_ISMDNS_ARG(is_mdns));
 }

 #endif /* LWIP_DNS */
--- a/src/core/inet_chksum.c
+++ b/src/core/inet_chksum.c
@@ -1,6 +1,6 @@
 /**
 * @file
- * Internet checksum functions.\n
+ * Incluse internet checksum functions.\n
 *
 * These are some reference implementations of the checksum algorithm, with the
 * aim of being simple, correct and fully portable. Checksumming is the
@@ -8,7 +8,7 @@
 * your own version, link it in and in your cc.h put:
 *
 * \#define LWIP_CHKSUM your_checksum_routine
- *
+ * 
 * Or you can select from the implementations below by defining
 * LWIP_CHKSUM_ALGORITHM to 1, 2 or 3.
 */
@@ -85,7 +85,7 @@ lwip_standard_chksum(const void *dataptr, int len)

  acc = 0;
  /* dataptr may be at odd or even addresses */
-  octetptr = (const u8_t *)dataptr;
+  octetptr = (const u8_t*)dataptr;
  while (len > 1) {
    /* declare first octet as most significant
       thus assume network order, ignoring host order */
@@ -201,14 +201,14 @@ lwip_standard_chksum(const void *dataptr, int len)
    len--;
  }

-  ps = (const u16_t *)(const void *)pb;
+  ps = (const u16_t *)(const void*)pb;

  if (((mem_ptr_t)ps & 3) && len > 1) {
    sum += *ps++;
    len -= 2;
  }

-  pl = (const u32_t *)(const void *)ps;
+  pl = (const u32_t *)(const void*)ps;

  while (len > 7)  {
    tmp = sum + *pl++;          /* ping */
@@ -260,19 +260,19 @@ static u16_t
 inet_cksum_pseudo_base(struct pbuf *p, u8_t proto, u16_t proto_len, u32_t acc)
 {
  struct pbuf *q;
-  int swapped = 0;
+  u8_t swapped = 0;

  /* iterate through all pbuf in chain */
  for (q = p; q != NULL; q = q->next) {
    LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): checksumming pbuf %p (has next %p) \n",
-                             (void *)q, (void *)q->next));
+      (void *)q, (void *)q->next));
    acc += LWIP_CHKSUM(q->payload, q->len);
    /*LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): unwrapped lwip_chksum()=%"X32_F" \n", acc));*/
    /* just executing this next line is probably faster that the if statement needed
       to check whether we really need to execute it, and does no harm */
    acc = FOLD_U32T(acc);
    if (q->len % 2 != 0) {
-      swapped = !swapped;
+      swapped = 1 - swapped;
      acc = SWAP_BYTES_IN_WORD(acc);
    }
    /*LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): wrapped lwip_chksum()=%"X32_F" \n", acc));*/
@@ -308,17 +308,17 @@ inet_cksum_pseudo_base(struct pbuf *p, u8_t proto, u16_t proto_len, u32_t acc)
 */
 u16_t
 inet_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
-                   const ip4_addr_t *src, const ip4_addr_t *dest)
+       const ip4_addr_t *src, const ip4_addr_t *dest)
 {
  u32_t acc;
  u32_t addr;

  addr = ip4_addr_get_u32(src);
  acc = (addr & 0xffffUL);
-  acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+  acc += ((addr >> 16) & 0xffffUL);
  addr = ip4_addr_get_u32(dest);
-  acc = (u32_t)(acc + (addr & 0xffffUL));
-  acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+  acc += (addr & 0xffffUL);
+  acc += ((addr >> 16) & 0xffffUL);
  /* fold down to 16 bits */
  acc = FOLD_U32T(acc);
  acc = FOLD_U32T(acc);
@@ -341,7 +341,7 @@ inet_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
 */
 u16_t
 ip6_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
-                  const ip6_addr_t *src, const ip6_addr_t *dest)
+       const ip6_addr_t *src, const ip6_addr_t *dest)
 {
  u32_t acc = 0;
  u32_t addr;
@@ -349,11 +349,11 @@ ip6_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,

  for (addr_part = 0; addr_part < 4; addr_part++) {
    addr = src->addr[addr_part];
-    acc = (u32_t)(acc + (addr & 0xffffUL));
-    acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+    acc += (addr & 0xffffUL);
+    acc += ((addr >> 16) & 0xffffUL);
    addr = dest->addr[addr_part];
-    acc = (u32_t)(acc + (addr & 0xffffUL));
-    acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+    acc += (addr & 0xffffUL);
+    acc += ((addr >> 16) & 0xffffUL);
  }
  /* fold down to 16 bits */
  acc = FOLD_U32T(acc);
@@ -377,7 +377,7 @@ ip6_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
 */
 u16_t
 ip_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
-                 const ip_addr_t *src, const ip_addr_t *dest)
+       const ip_addr_t *src, const ip_addr_t *dest)
 {
 #if LWIP_IPV6
  if (IP_IS_V6(dest)) {
@@ -397,28 +397,28 @@ ip_chksum_pseudo(struct pbuf *p, u8_t proto, u16_t proto_len,
 /** Parts of the pseudo checksum which are common to IPv4 and IPv6 */
 static u16_t
 inet_cksum_pseudo_partial_base(struct pbuf *p, u8_t proto, u16_t proto_len,
-                               u16_t chksum_len, u32_t acc)
+       u16_t chksum_len, u32_t acc)
 {
  struct pbuf *q;
-  int swapped = 0;
+  u8_t swapped = 0;
  u16_t chklen;

  /* iterate through all pbuf in chain */
  for (q = p; (q != NULL) && (chksum_len > 0); q = q->next) {
    LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): checksumming pbuf %p (has next %p) \n",
-                             (void *)q, (void *)q->next));
+      (void *)q, (void *)q->next));
    chklen = q->len;
    if (chklen > chksum_len) {
      chklen = chksum_len;
    }
    acc += LWIP_CHKSUM(q->payload, chklen);
-    chksum_len = (u16_t)(chksum_len - chklen);
+    chksum_len -= chklen;
    LWIP_ASSERT("delete me", chksum_len < 0x7fff);
    /*LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): unwrapped lwip_chksum()=%"X32_F" \n", acc));*/
    /* fold the upper bit down */
    acc = FOLD_U32T(acc);
    if (q->len % 2 != 0) {
-      swapped = !swapped;
+      swapped = 1 - swapped;
      acc = SWAP_BYTES_IN_WORD(acc);
    }
    /*LWIP_DEBUGF(INET_DEBUG, ("inet_chksum_pseudo(): wrapped lwip_chksum()=%"X32_F" \n", acc));*/
@@ -454,17 +454,17 @@ inet_cksum_pseudo_partial_base(struct pbuf *p, u8_t proto, u16_t proto_len,
 */
 u16_t
 inet_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,
-                           u16_t chksum_len, const ip4_addr_t *src, const ip4_addr_t *dest)
+       u16_t chksum_len, const ip4_addr_t *src, const ip4_addr_t *dest)
 {
  u32_t acc;
  u32_t addr;

  addr = ip4_addr_get_u32(src);
  acc = (addr & 0xffffUL);
-  acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+  acc += ((addr >> 16) & 0xffffUL);
  addr = ip4_addr_get_u32(dest);
-  acc = (u32_t)(acc + (addr & 0xffffUL));
-  acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+  acc += (addr & 0xffffUL);
+  acc += ((addr >> 16) & 0xffffUL);
  /* fold down to 16 bits */
  acc = FOLD_U32T(acc);
  acc = FOLD_U32T(acc);
@@ -489,7 +489,7 @@ inet_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,
 */
 u16_t
 ip6_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,
-                          u16_t chksum_len, const ip6_addr_t *src, const ip6_addr_t *dest)
+       u16_t chksum_len, const ip6_addr_t *src, const ip6_addr_t *dest)
 {
  u32_t acc = 0;
  u32_t addr;
@@ -497,11 +497,11 @@ ip6_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,

  for (addr_part = 0; addr_part < 4; addr_part++) {
    addr = src->addr[addr_part];
-    acc = (u32_t)(acc + (addr & 0xffffUL));
-    acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+    acc += (addr & 0xffffUL);
+    acc += ((addr >> 16) & 0xffffUL);
    addr = dest->addr[addr_part];
-    acc = (u32_t)(acc + (addr & 0xffffUL));
-    acc = (u32_t)(acc + ((addr >> 16) & 0xffffUL));
+    acc += (addr & 0xffffUL);
+    acc += ((addr >> 16) & 0xffffUL);
  }
  /* fold down to 16 bits */
  acc = FOLD_U32T(acc);
@@ -524,7 +524,7 @@ ip6_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,
 */
 u16_t
 ip_chksum_pseudo_partial(struct pbuf *p, u8_t proto, u16_t proto_len,
-                         u16_t chksum_len, const ip_addr_t *src, const ip_addr_t *dest)
+       u16_t chksum_len, const ip_addr_t *src, const ip_addr_t *dest)
 {
 #if LWIP_IPV6
  if (IP_IS_V6(dest)) {
@@ -569,14 +569,15 @@ inet_chksum_pbuf(struct pbuf *p)
 {
  u32_t acc;
  struct pbuf *q;
-  int swapped = 0;
+  u8_t swapped;

  acc = 0;
+  swapped = 0;
  for (q = p; q != NULL; q = q->next) {
    acc += LWIP_CHKSUM(q->payload, q->len);
    acc = FOLD_U32T(acc);
    if (q->len % 2 != 0) {
-      swapped = !swapped;
+      swapped = 1 - swapped;
      acc = SWAP_BYTES_IN_WORD(acc);
    }
  }
--- a/src/core/init.c
+++ b/src/core/init.c
@@ -67,7 +67,8 @@
 #  include "arch/bpstruct.h"
 #endif
 PACK_STRUCT_BEGIN
-struct packed_struct_test {
+struct packed_struct_test
+{
  PACK_STRUCT_FLD_8(u8_t  dummy1);
  PACK_STRUCT_FIELD(u32_t dummy2);
 } PACK_STRUCT_STRUCT;
@@ -83,183 +84,187 @@ PACK_STRUCT_END
 * These can be done independently of LWIP_DEBUG, without penalty.
 */
 #ifndef BYTE_ORDER
-#error "BYTE_ORDER is not defined, you have to define it in your cc.h"
+  #error "BYTE_ORDER is not defined, you have to define it in your cc.h"
 #endif
 #if (!IP_SOF_BROADCAST && IP_SOF_BROADCAST_RECV)
-#error "If you want to use broadcast filter per pcb on recv operations, you have to define IP_SOF_BROADCAST=1 in your lwipopts.h"
+  #error "If you want to use broadcast filter per pcb on recv operations, you have to define IP_SOF_BROADCAST=1 in your lwipopts.h"
 #endif
 #if (!LWIP_UDP && LWIP_UDPLITE)
-#error "If you want to use UDP Lite, you have to define LWIP_UDP=1 in your lwipopts.h"
+  #error "If you want to use UDP Lite, you have to define LWIP_UDP=1 in your lwipopts.h"
 #endif
 #if (!LWIP_UDP && LWIP_DHCP)
-#error "If you want to use DHCP, you have to define LWIP_UDP=1 in your lwipopts.h"
+  #error "If you want to use DHCP, you have to define LWIP_UDP=1 in your lwipopts.h"
 #endif
-#if (!LWIP_UDP && !LWIP_RAW && LWIP_MULTICAST_TX_OPTIONS)
-#error "If you want to use LWIP_MULTICAST_TX_OPTIONS, you have to define LWIP_UDP=1 and/or LWIP_RAW=1 in your lwipopts.h"
+#if (!LWIP_UDP && LWIP_MULTICAST_TX_OPTIONS)
+  #error "If you want to use IGMP/LWIP_MULTICAST_TX_OPTIONS, you have to define LWIP_UDP=1 in your lwipopts.h"
 #endif
 #if (!LWIP_UDP && LWIP_DNS)
-#error "If you want to use DNS, you have to define LWIP_UDP=1 in your lwipopts.h"
+  #error "If you want to use DNS, you have to define LWIP_UDP=1 in your lwipopts.h"
 #endif
 #if !MEMP_MEM_MALLOC /* MEMP_NUM_* checks are disabled when not using the pool allocator */
 #if (LWIP_ARP && ARP_QUEUEING && (MEMP_NUM_ARP_QUEUE<=0))
-#error "If you want to use ARP Queueing, you have to define MEMP_NUM_ARP_QUEUE>=1 in your lwipopts.h"
+  #error "If you want to use ARP Queueing, you have to define MEMP_NUM_ARP_QUEUE>=1 in your lwipopts.h"
 #endif
 #if (LWIP_RAW && (MEMP_NUM_RAW_PCB<=0))
-#error "If you want to use RAW, you have to define MEMP_NUM_RAW_PCB>=1 in your lwipopts.h"
+  #error "If you want to use RAW, you have to define MEMP_NUM_RAW_PCB>=1 in your lwipopts.h"
 #endif
 #if (LWIP_UDP && (MEMP_NUM_UDP_PCB<=0))
-#error "If you want to use UDP, you have to define MEMP_NUM_UDP_PCB>=1 in your lwipopts.h"
+  #error "If you want to use UDP, you have to define MEMP_NUM_UDP_PCB>=1 in your lwipopts.h"
 #endif
 #if (LWIP_TCP && (MEMP_NUM_TCP_PCB<=0))
-#error "If you want to use TCP, you have to define MEMP_NUM_TCP_PCB>=1 in your lwipopts.h"
+  #error "If you want to use TCP, you have to define MEMP_NUM_TCP_PCB>=1 in your lwipopts.h"
 #endif
 #if (LWIP_IGMP && (MEMP_NUM_IGMP_GROUP<=1))
-#error "If you want to use IGMP, you have to define MEMP_NUM_IGMP_GROUP>1 in your lwipopts.h"
+  #error "If you want to use IGMP, you have to define MEMP_NUM_IGMP_GROUP>1 in your lwipopts.h"
 #endif
 #if (LWIP_IGMP && !LWIP_MULTICAST_TX_OPTIONS)
-#error "If you want to use IGMP, you have to define LWIP_MULTICAST_TX_OPTIONS==1 in your lwipopts.h"
+  #error "If you want to use IGMP, you have to define LWIP_MULTICAST_TX_OPTIONS==1 in your lwipopts.h"
 #endif
 #if (LWIP_IGMP && !LWIP_IPV4)
-#error "IGMP needs LWIP_IPV4 enabled in your lwipopts.h"
+  #error "IGMP needs LWIP_IPV4 enabled in your lwipopts.h"
+#endif
+#if (LWIP_MULTICAST_TX_OPTIONS && !LWIP_IPV4)
+  #error "LWIP_MULTICAST_TX_OPTIONS needs LWIP_IPV4 enabled in your lwipopts.h"
 #endif
 #if ((LWIP_NETCONN || LWIP_SOCKET) && (MEMP_NUM_TCPIP_MSG_API<=0))
-#error "If you want to use Sequential API, you have to define MEMP_NUM_TCPIP_MSG_API>=1 in your lwipopts.h"
+  #error "If you want to use Sequential API, you have to define MEMP_NUM_TCPIP_MSG_API>=1 in your lwipopts.h"
 #endif
 /* There must be sufficient timeouts, taking into account requirements of the subsystems. */
-#if LWIP_TIMERS && (MEMP_NUM_SYS_TIMEOUT < LWIP_NUM_SYS_TIMEOUT_INTERNAL)
-#error "MEMP_NUM_SYS_TIMEOUT is too low to accomodate all required timeouts"
+#if LWIP_TIMERS && (MEMP_NUM_SYS_TIMEOUT < (LWIP_TCP + IP_REASSEMBLY + LWIP_ARP + (2*LWIP_DHCP) + LWIP_AUTOIP + LWIP_IGMP + LWIP_DNS + PPP_SUPPORT + (LWIP_IPV6 ? (1 + LWIP_IPV6_REASS + LWIP_IPV6_MLD) : 0)))
+  #error "MEMP_NUM_SYS_TIMEOUT is too low to accomodate all required timeouts"
 #endif
 #if (IP_REASSEMBLY && (MEMP_NUM_REASSDATA > IP_REASS_MAX_PBUFS))
-#error "MEMP_NUM_REASSDATA > IP_REASS_MAX_PBUFS doesn't make sense since each struct ip_reassdata must hold 2 pbufs at least!"
+  #error "MEMP_NUM_REASSDATA > IP_REASS_MAX_PBUFS doesn't make sense since each struct ip_reassdata must hold 2 pbufs at least!"
 #endif
 #endif /* !MEMP_MEM_MALLOC */
 #if LWIP_WND_SCALE
 #if (LWIP_TCP && (TCP_WND > 0xffffffff))
-#error "If you want to use TCP, TCP_WND must fit in an u32_t, so, you have to reduce it in your lwipopts.h"
+  #error "If you want to use TCP, TCP_WND must fit in an u32_t, so, you have to reduce it in your lwipopts.h"
 #endif
 #if (LWIP_TCP && (TCP_RCV_SCALE > 14))
-#error "The maximum valid window scale value is 14!"
+  #error "The maximum valid window scale value is 14!"
 #endif
 #if (LWIP_TCP && (TCP_WND > (0xFFFFU << TCP_RCV_SCALE)))
-#error "TCP_WND is bigger than the configured LWIP_WND_SCALE allows!"
+  #error "TCP_WND is bigger than the configured LWIP_WND_SCALE allows!"
 #endif
 #if (LWIP_TCP && ((TCP_WND >> TCP_RCV_SCALE) == 0))
-#error "TCP_WND is too small for the configured LWIP_WND_SCALE (results in zero window)!"
+  #error "TCP_WND is too small for the configured LWIP_WND_SCALE (results in zero window)!"
 #endif
 #else /* LWIP_WND_SCALE */
 #if (LWIP_TCP && (TCP_WND > 0xffff))
-#error "If you want to use TCP, TCP_WND must fit in an u16_t, so, you have to reduce it in your lwipopts.h (or enable window scaling)"
+  #error "If you want to use TCP, TCP_WND must fit in an u16_t, so, you have to reduce it in your lwipopts.h (or enable window scaling)"
 #endif
 #endif /* LWIP_WND_SCALE */
 #if (LWIP_TCP && (TCP_SND_QUEUELEN > 0xffff))
-#error "If you want to use TCP, TCP_SND_QUEUELEN must fit in an u16_t, so, you have to reduce it in your lwipopts.h"
+  #error "If you want to use TCP, TCP_SND_QUEUELEN must fit in an u16_t, so, you have to reduce it in your lwipopts.h"
 #endif
 #if (LWIP_TCP && (TCP_SND_QUEUELEN < 2))
-#error "TCP_SND_QUEUELEN must be at least 2 for no-copy TCP writes to work"
+  #error "TCP_SND_QUEUELEN must be at least 2 for no-copy TCP writes to work"
 #endif
 #if (LWIP_TCP && ((TCP_MAXRTX > 12) || (TCP_SYNMAXRTX > 12)))
-#error "If you want to use TCP, TCP_MAXRTX and TCP_SYNMAXRTX must less or equal to 12 (due to tcp_backoff table), so, you have to reduce them in your lwipopts.h"
+  #error "If you want to use TCP, TCP_MAXRTX and TCP_SYNMAXRTX must less or equal to 12 (due to tcp_backoff table), so, you have to reduce them in your lwipopts.h"
 #endif
 #if (LWIP_TCP && TCP_LISTEN_BACKLOG && ((TCP_DEFAULT_LISTEN_BACKLOG < 0) || (TCP_DEFAULT_LISTEN_BACKLOG > 0xff)))
-#error "If you want to use TCP backlog, TCP_DEFAULT_LISTEN_BACKLOG must fit into an u8_t"
-#endif
-#if (LWIP_TCP && LWIP_TCP_SACK_OUT && !TCP_QUEUE_OOSEQ)
-#error "To use LWIP_TCP_SACK_OUT, TCP_QUEUE_OOSEQ needs to be enabled"
-#endif
-#if (LWIP_TCP && LWIP_TCP_SACK_OUT && (LWIP_TCP_MAX_SACK_NUM < 1))
-#error "LWIP_TCP_MAX_SACK_NUM must be greater than 0"
+  #error "If you want to use TCP backlog, TCP_DEFAULT_LISTEN_BACKLOG must fit into an u8_t"
 #endif
 #if (LWIP_NETIF_API && (NO_SYS==1))
-#error "If you want to use NETIF API, you have to define NO_SYS=0 in your lwipopts.h"
+  #error "If you want to use NETIF API, you have to define NO_SYS=0 in your lwipopts.h"
 #endif
 #if ((LWIP_SOCKET || LWIP_NETCONN) && (NO_SYS==1))
-#error "If you want to use Sequential API, you have to define NO_SYS=0 in your lwipopts.h"
+  #error "If you want to use Sequential API, you have to define NO_SYS=0 in your lwipopts.h"
 #endif
 #if (LWIP_PPP_API && (NO_SYS==1))
-#error "If you want to use PPP API, you have to define NO_SYS=0 in your lwipopts.h"
+  #error "If you want to use PPP API, you have to define NO_SYS=0 in your lwipopts.h"
 #endif
 #if (LWIP_PPP_API && (PPP_SUPPORT==0))
-#error "If you want to use PPP API, you have to enable PPP_SUPPORT in your lwipopts.h"
+  #error "If you want to use PPP API, you have to enable PPP_SUPPORT in your lwipopts.h"
 #endif
 #if (((!LWIP_DHCP) || (!LWIP_AUTOIP)) && LWIP_DHCP_AUTOIP_COOP)
-#error "If you want to use DHCP/AUTOIP cooperation mode, you have to define LWIP_DHCP=1 and LWIP_AUTOIP=1 in your lwipopts.h"
+  #error "If you want to use DHCP/AUTOIP cooperation mode, you have to define LWIP_DHCP=1 and LWIP_AUTOIP=1 in your lwipopts.h"
 #endif
 #if (((!LWIP_DHCP) || (!LWIP_ARP)) && DHCP_DOES_ARP_CHECK)
-#error "If you want to use DHCP ARP checking, you have to define LWIP_DHCP=1 and LWIP_ARP=1 in your lwipopts.h"
+  #error "If you want to use DHCP ARP checking, you have to define LWIP_DHCP=1 and LWIP_ARP=1 in your lwipopts.h"
 #endif
 #if (!LWIP_ARP && LWIP_AUTOIP)
-#error "If you want to use AUTOIP, you have to define LWIP_ARP=1 in your lwipopts.h"
+  #error "If you want to use AUTOIP, you have to define LWIP_ARP=1 in your lwipopts.h"
 #endif
 #if (LWIP_TCP && ((LWIP_EVENT_API && LWIP_CALLBACK_API) || (!LWIP_EVENT_API && !LWIP_CALLBACK_API)))
-#error "One and exactly one of LWIP_EVENT_API and LWIP_CALLBACK_API has to be enabled in your lwipopts.h"
-#endif
-#if (LWIP_ALTCP && LWIP_EVENT_API)
-#error "The application layered tcp API does not work with LWIP_EVENT_API"
+  #error "One and exactly one of LWIP_EVENT_API and LWIP_CALLBACK_API has to be enabled in your lwipopts.h"
 #endif
 #if (MEM_LIBC_MALLOC && MEM_USE_POOLS)
-#error "MEM_LIBC_MALLOC and MEM_USE_POOLS may not both be simultaneously enabled in your lwipopts.h"
+  #error "MEM_LIBC_MALLOC and MEM_USE_POOLS may not both be simultaneously enabled in your lwipopts.h"
 #endif
 #if (MEM_USE_POOLS && !MEMP_USE_CUSTOM_POOLS)
-#error "MEM_USE_POOLS requires custom pools (MEMP_USE_CUSTOM_POOLS) to be enabled in your lwipopts.h"
+  #error "MEM_USE_POOLS requires custom pools (MEMP_USE_CUSTOM_POOLS) to be enabled in your lwipopts.h"
 #endif
 #if (PBUF_POOL_BUFSIZE <= MEM_ALIGNMENT)
-#error "PBUF_POOL_BUFSIZE must be greater than MEM_ALIGNMENT or the offset may take the full first pbuf"
+  #error "PBUF_POOL_BUFSIZE must be greater than MEM_ALIGNMENT or the offset may take the full first pbuf"
 #endif
 #if (DNS_LOCAL_HOSTLIST && !DNS_LOCAL_HOSTLIST_IS_DYNAMIC && !(defined(DNS_LOCAL_HOSTLIST_INIT)))
-#error "you have to define define DNS_LOCAL_HOSTLIST_INIT {{'host1', 0x123}, {'host2', 0x234}} to initialize DNS_LOCAL_HOSTLIST"
+  #error "you have to define define DNS_LOCAL_HOSTLIST_INIT {{'host1', 0x123}, {'host2', 0x234}} to initialize DNS_LOCAL_HOSTLIST"
 #endif
 #if PPP_SUPPORT && !PPPOS_SUPPORT && !PPPOE_SUPPORT && !PPPOL2TP_SUPPORT
-#error "PPP_SUPPORT needs at least one of PPPOS_SUPPORT, PPPOE_SUPPORT or PPPOL2TP_SUPPORT turned on"
+  #error "PPP_SUPPORT needs at least one of PPPOS_SUPPORT, PPPOE_SUPPORT or PPPOL2TP_SUPPORT turned on"
 #endif
 #if PPP_SUPPORT && !PPP_IPV4_SUPPORT && !PPP_IPV6_SUPPORT
-#error "PPP_SUPPORT needs PPP_IPV4_SUPPORT and/or PPP_IPV6_SUPPORT turned on"
+  #error "PPP_SUPPORT needs PPP_IPV4_SUPPORT and/or PPP_IPV6_SUPPORT turned on"
 #endif
 #if PPP_SUPPORT && PPP_IPV4_SUPPORT && !LWIP_IPV4
-#error "PPP_IPV4_SUPPORT needs LWIP_IPV4 turned on"
+  #error "PPP_IPV4_SUPPORT needs LWIP_IPV4 turned on"
 #endif
 #if PPP_SUPPORT && PPP_IPV6_SUPPORT && !LWIP_IPV6
-#error "PPP_IPV6_SUPPORT needs LWIP_IPV6 turned on"
+  #error "PPP_IPV6_SUPPORT needs LWIP_IPV6 turned on"
 #endif
 #if !LWIP_ETHERNET && (LWIP_ARP || PPPOE_SUPPORT)
-#error "LWIP_ETHERNET needs to be turned on for LWIP_ARP or PPPOE_SUPPORT"
+  #error "LWIP_ETHERNET needs to be turned on for LWIP_ARP or PPPOE_SUPPORT"
 #endif
 #if LWIP_TCPIP_CORE_LOCKING_INPUT && !LWIP_TCPIP_CORE_LOCKING
-#error "When using LWIP_TCPIP_CORE_LOCKING_INPUT, LWIP_TCPIP_CORE_LOCKING must be enabled, too"
+  #error "When using LWIP_TCPIP_CORE_LOCKING_INPUT, LWIP_TCPIP_CORE_LOCKING must be enabled, too"
 #endif
 #if LWIP_TCP && LWIP_NETIF_TX_SINGLE_PBUF && !TCP_OVERSIZE
-#error "LWIP_NETIF_TX_SINGLE_PBUF needs TCP_OVERSIZE enabled to create single-pbuf TCP packets"
+  #error "LWIP_NETIF_TX_SINGLE_PBUF needs TCP_OVERSIZE enabled to create single-pbuf TCP packets"
 #endif
 #if LWIP_NETCONN && LWIP_TCP
 #if NETCONN_COPY != TCP_WRITE_FLAG_COPY
-#error "NETCONN_COPY != TCP_WRITE_FLAG_COPY"
+  #error "NETCONN_COPY != TCP_WRITE_FLAG_COPY"
 #endif
 #if NETCONN_MORE != TCP_WRITE_FLAG_MORE
-#error "NETCONN_MORE != TCP_WRITE_FLAG_MORE"
+  #error "NETCONN_MORE != TCP_WRITE_FLAG_MORE"
 #endif
 #endif /* LWIP_NETCONN && LWIP_TCP */
 #if LWIP_SOCKET
+/* Check that the SO_* socket options and SOF_* lwIP-internal flags match */
+#if SO_REUSEADDR != SOF_REUSEADDR
+  #error "WARNING: SO_REUSEADDR != SOF_REUSEADDR"
+#endif
+#if SO_KEEPALIVE != SOF_KEEPALIVE
+  #error "WARNING: SO_KEEPALIVE != SOF_KEEPALIVE"
+#endif
+#if SO_BROADCAST != SOF_BROADCAST
+  #error "WARNING: SO_BROADCAST != SOF_BROADCAST"
+#endif
 #endif /* LWIP_SOCKET */


 /* Compile-time checks for deprecated options.
 */
 #ifdef MEMP_NUM_TCPIP_MSG
-#error "MEMP_NUM_TCPIP_MSG option is deprecated. Remove it from your lwipopts.h."
+  #error "MEMP_NUM_TCPIP_MSG option is deprecated. Remove it from your lwipopts.h."
 #endif
 #ifdef TCP_REXMIT_DEBUG
-#error "TCP_REXMIT_DEBUG option is deprecated. Remove it from your lwipopts.h."
+  #error "TCP_REXMIT_DEBUG option is deprecated. Remove it from your lwipopts.h."
 #endif
 #ifdef RAW_STATS
-#error "RAW_STATS option is deprecated. Remove it from your lwipopts.h."
+  #error "RAW_STATS option is deprecated. Remove it from your lwipopts.h."
 #endif
 #ifdef ETHARP_QUEUE_FIRST
-#error "ETHARP_QUEUE_FIRST option is deprecated. Remove it from your lwipopts.h."
+  #error "ETHARP_QUEUE_FIRST option is deprecated. Remove it from your lwipopts.h."
 #endif
 #ifdef ETHARP_ALWAYS_INSERT
-#error "ETHARP_ALWAYS_INSERT option is deprecated. Remove it from your lwipopts.h."
+  #error "ETHARP_ALWAYS_INSERT option is deprecated. Remove it from your lwipopts.h."
 #endif
 #if !NO_SYS && LWIP_TCPIP_CORE_LOCKING && LWIP_COMPAT_MUTEX && !defined(LWIP_COMPAT_MUTEX_ALLOWED)
-#error "LWIP_COMPAT_MUTEX cannot prevent priority inversion. It is recommended to implement priority-aware mutexes. (Define LWIP_COMPAT_MUTEX_ALLOWED to disable this error.)"
+  #error "LWIP_COMPAT_MUTEX cannot prevent priority inversion. It is recommended to implement priority-aware mutexes. (Define LWIP_COMPAT_MUTEX_ALLOWED to disable this error.)"
 #endif

 #ifndef LWIP_DISABLE_TCP_SANITY_CHECKS
@@ -294,31 +299,31 @@ PACK_STRUCT_END
 #if !LWIP_DISABLE_TCP_SANITY_CHECKS
 #if LWIP_TCP
 #if !MEMP_MEM_MALLOC && (MEMP_NUM_TCP_SEG < TCP_SND_QUEUELEN)
-#error "lwip_sanity_check: WARNING: MEMP_NUM_TCP_SEG should be at least as big as TCP_SND_QUEUELEN. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: MEMP_NUM_TCP_SEG should be at least as big as TCP_SND_QUEUELEN. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if TCP_SND_BUF < (2 * TCP_MSS)
-#error "lwip_sanity_check: WARNING: TCP_SND_BUF must be at least as much as (2 * TCP_MSS) for things to work smoothly. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_SND_BUF must be at least as much as (2 * TCP_MSS) for things to work smoothly. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if TCP_SND_QUEUELEN < (2 * (TCP_SND_BUF / TCP_MSS))
-#error "lwip_sanity_check: WARNING: TCP_SND_QUEUELEN must be at least as much as (2 * TCP_SND_BUF/TCP_MSS) for things to work. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_SND_QUEUELEN must be at least as much as (2 * TCP_SND_BUF/TCP_MSS) for things to work. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if TCP_SNDLOWAT >= TCP_SND_BUF
-#error "lwip_sanity_check: WARNING: TCP_SNDLOWAT must be less than TCP_SND_BUF. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_SNDLOWAT must be less than TCP_SND_BUF. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if TCP_SNDLOWAT >= (0xFFFF - (4 * TCP_MSS))
-#error "lwip_sanity_check: WARNING: TCP_SNDLOWAT must at least be 4*MSS below u16_t overflow!"
+  #error "lwip_sanity_check: WARNING: TCP_SNDLOWAT must at least be 4*MSS below u16_t overflow!"
 #endif
 #if TCP_SNDQUEUELOWAT >= TCP_SND_QUEUELEN
-#error "lwip_sanity_check: WARNING: TCP_SNDQUEUELOWAT must be less than TCP_SND_QUEUELEN. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_SNDQUEUELOWAT must be less than TCP_SND_QUEUELEN. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if !MEMP_MEM_MALLOC && PBUF_POOL_SIZE && (PBUF_POOL_BUFSIZE <= (PBUF_LINK_ENCAPSULATION_HLEN + PBUF_LINK_HLEN + PBUF_IP_HLEN + PBUF_TRANSPORT_HLEN))
-#error "lwip_sanity_check: WARNING: PBUF_POOL_BUFSIZE does not provide enough space for protocol headers. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: PBUF_POOL_BUFSIZE does not provide enough space for protocol headers. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if !MEMP_MEM_MALLOC && PBUF_POOL_SIZE && (TCP_WND > (PBUF_POOL_SIZE * (PBUF_POOL_BUFSIZE - (PBUF_LINK_ENCAPSULATION_HLEN + PBUF_LINK_HLEN + PBUF_IP_HLEN + PBUF_TRANSPORT_HLEN))))
-#error "lwip_sanity_check: WARNING: TCP_WND is larger than space provided by PBUF_POOL_SIZE * (PBUF_POOL_BUFSIZE - protocol headers). If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_WND is larger than space provided by PBUF_POOL_SIZE * (PBUF_POOL_BUFSIZE - protocol headers). If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #if TCP_WND < TCP_MSS
-#error "lwip_sanity_check: WARNING: TCP_WND is smaller than MSS. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
+  #error "lwip_sanity_check: WARNING: TCP_WND is smaller than MSS. If you know what you are doing, define LWIP_DISABLE_TCP_SANITY_CHECKS to 1 to disable this error."
 #endif
 #endif /* LWIP_TCP */
 #endif /* !LWIP_DISABLE_TCP_SANITY_CHECKS */
@@ -332,9 +337,9 @@ void
 lwip_init(void)
 {
 #ifndef LWIP_SKIP_CONST_CHECK
-  int a = 0;
+  int a;
  LWIP_UNUSED_ARG(a);
-  LWIP_ASSERT("LWIP_CONST_CAST not implemented correctly. Check your lwIP port.", LWIP_CONST_CAST(void *, &a) == &a);
+  LWIP_ASSERT("LWIP_CONST_CAST not implemented correctly. Check your lwIP port.", LWIP_CONST_CAST(void*, &a) == &a);
 #endif
 #ifndef LWIP_SKIP_PACKING_CHECK
  LWIP_ASSERT("Struct packing not implemented correctly. Check your lwIP port.", sizeof(struct packed_struct_test) == PACKED_STRUCT_TEST_EXPECTED_SIZE);
@@ -373,7 +378,7 @@ lwip_init(void)
 #if PPP_SUPPORT
  ppp_init();
 #endif
-
+ 
 #if LWIP_TIMERS
  sys_timeouts_init();
 #endif /* LWIP_TIMERS */
--- a/src/core/ip.c
+++ b/src/core/ip.c
@@ -4,19 +4,19 @@
 *
 * @defgroup ip IP
 * @ingroup callbackstyle_api
- *
+ * 
 * @defgroup ip4 IPv4
 * @ingroup ip
 *
 * @defgroup ip6 IPv6
 * @ingroup ip
- *
+ * 
 * @defgroup ipaddr IP address handling
 * @ingroup infrastructure
- *
+ * 
 * @defgroup ip4addr IPv4 only
 * @ingroup ipaddr
- *
+ * 
 * @defgroup ip6addr IPv6 only
 * @ingroup ipaddr
 */
@@ -67,49 +67,6 @@ struct ip_globals ip_data;

 const ip_addr_t ip_addr_any_type = IPADDR_ANY_TYPE_INIT;

-/**
- * @ingroup ipaddr
- * Convert numeric IP address (both versions) into ASCII representation.
- * returns ptr to static buffer; not reentrant!
- *
- * @param addr ip address in network order to convert
- * @return pointer to a global static (!) buffer that holds the ASCII
- *         representation of addr
- */
-char *ipaddr_ntoa(const ip_addr_t *addr)
-{
-  if (addr == NULL) {
-    return NULL;
-  }
-  if (IP_IS_V6(addr)) {
-    return ip6addr_ntoa(ip_2_ip6(addr));
-  } else {
-    return ip4addr_ntoa(ip_2_ip4(addr));
-  }
-}
-
-/**
- * @ingroup ipaddr
- * Same as ipaddr_ntoa, but reentrant since a user-supplied buffer is used.
- *
- * @param addr ip address in network order to convert
- * @param buf target buffer where the string is stored
- * @param buflen length of buf
- * @return either pointer to buf which now holds the ASCII
- *         representation of addr or NULL if buf was too small
- */
-char *ipaddr_ntoa_r(const ip_addr_t *addr, char *buf, int buflen)
-{
-  if (addr == NULL) {
-    return NULL;
-  }
-  if (IP_IS_V6(addr)) {
-    return ip6addr_ntoa_r(ip_2_ip6(addr), buf, buflen);
-  } else {
-    return ip4addr_ntoa_r(ip_2_ip4(addr), buf, buflen);
-  }
-}
-
 /**
 * @ingroup ipaddr
 * Convert IP address string (both versions) to numeric.
@@ -123,7 +80,7 @@ int
 ipaddr_aton(const char *cp, ip_addr_t *addr)
 {
  if (cp != NULL) {
-    const char *c;
+    const char* c;
    for (c = cp; *c != 0; c++) {
      if (*c == ':') {
        /* contains a colon: IPv6 address */
--- a/src/core/ipv4/autoip.c
+++ b/src/core/ipv4/autoip.c
@@ -22,7 +22,7 @@
 * With DHCP:
 * - define @ref LWIP_DHCP_AUTOIP_COOP 1 in your lwipopts.h.
 * - Configure your DHCP Client.
- *
+ * 
 * @see netifapi_autoip
 */

@@ -95,7 +95,7 @@ static err_t autoip_arp_announce(struct netif *netif);
 static void autoip_start_probing(struct netif *netif);

 /**
- * @ingroup autoip
+ * @ingroup autoip 
 * Set a statically allocated struct autoip to work with.
 * Using this prevents autoip_start to allocate it using mem_malloc.
 *
@@ -105,7 +105,6 @@ static void autoip_start_probing(struct netif *netif);
 void
 autoip_set_struct(struct netif *netif, struct autoip *autoip)
 {
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("netif != NULL", netif != NULL);
  LWIP_ASSERT("autoip != NULL", autoip != NULL);
  LWIP_ASSERT("netif already has a struct autoip set",
@@ -124,7 +123,7 @@ autoip_set_struct(struct netif *netif, struct autoip *autoip)
 static void
 autoip_restart(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);
  autoip->tried_llipaddr++;
  autoip_start(netif);
 }
@@ -135,7 +134,7 @@ autoip_restart(struct netif *netif)
 static void
 autoip_handle_arp_conflict(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

  /* RFC3927, 2.5 "Conflict Detection and Defense" allows two options where
     a) means retreat on the first conflict and
@@ -147,13 +146,13 @@ autoip_handle_arp_conflict(struct netif *netif)
  if (autoip->lastconflict > 0) {
    /* retreat, there was a conflicting ARP in the last DEFEND_INTERVAL seconds */
    LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-                ("autoip_handle_arp_conflict(): we are defending, but in DEFEND_INTERVAL, retreating\n"));
+      ("autoip_handle_arp_conflict(): we are defending, but in DEFEND_INTERVAL, retreating\n"));

    /* Active TCP sessions are aborted when removing the ip addresss */
    autoip_restart(netif);
  } else {
    LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-                ("autoip_handle_arp_conflict(): we are defend, send ARP Announce\n"));
+      ("autoip_handle_arp_conflict(): we are defend, send ARP Announce\n"));
    autoip_arp_announce(netif);
    autoip->lastconflict = DEFEND_INTERVAL * AUTOIP_TICKS_PER_SECOND;
  }
@@ -168,7 +167,7 @@ autoip_handle_arp_conflict(struct netif *netif)
 static void
 autoip_create_addr(struct netif *netif, ip4_addr_t *ipaddr)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

  /* Here we create an IP-Address out of range 169.254.1.0 to 169.254.254.255
   * compliant to RFC 3927 Section 2.1
@@ -186,13 +185,13 @@ autoip_create_addr(struct netif *netif, ip4_addr_t *ipaddr)
    addr -= AUTOIP_RANGE_END - AUTOIP_RANGE_START + 1;
  }
  LWIP_ASSERT("AUTOIP address not in range", (addr >= AUTOIP_RANGE_START) &&
-              (addr <= AUTOIP_RANGE_END));
+    (addr <= AUTOIP_RANGE_END));
  ip4_addr_set_u32(ipaddr, lwip_htonl(addr));

  LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-              ("autoip_create_addr(): tried_llipaddr=%"U16_F", %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-               (u16_t)(autoip->tried_llipaddr), ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr),
-               ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr)));
+    ("autoip_create_addr(): tried_llipaddr=%"U16_F", %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
+    (u16_t)(autoip->tried_llipaddr), ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr),
+    ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr)));
 }

 /**
@@ -203,7 +202,7 @@ autoip_create_addr(struct netif *netif, ip4_addr_t *ipaddr)
 static err_t
 autoip_arp_probe(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);
  /* this works because netif->ip_addr is ANY */
  return etharp_request(netif, &autoip->llipaddr);
 }
@@ -227,14 +226,14 @@ autoip_arp_announce(struct netif *netif)
 static err_t
 autoip_bind(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);
  ip4_addr_t sn_mask, gw_addr;

  LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE,
-              ("autoip_bind(netif=%p) %c%c%"U16_F" %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-               (void *)netif, netif->name[0], netif->name[1], (u16_t)netif->num,
-               ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
-               ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
+    ("autoip_bind(netif=%p) %c%c%"U16_F" %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
+    (void*)netif, netif->name[0], netif->name[1], (u16_t)netif->num,
+    ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
+    ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));

  IP4_ADDR(&sn_mask, 255, 255, 0, 0);
  IP4_ADDR(&gw_addr, 0, 0, 0, 0);
@@ -246,7 +245,7 @@ autoip_bind(struct netif *netif)
 }

 /**
- * @ingroup autoip
+ * @ingroup autoip 
 * Start AutoIP client
 *
 * @param netif network interface on which start the AutoIP client
@@ -254,10 +253,9 @@ autoip_bind(struct netif *netif)
 err_t
 autoip_start(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);
  err_t result = ERR_OK;

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ERROR("netif is not up, old style port?", netif_is_up(netif), return ERR_ARG;);

  /* Set IP-Address, Netmask and Gateway to 0 to make sure that
@@ -266,18 +264,19 @@ autoip_start(struct netif *netif)
  netif_set_addr(netif, IP4_ADDR_ANY4, IP4_ADDR_ANY4, IP4_ADDR_ANY4);

  LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-              ("autoip_start(netif=%p) %c%c%"U16_F"\n", (void *)netif, netif->name[0],
-               netif->name[1], (u16_t)netif->num));
+    ("autoip_start(netif=%p) %c%c%"U16_F"\n", (void*)netif, netif->name[0],
+    netif->name[1], (u16_t)netif->num));
  if (autoip == NULL) {
    /* no AutoIP client attached yet? */
    LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE,
-                ("autoip_start(): starting new AUTOIP client\n"));
-    autoip = (struct autoip *)mem_calloc(1, sizeof(struct autoip));
+      ("autoip_start(): starting new AUTOIP client\n"));
+    autoip = (struct autoip *)mem_malloc(sizeof(struct autoip));
    if (autoip == NULL) {
      LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE,
-                  ("autoip_start(): could not allocate autoip\n"));
+        ("autoip_start(): could not allocate autoip\n"));
      return ERR_MEM;
    }
+    memset(autoip, 0, sizeof(struct autoip));
    /* store this AutoIP client in the netif */
    netif_set_client_data(netif, LWIP_NETIF_CLIENT_DATA_INDEX_AUTOIP, autoip);
    LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE, ("autoip_start(): allocated autoip"));
@@ -298,14 +297,14 @@ autoip_start(struct netif *netif)
 static void
 autoip_start_probing(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

  autoip->state = AUTOIP_STATE_PROBING;
  autoip->sent_num = 0;
  LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-              ("autoip_start_probing(): changing state to PROBING: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-               ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
-               ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
+     ("autoip_start_probing(): changing state to PROBING: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
+      ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
+      ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));

  /* time to wait to first probe, this is randomly
   * chosen out of 0 to PROBE_WAIT seconds.
@@ -332,7 +331,7 @@ autoip_start_probing(struct netif *netif)
 void
 autoip_network_changed(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

  if (autoip && (autoip->state != AUTOIP_STATE_OFF)) {
    autoip_start_probing(netif);
@@ -340,7 +339,7 @@ autoip_network_changed(struct netif *netif)
 }

 /**
- * @ingroup autoip
+ * @ingroup autoip 
 * Stop AutoIP client
 *
 * @param netif network interface on which stop the AutoIP client
@@ -348,9 +347,8 @@ autoip_network_changed(struct netif *netif)
 err_t
 autoip_stop(struct netif *netif)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

-  LWIP_ASSERT_CORE_LOCKED();
  if (autoip != NULL) {
    autoip->state = AUTOIP_STATE_OFF;
    if (ip4_addr_islinklocal(netif_ip4_addr(netif))) {
@@ -366,10 +364,10 @@ autoip_stop(struct netif *netif)
 void
 autoip_tmr(void)
 {
-  struct netif *netif;
+  struct netif *netif = netif_list;
  /* loop through netif's */
-  NETIF_FOREACH(netif) {
-    struct autoip *autoip = netif_autoip_data(netif);
+  while (netif != NULL) {
+    struct autoip* autoip = netif_autoip_data(netif);
    /* only act on AutoIP configured interfaces */
    if (autoip != NULL) {
      if (autoip->lastconflict > 0) {
@@ -377,14 +375,14 @@ autoip_tmr(void)
      }

      LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE,
-                  ("autoip_tmr() AutoIP-State: %"U16_F", ttw=%"U16_F"\n",
-                   (u16_t)(autoip->state), autoip->ttw));
+        ("autoip_tmr() AutoIP-State: %"U16_F", ttw=%"U16_F"\n",
+        (u16_t)(autoip->state), autoip->ttw));

      if (autoip->ttw > 0) {
        autoip->ttw--;
      }

-      switch (autoip->state) {
+      switch(autoip->state) {
        case AUTOIP_STATE_PROBING:
          if (autoip->ttw == 0) {
            if (autoip->sent_num >= PROBE_NUM) {
@@ -396,9 +394,9 @@ autoip_tmr(void)
              autoip->sent_num = 1;
              autoip->ttw = ANNOUNCE_WAIT * AUTOIP_TICKS_PER_SECOND;
              LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-                          ("autoip_tmr(): changing state to ANNOUNCING: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                           ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
-                           ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
+                 ("autoip_tmr(): changing state to ANNOUNCING: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
+                  ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
+                  ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
            } else {
              autoip_arp_probe(netif);
              LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE, ("autoip_tmr() PROBING Sent Probe\n"));
@@ -409,8 +407,8 @@ autoip_tmr(void)
              } else {
                /* calculate time to wait to next probe */
                autoip->ttw = (u16_t)((LWIP_AUTOIP_RAND(netif) %
-                                       ((PROBE_MAX - PROBE_MIN) * AUTOIP_TICKS_PER_SECOND) ) +
-                                      PROBE_MIN * AUTOIP_TICKS_PER_SECOND);
+                  ((PROBE_MAX - PROBE_MIN) * AUTOIP_TICKS_PER_SECOND) ) +
+                  PROBE_MIN * AUTOIP_TICKS_PER_SECOND);
              }
            }
          }
@@ -424,13 +422,13 @@ autoip_tmr(void)
            autoip->sent_num++;

            if (autoip->sent_num >= ANNOUNCE_NUM) {
-              autoip->state = AUTOIP_STATE_BOUND;
-              autoip->sent_num = 0;
-              autoip->ttw = 0;
-              LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
-                          ("autoip_tmr(): changing state to BOUND: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                           ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
-                           ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
+                autoip->state = AUTOIP_STATE_BOUND;
+                autoip->sent_num = 0;
+                autoip->ttw = 0;
+                 LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE,
+                    ("autoip_tmr(): changing state to BOUND: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
+                     ip4_addr1_16(&autoip->llipaddr), ip4_addr2_16(&autoip->llipaddr),
+                     ip4_addr3_16(&autoip->llipaddr), ip4_addr4_16(&autoip->llipaddr)));
            }
          }
          break;
@@ -440,6 +438,8 @@ autoip_tmr(void)
          break;
      }
    }
+    /* proceed to next network interface */
+    netif = netif->next;
  }
 }

@@ -452,49 +452,49 @@ autoip_tmr(void)
 void
 autoip_arp_reply(struct netif *netif, struct etharp_hdr *hdr)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);

  LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE, ("autoip_arp_reply()\n"));
  if ((autoip != NULL) && (autoip->state != AUTOIP_STATE_OFF)) {
-    /* when ip.src == llipaddr && hw.src != netif->hwaddr
-     *
-     * when probing  ip.dst == llipaddr && hw.src != netif->hwaddr
-     * we have a conflict and must solve it
-     */
+   /* when ip.src == llipaddr && hw.src != netif->hwaddr
+    *
+    * when probing  ip.dst == llipaddr && hw.src != netif->hwaddr
+    * we have a conflict and must solve it
+    */
    ip4_addr_t sipaddr, dipaddr;
    struct eth_addr netifaddr;
-    SMEMCPY(netifaddr.addr, netif->hwaddr, ETH_HWADDR_LEN);
+    ETHADDR16_COPY(netifaddr.addr, netif->hwaddr);

-    /* Copy struct ip4_addr_wordaligned to aligned ip4_addr, to support compilers without
+    /* Copy struct ip4_addr2 to aligned ip4_addr, to support compilers without
     * structure packing (not using structure copy which breaks strict-aliasing rules).
     */
-    IPADDR_WORDALIGNED_COPY_TO_IP4_ADDR_T(&sipaddr, &hdr->sipaddr);
-    IPADDR_WORDALIGNED_COPY_TO_IP4_ADDR_T(&dipaddr, &hdr->dipaddr);
+    IPADDR2_COPY(&sipaddr, &hdr->sipaddr);
+    IPADDR2_COPY(&dipaddr, &hdr->dipaddr);

    if (autoip->state == AUTOIP_STATE_PROBING) {
-      /* RFC 3927 Section 2.2.1:
-       * from beginning to after ANNOUNCE_WAIT
-       * seconds we have a conflict if
-       * ip.src == llipaddr OR
-       * ip.dst == llipaddr && hw.src != own hwaddr
-       */
+     /* RFC 3927 Section 2.2.1:
+      * from beginning to after ANNOUNCE_WAIT
+      * seconds we have a conflict if
+      * ip.src == llipaddr OR
+      * ip.dst == llipaddr && hw.src != own hwaddr
+      */
      if ((ip4_addr_cmp(&sipaddr, &autoip->llipaddr)) ||
          (ip4_addr_isany_val(sipaddr) &&
           ip4_addr_cmp(&dipaddr, &autoip->llipaddr) &&
           !eth_addr_cmp(&netifaddr, &hdr->shwaddr))) {
        LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE | LWIP_DBG_LEVEL_WARNING,
-                    ("autoip_arp_reply(): Probe Conflict detected\n"));
+          ("autoip_arp_reply(): Probe Conflict detected\n"));
        autoip_restart(netif);
      }
    } else {
-      /* RFC 3927 Section 2.5:
-       * in any state we have a conflict if
-       * ip.src == llipaddr && hw.src != own hwaddr
-       */
+     /* RFC 3927 Section 2.5:
+      * in any state we have a conflict if
+      * ip.src == llipaddr && hw.src != own hwaddr
+      */
      if (ip4_addr_cmp(&sipaddr, &autoip->llipaddr) &&
          !eth_addr_cmp(&netifaddr, &hdr->shwaddr)) {
        LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE | LWIP_DBG_LEVEL_WARNING,
-                    ("autoip_arp_reply(): Conflicting ARP-Packet detected\n"));
+          ("autoip_arp_reply(): Conflicting ARP-Packet detected\n"));
        autoip_handle_arp_conflict(netif);
      }
    }
@@ -511,7 +511,7 @@ u8_t
 autoip_supplied_address(const struct netif *netif)
 {
  if ((netif != NULL) && (netif_autoip_data(netif) != NULL)) {
-    struct autoip *autoip = netif_autoip_data(netif);
+    struct autoip* autoip = netif_autoip_data(netif);
    return (autoip->state == AUTOIP_STATE_BOUND) || (autoip->state == AUTOIP_STATE_ANNOUNCING);
  }
  return 0;
@@ -520,7 +520,7 @@ autoip_supplied_address(const struct netif *netif)
 u8_t
 autoip_accept_packet(struct netif *netif, const ip4_addr_t *addr)
 {
-  struct autoip *autoip = netif_autoip_data(netif);
+  struct autoip* autoip = netif_autoip_data(netif);
  return (autoip != NULL) && ip4_addr_cmp(addr, &(autoip->llipaddr));
 }

--- a/src/core/ipv4/dhcp.c
+++ b/src/core/ipv4/dhcp.c
--- a/src/core/ipv4/etharp.c
+++ b/src/core/ipv4/etharp.c
@@ -45,14 +45,13 @@

 #include "lwip/opt.h"

-#if LWIP_IPV4 && LWIP_ARP /* don't build if not configured for use in lwipopts.h */
+#if LWIP_ARP || LWIP_ETHERNET

 #include "lwip/etharp.h"
 #include "lwip/stats.h"
 #include "lwip/snmp.h"
 #include "lwip/dhcp.h"
 #include "lwip/autoip.h"
-#include "lwip/prot/iana.h"
 #include "netif/ethernet.h"

 #include <string.h>
@@ -61,6 +60,8 @@
 #include LWIP_HOOK_FILENAME
 #endif

+#if LWIP_IPV4 && LWIP_ARP /* don't build if not configured for use in lwipopts.h */
+
 /** Re-request a used ARP entry 1 minute before it would expire to prevent
 *  breaking a steadily used connection because the ARP entry timed out. */
 #define ARP_AGE_REREQUEST_USED_UNICAST   (ARP_MAXAGE - 30)
@@ -83,7 +84,7 @@ enum etharp_state {
  ETHARP_STATE_STABLE_REREQUESTING_1,
  ETHARP_STATE_STABLE_REREQUESTING_2
 #if ETHARP_SUPPORT_STATIC_ENTRIES
-  , ETHARP_STATE_STATIC
+  ,ETHARP_STATE_STATIC
 #endif /* ETHARP_SUPPORT_STATIC_ENTRIES */
 };

@@ -105,7 +106,7 @@ struct etharp_entry {
 static struct etharp_entry arp_table[ARP_TABLE_SIZE];

 #if !LWIP_NETIF_HWADDRHINT
-static netif_addr_idx_t etharp_cached_entry;
+static u8_t etharp_cached_entry;
 #endif /* !LWIP_NETIF_HWADDRHINT */

 /** Try hard to create a new entry - we want the IP address to appear in
@@ -117,20 +118,20 @@ static netif_addr_idx_t etharp_cached_entry;
 #endif /* ETHARP_SUPPORT_STATIC_ENTRIES */

 #if LWIP_NETIF_HWADDRHINT
-#define ETHARP_SET_ADDRHINT(netif, addrhint)  do { if (((netif) != NULL) && ((netif)->hints != NULL)) { \
-                                              (netif)->hints->addr_hint = (addrhint); }} while(0)
+#define ETHARP_SET_HINT(netif, hint)  if (((netif) != NULL) && ((netif)->addr_hint != NULL))  \
+                                      *((netif)->addr_hint) = (hint);
 #else /* LWIP_NETIF_HWADDRHINT */
-#define ETHARP_SET_ADDRHINT(netif, addrhint)  (etharp_cached_entry = (addrhint))
+#define ETHARP_SET_HINT(netif, hint)  (etharp_cached_entry = (hint))
 #endif /* LWIP_NETIF_HWADDRHINT */


-/* Check for maximum ARP_TABLE_SIZE */
-#if (ARP_TABLE_SIZE > NETIF_ADDR_IDX_MAX)
-#error "ARP_TABLE_SIZE must fit in an s16_t, you have to reduce it in your lwipopts.h"
+/* Some checks, instead of etharp_init(): */
+#if (LWIP_ARP && (ARP_TABLE_SIZE > 0x7f))
+  #error "ARP_TABLE_SIZE must fit in an s8_t, you have to reduce it in your lwipopts.h"
 #endif


-static err_t etharp_request_dst(struct netif *netif, const ip4_addr_t *ipaddr, const struct eth_addr *hw_dst_addr);
+static err_t etharp_request_dst(struct netif *netif, const ip4_addr_t *ipaddr, const struct eth_addr* hw_dst_addr);
 static err_t etharp_raw(struct netif *netif,
                        const struct eth_addr *ethsrc_addr, const struct eth_addr *ethdst_addr,
                        const struct eth_addr *hwsrc_addr, const ip4_addr_t *ipsrc_addr,
@@ -148,6 +149,7 @@ free_etharp_q(struct etharp_q_entry *q)
 {
  struct etharp_q_entry *r;
  LWIP_ASSERT("q != NULL", q != NULL);
+  LWIP_ASSERT("q->p != NULL", q->p != NULL);
  while (q) {
    r = q;
    q = q->next;
@@ -196,7 +198,7 @@ etharp_free_entry(int i)
 void
 etharp_tmr(void)
 {
-  int i;
+  u8_t i;

  LWIP_DEBUGF(ETHARP_DEBUG, ("etharp_timer\n"));
  /* remove expired entries from the ARP table */
@@ -204,16 +206,16 @@ etharp_tmr(void)
    u8_t state = arp_table[i].state;
    if (state != ETHARP_STATE_EMPTY
 #if ETHARP_SUPPORT_STATIC_ENTRIES
-        && (state != ETHARP_STATE_STATIC)
+      && (state != ETHARP_STATE_STATIC)
 #endif /* ETHARP_SUPPORT_STATIC_ENTRIES */
-       ) {
+      ) {
      arp_table[i].ctime++;
      if ((arp_table[i].ctime >= ARP_MAXAGE) ||
          ((arp_table[i].state == ETHARP_STATE_PENDING)  &&
           (arp_table[i].ctime >= ARP_MAXPENDING))) {
        /* pending or stable entry has become old! */
-        LWIP_DEBUGF(ETHARP_DEBUG, ("etharp_timer: expired %s entry %d.\n",
-                                   arp_table[i].state >= ETHARP_STATE_STABLE ? "stable" : "pending", i));
+        LWIP_DEBUGF(ETHARP_DEBUG, ("etharp_timer: expired %s entry %"U16_F".\n",
+             arp_table[i].state >= ETHARP_STATE_STABLE ? "stable" : "pending", (u16_t)i));
        /* clean up entries that have just been expired */
        etharp_free_entry(i);
      } else if (arp_table[i].state == ETHARP_STATE_STABLE_REREQUESTING_1) {
@@ -252,14 +254,14 @@ etharp_tmr(void)
 * @return The ARP entry index that matched or is created, ERR_MEM if no
 * entry is found or could be recycled.
 */
-static s16_t
-etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
+static s8_t
+etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif* netif)
 {
-  s16_t old_pending = ARP_TABLE_SIZE, old_stable = ARP_TABLE_SIZE;
-  s16_t empty = ARP_TABLE_SIZE;
-  s16_t i = 0;
+  s8_t old_pending = ARP_TABLE_SIZE, old_stable = ARP_TABLE_SIZE;
+  s8_t empty = ARP_TABLE_SIZE;
+  u8_t i = 0;
  /* oldest entry with packets on queue */
-  s16_t old_queue = ARP_TABLE_SIZE;
+  s8_t old_queue = ARP_TABLE_SIZE;
  /* its age */
  u16_t age_queue = 0, age_pending = 0, age_stable = 0;

@@ -284,19 +286,19 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
    u8_t state = arp_table[i].state;
    /* no empty entry found yet and now we do find one? */
    if ((empty == ARP_TABLE_SIZE) && (state == ETHARP_STATE_EMPTY)) {
-      LWIP_DEBUGF(ETHARP_DEBUG, ("etharp_find_entry: found empty entry %d\n", (int)i));
+      LWIP_DEBUGF(ETHARP_DEBUG, ("etharp_find_entry: found empty entry %"U16_F"\n", (u16_t)i));
      /* remember first empty entry */
      empty = i;
    } else if (state != ETHARP_STATE_EMPTY) {
      LWIP_ASSERT("state == ETHARP_STATE_PENDING || state >= ETHARP_STATE_STABLE",
-                  state == ETHARP_STATE_PENDING || state >= ETHARP_STATE_STABLE);
+        state == ETHARP_STATE_PENDING || state >= ETHARP_STATE_STABLE);
      /* if given, does IP address match IP address in ARP entry? */
      if (ipaddr && ip4_addr_cmp(ipaddr, &arp_table[i].ipaddr)
 #if ETHARP_TABLE_MATCH_NETIF
          && ((netif == NULL) || (netif == arp_table[i].netif))
 #endif /* ETHARP_TABLE_MATCH_NETIF */
-         ) {
-        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: found matching entry %d\n", (int)i));
+        ) {
+        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: found matching entry %"U16_F"\n", (u16_t)i));
        /* found exact IP address match, simply bail out */
        return i;
      }
@@ -309,14 +311,14 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
            age_queue = arp_table[i].ctime;
          }
        } else
-          /* pending without queued packets? */
+        /* pending without queued packets? */
        {
          if (arp_table[i].ctime >= age_pending) {
            old_pending = i;
            age_pending = arp_table[i].ctime;
          }
        }
-        /* stable entry? */
+      /* stable entry? */
      } else if (state >= ETHARP_STATE_STABLE) {
 #if ETHARP_SUPPORT_STATIC_ENTRIES
        /* don't record old_stable for static entries since they never expire */
@@ -339,7 +341,7 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
      /* or no empty entry found and not allowed to recycle? */
      ((empty == ARP_TABLE_SIZE) && ((flags & ETHARP_FLAG_TRY_HARD) == 0))) {
    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: no empty entry found and not allowed to recycle\n"));
-    return (s16_t)ERR_MEM;
+    return (s8_t)ERR_MEM;
  }

  /* b) choose the least destructive entry to recycle:
@@ -354,29 +356,29 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
  /* 1) empty entry available? */
  if (empty < ARP_TABLE_SIZE) {
    i = empty;
-    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting empty entry %d\n", (int)i));
+    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting empty entry %"U16_F"\n", (u16_t)i));
  } else {
    /* 2) found recyclable stable entry? */
    if (old_stable < ARP_TABLE_SIZE) {
      /* recycle oldest stable*/
      i = old_stable;
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest stable entry %d\n", (int)i));
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest stable entry %"U16_F"\n", (u16_t)i));
      /* no queued packets should exist on stable entries */
      LWIP_ASSERT("arp_table[i].q == NULL", arp_table[i].q == NULL);
-      /* 3) found recyclable pending entry without queued packets? */
+    /* 3) found recyclable pending entry without queued packets? */
    } else if (old_pending < ARP_TABLE_SIZE) {
      /* recycle oldest pending */
      i = old_pending;
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest pending entry %d (without queue)\n", (int)i));
-      /* 4) found recyclable pending entry with queued packets? */
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest pending entry %"U16_F" (without queue)\n", (u16_t)i));
+    /* 4) found recyclable pending entry with queued packets? */
    } else if (old_queue < ARP_TABLE_SIZE) {
      /* recycle oldest pending (queued packets are free in etharp_free_entry) */
      i = old_queue;
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest pending entry %d, freeing packet queue %p\n", (int)i, (void *)(arp_table[i].q)));
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: selecting oldest pending entry %"U16_F", freeing packet queue %p\n", (u16_t)i, (void *)(arp_table[i].q)));
      /* no empty or recyclable entries found */
    } else {
      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_find_entry: no empty or recyclable entries found\n"));
-      return (s16_t)ERR_MEM;
+      return (s8_t)ERR_MEM;
    }

    /* { empty or recyclable entry found } */
@@ -386,7 +388,7 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)

  LWIP_ASSERT("i < ARP_TABLE_SIZE", i < ARP_TABLE_SIZE);
  LWIP_ASSERT("arp_table[i].state == ETHARP_STATE_EMPTY",
-              arp_table[i].state == ETHARP_STATE_EMPTY);
+    arp_table[i].state == ETHARP_STATE_EMPTY);

  /* IP address given? */
  if (ipaddr != NULL) {
@@ -396,8 +398,8 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
  arp_table[i].ctime = 0;
 #if ETHARP_TABLE_MATCH_NETIF
  arp_table[i].netif = netif;
-#endif /* ETHARP_TABLE_MATCH_NETIF */
-  return (s16_t)i;
+#endif /* ETHARP_TABLE_MATCH_NETIF*/
+  return (err_t)i;
 }

 /**
@@ -421,12 +423,12 @@ etharp_find_entry(const ip4_addr_t *ipaddr, u8_t flags, struct netif *netif)
 static err_t
 etharp_update_arp_entry(struct netif *netif, const ip4_addr_t *ipaddr, struct eth_addr *ethaddr, u8_t flags)
 {
-  s16_t i;
+  s8_t i;
  LWIP_ASSERT("netif->hwaddr_len == ETH_HWADDR_LEN", netif->hwaddr_len == ETH_HWADDR_LEN);
  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_update_arp_entry: %"U16_F".%"U16_F".%"U16_F".%"U16_F" - %02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F"\n",
-              ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr),
-              (u16_t)ethaddr->addr[0], (u16_t)ethaddr->addr[1], (u16_t)ethaddr->addr[2],
-              (u16_t)ethaddr->addr[3], (u16_t)ethaddr->addr[4], (u16_t)ethaddr->addr[5]));
+    ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr),
+    (u16_t)ethaddr->addr[0], (u16_t)ethaddr->addr[1], (u16_t)ethaddr->addr[2],
+    (u16_t)ethaddr->addr[3], (u16_t)ethaddr->addr[4], (u16_t)ethaddr->addr[5]));
  /* non-unicast address? */
  if (ip4_addr_isany(ipaddr) ||
      ip4_addr_isbroadcast(ipaddr, netif) ||
@@ -460,9 +462,9 @@ etharp_update_arp_entry(struct netif *netif, const ip4_addr_t *ipaddr, struct et
  /* insert in SNMP ARP index tree */
  mib2_add_arp_entry(netif, &arp_table[i].ipaddr);

-  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_update_arp_entry: updating stable entry %"S16_F"\n", i));
+  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_update_arp_entry: updating stable entry %"S16_F"\n", (s16_t)i));
  /* update address */
-  SMEMCPY(&arp_table[i].ethaddr, ethaddr, ETH_HWADDR_LEN);
+  ETHADDR32_COPY(&arp_table[i].ethaddr, ethaddr);
  /* reset time stamp */
  arp_table[i].ctime = 0;
  /* this is where we will send out queued packets! */
@@ -483,7 +485,7 @@ etharp_update_arp_entry(struct netif *netif, const ip4_addr_t *ipaddr, struct et
    arp_table[i].q = NULL;
 #endif /* ARP_QUEUEING */
    /* send the queued IP packet */
-    ethernet_output(netif, p, (struct eth_addr *)(netif->hwaddr), ethaddr, ETHTYPE_IP);
+    ethernet_output(netif, p, (struct eth_addr*)(netif->hwaddr), ethaddr, ETHTYPE_IP);
    /* free the queued IP packet */
    pbuf_free(p);
  }
@@ -503,11 +505,10 @@ err_t
 etharp_add_static_entry(const ip4_addr_t *ipaddr, struct eth_addr *ethaddr)
 {
  struct netif *netif;
-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_add_static_entry: %"U16_F".%"U16_F".%"U16_F".%"U16_F" - %02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F":%02"X16_F"\n",
-              ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr),
-              (u16_t)ethaddr->addr[0], (u16_t)ethaddr->addr[1], (u16_t)ethaddr->addr[2],
-              (u16_t)ethaddr->addr[3], (u16_t)ethaddr->addr[4], (u16_t)ethaddr->addr[5]));
+    ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr),
+    (u16_t)ethaddr->addr[0], (u16_t)ethaddr->addr[1], (u16_t)ethaddr->addr[2],
+    (u16_t)ethaddr->addr[3], (u16_t)ethaddr->addr[4], (u16_t)ethaddr->addr[5]));

  netif = ip4_route(ipaddr);
  if (netif == NULL) {
@@ -528,10 +529,9 @@ etharp_add_static_entry(const ip4_addr_t *ipaddr, struct eth_addr *ethaddr)
 err_t
 etharp_remove_static_entry(const ip4_addr_t *ipaddr)
 {
-  s16_t i;
-  LWIP_ASSERT_CORE_LOCKED();
+  s8_t i;
  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_remove_static_entry: %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-              ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr)));
+    ip4_addr1_16(ipaddr), ip4_addr2_16(ipaddr), ip4_addr3_16(ipaddr), ip4_addr4_16(ipaddr)));

  /* find or create ARP entry */
  i = etharp_find_entry(ipaddr, ETHARP_FLAG_FIND_ONLY, NULL);
@@ -558,7 +558,7 @@ etharp_remove_static_entry(const ip4_addr_t *ipaddr)
 void
 etharp_cleanup_netif(struct netif *netif)
 {
-  int i;
+  u8_t i;

  for (i = 0; i < ARP_TABLE_SIZE; ++i) {
    u8_t state = arp_table[i].state;
@@ -579,22 +579,22 @@ etharp_cleanup_netif(struct netif *netif)
 * @param ip_ret points to return pointer
 * @return table index if found, -1 otherwise
 */
-ssize_t
+s8_t
 etharp_find_addr(struct netif *netif, const ip4_addr_t *ipaddr,
-                 struct eth_addr **eth_ret, const ip4_addr_t **ip_ret)
+         struct eth_addr **eth_ret, const ip4_addr_t **ip_ret)
 {
-  s16_t i;
+  s8_t i;

  LWIP_ASSERT("eth_ret != NULL && ip_ret != NULL",
-              eth_ret != NULL && ip_ret != NULL);
+    eth_ret != NULL && ip_ret != NULL);

  LWIP_UNUSED_ARG(netif);

  i = etharp_find_entry(ipaddr, ETHARP_FLAG_FIND_ONLY, netif);
  if ((i >= 0) && (arp_table[i].state >= ETHARP_STATE_STABLE)) {
-    *eth_ret = &arp_table[i].ethaddr;
-    *ip_ret = &arp_table[i].ipaddr;
-    return i;
+      *eth_ret = &arp_table[i].ethaddr;
+      *ip_ret = &arp_table[i].ipaddr;
+      return i;
  }
  return -1;
 }
@@ -608,14 +608,14 @@ etharp_find_addr(struct netif *netif, const ip4_addr_t *ipaddr,
 * @param eth_ret return value: ETH address
 * @return 1 on valid index, 0 otherwise
 */
-int
-etharp_get_entry(size_t i, ip4_addr_t **ipaddr, struct netif **netif, struct eth_addr **eth_ret)
+u8_t
+etharp_get_entry(u8_t i, ip4_addr_t **ipaddr, struct netif **netif, struct eth_addr **eth_ret)
 {
  LWIP_ASSERT("ipaddr != NULL", ipaddr != NULL);
  LWIP_ASSERT("netif != NULL", netif != NULL);
  LWIP_ASSERT("eth_ret != NULL", eth_ret != NULL);

-  if ((i < ARP_TABLE_SIZE) && (arp_table[i].state >= ETHARP_STATE_STABLE)) {
+  if((i < ARP_TABLE_SIZE) && (arp_table[i].state >= ETHARP_STATE_STABLE)) {
    *ipaddr  = &arp_table[i].ipaddr;
    *netif   = arp_table[i].netif;
    *eth_ret = &arp_table[i].ethaddr;
@@ -645,20 +645,18 @@ etharp_input(struct pbuf *p, struct netif *netif)
  ip4_addr_t sipaddr, dipaddr;
  u8_t for_us;

-  LWIP_ASSERT_CORE_LOCKED();
-
  LWIP_ERROR("netif != NULL", (netif != NULL), return;);

  hdr = (struct etharp_hdr *)p->payload;

  /* RFC 826 "Packet Reception": */
-  if ((hdr->hwtype != PP_HTONS(LWIP_IANA_HWTYPE_ETHERNET)) ||
+  if ((hdr->hwtype != PP_HTONS(HWTYPE_ETHERNET)) ||
      (hdr->hwlen != ETH_HWADDR_LEN) ||
      (hdr->protolen != sizeof(ip4_addr_t)) ||
      (hdr->proto != PP_HTONS(ETHTYPE_IP)))  {
    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_WARNING,
-                ("etharp_input: packet dropped, wrong hw type, hwlen, proto, protolen or ethernet type (%"U16_F"/%"U16_F"/%"U16_F"/%"U16_F")\n",
-                 hdr->hwtype, (u16_t)hdr->hwlen, hdr->proto, (u16_t)hdr->protolen));
+      ("etharp_input: packet dropped, wrong hw type, hwlen, proto, protolen or ethernet type (%"U16_F"/%"U16_F"/%"U16_F"/%"U16_F")\n",
+      hdr->hwtype, (u16_t)hdr->hwlen, hdr->proto, (u16_t)hdr->protolen));
    ETHARP_STATS_INC(etharp.proterr);
    ETHARP_STATS_INC(etharp.drop);
    pbuf_free(p);
@@ -673,10 +671,10 @@ etharp_input(struct pbuf *p, struct netif *netif)
  autoip_arp_reply(netif, hdr);
 #endif /* LWIP_AUTOIP */

-  /* Copy struct ip4_addr_wordaligned to aligned ip4_addr, to support compilers without
+  /* Copy struct ip4_addr2 to aligned ip4_addr, to support compilers without
   * structure packing (not using structure copy which breaks strict-aliasing rules). */
-  IPADDR_WORDALIGNED_COPY_TO_IP4_ADDR_T(&sipaddr, &hdr->sipaddr);
-  IPADDR_WORDALIGNED_COPY_TO_IP4_ADDR_T(&dipaddr, &hdr->dipaddr);
+  IPADDR2_COPY(&sipaddr, &hdr->sipaddr);
+  IPADDR2_COPY(&dipaddr, &hdr->dipaddr);

  /* this interface is not configured? */
  if (ip4_addr_isany_val(*netif_ip4_addr(netif))) {
@@ -692,50 +690,50 @@ etharp_input(struct pbuf *p, struct netif *netif)
     ARP message not directed to us?
      ->  update the source IP address in the cache, if present */
  etharp_update_arp_entry(netif, &sipaddr, &(hdr->shwaddr),
-                          for_us ? ETHARP_FLAG_TRY_HARD : ETHARP_FLAG_FIND_ONLY);
+                   for_us ? ETHARP_FLAG_TRY_HARD : ETHARP_FLAG_FIND_ONLY);

  /* now act on the message itself */
  switch (hdr->opcode) {
-    /* ARP request? */
-    case PP_HTONS(ARP_REQUEST):
-      /* ARP request. If it asked for our address, we send out a
-       * reply. In any case, we time-stamp any existing ARP entry,
-       * and possibly send out an IP packet that was queued on it. */
+  /* ARP request? */
+  case PP_HTONS(ARP_REQUEST):
+    /* ARP request. If it asked for our address, we send out a
+     * reply. In any case, we time-stamp any existing ARP entry,
+     * and possibly send out an IP packet that was queued on it. */

-      LWIP_DEBUGF (ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: incoming ARP request\n"));
-      /* ARP request for our address? */
-      if (for_us) {
-        /* send ARP response */
-        etharp_raw(netif,
-                   (struct eth_addr *)netif->hwaddr, &hdr->shwaddr,
-                   (struct eth_addr *)netif->hwaddr, netif_ip4_addr(netif),
-                   &hdr->shwaddr, &sipaddr,
-                   ARP_REPLY);
-        /* we are not configured? */
-      } else if (ip4_addr_isany_val(*netif_ip4_addr(netif))) {
-        /* { for_us == 0 and netif->ip_addr.addr == 0 } */
-        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: we are unconfigured, ARP request ignored.\n"));
-        /* request was not directed to us */
-      } else {
-        /* { for_us == 0 and netif->ip_addr.addr != 0 } */
-        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: ARP request was not for us.\n"));
-      }
-      break;
-    case PP_HTONS(ARP_REPLY):
-      /* ARP reply. We already updated the ARP cache earlier. */
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: incoming ARP reply\n"));
+    LWIP_DEBUGF (ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: incoming ARP request\n"));
+    /* ARP request for our address? */
+    if (for_us) {
+      /* send ARP response */
+      etharp_raw(netif,
+                 (struct eth_addr *)netif->hwaddr, &hdr->shwaddr,
+                 (struct eth_addr *)netif->hwaddr, netif_ip4_addr(netif),
+                 &hdr->shwaddr, &sipaddr,
+                 ARP_REPLY);
+    /* we are not configured? */
+    } else if (ip4_addr_isany_val(*netif_ip4_addr(netif))) {
+      /* { for_us == 0 and netif->ip_addr.addr == 0 } */
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: we are unconfigured, ARP request ignored.\n"));
+    /* request was not directed to us */
+    } else {
+      /* { for_us == 0 and netif->ip_addr.addr != 0 } */
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: ARP request was not for us.\n"));
+    }
+    break;
+  case PP_HTONS(ARP_REPLY):
+    /* ARP reply. We already updated the ARP cache earlier. */
+    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: incoming ARP reply\n"));
 #if (LWIP_DHCP && DHCP_DOES_ARP_CHECK)
-      /* DHCP wants to know about ARP replies from any host with an
-       * IP address also offered to us by the DHCP server. We do not
-       * want to take a duplicate IP address on a single network.
-       * @todo How should we handle redundant (fail-over) interfaces? */
-      dhcp_arp_reply(netif, &sipaddr);
+    /* DHCP wants to know about ARP replies from any host with an
+     * IP address also offered to us by the DHCP server. We do not
+     * want to take a duplicate IP address on a single network.
+     * @todo How should we handle redundant (fail-over) interfaces? */
+    dhcp_arp_reply(netif, &sipaddr);
 #endif /* (LWIP_DHCP && DHCP_DOES_ARP_CHECK) */
-      break;
-    default:
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: ARP unknown opcode type %"S16_F"\n", lwip_htons(hdr->opcode)));
-      ETHARP_STATS_INC(etharp.err);
-      break;
+    break;
+  default:
+    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_input: ARP unknown opcode type %"S16_F"\n", lwip_htons(hdr->opcode)));
+    ETHARP_STATS_INC(etharp.err);
+    break;
  }
  /* free ARP packet */
  pbuf_free(p);
@@ -745,7 +743,7 @@ etharp_input(struct pbuf *p, struct netif *netif)
 * in the arp_table specified by the index 'arp_idx'.
 */
 static err_t
-etharp_output_to_arp_index(struct netif *netif, struct pbuf *q, netif_addr_idx_t arp_idx)
+etharp_output_to_arp_index(struct netif *netif, struct pbuf *q, u8_t arp_idx)
 {
  LWIP_ASSERT("arp_table[arp_idx].state >= ETHARP_STATE_STABLE",
              arp_table[arp_idx].state >= ETHARP_STATE_STABLE);
@@ -766,7 +764,7 @@ etharp_output_to_arp_index(struct netif *netif, struct pbuf *q, netif_addr_idx_t
    }
  }

-  return ethernet_output(netif, q, (struct eth_addr *)(netif->hwaddr), &arp_table[arp_idx].ethaddr, ETHTYPE_IP);
+  return ethernet_output(netif, q, (struct eth_addr*)(netif->hwaddr), &arp_table[arp_idx].ethaddr, ETHTYPE_IP);
 }

 /**
@@ -794,7 +792,6 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
  struct eth_addr mcastaddr;
  const ip4_addr_t *dst_addr = ipaddr;

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_ASSERT("netif != NULL", netif != NULL);
  LWIP_ASSERT("q != NULL", q != NULL);
  LWIP_ASSERT("ipaddr != NULL", ipaddr != NULL);
@@ -806,7 +803,7 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
  if (ip4_addr_isbroadcast(ipaddr, netif)) {
    /* broadcast on Ethernet also */
    dest = (const struct eth_addr *)&ethbroadcast;
-    /* multicast destination IP address? */
+  /* multicast destination IP address? */
  } else if (ip4_addr_ismulticast(ipaddr)) {
    /* Hash IP multicast address to MAC address.*/
    mcastaddr.addr[0] = LL_IP4_MULTICAST_ADDR_0;
@@ -817,15 +814,15 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
    mcastaddr.addr[5] = ip4_addr4(ipaddr);
    /* destination Ethernet address is multicast */
    dest = &mcastaddr;
-    /* unicast destination IP address? */
+  /* unicast destination IP address? */
  } else {
-    netif_addr_idx_t i;
+    s8_t i;
    /* outside local network? if so, this can neither be a global broadcast nor
       a subnet broadcast. */
    if (!ip4_addr_netcmp(ipaddr, netif_ip4_addr(netif), netif_ip4_netmask(netif)) &&
        !ip4_addr_islinklocal(ipaddr)) {
 #if LWIP_AUTOIP
-      struct ip_hdr *iphdr = LWIP_ALIGNMENT_CAST(struct ip_hdr *, q->payload);
+      struct ip_hdr *iphdr = LWIP_ALIGNMENT_CAST(struct ip_hdr*, q->payload);
      /* According to RFC 3297, chapter 2.6.2 (Forwarding Rules), a packet with
         a link-local source address must always be "directly to its destination
         on the same physical link. The host MUST NOT send the packet to any
@@ -844,7 +841,7 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
          if (!ip4_addr_isany_val(*netif_ip4_gw(netif))) {
            /* send to hardware address of default gateway IP address */
            dst_addr = netif_ip4_gw(netif);
-            /* no default gateway available */
+          /* no default gateway available */
          } else {
            /* no route to destination error (default gateway missing) */
            return ERR_RTE;
@@ -853,9 +850,9 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
      }
    }
 #if LWIP_NETIF_HWADDRHINT
-    if (netif->hints != NULL) {
+    if (netif->addr_hint != NULL) {
      /* per-pcb cached entry was given */
-      netif_addr_idx_t etharp_cached_entry = netif->hints->addr_hint;
+      u8_t etharp_cached_entry = *(netif->addr_hint);
      if (etharp_cached_entry < ARP_TABLE_SIZE) {
 #endif /* LWIP_NETIF_HWADDRHINT */
        if ((arp_table[etharp_cached_entry].state >= ETHARP_STATE_STABLE) &&
@@ -881,7 +878,7 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
 #endif
          (ip4_addr_cmp(dst_addr, &arp_table[i].ipaddr))) {
        /* found an existing, stable entry */
-        ETHARP_SET_ADDRHINT(netif, i);
+        ETHARP_SET_HINT(netif, i);
        return etharp_output_to_arp_index(netif, q, i);
      }
    }
@@ -893,7 +890,7 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
  /* continuation for multicast/broadcast destinations */
  /* obtain source Ethernet address of the given interface */
  /* send packet directly on the link */
-  return ethernet_output(netif, q, (struct eth_addr *)(netif->hwaddr), dest, ETHTYPE_IP);
+  return ethernet_output(netif, q, (struct eth_addr*)(netif->hwaddr), dest, ETHTYPE_IP);
 }

 /**
@@ -932,11 +929,10 @@ etharp_output(struct netif *netif, struct pbuf *q, const ip4_addr_t *ipaddr)
 err_t
 etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
 {
-  struct eth_addr *srcaddr = (struct eth_addr *)netif->hwaddr;
+  struct eth_addr * srcaddr = (struct eth_addr *)netif->hwaddr;
  err_t result = ERR_MEM;
  int is_new_entry = 0;
-  s16_t i_err;
-  netif_addr_idx_t i;
+  s8_t i; /* ARP entry index */

  /* non-unicast address? */
  if (ip4_addr_isbroadcast(ipaddr, netif) ||
@@ -947,19 +943,17 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
  }

  /* find entry in ARP cache, ask to create entry if queueing packet */
-  i_err = etharp_find_entry(ipaddr, ETHARP_FLAG_TRY_HARD, netif);
+  i = etharp_find_entry(ipaddr, ETHARP_FLAG_TRY_HARD, netif);

  /* could not find or create entry? */
-  if (i_err < 0) {
+  if (i < 0) {
    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: could not create ARP entry\n"));
    if (q) {
      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: packet dropped\n"));
      ETHARP_STATS_INC(etharp.memerr);
    }
-    return (err_t)i_err;
+    return (err_t)i;
  }
-  LWIP_ASSERT("type overflow", (size_t)i_err < NETIF_ADDR_IDX_MAX);
-  i = (netif_addr_idx_t)i_err;

  /* mark a fresh entry as pending (we just sent a request) */
  if (arp_table[i].state == ETHARP_STATE_EMPTY) {
@@ -971,8 +965,8 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)

  /* { i is either a STABLE or (new or existing) PENDING entry } */
  LWIP_ASSERT("arp_table[i].state == PENDING or STABLE",
-              ((arp_table[i].state == ETHARP_STATE_PENDING) ||
-               (arp_table[i].state >= ETHARP_STATE_STABLE)));
+  ((arp_table[i].state == ETHARP_STATE_PENDING) ||
+   (arp_table[i].state >= ETHARP_STATE_STABLE)));

  /* do we have a new entry? or an implicit query request? */
  if (is_new_entry || (q == NULL)) {
@@ -994,20 +988,21 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
  /* stable entry? */
  if (arp_table[i].state >= ETHARP_STATE_STABLE) {
    /* we have a valid IP->Ethernet address mapping */
-    ETHARP_SET_ADDRHINT(netif, i);
+    ETHARP_SET_HINT(netif, i);
    /* send the packet */
    result = ethernet_output(netif, q, srcaddr, &(arp_table[i].ethaddr), ETHTYPE_IP);
-    /* pending entry? (either just created or already pending */
+  /* pending entry? (either just created or already pending */
  } else if (arp_table[i].state == ETHARP_STATE_PENDING) {
    /* entry is still pending, queue the given packet 'q' */
    struct pbuf *p;
    int copy_needed = 0;
-    /* IF q includes a pbuf that must be copied, copy the whole chain into a
-     * new PBUF_RAM. See the definition of PBUF_NEEDS_COPY for details. */
+    /* IF q includes a PBUF_REF, PBUF_POOL or PBUF_RAM, we have no choice but
+     * to copy the whole queue into a new PBUF_RAM (see bug #11400)
+     * PBUF_ROMs can be left as they are, since ROM must not get changed. */
    p = q;
    while (p) {
      LWIP_ASSERT("no packet queues allowed!", (p->len != p->tot_len) || (p->next == 0));
-      if (PBUF_NEEDS_COPY(p)) {
+      if (p->type != PBUF_ROM) {
        copy_needed = 1;
        break;
      }
@@ -1015,7 +1010,13 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
    }
    if (copy_needed) {
      /* copy the whole packet into new pbufs */
-      p = pbuf_clone(PBUF_LINK, PBUF_RAM, q);
+      p = pbuf_alloc(PBUF_LINK, p->tot_len, PBUF_RAM);
+      if (p != NULL) {
+        if (pbuf_copy(p, q) != ERR_OK) {
+          pbuf_free(p);
+          p = NULL;
+        }
+      }
    } else {
      /* referencing the old pbuf is enough */
      p = q;
@@ -1055,7 +1056,7 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
          memp_free(MEMP_ARP_QUEUE, old);
        }
 #endif
-        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: queued packet %p on ARP entry %"U16_F"\n", (void *)q, i));
+        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: queued packet %p on ARP entry %"S16_F"\n", (void *)q, (s16_t)i));
        result = ERR_OK;
      } else {
        /* the pool MEMP_ARP_QUEUE is empty */
@@ -1066,12 +1067,12 @@ etharp_query(struct netif *netif, const ip4_addr_t *ipaddr, struct pbuf *q)
 #else /* ARP_QUEUEING */
      /* always queue one packet per ARP request only, freeing a previously queued packet */
      if (arp_table[i].q != NULL) {
-        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: dropped previously queued packet %p for ARP entry %"U16_F"\n", (void *)q, (u16_t)i));
+        LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: dropped previously queued packet %p for ARP entry %"S16_F"\n", (void *)q, (s16_t)i));
        pbuf_free(arp_table[i].q);
      }
      arp_table[i].q = p;
      result = ERR_OK;
-      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: queued packet %p on ARP entry %"U16_F"\n", (void *)q, (u16_t)i));
+      LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_query: queued packet %p on ARP entry %"S16_F"\n", (void *)q, (s16_t)i));
 #endif /* ARP_QUEUEING */
    } else {
      ETHARP_STATS_INC(etharp.memerr);
@@ -1115,7 +1116,7 @@ etharp_raw(struct netif *netif, const struct eth_addr *ethsrc_addr,
  /* could allocate a pbuf for an ARP request? */
  if (p == NULL) {
    LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_SERIOUS,
-                ("etharp_raw: could not allocate pbuf for ARP request.\n"));
+      ("etharp_raw: could not allocate pbuf for ARP request.\n"));
    ETHARP_STATS_INC(etharp.memerr);
    return ERR_MEM;
  }
@@ -1130,14 +1131,14 @@ etharp_raw(struct netif *netif, const struct eth_addr *ethsrc_addr,
              (netif->hwaddr_len == ETH_HWADDR_LEN));

  /* Write the ARP MAC-Addresses */
-  SMEMCPY(&hdr->shwaddr, hwsrc_addr, ETH_HWADDR_LEN);
-  SMEMCPY(&hdr->dhwaddr, hwdst_addr, ETH_HWADDR_LEN);
-  /* Copy struct ip4_addr_wordaligned to aligned ip4_addr, to support compilers without
+  ETHADDR16_COPY(&hdr->shwaddr, hwsrc_addr);
+  ETHADDR16_COPY(&hdr->dhwaddr, hwdst_addr);
+  /* Copy struct ip4_addr2 to aligned ip4_addr, to support compilers without
   * structure packing. */
-  IPADDR_WORDALIGNED_COPY_FROM_IP4_ADDR_T(&hdr->sipaddr, ipsrc_addr);
-  IPADDR_WORDALIGNED_COPY_FROM_IP4_ADDR_T(&hdr->dipaddr, ipdst_addr);
+  IPADDR2_COPY(&hdr->sipaddr, ipsrc_addr);
+  IPADDR2_COPY(&hdr->dipaddr, ipdst_addr);

-  hdr->hwtype = PP_HTONS(LWIP_IANA_HWTYPE_ETHERNET);
+  hdr->hwtype = PP_HTONS(HWTYPE_ETHERNET);
  hdr->proto = PP_HTONS(ETHTYPE_IP);
  /* set hwlen and protolen */
  hdr->hwlen = ETH_HWADDR_LEN;
@@ -1148,7 +1149,7 @@ etharp_raw(struct netif *netif, const struct eth_addr *ethsrc_addr,
  /* If we are using Link-Local, all ARP packets that contain a Link-Local
   * 'sender IP address' MUST be sent using link-layer broadcast instead of
   * link-layer unicast. (See RFC3927 Section 2.5, last paragraph) */
-  if (ip4_addr_islinklocal(ipsrc_addr)) {
+  if(ip4_addr_islinklocal(ipsrc_addr)) {
    ethernet_output(netif, p, ethsrc_addr, &ethbroadcast, ETHTYPE_ARP);
  } else
 #endif /* LWIP_AUTOIP */
@@ -1178,7 +1179,7 @@ etharp_raw(struct netif *netif, const struct eth_addr *ethsrc_addr,
 *         any other err_t on failure
 */
 static err_t
-etharp_request_dst(struct netif *netif, const ip4_addr_t *ipaddr, const struct eth_addr *hw_dst_addr)
+etharp_request_dst(struct netif *netif, const ip4_addr_t *ipaddr, const struct eth_addr* hw_dst_addr)
 {
  return etharp_raw(netif, (struct eth_addr *)netif->hwaddr, hw_dst_addr,
                    (struct eth_addr *)netif->hwaddr, netif_ip4_addr(netif), &ethzero,
@@ -1200,5 +1201,6 @@ etharp_request(struct netif *netif, const ip4_addr_t *ipaddr)
  LWIP_DEBUGF(ETHARP_DEBUG | LWIP_DBG_TRACE, ("etharp_request: sending ARP request.\n"));
  return etharp_request_dst(netif, ipaddr, &ethbroadcast);
 }
-
 #endif /* LWIP_IPV4 && LWIP_ARP */
+
+#endif /* LWIP_ARP || LWIP_ETHERNET */
--- a/src/core/ipv4/icmp.c
+++ b/src/core/ipv4/icmp.c
@@ -57,7 +57,7 @@

 /** Small optimization: set to 0 if incoming PBUF_POOL pbuf always can be
 * used to modify and send a response packet (and to 1 if this is not the case,
- * e.g. when link header is stripped off when receiving) */
+ * e.g. when link header is stripped of when receiving) */
 #ifndef LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN
 #define LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN 1
 #endif /* LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN */
@@ -86,198 +86,191 @@ icmp_input(struct pbuf *p, struct netif *inp)
  struct icmp_echo_hdr *iecho;
  const struct ip_hdr *iphdr_in;
  u16_t hlen;
-  const ip4_addr_t *src;
+  const ip4_addr_t* src;

  ICMP_STATS_INC(icmp.recv);
  MIB2_STATS_INC(mib2.icmpinmsgs);

  iphdr_in = ip4_current_header();
-  hlen = IPH_HL_BYTES(iphdr_in);
+  hlen = IPH_HL(iphdr_in) * 4;
  if (hlen < IP_HLEN) {
    LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: short IP header (%"S16_F" bytes) received\n", hlen));
    goto lenerr;
  }
-  if (p->len < sizeof(u16_t) * 2) {
+  if (p->len < sizeof(u16_t)*2) {
    LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: short ICMP (%"U16_F" bytes) received\n", p->tot_len));
    goto lenerr;
  }

  type = *((u8_t *)p->payload);
 #ifdef LWIP_DEBUG
-  code = *(((u8_t *)p->payload) + 1);
-  /* if debug is enabled but debug statement below is somehow disabled: */
-  LWIP_UNUSED_ARG(code);
+  code = *(((u8_t *)p->payload)+1);
 #endif /* LWIP_DEBUG */
  switch (type) {
-    case ICMP_ER:
-      /* This is OK, echo reply might have been parsed by a raw PCB
-         (as obviously, an echo request has been sent, too). */
-      MIB2_STATS_INC(mib2.icmpinechoreps);
-      break;
-    case ICMP_ECHO:
-      MIB2_STATS_INC(mib2.icmpinechos);
-      src = ip4_current_dest_addr();
-      /* multicast destination address? */
-      if (ip4_addr_ismulticast(ip4_current_dest_addr())) {
+  case ICMP_ER:
+    /* This is OK, echo reply might have been parsed by a raw PCB
+       (as obviously, an echo request has been sent, too). */
+    MIB2_STATS_INC(mib2.icmpinechoreps);
+    break;
+  case ICMP_ECHO:
+    MIB2_STATS_INC(mib2.icmpinechos);
+    src = ip4_current_dest_addr();
+    /* multicast destination address? */
+    if (ip4_addr_ismulticast(ip4_current_dest_addr())) {
 #if LWIP_MULTICAST_PING
-        /* For multicast, use address of receiving interface as source address */
-        src = netif_ip4_addr(inp);
+      /* For multicast, use address of receiving interface as source address */
+      src = netif_ip4_addr(inp);
 #else /* LWIP_MULTICAST_PING */
-        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: Not echoing to multicast pings\n"));
-        goto icmperr;
+      LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: Not echoing to multicast pings\n"));
+      goto icmperr;
 #endif /* LWIP_MULTICAST_PING */
-      }
-      /* broadcast destination address? */
-      if (ip4_addr_isbroadcast(ip4_current_dest_addr(), ip_current_netif())) {
+    }
+    /* broadcast destination address? */
+    if (ip4_addr_isbroadcast(ip4_current_dest_addr(), ip_current_netif())) {
 #if LWIP_BROADCAST_PING
-        /* For broadcast, use address of receiving interface as source address */
-        src = netif_ip4_addr(inp);
+      /* For broadcast, use address of receiving interface as source address */
+      src = netif_ip4_addr(inp);
 #else /* LWIP_BROADCAST_PING */
-        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: Not echoing to broadcast pings\n"));
-        goto icmperr;
+      LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: Not echoing to broadcast pings\n"));
+      goto icmperr;
 #endif /* LWIP_BROADCAST_PING */
-      }
-      LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ping\n"));
-      if (p->tot_len < sizeof(struct icmp_echo_hdr)) {
-        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: bad ICMP echo received\n"));
-        goto lenerr;
-      }
+    }
+    LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ping\n"));
+    if (p->tot_len < sizeof(struct icmp_echo_hdr)) {
+      LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: bad ICMP echo received\n"));
+      goto lenerr;
+    }
 #if CHECKSUM_CHECK_ICMP
-      IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_CHECK_ICMP) {
-        if (inet_chksum_pbuf(p) != 0) {
-          LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: checksum failed for received ICMP echo\n"));
-          pbuf_free(p);
-          ICMP_STATS_INC(icmp.chkerr);
-          MIB2_STATS_INC(mib2.icmpinerrors);
-          return;
-        }
+    IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_CHECK_ICMP) {
+      if (inet_chksum_pbuf(p) != 0) {
+        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: checksum failed for received ICMP echo\n"));
+        pbuf_free(p);
+        ICMP_STATS_INC(icmp.chkerr);
+        MIB2_STATS_INC(mib2.icmpinerrors);
+        return;
      }
+    }
 #endif
 #if LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN
-      if (pbuf_add_header(p, hlen + PBUF_LINK_HLEN + PBUF_LINK_ENCAPSULATION_HLEN)) {
-        /* p is not big enough to contain link headers
-         * allocate a new one and copy p into it
-         */
-        struct pbuf *r;
-        u16_t alloc_len = (u16_t)(p->tot_len + hlen);
-        if (alloc_len < p->tot_len) {
-          LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: allocating new pbuf failed (tot_len overflow)\n"));
-          goto icmperr;
-        }
-        /* allocate new packet buffer with space for link headers */
-        r = pbuf_alloc(PBUF_LINK, alloc_len, PBUF_RAM);
-        if (r == NULL) {
-          LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: allocating new pbuf failed\n"));
-          goto icmperr;
-        }
-        if (r->len < hlen + sizeof(struct icmp_echo_hdr)) {
-          LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("first pbuf cannot hold the ICMP header"));
-          pbuf_free(r);
-          goto icmperr;
-        }
-        /* copy the ip header */
-        MEMCPY(r->payload, iphdr_in, hlen);
-        /* switch r->payload back to icmp header (cannot fail) */
-        if (pbuf_remove_header(r, hlen)) {
-          LWIP_ASSERT("icmp_input: moving r->payload to icmp header failed\n", 0);
-          pbuf_free(r);
-          goto icmperr;
-        }
-        /* copy the rest of the packet without ip header */
-        if (pbuf_copy(r, p) != ERR_OK) {
-          LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("icmp_input: copying to new pbuf failed"));
-          pbuf_free(r);
-          goto icmperr;
-        }
-        /* free the original p */
-        pbuf_free(p);
-        /* we now have an identical copy of p that has room for link headers */
-        p = r;
-      } else {
-        /* restore p->payload to point to icmp header (cannot fail) */
-        if (pbuf_remove_header(p, hlen + PBUF_LINK_HLEN + PBUF_LINK_ENCAPSULATION_HLEN)) {
-          LWIP_ASSERT("icmp_input: restoring original p->payload failed\n", 0);
-          goto icmperr;
+    if (pbuf_header(p, (s16_t)(hlen + PBUF_LINK_HLEN + PBUF_LINK_ENCAPSULATION_HLEN))) {
+      /* p is not big enough to contain link headers
+       * allocate a new one and copy p into it
+       */
+      struct pbuf *r;
+      /* allocate new packet buffer with space for link headers */
+      r = pbuf_alloc(PBUF_LINK, p->tot_len + hlen, PBUF_RAM);
+      if (r == NULL) {
+        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: allocating new pbuf failed\n"));
+        goto icmperr;
+      }
+      if (r->len < hlen + sizeof(struct icmp_echo_hdr)) {
+        LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("first pbuf cannot hold the ICMP header"));
+        pbuf_free(r);
+        goto icmperr;
+      }
+      /* copy the ip header */
+      MEMCPY(r->payload, iphdr_in, hlen);
+      /* switch r->payload back to icmp header (cannot fail) */
+      if (pbuf_header(r, (s16_t)-hlen)) {
+        LWIP_ASSERT("icmp_input: moving r->payload to icmp header failed\n", 0);
+        pbuf_free(r);
+        goto icmperr;
+      }
+      /* copy the rest of the packet without ip header */
+      if (pbuf_copy(r, p) != ERR_OK) {
+        LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("icmp_input: copying to new pbuf failed"));
+        pbuf_free(r);
+        goto icmperr;
+      }
+      /* free the original p */
+      pbuf_free(p);
+      /* we now have an identical copy of p that has room for link headers */
+      p = r;
+    } else {
+      /* restore p->payload to point to icmp header (cannot fail) */
+      if (pbuf_header(p, -(s16_t)(hlen + PBUF_LINK_HLEN + PBUF_LINK_ENCAPSULATION_HLEN))) {
+        LWIP_ASSERT("icmp_input: restoring original p->payload failed\n", 0);
+        goto icmperr;
+      }
+    }
+#endif /* LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN */
+    /* At this point, all checks are OK. */
+    /* We generate an answer by switching the dest and src ip addresses,
+     * setting the icmp type to ECHO_RESPONSE and updating the checksum. */
+    iecho = (struct icmp_echo_hdr *)p->payload;
+    if (pbuf_header(p, (s16_t)hlen)) {
+      LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("Can't move over header in packet"));
+    } else {
+      err_t ret;
+      struct ip_hdr *iphdr = (struct ip_hdr*)p->payload;
+      ip4_addr_copy(iphdr->src, *src);
+      ip4_addr_copy(iphdr->dest, *ip4_current_src_addr());
+      ICMPH_TYPE_SET(iecho, ICMP_ER);
+#if CHECKSUM_GEN_ICMP
+      IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_GEN_ICMP) {
+        /* adjust the checksum */
+        if (iecho->chksum > PP_HTONS(0xffffU - (ICMP_ECHO << 8))) {
+          iecho->chksum += PP_HTONS(ICMP_ECHO << 8) + 1;
+        } else {
+          iecho->chksum += PP_HTONS(ICMP_ECHO << 8);
        }
      }
-#endif /* LWIP_ICMP_ECHO_CHECK_INPUT_PBUF_LEN */
-      /* At this point, all checks are OK. */
-      /* We generate an answer by switching the dest and src ip addresses,
-       * setting the icmp type to ECHO_RESPONSE and updating the checksum. */
-      iecho = (struct icmp_echo_hdr *)p->payload;
-      if (pbuf_add_header(p, hlen)) {
-        LWIP_DEBUGF(ICMP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("Can't move over header in packet"));
-      } else {
-        err_t ret;
-        struct ip_hdr *iphdr = (struct ip_hdr *)p->payload;
-        ip4_addr_copy(iphdr->src, *src);
-        ip4_addr_copy(iphdr->dest, *ip4_current_src_addr());
-        ICMPH_TYPE_SET(iecho, ICMP_ER);
-#if CHECKSUM_GEN_ICMP
-        IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_GEN_ICMP) {
-          /* adjust the checksum */
-          if (iecho->chksum > PP_HTONS(0xffffU - (ICMP_ECHO << 8))) {
-            iecho->chksum = (u16_t)(iecho->chksum + PP_HTONS((u16_t)(ICMP_ECHO << 8)) + 1);
-          } else {
-            iecho->chksum = (u16_t)(iecho->chksum + PP_HTONS(ICMP_ECHO << 8));
-          }
-        }
 #if LWIP_CHECKSUM_CTRL_PER_NETIF
-        else {
-          iecho->chksum = 0;
-        }
+      else {
+        iecho->chksum = 0;
+      }
 #endif /* LWIP_CHECKSUM_CTRL_PER_NETIF */
 #else /* CHECKSUM_GEN_ICMP */
-        iecho->chksum = 0;
+      iecho->chksum = 0;
 #endif /* CHECKSUM_GEN_ICMP */

-        /* Set the correct TTL and recalculate the header checksum. */
-        IPH_TTL_SET(iphdr, ICMP_TTL);
-        IPH_CHKSUM_SET(iphdr, 0);
+      /* Set the correct TTL and recalculate the header checksum. */
+      IPH_TTL_SET(iphdr, ICMP_TTL);
+      IPH_CHKSUM_SET(iphdr, 0);
 #if CHECKSUM_GEN_IP
-        IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_GEN_IP) {
-          IPH_CHKSUM_SET(iphdr, inet_chksum(iphdr, hlen));
-        }
+      IF__NETIF_CHECKSUM_ENABLED(inp, NETIF_CHECKSUM_GEN_IP) {
+        IPH_CHKSUM_SET(iphdr, inet_chksum(iphdr, hlen));
+      }
 #endif /* CHECKSUM_GEN_IP */

-        ICMP_STATS_INC(icmp.xmit);
-        /* increase number of messages attempted to send */
-        MIB2_STATS_INC(mib2.icmpoutmsgs);
-        /* increase number of echo replies attempted to send */
-        MIB2_STATS_INC(mib2.icmpoutechoreps);
+      ICMP_STATS_INC(icmp.xmit);
+      /* increase number of messages attempted to send */
+      MIB2_STATS_INC(mib2.icmpoutmsgs);
+      /* increase number of echo replies attempted to send */
+      MIB2_STATS_INC(mib2.icmpoutechoreps);

-        /* send an ICMP packet */
-        ret = ip4_output_if(p, src, LWIP_IP_HDRINCL,
-                            ICMP_TTL, 0, IP_PROTO_ICMP, inp);
-        if (ret != ERR_OK) {
-          LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ip_output_if returned an error: %s\n", lwip_strerr(ret)));
-        }
+      /* send an ICMP packet */
+      ret = ip4_output_if(p, src, LWIP_IP_HDRINCL,
+                   ICMP_TTL, 0, IP_PROTO_ICMP, inp);
+      if (ret != ERR_OK) {
+        LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ip_output_if returned an error: %s\n", lwip_strerr(ret)));
      }
-      break;
-    default:
-      if (type == ICMP_DUR) {
-        MIB2_STATS_INC(mib2.icmpindestunreachs);
-      } else if (type == ICMP_TE) {
-        MIB2_STATS_INC(mib2.icmpintimeexcds);
-      } else if (type == ICMP_PP) {
-        MIB2_STATS_INC(mib2.icmpinparmprobs);
-      } else if (type == ICMP_SQ) {
-        MIB2_STATS_INC(mib2.icmpinsrcquenchs);
-      } else if (type == ICMP_RD) {
-        MIB2_STATS_INC(mib2.icmpinredirects);
-      } else if (type == ICMP_TS) {
-        MIB2_STATS_INC(mib2.icmpintimestamps);
-      } else if (type == ICMP_TSR) {
-        MIB2_STATS_INC(mib2.icmpintimestampreps);
-      } else if (type == ICMP_AM) {
-        MIB2_STATS_INC(mib2.icmpinaddrmasks);
-      } else if (type == ICMP_AMR) {
-        MIB2_STATS_INC(mib2.icmpinaddrmaskreps);
-      }
-      LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ICMP type %"S16_F" code %"S16_F" not supported.\n",
-                               (s16_t)type, (s16_t)code));
-      ICMP_STATS_INC(icmp.proterr);
-      ICMP_STATS_INC(icmp.drop);
+    }
+    break;
+  default:
+    if (type == ICMP_DUR) {
+      MIB2_STATS_INC(mib2.icmpindestunreachs);
+    } else if (type == ICMP_TE) {
+      MIB2_STATS_INC(mib2.icmpintimeexcds);
+    } else if (type == ICMP_PP) {
+      MIB2_STATS_INC(mib2.icmpinparmprobs);
+    } else if (type == ICMP_SQ) {
+      MIB2_STATS_INC(mib2.icmpinsrcquenchs);
+    } else if (type == ICMP_RD) {
+      MIB2_STATS_INC(mib2.icmpinredirects);
+    } else if (type == ICMP_TS) {
+      MIB2_STATS_INC(mib2.icmpintimestamps);
+    } else if (type == ICMP_TSR) {
+      MIB2_STATS_INC(mib2.icmpintimestampreps);
+    } else if (type == ICMP_AM) {
+      MIB2_STATS_INC(mib2.icmpinaddrmasks);
+    } else if (type == ICMP_AMR) {
+      MIB2_STATS_INC(mib2.icmpinaddrmaskreps);
+    }
+    LWIP_DEBUGF(ICMP_DEBUG, ("icmp_input: ICMP type %"S16_F" code %"S16_F" not supported.\n",
+                (s16_t)type, (s16_t)code));
+    ICMP_STATS_INC(icmp.proterr);
+    ICMP_STATS_INC(icmp.drop);
  }
  pbuf_free(p);
  return;
@@ -358,7 +351,7 @@ icmp_send_response(struct pbuf *p, u8_t type, u8_t code)
    return;
  }
  LWIP_ASSERT("check that first pbuf can hold icmp message",
-              (q->len >= (sizeof(struct icmp_echo_hdr) + IP_HLEN + ICMP_DEST_UNREACH_DATASIZE)));
+             (q->len >= (sizeof(struct icmp_echo_hdr) + IP_HLEN + ICMP_DEST_UNREACH_DATASIZE)));

  iphdr = (struct ip_hdr *)p->payload;
  LWIP_DEBUGF(ICMP_DEBUG, ("icmp_time_exceeded from "));
@@ -382,7 +375,7 @@ icmp_send_response(struct pbuf *p, u8_t type, u8_t code)
  {
    ip4_addr_t iphdr_dst;
    ip4_addr_copy(iphdr_dst, iphdr->dest);
-    netif = ip4_route_src(&iphdr_dst, &iphdr_src);
+    netif = ip4_route_src(&iphdr_src, &iphdr_dst);
  }
 #else
  netif = ip4_route(&iphdr_src);
--- a/src/core/ipv4/igmp.c
+++ b/src/core/ipv4/igmp.c
@@ -94,10 +94,10 @@ Steve Reynolds
 #include "lwip/stats.h"
 #include "lwip/prot/igmp.h"

-#include <string.h>
+#include "string.h"

 static struct igmp_group *igmp_lookup_group(struct netif *ifp, const ip4_addr_t *addr);
-static err_t  igmp_remove_group(struct netif *netif, struct igmp_group *group);
+static err_t  igmp_remove_group(struct netif* netif, struct igmp_group *group);
 static void   igmp_timeout(struct netif *netif, struct igmp_group *group);
 static void   igmp_start_timer(struct igmp_group *group, u8_t max_time);
 static void   igmp_delaying_member(struct igmp_group *group, u8_t maxresp);
@@ -127,9 +127,9 @@ igmp_init(void)
 err_t
 igmp_start(struct netif *netif)
 {
-  struct igmp_group *group;
+  struct igmp_group* group;

-  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_start: starting IGMP processing on if %p\n", (void *)netif));
+  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_start: starting IGMP processing on if %p\n", (void*)netif));

  group = igmp_lookup_group(netif, &allsystems);

@@ -141,7 +141,7 @@ igmp_start(struct netif *netif)
    if (netif->igmp_mac_filter != NULL) {
      LWIP_DEBUGF(IGMP_DEBUG, ("igmp_start: igmp_mac_filter(ADD "));
      ip4_addr_debug_print_val(IGMP_DEBUG, allsystems);
-      LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void *)netif));
+      LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void*)netif));
      netif->igmp_mac_filter(netif, &allsystems, NETIF_ADD_MAC_FILTER);
    }

@@ -169,8 +169,8 @@ igmp_stop(struct netif *netif)
    /* disable the group at the MAC level */
    if (netif->igmp_mac_filter != NULL) {
      LWIP_DEBUGF(IGMP_DEBUG, ("igmp_stop: igmp_mac_filter(DEL "));
-      ip4_addr_debug_print_val(IGMP_DEBUG, group->group_address);
-      LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void *)netif));
+      ip4_addr_debug_print(IGMP_DEBUG, &group->group_address);
+      LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void*)netif));
      netif->igmp_mac_filter(netif, &(group->group_address), NETIF_DEL_MAC_FILTER);
    }

@@ -193,13 +193,13 @@ igmp_report_groups(struct netif *netif)
 {
  struct igmp_group *group = netif_igmp_data(netif);

-  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_report_groups: sending IGMP reports on if %p\n", (void *)netif));
+  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_report_groups: sending IGMP reports on if %p\n", (void*)netif));

  /* Skip the first group in the list, it is always the allsystems group added in igmp_start() */
-  if (group != NULL) {
+  if(group != NULL) {
    group = group->next;
  }
-
+  
  while (group != NULL) {
    igmp_delaying_member(group, IGMP_JOIN_DELAYING_MEMBER_TMR);
    group = group->next;
@@ -207,7 +207,7 @@ igmp_report_groups(struct netif *netif)
 }

 /**
- * Search for a group in the netif's igmp group list
+ * Search for a group in the global igmp_group_list
 *
 * @param ifp the network interface for which to look
 * @param addr the group ip address to search for
@@ -252,7 +252,7 @@ igmp_lookup_group(struct netif *ifp, const ip4_addr_t *addr)
    /* Group already exists. */
    return group;
  }
-
+  
  /* Group doesn't exist yet, create a new one */
  group = (struct igmp_group *)memp_malloc(MEMP_IGMP_GROUP);
  if (group != NULL) {
@@ -262,37 +262,37 @@ igmp_lookup_group(struct netif *ifp, const ip4_addr_t *addr)
    group->last_reporter_flag = 0;
    group->use                = 0;

-    /* Ensure allsystems group is always first in list */
+    /* Ensure allsystems group is always first in list */    
    if (list_head == NULL) {
      /* this is the first entry in linked list */
      LWIP_ASSERT("igmp_lookup_group: first group must be allsystems",
-                  (ip4_addr_cmp(addr, &allsystems) != 0));
+        (ip4_addr_cmp(addr, &allsystems) != 0));
      group->next = NULL;
      netif_set_client_data(ifp, LWIP_NETIF_CLIENT_DATA_INDEX_IGMP, group);
    } else {
      /* append _after_ first entry */
      LWIP_ASSERT("igmp_lookup_group: all except first group must not be allsystems",
-                  (ip4_addr_cmp(addr, &allsystems) == 0));
+        (ip4_addr_cmp(addr, &allsystems) == 0));
      group->next = list_head->next;
      list_head->next = group;
    }
  }

-  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_lookup_group: %sallocated a new group with address ", (group ? "" : "impossible to ")));
+  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_lookup_group: %sallocated a new group with address ", (group?"":"impossible to ")));
  ip4_addr_debug_print(IGMP_DEBUG, addr);
-  LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void *)ifp));
+  LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void*)ifp));

  return group;
 }

 /**
- * Remove a group from netif's igmp group list, but don't free it yet
+ * Remove a group in the global igmp_group_list, but don't free it yet
 *
- * @param group the group to remove from the netif's igmp group list
+ * @param group the group to remove from the global igmp_group_list
 * @return ERR_OK if group was removed from the list, an err_t otherwise
 */
 static err_t
-igmp_remove_group(struct netif *netif, struct igmp_group *group)
+igmp_remove_group(struct netif* netif, struct igmp_group *group)
 {
  err_t err = ERR_OK;
  struct igmp_group *tmp_group;
@@ -304,7 +304,7 @@ igmp_remove_group(struct netif *netif, struct igmp_group *group)
      break;
    }
  }
-  /* Group not found in netif's igmp group list */
+  /* Group not found in the global igmp_group_list */
  if (tmp_group == NULL) {
    err = ERR_ARG;
  }
@@ -322,9 +322,9 @@ igmp_remove_group(struct netif *netif, struct igmp_group *group)
 void
 igmp_input(struct pbuf *p, struct netif *inp, const ip4_addr_t *dest)
 {
-  struct igmp_msg   *igmp;
-  struct igmp_group *group;
-  struct igmp_group *groupref;
+  struct igmp_msg*   igmp;
+  struct igmp_group* group;
+  struct igmp_group* groupref;

  IGMP_STATS_INC(igmp.recv);

@@ -337,10 +337,10 @@ igmp_input(struct pbuf *p, struct netif *inp, const ip4_addr_t *dest)
  }

  LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: message from "));
-  ip4_addr_debug_print_val(IGMP_DEBUG, ip4_current_header()->src);
+  ip4_addr_debug_print(IGMP_DEBUG, &(ip4_current_header()->src));
  LWIP_DEBUGF(IGMP_DEBUG, (" to address "));
-  ip4_addr_debug_print_val(IGMP_DEBUG, ip4_current_header()->dest);
-  LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void *)inp));
+  ip4_addr_debug_print(IGMP_DEBUG, &(ip4_current_header()->dest));
+  LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void*)inp));

  /* Now calculate and check the checksum */
  igmp = (struct igmp_msg *)p->payload;
@@ -364,73 +364,73 @@ igmp_input(struct pbuf *p, struct netif *inp, const ip4_addr_t *dest)

  /* NOW ACT ON THE INCOMING MESSAGE TYPE... */
  switch (igmp->igmp_msgtype) {
-    case IGMP_MEMB_QUERY:
-      /* IGMP_MEMB_QUERY to the "all systems" address ? */
-      if ((ip4_addr_cmp(dest, &allsystems)) && ip4_addr_isany(&igmp->igmp_group_address)) {
-        /* THIS IS THE GENERAL QUERY */
-        LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: General IGMP_MEMB_QUERY on \"ALL SYSTEMS\" address (224.0.0.1) [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));
+  case IGMP_MEMB_QUERY:
+    /* IGMP_MEMB_QUERY to the "all systems" address ? */
+    if ((ip4_addr_cmp(dest, &allsystems)) && ip4_addr_isany(&igmp->igmp_group_address)) {
+      /* THIS IS THE GENERAL QUERY */
+      LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: General IGMP_MEMB_QUERY on \"ALL SYSTEMS\" address (224.0.0.1) [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));

-        if (igmp->igmp_maxresp == 0) {
-          IGMP_STATS_INC(igmp.rx_v1);
-          LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: got an all hosts query with time== 0 - this is V1 and not implemented - treat as v2\n"));
-          igmp->igmp_maxresp = IGMP_V1_DELAYING_MEMBER_TMR;
+      if (igmp->igmp_maxresp == 0) {
+        IGMP_STATS_INC(igmp.rx_v1);
+        LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: got an all hosts query with time== 0 - this is V1 and not implemented - treat as v2\n"));
+        igmp->igmp_maxresp = IGMP_V1_DELAYING_MEMBER_TMR;
+      } else {
+        IGMP_STATS_INC(igmp.rx_general);
+      }
+
+      groupref = netif_igmp_data(inp);
+      
+      /* Do not send messages on the all systems group address! */
+      /* Skip the first group in the list, it is always the allsystems group added in igmp_start() */
+      if(groupref != NULL) {
+        groupref = groupref->next;
+      }
+
+      while (groupref) {
+        igmp_delaying_member(groupref, igmp->igmp_maxresp);
+        groupref = groupref->next;
+      }
+    } else {
+      /* IGMP_MEMB_QUERY to a specific group ? */
+      if (!ip4_addr_isany(&igmp->igmp_group_address)) {
+        LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: IGMP_MEMB_QUERY to a specific group "));
+        ip4_addr_debug_print(IGMP_DEBUG, &igmp->igmp_group_address);
+        if (ip4_addr_cmp(dest, &allsystems)) {
+          ip4_addr_t groupaddr;
+          LWIP_DEBUGF(IGMP_DEBUG, (" using \"ALL SYSTEMS\" address (224.0.0.1) [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));
+          /* we first need to re-look for the group since we used dest last time */
+          ip4_addr_copy(groupaddr, igmp->igmp_group_address);
+          group = igmp_lookfor_group(inp, &groupaddr);
        } else {
-          IGMP_STATS_INC(igmp.rx_general);
+          LWIP_DEBUGF(IGMP_DEBUG, (" with the group address as destination [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));
        }

-        groupref = netif_igmp_data(inp);
-
-        /* Do not send messages on the all systems group address! */
-        /* Skip the first group in the list, it is always the allsystems group added in igmp_start() */
-        if (groupref != NULL) {
-          groupref = groupref->next;
-        }
-
-        while (groupref) {
-          igmp_delaying_member(groupref, igmp->igmp_maxresp);
-          groupref = groupref->next;
+        if (group != NULL) {
+          IGMP_STATS_INC(igmp.rx_group);
+          igmp_delaying_member(group, igmp->igmp_maxresp);
+        } else {
+          IGMP_STATS_INC(igmp.drop);
        }
      } else {
-        /* IGMP_MEMB_QUERY to a specific group ? */
-        if (!ip4_addr_isany(&igmp->igmp_group_address)) {
-          LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: IGMP_MEMB_QUERY to a specific group "));
-          ip4_addr_debug_print_val(IGMP_DEBUG, igmp->igmp_group_address);
-          if (ip4_addr_cmp(dest, &allsystems)) {
-            ip4_addr_t groupaddr;
-            LWIP_DEBUGF(IGMP_DEBUG, (" using \"ALL SYSTEMS\" address (224.0.0.1) [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));
-            /* we first need to re-look for the group since we used dest last time */
-            ip4_addr_copy(groupaddr, igmp->igmp_group_address);
-            group = igmp_lookfor_group(inp, &groupaddr);
-          } else {
-            LWIP_DEBUGF(IGMP_DEBUG, (" with the group address as destination [igmp_maxresp=%i]\n", (int)(igmp->igmp_maxresp)));
-          }
-
-          if (group != NULL) {
-            IGMP_STATS_INC(igmp.rx_group);
-            igmp_delaying_member(group, igmp->igmp_maxresp);
-          } else {
-            IGMP_STATS_INC(igmp.drop);
-          }
-        } else {
-          IGMP_STATS_INC(igmp.proterr);
-        }
+        IGMP_STATS_INC(igmp.proterr);
      }
-      break;
-    case IGMP_V2_MEMB_REPORT:
-      LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: IGMP_V2_MEMB_REPORT\n"));
-      IGMP_STATS_INC(igmp.rx_report);
-      if (group->group_state == IGMP_GROUP_DELAYING_MEMBER) {
-        /* This is on a specific group we have already looked up */
-        group->timer = 0; /* stopped */
-        group->group_state = IGMP_GROUP_IDLE_MEMBER;
-        group->last_reporter_flag = 0;
-      }
-      break;
-    default:
-      LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: unexpected msg %d in state %d on group %p on if %p\n",
-                               igmp->igmp_msgtype, group->group_state, (void *)&group, (void *)inp));
-      IGMP_STATS_INC(igmp.proterr);
-      break;
+    }
+    break;
+  case IGMP_V2_MEMB_REPORT:
+    LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: IGMP_V2_MEMB_REPORT\n"));
+    IGMP_STATS_INC(igmp.rx_report);
+    if (group->group_state == IGMP_GROUP_DELAYING_MEMBER) {
+      /* This is on a specific group we have already looked up */
+      group->timer = 0; /* stopped */
+      group->group_state = IGMP_GROUP_IDLE_MEMBER;
+      group->last_reporter_flag = 0;
+    }
+    break;
+  default:
+    LWIP_DEBUGF(IGMP_DEBUG, ("igmp_input: unexpected msg %d in state %d on group %p on if %p\n",
+      igmp->igmp_msgtype, group->group_state, (void*)&group, (void*)inp));
+    IGMP_STATS_INC(igmp.proterr);
+    break;
  }

  pbuf_free(p);
@@ -451,14 +451,13 @@ igmp_joingroup(const ip4_addr_t *ifaddr, const ip4_addr_t *groupaddr)
  err_t err = ERR_VAL; /* no matching interface */
  struct netif *netif;

-  LWIP_ASSERT_CORE_LOCKED();
-
  /* make sure it is multicast address */
  LWIP_ERROR("igmp_joingroup: attempt to join non-multicast address", ip4_addr_ismulticast(groupaddr), return ERR_VAL;);
  LWIP_ERROR("igmp_joingroup: attempt to join allsystems address", (!ip4_addr_cmp(groupaddr, &allsystems)), return ERR_VAL;);

  /* loop through netif's */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    /* Should we join this interface ? */
    if ((netif->flags & NETIF_FLAG_IGMP) && ((ip4_addr_isany(ifaddr) || ip4_addr_cmp(netif_ip4_addr(netif), ifaddr)))) {
      err = igmp_joingroup_netif(netif, groupaddr);
@@ -468,6 +467,8 @@ igmp_joingroup(const ip4_addr_t *ifaddr, const ip4_addr_t *groupaddr)
        return err;
      }
    }
+    /* proceed to next network interface */
+    netif = netif->next;
  }

  return err;
@@ -486,8 +487,6 @@ igmp_joingroup_netif(struct netif *netif, const ip4_addr_t *groupaddr)
 {
  struct igmp_group *group;

-  LWIP_ASSERT_CORE_LOCKED();
-
  /* make sure it is multicast address */
  LWIP_ERROR("igmp_joingroup_netif: attempt to join non-multicast address", ip4_addr_ismulticast(groupaddr), return ERR_VAL;);
  LWIP_ERROR("igmp_joingroup_netif: attempt to join allsystems address", (!ip4_addr_cmp(groupaddr, &allsystems)), return ERR_VAL;);
@@ -509,10 +508,10 @@ igmp_joingroup_netif(struct netif *netif, const ip4_addr_t *groupaddr)
      LWIP_DEBUGF(IGMP_DEBUG, ("\n"));

      /* If first use of the group, allow the group at the MAC level */
-      if ((group->use == 0) && (netif->igmp_mac_filter != NULL)) {
+      if ((group->use==0) && (netif->igmp_mac_filter != NULL)) {
        LWIP_DEBUGF(IGMP_DEBUG, ("igmp_joingroup_netif: igmp_mac_filter(ADD "));
        ip4_addr_debug_print(IGMP_DEBUG, groupaddr);
-        LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void *)netif));
+        LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void*)netif));
        netif->igmp_mac_filter(netif, groupaddr, NETIF_ADD_MAC_FILTER);
      }

@@ -548,14 +547,13 @@ igmp_leavegroup(const ip4_addr_t *ifaddr, const ip4_addr_t *groupaddr)
  err_t err = ERR_VAL; /* no matching interface */
  struct netif *netif;

-  LWIP_ASSERT_CORE_LOCKED();
-
  /* make sure it is multicast address */
  LWIP_ERROR("igmp_leavegroup: attempt to leave non-multicast address", ip4_addr_ismulticast(groupaddr), return ERR_VAL;);
  LWIP_ERROR("igmp_leavegroup: attempt to leave allsystems address", (!ip4_addr_cmp(groupaddr, &allsystems)), return ERR_VAL;);

  /* loop through netif's */
-  NETIF_FOREACH(netif) {
+  netif = netif_list;
+  while (netif != NULL) {
    /* Should we leave this interface ? */
    if ((netif->flags & NETIF_FLAG_IGMP) && ((ip4_addr_isany(ifaddr) || ip4_addr_cmp(netif_ip4_addr(netif), ifaddr)))) {
      err_t res = igmp_leavegroup_netif(netif, groupaddr);
@@ -564,6 +562,8 @@ igmp_leavegroup(const ip4_addr_t *ifaddr, const ip4_addr_t *groupaddr)
        err = res;
      }
    }
+    /* proceed to next network interface */
+    netif = netif->next;
  }

  return err;
@@ -582,8 +582,6 @@ igmp_leavegroup_netif(struct netif *netif, const ip4_addr_t *groupaddr)
 {
  struct igmp_group *group;

-  LWIP_ASSERT_CORE_LOCKED();
-
  /* make sure it is multicast address */
  LWIP_ERROR("igmp_leavegroup_netif: attempt to leave non-multicast address", ip4_addr_ismulticast(groupaddr), return ERR_VAL;);
  LWIP_ERROR("igmp_leavegroup_netif: attempt to leave allsystems address", (!ip4_addr_cmp(groupaddr, &allsystems)), return ERR_VAL;);
@@ -616,7 +614,7 @@ igmp_leavegroup_netif(struct netif *netif, const ip4_addr_t *groupaddr)
      if (netif->igmp_mac_filter != NULL) {
        LWIP_DEBUGF(IGMP_DEBUG, ("igmp_leavegroup_netif: igmp_mac_filter(DEL "));
        ip4_addr_debug_print(IGMP_DEBUG, groupaddr);
-        LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void *)netif));
+        LWIP_DEBUGF(IGMP_DEBUG, (") on if %p\n", (void*)netif));
        netif->igmp_mac_filter(netif, groupaddr, NETIF_DEL_MAC_FILTER);
      }

@@ -640,9 +638,9 @@ igmp_leavegroup_netif(struct netif *netif, const ip4_addr_t *groupaddr)
 void
 igmp_tmr(void)
 {
-  struct netif *netif;
+  struct netif *netif = netif_list;

-  NETIF_FOREACH(netif) {
+  while (netif != NULL) {
    struct igmp_group *group = netif_igmp_data(netif);

    while (group != NULL) {
@@ -654,6 +652,7 @@ igmp_tmr(void)
      }
      group = group->next;
    }
+    netif = netif->next;
  }
 }

@@ -671,11 +670,11 @@ igmp_timeout(struct netif *netif, struct igmp_group *group)
  if ((group->group_state == IGMP_GROUP_DELAYING_MEMBER) &&
      (!(ip4_addr_cmp(&(group->group_address), &allsystems)))) {
    LWIP_DEBUGF(IGMP_DEBUG, ("igmp_timeout: report membership for group with address "));
-    ip4_addr_debug_print_val(IGMP_DEBUG, group->group_address);
-    LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void *)netif));
+    ip4_addr_debug_print(IGMP_DEBUG, &(group->group_address));
+    LWIP_DEBUGF(IGMP_DEBUG, (" on if %p\n", (void*)netif));

    group->group_state = IGMP_GROUP_IDLE_MEMBER;
-
+    
    IGMP_STATS_INC(igmp.tx_report);
    igmp_send(netif, group, IGMP_V2_MEMB_REPORT);
  }
@@ -692,7 +691,7 @@ static void
 igmp_start_timer(struct igmp_group *group, u8_t max_time)
 {
 #ifdef LWIP_RAND
-  group->timer = (u16_t)(max_time > 2 ? (LWIP_RAND() % max_time) : 1);
+  group->timer = max_time > 2 ? (LWIP_RAND() % max_time) : 1;
 #else /* LWIP_RAND */
  /* ATTENTION: use this only if absolutely necessary! */
  group->timer = max_time / 2;
@@ -713,8 +712,8 @@ static void
 igmp_delaying_member(struct igmp_group *group, u8_t maxresp)
 {
  if ((group->group_state == IGMP_GROUP_IDLE_MEMBER) ||
-      ((group->group_state == IGMP_GROUP_DELAYING_MEMBER) &&
-       ((group->timer == 0) || (maxresp < group->timer)))) {
+     ((group->group_state == IGMP_GROUP_DELAYING_MEMBER) &&
+      ((group->timer == 0) || (maxresp < group->timer)))) {
    igmp_start_timer(group, maxresp);
    group->group_state = IGMP_GROUP_DELAYING_MEMBER;
  }
@@ -757,10 +756,10 @@ igmp_ip_output_if(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 static void
 igmp_send(struct netif *netif, struct igmp_group *group, u8_t type)
 {
-  struct pbuf     *p    = NULL;
-  struct igmp_msg *igmp = NULL;
+  struct pbuf*     p    = NULL;
+  struct igmp_msg* igmp = NULL;
  ip4_addr_t   src  = *IP4_ADDR_ANY4;
-  ip4_addr_t  *dest = NULL;
+  ip4_addr_t*  dest = NULL;

  /* IP header + "router alert" option + IGMP header */
  p = pbuf_alloc(PBUF_TRANSPORT, IGMP_MINLEN, PBUF_RAM);
@@ -768,7 +767,7 @@ igmp_send(struct netif *netif, struct igmp_group *group, u8_t type)
  if (p) {
    igmp = (struct igmp_msg *)p->payload;
    LWIP_ASSERT("igmp_send: check that first pbuf can hold struct igmp_msg",
-                (p->len >= sizeof(struct igmp_msg)));
+               (p->len >= sizeof(struct igmp_msg)));
    ip4_addr_copy(src, *netif_ip4_addr(netif));

    if (type == IGMP_V2_MEMB_REPORT) {
--- a/src/core/ipv4/ip4.c
+++ b/src/core/ipv4/ip4.c
@@ -50,12 +50,12 @@
 #include "lwip/netif.h"
 #include "lwip/icmp.h"
 #include "lwip/igmp.h"
-#include "lwip/priv/raw_priv.h"
+#include "lwip/raw.h"
 #include "lwip/udp.h"
 #include "lwip/priv/tcp_priv.h"
 #include "lwip/autoip.h"
 #include "lwip/stats.h"
-#include "lwip/prot/iana.h"
+#include "lwip/prot/dhcp.h"

 #include <string.h>

@@ -89,14 +89,14 @@
 */
 #if LWIP_DHCP && defined(LWIP_IP_ACCEPT_UDP_PORT)
 /* accept DHCP client port and custom port */
-#define IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(port) (((port) == PP_NTOHS(LWIP_IANA_PORT_DHCP_CLIENT)) \
+#define IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(port) (((port) == PP_NTOHS(DHCP_CLIENT_PORT)) \
         || (LWIP_IP_ACCEPT_UDP_PORT(port)))
 #elif defined(LWIP_IP_ACCEPT_UDP_PORT) /* LWIP_DHCP && defined(LWIP_IP_ACCEPT_UDP_PORT) */
 /* accept custom port only */
 #define IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(port) (LWIP_IP_ACCEPT_UDP_PORT(port))
 #else /* LWIP_DHCP && defined(LWIP_IP_ACCEPT_UDP_PORT) */
 /* accept DHCP client port only */
-#define IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(port) ((port) == PP_NTOHS(LWIP_IANA_PORT_DHCP_CLIENT))
+#define IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(port) ((port) == PP_NTOHS(DHCP_CLIENT_PORT))
 #endif /* LWIP_DHCP && defined(LWIP_IP_ACCEPT_UDP_PORT) */

 #else /* LWIP_DHCP */
@@ -108,13 +108,13 @@ static u16_t ip_id;

 #if LWIP_MULTICAST_TX_OPTIONS
 /** The default netif used for multicast */
-static struct netif *ip4_default_multicast_netif;
+static struct netif* ip4_default_multicast_netif;

 /**
 * @ingroup ip4
 * Set a default netif for IPv4 multicast. */
 void
-ip4_set_default_multicast_netif(struct netif *default_multicast_netif)
+ip4_set_default_multicast_netif(struct netif* default_multicast_netif)
 {
  ip4_default_multicast_netif = default_multicast_netif;
 }
@@ -123,14 +123,14 @@ ip4_set_default_multicast_netif(struct netif *default_multicast_netif)
 #ifdef LWIP_HOOK_IP4_ROUTE_SRC
 /**
 * Source based IPv4 routing must be fully implemented in
- * LWIP_HOOK_IP4_ROUTE_SRC(). This function only provides the parameters.
+ * LWIP_HOOK_IP4_ROUTE_SRC(). This function only provides he parameters.
 */
 struct netif *
-ip4_route_src(const ip4_addr_t *src, const ip4_addr_t *dest)
+ip4_route_src(const ip4_addr_t *dest, const ip4_addr_t *src)
 {
  if (src != NULL) {
    /* when src==NULL, the hook is called from ip4_route(dest) */
-    struct netif *netif = LWIP_HOOK_IP4_ROUTE_SRC(src, dest);
+    struct netif *netif = LWIP_HOOK_IP4_ROUTE_SRC(dest, src);
    if (netif != NULL) {
      return netif;
    }
@@ -151,11 +151,8 @@ ip4_route_src(const ip4_addr_t *src, const ip4_addr_t *dest)
 struct netif *
 ip4_route(const ip4_addr_t *dest)
 {
-#if !LWIP_SINGLE_NETIF
  struct netif *netif;

-  LWIP_ASSERT_CORE_LOCKED();
-
 #if LWIP_MULTICAST_TX_OPTIONS
  /* Use administratively selected interface for multicast by default */
  if (ip4_addr_ismulticast(dest) && ip4_default_multicast_netif) {
@@ -163,11 +160,8 @@ ip4_route(const ip4_addr_t *dest)
  }
 #endif /* LWIP_MULTICAST_TX_OPTIONS */

-  /* bug #54569: in case LWIP_SINGLE_NETIF=1 and LWIP_DEBUGF() disabled, the following loop is optimized away */
-  LWIP_UNUSED_ARG(dest);
-
  /* iterate through netifs */
-  NETIF_FOREACH(netif) {
+  for (netif = netif_list; netif != NULL; netif = netif->next) {
    /* is the netif up, does it have a link and a valid address? */
    if (netif_is_up(netif) && netif_is_link_up(netif) && !ip4_addr_isany_val(*netif_ip4_addr(netif))) {
      /* network mask matches? */
@@ -191,7 +185,7 @@ ip4_route(const ip4_addr_t *dest)
      return netif_default;
    }
    /* default netif is not up, just use any netif for loopback traffic */
-    NETIF_FOREACH(netif) {
+    for (netif = netif_list; netif != NULL; netif = netif->next) {
      if (netif_is_up(netif)) {
        return netif;
      }
@@ -201,7 +195,7 @@ ip4_route(const ip4_addr_t *dest)
 #endif /* LWIP_NETIF_LOOPBACK && !LWIP_HAVE_LOOPIF */

 #ifdef LWIP_HOOK_IP4_ROUTE_SRC
-  netif = LWIP_HOOK_IP4_ROUTE_SRC(NULL, dest);
+  netif = LWIP_HOOK_IP4_ROUTE_SRC(dest, NULL);
  if (netif != NULL) {
    return netif;
  }
@@ -211,14 +205,13 @@ ip4_route(const ip4_addr_t *dest)
    return netif;
  }
 #endif
-#endif /* !LWIP_SINGLE_NETIF */

  if ((netif_default == NULL) || !netif_is_up(netif_default) || !netif_is_link_up(netif_default) ||
-      ip4_addr_isany_val(*netif_ip4_addr(netif_default)) || ip4_addr_isloopback(dest)) {
+      ip4_addr_isany_val(*netif_ip4_addr(netif_default))) {
    /* No matching netif found and default netif is not usable.
       If this is not good enough for you, use LWIP_HOOK_IP4_ROUTE() */
    LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("ip4_route: No route to %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
+      ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
    IP_STATS_INC(ip.rterr);
    MIB2_STATS_INC(mib2.ipoutnoroutes);
    return NULL;
@@ -240,19 +233,13 @@ ip4_canforward(struct pbuf *p)
 {
  u32_t addr = lwip_htonl(ip4_addr_get_u32(ip4_current_dest_addr()));

-#ifdef LWIP_HOOK_IP4_CANFORWARD
-  int ret = LWIP_HOOK_IP4_CANFORWARD(p, addr);
-  if (ret >= 0) {
-    return ret;
-  }
-#endif /* LWIP_HOOK_IP4_CANFORWARD */
-
  if (p->flags & PBUF_FLAG_LLBCAST) {
    /* don't route link-layer broadcasts */
    return 0;
  }
-  if ((p->flags & PBUF_FLAG_LLMCAST) || IP_MULTICAST(addr)) {
-    /* don't route link-layer multicasts (use LWIP_HOOK_IP4_CANFORWARD instead) */
+  if ((p->flags & PBUF_FLAG_LLMCAST) && !IP_MULTICAST(addr)) {
+    /* don't route link-layer multicasts unless the destination address is an IP
+       multicast address */
    return 0;
  }
  if (IP_EXPERIMENTAL(addr)) {
@@ -292,17 +279,17 @@ ip4_forward(struct pbuf *p, struct ip_hdr *iphdr, struct netif *inp)
  /* RFC3927 2.7: do not forward link-local addresses */
  if (ip4_addr_islinklocal(ip4_current_dest_addr())) {
    LWIP_DEBUGF(IP_DEBUG, ("ip4_forward: not forwarding LLA %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                           ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
-                           ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));
+      ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
+      ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));
    goto return_noroute;
  }

  /* Find network interface where to forward this IP packet to. */
-  netif = ip4_route_src(ip4_current_src_addr(), ip4_current_dest_addr());
+  netif = ip4_route_src(ip4_current_dest_addr(), ip4_current_src_addr());
  if (netif == NULL) {
    LWIP_DEBUGF(IP_DEBUG, ("ip4_forward: no forwarding route for %"U16_F".%"U16_F".%"U16_F".%"U16_F" found\n",
-                           ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
-                           ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));
+      ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
+      ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));
    /* @todo: send ICMP_DUR_NET? */
    goto return_noroute;
  }
@@ -331,14 +318,14 @@ ip4_forward(struct pbuf *p, struct ip_hdr *iphdr, struct netif *inp)

  /* Incrementally update the IP checksum. */
  if (IPH_CHKSUM(iphdr) >= PP_HTONS(0xffffU - 0x100)) {
-    IPH_CHKSUM_SET(iphdr, (u16_t)(IPH_CHKSUM(iphdr) + PP_HTONS(0x100) + 1));
+    IPH_CHKSUM_SET(iphdr, IPH_CHKSUM(iphdr) + PP_HTONS(0x100) + 1);
  } else {
-    IPH_CHKSUM_SET(iphdr, (u16_t)(IPH_CHKSUM(iphdr) + PP_HTONS(0x100)));
+    IPH_CHKSUM_SET(iphdr, IPH_CHKSUM(iphdr) + PP_HTONS(0x100));
  }

  LWIP_DEBUGF(IP_DEBUG, ("ip4_forward: forwarding packet to %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                         ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
-                         ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));
+    ip4_addr1_16(ip4_current_dest_addr()), ip4_addr2_16(ip4_current_dest_addr()),
+    ip4_addr3_16(ip4_current_dest_addr()), ip4_addr4_16(ip4_current_dest_addr())));

  IP_STATS_INC(ip.fw);
  MIB2_STATS_INC(mib2.ipforwdatagrams);
@@ -369,45 +356,6 @@ return_noroute:
 }
 #endif /* IP_FORWARD */

-/** Return true if the current input packet should be accepted on this netif */
-static int
-ip4_input_accept(struct netif *netif)
-{
-  LWIP_DEBUGF(IP_DEBUG, ("ip_input: iphdr->dest 0x%"X32_F" netif->ip_addr 0x%"X32_F" (0x%"X32_F", 0x%"X32_F", 0x%"X32_F")\n",
-                         ip4_addr_get_u32(ip4_current_dest_addr()), ip4_addr_get_u32(netif_ip4_addr(netif)),
-                         ip4_addr_get_u32(ip4_current_dest_addr()) & ip4_addr_get_u32(netif_ip4_netmask(netif)),
-                         ip4_addr_get_u32(netif_ip4_addr(netif)) & ip4_addr_get_u32(netif_ip4_netmask(netif)),
-                         ip4_addr_get_u32(ip4_current_dest_addr()) & ~ip4_addr_get_u32(netif_ip4_netmask(netif))));
-
-  /* interface is up and configured? */
-  if ((netif_is_up(netif)) && (!ip4_addr_isany_val(*netif_ip4_addr(netif)))) {
-    /* unicast to this interface address? */
-    if (ip4_addr_cmp(ip4_current_dest_addr(), netif_ip4_addr(netif)) ||
-        /* or broadcast on this interface network address? */
-        ip4_addr_isbroadcast(ip4_current_dest_addr(), netif)
-#if LWIP_NETIF_LOOPBACK && !LWIP_HAVE_LOOPIF
-        || (ip4_addr_get_u32(ip4_current_dest_addr()) == PP_HTONL(IPADDR_LOOPBACK))
-#endif /* LWIP_NETIF_LOOPBACK && !LWIP_HAVE_LOOPIF */
-       ) {
-      LWIP_DEBUGF(IP_DEBUG, ("ip4_input: packet accepted on interface %c%c\n",
-                             netif->name[0], netif->name[1]));
-      /* accept on this netif */
-      return 1;
-    }
-#if LWIP_AUTOIP
-    /* connections to link-local addresses must persist after changing
-        the netif's address (RFC3927 ch. 1.9) */
-    if (autoip_accept_packet(netif, ip4_current_dest_addr())) {
-      LWIP_DEBUGF(IP_DEBUG, ("ip4_input: LLA packet accepted on interface %c%c\n",
-                             netif->name[0], netif->name[1]));
-      /* accept on this netif */
-      return 1;
-    }
-#endif /* LWIP_AUTOIP */
-  }
-  return 0;
-}
-
 /**
 * This function is called by the network interface device driver when
 * an IP packet is received. The function does the basic checks of the
@@ -425,18 +373,13 @@ ip4_input_accept(struct netif *netif)
 err_t
 ip4_input(struct pbuf *p, struct netif *inp)
 {
-  const struct ip_hdr *iphdr;
+  struct ip_hdr *iphdr;
  struct netif *netif;
  u16_t iphdr_hlen;
  u16_t iphdr_len;
 #if IP_ACCEPT_LINK_LAYER_ADDRESSING || LWIP_IGMP
  int check_ip_src = 1;
 #endif /* IP_ACCEPT_LINK_LAYER_ADDRESSING || LWIP_IGMP */
-#if LWIP_RAW
-  raw_input_state_t raw_status;
-#endif /* LWIP_RAW */
-
-  LWIP_ASSERT_CORE_LOCKED();

  IP_STATS_INC(ip.recv);
  MIB2_STATS_INC(mib2.ipinreceives);
@@ -460,8 +403,10 @@ ip4_input(struct pbuf *p, struct netif *inp)
  }
 #endif

-  /* obtain IP header length in bytes */
-  iphdr_hlen = IPH_HL_BYTES(iphdr);
+  /* obtain IP header length in number of 32-bit words */
+  iphdr_hlen = IPH_HL(iphdr);
+  /* calculate IP header length in bytes */
+  iphdr_hlen *= 4;
  /* obtain ip length in bytes */
  iphdr_len = lwip_ntohs(IPH_LEN(iphdr));

@@ -474,17 +419,17 @@ ip4_input(struct pbuf *p, struct netif *inp)
  if ((iphdr_hlen > p->len) || (iphdr_len > p->tot_len) || (iphdr_hlen < IP_HLEN)) {
    if (iphdr_hlen < IP_HLEN) {
      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS,
-                  ("ip4_input: short IP header (%"U16_F" bytes) received, IP packet dropped\n", iphdr_hlen));
+        ("ip4_input: short IP header (%"U16_F" bytes) received, IP packet dropped\n", iphdr_hlen));
    }
    if (iphdr_hlen > p->len) {
      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS,
-                  ("IP header (len %"U16_F") does not fit in first pbuf (len %"U16_F"), IP packet dropped.\n",
-                   iphdr_hlen, p->len));
+        ("IP header (len %"U16_F") does not fit in first pbuf (len %"U16_F"), IP packet dropped.\n",
+        iphdr_hlen, p->len));
    }
    if (iphdr_len > p->tot_len) {
      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS,
-                  ("IP (len %"U16_F") is longer than pbuf (len %"U16_F"), IP packet dropped.\n",
-                   iphdr_len, p->tot_len));
+        ("IP (len %"U16_F") is longer than pbuf (len %"U16_F"), IP packet dropped.\n",
+        iphdr_len, p->tot_len));
    }
    /* free (drop) packet pbufs */
    pbuf_free(p);
@@ -500,7 +445,7 @@ ip4_input(struct pbuf *p, struct netif *inp)
    if (inet_chksum(iphdr, iphdr_hlen) != 0) {

      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS,
-                  ("Checksum (0x%"X16_F") failed, IP packet dropped.\n", inet_chksum(iphdr, iphdr_hlen)));
+        ("Checksum (0x%"X16_F") failed, IP packet dropped.\n", inet_chksum(iphdr, iphdr_hlen)));
      ip4_debug_print(p);
      pbuf_free(p);
      IP_STATS_INC(ip.chkerr);
@@ -539,31 +484,62 @@ ip4_input(struct pbuf *p, struct netif *inp)
 #endif /* LWIP_IGMP */
  } else {
    /* start trying with inp. if that's not acceptable, start walking the
-       list of configured netifs. */
-    if (ip4_input_accept(inp)) {
-      netif = inp;
-    } else {
-      netif = NULL;
-#if !LWIP_NETIF_LOOPBACK || LWIP_HAVE_LOOPIF
-      /* Packets sent to the loopback address must not be accepted on an
-       * interface that does not have the loopback address assigned to it,
-       * unless a non-loopback interface is used for loopback traffic. */
-      if (!ip4_addr_isloopback(ip4_current_dest_addr()))
-#endif /* !LWIP_NETIF_LOOPBACK || LWIP_HAVE_LOOPIF */
-      {
-#if !LWIP_SINGLE_NETIF
-        NETIF_FOREACH(netif) {
-          if (netif == inp) {
-            /* we checked that before already */
-            continue;
-          }
-          if (ip4_input_accept(netif)) {
-            break;
-          }
+       list of configured netifs.
+       'first' is used as a boolean to mark whether we started walking the list */
+    int first = 1;
+    netif = inp;
+    do {
+      LWIP_DEBUGF(IP_DEBUG, ("ip_input: iphdr->dest 0x%"X32_F" netif->ip_addr 0x%"X32_F" (0x%"X32_F", 0x%"X32_F", 0x%"X32_F")\n",
+          ip4_addr_get_u32(&iphdr->dest), ip4_addr_get_u32(netif_ip4_addr(netif)),
+          ip4_addr_get_u32(&iphdr->dest) & ip4_addr_get_u32(netif_ip4_netmask(netif)),
+          ip4_addr_get_u32(netif_ip4_addr(netif)) & ip4_addr_get_u32(netif_ip4_netmask(netif)),
+          ip4_addr_get_u32(&iphdr->dest) & ~ip4_addr_get_u32(netif_ip4_netmask(netif))));
+
+      /* interface is up and configured? */
+      if ((netif_is_up(netif)) && (!ip4_addr_isany_val(*netif_ip4_addr(netif)))) {
+        /* unicast to this interface address? */
+        if (ip4_addr_cmp(ip4_current_dest_addr(), netif_ip4_addr(netif)) ||
+            /* or broadcast on this interface network address? */
+            ip4_addr_isbroadcast(ip4_current_dest_addr(), netif)
+#if LWIP_NETIF_LOOPBACK && !LWIP_HAVE_LOOPIF
+            || (ip4_addr_get_u32(ip4_current_dest_addr()) == PP_HTONL(IPADDR_LOOPBACK))
+#endif /* LWIP_NETIF_LOOPBACK && !LWIP_HAVE_LOOPIF */
+            ) {
+          LWIP_DEBUGF(IP_DEBUG, ("ip4_input: packet accepted on interface %c%c\n",
+              netif->name[0], netif->name[1]));
+          /* break out of for loop */
+          break;
        }
-#endif /* !LWIP_SINGLE_NETIF */
+#if LWIP_AUTOIP
+        /* connections to link-local addresses must persist after changing
+           the netif's address (RFC3927 ch. 1.9) */
+        if (autoip_accept_packet(netif, ip4_current_dest_addr())) {
+          LWIP_DEBUGF(IP_DEBUG, ("ip4_input: LLA packet accepted on interface %c%c\n",
+              netif->name[0], netif->name[1]));
+          /* break out of for loop */
+          break;
+        }
+#endif /* LWIP_AUTOIP */
      }
-    }
+      if (first) {
+#if !LWIP_NETIF_LOOPBACK || LWIP_HAVE_LOOPIF
+        /* Packets sent to the loopback address must not be accepted on an
+         * interface that does not have the loopback address assigned to it,
+         * unless a non-loopback interface is used for loopback traffic. */
+        if (ip4_addr_isloopback(ip4_current_dest_addr())) {
+          netif = NULL;
+          break;
+        }
+#endif /* !LWIP_NETIF_LOOPBACK || LWIP_HAVE_LOOPIF */
+        first = 0;
+        netif = netif_list;
+      } else {
+        netif = netif->next;
+      }
+      if (netif == inp) {
+        netif = netif->next;
+      }
+    } while (netif != NULL);
  }

 #if IP_ACCEPT_LINK_LAYER_ADDRESSING
@@ -579,9 +555,9 @@ ip4_input(struct pbuf *p, struct netif *inp)
  if (netif == NULL) {
    /* remote port is DHCP server? */
    if (IPH_PROTO(iphdr) == IP_PROTO_UDP) {
-      const struct udp_hdr *udphdr = (const struct udp_hdr *)((const u8_t *)iphdr + iphdr_hlen);
+      struct udp_hdr *udphdr = (struct udp_hdr *)((u8_t *)iphdr + iphdr_hlen);
      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE, ("ip4_input: UDP packet to DHCP client port %"U16_F"\n",
-                                              lwip_ntohs(udphdr->dest)));
+        lwip_ntohs(udphdr->dest)));
      if (IP_ACCEPT_LINK_LAYER_ADDRESSED_PORT(udphdr->dest)) {
        LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE, ("ip4_input: DHCP packet accepted.\n"));
        netif = inp;
@@ -595,7 +571,7 @@ ip4_input(struct pbuf *p, struct netif *inp)
 #if LWIP_IGMP || IP_ACCEPT_LINK_LAYER_ADDRESSING
  if (check_ip_src
 #if IP_ACCEPT_LINK_LAYER_ADDRESSING
-      /* DHCP servers need 0.0.0.0 to be allowed as source address (RFC 1.1.2.2: 3.2.1.3/a) */
+  /* DHCP servers need 0.0.0.0 to be allowed as source address (RFC 1.1.2.2: 3.2.1.3/a) */
      && !ip4_addr_isany_val(*ip4_current_src_addr())
 #endif /* IP_ACCEPT_LINK_LAYER_ADDRESSING */
     )
@@ -622,7 +598,7 @@ ip4_input(struct pbuf *p, struct netif *inp)
    /* non-broadcast packet? */
    if (!ip4_addr_isbroadcast(ip4_current_dest_addr(), inp)) {
      /* try to forward IP packet on (other) interfaces */
-      ip4_forward(p, (struct ip_hdr *)p->payload, inp);
+      ip4_forward(p, iphdr, inp);
    } else
 #endif /* IP_FORWARD */
    {
@@ -637,18 +613,18 @@ ip4_input(struct pbuf *p, struct netif *inp)
  if ((IPH_OFFSET(iphdr) & PP_HTONS(IP_OFFMASK | IP_MF)) != 0) {
 #if IP_REASSEMBLY /* packet fragment reassembly code present? */
    LWIP_DEBUGF(IP_DEBUG, ("IP packet is a fragment (id=0x%04"X16_F" tot_len=%"U16_F" len=%"U16_F" MF=%"U16_F" offset=%"U16_F"), calling ip4_reass()\n",
-                           lwip_ntohs(IPH_ID(iphdr)), p->tot_len, lwip_ntohs(IPH_LEN(iphdr)), (u16_t)!!(IPH_OFFSET(iphdr) & PP_HTONS(IP_MF)), (u16_t)((lwip_ntohs(IPH_OFFSET(iphdr)) & IP_OFFMASK) * 8)));
+      lwip_ntohs(IPH_ID(iphdr)), p->tot_len, lwip_ntohs(IPH_LEN(iphdr)), (u16_t)!!(IPH_OFFSET(iphdr) & PP_HTONS(IP_MF)), (u16_t)((lwip_ntohs(IPH_OFFSET(iphdr)) & IP_OFFMASK)*8)));
    /* reassemble the packet*/
    p = ip4_reass(p);
    /* packet not fully reassembled yet? */
    if (p == NULL) {
      return ERR_OK;
    }
-    iphdr = (const struct ip_hdr *)p->payload;
+    iphdr = (struct ip_hdr *)p->payload;
 #else /* IP_REASSEMBLY == 0, no packet fragment reassembly code present */
    pbuf_free(p);
    LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("IP packet dropped since it was fragmented (0x%"X16_F") (while IP_REASSEMBLY == 0).\n",
-                lwip_ntohs(IPH_OFFSET(iphdr))));
+      lwip_ntohs(IPH_OFFSET(iphdr))));
    IP_STATS_INC(ip.opterr);
    IP_STATS_INC(ip.drop);
    /* unsupported protocol feature */
@@ -683,67 +659,59 @@ ip4_input(struct pbuf *p, struct netif *inp)
  ip_data.current_netif = netif;
  ip_data.current_input_netif = inp;
  ip_data.current_ip4_header = iphdr;
-  ip_data.current_ip_header_tot_len = IPH_HL_BYTES(iphdr);
+  ip_data.current_ip_header_tot_len = IPH_HL(iphdr) * 4;

 #if LWIP_RAW
  /* raw input did not eat the packet? */
-  raw_status = raw_input(p, inp);
-  if (raw_status != RAW_INPUT_EATEN)
+  if (raw_input(p, inp) == 0)
 #endif /* LWIP_RAW */
  {
-    pbuf_remove_header(p, iphdr_hlen); /* Move to payload, no check necessary. */
+    pbuf_header(p, -(s16_t)iphdr_hlen); /* Move to payload, no check necessary. */

    switch (IPH_PROTO(iphdr)) {
 #if LWIP_UDP
-      case IP_PROTO_UDP:
+    case IP_PROTO_UDP:
 #if LWIP_UDPLITE
-      case IP_PROTO_UDPLITE:
+    case IP_PROTO_UDPLITE:
 #endif /* LWIP_UDPLITE */
-        MIB2_STATS_INC(mib2.ipindelivers);
-        udp_input(p, inp);
-        break;
+      MIB2_STATS_INC(mib2.ipindelivers);
+      udp_input(p, inp);
+      break;
 #endif /* LWIP_UDP */
 #if LWIP_TCP
-      case IP_PROTO_TCP:
-        MIB2_STATS_INC(mib2.ipindelivers);
-        tcp_input(p, inp);
-        break;
+    case IP_PROTO_TCP:
+      MIB2_STATS_INC(mib2.ipindelivers);
+      tcp_input(p, inp);
+      break;
 #endif /* LWIP_TCP */
 #if LWIP_ICMP
-      case IP_PROTO_ICMP:
-        MIB2_STATS_INC(mib2.ipindelivers);
-        icmp_input(p, inp);
-        break;
+    case IP_PROTO_ICMP:
+      MIB2_STATS_INC(mib2.ipindelivers);
+      icmp_input(p, inp);
+      break;
 #endif /* LWIP_ICMP */
 #if LWIP_IGMP
-      case IP_PROTO_IGMP:
-        igmp_input(p, inp, ip4_current_dest_addr());
-        break;
+    case IP_PROTO_IGMP:
+      igmp_input(p, inp, ip4_current_dest_addr());
+      break;
 #endif /* LWIP_IGMP */
-      default:
-#if LWIP_RAW
-        if (raw_status == RAW_INPUT_DELIVERED) {
-          MIB2_STATS_INC(mib2.ipindelivers);
-        } else
-#endif /* LWIP_RAW */
-        {
+    default:
 #if LWIP_ICMP
-          /* send ICMP destination protocol unreachable unless is was a broadcast */
-          if (!ip4_addr_isbroadcast(ip4_current_dest_addr(), netif) &&
-              !ip4_addr_ismulticast(ip4_current_dest_addr())) {
-            pbuf_header_force(p, (s16_t)iphdr_hlen); /* Move to ip header, no check necessary. */
-            icmp_dest_unreach(p, ICMP_DUR_PROTO);
-          }
+      /* send ICMP destination protocol unreachable unless is was a broadcast */
+      if (!ip4_addr_isbroadcast(ip4_current_dest_addr(), netif) &&
+          !ip4_addr_ismulticast(ip4_current_dest_addr())) {
+        pbuf_header_force(p, iphdr_hlen); /* Move to ip header, no check necessary. */
+        p->payload = iphdr;
+        icmp_dest_unreach(p, ICMP_DUR_PROTO);
+      }
 #endif /* LWIP_ICMP */
+      pbuf_free(p);

-          LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("Unsupported transport protocol %"U16_F"\n", (u16_t)IPH_PROTO(iphdr)));
+      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("Unsupported transport protocol %"U16_F"\n", (u16_t)IPH_PROTO(iphdr)));

-          IP_STATS_INC(ip.proterr);
-          IP_STATS_INC(ip.drop);
-          MIB2_STATS_INC(mib2.ipinunknownprotos);
-        }
-        pbuf_free(p);
-        break;
+      IP_STATS_INC(ip.proterr);
+      IP_STATS_INC(ip.drop);
+      MIB2_STATS_INC(mib2.ipinunknownprotos);
    }
  }

@@ -785,8 +753,8 @@ ip4_input(struct pbuf *p, struct netif *inp)
 */
 err_t
 ip4_output_if(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-              u8_t ttl, u8_t tos,
-              u8_t proto, struct netif *netif)
+             u8_t ttl, u8_t tos,
+             u8_t proto, struct netif *netif)
 {
 #if IP_OPTIONS_SEND
  return ip4_output_if_opt(p, src, dest, ttl, tos, proto, netif, NULL, 0);
@@ -800,8 +768,8 @@ ip4_output_if(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 */
 err_t
 ip4_output_if_opt(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-                  u8_t ttl, u8_t tos, u8_t proto, struct netif *netif, void *ip_options,
-                  u16_t optlen)
+       u8_t ttl, u8_t tos, u8_t proto, struct netif *netif, void *ip_options,
+       u16_t optlen)
 {
 #endif /* IP_OPTIONS_SEND */
  const ip4_addr_t *src_used = src;
@@ -813,7 +781,7 @@ ip4_output_if_opt(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,

 #if IP_OPTIONS_SEND
  return ip4_output_if_opt_src(p, src_used, dest, ttl, tos, proto, netif,
-                               ip_options, optlen);
+    ip_options, optlen);
 #else /* IP_OPTIONS_SEND */
  return ip4_output_if_src(p, src_used, dest, ttl, tos, proto, netif);
 #endif /* IP_OPTIONS_SEND */
@@ -825,8 +793,8 @@ ip4_output_if_opt(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 */
 err_t
 ip4_output_if_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-                  u8_t ttl, u8_t tos,
-                  u8_t proto, struct netif *netif)
+             u8_t ttl, u8_t tos,
+             u8_t proto, struct netif *netif)
 {
 #if IP_OPTIONS_SEND
  return ip4_output_if_opt_src(p, src, dest, ttl, tos, proto, netif, NULL, 0);
@@ -838,8 +806,8 @@ ip4_output_if_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 */
 err_t
 ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-                      u8_t ttl, u8_t tos, u8_t proto, struct netif *netif, void *ip_options,
-                      u16_t optlen)
+       u8_t ttl, u8_t tos, u8_t proto, struct netif *netif, void *ip_options,
+       u16_t optlen)
 {
 #endif /* IP_OPTIONS_SEND */
  struct ip_hdr *iphdr;
@@ -848,7 +816,6 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
  u32_t chk_sum = 0;
 #endif /* CHECKSUM_GEN_IP_INLINE */

-  LWIP_ASSERT_CORE_LOCKED();
  LWIP_IP_CHECK_PBUF_REF_COUNT_FOR_TX(p);

  MIB2_STATS_INC(mib2.ipoutrequests);
@@ -862,18 +829,11 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
 #if CHECKSUM_GEN_IP_INLINE
      int i;
 #endif /* CHECKSUM_GEN_IP_INLINE */
-      if (optlen > (IP_HLEN_MAX - IP_HLEN)) {
-        /* optlen too long */
-        LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("ip4_output_if_opt: optlen too long\n"));
-        IP_STATS_INC(ip.err);
-        MIB2_STATS_INC(mib2.ipoutdiscards);
-        return ERR_VAL;
-      }
      /* round up to a multiple of 4 */
-      optlen_aligned = (u16_t)((optlen + 3) & ~3);
-      ip_hlen = (u16_t)(ip_hlen + optlen_aligned);
+      optlen_aligned = ((optlen + 3) & ~3);
+      ip_hlen += optlen_aligned;
      /* First write in the IP options */
-      if (pbuf_add_header(p, optlen_aligned)) {
+      if (pbuf_header(p, optlen_aligned)) {
        LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("ip4_output_if_opt: not enough room for IP options in pbuf\n"));
        IP_STATS_INC(ip.err);
        MIB2_STATS_INC(mib2.ipoutdiscards);
@@ -882,17 +842,17 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
      MEMCPY(p->payload, ip_options, optlen);
      if (optlen < optlen_aligned) {
        /* zero the remaining bytes */
-        memset(((char *)p->payload) + optlen, 0, (size_t)(optlen_aligned - optlen));
+        memset(((char*)p->payload) + optlen, 0, optlen_aligned - optlen);
      }
 #if CHECKSUM_GEN_IP_INLINE
-      for (i = 0; i < optlen_aligned / 2; i++) {
-        chk_sum += ((u16_t *)p->payload)[i];
+      for (i = 0; i < optlen_aligned/2; i++) {
+        chk_sum += ((u16_t*)p->payload)[i];
      }
 #endif /* CHECKSUM_GEN_IP_INLINE */
    }
 #endif /* IP_OPTIONS_SEND */
    /* generate IP header */
-    if (pbuf_add_header(p, IP_HLEN)) {
+    if (pbuf_header(p, IP_HLEN)) {
      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("ip4_output: not enough room for IP header in pbuf\n"));

      IP_STATS_INC(ip.err);
@@ -902,7 +862,7 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d

    iphdr = (struct ip_hdr *)p->payload;
    LWIP_ASSERT("check that first pbuf can hold struct ip_hdr",
-                (p->len >= sizeof(struct ip_hdr)));
+               (p->len >= sizeof(struct ip_hdr)));

    IPH_TTL_SET(iphdr, ttl);
    IPH_PROTO_SET(iphdr, proto);
@@ -964,12 +924,6 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
 #endif /* CHECKSUM_GEN_IP_INLINE */
  } else {
    /* IP header already included in p */
-    if (p->len < IP_HLEN) {
-      LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_LEVEL_SERIOUS, ("ip4_output: LWIP_IP_HDRINCL but pbuf is too short\n"));
-      IP_STATS_INC(ip.err);
-      MIB2_STATS_INC(mib2.ipoutdiscards);
-      return ERR_BUF;
-    }
    iphdr = (struct ip_hdr *)p->payload;
    ip4_addr_copy(dest_addr, iphdr->dest);
    dest = &dest_addr;
@@ -985,7 +939,7 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
 #if !LWIP_HAVE_LOOPIF
      || ip4_addr_isloopback(dest)
 #endif /* !LWIP_HAVE_LOOPIF */
-     ) {
+      ) {
    /* Packet to self, enqueue it for loopback */
    LWIP_DEBUGF(IP_DEBUG, ("netif_loop_output()"));
    return netif_loop_output(netif, p);
@@ -1026,15 +980,15 @@ ip4_output_if_opt_src(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *d
 */
 err_t
 ip4_output(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-           u8_t ttl, u8_t tos, u8_t proto)
+          u8_t ttl, u8_t tos, u8_t proto)
 {
  struct netif *netif;

  LWIP_IP_CHECK_PBUF_REF_COUNT_FOR_TX(p);

-  if ((netif = ip4_route_src(src, dest)) == NULL) {
+  if ((netif = ip4_route_src(dest, src)) == NULL) {
    LWIP_DEBUGF(IP_DEBUG, ("ip4_output: No route to %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                           ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
+      ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
    IP_STATS_INC(ip.rterr);
    return ERR_RTE;
  }
@@ -1042,7 +996,7 @@ ip4_output(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
  return ip4_output_if(p, src, dest, ttl, tos, proto, netif);
 }

-#if LWIP_NETIF_USE_HINTS
+#if LWIP_NETIF_HWADDRHINT
 /** Like ip_output, but takes and addr_hint pointer that is passed on to netif->addr_hint
 *  before calling ip_output_if.
 *
@@ -1055,7 +1009,7 @@ ip4_output(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 * @param ttl the TTL value to be set in the IP header
 * @param tos the TOS value to be set in the IP header
 * @param proto the PROTOCOL to be set in the IP header
- * @param netif_hint netif output hint pointer set to netif->hint before
+ * @param addr_hint address hint pointer set to netif->addr_hint before
 *        calling ip_output_if()
 *
 * @return ERR_RTE if no route is found
@@ -1063,27 +1017,27 @@ ip4_output(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
 */
 err_t
 ip4_output_hinted(struct pbuf *p, const ip4_addr_t *src, const ip4_addr_t *dest,
-                  u8_t ttl, u8_t tos, u8_t proto, struct netif_hint *netif_hint)
+          u8_t ttl, u8_t tos, u8_t proto, u8_t *addr_hint)
 {
  struct netif *netif;
  err_t err;

  LWIP_IP_CHECK_PBUF_REF_COUNT_FOR_TX(p);

-  if ((netif = ip4_route_src(src, dest)) == NULL) {
+  if ((netif = ip4_route_src(dest, src)) == NULL) {
    LWIP_DEBUGF(IP_DEBUG, ("ip4_output: No route to %"U16_F".%"U16_F".%"U16_F".%"U16_F"\n",
-                           ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
+      ip4_addr1_16(dest), ip4_addr2_16(dest), ip4_addr3_16(dest), ip4_addr4_16(dest)));
    IP_STATS_INC(ip.rterr);
    return ERR_RTE;
  }

-  NETIF_SET_HINTS(netif, netif_hint);
+  NETIF_SET_HWADDRHINT(netif, addr_hint);
  err = ip4_output_if(p, src, dest, ttl, tos, proto, netif);
-  NETIF_RESET_HINTS(netif);
+  NETIF_SET_HWADDRHINT(netif, NULL);

  return err;
 }
-#endif /* LWIP_NETIF_USE_HINTS*/
+#endif /* LWIP_NETIF_HWADDRHINT*/

 #if IP_DEBUG
 /* Print an IP header by using LWIP_DEBUGF
@@ -1097,34 +1051,34 @@ ip4_debug_print(struct pbuf *p)
  LWIP_DEBUGF(IP_DEBUG, ("IP header:\n"));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
  LWIP_DEBUGF(IP_DEBUG, ("|%2"S16_F" |%2"S16_F" |  0x%02"X16_F" |     %5"U16_F"     | (v, hl, tos, len)\n",
-                         (u16_t)IPH_V(iphdr),
-                         (u16_t)IPH_HL(iphdr),
-                         (u16_t)IPH_TOS(iphdr),
-                         lwip_ntohs(IPH_LEN(iphdr))));
+                    (u16_t)IPH_V(iphdr),
+                    (u16_t)IPH_HL(iphdr),
+                    (u16_t)IPH_TOS(iphdr),
+                    lwip_ntohs(IPH_LEN(iphdr))));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
  LWIP_DEBUGF(IP_DEBUG, ("|    %5"U16_F"      |%"U16_F"%"U16_F"%"U16_F"|    %4"U16_F"   | (id, flags, offset)\n",
-                         lwip_ntohs(IPH_ID(iphdr)),
-                         (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 15 & 1),
-                         (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 14 & 1),
-                         (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 13 & 1),
-                         (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) & IP_OFFMASK)));
+                    lwip_ntohs(IPH_ID(iphdr)),
+                    (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 15 & 1),
+                    (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 14 & 1),
+                    (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) >> 13 & 1),
+                    (u16_t)(lwip_ntohs(IPH_OFFSET(iphdr)) & IP_OFFMASK)));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
  LWIP_DEBUGF(IP_DEBUG, ("|  %3"U16_F"  |  %3"U16_F"  |    0x%04"X16_F"     | (ttl, proto, chksum)\n",
-                         (u16_t)IPH_TTL(iphdr),
-                         (u16_t)IPH_PROTO(iphdr),
-                         lwip_ntohs(IPH_CHKSUM(iphdr))));
+                    (u16_t)IPH_TTL(iphdr),
+                    (u16_t)IPH_PROTO(iphdr),
+                    lwip_ntohs(IPH_CHKSUM(iphdr))));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
  LWIP_DEBUGF(IP_DEBUG, ("|  %3"U16_F"  |  %3"U16_F"  |  %3"U16_F"  |  %3"U16_F"  | (src)\n",
-                         ip4_addr1_16_val(iphdr->src),
-                         ip4_addr2_16_val(iphdr->src),
-                         ip4_addr3_16_val(iphdr->src),
-                         ip4_addr4_16_val(iphdr->src)));
+                    ip4_addr1_16(&iphdr->src),
+                    ip4_addr2_16(&iphdr->src),
+                    ip4_addr3_16(&iphdr->src),
+                    ip4_addr4_16(&iphdr->src)));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
  LWIP_DEBUGF(IP_DEBUG, ("|  %3"U16_F"  |  %3"U16_F"  |  %3"U16_F"  |  %3"U16_F"  | (dest)\n",
-                         ip4_addr1_16_val(iphdr->dest),
-                         ip4_addr2_16_val(iphdr->dest),
-                         ip4_addr3_16_val(iphdr->dest),
-                         ip4_addr4_16_val(iphdr->dest)));
+                    ip4_addr1_16(&iphdr->dest),
+                    ip4_addr2_16(&iphdr->dest),
+                    ip4_addr3_16(&iphdr->dest),
+                    ip4_addr4_16(&iphdr->dest)));
  LWIP_DEBUGF(IP_DEBUG, ("+-------------------------------+\n"));
 }
 #endif /* IP_DEBUG */
--- a/src/core/ipv4/ip4_addr.c
+++ b/src/core/ipv4/ip4_addr.c
@@ -64,19 +64,19 @@ ip4_addr_isbroadcast_u32(u32_t addr, const struct netif *netif)
  if ((~addr == IPADDR_ANY) ||
      (addr == IPADDR_ANY)) {
    return 1;
-    /* no broadcast support on this network interface? */
+  /* no broadcast support on this network interface? */
  } else if ((netif->flags & NETIF_FLAG_BROADCAST) == 0) {
    /* the given address cannot be a broadcast address
     * nor can we check against any broadcast addresses */
    return 0;
-    /* address matches network interface address exactly? => no broadcast */
+  /* address matches network interface address exactly? => no broadcast */
  } else if (addr == ip4_addr_get_u32(netif_ip4_addr(netif))) {
    return 0;
-    /*  on the same (sub) network... */
+  /*  on the same (sub) network... */
  } else if (ip4_addr_netcmp(&ipaddr, netif_ip4_addr(netif), netif_ip4_netmask(netif))
-             /* ...and host identifier bits are all ones? =>... */
-             && ((addr & ~ip4_addr_get_u32(netif_ip4_netmask(netif))) ==
-                 (IPADDR_BROADCAST & ~ip4_addr_get_u32(netif_ip4_netmask(netif))))) {
+         /* ...and host identifier bits are all ones? =>... */
+          && ((addr & ~ip4_addr_get_u32(netif_ip4_netmask(netif))) ==
+           (IPADDR_BROADCAST & ~ip4_addr_get_u32(netif_ip4_netmask(netif))))) {
    /* => network broadcast address */
    return 1;
  } else {
@@ -112,6 +112,16 @@ ip4_addr_netmask_valid(u32_t netmask)
  return 1;
 }

+/* Here for now until needed in other places in lwIP */
+#ifndef isprint
+#define in_range(c, lo, up)  ((u8_t)c >= lo && (u8_t)c <= up)
+#define isprint(c)           in_range(c, 0x20, 0x7f)
+#define isdigit(c)           in_range(c, '0', '9')
+#define isxdigit(c)          (isdigit(c) || in_range(c, 'a', 'f') || in_range(c, 'A', 'F'))
+#define islower(c)           in_range(c, 'a', 'z')
+#define isspace(c)           (c == ' ' || c == '\f' || c == '\n' || c == '\r' || c == '\t' || c == '\v')
+#endif
+
 /**
 * Ascii internet address interpretation routine.
 * The value returned is in network order.
@@ -157,7 +167,7 @@ ip4addr_aton(const char *cp, ip4_addr_t *addr)
     * Values are specified as for C:
     * 0x=hex, 0=octal, 1-9=decimal.
     */
-    if (!lwip_isdigit(c)) {
+    if (!isdigit(c)) {
      return 0;
    }
    val = 0;
@@ -172,11 +182,11 @@ ip4addr_aton(const char *cp, ip4_addr_t *addr)
      }
    }
    for (;;) {
-      if (lwip_isdigit(c)) {
+      if (isdigit(c)) {
        val = (val * base) + (u32_t)(c - '0');
        c = *++cp;
-      } else if (base == 16 && lwip_isxdigit(c)) {
-        val = (val << 4) | (u32_t)(c + 10 - (lwip_islower(c) ? 'a' : 'A'));
+      } else if (base == 16 && isxdigit(c)) {
+        val = (val << 4) | (u32_t)(c + 10 - (islower(c) ? 'a' : 'A'));
        c = *++cp;
      } else {
        break;
@@ -201,7 +211,7 @@ ip4addr_aton(const char *cp, ip4_addr_t *addr)
  /*
   * Check for trailing characters.
   */
-  if (c != '\0' && !lwip_isspace(c)) {
+  if (c != '\0' && !isspace(c)) {
    return 0;
  }
  /*
@@ -210,44 +220,44 @@ ip4addr_aton(const char *cp, ip4_addr_t *addr)
   */
  switch (pp - parts + 1) {

-    case 0:
-      return 0;       /* initial nondigit */
+  case 0:
+    return 0;       /* initial nondigit */

-    case 1:             /* a -- 32 bits */
-      break;
+  case 1:             /* a -- 32 bits */
+    break;

-    case 2:             /* a.b -- 8.24 bits */
-      if (val > 0xffffffUL) {
-        return 0;
-      }
-      if (parts[0] > 0xff) {
-        return 0;
-      }
-      val |= parts[0] << 24;
-      break;
+  case 2:             /* a.b -- 8.24 bits */
+    if (val > 0xffffffUL) {
+      return 0;
+    }
+    if (parts[0] > 0xff) {
+      return 0;
+    }
+    val |= parts[0] << 24;
+    break;

-    case 3:             /* a.b.c -- 8.8.16 bits */
-      if (val > 0xffff) {
-        return 0;
-      }
-      if ((parts[0] > 0xff) || (parts[1] > 0xff)) {
-        return 0;
-      }
-      val |= (parts[0] << 24) | (parts[1] << 16);
-      break;
+  case 3:             /* a.b.c -- 8.8.16 bits */
+    if (val > 0xffff) {
+      return 0;
+    }
+    if ((parts[0] > 0xff) || (parts[1] > 0xff)) {
+      return 0;
+    }
+    val |= (parts[0] << 24) | (parts[1] << 16);
+    break;

-    case 4:             /* a.b.c.d -- 8.8.8.8 bits */
-      if (val > 0xff) {
-        return 0;
-      }
-      if ((parts[0] > 0xff) || (parts[1] > 0xff) || (parts[2] > 0xff)) {
-        return 0;
-      }
-      val |= (parts[0] << 24) | (parts[1] << 16) | (parts[2] << 8);
-      break;
-    default:
-      LWIP_ASSERT("unhandled", 0);
-      break;
+  case 4:             /* a.b.c.d -- 8.8.8.8 bits */
+    if (val > 0xff) {
+      return 0;
+    }
+    if ((parts[0] > 0xff) || (parts[1] > 0xff) || (parts[2] > 0xff)) {
+      return 0;
+    }
+    val |= (parts[0] << 24) | (parts[1] << 16) | (parts[2] << 8);
+    break;
+  default:
+    LWIP_ASSERT("unhandled", 0);
+    break;
  }
  if (addr) {
    ip4_addr_set_u32(addr, lwip_htonl(val));
@@ -263,7 +273,7 @@ ip4addr_aton(const char *cp, ip4_addr_t *addr)
 * @return pointer to a global static (!) buffer that holds the ASCII
 *         representation of addr
 */
-char *
+char*
 ip4addr_ntoa(const ip4_addr_t *addr)
 {
  static char str[IP4ADDR_STRLEN_MAX];
@@ -271,7 +281,7 @@ ip4addr_ntoa(const ip4_addr_t *addr)
 }

 /**
- * Same as ip4addr_ntoa, but reentrant since a user-supplied buffer is used.
+ * Same as ipaddr_ntoa, but reentrant since a user-supplied buffer is used.
 *
 * @param addr ip address in network order to convert
 * @param buf target buffer where the string is stored
@@ -279,7 +289,7 @@ ip4addr_ntoa(const ip4_addr_t *addr)
 * @return either pointer to buf which now holds the ASCII
 *         representation of addr or NULL if buf was too small
 */
-char *
+char*
 ip4addr_ntoa_r(const ip4_addr_t *addr, char *buf, int buflen)
 {
  u32_t s_addr;
--- a/src/core/ipv4/ip4_frag.c
+++ b/src/core/ipv4/ip4_frag.c
@@ -79,10 +79,6 @@

 #define IP_REASS_FLAG_LASTFRAG 0x01

-#define IP_REASS_VALIDATE_TELEGRAM_FINISHED  1
-#define IP_REASS_VALIDATE_PBUF_QUEUED        0
-#define IP_REASS_VALIDATE_PBUF_DROPPED       -1
-
 /** This is a helper struct which holds the starting
 * offset and the ending offset of this fragment to
 * easily chain the fragments.
@@ -135,7 +131,7 @@ ip_reass_tmr(void)
     * clean up the incomplete fragment assembly */
    if (r->timer > 0) {
      r->timer--;
-      LWIP_DEBUGF(IP_REASS_DEBUG, ("ip_reass_tmr: timer dec %"U16_F"\n", (u16_t)r->timer));
+      LWIP_DEBUGF(IP_REASS_DEBUG, ("ip_reass_tmr: timer dec %"U16_F"\n",(u16_t)r->timer));
      prev = r;
      r = r->next;
    } else {
@@ -147,8 +143,8 @@ ip_reass_tmr(void)
      r = r->next;
      /* free the helper struct and all enqueued pbufs */
      ip_reass_free_complete_datagram(tmp, prev);
-    }
-  }
+     }
+   }
 }

 /**
@@ -186,7 +182,7 @@ ip_reass_free_complete_datagram(struct ip_reassdata *ipr, struct ip_reassdata *p
    icmp_time_exceeded(p, ICMP_TE_FRAG);
    clen = pbuf_clen(p);
    LWIP_ASSERT("pbufs_freed + clen <= 0xffff", pbufs_freed + clen <= 0xffff);
-    pbufs_freed = (u16_t)(pbufs_freed + clen);
+    pbufs_freed += clen;
    pbuf_free(p);
  }
 #endif /* LWIP_ICMP */
@@ -202,13 +198,13 @@ ip_reass_free_complete_datagram(struct ip_reassdata *ipr, struct ip_reassdata *p
    p = iprh->next_pbuf;
    clen = pbuf_clen(pcur);
    LWIP_ASSERT("pbufs_freed + clen <= 0xffff", pbufs_freed + clen <= 0xffff);
-    pbufs_freed = (u16_t)(pbufs_freed + clen);
+    pbufs_freed += clen;
    pbuf_free(pcur);
  }
  /* Then, unchain the struct ip_reassdata from the list and free it. */
  ip_reass_dequeue_datagram(ipr, prev);
-  LWIP_ASSERT("ip_reass_pbufcount >= pbufs_freed", ip_reass_pbufcount >= pbufs_freed);
-  ip_reass_pbufcount = (u16_t)(ip_reass_pbufcount - pbufs_freed);
+  LWIP_ASSERT("ip_reass_pbufcount >= clen", ip_reass_pbufcount >= pbufs_freed);
+  ip_reass_pbufcount -= pbufs_freed;

  return pbufs_freed;
 }
@@ -274,10 +270,10 @@ ip_reass_remove_oldest_datagram(struct ip_hdr *fraghdr, int pbufs_needed)
 * @param clen number of pbufs needed to enqueue (used for freeing other datagrams if not enough space)
 * @return A pointer to the queue location into which the fragment was enqueued
 */
-static struct ip_reassdata *
+static struct ip_reassdata*
 ip_reass_enqueue_new_datagram(struct ip_hdr *fraghdr, int clen)
 {
-  struct ip_reassdata *ipr;
+  struct ip_reassdata* ipr;
 #if ! IP_REASS_FREE_OLDEST
  LWIP_UNUSED_ARG(clen);
 #endif
@@ -293,7 +289,7 @@ ip_reass_enqueue_new_datagram(struct ip_hdr *fraghdr, int clen)
 #endif /* IP_REASS_FREE_OLDEST */
    {
      IPFRAG_STATS_INC(ip_frag.memerr);
-      LWIP_DEBUGF(IP_REASS_DEBUG, ("Failed to alloc reassdata struct\n"));
+      LWIP_DEBUGF(IP_REASS_DEBUG,("Failed to alloc reassdata struct\n"));
      return NULL;
    }
  }
@@ -337,48 +333,36 @@ ip_reass_dequeue_datagram(struct ip_reassdata *ipr, struct ip_reassdata *prev)
 * fragment was received at least once).
 * @param ipr points to the reassembly state
 * @param new_p points to the pbuf for the current fragment
- * @param is_last is 1 if this pbuf has MF==0 (ipr->flags not updated yet)
- * @return see IP_REASS_VALIDATE_* defines
+ * @return 0 if invalid, >0 otherwise
 */
 static int
-ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct pbuf *new_p, int is_last)
+ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct pbuf *new_p)
 {
-  struct ip_reass_helper *iprh, *iprh_tmp, *iprh_prev = NULL;
+  struct ip_reass_helper *iprh, *iprh_tmp, *iprh_prev=NULL;
  struct pbuf *q;
  u16_t offset, len;
-  u8_t hlen;
  struct ip_hdr *fraghdr;
  int valid = 1;

  /* Extract length and fragment offset from current fragment */
-  fraghdr = (struct ip_hdr *)new_p->payload;
-  len = lwip_ntohs(IPH_LEN(fraghdr));
-  hlen = IPH_HL_BYTES(fraghdr);
-  if (hlen > len) {
-    /* invalid datagram */
-    return IP_REASS_VALIDATE_PBUF_DROPPED;
-  }
-  len = (u16_t)(len - hlen);
-  offset = IPH_OFFSET_BYTES(fraghdr);
+  fraghdr = (struct ip_hdr*)new_p->payload;
+  len = lwip_ntohs(IPH_LEN(fraghdr)) - IPH_HL(fraghdr) * 4;
+  offset = (lwip_ntohs(IPH_OFFSET(fraghdr)) & IP_OFFMASK) * 8;

  /* overwrite the fragment's ip header from the pbuf with our helper struct,
   * and setup the embedded helper structure. */
  /* make sure the struct ip_reass_helper fits into the IP header */
  LWIP_ASSERT("sizeof(struct ip_reass_helper) <= IP_HLEN",
              sizeof(struct ip_reass_helper) <= IP_HLEN);
-  iprh = (struct ip_reass_helper *)new_p->payload;
+  iprh = (struct ip_reass_helper*)new_p->payload;
  iprh->next_pbuf = NULL;
  iprh->start = offset;
-  iprh->end = (u16_t)(offset + len);
-  if (iprh->end < offset) {
-    /* u16_t overflow, cannot handle this */
-    return IP_REASS_VALIDATE_PBUF_DROPPED;
-  }
+  iprh->end = offset + len;

  /* Iterate through until we either get to the end of the list (append),
   * or we find one with a larger offset (insert). */
  for (q = ipr->p; q != NULL;) {
-    iprh_tmp = (struct ip_reass_helper *)q->payload;
+    iprh_tmp = (struct ip_reass_helper*)q->payload;
    if (iprh->start < iprh_tmp->start) {
      /* the new pbuf should be inserted before this */
      iprh->next_pbuf = q;
@@ -387,33 +371,22 @@ ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct
 #if IP_REASS_CHECK_OVERLAP
        if ((iprh->start < iprh_prev->end) || (iprh->end > iprh_tmp->start)) {
          /* fragment overlaps with previous or following, throw away */
-          return IP_REASS_VALIDATE_PBUF_DROPPED;
+          goto freepbuf;
        }
 #endif /* IP_REASS_CHECK_OVERLAP */
        iprh_prev->next_pbuf = new_p;
-        if (iprh_prev->end != iprh->start) {
-          /* There is a fragment missing between the current
-           * and the previous fragment */
-          valid = 0;
-        }
      } else {
-#if IP_REASS_CHECK_OVERLAP
-        if (iprh->end > iprh_tmp->start) {
-          /* fragment overlaps with following, throw away */
-          return IP_REASS_VALIDATE_PBUF_DROPPED;
-        }
-#endif /* IP_REASS_CHECK_OVERLAP */
        /* fragment with the lowest offset */
        ipr->p = new_p;
      }
      break;
    } else if (iprh->start == iprh_tmp->start) {
      /* received the same datagram twice: no need to keep the datagram */
-      return IP_REASS_VALIDATE_PBUF_DROPPED;
+      goto freepbuf;
 #if IP_REASS_CHECK_OVERLAP
    } else if (iprh->start < iprh_tmp->end) {
      /* overlap: no need to keep the new datagram */
-      return IP_REASS_VALIDATE_PBUF_DROPPED;
+      goto freepbuf;
 #endif /* IP_REASS_CHECK_OVERLAP */
    } else {
      /* Check if the fragments received so far have no holes. */
@@ -444,7 +417,7 @@ ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct
    } else {
 #if IP_REASS_CHECK_OVERLAP
      LWIP_ASSERT("no previous fragment, this must be the first fragment!",
-                  ipr->p == NULL);
+        ipr->p == NULL);
 #endif /* IP_REASS_CHECK_OVERLAP */
      /* this is the first fragment we ever received for this ip datagram */
      ipr->p = new_p;
@@ -453,19 +426,19 @@ ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct

  /* At this point, the validation part begins: */
  /* If we already received the last fragment */
-  if (is_last || ((ipr->flags & IP_REASS_FLAG_LASTFRAG) != 0)) {
+  if ((ipr->flags & IP_REASS_FLAG_LASTFRAG) != 0) {
    /* and had no holes so far */
    if (valid) {
      /* then check if the rest of the fragments is here */
      /* Check if the queue starts with the first datagram */
-      if ((ipr->p == NULL) || (((struct ip_reass_helper *)ipr->p->payload)->start != 0)) {
+      if ((ipr->p == NULL) || (((struct ip_reass_helper*)ipr->p->payload)->start != 0)) {
        valid = 0;
      } else {
        /* and check that there are no holes after this datagram */
        iprh_prev = iprh;
        q = iprh->next_pbuf;
        while (q != NULL) {
-          iprh = (struct ip_reass_helper *)q->payload;
+          iprh = (struct ip_reass_helper*)q->payload;
          if (iprh_prev->end != iprh->start) {
            valid = 0;
            break;
@@ -478,19 +451,27 @@ ip_reass_chain_frag_into_datagram_and_validate(struct ip_reassdata *ipr, struct
        if (valid) {
          LWIP_ASSERT("sanity check", ipr->p != NULL);
          LWIP_ASSERT("sanity check",
-                      ((struct ip_reass_helper *)ipr->p->payload) != iprh);
+            ((struct ip_reass_helper*)ipr->p->payload) != iprh);
          LWIP_ASSERT("validate_datagram:next_pbuf!=NULL",
-                      iprh->next_pbuf == NULL);
+            iprh->next_pbuf == NULL);
+          LWIP_ASSERT("validate_datagram:datagram end!=datagram len",
+            iprh->end == ipr->datagram_len);
        }
      }
    }
    /* If valid is 0 here, there are some fragments missing in the middle
     * (since MF == 0 has already arrived). Such datagrams simply time out if
     * no more fragments are received... */
-    return valid ? IP_REASS_VALIDATE_TELEGRAM_FINISHED : IP_REASS_VALIDATE_PBUF_QUEUED;
+    return valid;
  }
  /* If we come here, not all fragments were received, yet! */
-  return IP_REASS_VALIDATE_PBUF_QUEUED; /* not yet valid! */
+  return 0; /* not yet valid! */
+#if IP_REASS_CHECK_OVERLAP
+freepbuf:
+  ip_reass_pbufcount -= pbuf_clen(new_p);
+  pbuf_free(new_p);
+  return 0;
+#endif /* IP_REASS_CHECK_OVERLAP */
 }

 /**
@@ -507,29 +488,20 @@ ip4_reass(struct pbuf *p)
  struct ip_reassdata *ipr;
  struct ip_reass_helper *iprh;
  u16_t offset, len, clen;
-  u8_t hlen;
-  int valid;
-  int is_last;

  IPFRAG_STATS_INC(ip_frag.recv);
  MIB2_STATS_INC(mib2.ipreasmreqds);

-  fraghdr = (struct ip_hdr *)p->payload;
+  fraghdr = (struct ip_hdr*)p->payload;

-  if (IPH_HL_BYTES(fraghdr) != IP_HLEN) {
-    LWIP_DEBUGF(IP_REASS_DEBUG, ("ip4_reass: IP options currently not supported!\n"));
+  if ((IPH_HL(fraghdr) * 4) != IP_HLEN) {
+    LWIP_DEBUGF(IP_REASS_DEBUG,("ip4_reass: IP options currently not supported!\n"));
    IPFRAG_STATS_INC(ip_frag.err);
    goto nullreturn;
  }

-  offset = IPH_OFFSET_BYTES(fraghdr);
-  len = lwip_ntohs(IPH_LEN(fraghdr));
-  hlen = IPH_HL_BYTES(fraghdr);
-  if (hlen > len) {
-    /* invalid datagram */
-    goto nullreturn;
-  }
-  len = (u16_t)(len - hlen);
+  offset = (lwip_ntohs(IPH_OFFSET(fraghdr)) & IP_OFFMASK) * 8;
+  len = lwip_ntohs(IPH_LEN(fraghdr)) - IPH_HL(fraghdr) * 4;

  /* Check if we are allowed to enqueue more datagrams. */
  clen = pbuf_clen(p);
@@ -540,8 +512,8 @@ ip4_reass(struct pbuf *p)
 #endif /* IP_REASS_FREE_OLDEST */
    {
      /* No datagram could be freed and still too many pbufs enqueued */
-      LWIP_DEBUGF(IP_REASS_DEBUG, ("ip4_reass: Overflow condition: pbufct=%d, clen=%d, MAX=%d\n",
-                                   ip_reass_pbufcount, clen, IP_REASS_MAX_PBUFS));
+      LWIP_DEBUGF(IP_REASS_DEBUG,("ip4_reass: Overflow condition: pbufct=%d, clen=%d, MAX=%d\n",
+        ip_reass_pbufcount, clen, IP_REASS_MAX_PBUFS));
      IPFRAG_STATS_INC(ip_frag.memerr);
      /* @todo: send ICMP time exceeded here? */
      /* drop this pbuf */
@@ -557,14 +529,14 @@ ip4_reass(struct pbuf *p)
       fragment into the buffer. */
    if (IP_ADDRESSES_AND_ID_MATCH(&ipr->iphdr, fraghdr)) {
      LWIP_DEBUGF(IP_REASS_DEBUG, ("ip4_reass: matching previous fragment ID=%"X16_F"\n",
-                                   lwip_ntohs(IPH_ID(fraghdr))));
+        lwip_ntohs(IPH_ID(fraghdr))));
      IPFRAG_STATS_INC(ip_frag.cachehit);
      break;
    }
  }

  if (ipr == NULL) {
-    /* Enqueue a new datagram into the datagram queue */
+  /* Enqueue a new datagram into the datagram queue */
    ipr = ip_reass_enqueue_new_datagram(fraghdr, clen);
    /* Bail if unable to enqueue */
    if (ipr == NULL) {
@@ -572,7 +544,7 @@ ip4_reass(struct pbuf *p)
    }
  } else {
    if (((lwip_ntohs(IPH_OFFSET(fraghdr)) & IP_OFFMASK) == 0) &&
-        ((lwip_ntohs(IPH_OFFSET(&ipr->iphdr)) & IP_OFFMASK) != 0)) {
+      ((lwip_ntohs(IPH_OFFSET(&ipr->iphdr)) & IP_OFFMASK) != 0)) {
      /* ipr->iphdr is not the header from the first fragment, but fraghdr is
       * -> copy fraghdr into ipr->iphdr since we want to have the header
       * of the first fragment (for ICMP time exceeded and later, for copying
@@ -580,53 +552,36 @@ ip4_reass(struct pbuf *p)
      SMEMCPY(&ipr->iphdr, fraghdr, IP_HLEN);
    }
  }
+  /* Track the current number of pbufs current 'in-flight', in order to limit
+  the number of fragments that may be enqueued at any one time */
+  ip_reass_pbufcount += clen;

  /* At this point, we have either created a new entry or pointing
   * to an existing one */

  /* check for 'no more fragments', and update queue entry*/
-  is_last = (IPH_OFFSET(fraghdr) & PP_NTOHS(IP_MF)) == 0;
-  if (is_last) {
-    u16_t datagram_len = (u16_t)(offset + len);
-    if ((datagram_len < offset) || (datagram_len > (0xFFFF - IP_HLEN))) {
-      /* u16_t overflow, cannot handle this */
-      goto nullreturn_ipr;
-    }
+  if ((IPH_OFFSET(fraghdr) & PP_NTOHS(IP_MF)) == 0) {
+    ipr->flags |= IP_REASS_FLAG_LASTFRAG;
+    ipr->datagram_len = offset + len;
+    LWIP_DEBUGF(IP_REASS_DEBUG,
+     ("ip4_reass: last fragment seen, total len %"S16_F"\n",
+      ipr->datagram_len));
  }
  /* find the right place to insert this pbuf */
  /* @todo: trim pbufs if fragments are overlapping */
-  valid = ip_reass_chain_frag_into_datagram_and_validate(ipr, p, is_last);
-  if (valid == IP_REASS_VALIDATE_PBUF_DROPPED) {
-    goto nullreturn_ipr;
-  }
-  /* if we come here, the pbuf has been enqueued */
-
-  /* Track the current number of pbufs current 'in-flight', in order to limit
-     the number of fragments that may be enqueued at any one time
-     (overflow checked by testing against IP_REASS_MAX_PBUFS) */
-  ip_reass_pbufcount = (u16_t)(ip_reass_pbufcount + clen);
-  if (is_last) {
-    u16_t datagram_len = (u16_t)(offset + len);
-    ipr->datagram_len = datagram_len;
-    ipr->flags |= IP_REASS_FLAG_LASTFRAG;
-    LWIP_DEBUGF(IP_REASS_DEBUG,
-                ("ip4_reass: last fragment seen, total len %"S16_F"\n",
-                 ipr->datagram_len));
-  }
-
-  if (valid == IP_REASS_VALIDATE_TELEGRAM_FINISHED) {
+  if (ip_reass_chain_frag_into_datagram_and_validate(ipr, p)) {
    struct ip_reassdata *ipr_prev;
    /* the totally last fragment (flag more fragments = 0) was received at least
     * once AND all fragments are received */
-    u16_t datagram_len = (u16_t)(ipr->datagram_len + IP_HLEN);
+    ipr->datagram_len += IP_HLEN;

    /* save the second pbuf before copying the header over the pointer */
-    r = ((struct ip_reass_helper *)ipr->p->payload)->next_pbuf;
+    r = ((struct ip_reass_helper*)ipr->p->payload)->next_pbuf;

    /* copy the original ip header back to the first pbuf */
-    fraghdr = (struct ip_hdr *)(ipr->p->payload);
+    fraghdr = (struct ip_hdr*)(ipr->p->payload);
    SMEMCPY(fraghdr, &ipr->iphdr, IP_HLEN);
-    IPH_LEN_SET(fraghdr, lwip_htons(datagram_len));
+    IPH_LEN_SET(fraghdr, lwip_htons(ipr->datagram_len));
    IPH_OFFSET_SET(fraghdr, 0);
    IPH_CHKSUM_SET(fraghdr, 0);
    /* @todo: do we need to set/calculate the correct checksum? */
@@ -640,10 +595,10 @@ ip4_reass(struct pbuf *p)

    /* chain together the pbufs contained within the reass_data list. */
    while (r != NULL) {
-      iprh = (struct ip_reass_helper *)r->payload;
+      iprh = (struct ip_reass_helper*)r->payload;

      /* hide the ip header for every succeeding fragment */
-      pbuf_remove_header(r, IP_HLEN);
+      pbuf_header(r, -IP_HLEN);
      pbuf_cat(p, r);
      r = iprh->next_pbuf;
    }
@@ -663,9 +618,7 @@ ip4_reass(struct pbuf *p)
    ip_reass_dequeue_datagram(ipr, ipr_prev);

    /* and adjust the number of pbufs currently queued for reassembly. */
-    clen = pbuf_clen(p);
-    LWIP_ASSERT("ip_reass_pbufcount >= clen", ip_reass_pbufcount >= clen);
-    ip_reass_pbufcount = (u16_t)(ip_reass_pbufcount - clen);
+    ip_reass_pbufcount -= pbuf_clen(p);

    MIB2_STATS_INC(mib2.ipreasmoks);

@@ -673,19 +626,11 @@ ip4_reass(struct pbuf *p)
    return p;
  }
  /* the datagram is not (yet?) reassembled completely */
-  LWIP_DEBUGF(IP_REASS_DEBUG, ("ip_reass_pbufcount: %d out\n", ip_reass_pbufcount));
+  LWIP_DEBUGF(IP_REASS_DEBUG,("ip_reass_pbufcount: %d out\n", ip_reass_pbufcount));
  return NULL;

-nullreturn_ipr:
-  LWIP_ASSERT("ipr != NULL", ipr != NULL);
-  if (ipr->p == NULL) {
-    /* dropped pbuf after creating a new datagram entry: remove the entry, too */
-    LWIP_ASSERT("not firstalthough just enqueued", ipr == reassdatagrams);
-    ip_reass_dequeue_datagram(ipr, NULL);
-  }
-
 nullreturn:
-  LWIP_DEBUGF(IP_REASS_DEBUG, ("ip4_reass: nullreturn\n"));
+  LWIP_DEBUGF(IP_REASS_DEBUG,("ip4_reass: nullreturn\n"));
  IPFRAG_STATS_INC(ip_frag.drop);
  pbuf_free(p);
  return NULL;
@@ -695,15 +640,15 @@ nullreturn:
 #if IP_FRAG
 #if !LWIP_NETIF_TX_SINGLE_PBUF
 /** Allocate a new struct pbuf_custom_ref */
-static struct pbuf_custom_ref *
+static struct pbuf_custom_ref*
 ip_frag_alloc_pbuf_custom_ref(void)
 {
-  return (struct pbuf_custom_ref *)memp_malloc(MEMP_FRAG_PBUF);
+  return (struct pbuf_custom_ref*)memp_malloc(MEMP_FRAG_PBUF);
 }

 /** Free a struct pbuf_custom_ref */
 static void
-ip_frag_free_pbuf_custom_ref(struct pbuf_custom_ref *p)
+ip_frag_free_pbuf_custom_ref(struct pbuf_custom_ref* p)
 {
  LWIP_ASSERT("p != NULL", p != NULL);
  memp_free(MEMP_FRAG_PBUF, p);
@@ -714,9 +659,9 @@ ip_frag_free_pbuf_custom_ref(struct pbuf_custom_ref *p)
 static void
 ipfrag_free_pbuf_custom(struct pbuf *p)
 {
-  struct pbuf_custom_ref *pcr = (struct pbuf_custom_ref *)p;
+  struct pbuf_custom_ref *pcr = (struct pbuf_custom_ref*)p;
  LWIP_ASSERT("pcr != NULL", pcr != NULL);
-  LWIP_ASSERT("pcr == p", (void *)pcr == (void *)p);
+  LWIP_ASSERT("pcr == p", (void*)pcr == (void*)p);
  if (pcr->original != NULL) {
    pbuf_free(pcr->original);
  }
@@ -747,33 +692,27 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
 #endif
  struct ip_hdr *original_iphdr;
  struct ip_hdr *iphdr;
-  const u16_t nfb = (u16_t)((netif->mtu - IP_HLEN) / 8);
+  const u16_t nfb = (netif->mtu - IP_HLEN) / 8;
  u16_t left, fragsize;
  u16_t ofo;
  int last;
  u16_t poff = IP_HLEN;
  u16_t tmp;
-  int mf_set;

  original_iphdr = (struct ip_hdr *)p->payload;
  iphdr = original_iphdr;
-  if (IPH_HL_BYTES(iphdr) != IP_HLEN) {
-    /* ip4_frag() does not support IP options */
-    return ERR_VAL;
-  }
-  LWIP_ERROR("ip4_frag(): pbuf too short", p->len >= IP_HLEN, return ERR_VAL);
+  LWIP_ERROR("ip4_frag() does not support IP options", IPH_HL(iphdr) * 4 == IP_HLEN, return ERR_VAL);

  /* Save original offset */
  tmp = lwip_ntohs(IPH_OFFSET(iphdr));
  ofo = tmp & IP_OFFMASK;
-  /* already fragmented? if so, the last fragment we create must have MF, too */
-  mf_set = tmp & IP_MF;
+  LWIP_ERROR("ip_frag(): MF already set", (tmp & IP_MF) == 0, return ERR_VAL);

-  left = (u16_t)(p->tot_len - IP_HLEN);
+  left = p->tot_len - IP_HLEN;

  while (left) {
    /* Fill this fragment */
-    fragsize = LWIP_MIN(left, (u16_t)(nfb * 8));
+    fragsize = LWIP_MIN(left, nfb * 8);

 #if LWIP_NETIF_TX_SINGLE_PBUF
    rambuf = pbuf_alloc(PBUF_IP, fragsize, PBUF_RAM);
@@ -781,16 +720,16 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
      goto memerr;
    }
    LWIP_ASSERT("this needs a pbuf in one piece!",
-                (rambuf->len == rambuf->tot_len) && (rambuf->next == NULL));
+      (rambuf->len == rambuf->tot_len) && (rambuf->next == NULL));
    poff += pbuf_copy_partial(p, rambuf->payload, fragsize, poff);
    /* make room for the IP header */
-    if (pbuf_add_header(rambuf, IP_HLEN)) {
+    if (pbuf_header(rambuf, IP_HLEN)) {
      pbuf_free(rambuf);
      goto memerr;
    }
    /* fill in the IP header */
    SMEMCPY(rambuf->payload, original_iphdr, IP_HLEN);
-    iphdr = (struct ip_hdr *)rambuf->payload;
+    iphdr = (struct ip_hdr*)rambuf->payload;
 #else /* LWIP_NETIF_TX_SINGLE_PBUF */
    /* When not using a static buffer, create a chain of pbufs.
     * The first will be a PBUF_RAM holding the link and IP header.
@@ -802,15 +741,14 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
      goto memerr;
    }
    LWIP_ASSERT("this needs a pbuf in one piece!",
-                (rambuf->len >= (IP_HLEN)));
+                (p->len >= (IP_HLEN)));
    SMEMCPY(rambuf->payload, original_iphdr, IP_HLEN);
    iphdr = (struct ip_hdr *)rambuf->payload;

    left_to_copy = fragsize;
    while (left_to_copy) {
      struct pbuf_custom_ref *pcr;
-      u16_t plen = (u16_t)(p->len - poff);
-      LWIP_ASSERT("p->len >= poff", p->len >= poff);
+      u16_t plen = p->len - poff;
      newpbuflen = LWIP_MIN(left_to_copy, plen);
      /* Is this pbuf already empty? */
      if (!newpbuflen) {
@@ -825,7 +763,7 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
      }
      /* Mirror this pbuf, although we might not need all of it. */
      newpbuf = pbuf_alloced_custom(PBUF_RAW, newpbuflen, PBUF_REF, &pcr->pc,
-                                    (u8_t *)p->payload + poff, newpbuflen);
+        (u8_t*)p->payload + poff, newpbuflen);
      if (newpbuf == NULL) {
        ip_frag_free_pbuf_custom_ref(pcr);
        pbuf_free(rambuf);
@@ -839,13 +777,13 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
       * so that it is removed when pbuf_dechain is later called on rambuf.
       */
      pbuf_cat(rambuf, newpbuf);
-      left_to_copy = (u16_t)(left_to_copy - newpbuflen);
+      left_to_copy -= newpbuflen;
      if (left_to_copy) {
        poff = 0;
        p = p->next;
      }
    }
-    poff = (u16_t)(poff + newpbuflen);
+    poff += newpbuflen;
 #endif /* LWIP_NETIF_TX_SINGLE_PBUF */

    /* Correct header */
@@ -853,12 +791,11 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)

    /* Set new offset and MF flag */
    tmp = (IP_OFFMASK & (ofo));
-    if (!last || mf_set) {
-      /* the last fragment has MF set if the input frame had it */
+    if (!last) {
      tmp = tmp | IP_MF;
    }
    IPH_OFFSET_SET(iphdr, lwip_htons(tmp));
-    IPH_LEN_SET(iphdr, lwip_htons((u16_t)(fragsize + IP_HLEN)));
+    IPH_LEN_SET(iphdr, lwip_htons(fragsize + IP_HLEN));
    IPH_CHKSUM_SET(iphdr, 0);
 #if CHECKSUM_GEN_IP
    IF__NETIF_CHECKSUM_ENABLED(netif, NETIF_CHECKSUM_GEN_IP) {
@@ -880,8 +817,8 @@ ip4_frag(struct pbuf *p, struct netif *netif, const ip4_addr_t *dest)
     */

    pbuf_free(rambuf);
-    left = (u16_t)(left - fragsize);
-    ofo = (u16_t)(ofo + nfb);
+    left -= fragsize;
+    ofo += nfb;
  }
  MIB2_STATS_INC(mib2.ipfragoks);
  return ERR_OK;
--- a/src/core/ipv6/dhcp6.c
+++ b/src/core/ipv6/dhcp6.c
@@ -1,31 +1,11 @@
 /**
 * @file
 *
- * @defgroup dhcp6 DHCPv6
- * @ingroup ip6
- * DHCPv6 client: IPv6 address autoconfiguration as per
- * RFC 3315 (stateful DHCPv6) and
- * RFC 3736 (stateless DHCPv6).
- *
- * For now, only stateless DHCPv6 is implemented!
- *
- * TODO:
- * - enable/disable API to not always start when RA is received
- * - stateful DHCPv6 (for now, only stateless DHCPv6 for DNS and NTP servers works)
- * - create Client Identifier?
- * - only start requests if a valid local address is available on the netif
- * - only start information requests if required (not for every RA)
- *
- * dhcp6_enable_stateful() enables stateful DHCPv6 for a netif (stateless disabled)\n
- * dhcp6_enable_stateless() enables stateless DHCPv6 for a netif (stateful disabled)\n
- * dhcp6_disable() disable DHCPv6 for a netif
- *
- * When enabled, requests are only issued after receipt of RA with the
- * corresponding bits set.
+ * DHCPv6.
 */

 /*
- * Copyright (c) 2018 Simon Goldschmidt
+ * Copyright (c) 2010 Inico Technologies Ltd.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without modification,
@@ -52,761 +32,19 @@
 *
 * This file is part of the lwIP TCP/IP stack.
 *
- * Author: Simon Goldschmidt <goldsimon@gmx.de>
+ * Author: Ivan Delamer <delamer@inicotech.com>
+ *
+ *
+ * Please coordinate changes and requests with Ivan Delamer
+ * <delamer@inicotech.com>
 */

 #include "lwip/opt.h"

 #if LWIP_IPV6 && LWIP_IPV6_DHCP6 /* don't build if not configured for use in lwipopts.h */

-#include "lwip/dhcp6.h"
-#include "lwip/prot/dhcp6.h"
+#include "lwip/ip6_addr.h"
 #include "lwip/def.h"
-#include "lwip/udp.h"
-#include "lwip/dns.h"

-#include <string.h>
-
-#ifdef LWIP_HOOK_FILENAME
-#include LWIP_HOOK_FILENAME
-#endif
-#ifndef LWIP_HOOK_DHCP6_APPEND_OPTIONS
-#define LWIP_HOOK_DHCP6_APPEND_OPTIONS(netif, dhcp6, state, msg, msg_type, options_len_ptr, max_len)
-#endif
-#ifndef LWIP_HOOK_DHCP6_PARSE_OPTION
-#define LWIP_HOOK_DHCP6_PARSE_OPTION(netif, dhcp6, state, msg, msg_type, option, len, pbuf, offset) do { LWIP_UNUSED_ARG(msg); } while(0)
-#endif
-
-#if LWIP_DNS && LWIP_DHCP6_MAX_DNS_SERVERS
-#if DNS_MAX_SERVERS > LWIP_DHCP6_MAX_DNS_SERVERS
-#define LWIP_DHCP6_PROVIDE_DNS_SERVERS LWIP_DHCP6_MAX_DNS_SERVERS
-#else
-#define LWIP_DHCP6_PROVIDE_DNS_SERVERS DNS_MAX_SERVERS
-#endif
-#else
-#define LWIP_DHCP6_PROVIDE_DNS_SERVERS 0
-#endif
-
-
-/** Option handling: options are parsed in dhcp6_parse_reply
- * and saved in an array where other functions can load them from.
- * This might be moved into the struct dhcp6 (not necessarily since
- * lwIP is single-threaded and the array is only used while in recv
- * callback). */
-enum dhcp6_option_idx {
-  DHCP6_OPTION_IDX_CLI_ID = 0,
-  DHCP6_OPTION_IDX_SERVER_ID,
-#if LWIP_DHCP6_PROVIDE_DNS_SERVERS
-  DHCP6_OPTION_IDX_DNS_SERVER,
-  DHCP6_OPTION_IDX_DOMAIN_LIST,
-#endif /* LWIP_DHCP_PROVIDE_DNS_SERVERS */
-#if LWIP_DHCP6_GET_NTP_SRV
-  DHCP6_OPTION_IDX_NTP_SERVER,
-#endif /* LWIP_DHCP_GET_NTP_SRV */
-  DHCP6_OPTION_IDX_MAX
-};
-
-struct dhcp6_option_info {
-  u8_t option_given;
-  u16_t val_start;
-  u16_t val_length;
-};
-
-/** Holds the decoded option info, only valid while in dhcp6_recv. */
-struct dhcp6_option_info dhcp6_rx_options[DHCP6_OPTION_IDX_MAX];
-
-#define dhcp6_option_given(dhcp6, idx)           (dhcp6_rx_options[idx].option_given != 0)
-#define dhcp6_got_option(dhcp6, idx)             (dhcp6_rx_options[idx].option_given = 1)
-#define dhcp6_clear_option(dhcp6, idx)           (dhcp6_rx_options[idx].option_given = 0)
-#define dhcp6_clear_all_options(dhcp6)           (memset(dhcp6_rx_options, 0, sizeof(dhcp6_rx_options)))
-#define dhcp6_get_option_start(dhcp6, idx)       (dhcp6_rx_options[idx].val_start)
-#define dhcp6_get_option_length(dhcp6, idx)      (dhcp6_rx_options[idx].val_length)
-#define dhcp6_set_option(dhcp6, idx, start, len) do { dhcp6_rx_options[idx].val_start = (start); dhcp6_rx_options[idx].val_length = (len); }while(0)
-
-
-const ip_addr_t dhcp6_All_DHCP6_Relay_Agents_and_Servers = IPADDR6_INIT_HOST(0xFF020000, 0, 0, 0x00010002);
-const ip_addr_t dhcp6_All_DHCP6_Servers = IPADDR6_INIT_HOST(0xFF020000, 0, 0, 0x00010003);
-
-static struct udp_pcb *dhcp6_pcb;
-static u8_t dhcp6_pcb_refcount;
-
-
-/* receive, unfold, parse and free incoming messages */
-static void dhcp6_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr, u16_t port);
-
-/** Ensure DHCP PCB is allocated and bound */
-static err_t
-dhcp6_inc_pcb_refcount(void)
-{
-  if (dhcp6_pcb_refcount == 0) {
-    LWIP_ASSERT("dhcp6_inc_pcb_refcount(): memory leak", dhcp6_pcb == NULL);
-
-    /* allocate UDP PCB */
-    dhcp6_pcb = udp_new_ip6();
-
-    if (dhcp6_pcb == NULL) {
-      return ERR_MEM;
-    }
-
-    ip_set_option(dhcp6_pcb, SOF_BROADCAST);
-
-    /* set up local and remote port for the pcb -> listen on all interfaces on all src/dest IPs */
-    udp_bind(dhcp6_pcb, IP6_ADDR_ANY, DHCP6_CLIENT_PORT);
-    udp_recv(dhcp6_pcb, dhcp6_recv, NULL);
-  }
-
-  dhcp6_pcb_refcount++;
-
-  return ERR_OK;
-}
-
-/** Free DHCP PCB if the last netif stops using it */
-static void
-dhcp6_dec_pcb_refcount(void)
-{
-  LWIP_ASSERT("dhcp6_pcb_refcount(): refcount error", (dhcp6_pcb_refcount > 0));
-  dhcp6_pcb_refcount--;
-
-  if (dhcp6_pcb_refcount == 0) {
-    udp_remove(dhcp6_pcb);
-    dhcp6_pcb = NULL;
-  }
-}
-
-/**
- * @ingroup dhcp6
- * Set a statically allocated struct dhcp6 to work with.
- * Using this prevents dhcp6_start to allocate it using mem_malloc.
- *
- * @param netif the netif for which to set the struct dhcp
- * @param dhcp6 (uninitialised) dhcp6 struct allocated by the application
- */
-void
-dhcp6_set_struct(struct netif *netif, struct dhcp6 *dhcp6)
-{
-  LWIP_ASSERT("netif != NULL", netif != NULL);
-  LWIP_ASSERT("dhcp6 != NULL", dhcp6 != NULL);
-  LWIP_ASSERT("netif already has a struct dhcp6 set", netif_dhcp6_data(netif) == NULL);
-
-  /* clear data structure */
-  memset(dhcp6, 0, sizeof(struct dhcp6));
-  /* dhcp6_set_state(&dhcp, DHCP6_STATE_OFF); */
-  netif_set_client_data(netif, LWIP_NETIF_CLIENT_DATA_INDEX_DHCP6, dhcp6);
-}
-
-/**
- * @ingroup dhcp6
- * Removes a struct dhcp6 from a netif.
- *
- * ATTENTION: Only use this when not using dhcp6_set_struct() to allocate the
- *            struct dhcp6 since the memory is passed back to the heap.
- *
- * @param netif the netif from which to remove the struct dhcp
- */
-void dhcp6_cleanup(struct netif *netif)
-{
-  LWIP_ASSERT("netif != NULL", netif != NULL);
-
-  if (netif_dhcp6_data(netif) != NULL) {
-    mem_free(netif_dhcp6_data(netif));
-    netif_set_client_data(netif, LWIP_NETIF_CLIENT_DATA_INDEX_DHCP6, NULL);
-  }
-}
-
-static struct dhcp6*
-dhcp6_get_struct(struct netif *netif, const char *dbg_requester)
-{
-  struct dhcp6 *dhcp6 = netif_dhcp6_data(netif);
-  if (dhcp6 == NULL) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("%s: mallocing new DHCPv6 client\n", dbg_requester));
-    dhcp6 = (struct dhcp6 *)mem_malloc(sizeof(struct dhcp6));
-    if (dhcp6 == NULL) {
-      LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("%s: could not allocate dhcp6\n", dbg_requester));
-      return NULL;
-    }
-
-    /* clear data structure, this implies DHCP6_STATE_OFF */
-    memset(dhcp6, 0, sizeof(struct dhcp6));
-    /* store this dhcp6 client in the netif */
-    netif_set_client_data(netif, LWIP_NETIF_CLIENT_DATA_INDEX_DHCP6, dhcp6);
-  } else {
-    /* already has DHCP6 client attached */
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("%s: using existing DHCPv6 client\n", dbg_requester));
-  }
-
-  if (!dhcp6->pcb_allocated) {
-    if (dhcp6_inc_pcb_refcount() != ERR_OK) { /* ensure DHCP6 PCB is allocated */
-      mem_free(dhcp6);
-      netif_set_client_data(netif, LWIP_NETIF_CLIENT_DATA_INDEX_DHCP6, NULL);
-      return NULL;
-    }
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("%s: allocated dhcp6", dbg_requester));
-    dhcp6->pcb_allocated = 1;
-  }
-  return dhcp6;
-}
-
-/*
- * Set the DHCPv6 state
- * If the state changed, reset the number of tries.
- */
-static void
-dhcp6_set_state(struct dhcp6 *dhcp6, u8_t new_state, const char *dbg_caller)
-{
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("DHCPv6 state: %d -> %d (%s)\n",
-    dhcp6->state, new_state, dbg_caller));
-  if (new_state != dhcp6->state) {
-    dhcp6->state = new_state;
-    dhcp6->tries = 0;
-    dhcp6->request_timeout = 0;
-  }
-}
-
-static int
-dhcp6_stateless_enabled(struct dhcp6 *dhcp6)
-{
-  if ((dhcp6->state == DHCP6_STATE_STATELESS_IDLE) ||
-      (dhcp6->state == DHCP6_STATE_REQUESTING_CONFIG)) {
-    return 1;
-  }
-  return 0;
-}
-
-/*static int
-dhcp6_stateful_enabled(struct dhcp6 *dhcp6)
-{
-  if (dhcp6->state == DHCP6_STATE_OFF) {
-    return 0;
-  }
-  if (dhcp6_stateless_enabled(dhcp6)) {
-    return 0;
-  }
-  return 1;
-}*/
-
-/**
- * @ingroup dhcp6
- * Enable stateful DHCPv6 on this netif
- * Requests are sent on receipt of an RA message with the
- * ND6_RA_FLAG_MANAGED_ADDR_CONFIG flag set.
- *
- * A struct dhcp6 will be allocated for this netif if not
- * set via @ref dhcp6_set_struct before.
- *
- * @todo: stateful DHCPv6 not supported, yet
- */
-err_t
-dhcp6_enable_stateful(struct netif *netif)
-{
-  LWIP_UNUSED_ARG(netif);
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("stateful dhcp6 not implemented yet"));
-  return ERR_VAL;
-}
-
-/**
- * @ingroup dhcp6
- * Enable stateless DHCPv6 on this netif
- * Requests are sent on receipt of an RA message with the
- * ND6_RA_FLAG_OTHER_CONFIG flag set.
- *
- * A struct dhcp6 will be allocated for this netif if not
- * set via @ref dhcp6_set_struct before.
- */
-err_t
-dhcp6_enable_stateless(struct netif *netif)
-{
-  struct dhcp6 *dhcp6;
-
-  LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("dhcp6_enable_stateless(netif=%p) %c%c%"U16_F"\n", (void *)netif, netif->name[0], netif->name[1], (u16_t)netif->num));
-
-  dhcp6 = dhcp6_get_struct(netif, "dhcp6_enable_stateless()");
-  if (dhcp6 == NULL) {
-    return ERR_MEM;
-  }
-  if (dhcp6_stateless_enabled(dhcp6)) {
-    LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE, ("dhcp6_enable_stateless(): stateless DHCPv6 already enabled"));
-    return ERR_OK;
-  } else if (dhcp6->state != DHCP6_STATE_OFF) {
-    /* stateful running */
-    /* @todo: stop stateful once it is implemented */
-    LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE, ("dhcp6_enable_stateless(): switching from stateful to stateless DHCPv6"));
-  }
-  LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE, ("dhcp6_enable_stateless(): stateless DHCPv6 enabled\n"));
-  dhcp6_set_state(dhcp6, DHCP6_STATE_STATELESS_IDLE, "dhcp6_enable_stateless");
-  return ERR_OK;
-}
-
-/**
- * @ingroup dhcp6
- * Disable stateful or stateless DHCPv6 on this netif
- * Requests are sent on receipt of an RA message with the
- * ND6_RA_FLAG_OTHER_CONFIG flag set.
- */
-void
-dhcp6_disable(struct netif *netif)
-{
-  struct dhcp6 *dhcp6;
-
-  LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("dhcp6_disable(netif=%p) %c%c%"U16_F"\n", (void *)netif, netif->name[0], netif->name[1], (u16_t)netif->num));
-
-  dhcp6 = netif_dhcp6_data(netif);
-  if (dhcp6 != NULL) {
-    if (dhcp6->state != DHCP6_STATE_OFF) {
-      LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("dhcp6_disable(): DHCPv6 disabled (old state: %s)\n",
-        (dhcp6_stateless_enabled(dhcp6) ? "stateless" : "stateful")));
-      dhcp6_set_state(dhcp6, DHCP6_STATE_OFF, "dhcp6_disable");
-      if (dhcp6->pcb_allocated != 0) {
-        dhcp6_dec_pcb_refcount(); /* free DHCPv6 PCB if not needed any more */
-        dhcp6->pcb_allocated = 0;
-      }
-    }
-  }
-}
-
-/**
- * Create a DHCPv6 request, fill in common headers
- *
- * @param netif the netif under DHCPv6 control
- * @param dhcp6 dhcp6 control struct
- * @param message_type message type of the request
- * @param opt_len_alloc option length to allocate
- * @param options_out_len option length on exit
- * @return a pbuf for the message
- */
-static struct pbuf *
-dhcp6_create_msg(struct netif *netif, struct dhcp6 *dhcp6, u8_t message_type,
-                 u16_t opt_len_alloc, u16_t *options_out_len)
-{
-  struct pbuf *p_out;
-  struct dhcp6_msg *msg_out;
-
-  LWIP_ERROR("dhcp6_create_msg: netif != NULL", (netif != NULL), return NULL;);
-  LWIP_ERROR("dhcp6_create_msg: dhcp6 != NULL", (dhcp6 != NULL), return NULL;);
-  p_out = pbuf_alloc(PBUF_TRANSPORT, sizeof(struct dhcp6_msg) + opt_len_alloc, PBUF_RAM);
-  if (p_out == NULL) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_SERIOUS,
-                ("dhcp6_create_msg(): could not allocate pbuf\n"));
-    return NULL;
-  }
-  LWIP_ASSERT("dhcp6_create_msg: check that first pbuf can hold struct dhcp6_msg",
-              (p_out->len >= sizeof(struct dhcp6_msg) + opt_len_alloc));
-
-  /* @todo: limit new xid for certain message types? */
-  /* reuse transaction identifier in retransmissions */
-  if (dhcp6->tries == 0) {
-    dhcp6->xid = LWIP_RAND() & 0xFFFFFF;
-  }
-
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE,
-              ("transaction id xid(%"X32_F")\n", dhcp6->xid));
-
-  msg_out = (struct dhcp6_msg *)p_out->payload;
-  memset(msg_out, 0, sizeof(struct dhcp6_msg) + opt_len_alloc);
-
-  msg_out->msgtype = message_type;
-  msg_out->transaction_id[0] = (u8_t)(dhcp6->xid >> 16);
-  msg_out->transaction_id[1] = (u8_t)(dhcp6->xid >> 8);
-  msg_out->transaction_id[2] = (u8_t)dhcp6->xid;
-  *options_out_len = 0;
-  return p_out;
-}
-
-static u16_t
-dhcp6_option_short(u16_t options_out_len, u8_t *options, u16_t value)
-{
-  options[options_out_len++] = (u8_t)((value & 0xff00U) >> 8);
-  options[options_out_len++] = (u8_t) (value & 0x00ffU);
-  return options_out_len;
-}
-
-static u16_t
-dhcp6_option_optionrequest(u16_t options_out_len, u8_t *options, const u16_t *req_options,
-                           u16_t num_req_options, u16_t max_len)
-{
-  size_t i;
-  u16_t ret;
-
-  LWIP_ASSERT("dhcp6_option_optionrequest: options_out_len + sizeof(struct dhcp6_msg) + addlen <= max_len",
-    sizeof(struct dhcp6_msg) + options_out_len + 4U + (2U * num_req_options) <= max_len);
-  LWIP_UNUSED_ARG(max_len);
-
-  ret = dhcp6_option_short(options_out_len, options, DHCP6_OPTION_ORO);
-  ret = dhcp6_option_short(ret, options, 2 * num_req_options);
-  for (i = 0; i < num_req_options; i++) {
-    ret = dhcp6_option_short(ret, options, req_options[i]);
-  }
-  return ret;
-}
-
-/* All options are added, shrink the pbuf to the required size */
-static void
-dhcp6_msg_finalize(u16_t options_out_len, struct pbuf *p_out)
-{
-  /* shrink the pbuf to the actual content length */
-  pbuf_realloc(p_out, (u16_t)(sizeof(struct dhcp6_msg) + options_out_len));
-}
-
-
-#if LWIP_IPV6_DHCP6_STATELESS
-static void
-dhcp6_information_request(struct netif *netif, struct dhcp6 *dhcp6)
-{
-  const u16_t requested_options[] = {DHCP6_OPTION_DNS_SERVERS, DHCP6_OPTION_DOMAIN_LIST, DHCP6_OPTION_SNTP_SERVERS};
-  u16_t msecs;
-  struct pbuf *p_out;
-  u16_t options_out_len;
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("dhcp6_information_request()\n"));
-  /* create and initialize the DHCP message header */
-  p_out = dhcp6_create_msg(netif, dhcp6, DHCP6_INFOREQUEST, 4 + sizeof(requested_options), &options_out_len);
-  if (p_out != NULL) {
-    err_t err;
-    struct dhcp6_msg *msg_out = (struct dhcp6_msg *)p_out->payload;
-    u8_t *options = (u8_t *)(msg_out + 1);
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("dhcp6_information_request: making request\n"));
-
-    options_out_len = dhcp6_option_optionrequest(options_out_len, options, requested_options,
-      LWIP_ARRAYSIZE(requested_options), p_out->len);
-    LWIP_HOOK_DHCP6_APPEND_OPTIONS(netif, dhcp6, DHCP6_STATE_REQUESTING_CONFIG, msg_out,
-      DHCP6_INFOREQUEST, options_out_len, p_out->len);
-    dhcp6_msg_finalize(options_out_len, p_out);
-
-    err = udp_sendto_if(dhcp6_pcb, p_out, &dhcp6_All_DHCP6_Relay_Agents_and_Servers, DHCP6_SERVER_PORT, netif);
-    pbuf_free(p_out);
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("dhcp6_information_request: INFOREQUESTING -> %d\n", (int)err));
-    LWIP_UNUSED_ARG(err);
-  } else {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_SERIOUS, ("dhcp6_information_request: could not allocate DHCP6 request\n"));
-  }
-  dhcp6_set_state(dhcp6, DHCP6_STATE_REQUESTING_CONFIG, "dhcp6_information_request");
-  if (dhcp6->tries < 255) {
-    dhcp6->tries++;
-  }
-  msecs = (u16_t)((dhcp6->tries < 6 ? 1 << dhcp6->tries : 60) * 1000);
-  dhcp6->request_timeout = (u16_t)((msecs + DHCP6_TIMER_MSECS - 1) / DHCP6_TIMER_MSECS);
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("dhcp6_information_request(): set request timeout %"U16_F" msecs\n", msecs));
-}
-
-static err_t
-dhcp6_request_config(struct netif *netif, struct dhcp6 *dhcp6)
-{
-  /* stateless mode enabled and no request running? */
-  if (dhcp6->state == DHCP6_STATE_STATELESS_IDLE) {
-    /* send Information-request and wait for answer; setup receive timeout */
-    dhcp6_information_request(netif, dhcp6);
-  }
-
-  return ERR_OK;
-}
-
-static void
-dhcp6_abort_config_request(struct dhcp6 *dhcp6)
-{
-  if (dhcp6->state == DHCP6_STATE_REQUESTING_CONFIG) {
-    /* abort running request */
-    dhcp6_set_state(dhcp6, DHCP6_STATE_STATELESS_IDLE, "dhcp6_abort_config_request");
-  }
-}
-
-/* Handle a REPLY to INFOREQUEST
- * This parses DNS and NTP server addresses from the reply.
- */
-static void
-dhcp6_handle_config_reply(struct netif *netif, struct pbuf *p_msg_in)
-{
-  struct dhcp6 *dhcp6 = netif_dhcp6_data(netif);
-
-  LWIP_UNUSED_ARG(dhcp6);
-  LWIP_UNUSED_ARG(p_msg_in);
-
-#if LWIP_DHCP6_PROVIDE_DNS_SERVERS
-  if (dhcp6_option_given(dhcp6, DHCP6_OPTION_IDX_DNS_SERVER)) {
-    ip_addr_t dns_addr;
-    ip6_addr_t *dns_addr6;
-    u16_t op_start = dhcp6_get_option_start(dhcp6, DHCP6_OPTION_IDX_DNS_SERVER);
-    u16_t op_len = dhcp6_get_option_length(dhcp6, DHCP6_OPTION_IDX_DNS_SERVER);
-    u16_t idx;
-    u8_t n;
-
-    memset(&dns_addr, 0, sizeof(dns_addr));
-    dns_addr6 = ip_2_ip6(&dns_addr);
-    for (n = 0, idx = op_start; (idx < op_start + op_len) && (n < LWIP_DHCP6_PROVIDE_DNS_SERVERS);
-         n++, idx += sizeof(struct ip6_addr_packed)) {
-      u16_t copied = pbuf_copy_partial(p_msg_in, dns_addr6, sizeof(struct ip6_addr_packed), idx);
-      if (copied != sizeof(struct ip6_addr_packed)) {
-        /* pbuf length mismatch */
-        return;
-      }
-      ip6_addr_assign_zone(dns_addr6, IP6_UNKNOWN, netif);
-      /* @todo: do we need a different offset than DHCP(v4)? */
-      dns_setserver(n, &dns_addr);
-    }
-  }
-  /* @ todo: parse and set Domain Search List */
-#endif /* LWIP_DHCP6_PROVIDE_DNS_SERVERS */
-
-#if LWIP_DHCP6_GET_NTP_SRV
-  if (dhcp6_option_given(dhcp6, DHCP6_OPTION_IDX_NTP_SERVER)) {
-    ip_addr_t ntp_server_addrs[LWIP_DHCP6_MAX_NTP_SERVERS];
-    u16_t op_start = dhcp6_get_option_start(dhcp6, DHCP6_OPTION_IDX_NTP_SERVER);
-    u16_t op_len = dhcp6_get_option_length(dhcp6, DHCP6_OPTION_IDX_NTP_SERVER);
-    u16_t idx;
-    u8_t n;
-
-    for (n = 0, idx = op_start; (idx < op_start + op_len) && (n < LWIP_DHCP6_MAX_NTP_SERVERS);
-         n++, idx += sizeof(struct ip6_addr_packed)) {
-      u16_t copied;
-      ip6_addr_t *ntp_addr6 = ip_2_ip6(&ntp_server_addrs[n]);
-      ip_addr_set_zero_ip6(&ntp_server_addrs[n]);
-      copied = pbuf_copy_partial(p_msg_in, ntp_addr6, sizeof(struct ip6_addr_packed), idx);
-      if (copied != sizeof(struct ip6_addr_packed)) {
-        /* pbuf length mismatch */
-        return;
-      }
-      ip6_addr_assign_zone(ntp_addr6, IP6_UNKNOWN, netif);
-    }
-    dhcp6_set_ntp_servers(n, ntp_server_addrs);
-  }
-#endif /* LWIP_DHCP6_GET_NTP_SRV */
-}
-#endif /* LWIP_IPV6_DHCP6_STATELESS */
-
-/** This function is called from nd6 module when an RA messsage is received
- * It triggers DHCPv6 requests (if enabled).
- */
-void
-dhcp6_nd6_ra_trigger(struct netif *netif, u8_t managed_addr_config, u8_t other_config)
-{
-  struct dhcp6 *dhcp6;
-
-  LWIP_ASSERT("netif != NULL", netif != NULL);
-  dhcp6 = netif_dhcp6_data(netif);
-
-  LWIP_UNUSED_ARG(managed_addr_config);
-  LWIP_UNUSED_ARG(other_config);
-  LWIP_UNUSED_ARG(dhcp6);
-
-#if LWIP_IPV6_DHCP6_STATELESS
-  if (dhcp6 != NULL) {
-    if (dhcp6_stateless_enabled(dhcp6)) {
-      if (other_config) {
-        dhcp6_request_config(netif, dhcp6);
-      } else {
-        dhcp6_abort_config_request(dhcp6);
-      }
-    }
-  }
-#endif /* LWIP_IPV6_DHCP6_STATELESS */
-}
-
-/**
- * Parse the DHCPv6 message and extract the DHCPv6 options.
- *
- * Extract the DHCPv6 options (offset + length) so that we can later easily
- * check for them or extract the contents.
- */
-static err_t
-dhcp6_parse_reply(struct pbuf *p, struct dhcp6 *dhcp6)
-{
-  u16_t offset;
-  u16_t offset_max;
-  u16_t options_idx;
-  struct dhcp6_msg *msg_in;
-
-  LWIP_UNUSED_ARG(dhcp6);
-
-  /* clear received options */
-  dhcp6_clear_all_options(dhcp6);
-  msg_in = (struct dhcp6_msg *)p->payload;
-
-  /* parse options */
-
-  options_idx = sizeof(struct dhcp6_msg);
-  /* parse options to the end of the received packet */
-  offset_max = p->tot_len;
-
-  offset = options_idx;
-  /* at least 4 byte to read? */
-  while ((offset + 4 <= offset_max)) {
-    u8_t op_len_buf[4];
-    u8_t *op_len;
-    u16_t op;
-    u16_t len;
-    u16_t val_offset = (u16_t)(offset + 4);
-    if (val_offset < offset) {
-      /* overflow */
-      return ERR_BUF;
-    }
-    /* copy option + length, might be split accross pbufs */
-    op_len = (u8_t *)pbuf_get_contiguous(p, op_len_buf, 4, 4, offset);
-    if (op_len == NULL) {
-      /* failed to get option and length */
-      return ERR_VAL;
-    }
-    op = (op_len[0] << 8) | op_len[1];
-    len = (op_len[2] << 8) | op_len[3];
-    offset = val_offset + len;
-    if (offset < val_offset) {
-      /* overflow */
-      return ERR_BUF;
-    }
-
-    switch (op) {
-      case (DHCP6_OPTION_CLIENTID):
-        dhcp6_got_option(dhcp6, DHCP6_OPTION_IDX_CLI_ID);
-        dhcp6_set_option(dhcp6, DHCP6_OPTION_IDX_CLI_ID, val_offset, len);
-        break;
-      case (DHCP6_OPTION_SERVERID):
-        dhcp6_got_option(dhcp6, DHCP6_OPTION_IDX_SERVER_ID);
-        dhcp6_set_option(dhcp6, DHCP6_OPTION_IDX_SERVER_ID, val_offset, len);
-        break;
-#if LWIP_DHCP6_PROVIDE_DNS_SERVERS
-      case (DHCP6_OPTION_DNS_SERVERS):
-        dhcp6_got_option(dhcp6, DHCP6_OPTION_IDX_DNS_SERVER);
-        dhcp6_set_option(dhcp6, DHCP6_OPTION_IDX_DNS_SERVER, val_offset, len);
-        break;
-      case (DHCP6_OPTION_DOMAIN_LIST):
-        dhcp6_got_option(dhcp6, DHCP6_OPTION_IDX_DOMAIN_LIST);
-        dhcp6_set_option(dhcp6, DHCP6_OPTION_IDX_DOMAIN_LIST, val_offset, len);
-        break;
-#endif /* LWIP_DHCP6_PROVIDE_DNS_SERVERS */
-#if LWIP_DHCP6_GET_NTP_SRV
-      case (DHCP6_OPTION_SNTP_SERVERS):
-        dhcp6_got_option(dhcp6, DHCP6_OPTION_IDX_NTP_SERVER);
-        dhcp6_set_option(dhcp6, DHCP6_OPTION_IDX_NTP_SERVER, val_offset, len);
-        break;
-#endif /* LWIP_DHCP6_GET_NTP_SRV*/
-      default:
-        LWIP_DEBUGF(DHCP6_DEBUG, ("skipping option %"U16_F" in options\n", op));
-        LWIP_HOOK_DHCP6_PARSE_OPTION(ip_current_netif(), dhcp6, dhcp6->state, msg_in,
-          msg_in->msgtype, op, len, q, val_offset);
-        break;
-    }
-  }
-  return ERR_OK;
-}
-
-static void
-dhcp6_recv(void *arg, struct udp_pcb *pcb, struct pbuf *p, const ip_addr_t *addr, u16_t port)
-{
-  struct netif *netif = ip_current_input_netif();
-  struct dhcp6 *dhcp6 = netif_dhcp6_data(netif);
-  struct dhcp6_msg *reply_msg = (struct dhcp6_msg *)p->payload;
-  u8_t msg_type;
-  u32_t xid;
-
-  LWIP_UNUSED_ARG(arg);
-
-  /* Caught DHCPv6 message from netif that does not have DHCPv6 enabled? -> not interested */
-  if ((dhcp6 == NULL) || (dhcp6->pcb_allocated == 0)) {
-    goto free_pbuf_and_return;
-  }
-
-  LWIP_ERROR("invalid server address type", IP_IS_V6(addr), goto free_pbuf_and_return;);
-
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("dhcp6_recv(pbuf = %p) from DHCPv6 server %s port %"U16_F"\n", (void *)p,
-    ipaddr_ntoa(addr), port));
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("pbuf->len = %"U16_F"\n", p->len));
-  LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("pbuf->tot_len = %"U16_F"\n", p->tot_len));
-  /* prevent warnings about unused arguments */
-  LWIP_UNUSED_ARG(pcb);
-  LWIP_UNUSED_ARG(addr);
-  LWIP_UNUSED_ARG(port);
-
-  if (p->len < sizeof(struct dhcp6_msg)) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_WARNING, ("DHCPv6 reply message or pbuf too short\n"));
-    goto free_pbuf_and_return;
-  }
-
-  /* match transaction ID against what we expected */
-  xid = reply_msg->transaction_id[0] << 16;
-  xid |= reply_msg->transaction_id[1] << 8;
-  xid |= reply_msg->transaction_id[2];
-  if (xid != dhcp6->xid) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_WARNING,
-                ("transaction id mismatch reply_msg->xid(%"X32_F")!= dhcp6->xid(%"X32_F")\n", xid, dhcp6->xid));
-    goto free_pbuf_and_return;
-  }
-  /* option fields could be unfold? */
-  if (dhcp6_parse_reply(p, dhcp6) != ERR_OK) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_SERIOUS,
-                ("problem unfolding DHCPv6 message - too short on memory?\n"));
-    goto free_pbuf_and_return;
-  }
-
-  /* read DHCP message type */
-  msg_type = reply_msg->msgtype;
-  /* message type is DHCP6 REPLY? */
-  if (msg_type == DHCP6_REPLY) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("DHCP6_REPLY received\n"));
-#if LWIP_IPV6_DHCP6_STATELESS
-    /* in info-requesting state? */
-    if (dhcp6->state == DHCP6_STATE_REQUESTING_CONFIG) {
-      dhcp6_set_state(dhcp6, DHCP6_STATE_STATELESS_IDLE, "dhcp6_recv");
-      dhcp6_handle_config_reply(netif, p);
-    } else
-#endif /* LWIP_IPV6_DHCP6_STATELESS */
-    {
-      /* @todo: handle reply in other states? */
-    }
-  } else {
-    /* @todo: handle other message types */
-  }
-
-free_pbuf_and_return:
-  pbuf_free(p);
-}
-
-/**
- * A DHCPv6 request has timed out.
- *
- * The timer that was started with the DHCPv6 request has
- * timed out, indicating no response was received in time.
- */
-static void
-dhcp6_timeout(struct netif *netif, struct dhcp6 *dhcp6)
-{
-  LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE, ("dhcp6_timeout()\n"));
-
-  LWIP_UNUSED_ARG(netif);
-  LWIP_UNUSED_ARG(dhcp6);
-
-#if LWIP_IPV6_DHCP6_STATELESS
-  /* back-off period has passed, or server selection timed out */
-  if (dhcp6->state == DHCP6_STATE_REQUESTING_CONFIG) {
-    LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE, ("dhcp6_timeout(): retrying information request\n"));
-    dhcp6_information_request(netif, dhcp6);
-  }
-#endif /* LWIP_IPV6_DHCP6_STATELESS */
-}
-
-/**
- * DHCPv6 timeout handling (this function must be called every 500ms,
- * see @ref DHCP6_TIMER_MSECS).
- *
- * A DHCPv6 server is expected to respond within a short period of time.
- * This timer checks whether an outstanding DHCPv6 request is timed out.
- */
-void
-dhcp6_tmr(void)
-{
-  struct netif *netif;
-  /* loop through netif's */
-  NETIF_FOREACH(netif) {
-    struct dhcp6 *dhcp6 = netif_dhcp6_data(netif);
-    /* only act on DHCPv6 configured interfaces */
-    if (dhcp6 != NULL) {
-      /* timer is active (non zero), and is about to trigger now */
-      if (dhcp6->request_timeout > 1) {
-        dhcp6->request_timeout--;
-      } else if (dhcp6->request_timeout == 1) {
-        dhcp6->request_timeout--;
-        /* { dhcp6->request_timeout == 0 } */
-        LWIP_DEBUGF(DHCP6_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_STATE, ("dhcp6_tmr(): request timeout\n"));
-        /* this client's request timeout triggered */
-        dhcp6_timeout(netif, dhcp6);
-      }
-    }
-  }
-}

 #endif /* LWIP_IPV6 && LWIP_IPV6_DHCP6 */
--- a/src/core/ipv6/ethip6.c
+++ b/src/core/ipv6/ethip6.c
@@ -82,11 +82,6 @@ ethip6_output(struct netif *netif, struct pbuf *q, const ip6_addr_t *ip6addr)
  const u8_t *hwaddr;
  err_t result;

-  LWIP_ASSERT_CORE_LOCKED();
-
-  /* The destination IP address must be properly zoned from here on down. */
-  IP6_ADDR_ZONECHECK_NETIF(ip6addr, netif);
-
  /* multicast destination IP address? */
  if (ip6_addr_ismulticast(ip6addr)) {
    /* Hash IP multicast address to MAC address.*/
--- a/src/core/ipv6/icmp6.c
+++ b/src/core/ipv6/icmp6.c
@@ -57,17 +57,15 @@

 #include <string.h>

+#ifndef LWIP_ICMP6_DATASIZE
+#define LWIP_ICMP6_DATASIZE   8
+#endif
 #if LWIP_ICMP6_DATASIZE == 0
-#undef LWIP_ICMP6_DATASIZE
 #define LWIP_ICMP6_DATASIZE   8
 #endif

 /* Forward declarations */
 static void icmp6_send_response(struct pbuf *p, u8_t code, u32_t data, u8_t type);
-static void icmp6_send_response_with_addrs(struct pbuf *p, u8_t code, u32_t data,
-    u8_t type, const ip6_addr_t *src_addr, const ip6_addr_t *dest_addr);
-static void icmp6_send_response_with_addrs_and_netif(struct pbuf *p, u8_t code, u32_t data,
-    u8_t type, const ip6_addr_t *src_addr, const ip6_addr_t *dest_addr, struct netif *netif);


 /**
@@ -120,6 +118,7 @@ icmp6_input(struct pbuf *p, struct netif *inp)
  case ICMP6_TYPE_PTB: /* Packet too big */
    nd6_input(p, inp);
    return;
+    break;
  case ICMP6_TYPE_RS:
 #if LWIP_IPV6_FORWARD
    /* @todo implement router functionality */
@@ -131,6 +130,7 @@ icmp6_input(struct pbuf *p, struct netif *inp)
  case ICMP6_TYPE_MLD:
    mld6_input(p, inp);
    return;
+    break;
 #endif
  case ICMP6_TYPE_EREQ:
 #if !LWIP_MULTICAST_PING
@@ -209,9 +209,6 @@ icmp6_input(struct pbuf *p, struct netif *inp)
 /**
 * Send an icmpv6 'destination unreachable' packet.
 *
- * This function must be used only in direct response to a packet that is being
- * received right now. Otherwise, address zones would be lost.
- *
 * @param p the input packet for which the 'unreachable' should be sent,
 *          p->payload pointing to the IPv6 header
 * @param c ICMPv6 code for the unreachable type
@@ -225,9 +222,6 @@ icmp6_dest_unreach(struct pbuf *p, enum icmp6_dur_code c)
 /**
 * Send an icmpv6 'packet too big' packet.
 *
- * This function must be used only in direct response to a packet that is being
- * received right now. Otherwise, address zones would be lost.
- *
 * @param p the input packet for which the 'packet too big' should be sent,
 *          p->payload pointing to the IPv6 header
 * @param mtu the maximum mtu that we can accept
@@ -241,10 +235,7 @@ icmp6_packet_too_big(struct pbuf *p, u32_t mtu)
 /**
 * Send an icmpv6 'time exceeded' packet.
 *
- * This function must be used only in direct response to a packet that is being
- * received right now. Otherwise, address zones would be lost.
- *
- * @param p the input packet for which the 'time exceeded' should be sent,
+ * @param p the input packet for which the 'unreachable' should be sent,
 *          p->payload pointing to the IPv6 header
 * @param c ICMPv6 code for the time exceeded type
 */
@@ -254,50 +245,22 @@ icmp6_time_exceeded(struct pbuf *p, enum icmp6_te_code c)
  icmp6_send_response(p, c, 0, ICMP6_TYPE_TE);
 }

-/**
- * Send an icmpv6 'time exceeded' packet, with explicit source and destination
- * addresses.
- *
- * This function may be used to send a response sometime after receiving the
- * packet for which this response is meant. The provided source and destination
- * addresses are used primarily to retain their zone information.
- *
- * @param p the input packet for which the 'time exceeded' should be sent,
- *          p->payload pointing to the IPv6 header
- * @param c ICMPv6 code for the time exceeded type
- * @param src_addr source address of the original packet, with zone information
- * @param dest_addr destination address of the original packet, with zone
- *                  information
- */
-void
-icmp6_time_exceeded_with_addrs(struct pbuf *p, enum icmp6_te_code c,
-    const ip6_addr_t *src_addr, const ip6_addr_t *dest_addr)
-{
-  icmp6_send_response_with_addrs(p, c, 0, ICMP6_TYPE_TE, src_addr, dest_addr);
-}
-
 /**
 * Send an icmpv6 'parameter problem' packet.
 *
- * This function must be used only in direct response to a packet that is being
- * received right now. Otherwise, address zones would be lost and the calculated
- * offset would be wrong (calculated against ip6_current_header()).
- *
 * @param p the input packet for which the 'param problem' should be sent,
 *          p->payload pointing to the IP header
 * @param c ICMPv6 code for the param problem type
 * @param pointer the pointer to the byte where the parameter is found
 */
 void
-icmp6_param_problem(struct pbuf *p, enum icmp6_pp_code c, const void *pointer)
+icmp6_param_problem(struct pbuf *p, enum icmp6_pp_code c, u32_t pointer)
 {
-  u32_t pointer_u32 = (u32_t)((const u8_t *)pointer - (const u8_t *)ip6_current_header());
-  icmp6_send_response(p, c, pointer_u32, ICMP6_TYPE_PP);
+  icmp6_send_response(p, c, pointer, ICMP6_TYPE_PP);
 }

 /**
 * Send an ICMPv6 packet in response to an incoming packet.
- * The packet is sent *to* ip_current_src_addr() on ip_current_netif().
 *
 * @param p the input packet for which the response should be sent,
 *          p->payload pointing to the IPv6 header
@@ -307,86 +270,14 @@ icmp6_param_problem(struct pbuf *p, enum icmp6_pp_code c, const void *pointer)
 */
 static void
 icmp6_send_response(struct pbuf *p, u8_t code, u32_t data, u8_t type)
-{
-  const struct ip6_addr *reply_src, *reply_dest;
-  struct netif *netif = ip_current_netif();
-
-  LWIP_ASSERT("icmpv6 packet not a direct response", netif != NULL);
-  reply_dest = ip6_current_src_addr();
-
-  /* Select an address to use as source. */
-  reply_src = ip_2_ip6(ip6_select_source_address(netif, reply_dest));
-  if (reply_src == NULL) {
-    ICMP6_STATS_INC(icmp6.rterr);
-    return;
-  }
-  icmp6_send_response_with_addrs_and_netif(p, code, data, type, reply_src, reply_dest, netif);
-}
-
-/**
- * Send an ICMPv6 packet in response to an incoming packet.
- *
- * Call this function if the packet is NOT sent as a direct response to an
- * incoming packet, but rather sometime later (e.g. for a fragment reassembly
- * timeout). The caller must provide the zoned source and destination addresses
- * from the original packet with the src_addr and dest_addr parameters. The
- * reason for this approach is that while the addresses themselves are part of
- * the original packet, their zone information is not, thus possibly resulting
- * in a link-local response being sent over the wrong link.
- *
- * @param p the input packet for which the response should be sent,
- *          p->payload pointing to the IPv6 header
- * @param code Code of the ICMPv6 header
- * @param data Additional 32-bit parameter in the ICMPv6 header
- * @param type Type of the ICMPv6 header
- * @param src_addr original source address
- * @param dest_addr original destination address
- */
-static void
-icmp6_send_response_with_addrs(struct pbuf *p, u8_t code, u32_t data, u8_t type,
-    const ip6_addr_t *src_addr, const ip6_addr_t *dest_addr)
-{
-  const struct ip6_addr *reply_src, *reply_dest;
-  struct netif *netif;
-
-  /* Get the destination address and netif for this ICMP message. */
-  LWIP_ASSERT("must provide both source and destination", src_addr != NULL);
-  LWIP_ASSERT("must provide both source and destination", dest_addr != NULL);
-
-  /* Special case, as ip6_current_xxx is either NULL, or points
-     to a different packet than the one that expired. */
-  IP6_ADDR_ZONECHECK(src_addr);
-  IP6_ADDR_ZONECHECK(dest_addr);
-  /* Swap source and destination for the reply. */
-  reply_dest = src_addr;
-  reply_src = dest_addr;
-  netif = ip6_route(reply_src, reply_dest);
-  if (netif == NULL) {
-    ICMP6_STATS_INC(icmp6.rterr);
-    return;
-  }
-  icmp6_send_response_with_addrs_and_netif(p, code, data, type, reply_src,
-    reply_dest, netif);
-}
-
-/**
- * Send an ICMPv6 packet (with srd/dst address and netif given).
- *
- * @param p the input packet for which the response should be sent,
- *          p->payload pointing to the IPv6 header
- * @param code Code of the ICMPv6 header
- * @param data Additional 32-bit parameter in the ICMPv6 header
- * @param type Type of the ICMPv6 header
- * @param reply_src source address of the packet to send
- * @param reply_dest destination address of the packet to send
- * @param netif netif to send the packet
- */
-static void
-icmp6_send_response_with_addrs_and_netif(struct pbuf *p, u8_t code, u32_t data, u8_t type,
-    const ip6_addr_t *reply_src, const ip6_addr_t *reply_dest, struct netif *netif)
 {
  struct pbuf *q;
  struct icmp6_hdr *icmp6hdr;
+  const ip6_addr_t *reply_src;
+  ip6_addr_t *reply_dest;
+  ip6_addr_t reply_src_local, reply_dest_local;
+  struct ip6_hdr *ip6hdr;
+  struct netif *netif;

  /* ICMPv6 header + IPv6 header + data */
  q = pbuf_alloc(PBUF_IP, sizeof(struct icmp6_hdr) + IP6_HLEN + LWIP_ICMP6_DATASIZE,
@@ -402,12 +293,46 @@ icmp6_send_response_with_addrs_and_netif(struct pbuf *p, u8_t code, u32_t data,
  icmp6hdr = (struct icmp6_hdr *)q->payload;
  icmp6hdr->type = type;
  icmp6hdr->code = code;
-  icmp6hdr->data = lwip_htonl(data);
+  icmp6hdr->data = data;

  /* copy fields from original packet */
  SMEMCPY((u8_t *)q->payload + sizeof(struct icmp6_hdr), (u8_t *)p->payload,
          IP6_HLEN + LWIP_ICMP6_DATASIZE);

+  /* Get the destination address and netif for this ICMP message. */
+  if ((ip_current_netif() == NULL) ||
+      ((code == ICMP6_TE_FRAG) && (type == ICMP6_TYPE_TE))) {
+    /* Special case, as ip6_current_xxx is either NULL, or points
+     * to a different packet than the one that expired.
+     * We must use the addresses that are stored in the expired packet. */
+    ip6hdr = (struct ip6_hdr *)p->payload;
+    /* copy from packed address to aligned address */
+    ip6_addr_copy(reply_dest_local, ip6hdr->src);
+    ip6_addr_copy(reply_src_local, ip6hdr->dest);
+    reply_dest = &reply_dest_local;
+    reply_src = &reply_src_local;
+    netif = ip6_route(reply_src, reply_dest);
+    if (netif == NULL) {
+      /* drop */
+      pbuf_free(q);
+      ICMP6_STATS_INC(icmp6.rterr);
+      return;
+    }
+  }
+  else {
+    netif = ip_current_netif();
+    reply_dest = ip6_current_src_addr();
+
+    /* Select an address to use as source. */
+    reply_src = ip_2_ip6(ip6_select_source_address(netif, reply_dest));
+    if (reply_src == NULL) {
+      /* drop */
+      pbuf_free(q);
+      ICMP6_STATS_INC(icmp6.rterr);
+      return;
+    }
+  }
+
  /* calculate checksum */
  icmp6hdr->chksum = 0;
 #if CHECKSUM_GEN_ICMP6
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
goldsimon	ea2f6fb57c	Add CHANGELOG for 2.0.2	2017-03-13 10:26:42 +01:00
Dirk Ziegelmeier	b307fea1b9	Rename "IPv6 mapped IPv4 addresses" to their correct name from RFC4191: "IPv4-mapped IPv6 address" (cherry picked from commit `4d8fec3b67`) Conflicts: src/core/ipv6/ip6.c	2017-03-13 09:28:46 +01:00
Joel Cunningham	c31bd404e2	Fix unit test with assumed congestion avoidance test_tcp_fast_rexmit_wraparound correctness relied on the congestion window being in congestion avoidance so that only a single TCP_MSS segment is sent upon ACKing the first segment. It's not known whether the test was relying tcp_alloc() to set ssthresh to 0 and thus start in congestion avoidance or if the test was working by accident until changes in `b90a54f989` This fixes the test by enforcing the requirement of starting in congestion avoidance Signed-off-by: goldsimon <goldsimon@gmx.de> (cherry picked from commit `8bf402fd67`)	2017-03-13 09:14:38 +01:00
goldsimon	0381849624	tcp unit tests: fixed that tcp_teardown() could lead to accessing a netif pointer that is not valid any more (netif added in test function stored on stack) (cherry picked from commit `e9e9ec23b8`)	2017-03-13 09:14:24 +01:00
goldsimon	19d56b4096	tcp: watch out for pcb->nrtx overflows and tcp_backoff indexing overflow (cherry picked from commit `7ffe5bfb3c`)	2017-03-13 09:14:23 +01:00
David van Moolenbroek	66db517a28	tcp: do not keep sending SYNs when getting ACKs If a locally generated TCP SYN packet is replied to with an ACK packet, lwIP immediately sends a RST packet followed by resending the SYN packet. This is expected, but on loopback interfaces the resent SYN packet may immediately get another ACK reply, typically when the other endpoint is in TIME_WAIT state (which ignores the RSTs). The result is an endless loop of SYN, ACK, RST packets. This patch applies the normal SYN retransmission limit in this scenario, such that the endless loop is limited to a brief storm. (cherry picked from commit `5827c168c2`)	2017-03-13 09:14:22 +01:00
Joel Cunningham	2452bc9336	bug #50476 : initialize ssthresh to TCP_SND_BUF This commit changes ssthresh to be the largest effective congestion window (amount of in-flight data). This follows the guidance of RFC 5681 which recommends setting ssthresh arbitrarily high. LwIP was previously using the receive window value at the end of the 3-way handshake and in the case of an active open where the receiver used window scaling and/or window auto-tuning, this resulted in a very small ssthresh value even though the window ramped up once the connection was established (cherry picked from commit `b90a54f989`)	2017-03-13 09:13:41 +01:00
Sylvain Rochet	2848b17e80	PPP: remove unused and confusing return values other than ERR_OK for ppp_connect and ppp_listen User should not use ppp_connect or ppp_listen return value to retry later, it must wait for the callback to be called. This is primarily done this way to have a consistent behavior with and without the holdoff feature. Remove returned error value from PPP link level API connect and listen callbacks because we are not using them anymore, then make ppp_connect or ppp_listen to always return ERR_OK, thus we are not breaking the PPP user API. We don't need the return code here, all PPP link level drivers can't fail at all (e.g. PPPoS) or retry if necessary (PPPoE and PPPoL2TP). (cherry picked from commit `e16d10ade6`)	2017-03-13 09:13:17 +01:00
goldsimon	c71c9882c2	arch.h: include <limits.h> if it exists (at least INT_MAX is used) (cherry picked from commit `aff1935e40`)	2017-03-13 09:13:07 +01:00
Dirk Ziegelmeier	40fbd6bc24	One enum icmp_te_type member is not in doxygen docs - fix it. (cherry picked from commit `927990d94e`)	2017-03-13 09:12:30 +01:00
goldsimon	df7485de1c	lwip_sendmsg/tcp: prevent PSH until all iovecs are enqueued (cherry picked from commit `1b3aaef525`)	2017-03-13 09:12:08 +01:00
goldsimon	fe6e1bd4af	httpd: LWIP_HTTPD_POST_MANUAL_WND: fixed double-free when httpd_post_data_recved is called nested from httpd_post_receive_data() (bug #50424 ) # Conflicts: # CHANGELOG	2017-03-01 22:15:59 +01:00
goldsimon	168fa1c38a	Fix compiling httpd for LWIP_HTTPD_SUPPORT_POST==1 (assigning int to u16_t)	2017-03-01 22:15:42 +01:00
goldsimon	f0975b3c59	make tcp apps depend on LWIP_CALLBACK_API, too	2017-03-01 22:15:18 +01:00
goldsimon	563932b888	tcp: fixed bug #50418 : LWIP_EVENT_API: fix invalid calbacks for SYN_RCVD pcb # Conflicts: # CHANGELOG	2017-03-01 22:15:07 +01:00
goldsimon	8849a443a4	pbuf_ref: assert-check for 'ref' overflow (cherry picked from commit `76763c9bcd`)	2017-02-27 12:31:13 +01:00
goldsimon	e318688195	Improved DNS_LOCAL_HOSTLIST interface (bug #50325 ) (cherry picked from commit `deaa6e9406`) Conflicts: CHANGELOG	2017-02-27 12:30:38 +01:00
goldsimon	fa8b6a92b4	Fix portable initialization of non-dynamic DNS_LOCAL_HOSTLIST (cherry picked from commit `19d63e6aa0`)	2017-02-27 12:30:30 +01:00
sg	2ca39c275a	LWIP_NETCONN_FULLDUPLEX: fixed shutdown during write (bug #50274 ) (cherry picked from commit `6dca664217`) Conflicts: CHANGELOG	2017-02-27 12:29:23 +01:00
Joel Cunningham	4d1d567ab7	Fix comment typo from bug #47485 tcp_close_shutdown_impl() should be tcp_close_shutdown_fin() (cherry picked from commit `0b257f71e7`)	2017-02-27 12:28:18 +01:00
goldsimon	8927cda2f8	For tiny targtes, LWIP_RAND is optional -> fix compile time checks (cherry picked from commit `693a74c286`)	2017-02-27 12:27:47 +01:00
Dirk Ziegelmeier	bc78251f4a	My documentation changes forced the usage of rand() function, which is not desired By default, the code that does NOT need LWIP_RAND() is active now (cherry picked from commit `06c84cb110`)	2017-02-27 12:27:30 +01:00
David van Moolenbroek	0a3e4cd10e	tcp: fix accept event on closed listening PCBs If LWIP_CALLBACK_API is not defined, but TCP_LISTEN_BACKLOG is, then the LWIP_EVENT_ACCEPT TCP event may be triggered for closed listening sockets. This case is just as disastrous for the event API as it is for the callback API, as there is no way for the event hook to tell whether the listening PCB is still around. Add the same protection against this case for TCP_LISTEN_BACKLOG as was already in place for LWIP_CALLBACK_API. Also remove one NULL check for LWIP_CALLBACK_API that had already become redundant for all callers, making the TCP_EVENT_ACCEPT code for that callback wrapper more in line with the rest of the wrappers. (cherry picked from commit `240cf62056`)	2017-02-27 12:25:52 +01:00
Dirk Ziegelmeier	76efa271e6	Implement task #14367 : Hooks need a better place to be defined We now have a #define for a header file name that is #included in every .c file that provides hooks.	2017-02-27 12:25:08 +01:00
goldsimon	b3293d903e	Fixed bug #47485 (tcp_close() should not fail on memory error) by retrying to send FIN from tcp_fasttmr (cherry picked from commit `bc07fd9db5`) Conflicts: CHANGELOG	2017-02-27 12:24:51 +01:00
Dirk Ziegelmeier	5ef8a3cb60	igmp.c: igmp_lookup_group() should be static (cherry picked from commit `702091d548`)	2017-02-27 12:23:39 +01:00
sg	01c2e43c5c	Fixed bug #44032 (LWIP_NETCONN_FULLDUPLEX: select might work on invalid/reused socket) by not allowing to reallocate a socket that has "select_waiting != 0" (cherry picked from commit `c1c470fc4c`)	2017-02-27 12:23:04 +01:00
goldsimon	0b7bef5420	http_add_connection: add connections to the front to be faster (and really fix bug #50059 ) (cherry picked from commit `ea093d3a53`)	2017-02-27 12:22:42 +01:00
goldsimon	3c4aec99a4	Fixed bug #50059 (httpd LWIP_HTTPD_SUPPORT_11_KEEPALIVE vs. LWIP_HTTPD_KILL_OLD_ON_CONNECTIONS_EXCEEDED) (cherry picked from commit `5743864744`)	2017-02-27 12:22:42 +01:00
Luc Revardel	dc38e21a70	Fix bug #50220 (mld6_leavegroup does not send ICMP6_TYPE_MLD, even if last reporter) Signed-off-by: sg <goldsimon@gmx.de> (cherry picked from commit `819bfbb943`)	2017-02-27 12:22:41 +01:00
David van Moolenbroek	d471e5f89e	Patch #9250 (slightly changed): fix source substitution in ip6_output_if() (broken in 2014 with `be75c483d0`) Signed-off-by: sg <goldsimon@gmx.de> (cherry picked from commit `fffd61c746`)	2017-02-27 12:22:03 +01:00
sg	99ef13f2be	Fixed bug #50090 (ast_unsent->oversize_left can become wrong value in tcp_write error path) (cherry picked from commit `21737f57e5`)	2017-02-27 12:21:31 +01:00
Dirk Ziegelmeier	bb2b2be454	Fix bug #50206 : UDP Netconn bind to IP6_ADDR_ANY fails The tests were in to catch user errors, but they seem to get in the way of application programming :-) The checks in *_send() remain active to catch when PCB source and destination address types do not match (cherry picked from commit `ff04c2046e`)	2017-02-27 12:20:01 +01:00
goldsimon	faa7a21a83	Fix comment on lwip_shutdown() (it's not unimplemented any more) (cherry picked from commit `4b091cfc2a`)	2017-02-27 12:19:28 +01:00
Axel Lin	d6e8e05edd	stats: Remove superfluous /t in end of stats display The debug message after the stats display looks odd because the /t in end of stats display. Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `2685d742e8`)	2017-02-27 12:19:08 +01:00
Dirk Ziegelmeier	0b299f96e9	Add CHANGELOG to lwIP HTML documentation (cherry picked from commit `ee3154999a`)	2017-02-27 12:18:26 +01:00
Dirk Ziegelmeier	777d54f0e4	Retry 1 to fix bug #50064 Accidentally used the wrong destination HW addr (cherry picked from commit `645ca84704`)	2017-02-27 12:17:41 +01:00
Dirk Ziegelmeier	8c6ac8eb59	Optimize my last fix in etharp.c, I missed the variable declaration at the beginning of the function (cherry picked from commit `7aaa888d1d`)	2017-02-27 12:17:41 +01:00
Dirk Ziegelmeier	4fc3770278	Remove special ARP reply optimization from etharp.c - Code duplication with etharp_raw() - No great effect on perfomance - May make reworking PBUF handling code more complicated (see bug #49914) - The check for p->type == PBUF_REF is a strange special case, too - Simon also voted to remove it (cherry picked from commit `47bac3c11f`)	2017-02-27 12:17:40 +01:00
Dirk Ziegelmeier	e53c84654e	Fix bug #50064 : Zero-copy RX: ARP reply fails with PBUF_REF Kept the optimized version intact, see discussion in savannah bug tracker (cherry picked from commit `199c38de29`)	2017-02-27 12:17:40 +01:00
sg	d0b0cf983e	fix compiling TCP unit tests with IPv6 enabled (cherry picked from commit `b198c877db`)	2017-02-27 12:17:39 +01:00
Axel Lin	90d68b41df	tcp_out: Use LWIP_MIN instead of open-coded for better readability Make the intention of code more clear by using LWIP_MIN instead of open-coded. Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `141b5def46`)	2017-02-27 12:16:17 +01:00
Axel Lin	e6756387b0	tcp_out: Fix comment for last_unsent->oversize_left and tcp_pcb.unsent_oversize Both last_unsent->unsent_oversize and tcp_pcb.unsent_oversized fields are not exist, fix the comments. Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `30aedfc3f7`)	2017-02-27 12:16:17 +01:00
Dirk Ziegelmeier	4fe1436904	Add some parentheses for better code readability in tcp_in.c (cherry picked from commit `df8e404abd`)	2017-02-27 12:16:16 +01:00
Dirk Ziegelmeier	1fdbda9700	Fix bug #50040 : pbuf_alloc(..., 65534, PBUF_RAM) succeeds Check for integer overflow when calculating memory allocation size (cherry picked from commit `9898d406bc`)	2017-02-27 12:16:16 +01:00
Dirk Ziegelmeier	fed15778dd	Minor typo fix in tcp_out.c (cherry picked from commit `0043bf78b6`)	2017-02-27 12:16:16 +01:00
Axel Lin	bbe91e356f	tcp_out: Fix oversize vs. space assertion test oversize_used is always 0 at this point, should test oversize instead. Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `e1598b0b11`)	2017-02-27 12:16:15 +01:00
Dirk Ziegelmeier	0a73e0ff30	Set lwIP version to 2.0.2 in doxygen script (cherry picked from commit `861dab5b22`)	2017-02-27 12:16:15 +01:00
Dirk Ziegelmeier	7ba2633ef0	Minor code readability improvement in mqtt.c (cherry picked from commit `5c58e25de5`)	2017-02-27 12:14:46 +01:00
Dirk Ziegelmeier	d860dd7655	Minor correction to last patch: Avoid #including socket.h in api_msg.c (cherry picked from commit `2b1ebda6f1`)	2017-02-27 12:13:27 +01:00
Knut Andre Tidemann	2694486309	lwip: fix broken default ICMPv6 handling of checksums. ICMPv6 should always have checksum generated for it as per RFC 3542 chapter 3.1. (cherry picked from commit `5e9df2c698`)	2017-02-27 12:13:26 +01:00
Dirk Ziegelmeier	cb97e27120	MQTT: Add check that WILL topic length must be > 0 (cherry picked from commit `52f448978f`)	2017-02-27 12:09:49 +01:00
Dirk Ziegelmeier	890c5982a1	MQTT: Fix possible bug in connect message generation that WILL flag can be set without appending a will message The boolean condition of setting the WILL flag differs from that of appending the will message Found by Axel Lin (I fixed it the same way as Axel suggested, but I wanted a different commit message) (cherry picked from commit `6d5ddb7139`)	2017-02-27 12:09:49 +01:00
Axel Lin	4deaebae44	mqtt: Slightly improve mqtt_create_request Mainly for better readability, also save NULL test while iterating the for loop. Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `a2915b7142`)	2017-02-27 12:09:49 +01:00
Axel Lin	5fe195c3d3	mqtt: Prevent NULL pointer dereference before assertion checking Signed-off-by: Axel Lin <axel.lin@ingics.com> (cherry picked from commit `7faa4bcbe2`)	2017-02-27 12:08:55 +01:00
Dirk Ziegelmeier	e5071daf45	Add MQTT to CHANGELOG (too late for 2.0.1 release...)	2017-01-10 10:42:25 +01:00
Dirk Ziegelmeier	980b219c28	Put 2.0.1 version tag in UPGRADING document	2017-01-10 10:42:23 +01:00
Erik Ekman	76b4365aaa	Remove duplicate netif_dhcp_data() macro Fix compilation of unit tests	2017-01-10 10:42:22 +01:00
Dirk Ziegelmeier	a5a4830b16	Set lwIP version to 2.0.1 RELEASE	2017-01-05 15:02:10 +01:00
Dirk Ziegelmeier	1a2a9a4e96	Merge branch 'master' into STABLE-2_0_0 # Conflicts: # src/include/lwip/init.h	2017-01-05 15:01:08 +01:00
Dirk Ziegelmeier	216bf89491	Set version to 2.0.0 release	2016-11-10 09:46:31 +01:00
Dirk Ziegelmeier	a68eddbd47	Merge branch 'master' into STABLE-2_0_0	2016-11-10 09:44:33 +01:00
goldsimon	fd096a5769	Set LWIP_VERSION_RC to RC2	2016-08-03 09:12:23 +02:00
goldsimon	15b75555a6	Merge branch 'master' into STABLE-2_0_0	2016-08-03 08:59:09 +02:00
sg	33955c636d	Set LWIP_VERSION_RC to RC1	2016-04-27 22:04:51 +02:00