scratch/lwip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PPP, PPPoE, PPPoL2TP: enforce disabling of silent and passive modes

Browse Source 
PPP is just the upper protocol for PPPoE and PPPoL2TP, meaning it is only
started once "E" or L2TP is established. Therefore waiting indefinitely
for LCP packets on the PPP side does not make sense at all, if the lower
level protocol is UP, PPP *MUST* comes up as well or we should restart from
the beginning.
This commit is contained in:
Sylvain Rochet
2016-07-02 21:10:24 +02:00
parent a99fe1fa32
commit f0dbba6406
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/netif/ppp/pppoe.c
View File

@@ -932,6 +932,8 @@ pppoe_connect(ppp_pcb *ppp, void *ctx)
lcp_wo->neg_asyncmap = 0;
lcp_wo->neg_pcompression = 0;
lcp_wo->neg_accompression = 0;
lcp_wo->passive = 0;
lcp_wo->silent = 0;
lcp_ao = &ppp->lcp_allowoptions;
lcp_ao->mru = sc->sc_ethif->mtu-PPPOE_HEADERLEN-2; /* two byte PPP protocol discriminator, then IP data */

2
src/netif/ppp/pppol2tp.c
View File

@@ -275,6 +275,8 @@ static err_t pppol2tp_connect(ppp_pcb *ppp, void *ctx) {
lcp_wo->neg_asyncmap = 0;
lcp_wo->neg_pcompression = 0;
lcp_wo->neg_accompression = 0;
lcp_wo->passive = 0;
lcp_wo->silent = 0;
lcp_ao = &ppp->lcp_allowoptions;
lcp_ao->mru = PPPOL2TP_DEFMRU;