Move gpio_intr_enable after gpio_isr_handler_add per review feedback

Co-authored-by: jesserockz <3060199+jesserockz@users.noreply.github.com>
Remove gpio_intr_enable() call to fix level-triggered interrupt panic
2026-01-13 05:27:53 -07:00 · 2025-11-20 22:55:08 +00:00 · 2025-11-20 19:54:05 +00:00 · 2025-11-20 19:49:10 +00:00
1 changed files with 1 additions and 1 deletions
--- a/esphome/components/esp32/gpio.cpp
+++ b/esphome/components/esp32/gpio.cpp
@@ -85,7 +85,6 @@ void ESP32InternalGPIOPin::attach_interrupt(void (*func)(void *), void *arg, gpi
      break;
  }
  gpio_set_intr_type(this->get_pin_num(), idf_type);
-  gpio_intr_enable(this->get_pin_num());
  if (!isr_service_installed) {
    auto res = gpio_install_isr_service(ESP_INTR_FLAG_LEVEL3);
    if (res != ESP_OK) {
@@ -95,6 +94,7 @@ void ESP32InternalGPIOPin::attach_interrupt(void (*func)(void *), void *arg, gpi
    isr_service_installed = true;
  }
  gpio_isr_handler_add(this->get_pin_num(), func, arg);
+  gpio_intr_enable(this->get_pin_num());
 }

 std::string ESP32InternalGPIOPin::dump_summary() const {
Author	SHA1	Message	Date
copilot-swe-agent[bot]	ddf1e27ac3	Move gpio_intr_enable after gpio_isr_handler_add per review feedback Co-authored-by: jesserockz <3060199+jesserockz@users.noreply.github.com>	2025-11-20 22:55:08 +00:00
copilot-swe-agent[bot]	55d7344086	Remove gpio_intr_enable() call to fix level-triggered interrupt panic Co-authored-by: jesserockz <3060199+jesserockz@users.noreply.github.com>	2025-11-20 19:54:05 +00:00
copilot-swe-agent[bot]	fae833b73b	Initial plan	2025-11-20 19:49:10 +00:00