[esp32_hosted] Replace sscanf with strtol for version parsing

esphome/components/esp32_hosted/update/esp32_hosted_update.cpp

@@ -34,14 +34,29 @@ static const char *const ESP_HOSTED_VERSION_STR = STRINGIFY(ESP_HOSTED_VERSION_M
     ESP_HOSTED_VERSION_MINOR_1) "." STRINGIFY(ESP_HOSTED_VERSION_PATCH_1);
 
 #ifdef USE_ESP32_HOSTED_HTTP_UPDATE
+// Parse an integer from str, advancing ptr past the number
+// Returns false if no digits were parsed
+static bool parse_int(const char *&ptr, int &value) {
+  char *end;
+  value = static_cast<int>(strtol(ptr, &end, 10));
+  if (end == ptr)
+    return false;
+  ptr = end;
+  return true;
+}
+
 // Parse version string "major.minor.patch" into components
-// Returns true if parsing succeeded
+// Returns true if at least major.minor was parsed
 static bool parse_version(const std::string &version_str, int &major, int &minor, int &patch) {
   major = minor = patch = 0;
-  if (sscanf(version_str.c_str(), "%d.%d.%d", &major, &minor, &patch) >= 2) {  // NOLINT
-    return true;
-  }
-  return false;
+  const char *ptr = version_str.c_str();
+
+  if (!parse_int(ptr, major) || *ptr++ != '.' || !parse_int(ptr, minor))
+    return false;
+  if (*ptr == '.')
+    parse_int(++ptr, patch);
+
+  return true;
 }
 
 // Compare two versions, returns:

script/ci-custom.py

@@ -756,28 +756,6 @@ def lint_no_sprintf(fname, match):
     )
 
 
-@lint_re_check(
-    # Match scanf family functions: scanf, sscanf, fscanf, vscanf, vsscanf, vfscanf
-    # Also match std:: prefixed versions
-    # [^\w] ensures we match function calls, not substrings
-    r"[^\w]((?:std::)?v?[fs]?scanf)\s*\(" + CPP_RE_EOL,
-    include=cpp_include,
-)
-def lint_no_scanf(fname, match):
-    func = match.group(1)
-    return (
-        f"{highlight(func + '()')} is not allowed in new ESPHome code. The scanf family "
-        f"pulls in ~7KB flash on ESP8266 and ~9KB on ESP32, and ESPHome doesn't otherwise "
-        f"need this code.\n"
-        f"Please use alternatives:\n"
-        f"  - {highlight('parse_number<T>(str)')} for parsing integers/floats from strings\n"
-        f"  - {highlight('strtol()/strtof()')} for C-style number parsing with error checking\n"
-        f"  - {highlight('parse_hex()')} for hex string parsing\n"
-        f"  - Manual parsing for simple fixed formats\n"
-        f"(If strictly necessary, add `// NOLINT` to the end of the line)"
-    )
-
-
 @lint_content_find_check(
     "ESP_LOG",
     include=["*.h", "*.tcc"],