mirror/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-01-10 04:00:51 -07:00
Code Issues Packages Projects Releases Wiki Activity

[voice_assistant] Reduce heap allocation with stack-based timer formatting (#13001)

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-05 17:14:33 -10:00
committed by GitHub
parent b402e403a0
commit 0290ed5d23
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
esphome/components/voice_assistant/voice_assistant.cpp
View File

@@ -866,11 +866,12 @@ void VoiceAssistant::on_timer_event(const api::VoiceAssistantTimerEventResponse
.is_active = msg.is_active,
};
this->timers_[timer.id] = timer;
char timer_buf[Timer::TO_STR_BUFFER_SIZE];
ESP_LOGD(TAG,
"Timer Event\n"
" Type: %" PRId32 "\n"
" %s",
msg.event_type, timer.to_string().c_str());
msg.event_type, timer.to_str(timer_buf));
switch (msg.event_type) {
case api::enums::VOICE_ASSISTANT_TIMER_STARTED:

15
esphome/components/voice_assistant/voice_assistant.h
View File

@@ -23,6 +23,7 @@
#endif
#include "esphome/components/socket/socket.h"
#include <span>
#include <unordered_map>
#include <vector>
@@ -71,10 +72,18 @@ struct Timer {
uint32_t seconds_left;
bool is_active;
/// Buffer size for to_str() - sufficient for typical timer names
static constexpr size_t TO_STR_BUFFER_SIZE = 128;
/// Format to buffer, returns pointer to buffer (may truncate long names)
const char *to_str(std::span<char, TO_STR_BUFFER_SIZE> buffer) const {
snprintf(buffer.data(), buffer.size(),
"Timer(id=%s, name=%s, total_seconds=%" PRIu32 ", seconds_left=%" PRIu32 ", is_active=%s)",
this->id.c_str(), this->name.c_str(), this->total_seconds, this->seconds_left, YESNO(this->is_active));
return buffer.data();
}
std::string to_string() const {
return str_sprintf("Timer(id=%s, name=%s, total_seconds=%" PRIu32 ", seconds_left=%" PRIu32 ", is_active=%s)",
this->id.c_str(), this->name.c_str(), this->total_seconds, this->seconds_left,
YESNO(this->is_active));
char buffer[TO_STR_BUFFER_SIZE];
return this->to_str(buffer);
}
};