scratch/lwip
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PPP: removed ppp_delete(), merged with ppp_free()

Browse Source 
The only benefit of ppp_delete() call was about having a persistent
netif interface. netif was moved out of PPP pcb so we don't need
ppp_delete() anymore, second step in simplifying the weird
new/open/free/delete PPP API.
This commit is contained in:
Sylvain Rochet
2015-02-14 22:22:08 +01:00
parent 318e752fd6
commit 17c6be6a9b
4 changed files with 13 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/lwip/pppapi.h
View File

@@ -136,7 +136,7 @@ ppp_pcb *pppapi_over_l2tp_create(struct netif *pppif, struct netif *netif, ip_ad
int pppapi_open(ppp_pcb *pcb, u16_t holdoff);
int pppapi_close(ppp_pcb *pcb);
void pppapi_sighup(ppp_pcb *pcb);
int pppapi_delete(ppp_pcb *pcb);
int pppapi_free(ppp_pcb *pcb);
int pppapi_ioctl(ppp_pcb *pcb, int cmd, void *arg);
#if LWIP_NETIF_STATUS_CALLBACK
void pppapi_set_netif_statuscallback(ppp_pcb *pcb, netif_status_callback_fn status_callback);

17
src/include/netif/ppp/ppp.h
View File

@@ -573,21 +573,6 @@ int ppp_close(ppp_pcb *pcb);
*/
void ppp_sighup(ppp_pcb *pcb);
/*
* Free the control block, clean everything except the PPP PCB itself
* and the netif, it allows you to change the underlying PPP protocol
* (eg. from PPPoE to PPPoS to switch from DSL to GPRS) without losing
* your PPP and netif handlers.
*
* This can only be called if PPP is in the dead phase.
*
* You must use ppp_close() before if you wish to terminate
* an established PPP session.
*
* Return 0 on success, an error code on failure.
*/
int ppp_free(ppp_pcb *pcb);
/*
* Release the control block.
*
@@ -598,7 +583,7 @@ int ppp_free(ppp_pcb *pcb);
*
* Return 0 on success, an error code on failure.
*/
int ppp_delete(ppp_pcb *pcb);
int ppp_free(ppp_pcb *pcb);
/*
* Get and set parameters for the given connection.