From da95cc30d3818eea5a44aa10bdf34d947d3290f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kuba=20Szczodrzy=C5=84ski?= <kuba@szczodrzynski.pl>
Date: Mon, 2 Jan 2023 16:02:47 +0100
Subject: [PATCH] [realtek-ambz] Move to GNU++11, update TODO.md

---
 TODO.md                                | 14 ++++++++++++--
 builder/frameworks/realtek-ambz-sdk.py |  3 +--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/TODO.md b/TODO.md
index fe12c46..7017d3a 100644
--- a/TODO.md
+++ b/TODO.md
@@ -2,6 +2,16 @@
 
 ## General
 
+### Environment stability
+
+Do not publish *any* SDK functions, macros, defines and includes. Define only what's needed in LT's public headers (like `Arduino.h`). Everything else is taken from `sdk_extern.h` or `WVariant.h` (TODO decide whether to keep WV public / make both private / get rid of WV and use sdk_extern only). Private headers are included by LT's .cpp units (maybe a dedicated private header that would include sdk_extern + Arduino.h).
+
+Developers wanting to use SDK functions need to include them.
+
+Explicit is better than implicit.
+
+- consider moving to C++17 (GNU)? or any newer than C++11
+
 ### New families
 
 - BL602
@@ -10,6 +20,7 @@
 - RTL8720D
 - W600 and/or W800
 - LN8825
+- BK7231Q
 - host-native family
 
 ### Tools
@@ -30,7 +41,6 @@
 
 ## BK7231
 
-- implement OTA
 - fix WiFi on BK7231N, test other functionality
 - fix SSL (mbedTLS)
 - I2C (Wire)
@@ -39,5 +49,5 @@
 
 ## RTL8710B
 
-- move to GNU++11 (and verify that it works) - take all stdio functions from stdio.h
+- take all stdio functions from stdio.h
 - rewrite most of Wiring (it was copied from `ambd_arduino`, and is ugly)
diff --git a/builder/frameworks/realtek-ambz-sdk.py b/builder/frameworks/realtek-ambz-sdk.py
index 3721300..328cefe 100644
--- a/builder/frameworks/realtek-ambz-sdk.py
+++ b/builder/frameworks/realtek-ambz-sdk.py
@@ -31,7 +31,7 @@ env.Append(
     ],
     CXXFLAGS=[
         # borrowed from RtlDuino/development/rtl87xx/platform.txt
-        "-std=c++11",
+        "-std=gnu++11",
         "-MMD",
         "-fno-exceptions",
         "-fno-rtti",
@@ -100,7 +100,6 @@ env.AddLibrary(
         "+<component/common/api/lwip_netconf.c>",
         "+<component/common/drivers/wlan/realtek/src/osdep/lwip_intf.c>",
         "+<component/common/network/dhcp/dhcps.c>",
-        "+<component/common/network/sntp/sntp.c>",
         "+<component/common/network/ssl/ssl_ram_map/ssl_ram_map.c>",
         "+<component/os/freertos/freertos_v8.1.2/Source/portable/MemMang/heap_5.c>",
         "+<component/os/freertos/freertos_v8.1.2/Source/portable/GCC/ARM_CM4F/port.c>",