From 9c445648c222ce6eda06536c5f4c5851697362af Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Thu, 19 Feb 2026 19:12:47 -0600 Subject: [PATCH] [e131] Move read_() to header for inlining --- esphome/components/e131/e131.cpp | 10 ---------- esphome/components/e131/e131.h | 10 +++++++++- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/esphome/components/e131/e131.cpp b/esphome/components/e131/e131.cpp index 04a4fc0d03..a1cab0be52 100644 --- a/esphome/components/e131/e131.cpp +++ b/esphome/components/e131/e131.cpp @@ -84,16 +84,6 @@ void E131Component::loop() { } } -ssize_t E131Component::read_(uint8_t *buf, size_t len) { -#if defined(USE_SOCKET_IMPL_BSD_SOCKETS) || defined(USE_SOCKET_IMPL_LWIP_SOCKETS) - return this->socket_->read(buf, len); -#elif defined(USE_SOCKET_IMPL_LWIP_TCP) - if (!this->udp_.parsePacket()) - return -1; - return this->udp_.read(buf, len); -#endif -} - void E131Component::add_effect(E131AddressableLightEffect *light_effect) { if (std::find(light_effects_.begin(), light_effects_.end(), light_effect) != light_effects_.end()) { return; diff --git a/esphome/components/e131/e131.h b/esphome/components/e131/e131.h index 16976a66ef..8f0b808946 100644 --- a/esphome/components/e131/e131.h +++ b/esphome/components/e131/e131.h @@ -46,7 +46,15 @@ class E131Component : public esphome::Component { void set_method(E131ListenMethod listen_method) { this->listen_method_ = listen_method; } protected: - ssize_t read_(uint8_t *buf, size_t len); + inline ssize_t read_(uint8_t *buf, size_t len) { +#if defined(USE_SOCKET_IMPL_BSD_SOCKETS) || defined(USE_SOCKET_IMPL_LWIP_SOCKETS) + return this->socket_->read(buf, len); +#elif defined(USE_SOCKET_IMPL_LWIP_TCP) + if (!this->udp_.parsePacket()) + return -1; + return this->udp_.read(buf, len); +#endif + } bool packet_(const uint8_t *data, size_t len, int &universe, E131Packet &packet); bool process_(int universe, const E131Packet &packet); bool join_igmp_groups_();