mirror of
https://github.com/acme-dns/acme-dns.git
synced 2026-02-21 17:15:35 -07:00
* Refactor core * Re-added tests * Small fixes * Add tests for acmetxt cidrslice and util funcs * Remove the last dangling reference to old logging package * Refactoring (#327) * chore: enable more linters and fix linter issues * ci: enable linter checks on all branches and disable recurring checks recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;) * chore: update packages * Revert "chore: update packages" This reverts commit 30250bf28c4b39e9e5b3af012a4e28ab036bf9af. * chore: manually upgrade some packages * Updated dependencies, wrote changelog entry and fixed namespace for release * Refactoring - improving coverage (#371) * Increase code coverage in acmedns * More testing of ReadConfig() and its fallback mechanism * Found that if someone put a '"' double quote into the filename that we configure zap to log to, it would cause the the JSON created to be invalid. I have replaced the JSON string with proper config * Better handling of config options for api.TLS - we now error on an invalid value instead of silently failing. added a basic test for api.setupTLS() (to increase test coverage) * testing nameserver isOwnChallenge and isAuthoritative methods * add a unit test for nameserver answerOwnChallenge * fix linting errors * bump go and golangci-lint versions in github actions * Update golangci-lint.yml Bumping github-actions workflow versions to accommodate some changes in upstream golanci-lint * Bump Golang version to 1.23 (currently the oldest supported version) Bump golanglint-ci to 2.0.2 and migrate the config file. This should resolve the math/rand/v2 issue * bump golanglint-ci action version * Fixing up new golanglint-ci warnings and errors --------- Co-authored-by: Joona Hoikkala <5235109+joohoi@users.noreply.github.com> * Minor refactoring, error returns and e2e testing suite * Add a few tests * Fix linter and umask setting * Update github actions * Refine concurrency configuration for GitHub actions * HTTP timeouts to API, and self-validation mutex to nameserver ops --------- Co-authored-by: Florian Ritterhoff <32478819+fritterhoff@users.noreply.github.com> Co-authored-by: Jason Playne <jason@jasonplayne.com>
151 lines
2.8 KiB
Go
151 lines
2.8 KiB
Go
package nameserver
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func TestNameserver_isOwnChallenge(t *testing.T) {
|
|
type fields struct {
|
|
OwnDomain string
|
|
}
|
|
type args struct {
|
|
name string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want bool
|
|
}{
|
|
{
|
|
name: "is own challenge",
|
|
fields: fields{
|
|
OwnDomain: "some-domain.test.",
|
|
},
|
|
args: args{
|
|
name: "_acme-challenge.some-domain.test.",
|
|
},
|
|
want: true,
|
|
},
|
|
{
|
|
name: "challenge but not for us",
|
|
fields: fields{
|
|
OwnDomain: "some-domain.test.",
|
|
},
|
|
args: args{
|
|
name: "_acme-challenge.some-other-domain.test.",
|
|
},
|
|
want: false,
|
|
},
|
|
{
|
|
name: "not a challenge",
|
|
fields: fields{
|
|
OwnDomain: "domain.test.",
|
|
},
|
|
args: args{
|
|
name: "domain.test.",
|
|
},
|
|
want: false,
|
|
},
|
|
{
|
|
name: "other request challenge",
|
|
fields: fields{
|
|
OwnDomain: "domain.test.",
|
|
},
|
|
args: args{
|
|
name: "my-domain.test.",
|
|
},
|
|
want: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
n := &Nameserver{
|
|
OwnDomain: tt.fields.OwnDomain,
|
|
}
|
|
if got := n.isOwnChallenge(tt.args.name); got != tt.want {
|
|
t.Errorf("isOwnChallenge() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNameserver_isAuthoritative(t *testing.T) {
|
|
type fields struct {
|
|
OwnDomain string
|
|
Domains map[string]Records
|
|
}
|
|
type args struct {
|
|
q dns.Question
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want bool
|
|
}{
|
|
{
|
|
name: "is authoritative own domain",
|
|
fields: fields{
|
|
OwnDomain: "auth.domain.",
|
|
},
|
|
args: args{
|
|
q: dns.Question{Name: "auth.domain."},
|
|
},
|
|
want: true,
|
|
},
|
|
{
|
|
name: "is authoritative other domain",
|
|
fields: fields{
|
|
OwnDomain: "auth.domain.",
|
|
Domains: map[string]Records{
|
|
"other-domain.test.": {Records: nil},
|
|
},
|
|
},
|
|
args: args{
|
|
q: dns.Question{Name: "other-domain.test."},
|
|
},
|
|
want: true,
|
|
},
|
|
{
|
|
name: "is authoritative sub domain",
|
|
fields: fields{
|
|
OwnDomain: "auth.domain.",
|
|
Domains: map[string]Records{
|
|
"other-domain.test.": {Records: nil},
|
|
},
|
|
},
|
|
args: args{
|
|
q: dns.Question{Name: "sub.auth.domain."},
|
|
},
|
|
want: true,
|
|
},
|
|
{
|
|
name: "is not authoritative own",
|
|
fields: fields{
|
|
OwnDomain: "auth.domain.",
|
|
Domains: map[string]Records{
|
|
"other-domain.test.": {Records: nil},
|
|
},
|
|
},
|
|
args: args{
|
|
q: dns.Question{Name: "special-auth.domain."},
|
|
},
|
|
want: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
n := &Nameserver{
|
|
OwnDomain: tt.fields.OwnDomain,
|
|
Domains: tt.fields.Domains,
|
|
}
|
|
if got := n.isAuthoritative(tt.args.q.Name); got != tt.want {
|
|
t.Errorf("isAuthoritative() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|