mirror of
https://github.com/acme-dns/acme-dns.git
synced 2026-02-21 09:15:30 -07:00
* Refactor core * Re-added tests * Small fixes * Add tests for acmetxt cidrslice and util funcs * Remove the last dangling reference to old logging package * Refactoring (#327) * chore: enable more linters and fix linter issues * ci: enable linter checks on all branches and disable recurring checks recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;) * chore: update packages * Revert "chore: update packages" This reverts commit 30250bf28c4b39e9e5b3af012a4e28ab036bf9af. * chore: manually upgrade some packages * Updated dependencies, wrote changelog entry and fixed namespace for release * Refactoring - improving coverage (#371) * Increase code coverage in acmedns * More testing of ReadConfig() and its fallback mechanism * Found that if someone put a '"' double quote into the filename that we configure zap to log to, it would cause the the JSON created to be invalid. I have replaced the JSON string with proper config * Better handling of config options for api.TLS - we now error on an invalid value instead of silently failing. added a basic test for api.setupTLS() (to increase test coverage) * testing nameserver isOwnChallenge and isAuthoritative methods * add a unit test for nameserver answerOwnChallenge * fix linting errors * bump go and golangci-lint versions in github actions * Update golangci-lint.yml Bumping github-actions workflow versions to accommodate some changes in upstream golanci-lint * Bump Golang version to 1.23 (currently the oldest supported version) Bump golanglint-ci to 2.0.2 and migrate the config file. This should resolve the math/rand/v2 issue * bump golanglint-ci action version * Fixing up new golanglint-ci warnings and errors --------- Co-authored-by: Joona Hoikkala <5235109+joohoi@users.noreply.github.com> * Minor refactoring, error returns and e2e testing suite * Add a few tests * Fix linter and umask setting * Update github actions * Refine concurrency configuration for GitHub actions * HTTP timeouts to API, and self-validation mutex to nameserver ops --------- Co-authored-by: Florian Ritterhoff <32478819+fritterhoff@users.noreply.github.com> Co-authored-by: Jason Playne <jason@jasonplayne.com>
136 lines
3.6 KiB
Go
136 lines
3.6 KiB
Go
package api
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/joohoi/acme-dns/pkg/acmedns"
|
|
|
|
"github.com/google/uuid"
|
|
)
|
|
|
|
func TestGetValidUsername(t *testing.T) {
|
|
v1, _ := uuid.Parse("a097455b-52cc-4569-90c8-7a4b97c6eba8")
|
|
for i, test := range []struct {
|
|
uname string
|
|
output uuid.UUID
|
|
shouldErr bool
|
|
}{
|
|
{"a097455b-52cc-4569-90c8-7a4b97c6eba8", v1, false},
|
|
{"a-97455b-52cc-4569-90c8-7a4b97c6eba8", uuid.UUID{}, true},
|
|
{"", uuid.UUID{}, true},
|
|
{"&!#!25123!%!'%", uuid.UUID{}, true},
|
|
} {
|
|
ret, err := getValidUsername(test.uname)
|
|
if test.shouldErr && err == nil {
|
|
t.Errorf("Test %d: Expected error, but there was none", i)
|
|
}
|
|
if !test.shouldErr && err != nil {
|
|
t.Errorf("Test %d: Expected no error, but got [%v]", i, err)
|
|
}
|
|
if ret != test.output {
|
|
t.Errorf("Test %d: Expected return value %v, but got %v", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidKey(t *testing.T) {
|
|
for i, test := range []struct {
|
|
key string
|
|
output bool
|
|
}{
|
|
{"", false},
|
|
{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true},
|
|
{"aaaaaaaa-aaa-aaaaaa-aaaaaaaa-aaa_aacaaaa", true},
|
|
{"aaaaaaaa-aaa-aaaaaa#aaaaaaaa-aaa_aacaaaa", false},
|
|
{"aaaaaaaa-aaa-aaaaaa-aaaaaaaa-aaa_aacaaaaa", false},
|
|
} {
|
|
ret := validKey(test.key)
|
|
if ret != test.output {
|
|
t.Errorf("Test %d: Expected return value %t, but got %t", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetValidSubdomain(t *testing.T) {
|
|
for i, test := range []struct {
|
|
subdomain string
|
|
output bool
|
|
}{
|
|
{"a097455b-52cc-4569-90c8-7a4b97c6eba8", true},
|
|
{"a-97455b-52cc-4569-90c8-7a4b97c6eba8", true},
|
|
{"foo.example.com", false},
|
|
{"foo-example-com", true},
|
|
{"", false},
|
|
{"&!#!25123!%!'%", false},
|
|
} {
|
|
ret := validSubdomain(test.subdomain)
|
|
if ret != test.output {
|
|
t.Errorf("Test %d: Expected return value %t, but got %t", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidTXT(t *testing.T) {
|
|
for i, test := range []struct {
|
|
txt string
|
|
output bool
|
|
}{
|
|
{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true},
|
|
{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", false},
|
|
{"aaaaaaaaaaaaaaaaaaaaaaaaaaaa#aaaaaaaaaaaaaa", false},
|
|
{"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", false},
|
|
{"", false},
|
|
} {
|
|
ret := validTXT(test.txt)
|
|
if ret != test.output {
|
|
t.Errorf("Test %d: Expected return value %t, but got %t", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCorrectPassword(t *testing.T) {
|
|
for i, test := range []struct {
|
|
pw string
|
|
hash string
|
|
output bool
|
|
}{
|
|
{"PUrNTjU24JYNEOCeS2JcjaJGv1sinT80oV9--dpX",
|
|
"$2a$10$ldVoGU5yrdlbPzuPUbUfleVovGjaRelP9tql0IltVUJk778gf.2tu",
|
|
true},
|
|
{"PUrNTjU24JYNEOCeS2JcjaJGv1sinT80oV9--dpX",
|
|
"$2a$10$ldVoGU5yrdlbPzuPUbUfleVovGjaRelP9tql0IltVUJk778gf.2t",
|
|
false},
|
|
{"PUrNTjU24JYNEOCeS2JcjaJGv1sinT80oV9--dp",
|
|
"$2a$10$ldVoGU5yrdlbPzuPUbUfleVovGjaRelP9tql0IltVUJk778gf.2tu",
|
|
false},
|
|
{"", "", false},
|
|
} {
|
|
ret := acmedns.CorrectPassword(test.pw, test.hash)
|
|
if ret != test.output {
|
|
t.Errorf("Test %d: Expected return value %t, but got %t", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetValidCIDRMasks(t *testing.T) {
|
|
for i, test := range []struct {
|
|
input acmedns.Cidrslice
|
|
output acmedns.Cidrslice
|
|
}{
|
|
{acmedns.Cidrslice{"10.0.0.1/24"}, acmedns.Cidrslice{"10.0.0.1/24"}},
|
|
{acmedns.Cidrslice{"invalid", "127.0.0.1/32"}, acmedns.Cidrslice{"127.0.0.1/32"}},
|
|
{acmedns.Cidrslice{"2002:c0a8::0/32", "8.8.8.8/32"}, acmedns.Cidrslice{"2002:c0a8::0/32", "8.8.8.8/32"}},
|
|
} {
|
|
ret := test.input.ValidEntries()
|
|
if len(ret) == len(test.output) {
|
|
for i, v := range ret {
|
|
if v != test.output[i] {
|
|
t.Errorf("Test %d: Expected %q but got %q", i, test.output, ret)
|
|
}
|
|
}
|
|
} else {
|
|
t.Errorf("Test %d: Expected %q but got %q", i, test.output, ret)
|
|
}
|
|
}
|
|
}
|